Files
UnrealEngineUWP/Engine/Source/Editor/BlueprintGraph/Private/K2Node_MakeContainer.cpp

666 lines
20 KiB
C++
Raw Normal View History

// Copyright Epic Games, Inc. All Rights Reserved.
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
#include "K2Node_MakeContainer.h"
#include "EdGraph/EdGraphPin.h"
#include "Engine/Blueprint.h"
#include "Framework/Commands/UIAction.h"
#include "Framework/MultiBox/MultiBoxBuilder.h"
#include "EdGraphSchema_K2.h"
#include "EdGraph/EdGraphNodeUtils.h"
#include "Kismet2/BlueprintEditorUtils.h"
#include "ScopedTransaction.h"
#include "EdGraphUtilities.h"
Merging //UE5/Dev-LargeWorldCoordinates [at] 18802167 to //UE5/Release-5.0 Blueprint real number support. This change deprecates the use the of "float" and "double" types in Blueprints in favor of a new "real". By default, "real" is back by a double precision floating point number. However, it can be single precision if the number is a native float property or function parameter. This distinction won't be visible to the Blueprint user: in both instances, they'll be represented by "real" pin types. During deserialization, we'll automatically convert Blueprint pin types to use real/doubles, unless they're used to represent native code (including delegate signatures). One consequence of this change is that we need to perform implicit casts between single and double precision real numbers. During Blueprint compilation, the compiler will detect points in the graph for when either a widening or narrowing conversion needs to occur. Subsequently, the script bytecode will contain a new cast instruction that performs the conversion. This also works on container types, but each entry in the container will have to be converted. This can introduce unwanted overhead for large containers that are frequently passed between Blueprint and native code. The scope of this change affects Blueprints used by Gameplay, Animation, Control Rig, and UMG. #rb marc.audy (serialization changes) #jira UE-116484 #preflight 61f8bdd5a2514ba12ff7bdfc #ROBOMERGE-AUTHOR: dave.jones2 #ROBOMERGE-SOURCE: CL 18809077 in //UE5/Release-5.0/... via CL 18809455 via CL 18822548 #ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545) [CL 18823569 by dave jones2 in ue5-main branch]
2022-02-02 05:50:50 -05:00
#include "KismetCastingUtils.h"
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
#include "KismetCompiledFunctionContext.h"
#include "KismetCompilerMisc.h"
#include "BlueprintNodeSpawner.h"
#include "EditorCategoryUtils.h"
#include "BlueprintActionDatabaseRegistrar.h"
#define LOCTEXT_NAMESPACE "MakeArrayNode"
void FKCHandler_MakeContainer::RegisterNets(FKismetFunctionContext& Context, UEdGraphNode* Node)
{
UK2Node_MakeContainer* ContainerNode = CastChecked<UK2Node_MakeContainer>(Node);
UEdGraphPin* OutputPin = ContainerNode->GetOutputPin();
FNodeHandlingFunctor::RegisterNets(Context, Node);
// Create a local term to drop the container into
FBPTerminal* Term = Context.CreateLocalTerminalFromPinAutoChooseScope(OutputPin, Context.NetNameMap->MakeValidName(OutputPin));
Term->bPassedByReference = false;
Term->Source = Node;
Context.NetMap.Add(OutputPin, Term);
}
void FKCHandler_MakeContainer::Compile(FKismetFunctionContext& Context, UEdGraphNode* Node)
{
Merging //UE5/Dev-LargeWorldCoordinates [at] 18802167 to //UE5/Release-5.0 Blueprint real number support. This change deprecates the use the of "float" and "double" types in Blueprints in favor of a new "real". By default, "real" is back by a double precision floating point number. However, it can be single precision if the number is a native float property or function parameter. This distinction won't be visible to the Blueprint user: in both instances, they'll be represented by "real" pin types. During deserialization, we'll automatically convert Blueprint pin types to use real/doubles, unless they're used to represent native code (including delegate signatures). One consequence of this change is that we need to perform implicit casts between single and double precision real numbers. During Blueprint compilation, the compiler will detect points in the graph for when either a widening or narrowing conversion needs to occur. Subsequently, the script bytecode will contain a new cast instruction that performs the conversion. This also works on container types, but each entry in the container will have to be converted. This can introduce unwanted overhead for large containers that are frequently passed between Blueprint and native code. The scope of this change affects Blueprints used by Gameplay, Animation, Control Rig, and UMG. #rb marc.audy (serialization changes) #jira UE-116484 #preflight 61f8bdd5a2514ba12ff7bdfc #ROBOMERGE-AUTHOR: dave.jones2 #ROBOMERGE-SOURCE: CL 18809077 in //UE5/Release-5.0/... via CL 18809455 via CL 18822548 #ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545) [CL 18823569 by dave jones2 in ue5-main branch]
2022-02-02 05:50:50 -05:00
TArray<FBPTerminal*> RHSTerms;
for (UEdGraphPin* Pin : Node->Pins)
{
if (Pin && Pin->Direction == EGPD_Input)
{
FBPTerminal** InputTerm = Context.NetMap.Find(FEdGraphUtilities::GetNetFromPin(Pin));
if (InputTerm)
{
FBPTerminal* RHSTerm = *InputTerm;
{
using namespace UE::KismetCompiler;
TOptional<TPair<FBPTerminal*, EKismetCompiledStatementType>> ImplicitCastEntry =
CastingUtils::InsertImplicitCastStatement(Context, Pin, RHSTerm);
if (ImplicitCastEntry)
{
RHSTerm = ImplicitCastEntry->Get<0>();
}
}
RHSTerms.Add(RHSTerm);
}
}
}
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
UK2Node_MakeContainer* ContainerNode = CastChecked<UK2Node_MakeContainer>(Node);
UEdGraphPin* OutputPin = ContainerNode->GetOutputPin();
FBPTerminal** ContainerTerm = Context.NetMap.Find(OutputPin);
check(ContainerTerm);
FBlueprintCompiledStatement& CreateContainerStatement = Context.AppendStatementForNode(Node);
CreateContainerStatement.Type = CompiledStatementType;
CreateContainerStatement.LHS = *ContainerTerm;
Merging //UE5/Dev-LargeWorldCoordinates [at] 18802167 to //UE5/Release-5.0 Blueprint real number support. This change deprecates the use the of "float" and "double" types in Blueprints in favor of a new "real". By default, "real" is back by a double precision floating point number. However, it can be single precision if the number is a native float property or function parameter. This distinction won't be visible to the Blueprint user: in both instances, they'll be represented by "real" pin types. During deserialization, we'll automatically convert Blueprint pin types to use real/doubles, unless they're used to represent native code (including delegate signatures). One consequence of this change is that we need to perform implicit casts between single and double precision real numbers. During Blueprint compilation, the compiler will detect points in the graph for when either a widening or narrowing conversion needs to occur. Subsequently, the script bytecode will contain a new cast instruction that performs the conversion. This also works on container types, but each entry in the container will have to be converted. This can introduce unwanted overhead for large containers that are frequently passed between Blueprint and native code. The scope of this change affects Blueprints used by Gameplay, Animation, Control Rig, and UMG. #rb marc.audy (serialization changes) #jira UE-116484 #preflight 61f8bdd5a2514ba12ff7bdfc #ROBOMERGE-AUTHOR: dave.jones2 #ROBOMERGE-SOURCE: CL 18809077 in //UE5/Release-5.0/... via CL 18809455 via CL 18822548 #ROBOMERGE-BOT: UE5 (Release-Engine-Test -> Main) (v908-18788545) [CL 18823569 by dave jones2 in ue5-main branch]
2022-02-02 05:50:50 -05:00
CreateContainerStatement.RHS = MoveTemp(RHSTerms);
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
}
/////////////////////////////////////////////////////
// UK2Node_MakeContainer
UK2Node_MakeContainer::UK2Node_MakeContainer(const FObjectInitializer& ObjectInitializer)
: Super(ObjectInitializer)
{
NumInputs = 1;
}
UEdGraphPin* UK2Node_MakeContainer::GetOutputPin() const
{
return FindPin(GetOutputPinName());
}
void UK2Node_MakeContainer::ReallocatePinsDuringReconstruction(TArray<UEdGraphPin*>& OldPins)
{
Super::ReallocatePinsDuringReconstruction(OldPins);
// This is necessary to retain type information after pasting or loading from disc
if (UEdGraphPin* OutputPin = GetOutputPin())
{
// Only update the output pin if it is currently a wildcard
if (OutputPin->PinType.PinCategory == UEdGraphSchema_K2::PC_Wildcard)
{
// Find the matching Old Pin if it exists
for (UEdGraphPin* OldPin : OldPins)
{
if (OldPin->Direction == EGPD_Output)
{
// Update our output pin with the old type information and then propagate it to our input pins
OutputPin->PinType = OldPin->PinType;
PropagatePinType();
break;
}
}
}
}
}
void UK2Node_MakeContainer::AllocateDefaultPins()
{
// Create the output pin
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3716594) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3623720 by Phillip.Kavan #jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build. Change summary: - Temporarily excluded all AnimBP assets from nativization as a workaround. Change 3626305 by Phillip.Kavan #jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default. Change 3629145 by Marc.Audy Don't hide developer nativization tool behind ini Change 3630849 by Marc.Audy Fix nativization uncompilable code when using a non-referenceable term in a switch statement. #jira UE-44085 Change 3631037 by Marc.Audy (4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it #jira UE-49440 Change 3631206 by Marc.Audy Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT("")) Change 3631232 by Marc.Audy Remove outdated diagnostic code throwing false positives #jira UE-47986 Change 3631573 by Marc.Audy Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's' Change 3633168 by Lukasz.Furman fixed behavior tree changing its state during latent abort, modified order of operations during abort to: abort & wait -> change aux nodes -> execute Change 3633609 by Marc.Audy Don't get unneeded string Change 3633691 by Marc.Audy Fix copy-pasting of a collapsed graph containing a map input losing the value type #jira UE-49517 Change 3633967 by Ben.Zeigler Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript Fixed a few other fields to be private that were accidentally made public in 4.17 Change 3633984 by Michael.Noland Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links Change 3634464 by Ben.Zeigler Header cleanups for Pawn, Controller, Character, and PlayerController Change 3636858 by Marc.Audy In preview worlds don't display the light error sprite #jira UE-49555 Change 3636903 by Marc.Audy Fix numerous issues with copy/pasting editable pin bases #jira UE-49532 Change 3638898 by Marc.Audy Allow right-click creation of local variables in blueprint function libraries #jira UE-49590 Change 3639086 by Marc.Audy PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin) #jira UE-49591 Change 3639445 by Marc.Audy Fix mistaken override and virtual markup on niagara schema function. Change 3641202 by Marc.Audy (4.17.2) Fix crash undoing pin changes with split pins #jira UE-49634 Change 3643825 by Marc.Audy (4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted #jira UE-49756 Change 3645110 by mason.seay Fixed up QA-ClickHUD map so it's usable and makes more sense Change 3646428 by Dan.Oconnor Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data #jira None Change 3647298 by Marc.Audy PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist) #jira UE-49748 Change 3647815 by Marc.Audy Minor performance improvements Change 3648931 by Lina.Halper #Compiler : fixed so that each type of BP can provide module info, and compiler info - Moved out AnimBlueprint Compiler - Refactored WidgetBlueprint - DUPE - Merging using ControlRig_Dev-Framework Change 3654310 by Marc.Audy Shrink USkinnedMeshComponent 64 bytes Shrink USkeletalMeshComponent 224 bytes (160 bytes internal) Change 3654636 by Lina.Halper Fix crashing on shutdown #jira: UE-50004 Change 3654960 by Lina.Halper - Fix with automation test of creation/duplication - Fixed shut down crash with editor again due to uobject GCed #jira: UE-50028 Change 3655023 by Ben.Zeigler #jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag Change 3655426 by Ben.Zeigler #jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them Change 3657627 by Ben.Zeigler #jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction Change 3662086 by Mieszko.Zielinski Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4 This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList #jira UE-50101 Change 3662294 by Ben.Zeigler Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check Change 3662825 by Mieszko.Zielinski Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4 there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no Change 3664424 by Marc.Audy UE-50076 test assets #rb none #rnx Change 3664441 by Mieszko.Zielinski PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist) Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated. Change 3664506 by Phillip.Kavan #jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets. Change summary: - UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization. - UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths. - UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished. - UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option). - UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed. - UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead. - UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead. - UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file. - UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file. - UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first). - UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness. - UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed. - UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc. - UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file. - UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string. - UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>. - UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin. - UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed). - UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed). - UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it. - UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished. - UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed. - UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context. - UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail. - UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT). - UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders. Notes: - After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release). - Advanced users and build engineers can override this value per task. Instructions to do that are as follows: - For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line. - When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly. - We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT. - We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above). Change 3665061 by Phillip.Kavan Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum. Mirrored from //UE4/Release-4.18 (CL# 3664993). #3969 #jira UE-49233 Change 3665108 by Marc.Audy (4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted + additional code cleanup #jira UE-50076 Change 3665114 by Marc.Audy Minor change that could potentially improve performance in some cases Change 3665410 by Mieszko.Zielinski Fixed naming of Vislog's BP API #UE4 Change 3665634 by Ben.Zeigler #jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk Change 3666970 by Phillip.Kavan Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8. #jira UE-46814 Change 3667058 by Phillip.Kavan Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage. Mirrored from //UE4/Release-4.18 (CL# 3667043). #jira UE-50403 Change 3667150 by Mieszko.Zielinski PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM) Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend. #jira UE-50249 Change 3667152 by Mieszko.Zielinski PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM) #jira UE-50298 Change 3667166 by Mieszko.Zielinski Fixed FRichCurve baking so that it doesn't loose its curvature #UE4 Also, added some baking sanity checking (like if the range is larger than a single point). Change 3668025 by Dan.Oconnor Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed #jira UE-50453 Change 3672063 by Ben.Zeigler #jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case Change 3672306 by Ben.Zeigler #jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it Change 3672683 by Marc.Audy Code cleanup Change 3672749 by Ben.Zeigler Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build Change 3672831 by Ben.Zeigler #jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId. Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project Change 3673551 by Ben.Zeigler #jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load Change 3675074 by mason.seay Test map for VisLog Testing Change 3675084 by Mieszko.Zielinski Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4 #jira UE-43430 Change 3676490 by Ben.Zeigler #jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset Change 3676579 by Lukasz.Furman fixed crash in behavior tree's search rollback Change 3676586 by Lukasz.Furman added local scope mode to behavior tree's composite nodes Change 3676587 by Ben.Zeigler Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case Add browse, use selected, and clear buttons, and make ID selector font the normal property font Change 3676715 by Lukasz.Furman changed order of behavior tree's aux node ticking Change 3676867 by Ben.Zeigler #jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early Change 3677892 by Ben.Zeigler Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites Change 3678247 by Marc.Audy Fix static analysis warning Change 3678357 by Ben.Zeigler #jira UE-50696 Add some container variables to diff test to track down crashes Change 3678385 by Ben.Zeigler #jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match Change 3678600 by Ben.Zeigler #jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference Change 3679075 by Dan.Oconnor Mirror 3679030 from Release-4.18 Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on #jira UE-48692 Change 3679087 by Dan.Oconnor Filter out unnecessary relink jobs from the compilation manager #jira None Change 3680221 by Ben.Zeigler #jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary Change 3680561 by Lukasz.Furman fixed unsafe StopTree calls in behavior tree #jira nope Change 3680788 by Ben.Zeigler Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind Change 3683001 by mason.seay Submitting various test maps and assets Change 3686837 by Mieszko.Zielinski Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion #jira UE-50857 Change 3688451 by Marc.Audy Fix up new material expression to work with String -> Name refactor Change 3689097 by Mason.Seay Test content for nativization and enum testing Change 3689106 by Mieszko.Zielinski Made NavMeshBoundsVolume react to undo in the editor #Orion #jira UE-51013 Change 3689347 by Mieszko.Zielinski Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4 Manual merge of CL#3689316 over from 4.18 #jira UE-51019 Change 3692524 by mason.seay Moved some assets to folder for org, fixed up redirectors Change 3692540 by mason.seay Renaming test maps so they are clearly indicated for testing nativization Change 3692577 by mason.seay Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed Change 3692724 by mason.seay Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps Change 3693184 by mason.seay Assets for testing nativization with structs Change 3693367 by mason.seay Improvements to test content Change 3695395 by Dan.Oconnor Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced #jira None Change 3695484 by Marc.Audy Fix sound cue connection drawing policy not getting returned. #jira UE-51032 Change 3695494 by mason.seay More test content for nativization testing Change 3697829 by Mieszko.Zielinski PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei) Change 3700541 by mason.seay Test map for containers with function bug Change 3703459 by Marc.Audy Remove poorly named InverseLerp Fix degenerate behavior returning bad value #jira UE-50295 Change 3703803 by Marc.Audy Clean up autos Minor improvement to ShouldGenerateCluster Change 3704496 by Mason.Seay More test content for testing nativization Change 3706314 by Marc.Audy PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar) #jira UE-50874 Change 3707502 by Mason.Seay Final changes to nativization test content (hopefully) Change 3709478 by Marc.Audy PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel) Same as CL# 3689702 implemented in Fortnite #jira UE-51453 Change 3709967 by Marc.Audy PR #4139: fixed a typo in a comment (Contributed by derekvanvliet) #jira UE-51372 Change 3709970 by Marc.Audy PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman) #jira UE-51495 Change 3709971 by Marc.Audy PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas) #jira UE-51492 Change 3710041 by Marc.Audy Minor code cleanup Change 3711223 by Phillip.Kavan Move some Blueprint nativization log spam into the verbose category. #jira UE-49770 Change 3713398 by Marc.Audy PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM) #jira UE-51517 Change 3713601 by Marc.Audy Fix merge error Change 3713994 by Marc.Audy (4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event. #jira UE-50738 Change 3714270 by Marc.Audy Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors #jira UE-51534 Change 3714406 by Marc.Audy Fix dumb inverted boolean check Change 3716594 by Dan.Oconnor Integrate 3681301 from 4.18 Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior #jira UE-50780, UE-51568 Change 3686450 by Marc.Audy PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString. CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither. CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters. Material Expressions now store input and output names as FName instead of FString FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString Most existing pin related functions using string have been deprecated. Change 3713796 by Marc.Audy Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not. IsTickable no longer a pure virtual (defaults to true). Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject. Change 3638554 by Marc.Audy Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected. Change 3676502 by Ben.Zeigler Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635 [CL 3718205 by Marc Audy in Main branch]
2017-10-25 09:30:36 -04:00
UEdGraphNode::FCreatePinParams PinParams;
PinParams.ContainerType = ContainerType;
CreatePin(EGPD_Output, UEdGraphSchema_K2::PC_Wildcard, GetOutputPinName(), PinParams);
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
// Create the input pins to create the container from
for (int32 i = 0; i < NumInputs; ++i)
{
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3716594) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3623720 by Phillip.Kavan #jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build. Change summary: - Temporarily excluded all AnimBP assets from nativization as a workaround. Change 3626305 by Phillip.Kavan #jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default. Change 3629145 by Marc.Audy Don't hide developer nativization tool behind ini Change 3630849 by Marc.Audy Fix nativization uncompilable code when using a non-referenceable term in a switch statement. #jira UE-44085 Change 3631037 by Marc.Audy (4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it #jira UE-49440 Change 3631206 by Marc.Audy Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT("")) Change 3631232 by Marc.Audy Remove outdated diagnostic code throwing false positives #jira UE-47986 Change 3631573 by Marc.Audy Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's' Change 3633168 by Lukasz.Furman fixed behavior tree changing its state during latent abort, modified order of operations during abort to: abort & wait -> change aux nodes -> execute Change 3633609 by Marc.Audy Don't get unneeded string Change 3633691 by Marc.Audy Fix copy-pasting of a collapsed graph containing a map input losing the value type #jira UE-49517 Change 3633967 by Ben.Zeigler Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript Fixed a few other fields to be private that were accidentally made public in 4.17 Change 3633984 by Michael.Noland Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links Change 3634464 by Ben.Zeigler Header cleanups for Pawn, Controller, Character, and PlayerController Change 3636858 by Marc.Audy In preview worlds don't display the light error sprite #jira UE-49555 Change 3636903 by Marc.Audy Fix numerous issues with copy/pasting editable pin bases #jira UE-49532 Change 3638898 by Marc.Audy Allow right-click creation of local variables in blueprint function libraries #jira UE-49590 Change 3639086 by Marc.Audy PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin) #jira UE-49591 Change 3639445 by Marc.Audy Fix mistaken override and virtual markup on niagara schema function. Change 3641202 by Marc.Audy (4.17.2) Fix crash undoing pin changes with split pins #jira UE-49634 Change 3643825 by Marc.Audy (4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted #jira UE-49756 Change 3645110 by mason.seay Fixed up QA-ClickHUD map so it's usable and makes more sense Change 3646428 by Dan.Oconnor Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data #jira None Change 3647298 by Marc.Audy PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist) #jira UE-49748 Change 3647815 by Marc.Audy Minor performance improvements Change 3648931 by Lina.Halper #Compiler : fixed so that each type of BP can provide module info, and compiler info - Moved out AnimBlueprint Compiler - Refactored WidgetBlueprint - DUPE - Merging using ControlRig_Dev-Framework Change 3654310 by Marc.Audy Shrink USkinnedMeshComponent 64 bytes Shrink USkeletalMeshComponent 224 bytes (160 bytes internal) Change 3654636 by Lina.Halper Fix crashing on shutdown #jira: UE-50004 Change 3654960 by Lina.Halper - Fix with automation test of creation/duplication - Fixed shut down crash with editor again due to uobject GCed #jira: UE-50028 Change 3655023 by Ben.Zeigler #jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag Change 3655426 by Ben.Zeigler #jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them Change 3657627 by Ben.Zeigler #jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction Change 3662086 by Mieszko.Zielinski Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4 This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList #jira UE-50101 Change 3662294 by Ben.Zeigler Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check Change 3662825 by Mieszko.Zielinski Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4 there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no Change 3664424 by Marc.Audy UE-50076 test assets #rb none #rnx Change 3664441 by Mieszko.Zielinski PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist) Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated. Change 3664506 by Phillip.Kavan #jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets. Change summary: - UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization. - UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths. - UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished. - UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option). - UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed. - UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead. - UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead. - UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file. - UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file. - UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first). - UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness. - UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed. - UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc. - UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file. - UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string. - UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>. - UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin. - UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed). - UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed). - UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it. - UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished. - UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed. - UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context. - UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail. - UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT). - UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders. Notes: - After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release). - Advanced users and build engineers can override this value per task. Instructions to do that are as follows: - For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line. - When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly. - We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT. - We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above). Change 3665061 by Phillip.Kavan Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum. Mirrored from //UE4/Release-4.18 (CL# 3664993). #3969 #jira UE-49233 Change 3665108 by Marc.Audy (4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted + additional code cleanup #jira UE-50076 Change 3665114 by Marc.Audy Minor change that could potentially improve performance in some cases Change 3665410 by Mieszko.Zielinski Fixed naming of Vislog's BP API #UE4 Change 3665634 by Ben.Zeigler #jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk Change 3666970 by Phillip.Kavan Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8. #jira UE-46814 Change 3667058 by Phillip.Kavan Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage. Mirrored from //UE4/Release-4.18 (CL# 3667043). #jira UE-50403 Change 3667150 by Mieszko.Zielinski PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM) Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend. #jira UE-50249 Change 3667152 by Mieszko.Zielinski PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM) #jira UE-50298 Change 3667166 by Mieszko.Zielinski Fixed FRichCurve baking so that it doesn't loose its curvature #UE4 Also, added some baking sanity checking (like if the range is larger than a single point). Change 3668025 by Dan.Oconnor Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed #jira UE-50453 Change 3672063 by Ben.Zeigler #jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case Change 3672306 by Ben.Zeigler #jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it Change 3672683 by Marc.Audy Code cleanup Change 3672749 by Ben.Zeigler Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build Change 3672831 by Ben.Zeigler #jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId. Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project Change 3673551 by Ben.Zeigler #jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load Change 3675074 by mason.seay Test map for VisLog Testing Change 3675084 by Mieszko.Zielinski Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4 #jira UE-43430 Change 3676490 by Ben.Zeigler #jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset Change 3676579 by Lukasz.Furman fixed crash in behavior tree's search rollback Change 3676586 by Lukasz.Furman added local scope mode to behavior tree's composite nodes Change 3676587 by Ben.Zeigler Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case Add browse, use selected, and clear buttons, and make ID selector font the normal property font Change 3676715 by Lukasz.Furman changed order of behavior tree's aux node ticking Change 3676867 by Ben.Zeigler #jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early Change 3677892 by Ben.Zeigler Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites Change 3678247 by Marc.Audy Fix static analysis warning Change 3678357 by Ben.Zeigler #jira UE-50696 Add some container variables to diff test to track down crashes Change 3678385 by Ben.Zeigler #jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match Change 3678600 by Ben.Zeigler #jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference Change 3679075 by Dan.Oconnor Mirror 3679030 from Release-4.18 Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on #jira UE-48692 Change 3679087 by Dan.Oconnor Filter out unnecessary relink jobs from the compilation manager #jira None Change 3680221 by Ben.Zeigler #jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary Change 3680561 by Lukasz.Furman fixed unsafe StopTree calls in behavior tree #jira nope Change 3680788 by Ben.Zeigler Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind Change 3683001 by mason.seay Submitting various test maps and assets Change 3686837 by Mieszko.Zielinski Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion #jira UE-50857 Change 3688451 by Marc.Audy Fix up new material expression to work with String -> Name refactor Change 3689097 by Mason.Seay Test content for nativization and enum testing Change 3689106 by Mieszko.Zielinski Made NavMeshBoundsVolume react to undo in the editor #Orion #jira UE-51013 Change 3689347 by Mieszko.Zielinski Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4 Manual merge of CL#3689316 over from 4.18 #jira UE-51019 Change 3692524 by mason.seay Moved some assets to folder for org, fixed up redirectors Change 3692540 by mason.seay Renaming test maps so they are clearly indicated for testing nativization Change 3692577 by mason.seay Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed Change 3692724 by mason.seay Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps Change 3693184 by mason.seay Assets for testing nativization with structs Change 3693367 by mason.seay Improvements to test content Change 3695395 by Dan.Oconnor Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced #jira None Change 3695484 by Marc.Audy Fix sound cue connection drawing policy not getting returned. #jira UE-51032 Change 3695494 by mason.seay More test content for nativization testing Change 3697829 by Mieszko.Zielinski PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei) Change 3700541 by mason.seay Test map for containers with function bug Change 3703459 by Marc.Audy Remove poorly named InverseLerp Fix degenerate behavior returning bad value #jira UE-50295 Change 3703803 by Marc.Audy Clean up autos Minor improvement to ShouldGenerateCluster Change 3704496 by Mason.Seay More test content for testing nativization Change 3706314 by Marc.Audy PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar) #jira UE-50874 Change 3707502 by Mason.Seay Final changes to nativization test content (hopefully) Change 3709478 by Marc.Audy PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel) Same as CL# 3689702 implemented in Fortnite #jira UE-51453 Change 3709967 by Marc.Audy PR #4139: fixed a typo in a comment (Contributed by derekvanvliet) #jira UE-51372 Change 3709970 by Marc.Audy PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman) #jira UE-51495 Change 3709971 by Marc.Audy PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas) #jira UE-51492 Change 3710041 by Marc.Audy Minor code cleanup Change 3711223 by Phillip.Kavan Move some Blueprint nativization log spam into the verbose category. #jira UE-49770 Change 3713398 by Marc.Audy PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM) #jira UE-51517 Change 3713601 by Marc.Audy Fix merge error Change 3713994 by Marc.Audy (4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event. #jira UE-50738 Change 3714270 by Marc.Audy Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors #jira UE-51534 Change 3714406 by Marc.Audy Fix dumb inverted boolean check Change 3716594 by Dan.Oconnor Integrate 3681301 from 4.18 Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior #jira UE-50780, UE-51568 Change 3686450 by Marc.Audy PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString. CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither. CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters. Material Expressions now store input and output names as FName instead of FString FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString Most existing pin related functions using string have been deprecated. Change 3713796 by Marc.Audy Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not. IsTickable no longer a pure virtual (defaults to true). Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject. Change 3638554 by Marc.Audy Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected. Change 3676502 by Ben.Zeigler Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635 [CL 3718205 by Marc Audy in Main branch]
2017-10-25 09:30:36 -04:00
CreatePin(EGPD_Input, UEdGraphSchema_K2::PC_Wildcard, GetPinName(i));
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
}
}
void UK2Node_MakeContainer::GetKeyAndValuePins(TArray<UEdGraphPin*>& KeyPins, TArray<UEdGraphPin*>& ValuePins) const
{
for (UEdGraphPin* CurrentPin : Pins)
{
if (CurrentPin->Direction == EGPD_Input && CurrentPin->ParentPin == nullptr)
{
KeyPins.Add(CurrentPin);
}
}
}
bool UK2Node_MakeContainer::CanResetToWildcard() const
{
bool bClearPinsToWildcard = true;
// Check to see if we want to clear the wildcards.
for (const UEdGraphPin* Pin : Pins)
{
if( Pin->LinkedTo.Num() > 0 )
{
// One of the pins is still linked, we will not be clearing the types.
bClearPinsToWildcard = false;
break;
}
}
return bClearPinsToWildcard;
}
void UK2Node_MakeContainer::ClearPinTypeToWildcard()
{
if (CanResetToWildcard())
{
UEdGraphPin* OutputPin = GetOutputPin();
OutputPin->PinType.PinCategory = UEdGraphSchema_K2::PC_Wildcard;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3716594) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3623720 by Phillip.Kavan #jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build. Change summary: - Temporarily excluded all AnimBP assets from nativization as a workaround. Change 3626305 by Phillip.Kavan #jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default. Change 3629145 by Marc.Audy Don't hide developer nativization tool behind ini Change 3630849 by Marc.Audy Fix nativization uncompilable code when using a non-referenceable term in a switch statement. #jira UE-44085 Change 3631037 by Marc.Audy (4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it #jira UE-49440 Change 3631206 by Marc.Audy Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT("")) Change 3631232 by Marc.Audy Remove outdated diagnostic code throwing false positives #jira UE-47986 Change 3631573 by Marc.Audy Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's' Change 3633168 by Lukasz.Furman fixed behavior tree changing its state during latent abort, modified order of operations during abort to: abort & wait -> change aux nodes -> execute Change 3633609 by Marc.Audy Don't get unneeded string Change 3633691 by Marc.Audy Fix copy-pasting of a collapsed graph containing a map input losing the value type #jira UE-49517 Change 3633967 by Ben.Zeigler Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript Fixed a few other fields to be private that were accidentally made public in 4.17 Change 3633984 by Michael.Noland Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links Change 3634464 by Ben.Zeigler Header cleanups for Pawn, Controller, Character, and PlayerController Change 3636858 by Marc.Audy In preview worlds don't display the light error sprite #jira UE-49555 Change 3636903 by Marc.Audy Fix numerous issues with copy/pasting editable pin bases #jira UE-49532 Change 3638898 by Marc.Audy Allow right-click creation of local variables in blueprint function libraries #jira UE-49590 Change 3639086 by Marc.Audy PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin) #jira UE-49591 Change 3639445 by Marc.Audy Fix mistaken override and virtual markup on niagara schema function. Change 3641202 by Marc.Audy (4.17.2) Fix crash undoing pin changes with split pins #jira UE-49634 Change 3643825 by Marc.Audy (4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted #jira UE-49756 Change 3645110 by mason.seay Fixed up QA-ClickHUD map so it's usable and makes more sense Change 3646428 by Dan.Oconnor Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data #jira None Change 3647298 by Marc.Audy PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist) #jira UE-49748 Change 3647815 by Marc.Audy Minor performance improvements Change 3648931 by Lina.Halper #Compiler : fixed so that each type of BP can provide module info, and compiler info - Moved out AnimBlueprint Compiler - Refactored WidgetBlueprint - DUPE - Merging using ControlRig_Dev-Framework Change 3654310 by Marc.Audy Shrink USkinnedMeshComponent 64 bytes Shrink USkeletalMeshComponent 224 bytes (160 bytes internal) Change 3654636 by Lina.Halper Fix crashing on shutdown #jira: UE-50004 Change 3654960 by Lina.Halper - Fix with automation test of creation/duplication - Fixed shut down crash with editor again due to uobject GCed #jira: UE-50028 Change 3655023 by Ben.Zeigler #jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag Change 3655426 by Ben.Zeigler #jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them Change 3657627 by Ben.Zeigler #jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction Change 3662086 by Mieszko.Zielinski Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4 This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList #jira UE-50101 Change 3662294 by Ben.Zeigler Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check Change 3662825 by Mieszko.Zielinski Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4 there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no Change 3664424 by Marc.Audy UE-50076 test assets #rb none #rnx Change 3664441 by Mieszko.Zielinski PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist) Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated. Change 3664506 by Phillip.Kavan #jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets. Change summary: - UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization. - UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths. - UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished. - UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option). - UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed. - UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead. - UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead. - UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file. - UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file. - UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first). - UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness. - UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed. - UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc. - UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file. - UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string. - UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>. - UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin. - UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed). - UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed). - UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it. - UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished. - UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed. - UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context. - UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail. - UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT). - UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders. Notes: - After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release). - Advanced users and build engineers can override this value per task. Instructions to do that are as follows: - For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line. - When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly. - We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT. - We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above). Change 3665061 by Phillip.Kavan Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum. Mirrored from //UE4/Release-4.18 (CL# 3664993). #3969 #jira UE-49233 Change 3665108 by Marc.Audy (4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted + additional code cleanup #jira UE-50076 Change 3665114 by Marc.Audy Minor change that could potentially improve performance in some cases Change 3665410 by Mieszko.Zielinski Fixed naming of Vislog's BP API #UE4 Change 3665634 by Ben.Zeigler #jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk Change 3666970 by Phillip.Kavan Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8. #jira UE-46814 Change 3667058 by Phillip.Kavan Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage. Mirrored from //UE4/Release-4.18 (CL# 3667043). #jira UE-50403 Change 3667150 by Mieszko.Zielinski PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM) Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend. #jira UE-50249 Change 3667152 by Mieszko.Zielinski PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM) #jira UE-50298 Change 3667166 by Mieszko.Zielinski Fixed FRichCurve baking so that it doesn't loose its curvature #UE4 Also, added some baking sanity checking (like if the range is larger than a single point). Change 3668025 by Dan.Oconnor Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed #jira UE-50453 Change 3672063 by Ben.Zeigler #jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case Change 3672306 by Ben.Zeigler #jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it Change 3672683 by Marc.Audy Code cleanup Change 3672749 by Ben.Zeigler Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build Change 3672831 by Ben.Zeigler #jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId. Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project Change 3673551 by Ben.Zeigler #jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load Change 3675074 by mason.seay Test map for VisLog Testing Change 3675084 by Mieszko.Zielinski Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4 #jira UE-43430 Change 3676490 by Ben.Zeigler #jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset Change 3676579 by Lukasz.Furman fixed crash in behavior tree's search rollback Change 3676586 by Lukasz.Furman added local scope mode to behavior tree's composite nodes Change 3676587 by Ben.Zeigler Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case Add browse, use selected, and clear buttons, and make ID selector font the normal property font Change 3676715 by Lukasz.Furman changed order of behavior tree's aux node ticking Change 3676867 by Ben.Zeigler #jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early Change 3677892 by Ben.Zeigler Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites Change 3678247 by Marc.Audy Fix static analysis warning Change 3678357 by Ben.Zeigler #jira UE-50696 Add some container variables to diff test to track down crashes Change 3678385 by Ben.Zeigler #jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match Change 3678600 by Ben.Zeigler #jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference Change 3679075 by Dan.Oconnor Mirror 3679030 from Release-4.18 Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on #jira UE-48692 Change 3679087 by Dan.Oconnor Filter out unnecessary relink jobs from the compilation manager #jira None Change 3680221 by Ben.Zeigler #jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary Change 3680561 by Lukasz.Furman fixed unsafe StopTree calls in behavior tree #jira nope Change 3680788 by Ben.Zeigler Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind Change 3683001 by mason.seay Submitting various test maps and assets Change 3686837 by Mieszko.Zielinski Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion #jira UE-50857 Change 3688451 by Marc.Audy Fix up new material expression to work with String -> Name refactor Change 3689097 by Mason.Seay Test content for nativization and enum testing Change 3689106 by Mieszko.Zielinski Made NavMeshBoundsVolume react to undo in the editor #Orion #jira UE-51013 Change 3689347 by Mieszko.Zielinski Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4 Manual merge of CL#3689316 over from 4.18 #jira UE-51019 Change 3692524 by mason.seay Moved some assets to folder for org, fixed up redirectors Change 3692540 by mason.seay Renaming test maps so they are clearly indicated for testing nativization Change 3692577 by mason.seay Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed Change 3692724 by mason.seay Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps Change 3693184 by mason.seay Assets for testing nativization with structs Change 3693367 by mason.seay Improvements to test content Change 3695395 by Dan.Oconnor Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced #jira None Change 3695484 by Marc.Audy Fix sound cue connection drawing policy not getting returned. #jira UE-51032 Change 3695494 by mason.seay More test content for nativization testing Change 3697829 by Mieszko.Zielinski PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei) Change 3700541 by mason.seay Test map for containers with function bug Change 3703459 by Marc.Audy Remove poorly named InverseLerp Fix degenerate behavior returning bad value #jira UE-50295 Change 3703803 by Marc.Audy Clean up autos Minor improvement to ShouldGenerateCluster Change 3704496 by Mason.Seay More test content for testing nativization Change 3706314 by Marc.Audy PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar) #jira UE-50874 Change 3707502 by Mason.Seay Final changes to nativization test content (hopefully) Change 3709478 by Marc.Audy PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel) Same as CL# 3689702 implemented in Fortnite #jira UE-51453 Change 3709967 by Marc.Audy PR #4139: fixed a typo in a comment (Contributed by derekvanvliet) #jira UE-51372 Change 3709970 by Marc.Audy PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman) #jira UE-51495 Change 3709971 by Marc.Audy PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas) #jira UE-51492 Change 3710041 by Marc.Audy Minor code cleanup Change 3711223 by Phillip.Kavan Move some Blueprint nativization log spam into the verbose category. #jira UE-49770 Change 3713398 by Marc.Audy PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM) #jira UE-51517 Change 3713601 by Marc.Audy Fix merge error Change 3713994 by Marc.Audy (4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event. #jira UE-50738 Change 3714270 by Marc.Audy Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors #jira UE-51534 Change 3714406 by Marc.Audy Fix dumb inverted boolean check Change 3716594 by Dan.Oconnor Integrate 3681301 from 4.18 Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior #jira UE-50780, UE-51568 Change 3686450 by Marc.Audy PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString. CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither. CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters. Material Expressions now store input and output names as FName instead of FString FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString Most existing pin related functions using string have been deprecated. Change 3713796 by Marc.Audy Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not. IsTickable no longer a pure virtual (defaults to true). Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject. Change 3638554 by Marc.Audy Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected. Change 3676502 by Ben.Zeigler Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635 [CL 3718205 by Marc Audy in Main branch]
2017-10-25 09:30:36 -04:00
OutputPin->PinType.PinSubCategory = NAME_None;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
OutputPin->PinType.PinSubCategoryObject = nullptr;
if (ContainerType == EPinContainerType::Map)
{
OutputPin->PinType.PinValueType.TerminalCategory = UEdGraphSchema_K2::PC_Wildcard;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3716594) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3623720 by Phillip.Kavan #jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build. Change summary: - Temporarily excluded all AnimBP assets from nativization as a workaround. Change 3626305 by Phillip.Kavan #jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default. Change 3629145 by Marc.Audy Don't hide developer nativization tool behind ini Change 3630849 by Marc.Audy Fix nativization uncompilable code when using a non-referenceable term in a switch statement. #jira UE-44085 Change 3631037 by Marc.Audy (4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it #jira UE-49440 Change 3631206 by Marc.Audy Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT("")) Change 3631232 by Marc.Audy Remove outdated diagnostic code throwing false positives #jira UE-47986 Change 3631573 by Marc.Audy Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's' Change 3633168 by Lukasz.Furman fixed behavior tree changing its state during latent abort, modified order of operations during abort to: abort & wait -> change aux nodes -> execute Change 3633609 by Marc.Audy Don't get unneeded string Change 3633691 by Marc.Audy Fix copy-pasting of a collapsed graph containing a map input losing the value type #jira UE-49517 Change 3633967 by Ben.Zeigler Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript Fixed a few other fields to be private that were accidentally made public in 4.17 Change 3633984 by Michael.Noland Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links Change 3634464 by Ben.Zeigler Header cleanups for Pawn, Controller, Character, and PlayerController Change 3636858 by Marc.Audy In preview worlds don't display the light error sprite #jira UE-49555 Change 3636903 by Marc.Audy Fix numerous issues with copy/pasting editable pin bases #jira UE-49532 Change 3638898 by Marc.Audy Allow right-click creation of local variables in blueprint function libraries #jira UE-49590 Change 3639086 by Marc.Audy PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin) #jira UE-49591 Change 3639445 by Marc.Audy Fix mistaken override and virtual markup on niagara schema function. Change 3641202 by Marc.Audy (4.17.2) Fix crash undoing pin changes with split pins #jira UE-49634 Change 3643825 by Marc.Audy (4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted #jira UE-49756 Change 3645110 by mason.seay Fixed up QA-ClickHUD map so it's usable and makes more sense Change 3646428 by Dan.Oconnor Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data #jira None Change 3647298 by Marc.Audy PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist) #jira UE-49748 Change 3647815 by Marc.Audy Minor performance improvements Change 3648931 by Lina.Halper #Compiler : fixed so that each type of BP can provide module info, and compiler info - Moved out AnimBlueprint Compiler - Refactored WidgetBlueprint - DUPE - Merging using ControlRig_Dev-Framework Change 3654310 by Marc.Audy Shrink USkinnedMeshComponent 64 bytes Shrink USkeletalMeshComponent 224 bytes (160 bytes internal) Change 3654636 by Lina.Halper Fix crashing on shutdown #jira: UE-50004 Change 3654960 by Lina.Halper - Fix with automation test of creation/duplication - Fixed shut down crash with editor again due to uobject GCed #jira: UE-50028 Change 3655023 by Ben.Zeigler #jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag Change 3655426 by Ben.Zeigler #jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them Change 3657627 by Ben.Zeigler #jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction Change 3662086 by Mieszko.Zielinski Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4 This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList #jira UE-50101 Change 3662294 by Ben.Zeigler Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check Change 3662825 by Mieszko.Zielinski Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4 there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no Change 3664424 by Marc.Audy UE-50076 test assets #rb none #rnx Change 3664441 by Mieszko.Zielinski PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist) Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated. Change 3664506 by Phillip.Kavan #jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets. Change summary: - UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization. - UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths. - UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished. - UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option). - UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed. - UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead. - UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead. - UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file. - UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file. - UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first). - UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness. - UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed. - UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc. - UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file. - UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string. - UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>. - UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin. - UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed). - UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed). - UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it. - UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished. - UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed. - UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context. - UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail. - UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT). - UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders. Notes: - After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release). - Advanced users and build engineers can override this value per task. Instructions to do that are as follows: - For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line. - When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly. - We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT. - We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above). Change 3665061 by Phillip.Kavan Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum. Mirrored from //UE4/Release-4.18 (CL# 3664993). #3969 #jira UE-49233 Change 3665108 by Marc.Audy (4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted + additional code cleanup #jira UE-50076 Change 3665114 by Marc.Audy Minor change that could potentially improve performance in some cases Change 3665410 by Mieszko.Zielinski Fixed naming of Vislog's BP API #UE4 Change 3665634 by Ben.Zeigler #jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk Change 3666970 by Phillip.Kavan Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8. #jira UE-46814 Change 3667058 by Phillip.Kavan Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage. Mirrored from //UE4/Release-4.18 (CL# 3667043). #jira UE-50403 Change 3667150 by Mieszko.Zielinski PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM) Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend. #jira UE-50249 Change 3667152 by Mieszko.Zielinski PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM) #jira UE-50298 Change 3667166 by Mieszko.Zielinski Fixed FRichCurve baking so that it doesn't loose its curvature #UE4 Also, added some baking sanity checking (like if the range is larger than a single point). Change 3668025 by Dan.Oconnor Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed #jira UE-50453 Change 3672063 by Ben.Zeigler #jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case Change 3672306 by Ben.Zeigler #jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it Change 3672683 by Marc.Audy Code cleanup Change 3672749 by Ben.Zeigler Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build Change 3672831 by Ben.Zeigler #jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId. Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project Change 3673551 by Ben.Zeigler #jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load Change 3675074 by mason.seay Test map for VisLog Testing Change 3675084 by Mieszko.Zielinski Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4 #jira UE-43430 Change 3676490 by Ben.Zeigler #jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset Change 3676579 by Lukasz.Furman fixed crash in behavior tree's search rollback Change 3676586 by Lukasz.Furman added local scope mode to behavior tree's composite nodes Change 3676587 by Ben.Zeigler Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case Add browse, use selected, and clear buttons, and make ID selector font the normal property font Change 3676715 by Lukasz.Furman changed order of behavior tree's aux node ticking Change 3676867 by Ben.Zeigler #jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early Change 3677892 by Ben.Zeigler Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites Change 3678247 by Marc.Audy Fix static analysis warning Change 3678357 by Ben.Zeigler #jira UE-50696 Add some container variables to diff test to track down crashes Change 3678385 by Ben.Zeigler #jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match Change 3678600 by Ben.Zeigler #jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference Change 3679075 by Dan.Oconnor Mirror 3679030 from Release-4.18 Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on #jira UE-48692 Change 3679087 by Dan.Oconnor Filter out unnecessary relink jobs from the compilation manager #jira None Change 3680221 by Ben.Zeigler #jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary Change 3680561 by Lukasz.Furman fixed unsafe StopTree calls in behavior tree #jira nope Change 3680788 by Ben.Zeigler Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind Change 3683001 by mason.seay Submitting various test maps and assets Change 3686837 by Mieszko.Zielinski Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion #jira UE-50857 Change 3688451 by Marc.Audy Fix up new material expression to work with String -> Name refactor Change 3689097 by Mason.Seay Test content for nativization and enum testing Change 3689106 by Mieszko.Zielinski Made NavMeshBoundsVolume react to undo in the editor #Orion #jira UE-51013 Change 3689347 by Mieszko.Zielinski Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4 Manual merge of CL#3689316 over from 4.18 #jira UE-51019 Change 3692524 by mason.seay Moved some assets to folder for org, fixed up redirectors Change 3692540 by mason.seay Renaming test maps so they are clearly indicated for testing nativization Change 3692577 by mason.seay Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed Change 3692724 by mason.seay Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps Change 3693184 by mason.seay Assets for testing nativization with structs Change 3693367 by mason.seay Improvements to test content Change 3695395 by Dan.Oconnor Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced #jira None Change 3695484 by Marc.Audy Fix sound cue connection drawing policy not getting returned. #jira UE-51032 Change 3695494 by mason.seay More test content for nativization testing Change 3697829 by Mieszko.Zielinski PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei) Change 3700541 by mason.seay Test map for containers with function bug Change 3703459 by Marc.Audy Remove poorly named InverseLerp Fix degenerate behavior returning bad value #jira UE-50295 Change 3703803 by Marc.Audy Clean up autos Minor improvement to ShouldGenerateCluster Change 3704496 by Mason.Seay More test content for testing nativization Change 3706314 by Marc.Audy PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar) #jira UE-50874 Change 3707502 by Mason.Seay Final changes to nativization test content (hopefully) Change 3709478 by Marc.Audy PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel) Same as CL# 3689702 implemented in Fortnite #jira UE-51453 Change 3709967 by Marc.Audy PR #4139: fixed a typo in a comment (Contributed by derekvanvliet) #jira UE-51372 Change 3709970 by Marc.Audy PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman) #jira UE-51495 Change 3709971 by Marc.Audy PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas) #jira UE-51492 Change 3710041 by Marc.Audy Minor code cleanup Change 3711223 by Phillip.Kavan Move some Blueprint nativization log spam into the verbose category. #jira UE-49770 Change 3713398 by Marc.Audy PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM) #jira UE-51517 Change 3713601 by Marc.Audy Fix merge error Change 3713994 by Marc.Audy (4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event. #jira UE-50738 Change 3714270 by Marc.Audy Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors #jira UE-51534 Change 3714406 by Marc.Audy Fix dumb inverted boolean check Change 3716594 by Dan.Oconnor Integrate 3681301 from 4.18 Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior #jira UE-50780, UE-51568 Change 3686450 by Marc.Audy PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString. CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither. CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters. Material Expressions now store input and output names as FName instead of FString FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString Most existing pin related functions using string have been deprecated. Change 3713796 by Marc.Audy Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not. IsTickable no longer a pure virtual (defaults to true). Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject. Change 3638554 by Marc.Audy Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected. Change 3676502 by Ben.Zeigler Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635 [CL 3718205 by Marc Audy in Main branch]
2017-10-25 09:30:36 -04:00
OutputPin->PinType.PinValueType.TerminalSubCategory = NAME_None;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
OutputPin->PinType.PinValueType.TerminalSubCategoryObject = nullptr;
}
PropagatePinType();
}
}
void UK2Node_MakeContainer::NotifyPinConnectionListChanged(UEdGraphPin* Pin)
{
Super::NotifyPinConnectionListChanged(Pin);
// Array to cache the input pins we might want to find these if we are removing the last link
TArray<UEdGraphPin*> KeyPins;
TArray<UEdGraphPin*> ValuePins;
GetKeyAndValuePins(KeyPins, ValuePins);
auto CountLinkedPins = [](const TArray<UEdGraphPin*> PinsToCount)
{
int32 LinkedPins = 0;
for (UEdGraphPin* CurrentPin : PinsToCount)
{
if (CurrentPin->LinkedTo.Num() > 0)
{
++LinkedPins;
}
}
return LinkedPins;
};
// Was this the first or last connection?
const int32 NumKeyPinsWithLinks = CountLinkedPins(KeyPins);
const int32 NumValuePinsWithLinks = CountLinkedPins(ValuePins);
UEdGraphPin* OutputPin = GetOutputPin();
bool bNotifyGraphChanged = false;
if (Pin->LinkedTo.Num() > 0)
{
if (Pin->ParentPin == nullptr)
{
if (Pin == OutputPin)
{
Copying //UE4/Release-Staging-4.19 to //UE4/Dev-Main (Source: //UE4/Release-4.19 @ 3873914) ============================ MAJOR FEATURES & CHANGES ============================ Change 3873906 by Dan.Oconnor Revised fix for preventing delegate functions from appearing in context menu when using the compilation manager - needed to run after CallDelegateHandler changed statement type #jira UE-51726 Change 3873614 by Dan.Oconnor Prevent delegate functions from appearing in context menu when using the compilation manager and prevent crash if such a function is somehow compiled #jira UE-51726 Change 3873428 by Ben.Zeigler #jira UE-54753 Fix class pin on SpawnActorFromClass to correctly support browse. It was inherting from the wrong pin widget Copy of 3873408 Change 3873083 by Ethan.Geller [4.19]#jira UE-54865 fix seconds -> milliseconds conversion issue. #rb aaron.mcleran #lockdown cristina.riveron Change 3872714 by Dan.Oconnor Further revise fix for UE-53840, mistakenly reverted to old behavior when compiling synchronously #jira UE-53840 Change 3872648 by Ben.Zeigler #jira UE-54845 Fix crash in NextDebugTarget when there are no valid debug targets Copy of CL #3872636 Change 3872500 by Arne.Schober Back out changelist 3870283 #jira UE-54838 Change 3872412 by Mark.Satterthwaite Remove now unnecessary r.Metal.ManualVertexFetch from the device profiles. #jira UE-54853 Change 3872313 by Martin.Wilson Add UI to Live Link Client to warn live link users about background performance throttling #jira none Change 3872272 by Martin.Wilson Fix crash when clearing a skeletal mesh on a skeletal mesh component with an active Post Process Anim Instance #jira none Change 3872238 by Mark.Satterthwaite Duplicate CL #3871025 Make Manual Vertex Fetch a property of the shader platform for Metal - only the desktop platforms (METAL SM5/SM5_NoTess/MRT) will use manual vertex fetch. The mobile platforms use vertex descriptors. Prevents problems with cooked versions of games not working properly on Metal due to a mismatch between the runtime's Manual-Vertex-Fetch state versus the state used by the cooker when compiling shaders. #jira UE-54843 Change 3872087 by Yasiman.Ahsani Adding Python, libdisasm, musl, and LSS licenses. #JIRA n/a - adding licenses for new TPS Change 3872037 by Ben.Marsh BuildGraph: Add a task for compiling MSBuild projects. #jira Change 3871934 by Lina.Halper #jira: UE-54703 Change 3871595 by Michael.Trepka Fixed a problem with Mac editor not exiting with error code returned from GuardedMain function #jira UE-54830 Change 3870829 by Joe.Barnes Fix unintentional change to PhysX libs used in Debug builds. #jira ue-54817 Change 3870820 by Nick.Atamas Copying //Tasks/UE4/Dev-VR-4.19a@3870772 to Release-4.19 (//UE4/Release-4.19) #jira UE-54816 Change 3870755 by Chance.Ivey Min Android version set - should fix camera permissions issue found in #JIRA UE-54024 #rb none #fyi nick.atamas Change 3870547 by Krzysztof.Narkowicz Fixed FreezeRendering on non editor builds: ComputeAndMarkRelevanceForViewParallel was calling FrozenMatricesGuard on multiple threads, reading and writing view matrices state in parallel. #jira UE-53640 Change 3870546 by Krzysztof.Narkowicz Fixed tesselation shader tex/uniform initialization in OpenGL3/4 path #jira UE-54471 Change 3870284 by Ben.Zeigler #jira UE-54583 Fix issue where loading multiple already loaded assets via Async Load Asset node could return the wrong asset on the loaded pin. The assign variable node was happening at a slightly wrong time Copy of CL #3870279 Change 3870283 by Arne.Schober SafeRelease SRVs that might be hold by the Vertexfactories (maybe due to indirect use in GlobalResources) Note that the VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should be uneccessary #jira none Change 3870098 by Ben.Marsh Fix OptimizeCode = CodeOptimization.Always causing compile errors in Linux debug builds. bUseInlining was not set correctly on the global compile environment used to build shared PCHs. Also fixed other settings not being propogated down from the target correctly. #jira UE-53855 Change 3870013 by Ben.Marsh UBT: Add an error if a user attempts to clean a target through hot-reload, rather than just failing to delete DLLs because they are locked. #jira UE-54179 Change 3870010 by Ben.Marsh UBT: Add an option to format output messages in a form that can be parsed by MSBuild. Prevents errors showing as "EXEC: Error:", and displays them correctly in the error list window. #jira Change 3869814 by Ben.Marsh UBT: Unify command line arguments to use -Name=Value syntax. -Module <Name>, -ModuleWithSuffix <Name> <Suffix>, -Plugin <Path> and -Receipt <Path> are no longer supported. Also remove the RemoteRoot option, which was not used anywhere. #jira Change 3869786 by Martin.Wilson Fix Live Link Remove Source button not working #Jira UE-54652 Change 3869660 by Martin.Wilson Fix missing message bus sources in the live link client (not repolling for new sources) #Jira UE-54712 Change 3869659 by Guillaume.Abadie Fixes SimpleComposure's BP_AdvancedCompositing keep allocating memory every frame. Credits for fixing the issue to Ron Radeztsk. #jira UE-54780 Change 3869401 by Lauren.Ridge Adding to the conditional in FindAllAncestorNamedSlotHostWidgetsForContent #jira UE-51470 Change 3869384 by Brandon.Schaefer Open the project in the explorer when NullSourceCodeAccess is done creating the project #jira UE-54630 Change 3869308 by Ben.Marsh PR #4452: Fixed FindFilesRecursively in IPlatformFilePak (Contributed by user37337) #jira UE-54568 Change 3869265 by Martin.Wilson Fix crash and subsequently found issues with unloading/reloading Maya Live Link plugin -Crash on reload due to core code getting reinitialize, made this a one time only thing (as Maya never gets rid of the module from memory) -Added manual ticking of FTicker, allows message bus objects to be cleaned up properly (cannot do this as part of normal flow as it is in engine code which we dont have) -rebuild binaries for Engine/Extras #Jira UE-54643 Change 3869206 by Benn.Gallagher Fixed crash updating clothing paint mode after tab spawners have been destroyed by the hosting application. #jira UE-54116 Change 3869064 by Benn.Gallagher Resolved skeletal mesh data changes and clothing section disable changes after collision. Re-added ability to disable sections at the mesh level and removed the ability to strip editor sections as these are required for a number of other features to correctly function. #jira UE-52557 Change 3869062 by Guillaume.Abadie Fixes "dynamic resolution is not supported on this platform" warning message being always visible. #jira UE-54655 Change 3868202 by Lauren.Ridge Fix for assert on expanding vector param in layered material #jira UE-54737 Change 3868161 by zak.parrish Replacing FaceARDebugUI with a blank UI until a new one can be created, due to a crash bug. #rb none #JIRA UE-54639 Change 3867750 by Ethan.Geller [4.19] #jira UE-54725 Fix for Envelope attack and release values not being properly set on Synth Components #rb aaron.mcleran #lockdown cristina.riveron Change 3867657 by Lauren.Ridge Adding if with editor wrapper to new function #jira cis fix Change 3867646 by Aaron.McLeran #jira UE-53867 Access violation on Switch when playing sound with specified time out of range Change 3867340 by Lauren.Ridge Fixes to Material Layers from 4.19 preview feedback -Need to pass through base attributes better/have better default nodes in layer (optional Example Layers and Blends checkbox now enables this in Experimental Settings) -Parent in function should be editable -Enforce only two layers in a blend -Mat layer should warn if it has incorrect output in the layer itself -Enforce not being able to delete outputs -Warn about creating a MAL node inside a function #jira UETOOL-1312 Change 3867317 by Aaron.McLeran #jira UE-53867 Access violation on Switch when playing sound with specified time out of range Change 3867000 by Lauren.Ridge Fix for folder favorites possibly becoming very large #jira UE-54704 Change 3866892 by Martin.Wilson Fix crash if clicking ok on message bus add source without having a source selected #jira UE-54572 Change 3866391 by Matt.Kuhlenschmidt Fix static analysis #jira UE-53379 Change 3866241 by Ryan.Vance #jira UE-54681 Fixed missing Vulkan texture GetNativeResource implementation that was lost in a bad merge. Change 3866071 by Nick.Shin UDN 412414 update HTMl5 readme file #jira none Change 3866005 by Max.Preussner Messaging: Preventing dangling references when removing message subscribers #jira UE-54680 Change 3865988 by Simon.Tourangeau Fix static analysis warnings #jira none Change 3865895 by zachary.wilson Renaming QA-PhysicalLightUnits to TM-PhysicalLightUnits in QAGame. #JIRA UE-29618 Change 3865469 by Simon.Tourangeau Support for DX11 quad buffer stereo rendering #jira UEENT-704 Change 3865461 by Chris.Babcock Add a wait for audio thread to pause audio on going to background #jira UE-54301 #ue4 #android Change 3865350 by Matt.Kuhlenschmidt Fix issue where cascade emitter UI would disapper #jira UE-53379 Change 3865336 by Arne.Schober REL - Fix UE-52356 Bone Weight #jira UE-52356 Change 3865257 by Ben.Marsh Fix editor failing to load content-only projects when compiled in DebugGame. #jira UE-54661 Change 3865238 by Simon.Tovey Pulling Olaf's fix from 3832595 over to release #tests EngineTests boots in vulkan #JIRA UE-54394 Change 3865191 by Sorin.Gradinaru UE-54317 DXT apps fail on first launch when 'For Distribution' enabled, Unsupported Texture Format #jira UE-54317 #Android #4.19 From //Dev-Mobile/3863322 Change 3865190 by Sorin.Gradinaru UE-54175 Selecting For Distribution no longer sets configuration to Shipping #UE4 #4.19 #jira UE-54175 From //Dev-Mobile/3863371 "For Distribution" enable-> reset "Build COnfiguration" to Shipping and force serialization to DefaultGame.ini (see UE-52845) Change 3865056 by Jamie.Dale Fixed culture being incorrect when added via the Localization Dashboard #jira none Change 3864826 by Max.Preussner WmfMedia: Added missing scope lock #jira UE-54365 Change 3864055 by Aaron.McLeran #jira UE-54213 Crash fix for GC'd plugin settings objects. Adding to AddReferencedObjects. Change 3863775 by Andrew.Porter MediaFrameworkTest: Removing Platform Media Source TVOS test content #jira UE-29618 Change 3863714 by Dan.Oconnor Make array, set, and map nodes no longer switch object type when a pin is disconnected. Also, you can no longer attach unrelated map types to the MakeMap node if only the value pin has been inferred #jira UE-54634 Change 3863696 by Max.Chen Sequencer: Fix crash open a new sequence while another is still active. #jira UE-54620 #jira UE-54624 Change 3863638 by Dan.Oconnor Make sure all blueprints that are skeleton compiled get a BroadcastChanged notification, also run BroadcastChanged after reinstancing, matching pre compilation manager behavior #jira UE-54193 Change 3863494 by Jamie.Dale Ensure Py_SetPythonHome is set correctly before the embedded Python interpreter is initialized #jira UE-54345 Change 3863433 by Max.Preussner MediaPlayerEditor: Removed tvOS from list of available platforms in Platform Media Source assets tvOS currently reports itself as iOS, so it cannot have its own setting. #jira UE-54559 Change 3863406 by Lauren.Ridge Fix for a crash when filtering a dropdown with no set value #jira UE-54631 Change 3863238 by Michael.Kirzinger #jira UE-52730: Fix mac voip crash Change 3862586 by Marc.Audy Clean up rendering thread heartbeat checks that got mangled in various integrations #jira Change 3862247 by Guillaume.Abadie Fixes editor lines that were using a simple element blending mode that was generating an incorrect alpha channel. #jira UE-53830 Change 3862120 by Guillaume.Abadie Fixes USceneCaptureComponent::HiddenActors always staying gray out in world editor. #jira UE-51458 Change 3861363 by Jamie.Dale Static analysis fixes #jira none Change 3861150 by Matt.Kuhlenschmidt Fix static mesh editor displaying 0 for all stats on LODs > 0 #jira UE-53776 Change 3860990 by Dan.Oconnor Clear subobjects not recreated on load, e.g. because we're running with -game and the subobject was created using CreateEditorOnlySubobject #jira UE-54551 Change 3860972 by Nick.Shin HTML5 - detect "SyntaxError: " and do a forced reload - an actual syntax error would be caught during compile time - this is usually error condition is usually seen when browser is running "old/partial" cached data and it's fairly safe to just reload the page #jira UE-54017 QAGame fails to launch properly on HTML5 Firefox 64 bit Change 3860951 by Arne.Schober Fix not releaseing SRV on render thread for FPositionVertexBuffer, FStaticMeshVertexBuffer, FColorVertexBuffer, FStaticMeshInstanceBuffer. #jira UE-54587 Change 3860950 by tim.gautier QAGame: Updating ML_Stone to include Texture Coordinate and Panner functions #jira UE-29618 Change 3860833 by Michael.Dupuis #jira UE-54181: Repopulate the foliage list when existing simulate mode Let the GC know that internal struct hold UObject ptr Change 3860762 by Jamie.Dale Ensure we invoke the correct version of Python from UBT #jira UE-54345 Change 3860676 by Simon.Tourangeau Remove DirectoryWatcher warning in output log #jira UEENT-846 Change 3860598 by Lauren.Ridge Fix for crash on opening new material instance #jira UE-54589 Change 3860338 by Michael.Lentine Integrate changes for fixing MorphTargets. #jira 54398 Change 3860215 by Ben.Marsh UAT: Fix exception consturcting target rules assembly inside UAT, now that there's an abstract TargetRules class. #jira UE-54578 Change 3860186 by Matt.Kuhlenschmidt Fix crash top 10 with the font editor shutting down and then a dpi event occuring #jira UE-54543 Change 3859854 by Graeme.Thornton PR #4124: VSCode: Changed VisualStudioCodeSourceCodeAccessor to work with non-default VSCode install paths on Linux (Contributed by christopherreed) #jira UE-51289 Change 3859848 by Graeme.Thornton Fix crypto.cs reading the wrong ini setting names for uasset encryption settings #jira UE-54566 Change 3859684 by Ben.Marsh PR #4436: Fix compile error when building BlankProgram because incorrect directory path (Contributed by windkey) #jira UE-54392 Change 3859657 by Ben.Marsh Fix FTransform being passed by value, causing alignment error when compiling for Win32. #jira Change 3859312 by nick.bullard Updating AEOverviewMan to remove reference to sub-level AEOverviewSWP which was deleted in 3859278 Still need to update menu to remove selection #jira UE-50784 Change 3859278 by Nick.Bullard Deleteing AEOverviewSWP.umap per request of Developer. Also updated TM-AnimPhys which refereneced this map as well. "This test map is a custom C++ implementation of a "procedural sound wave". This code is super janky and not worth fixing up. I'm sure there's a legit thread safety problem in there but the code is in QAGame only. We've since implemented "synth components" which do what this test does in a much safer/better way and maintaining/testing this old thing is *not* worth the time." #jira UE-50784 Change 3859124 by Dan.Oconnor Fix long standing crash when duplicating a blueprint that is missing its parent class. Entries in CrashReport go back to 4.16 #jira UE-54468 Change 3859086 by Ryan.Vance #jira UE-54470 We need to set the viewport in both cases. Change 3859006 by Dan.Oconnor Revise fix for archetype lookup when reinstancing. During compilation we do not want to force use of the up to date class #jira UE-54541 Change 3858990 by mason.seay Cleaned up blueprints to remove compile errors #jira UE-29618 Change 3858945 by Aaron.McLeran #jira UE-54265 PR #4428: Fixing Envelope Bug in AudioMixer (Contributed by Chrispykins) Change 3858719 by Aaron.McLeran #jira UE-54552 Fix for sample buffer reader Change 3858647 by Ethan.Geller PR #4439: Removes ambiX -> FuMa conversion (Contributed by mgorzel) #jira UE-54407 Change 3858364 by Michael.Dupuis #jira UE-52049: There was a case where adding and removing multiple time would lead to reordering the instances and this would cause the regeneration of the random stream for all the reorded instances. Change 3858268 by Dan.Oconnor Prevent postload logic running on REINST and SKEL classes #jira UE-54531 Change 3858205 by Mitchell.Wilson Removed particle looping from some emitters to resolve anim notify warnings. #jira UE-53823 Change 3858148 by Lauren.Ridge Changes based on Material Layer Feedback from previews - (Temporary) Disabled being able to create a layer or blend in the asset dropdown - Sections of the stack that have been disabled now inactivate that part of the UI - Create Function Instance now indicates if you are making a layer or a blend - Parent dropdown has been removed from layers and blends. Where relevant, a filter button has been added instead. #jira UETOOL-1328 Change 3857933 by Michael.Dupuis #jira UE-45854: Properly unregister callback when replacing foliage type with another one Change 3857898 by Michael.Dupuis #jira UE-54396: Remove the Ensure as it could be possible that the Landscape Info is invalid during an undo operation Change 3857878 by Max.Chen Sequencer: Assign the sequence id after the template is compiled. Copy from Dev-Sequencer #jira UE-54462 Change 3857808 by Michael.Dupuis #jira UE-54421: Prevent edition during Simulate when clicking on actor Change 3857786 by Rolando.Caloca UE4.19 - Fix recompute tangents and skin cache for OpenGL #jira UE-42108 PR #3271 Change 3857549 by Lina.Halper another jittering issue due to revision number change clear the motion vector after compile #jira: UE-53930 Change 3857439 by Lina.Halper Clear motion vector when end of sequencer when in editor world #jira:UE-54057 Change 3857384 by Graeme.Thornton Restore fix for visual studio source code accessor not correctly determining that a content project has no solution and opening a fresh instance of visual studio #jira UE-50020 Change 3856596 by Chris.Babcock Fix ResonanceAudioApi Android library architecture filtering #jira UE-54478 #ue4 #android Change 3856449 by Michael.Dupuis #jira UE-35097: Various cosmetic changes that were done in phase 2 that help improve clarity of the design. Change 3856415 by Dan.Oconnor Fix regression when loading instances that have had their class deleted. Issue detected by static analysis #jira UE-54467 Change 3856332 by Ben.Marsh Resaving TP_HandheldARBP assets to fix version again. #jira Change 3856319 by Ben.Marsh Back out changelist 3855588 Causes build failure in UFE because it introduces a dependency on the Engine module. UFE compiles with WITH_ENGINE = 0. #jira UE-54472 Change 3856292 by Ben.Marsh Fix app-local dependencies not being included in binary builds, and only working for code projects in source builds. #jira UE-54448 Change 3856190 by Martin.Wilson Fix bone access mismatch between raw mesh bones and final bones (that include virtual bones too) #jira UE-54266 Change 3856169 by Ben.Marsh Tag XGEControlWorker.exe as a build product, so it's included in the binary distro. #jira UE-54283 Change 3856123 by Chris.Babcock Fix missing ARCore file #jira UE-54453 #ue4 #android Change 3856005 by Richard.Wallis Clone of Dev-Rendering CL 3855993 - turn off FShaderCache. #jira UE-52928 Change 3855961 by Jian.Ru Copy 3855047 - fix DFAO Nan problem #jira UE-54403 Change 3855811 by Martin.Wilson Add build process for Maya Live Link plugin (standalone, manually triggered) + add built binaries to Engine/Extras (Maya 2016, Maya 2017, Maya 2018) #jira none Change 3855758 by Cosmin.Sulea UE-53569 - tvOS does not package or launch-on #jira UE-53569 Change 3855727 by Ben.Marsh Resaving assets with a versioned build in the editor, to fix warnings building DDC. #jira Change 3855626 by Adrian.Siminciuc https://jira.it.epicgames.net/browse/UE-50979 (MP4 doesn't resume playback when iOS 11 device wakes from sleep) #jira UE-50979 Change 3855588 by Graeme.Thornton Fix visual studio solution path being incorrect for content projects #jira UE-50020 Change 3855283 by Ben.Marsh Fix race condition where stdout/stderr write handles could be inherited by multiple processes, resulting in them not being closed (and the process exit being detected) until all processes that inherited them had been closed. Improves performance of ParallelExecutor. #jira Change 3855009 by Chance.Ivey Resaving with version number. #JIRA-54330 #rb none Change 3854943 by Dan.Oconnor Fix archetype lookup when searching hierarchy that has been partially reinstanced #jira UE-53840 Change 3854882 by Ryan.Vance #jira UE-54438 Removing vr related references to screen percentage. Removing previously removed gvr screen percentage code that came back in an integration from google. Change 3854806 by Mike.Beach Mirroring part of CL 3802176 to fix a crash that can occur when users try to use the default 'DisplayModel' on MotionController components. Also provided users a better error message to explain why a model might not be showing up. #jira UE-54214 Change 3854680 by Chance.Ivey Saving assets with version number#JIRA UE-54330 #rb none Change 3854652 by Uriel.Doyon Added a tooltip to the EV100 slider in the exposure menu. Using game settings now disables the slider. #jira UE-53945 Change 3854605 by Dan.Oconnor Make sure we don't create objects outered to a placeholder object, also make sure that archetypes that are reinstanced on load are relinked in to the linker table so that they are postload'd (and the old instance isn't) #jira UE-53954 Change 3854274 by Brandon.Schaefer Changes in CL 3842286 changed the function glslang::GlslangToSpv and requires a rebuild on Linux #jira UE-54302 #codeview Arciel.Rekman Change 3854255 by Phillip.Kavan Fix a scoping issue for local instanced subobject references in nativized Blueprint C++ code. Also, don't emit redundant assignment statements for instanced subobject reference properties. - Mirrored from //UE4/Dev-Framework (3853349). #jira UE-53960 Change 3854177 by Ethan.Geller #jira UE-54415 set EnabledByDefault to false for Resonance Audio Change 3854123 by Ethan.Geller #jira UE-54410 set AudioComponentID Change 3853775 by Lauren.Ridge Minor cleanup #jira UE-54054 Change 3853772 by Lauren.Ridge Don't create widgets when just testing if the selected widget is a replacement candidate #jira UE-54054 Change 3853715 by Rolando.Caloca UE4.19 - Fix for OpenGL overwriting texture units #jira UE-54401 Change 3853655 by Ben.Marsh Add a retry loop on creating the first directory before copying files. Attempt to work around problems copying to shared folders. #jira Change 3853535 by Ben.Marsh Expose the engine compatible changelist to Perforce. If EnginePatchVersion > 0, this will be the changelist of the original .0 release. #jira Change 3852583 by Nick.Atamas Resaved assets so they don't produce DDC warnings. #jira none Change 3852552 by Uriel.Doyon Fixed Pre-Exposure shader compilation and Temporal AA issue. #jira UE-54276 Change 3852354 by Nick.Atamas Hopefully fixes the static analysis warning from jira issue. #jira UE-54332 Change 3852281 by Nick.Atamas Merging CL 3851690 from //Tasks/UE4/Dev-VR-4.19a/... to //UE4/Telease-4.19/... #jira UE-54331 Change 3852274 by Simon.Tourangeau Back out changelist 3851041 until Win7 issue is resolved. #jira UE-54354 Change 3852208 by Jamie.Dale Merging CL# 3821754 from //UE4/Dev-Enterprise Class property conversion now goes through NativizeClass/PythonizeClass This allows it to coerce from Python wrapped object types #jira none Change 3852202 by Jamie.Dale More explicit handling of EngineDir for Python SDK #jira UE-54345 Change 3851982 by Brandon.Schaefer Workaround using a hardcoded path #jira UE-54136 Change 3851748 by Michael.Dupuis #jira UE-53904: Put the code back to what it was before, as we really only want to perform this code if bIsLayerThumbnail is true, it was changed to fix another issue complaining about a missing shader, that end up being added to the existing functions Change 3851545 by Marc.Audy Remove debugging code that slipped in #jira none Change 3851461 by Ben.Marsh Fix #includes with backslashes from crashing UBT. #jira UE-53996 Change 3851391 by Jamie.Dale Updated Python to prefer our TPS SDK #jira UE-54345 Change 3851372 by Jamie.Dale Added bat file to copy the Python SDK into TPS #jira UE-54345 Change 3851218 by Ben.Marsh Add missing template to installed engine build. #jira UE-54339 Change 3851117 by andrew.porter QAGame: Removing duplicate map #jira UE-29618 Change 3851041 by Simon.Tourangeau Support for DX11 quad buffer stereo rendering #jira UEENT-704 Change 3850548 by Ben.Marsh Add TP_HandheldARBP to installed engine build. #jira Change 3850424 by Ben.Zeigler Fix reported memory for asset registry to be correct, extracted from a larger change #jira none Change 3850324 by Ryan.Vance #jira UEVR-1050 Hook up the Rift dynamic res to the new IDynamicResolutionState framework Change 3849819 by JeanLuc.Corenthin Unhide Datasmith plugins in "regular" projects to allow easy project conversion #jira UEENT-795 Change 3849302 by Martin.Wilson Live Link is no longer experimental in 4.19 (moved from experimental folder to Animation) #jira none Change 3849238 by Max.Chen Sequencer: Remove bKeepStaleTracks so that stale tracks are now always purged. #jira UE-54248 Change 3849211 by Michael.Dupuis #jira UE-54181: Prevent foliage edition during PIE or simulate mode #coderevire jack.porter Change 3849123 by Benn.Gallagher Fixed crash in clothing actor creation when the clothing simulation mesh has no simulated vertices #jira UE-53741 Change 3849120 by Benn.Gallagher Fixed crash adding empty materials to destructible meshes in the destructible mesh editor #jira UE-53938 Change 3849047 by Jurre.deBaare Move material baking out of experimental #fix follow-up also remove the entry from experimental settings #jira UE-52685 Change 3848808 by Michael.Dupuis #jira UE-35097: Remove IncludeTessellationInShadowLOD & RestrictTessellationToShadowCascade from 4.19 as there is currently a bug regarding this in the dynamic rendering code path and would be too risky to fix for now. Fixed dynamic shadow code path issue vs static code path Change 3848659 by Lina.Halper Fix issue with animation resetting in the sequencer #jira: UE-54047 Change 3848635 by Rolando.Caloca UE4.19 - Fix static analysis #jira UE-50449 Change 3848515 by Sorin.Gradinaru Unshelved from pending changelist '3843541': WebBrowser Android crash on 4.4.3 #jira UE-53247 #Android #4.19 Crash on Android 4.x.x caused by a call to a Api Level 21 method Change 3848514 by Jurre.deBaare Moving over: CL 3832173 "Failed to import Alembic files #jira UE-53941 #fix Change Alembic thirdparty library setup - Removed old unused library files - Updated batch files for building HDF5 ILMBase and Alembic libraries to use new AlembicDeploy path - HDF5 is now build as a Dynamic library (which also enableds multi-threading) - Added DLLs for HDF5 to build.cs file CL 3838053 "Adding missing hdf5 dynamic libraries Change 3848245 by Ben.Marsh Downgrade warning about not using XGE shader compilation to a log message. Build machines do not have XGE. #jira UE-54237 Change 3847300 by Phillip.Kavan Fix shadowed local variable. #jira UE-54141 Change 3846922 by Max.Preussner ImgMedia: Fixed image media player never finished initialization if loading failed Copied from Dev-Sequencer CL# 3846902 #jira UE-54247 Change 3846831 by Arciel.Rekman Linux: only use lld for x86_64 (UE-54144). - lld support for other architectures seems to not ready for prime time. #jira UE-54144 Change 3846771 by Lauren.Ridge Material window now uses the background color set in preview scene. #jira UE-52215 Change 3846705 by Ben.Marsh Fix batch file paths not being quoted correctly when run through XGE. #jira Change 3846550 by Lauren.Ridge Toggling Show Background now updates the background as well #jira UE-52250 Change 3846417 by Matt.Kuhlenschmidt Fix crash resizing shootergame window #jira UE-53137 Change 3846295 by Rolando.Caloca UE4.19 - New Vulkan descriptor pooling mechanism (enabled on non-android) #jira UE-50449 Change 3846273 by tim.gautier QAGame: Updating Material Layer test assets to include more Params - Added temp assets, quicker repros for bugs #jira UE-54176, UE-54165 Change 3846255 by Lauren.Ridge Parameter tab is the primary tab for material instances #jira UE-54092 Change 3846086 by Chris.Babcock Add missing SecureHash.h include #jira UE-54026 #PR #4417 #ue4 #android Change 3846049 by Martin.Wilson Fix Set Root Motion Enabled Anim Data Modifier node (previously didn't set the enabled flag) #jira UE-54220 Change 3846033 by Martin.Wilson Fix root motion being repeatedly applied ( Clear() call only clears bHasRootMotion flag, not the transform itself ) #Jira UE-54219 Change 3845991 by andrew.porter QAGame: Updating bindings on activechannels sequencer test content #jira UE-29618 Change 3845933 by Lauren.Ridge Check for original material being valid #jira UE-54166 Change 3845920 by Martin.Wilson Optimized redundant key removal #jira UE-51303 Change 3845812 by Matt.Kuhlenschmidt Fix not being able to change BSP brush shape #jira UE-53738 Change 3845790 by Martin.Wilson Fix for assert failure when accumulating root motion in debug. #jira UE-53955 Change 3845730 by JeanLuc.Corenthin Fix build breakage warning: resaved disc.uasset with 4.19.0 preview #1 failure: set the correct default mesh for AreaLightStruct.uasset #jira none Change 3845693 by Lina.Halper Fix issue with previewing pose asset with curve data #jira: UE-53967 Change 3845533 by Andrew.Rodham Sequencer: Fixed sub sequences potentially being loaded during AddReferencedObjects #jira UE-54173 Change 3845472 by Thomas.Sarkanen Prevented debug object selection dropdown from displaying objects with pending kill outers #jira UE-54045 - Animation Blueprint Editor Crashes on Compile if the Debug Instance Selection is Other Than No Object or Preview Instance Change 3845401 by Yannick.Lange Reverting thumbnail capture from viewport. #jira UE-53775 #jira UE-53701 Change 3844693 by JeanMichel.Dignard Changed IES texture brightness to be the max candela value and set the texture multiplier to be 1. This fixes the IES lights intensity being too high. #jira UEENT-632 Change 3844689 by JeanLuc.Corenthin Update Datasmith content assets to latest Copying fix from Dev-Enterprise by Jean-Luc Corenthin CL 3809803 Updated assets with correct release version Cleanup some paths on static meshes and texture #jira UEENT-759 #jira UEENT-657 Change 3844571 by Martin.Wilson Fix motion controller motion source pin still showing when pin is connected to something #Jira UE-53236 Change 3844564 by Martin.Wilson Due to previously fixed bug some anim blueprint nodes could have duplicated guids, this fixes them #Jira UE-54174 Change 3844545 by Jamie.Dale No longer attempt to parse group separators for numeric inputs This avoids some ambiguity when parsing numbers for languages such as German #jira UE-54170 Change 3844221 by Nick.Shin HTML5 - filter out "windows/super" keys - these are not used in UE4 - but, keycode are not the expected "91 or 92" values, SDL keys are "227 & 231" instead... #jira UE-54056 HTML5 crashes inside browser upon pressing windows key Change 3843937 by JeanMichel.Dignard Fixed a crash when right clicking on a static mesh for which its AssetImportData class is currently unavailable (ie: in an unloaded plugin). #jira UEENT-764 Change 3843929 by Peter.Sauerbrei pull over fix for bad directory when copying launch images #jira UE-53177 Change 3843658 by Thomas.Sarkanen Text is red again in anim viewports #jira UE-53224 - Colouring removed from "Animation is being edited" warning messages Change 3843657 by Thomas.Sarkanen Enable picking via Enter for details panel asset pickers The previous (4.18) behavior was to only allow selection of the previous/next item in the list with arrow keys. A fix (CL 3783114) for pickers with many assets broke this. This change now allows for selection of any item by navigating with arrow keys and pressing Enter, as suggested in the Jira. #jira UE-53440 - Unable to select assets within modal Asset Selection dropdowns after navigating with keyboard entry Change 3843120 by Dan.Oconnor Avoid fixing component template games outside the editor, this logic does not work for games that have been nativized #jira UE-54009 Change 3842841 by Ben.Zeigler #jira UE-50020 Switch visual studio module back to using absolute paths so go to definition works, broken in CL #3796157 Change 3842582 by Lauren.Ridge Guards against the widget passed to scrollwidgetintoview being null #jira UE-54037 Change 3842575 by Max.Chen Sequence Recorder: Stop recording if the preview window is destroyed. #jira UE-49778 Change 3842551 by Michael.Dupuis #jira UE-35097: Minor bug fix, documentation, etc. to the landscape optim that was done in the phase 2 that have 0 risk. Change 3842371 by Max.Preussner Media: Merged 4.19 fixes from Dev-Sequencer CL 3807293 WmfMedia: Fixed YUY2 video format strides CL 3827988 MediaPlayerAssets: Fixed Media Texture is not linked to Media Player when created together CL 3805414 MediaAssets: Setting valid GUID when initializing media texture resource CL 3804183 MediaAssets: Added missing lock in media sound component CL 3831580 MfMedia: Media open events generated in same order as on other platforms CL 3807193 WmfMedia: Fixed incorrect buffer stride for RGB32 video tracks #jira UE-53532 #jira UE-53328 Change 3842356 by Max.Preussner ImgMedia: Fixed ensure when cooking project that uses ImgMediaSource #jira UE-51631 Change 3842335 by Aaron.McLeran #jira UE-54087 PR #4419: Fixes a crash due to nullptr dereference (Contributed by mgorzel) Change 3842286 by Rolando.Caloca UE4.19 - Fix for static analysis - Glslang 1.0.65.1 #jira UE-54128 Change 3842222 by andrew.porter QAGame: Updating framerate of EXR_Sequence #jira UE-29618 Change 3842211 by Ben.Marsh Fix determination of Windows version string. The manifest for UE4 applications declares compatibility with Windows 10 nowadays, so we get accurate version numbers returned from GetOSVersionInfo(). #jira UE-54035 Change 3842163 by Cosmin.Sulea UE-53303 - We do not check for remote connection before attempting remote shader compile, causing crashes when misconfigured #jira UE-53303 Change 3841770 by Max.Chen Sequencer: Fix to allow keying of an arbitrarily deep property path. #jira UE-54095 Change 3841758 by Max.Chen Sequencer: Fix unbound possessable components when pasting spawnables. #jira UE-54104 Change 3841415 by Lauren.Ridge Renaming a material layer or material layer blend will no longer cause the asset to appear removed from the stack #jira UE-53942 Change 3841327 by Arciel.Rekman Linux: fix Debug build (UE-53855) - A workaround. UBT should be using proper PCH files instead. #jira UE-53855 Change 3840975 by Rolando.Caloca UE4.19 - Updated VulkanRHI - Fixes for GPU frame time - Fixes for CPU performance #jira UE-50449 Change 3840838 by Michael.Dupuis #jira UE-53944: Make sure the LOD generated is in the valid range to prevent the crash Change 3840693 by Ben.Zeigler #jira UE-53923 Fix regression in 4.19 where PrintScriptCallstack is not always safe to call from the immediate window. I narrowed down the issue to some confusing optimized code so I turned off optimization Copy of CL #3840692 Change 3840680 by Aaron.McLeran Bringing fixes from Dev-AnimPhys to 4.19. #jira UE-53903 crash on load with oculus audio and old audio engine #jira UE-52786, UE-53910 Fix for broken spatialization on xaudio2, old audio engine. Change 3840663 by Rolando.Caloca UE4.19 - Fix for layout ensure on HMD projects on Vulkan #jira UE-50265 Change 3840577 by Rolando.Caloca UE4.19 - Fix for CPUs with more than 16 cores #jira UE-53434 Change 3840551 by andrew.porter QAGame: Setting Allow Bindings from Asset to false #jira UE-29618 Change 3840491 by Ben.Zeigler #jira UE-31662 Fix regression with renaming parent inherited function. It was not correctly searching the parent's skeleton class during the child's recompile so it was erroneously detecting the parent function as missing Copy of CL #3840489 Change 3840297 by Max.Chen Sequencer: Fix copy/paste crash for lights #jira UE-54084 Change 3840284 by Michael.Dupuis #jira UE-53053: Was having a mismatch between the remove reorder and the actual remove Change 3840215 by Sorin.Gradinaru Unshelved from pending changelist '3812852': UE-53550 Level doesn't render on Lenovo 939 UE-53592 Assertion right after rendering scene on Lenovo S939 #jira UE-53550 #jira UE-53592 #4.19 #Android UE-53550 Removed force disabling texture2DLodEXT and textureCubeLodEXT on Mali-400 devices The problem was that the shader compiler complains about code lines before the #extension directives. Placeholder // end extensions in the original shader code - to be replaced with round() functions UE-53592 Always use a new task for devices that have GIsThreadedRendering=false, even when the call is from the rendering thread Change 3840048 by Michael.Dupuis #jira UE-52975: Was always performing the equivalent of an Add, so now we use the Transform during the duplicate Change 3840005 by Richard.Wallis Clone of CL 3835252 Fix for shader library not working with iterative cooking, also fixes native Metal library not working with iterative cook. This works by saving a "backup" of the shader library file - this is reloaded only during iterative cook and adds back in shaders that are missing from the current cook. Fix for extracting/searching .metal files in different directories so debug tgz archiving wasn't working correctly and also support iterative cook. Includes first pass code review suggestions by Mark Sat and Dmitriy Dyomin. #jira UE-53815 Change 3839968 by Michael.Dupuis #jira UE-52289: When OnRegister is called on the component make sure our PerInstanceRenderData is up to date Prevent a possible crash if ClearInstanceSelection was called on a component with no PerInstanceRenderData existing ##codereview jack.porter Change 3839924 by Richard.Wallis Clone of CL 3838093 Fix for rewind / seek bugs in AvfMediaPlayer. - Don't initialise and send audio buffers that have a duration of Zero from the audio tap. This chokes the audio sink and adds overhead we don't need. - Don't faff around with current play rates during loop operation - normal seek doesn't do this so loop seek shouldn't either. - SetRate() should not required to be passed to media tracks - should be enough to do this on audio track select only. #jira UE-54019, UE-53027 Change 3839321 by andrew.porter QAGame: Adding missing bookmark to QA-Sequencer_Blending #jira UE-29618 Change 3839286 by Marcus.Wassmer Duplicate CL: 3823296 #jira UE-52784 Change 3839229 by Brandon.Schaefer Fix audio clean up crash when exiting PIE #jira UE-54050 #review-3839109 @Arciel.Rekman, @Aaron.McLeran Change 3839223 by andrew.porter QAGame: Rebinding pointlight actor to sequences #jira UE-29618 Change 3839098 by andrew.porter QAGame: Fixing missing sequencer blending test content #jira UE-29618 Change 3838919 by Mike.Erwin glTF: binary format's BIN chunk is not necessarily right after the JSON chunk. Discussed this with glTF spec authors. See https://github.com/KhronosGroup/glTF/issues/1177 Rearranged how we read "chunks" from the file since they are not fixed in number or order, besides JSON always being first. #jira UE-50695 Change 3838909 by Mike.Erwin glTF: base64 decoding of data buffers and images Data can be encoded inside the glTF JSON as a Base64 data URI. This CL addresses a known limitation of initial commit CL 3793018. I added this after because base64 is expected to be uncommon in the wild. Authoring software will typically use external BIN files (.gltf) or a BIN chunk (.glb) to store data. #jira UE-50695 Change 3838812 by Uriel.Doyon Integrated CL 3838576, 3838581 and 3831760 from DevRendering, fixing issues with texture streaming. #jira none Change 3838773 by Lauren.Ridge Fixing material layer filters #jira UE-54064 Change 3838748 by Michael.Trepka Fixed EngineTest runtime warning caused by CL 3838626 #jira UE-53893 Change 3838730 by Max.Chen Sequencer: Add notification when the blend type is changed. #jira UE-54046 Change 3838626 by Michael.Trepka Changed FMacMenu to store MultiBox and MenuEntryBox as weak pointers instead of shared pointers. This way we avoid a situation where FMacMenu would try to release them on the main Cocoa thread or where we'd try to execute a menu action for menu items that Slate considers released. #jira UE-53893 Change 3838392 by Arciel.Rekman Fix assert on a policy removal (UE-54042). - Applying Gil's safe fix which just sweeps the problem under the rug. #jira UE-54042 Change 3838162 by Arciel.Rekman Linux: fix crash due to lambda lifetime issues (UE-54040). - The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+). #jira UE-54040 (Edigrating 3819174 to Release-4.19) Change 3838156 by Rolando.Caloca UE4.19 - Support for Vulkan devices that have no cached memory type #jira UE-54039 Change 3838096 by Brandon.Schaefer Set sound to unfocused volume multiplier if not focused #jira UE-51327 #review-3835736 arciel.rekman Change 3838087 by Brandon.Schaefer Fix arm server building. A fix from CL 3617084 remove inheriting from IHeadMountedDisplayVulkanExtensions. Remove overrides #jira UE-53901 #review-3838088 arciel.rekman Change 3837072 by Phillip.Kavan Fix for a build failure that could occur with Blueprint nativization enabled and EDL disabled. This was a regression introduced in 4.18. - Mirrored from //UE4/Dev-Framework (3836768). #jira UE-53908 Change 3837071 by Phillip.Kavan Emit proper syntax for set/map fields containing converted assets to generated C++ Blueprint class headers when Blueprint nativization is enabled. - Mirrored from //UE4/Dev-Framework (3835944, 3835965). #jira UE-42614 Change 3837070 by Phillip.Kavan #4202 - Blueprint nativization bug fixes (PR). - Mirrored from //UE4/Dev-Framework (3830562, 3832292). #jira UE-52188 Change 3836507 by Ryan.Vance #jira UE-53992 Due to hijacking the depth target directly from the scene context, we can't support depth compositing if it's being scaled by screen percentage since it wont match our color render target dimensions. Change 3836390 by Dan.Oconnor Fix failure to resolve archetype when using the compilation manager #jira UE-53840 Change 3836251 by Ryan.Vance #jira UE-53992 Change 3835852 by Mark.Satterthwaite Fix tessellation shaders in Metal with Manual Vertex Fetch enabled: - The control points idnex buffer shouldn't collide with anything else. - We can't use the optimisation of loading texture width & height from the buffer meta-table in tessellation shaders as the combined stages don't guarantee not to clobber unused buffer slots and screw it up when we use linear textures. #jira UE-53851 Change 3835802 by JeanMichel.Dignard UBT changes for Enterprise deployment - Allow building enterprise against an installed engine version - Added enterprise to the cleanup process if its not installed #jira UEENT-748 Change 3835625 by Bogdan.Vasilache UE-50257 --> (Skeletal meshes silently fail to render if they have more than 75 bones) --> changed logged error with a warning #jira UE-50257 Change 3833649 by Mike.Beach Enabling debug layer when multiview is enabled. #jira UE-49954 Change 3833525 by Ethan.Geller Fix copyright in ActiveSound.cpp #jira none #rb none Change 3642649 by Stewart.Lynch Renamed loctext key to stop it clashing with an existing entry #jira UE-49432 Change 3644762 by Stewart.Lynch LLM update: Added Total, Untracked and FMalloc Unused to LLMFULL stat page. Fixed occasionally missing allocs/frees. Removed platform csv. * removed CheckSize arg from OnLowLevelFree * show a warning in LLM Map when replacing existing value. This means that there has been an alloc/free mismatch. * minor optimization in LLMMap::GetMaxIndex - cache Mask value * added Total and Untracked stats to LLMFULL. LLMFULL now tracks almost all of the memory that LLMPlatform does, so there is no real need to use LLMPlatform. Removed the LLMPlatform csv. * added FMalloc Unused stat to LLMFULL to account for memory Binned2 has allocated internally. This can be used to track Binned2 fragmentation over time. * renamed Binned stats to FMemory to make it more general * added Default tracking to CustomVirtualAlloc and disable it where necessary. This catches the few VirtualAlloc calls that were missed. * added AllocType arg to all allocation tracking. This was needed in order to track the FMalloc total, and also to fix the pausing * fixed a bug in pausing where alloc/frees were being missed. Now only pauses a specific allocation type. * Trackers now maintain totals for each enum tag * tracking of Texture and mesh allocation on Windows D3D11 & D3D12 Change 3651334 by Joe.Barnes Fix misspelled function name. #jira 39441 #3016 Change 3653857 by Ben.Woodhouse Integrate from //UE4/Main/...@3653675 to //UE4/Dev-Console/... Change 3656553 by Joe.Barnes Add path for SCS_DeviceDepth. Change 3662703 by Ben.Woodhouse Merging CL 3659069 from //Fortnite/Main/... to to //ue4/dev-console/...: [FORTNITE] [CONSOLE] [+] Improved frame syncing mechanism - Improves input latency by allowing the game thread to sync to the swap chain flip of the previous frame. - Added "r.GTSyncType" CVar to control how the game thread syncs with the rest of the pipe. - r.GTSyncType 2 will sync the game thread with the flip of the swap chain, preventing the pipe from getting too long and causing excess input latency. Platforms are required to implement RHIWaitForFlip and RHISignalFlipEvent, and call RHIInitializeFlipTracking on RHI startup. A separate thread monitors the progress of frame flips and signals task graph events as they pass their corresponding frame index. In r.GTSyncType 2 mode, the game thread is signaled by this flip tracking thread. [~] Unified platform specific sync interval CVars into one: rhi.SyncInterval - 1 == 60Hz - 2 == 30Hz - 3 == 20Hz Change 3675239 by Keith.Judge Fixed thread priorities for Windows so that BelowNormal and SlightlyBelowNormal are the same. Bumped Lowest down a notch so they all fit. #jira UE-50626 Change 3676709 by Ben.Woodhouse Integrate from //UE4/Main/...@3675008 to //UE4/Dev-Console/... Change 3689712 by Ben.Woodhouse Integrate from //UE4/Main/...@3687781 to //UE4/Dev-Console/... Change 3701778 by Ben.Woodhouse Integrate from //UE4/Main/...@3699491 to //UE4/Dev-Console/... Change 3677043 by Ben.Woodhouse From StewartL: I also found that on Windows Fortnite is overflowing int32 values due to the number of allocations. I changed LLMArray and LLMMap to use uint32 and it seems to be Ok now. I didn't want to check this in at the last minute, so here's the shelf: 3645336 Change 3726532 by Luke.Thatcher [CONSOLE] [~] Enable XGE shader compilation by default. - Also set XGE mode to "force interception". With XGE on by default, we don't want people with an old Incredibuild version using the old system inadvertently. Change 3726554 by Luke.Thatcher [CONSOLE] [+] Improved Scoped Named Events - Added SCOPED_NAMED_EVENT(_FSTRING/_TEXT/_F) macros to allow use of string literals, FString and printf in scoped named event strings. - Replaced explicit use of FPlatformMisc::Begin/EndNamedEvent throughout the engine with macros, so the events can be compiled out. - Fixed performance issues on various platforms with named events. SCOPED_NAMED_EVENT macros were not considering whether the platform uses wide or ansi char strings. Change 3751378 by Ben.Woodhouse Integrate from //UE4/Main/...@3748735 to //UE4/Dev-Console/... Change 3751812 by Ben.Woodhouse Integrate from //UE4/Main/...@3750870 to //UE4/Dev-Console/... Change 3728571 by Luke.Thatcher [CONSOLE] [!] Drop another XGE controller warning to log. Change 3747150 by Joe.Barnes Add AuthoringToolHelper.bat file to installed build copy list. Change 3768585 by Ben.Woodhouse Integrate from //UE4/Main/...@3767531 to //UE4/Dev-Console/... Change 3772333 by Ben.Woodhouse Integrate from //UE4/Main/...@3771573 to //UE4/Dev-Console/... Change 3786872 by Ben.Woodhouse Integrate from //UE4/Main/...@3786785 to //UE4/Dev-Console/... Change 3787279 by Luke.Thatcher [CONSOLE] [~] Unified present threshold CVars. - CVars are now in RHIUtilities.cpp, and are renamed to rhi.PresentThreshold.Top and rhi.PresentThreshold.Bottom. - Platform implementations will be checked in shortly. Change 3787445 by Luke.Thatcher [CONSOLE] [^] Merging (as edit) improvements to low-latency frame syncing from //Fortnite/Main to //UE4/Dev-Console Original CLs - 3708949 - Added rhi.SyncSlackMS cvar to allow an offset of the game thread sync time by a number of milliseconds. - 3712693 - Fix for crash on startup in new frame syncing. - 3735765 - Fix r.GTSyncType logic when vsync is disabled (falls back to old behaviour when vsync is off). Change 3788417 by Ben.Woodhouse Duplicate from FN CL 3712515 CSV profiler GPU and pre-declared stat support - refactor the GPU profiler so it's no longer dependent on the stats system and can work in Test builds - add support for pre-declared CSV stats, using FNames (these are required for GPU stats) - add DECLARE_GPU_STAT macro which handles STATS and CsvProfiler declarations Note: still a few issues to resolve with GPU stats: these randomly go to 0 at times during a replay on XB1, the GPU total is lower than the stat unit number, and the unaccounted stat is too large due to missing stats Change 3807818 by Ben.Woodhouse Integrate from //UE4/Main/...@3803271 to //UE4/Dev-Console/... Change 3818577 by Ben.Woodhouse Integrate from //UE4/Main/...@3812936 to //UE4/Dev-Console/... Change 3821198 by Ben.Woodhouse Integrate from //UE4/Release-4.19/...@3820127 to //UE4/Dev-Console/... Change 3821519 by Ben.Woodhouse Integrate from //UE4/Release-4.19/...@3820753 to //UE4/Dev-Console/... #robomerge none Change 3813513 by Ben.Woodhouse CSV profiler refactor+ bug fix - Move the CSV profiler to core, so we can use it in modules other than engine - Profiler no longer enqueues RT commands - this is handled by a new core delegate type - Make begin/end requests more robust, enqueued via a command queue and processed in order - Defer end capture requests by a frame. This ensures stats on threads other than the gamethread (e.g. renderthread etc) are complete, so the last frame is not truncated - Fix long-standing bug with multiple captures where old/stale frames would appear in the first <128 frames of captures - Move unit stats and dynamic resolution out of the profiler itself and into the engine. Only frametime is recorded in the profiler now - Fix longstanding bug in first frame renderthread time in the engine Change 3814039 by Ben.Woodhouse More Csvprofiler improvements - Event support (via CSV_EVENT macros). These appear in the "EVENTS" column of the CSV and can be used to add context to the stat data - Reduced memory overhead for timestamps through bit-packing (now 16 bytes per marker instead of 24), and splitting stats into different types Change 3814041 by Ben.Woodhouse Integrate as edit CL 3796390 from Fortnite/Main: Fix CsvProfiler not compiling in shipping for now Change 3814229 by Ben.Woodhouse Integrate + refactor of CL 3792591 to reduce complexity and fix bugs Original changelist description: CSV profiler improvements: - The CSV profiler is now always compiled in on the server - The CSV profiler can now handle both int32 and float stats - In BeginCapture, the function can take additional arguments for some customization of filenames Fixes to the above: - Remove FCustomValue class - Fixes bug where all timestamp values from CSV_SCOPED_STATs were garbage (due to issues resulting from FCustomValue type ambiguity when adding values together) - FCsvCustomStat now just uses simple union + bitfield flag to reduce size and complexity (4 bytes instead of 8 per value) - FCsvColumn class modified to use doubles, which can represent both ints and floats without loss of precision - this class is not memory or time critical - Replace multiple overrides used by the server for filenameprefix/folder/postfix etc with a single FilenameOverride Change 3814242 by Ben.Woodhouse Disable CSV unit stats on the dedicated server Change 3817339 by Ben.Woodhouse Duplicate from 3816641: CSV profiler improvements - Added a low-pri processing thread to compress raw timing data into a much more efficient format - Reduces memory usage for 15 minute 30k frame capture with GPU stats enabled from 110MB to 3.4MB - Processing time : 0.1ms per frame - Improved name handling for char literal stats. We now use the string as the ID rather than the pointer so multiple stat uses of the same name string apply only to a single stat - Reworked thread data access to eliminate locking for anything time-critical. Frame boundaries now handled via a lock-free helper class - Fixed bug with queue implementation where 1 in 128 reads would duplicate the last block of stat data - Reduced #include dependencies for CSVProfiler.h - Removed AccumulateMax because it doesn't work, and implementing properly would add a lot of complexity - Added a simple test harness Change 3817582 by Ben.Woodhouse Fix android compile warning Change 3823242 by Ben.Woodhouse Integrate as edit from Fortnite/Main 3820067: Fix threading issue with D3D12 pipeline state caches for windows. This was caused by the usage of FRwScopeLock::RaiseLockToWrite. A pointer read before RaiseLockToWrite was called was invalidated because RaiseLockToWrite has to release the read lock before acquiring the write lock. Rename FRwScopeLock::RaiseLockToWrite to ReleaseReadOnlyLockAndAcquireWriteLock_USE_WITH_CAUTION to make it more explicit what's happening. As the comment says: // This function should be used with caution. // It releases the read lock _before_ acquiring a new write lock. This is not an atomic operation and the caller should // not treat it as such. // E.g. Pointers read from protected data structures prior to this call may be invalid after the function is called. Change 3823840 by Ben.Woodhouse Edigrate from 3823816 Fix an issue where the csvprofile console commands would sometimes result in an empty CSV. The root cause was GFrameNumber incrementing between the console command being read and FCSVProfiler::EndFrame(). We now use our own frame counter which is updated in EndFrame, so this can't happen Also fix an issue where calling csvprofile stop twice would cause all further commands to be ignored. Change 3827787 by Ben.Woodhouse Integrate-as-edit CL 3820678 from Fortnite/Main Allow the CSV Profiler to be compiled in to shipping dedicated server builds Change 3827842 by Ben.Woodhouse Integrate-as-edit CL 3827079 from Fortnite/Main CSV profiler category support Change 3827918 by Luke.Thatcher [CONSOLE] [!] Fix compile error in CSV custom stats. Change 3827964 by Luke.Thatcher [CONSOLE] [!] Fix inverted logic and spelling of boolean. - Functionally, the boolean did the correct thing, but the logic was backwards inside the build tool. Change 3831661 by Ben.Woodhouse Integrate-as-edit CL 3830630 from Fortnite/Main Fix CSVProfiler assert in dev builds on XB1 Change 3860300 by Joe.Barnes Use same method for src and dest rect calculation as other post processing passes so rects match between passes. Prevents read of unprocessed pixels. Change 3860347 by Joe.Barnes Delete existing SourceConfigFile before allocating a new one to prevent them leaking. Change 3860348 by Joe.Barnes Completely encapsulate GetLLMAlloc() in #ifdef. Change 3861772 by Ben.Woodhouse Integrate-as-edit CL 3861688 from Fortnite/Main: Forward lighting GPU crash fixes Change 3861774 by Ben.Woodhouse Integrate as edit CL 3833918 from dev-rendering (courtesy of DanielW): D3D12 RHI: only refcount uniform buffers if GRHINeedsExtraDeletionLatency is false, which is no longer the case for PC. The refcounting was heavy on performance as reported by a licensee because FRHIResource uses atomics for refcounting, which is only necessary when GRHINeedsExtraDeletionLatency is disabled. Change 3862214 by Ben.Woodhouse Integrate-as-edit CL 3859637 from Fortnite/Main Dynamic resolution console tweaks - Dynamic resolution high level switch driven by a cvar instead of code - Disable user settings dynamic resolution handling on non-desktop platforms. DynamicRes as a user setting does not make sense on consoles/mobile - we'll drive it from device profiles/scalability - Modify naming of GPUHeadRoom to make it clear that it's a percentage, not millseconds Change 3863919 by Ben.Woodhouse [Copy] Integrate console dynamic resolution interface changes from CL 3863354, 3862754, 3862639 Change 3864347 by Ben.Woodhouse Fix the editor build. This will need a proper fix before 4.19 ships. #lockdown Nick.Penwarden #rb none [CL 3913399 by Ben Marsh in Main branch]
2018-02-27 17:30:35 -05:00
if (NumKeyPinsWithLinks == 0 && (OutputPin->PinType.PinCategory == UEdGraphSchema_K2::PC_Wildcard && Pin->LinkedTo[0]->PinType.PinCategory != UEdGraphSchema_K2::PC_Wildcard))
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
{
FEdGraphTerminalType TerminalType = MoveTemp(OutputPin->PinType.PinValueType);
OutputPin->PinType = Pin->LinkedTo[0]->PinType;
OutputPin->PinType.PinValueType = MoveTemp(TerminalType);
OutputPin->PinType.ContainerType = ContainerType;
bNotifyGraphChanged = true;
}
Copying //UE4/Release-Staging-4.19 to //UE4/Dev-Main (Source: //UE4/Release-4.19 @ 3873914) ============================ MAJOR FEATURES & CHANGES ============================ Change 3873906 by Dan.Oconnor Revised fix for preventing delegate functions from appearing in context menu when using the compilation manager - needed to run after CallDelegateHandler changed statement type #jira UE-51726 Change 3873614 by Dan.Oconnor Prevent delegate functions from appearing in context menu when using the compilation manager and prevent crash if such a function is somehow compiled #jira UE-51726 Change 3873428 by Ben.Zeigler #jira UE-54753 Fix class pin on SpawnActorFromClass to correctly support browse. It was inherting from the wrong pin widget Copy of 3873408 Change 3873083 by Ethan.Geller [4.19]#jira UE-54865 fix seconds -> milliseconds conversion issue. #rb aaron.mcleran #lockdown cristina.riveron Change 3872714 by Dan.Oconnor Further revise fix for UE-53840, mistakenly reverted to old behavior when compiling synchronously #jira UE-53840 Change 3872648 by Ben.Zeigler #jira UE-54845 Fix crash in NextDebugTarget when there are no valid debug targets Copy of CL #3872636 Change 3872500 by Arne.Schober Back out changelist 3870283 #jira UE-54838 Change 3872412 by Mark.Satterthwaite Remove now unnecessary r.Metal.ManualVertexFetch from the device profiles. #jira UE-54853 Change 3872313 by Martin.Wilson Add UI to Live Link Client to warn live link users about background performance throttling #jira none Change 3872272 by Martin.Wilson Fix crash when clearing a skeletal mesh on a skeletal mesh component with an active Post Process Anim Instance #jira none Change 3872238 by Mark.Satterthwaite Duplicate CL #3871025 Make Manual Vertex Fetch a property of the shader platform for Metal - only the desktop platforms (METAL SM5/SM5_NoTess/MRT) will use manual vertex fetch. The mobile platforms use vertex descriptors. Prevents problems with cooked versions of games not working properly on Metal due to a mismatch between the runtime's Manual-Vertex-Fetch state versus the state used by the cooker when compiling shaders. #jira UE-54843 Change 3872087 by Yasiman.Ahsani Adding Python, libdisasm, musl, and LSS licenses. #JIRA n/a - adding licenses for new TPS Change 3872037 by Ben.Marsh BuildGraph: Add a task for compiling MSBuild projects. #jira Change 3871934 by Lina.Halper #jira: UE-54703 Change 3871595 by Michael.Trepka Fixed a problem with Mac editor not exiting with error code returned from GuardedMain function #jira UE-54830 Change 3870829 by Joe.Barnes Fix unintentional change to PhysX libs used in Debug builds. #jira ue-54817 Change 3870820 by Nick.Atamas Copying //Tasks/UE4/Dev-VR-4.19a@3870772 to Release-4.19 (//UE4/Release-4.19) #jira UE-54816 Change 3870755 by Chance.Ivey Min Android version set - should fix camera permissions issue found in #JIRA UE-54024 #rb none #fyi nick.atamas Change 3870547 by Krzysztof.Narkowicz Fixed FreezeRendering on non editor builds: ComputeAndMarkRelevanceForViewParallel was calling FrozenMatricesGuard on multiple threads, reading and writing view matrices state in parallel. #jira UE-53640 Change 3870546 by Krzysztof.Narkowicz Fixed tesselation shader tex/uniform initialization in OpenGL3/4 path #jira UE-54471 Change 3870284 by Ben.Zeigler #jira UE-54583 Fix issue where loading multiple already loaded assets via Async Load Asset node could return the wrong asset on the loaded pin. The assign variable node was happening at a slightly wrong time Copy of CL #3870279 Change 3870283 by Arne.Schober SafeRelease SRVs that might be hold by the Vertexfactories (maybe due to indirect use in GlobalResources) Note that the VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should be uneccessary #jira none Change 3870098 by Ben.Marsh Fix OptimizeCode = CodeOptimization.Always causing compile errors in Linux debug builds. bUseInlining was not set correctly on the global compile environment used to build shared PCHs. Also fixed other settings not being propogated down from the target correctly. #jira UE-53855 Change 3870013 by Ben.Marsh UBT: Add an error if a user attempts to clean a target through hot-reload, rather than just failing to delete DLLs because they are locked. #jira UE-54179 Change 3870010 by Ben.Marsh UBT: Add an option to format output messages in a form that can be parsed by MSBuild. Prevents errors showing as "EXEC: Error:", and displays them correctly in the error list window. #jira Change 3869814 by Ben.Marsh UBT: Unify command line arguments to use -Name=Value syntax. -Module <Name>, -ModuleWithSuffix <Name> <Suffix>, -Plugin <Path> and -Receipt <Path> are no longer supported. Also remove the RemoteRoot option, which was not used anywhere. #jira Change 3869786 by Martin.Wilson Fix Live Link Remove Source button not working #Jira UE-54652 Change 3869660 by Martin.Wilson Fix missing message bus sources in the live link client (not repolling for new sources) #Jira UE-54712 Change 3869659 by Guillaume.Abadie Fixes SimpleComposure's BP_AdvancedCompositing keep allocating memory every frame. Credits for fixing the issue to Ron Radeztsk. #jira UE-54780 Change 3869401 by Lauren.Ridge Adding to the conditional in FindAllAncestorNamedSlotHostWidgetsForContent #jira UE-51470 Change 3869384 by Brandon.Schaefer Open the project in the explorer when NullSourceCodeAccess is done creating the project #jira UE-54630 Change 3869308 by Ben.Marsh PR #4452: Fixed FindFilesRecursively in IPlatformFilePak (Contributed by user37337) #jira UE-54568 Change 3869265 by Martin.Wilson Fix crash and subsequently found issues with unloading/reloading Maya Live Link plugin -Crash on reload due to core code getting reinitialize, made this a one time only thing (as Maya never gets rid of the module from memory) -Added manual ticking of FTicker, allows message bus objects to be cleaned up properly (cannot do this as part of normal flow as it is in engine code which we dont have) -rebuild binaries for Engine/Extras #Jira UE-54643 Change 3869206 by Benn.Gallagher Fixed crash updating clothing paint mode after tab spawners have been destroyed by the hosting application. #jira UE-54116 Change 3869064 by Benn.Gallagher Resolved skeletal mesh data changes and clothing section disable changes after collision. Re-added ability to disable sections at the mesh level and removed the ability to strip editor sections as these are required for a number of other features to correctly function. #jira UE-52557 Change 3869062 by Guillaume.Abadie Fixes "dynamic resolution is not supported on this platform" warning message being always visible. #jira UE-54655 Change 3868202 by Lauren.Ridge Fix for assert on expanding vector param in layered material #jira UE-54737 Change 3868161 by zak.parrish Replacing FaceARDebugUI with a blank UI until a new one can be created, due to a crash bug. #rb none #JIRA UE-54639 Change 3867750 by Ethan.Geller [4.19] #jira UE-54725 Fix for Envelope attack and release values not being properly set on Synth Components #rb aaron.mcleran #lockdown cristina.riveron Change 3867657 by Lauren.Ridge Adding if with editor wrapper to new function #jira cis fix Change 3867646 by Aaron.McLeran #jira UE-53867 Access violation on Switch when playing sound with specified time out of range Change 3867340 by Lauren.Ridge Fixes to Material Layers from 4.19 preview feedback -Need to pass through base attributes better/have better default nodes in layer (optional Example Layers and Blends checkbox now enables this in Experimental Settings) -Parent in function should be editable -Enforce only two layers in a blend -Mat layer should warn if it has incorrect output in the layer itself -Enforce not being able to delete outputs -Warn about creating a MAL node inside a function #jira UETOOL-1312 Change 3867317 by Aaron.McLeran #jira UE-53867 Access violation on Switch when playing sound with specified time out of range Change 3867000 by Lauren.Ridge Fix for folder favorites possibly becoming very large #jira UE-54704 Change 3866892 by Martin.Wilson Fix crash if clicking ok on message bus add source without having a source selected #jira UE-54572 Change 3866391 by Matt.Kuhlenschmidt Fix static analysis #jira UE-53379 Change 3866241 by Ryan.Vance #jira UE-54681 Fixed missing Vulkan texture GetNativeResource implementation that was lost in a bad merge. Change 3866071 by Nick.Shin UDN 412414 update HTMl5 readme file #jira none Change 3866005 by Max.Preussner Messaging: Preventing dangling references when removing message subscribers #jira UE-54680 Change 3865988 by Simon.Tourangeau Fix static analysis warnings #jira none Change 3865895 by zachary.wilson Renaming QA-PhysicalLightUnits to TM-PhysicalLightUnits in QAGame. #JIRA UE-29618 Change 3865469 by Simon.Tourangeau Support for DX11 quad buffer stereo rendering #jira UEENT-704 Change 3865461 by Chris.Babcock Add a wait for audio thread to pause audio on going to background #jira UE-54301 #ue4 #android Change 3865350 by Matt.Kuhlenschmidt Fix issue where cascade emitter UI would disapper #jira UE-53379 Change 3865336 by Arne.Schober REL - Fix UE-52356 Bone Weight #jira UE-52356 Change 3865257 by Ben.Marsh Fix editor failing to load content-only projects when compiled in DebugGame. #jira UE-54661 Change 3865238 by Simon.Tovey Pulling Olaf's fix from 3832595 over to release #tests EngineTests boots in vulkan #JIRA UE-54394 Change 3865191 by Sorin.Gradinaru UE-54317 DXT apps fail on first launch when 'For Distribution' enabled, Unsupported Texture Format #jira UE-54317 #Android #4.19 From //Dev-Mobile/3863322 Change 3865190 by Sorin.Gradinaru UE-54175 Selecting For Distribution no longer sets configuration to Shipping #UE4 #4.19 #jira UE-54175 From //Dev-Mobile/3863371 "For Distribution" enable-> reset "Build COnfiguration" to Shipping and force serialization to DefaultGame.ini (see UE-52845) Change 3865056 by Jamie.Dale Fixed culture being incorrect when added via the Localization Dashboard #jira none Change 3864826 by Max.Preussner WmfMedia: Added missing scope lock #jira UE-54365 Change 3864055 by Aaron.McLeran #jira UE-54213 Crash fix for GC'd plugin settings objects. Adding to AddReferencedObjects. Change 3863775 by Andrew.Porter MediaFrameworkTest: Removing Platform Media Source TVOS test content #jira UE-29618 Change 3863714 by Dan.Oconnor Make array, set, and map nodes no longer switch object type when a pin is disconnected. Also, you can no longer attach unrelated map types to the MakeMap node if only the value pin has been inferred #jira UE-54634 Change 3863696 by Max.Chen Sequencer: Fix crash open a new sequence while another is still active. #jira UE-54620 #jira UE-54624 Change 3863638 by Dan.Oconnor Make sure all blueprints that are skeleton compiled get a BroadcastChanged notification, also run BroadcastChanged after reinstancing, matching pre compilation manager behavior #jira UE-54193 Change 3863494 by Jamie.Dale Ensure Py_SetPythonHome is set correctly before the embedded Python interpreter is initialized #jira UE-54345 Change 3863433 by Max.Preussner MediaPlayerEditor: Removed tvOS from list of available platforms in Platform Media Source assets tvOS currently reports itself as iOS, so it cannot have its own setting. #jira UE-54559 Change 3863406 by Lauren.Ridge Fix for a crash when filtering a dropdown with no set value #jira UE-54631 Change 3863238 by Michael.Kirzinger #jira UE-52730: Fix mac voip crash Change 3862586 by Marc.Audy Clean up rendering thread heartbeat checks that got mangled in various integrations #jira Change 3862247 by Guillaume.Abadie Fixes editor lines that were using a simple element blending mode that was generating an incorrect alpha channel. #jira UE-53830 Change 3862120 by Guillaume.Abadie Fixes USceneCaptureComponent::HiddenActors always staying gray out in world editor. #jira UE-51458 Change 3861363 by Jamie.Dale Static analysis fixes #jira none Change 3861150 by Matt.Kuhlenschmidt Fix static mesh editor displaying 0 for all stats on LODs > 0 #jira UE-53776 Change 3860990 by Dan.Oconnor Clear subobjects not recreated on load, e.g. because we're running with -game and the subobject was created using CreateEditorOnlySubobject #jira UE-54551 Change 3860972 by Nick.Shin HTML5 - detect "SyntaxError: " and do a forced reload - an actual syntax error would be caught during compile time - this is usually error condition is usually seen when browser is running "old/partial" cached data and it's fairly safe to just reload the page #jira UE-54017 QAGame fails to launch properly on HTML5 Firefox 64 bit Change 3860951 by Arne.Schober Fix not releaseing SRV on render thread for FPositionVertexBuffer, FStaticMeshVertexBuffer, FColorVertexBuffer, FStaticMeshInstanceBuffer. #jira UE-54587 Change 3860950 by tim.gautier QAGame: Updating ML_Stone to include Texture Coordinate and Panner functions #jira UE-29618 Change 3860833 by Michael.Dupuis #jira UE-54181: Repopulate the foliage list when existing simulate mode Let the GC know that internal struct hold UObject ptr Change 3860762 by Jamie.Dale Ensure we invoke the correct version of Python from UBT #jira UE-54345 Change 3860676 by Simon.Tourangeau Remove DirectoryWatcher warning in output log #jira UEENT-846 Change 3860598 by Lauren.Ridge Fix for crash on opening new material instance #jira UE-54589 Change 3860338 by Michael.Lentine Integrate changes for fixing MorphTargets. #jira 54398 Change 3860215 by Ben.Marsh UAT: Fix exception consturcting target rules assembly inside UAT, now that there's an abstract TargetRules class. #jira UE-54578 Change 3860186 by Matt.Kuhlenschmidt Fix crash top 10 with the font editor shutting down and then a dpi event occuring #jira UE-54543 Change 3859854 by Graeme.Thornton PR #4124: VSCode: Changed VisualStudioCodeSourceCodeAccessor to work with non-default VSCode install paths on Linux (Contributed by christopherreed) #jira UE-51289 Change 3859848 by Graeme.Thornton Fix crypto.cs reading the wrong ini setting names for uasset encryption settings #jira UE-54566 Change 3859684 by Ben.Marsh PR #4436: Fix compile error when building BlankProgram because incorrect directory path (Contributed by windkey) #jira UE-54392 Change 3859657 by Ben.Marsh Fix FTransform being passed by value, causing alignment error when compiling for Win32. #jira Change 3859312 by nick.bullard Updating AEOverviewMan to remove reference to sub-level AEOverviewSWP which was deleted in 3859278 Still need to update menu to remove selection #jira UE-50784 Change 3859278 by Nick.Bullard Deleteing AEOverviewSWP.umap per request of Developer. Also updated TM-AnimPhys which refereneced this map as well. "This test map is a custom C++ implementation of a "procedural sound wave". This code is super janky and not worth fixing up. I'm sure there's a legit thread safety problem in there but the code is in QAGame only. We've since implemented "synth components" which do what this test does in a much safer/better way and maintaining/testing this old thing is *not* worth the time." #jira UE-50784 Change 3859124 by Dan.Oconnor Fix long standing crash when duplicating a blueprint that is missing its parent class. Entries in CrashReport go back to 4.16 #jira UE-54468 Change 3859086 by Ryan.Vance #jira UE-54470 We need to set the viewport in both cases. Change 3859006 by Dan.Oconnor Revise fix for archetype lookup when reinstancing. During compilation we do not want to force use of the up to date class #jira UE-54541 Change 3858990 by mason.seay Cleaned up blueprints to remove compile errors #jira UE-29618 Change 3858945 by Aaron.McLeran #jira UE-54265 PR #4428: Fixing Envelope Bug in AudioMixer (Contributed by Chrispykins) Change 3858719 by Aaron.McLeran #jira UE-54552 Fix for sample buffer reader Change 3858647 by Ethan.Geller PR #4439: Removes ambiX -> FuMa conversion (Contributed by mgorzel) #jira UE-54407 Change 3858364 by Michael.Dupuis #jira UE-52049: There was a case where adding and removing multiple time would lead to reordering the instances and this would cause the regeneration of the random stream for all the reorded instances. Change 3858268 by Dan.Oconnor Prevent postload logic running on REINST and SKEL classes #jira UE-54531 Change 3858205 by Mitchell.Wilson Removed particle looping from some emitters to resolve anim notify warnings. #jira UE-53823 Change 3858148 by Lauren.Ridge Changes based on Material Layer Feedback from previews - (Temporary) Disabled being able to create a layer or blend in the asset dropdown - Sections of the stack that have been disabled now inactivate that part of the UI - Create Function Instance now indicates if you are making a layer or a blend - Parent dropdown has been removed from layers and blends. Where relevant, a filter button has been added instead. #jira UETOOL-1328 Change 3857933 by Michael.Dupuis #jira UE-45854: Properly unregister callback when replacing foliage type with another one Change 3857898 by Michael.Dupuis #jira UE-54396: Remove the Ensure as it could be possible that the Landscape Info is invalid during an undo operation Change 3857878 by Max.Chen Sequencer: Assign the sequence id after the template is compiled. Copy from Dev-Sequencer #jira UE-54462 Change 3857808 by Michael.Dupuis #jira UE-54421: Prevent edition during Simulate when clicking on actor Change 3857786 by Rolando.Caloca UE4.19 - Fix recompute tangents and skin cache for OpenGL #jira UE-42108 PR #3271 Change 3857549 by Lina.Halper another jittering issue due to revision number change clear the motion vector after compile #jira: UE-53930 Change 3857439 by Lina.Halper Clear motion vector when end of sequencer when in editor world #jira:UE-54057 Change 3857384 by Graeme.Thornton Restore fix for visual studio source code accessor not correctly determining that a content project has no solution and opening a fresh instance of visual studio #jira UE-50020 Change 3856596 by Chris.Babcock Fix ResonanceAudioApi Android library architecture filtering #jira UE-54478 #ue4 #android Change 3856449 by Michael.Dupuis #jira UE-35097: Various cosmetic changes that were done in phase 2 that help improve clarity of the design. Change 3856415 by Dan.Oconnor Fix regression when loading instances that have had their class deleted. Issue detected by static analysis #jira UE-54467 Change 3856332 by Ben.Marsh Resaving TP_HandheldARBP assets to fix version again. #jira Change 3856319 by Ben.Marsh Back out changelist 3855588 Causes build failure in UFE because it introduces a dependency on the Engine module. UFE compiles with WITH_ENGINE = 0. #jira UE-54472 Change 3856292 by Ben.Marsh Fix app-local dependencies not being included in binary builds, and only working for code projects in source builds. #jira UE-54448 Change 3856190 by Martin.Wilson Fix bone access mismatch between raw mesh bones and final bones (that include virtual bones too) #jira UE-54266 Change 3856169 by Ben.Marsh Tag XGEControlWorker.exe as a build product, so it's included in the binary distro. #jira UE-54283 Change 3856123 by Chris.Babcock Fix missing ARCore file #jira UE-54453 #ue4 #android Change 3856005 by Richard.Wallis Clone of Dev-Rendering CL 3855993 - turn off FShaderCache. #jira UE-52928 Change 3855961 by Jian.Ru Copy 3855047 - fix DFAO Nan problem #jira UE-54403 Change 3855811 by Martin.Wilson Add build process for Maya Live Link plugin (standalone, manually triggered) + add built binaries to Engine/Extras (Maya 2016, Maya 2017, Maya 2018) #jira none Change 3855758 by Cosmin.Sulea UE-53569 - tvOS does not package or launch-on #jira UE-53569 Change 3855727 by Ben.Marsh Resaving assets with a versioned build in the editor, to fix warnings building DDC. #jira Change 3855626 by Adrian.Siminciuc https://jira.it.epicgames.net/browse/UE-50979 (MP4 doesn't resume playback when iOS 11 device wakes from sleep) #jira UE-50979 Change 3855588 by Graeme.Thornton Fix visual studio solution path being incorrect for content projects #jira UE-50020 Change 3855283 by Ben.Marsh Fix race condition where stdout/stderr write handles could be inherited by multiple processes, resulting in them not being closed (and the process exit being detected) until all processes that inherited them had been closed. Improves performance of ParallelExecutor. #jira Change 3855009 by Chance.Ivey Resaving with version number. #JIRA-54330 #rb none Change 3854943 by Dan.Oconnor Fix archetype lookup when searching hierarchy that has been partially reinstanced #jira UE-53840 Change 3854882 by Ryan.Vance #jira UE-54438 Removing vr related references to screen percentage. Removing previously removed gvr screen percentage code that came back in an integration from google. Change 3854806 by Mike.Beach Mirroring part of CL 3802176 to fix a crash that can occur when users try to use the default 'DisplayModel' on MotionController components. Also provided users a better error message to explain why a model might not be showing up. #jira UE-54214 Change 3854680 by Chance.Ivey Saving assets with version number#JIRA UE-54330 #rb none Change 3854652 by Uriel.Doyon Added a tooltip to the EV100 slider in the exposure menu. Using game settings now disables the slider. #jira UE-53945 Change 3854605 by Dan.Oconnor Make sure we don't create objects outered to a placeholder object, also make sure that archetypes that are reinstanced on load are relinked in to the linker table so that they are postload'd (and the old instance isn't) #jira UE-53954 Change 3854274 by Brandon.Schaefer Changes in CL 3842286 changed the function glslang::GlslangToSpv and requires a rebuild on Linux #jira UE-54302 #codeview Arciel.Rekman Change 3854255 by Phillip.Kavan Fix a scoping issue for local instanced subobject references in nativized Blueprint C++ code. Also, don't emit redundant assignment statements for instanced subobject reference properties. - Mirrored from //UE4/Dev-Framework (3853349). #jira UE-53960 Change 3854177 by Ethan.Geller #jira UE-54415 set EnabledByDefault to false for Resonance Audio Change 3854123 by Ethan.Geller #jira UE-54410 set AudioComponentID Change 3853775 by Lauren.Ridge Minor cleanup #jira UE-54054 Change 3853772 by Lauren.Ridge Don't create widgets when just testing if the selected widget is a replacement candidate #jira UE-54054 Change 3853715 by Rolando.Caloca UE4.19 - Fix for OpenGL overwriting texture units #jira UE-54401 Change 3853655 by Ben.Marsh Add a retry loop on creating the first directory before copying files. Attempt to work around problems copying to shared folders. #jira Change 3853535 by Ben.Marsh Expose the engine compatible changelist to Perforce. If EnginePatchVersion > 0, this will be the changelist of the original .0 release. #jira Change 3852583 by Nick.Atamas Resaved assets so they don't produce DDC warnings. #jira none Change 3852552 by Uriel.Doyon Fixed Pre-Exposure shader compilation and Temporal AA issue. #jira UE-54276 Change 3852354 by Nick.Atamas Hopefully fixes the static analysis warning from jira issue. #jira UE-54332 Change 3852281 by Nick.Atamas Merging CL 3851690 from //Tasks/UE4/Dev-VR-4.19a/... to //UE4/Telease-4.19/... #jira UE-54331 Change 3852274 by Simon.Tourangeau Back out changelist 3851041 until Win7 issue is resolved. #jira UE-54354 Change 3852208 by Jamie.Dale Merging CL# 3821754 from //UE4/Dev-Enterprise Class property conversion now goes through NativizeClass/PythonizeClass This allows it to coerce from Python wrapped object types #jira none Change 3852202 by Jamie.Dale More explicit handling of EngineDir for Python SDK #jira UE-54345 Change 3851982 by Brandon.Schaefer Workaround using a hardcoded path #jira UE-54136 Change 3851748 by Michael.Dupuis #jira UE-53904: Put the code back to what it was before, as we really only want to perform this code if bIsLayerThumbnail is true, it was changed to fix another issue complaining about a missing shader, that end up being added to the existing functions Change 3851545 by Marc.Audy Remove debugging code that slipped in #jira none Change 3851461 by Ben.Marsh Fix #includes with backslashes from crashing UBT. #jira UE-53996 Change 3851391 by Jamie.Dale Updated Python to prefer our TPS SDK #jira UE-54345 Change 3851372 by Jamie.Dale Added bat file to copy the Python SDK into TPS #jira UE-54345 Change 3851218 by Ben.Marsh Add missing template to installed engine build. #jira UE-54339 Change 3851117 by andrew.porter QAGame: Removing duplicate map #jira UE-29618 Change 3851041 by Simon.Tourangeau Support for DX11 quad buffer stereo rendering #jira UEENT-704 Change 3850548 by Ben.Marsh Add TP_HandheldARBP to installed engine build. #jira Change 3850424 by Ben.Zeigler Fix reported memory for asset registry to be correct, extracted from a larger change #jira none Change 3850324 by Ryan.Vance #jira UEVR-1050 Hook up the Rift dynamic res to the new IDynamicResolutionState framework Change 3849819 by JeanLuc.Corenthin Unhide Datasmith plugins in "regular" projects to allow easy project conversion #jira UEENT-795 Change 3849302 by Martin.Wilson Live Link is no longer experimental in 4.19 (moved from experimental folder to Animation) #jira none Change 3849238 by Max.Chen Sequencer: Remove bKeepStaleTracks so that stale tracks are now always purged. #jira UE-54248 Change 3849211 by Michael.Dupuis #jira UE-54181: Prevent foliage edition during PIE or simulate mode #coderevire jack.porter Change 3849123 by Benn.Gallagher Fixed crash in clothing actor creation when the clothing simulation mesh has no simulated vertices #jira UE-53741 Change 3849120 by Benn.Gallagher Fixed crash adding empty materials to destructible meshes in the destructible mesh editor #jira UE-53938 Change 3849047 by Jurre.deBaare Move material baking out of experimental #fix follow-up also remove the entry from experimental settings #jira UE-52685 Change 3848808 by Michael.Dupuis #jira UE-35097: Remove IncludeTessellationInShadowLOD & RestrictTessellationToShadowCascade from 4.19 as there is currently a bug regarding this in the dynamic rendering code path and would be too risky to fix for now. Fixed dynamic shadow code path issue vs static code path Change 3848659 by Lina.Halper Fix issue with animation resetting in the sequencer #jira: UE-54047 Change 3848635 by Rolando.Caloca UE4.19 - Fix static analysis #jira UE-50449 Change 3848515 by Sorin.Gradinaru Unshelved from pending changelist '3843541': WebBrowser Android crash on 4.4.3 #jira UE-53247 #Android #4.19 Crash on Android 4.x.x caused by a call to a Api Level 21 method Change 3848514 by Jurre.deBaare Moving over: CL 3832173 "Failed to import Alembic files #jira UE-53941 #fix Change Alembic thirdparty library setup - Removed old unused library files - Updated batch files for building HDF5 ILMBase and Alembic libraries to use new AlembicDeploy path - HDF5 is now build as a Dynamic library (which also enableds multi-threading) - Added DLLs for HDF5 to build.cs file CL 3838053 "Adding missing hdf5 dynamic libraries Change 3848245 by Ben.Marsh Downgrade warning about not using XGE shader compilation to a log message. Build machines do not have XGE. #jira UE-54237 Change 3847300 by Phillip.Kavan Fix shadowed local variable. #jira UE-54141 Change 3846922 by Max.Preussner ImgMedia: Fixed image media player never finished initialization if loading failed Copied from Dev-Sequencer CL# 3846902 #jira UE-54247 Change 3846831 by Arciel.Rekman Linux: only use lld for x86_64 (UE-54144). - lld support for other architectures seems to not ready for prime time. #jira UE-54144 Change 3846771 by Lauren.Ridge Material window now uses the background color set in preview scene. #jira UE-52215 Change 3846705 by Ben.Marsh Fix batch file paths not being quoted correctly when run through XGE. #jira Change 3846550 by Lauren.Ridge Toggling Show Background now updates the background as well #jira UE-52250 Change 3846417 by Matt.Kuhlenschmidt Fix crash resizing shootergame window #jira UE-53137 Change 3846295 by Rolando.Caloca UE4.19 - New Vulkan descriptor pooling mechanism (enabled on non-android) #jira UE-50449 Change 3846273 by tim.gautier QAGame: Updating Material Layer test assets to include more Params - Added temp assets, quicker repros for bugs #jira UE-54176, UE-54165 Change 3846255 by Lauren.Ridge Parameter tab is the primary tab for material instances #jira UE-54092 Change 3846086 by Chris.Babcock Add missing SecureHash.h include #jira UE-54026 #PR #4417 #ue4 #android Change 3846049 by Martin.Wilson Fix Set Root Motion Enabled Anim Data Modifier node (previously didn't set the enabled flag) #jira UE-54220 Change 3846033 by Martin.Wilson Fix root motion being repeatedly applied ( Clear() call only clears bHasRootMotion flag, not the transform itself ) #Jira UE-54219 Change 3845991 by andrew.porter QAGame: Updating bindings on activechannels sequencer test content #jira UE-29618 Change 3845933 by Lauren.Ridge Check for original material being valid #jira UE-54166 Change 3845920 by Martin.Wilson Optimized redundant key removal #jira UE-51303 Change 3845812 by Matt.Kuhlenschmidt Fix not being able to change BSP brush shape #jira UE-53738 Change 3845790 by Martin.Wilson Fix for assert failure when accumulating root motion in debug. #jira UE-53955 Change 3845730 by JeanLuc.Corenthin Fix build breakage warning: resaved disc.uasset with 4.19.0 preview #1 failure: set the correct default mesh for AreaLightStruct.uasset #jira none Change 3845693 by Lina.Halper Fix issue with previewing pose asset with curve data #jira: UE-53967 Change 3845533 by Andrew.Rodham Sequencer: Fixed sub sequences potentially being loaded during AddReferencedObjects #jira UE-54173 Change 3845472 by Thomas.Sarkanen Prevented debug object selection dropdown from displaying objects with pending kill outers #jira UE-54045 - Animation Blueprint Editor Crashes on Compile if the Debug Instance Selection is Other Than No Object or Preview Instance Change 3845401 by Yannick.Lange Reverting thumbnail capture from viewport. #jira UE-53775 #jira UE-53701 Change 3844693 by JeanMichel.Dignard Changed IES texture brightness to be the max candela value and set the texture multiplier to be 1. This fixes the IES lights intensity being too high. #jira UEENT-632 Change 3844689 by JeanLuc.Corenthin Update Datasmith content assets to latest Copying fix from Dev-Enterprise by Jean-Luc Corenthin CL 3809803 Updated assets with correct release version Cleanup some paths on static meshes and texture #jira UEENT-759 #jira UEENT-657 Change 3844571 by Martin.Wilson Fix motion controller motion source pin still showing when pin is connected to something #Jira UE-53236 Change 3844564 by Martin.Wilson Due to previously fixed bug some anim blueprint nodes could have duplicated guids, this fixes them #Jira UE-54174 Change 3844545 by Jamie.Dale No longer attempt to parse group separators for numeric inputs This avoids some ambiguity when parsing numbers for languages such as German #jira UE-54170 Change 3844221 by Nick.Shin HTML5 - filter out "windows/super" keys - these are not used in UE4 - but, keycode are not the expected "91 or 92" values, SDL keys are "227 & 231" instead... #jira UE-54056 HTML5 crashes inside browser upon pressing windows key Change 3843937 by JeanMichel.Dignard Fixed a crash when right clicking on a static mesh for which its AssetImportData class is currently unavailable (ie: in an unloaded plugin). #jira UEENT-764 Change 3843929 by Peter.Sauerbrei pull over fix for bad directory when copying launch images #jira UE-53177 Change 3843658 by Thomas.Sarkanen Text is red again in anim viewports #jira UE-53224 - Colouring removed from "Animation is being edited" warning messages Change 3843657 by Thomas.Sarkanen Enable picking via Enter for details panel asset pickers The previous (4.18) behavior was to only allow selection of the previous/next item in the list with arrow keys. A fix (CL 3783114) for pickers with many assets broke this. This change now allows for selection of any item by navigating with arrow keys and pressing Enter, as suggested in the Jira. #jira UE-53440 - Unable to select assets within modal Asset Selection dropdowns after navigating with keyboard entry Change 3843120 by Dan.Oconnor Avoid fixing component template games outside the editor, this logic does not work for games that have been nativized #jira UE-54009 Change 3842841 by Ben.Zeigler #jira UE-50020 Switch visual studio module back to using absolute paths so go to definition works, broken in CL #3796157 Change 3842582 by Lauren.Ridge Guards against the widget passed to scrollwidgetintoview being null #jira UE-54037 Change 3842575 by Max.Chen Sequence Recorder: Stop recording if the preview window is destroyed. #jira UE-49778 Change 3842551 by Michael.Dupuis #jira UE-35097: Minor bug fix, documentation, etc. to the landscape optim that was done in the phase 2 that have 0 risk. Change 3842371 by Max.Preussner Media: Merged 4.19 fixes from Dev-Sequencer CL 3807293 WmfMedia: Fixed YUY2 video format strides CL 3827988 MediaPlayerAssets: Fixed Media Texture is not linked to Media Player when created together CL 3805414 MediaAssets: Setting valid GUID when initializing media texture resource CL 3804183 MediaAssets: Added missing lock in media sound component CL 3831580 MfMedia: Media open events generated in same order as on other platforms CL 3807193 WmfMedia: Fixed incorrect buffer stride for RGB32 video tracks #jira UE-53532 #jira UE-53328 Change 3842356 by Max.Preussner ImgMedia: Fixed ensure when cooking project that uses ImgMediaSource #jira UE-51631 Change 3842335 by Aaron.McLeran #jira UE-54087 PR #4419: Fixes a crash due to nullptr dereference (Contributed by mgorzel) Change 3842286 by Rolando.Caloca UE4.19 - Fix for static analysis - Glslang 1.0.65.1 #jira UE-54128 Change 3842222 by andrew.porter QAGame: Updating framerate of EXR_Sequence #jira UE-29618 Change 3842211 by Ben.Marsh Fix determination of Windows version string. The manifest for UE4 applications declares compatibility with Windows 10 nowadays, so we get accurate version numbers returned from GetOSVersionInfo(). #jira UE-54035 Change 3842163 by Cosmin.Sulea UE-53303 - We do not check for remote connection before attempting remote shader compile, causing crashes when misconfigured #jira UE-53303 Change 3841770 by Max.Chen Sequencer: Fix to allow keying of an arbitrarily deep property path. #jira UE-54095 Change 3841758 by Max.Chen Sequencer: Fix unbound possessable components when pasting spawnables. #jira UE-54104 Change 3841415 by Lauren.Ridge Renaming a material layer or material layer blend will no longer cause the asset to appear removed from the stack #jira UE-53942 Change 3841327 by Arciel.Rekman Linux: fix Debug build (UE-53855) - A workaround. UBT should be using proper PCH files instead. #jira UE-53855 Change 3840975 by Rolando.Caloca UE4.19 - Updated VulkanRHI - Fixes for GPU frame time - Fixes for CPU performance #jira UE-50449 Change 3840838 by Michael.Dupuis #jira UE-53944: Make sure the LOD generated is in the valid range to prevent the crash Change 3840693 by Ben.Zeigler #jira UE-53923 Fix regression in 4.19 where PrintScriptCallstack is not always safe to call from the immediate window. I narrowed down the issue to some confusing optimized code so I turned off optimization Copy of CL #3840692 Change 3840680 by Aaron.McLeran Bringing fixes from Dev-AnimPhys to 4.19. #jira UE-53903 crash on load with oculus audio and old audio engine #jira UE-52786, UE-53910 Fix for broken spatialization on xaudio2, old audio engine. Change 3840663 by Rolando.Caloca UE4.19 - Fix for layout ensure on HMD projects on Vulkan #jira UE-50265 Change 3840577 by Rolando.Caloca UE4.19 - Fix for CPUs with more than 16 cores #jira UE-53434 Change 3840551 by andrew.porter QAGame: Setting Allow Bindings from Asset to false #jira UE-29618 Change 3840491 by Ben.Zeigler #jira UE-31662 Fix regression with renaming parent inherited function. It was not correctly searching the parent's skeleton class during the child's recompile so it was erroneously detecting the parent function as missing Copy of CL #3840489 Change 3840297 by Max.Chen Sequencer: Fix copy/paste crash for lights #jira UE-54084 Change 3840284 by Michael.Dupuis #jira UE-53053: Was having a mismatch between the remove reorder and the actual remove Change 3840215 by Sorin.Gradinaru Unshelved from pending changelist '3812852': UE-53550 Level doesn't render on Lenovo 939 UE-53592 Assertion right after rendering scene on Lenovo S939 #jira UE-53550 #jira UE-53592 #4.19 #Android UE-53550 Removed force disabling texture2DLodEXT and textureCubeLodEXT on Mali-400 devices The problem was that the shader compiler complains about code lines before the #extension directives. Placeholder // end extensions in the original shader code - to be replaced with round() functions UE-53592 Always use a new task for devices that have GIsThreadedRendering=false, even when the call is from the rendering thread Change 3840048 by Michael.Dupuis #jira UE-52975: Was always performing the equivalent of an Add, so now we use the Transform during the duplicate Change 3840005 by Richard.Wallis Clone of CL 3835252 Fix for shader library not working with iterative cooking, also fixes native Metal library not working with iterative cook. This works by saving a "backup" of the shader library file - this is reloaded only during iterative cook and adds back in shaders that are missing from the current cook. Fix for extracting/searching .metal files in different directories so debug tgz archiving wasn't working correctly and also support iterative cook. Includes first pass code review suggestions by Mark Sat and Dmitriy Dyomin. #jira UE-53815 Change 3839968 by Michael.Dupuis #jira UE-52289: When OnRegister is called on the component make sure our PerInstanceRenderData is up to date Prevent a possible crash if ClearInstanceSelection was called on a component with no PerInstanceRenderData existing ##codereview jack.porter Change 3839924 by Richard.Wallis Clone of CL 3838093 Fix for rewind / seek bugs in AvfMediaPlayer. - Don't initialise and send audio buffers that have a duration of Zero from the audio tap. This chokes the audio sink and adds overhead we don't need. - Don't faff around with current play rates during loop operation - normal seek doesn't do this so loop seek shouldn't either. - SetRate() should not required to be passed to media tracks - should be enough to do this on audio track select only. #jira UE-54019, UE-53027 Change 3839321 by andrew.porter QAGame: Adding missing bookmark to QA-Sequencer_Blending #jira UE-29618 Change 3839286 by Marcus.Wassmer Duplicate CL: 3823296 #jira UE-52784 Change 3839229 by Brandon.Schaefer Fix audio clean up crash when exiting PIE #jira UE-54050 #review-3839109 @Arciel.Rekman, @Aaron.McLeran Change 3839223 by andrew.porter QAGame: Rebinding pointlight actor to sequences #jira UE-29618 Change 3839098 by andrew.porter QAGame: Fixing missing sequencer blending test content #jira UE-29618 Change 3838919 by Mike.Erwin glTF: binary format's BIN chunk is not necessarily right after the JSON chunk. Discussed this with glTF spec authors. See https://github.com/KhronosGroup/glTF/issues/1177 Rearranged how we read "chunks" from the file since they are not fixed in number or order, besides JSON always being first. #jira UE-50695 Change 3838909 by Mike.Erwin glTF: base64 decoding of data buffers and images Data can be encoded inside the glTF JSON as a Base64 data URI. This CL addresses a known limitation of initial commit CL 3793018. I added this after because base64 is expected to be uncommon in the wild. Authoring software will typically use external BIN files (.gltf) or a BIN chunk (.glb) to store data. #jira UE-50695 Change 3838812 by Uriel.Doyon Integrated CL 3838576, 3838581 and 3831760 from DevRendering, fixing issues with texture streaming. #jira none Change 3838773 by Lauren.Ridge Fixing material layer filters #jira UE-54064 Change 3838748 by Michael.Trepka Fixed EngineTest runtime warning caused by CL 3838626 #jira UE-53893 Change 3838730 by Max.Chen Sequencer: Add notification when the blend type is changed. #jira UE-54046 Change 3838626 by Michael.Trepka Changed FMacMenu to store MultiBox and MenuEntryBox as weak pointers instead of shared pointers. This way we avoid a situation where FMacMenu would try to release them on the main Cocoa thread or where we'd try to execute a menu action for menu items that Slate considers released. #jira UE-53893 Change 3838392 by Arciel.Rekman Fix assert on a policy removal (UE-54042). - Applying Gil's safe fix which just sweeps the problem under the rug. #jira UE-54042 Change 3838162 by Arciel.Rekman Linux: fix crash due to lambda lifetime issues (UE-54040). - The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+). #jira UE-54040 (Edigrating 3819174 to Release-4.19) Change 3838156 by Rolando.Caloca UE4.19 - Support for Vulkan devices that have no cached memory type #jira UE-54039 Change 3838096 by Brandon.Schaefer Set sound to unfocused volume multiplier if not focused #jira UE-51327 #review-3835736 arciel.rekman Change 3838087 by Brandon.Schaefer Fix arm server building. A fix from CL 3617084 remove inheriting from IHeadMountedDisplayVulkanExtensions. Remove overrides #jira UE-53901 #review-3838088 arciel.rekman Change 3837072 by Phillip.Kavan Fix for a build failure that could occur with Blueprint nativization enabled and EDL disabled. This was a regression introduced in 4.18. - Mirrored from //UE4/Dev-Framework (3836768). #jira UE-53908 Change 3837071 by Phillip.Kavan Emit proper syntax for set/map fields containing converted assets to generated C++ Blueprint class headers when Blueprint nativization is enabled. - Mirrored from //UE4/Dev-Framework (3835944, 3835965). #jira UE-42614 Change 3837070 by Phillip.Kavan #4202 - Blueprint nativization bug fixes (PR). - Mirrored from //UE4/Dev-Framework (3830562, 3832292). #jira UE-52188 Change 3836507 by Ryan.Vance #jira UE-53992 Due to hijacking the depth target directly from the scene context, we can't support depth compositing if it's being scaled by screen percentage since it wont match our color render target dimensions. Change 3836390 by Dan.Oconnor Fix failure to resolve archetype when using the compilation manager #jira UE-53840 Change 3836251 by Ryan.Vance #jira UE-53992 Change 3835852 by Mark.Satterthwaite Fix tessellation shaders in Metal with Manual Vertex Fetch enabled: - The control points idnex buffer shouldn't collide with anything else. - We can't use the optimisation of loading texture width & height from the buffer meta-table in tessellation shaders as the combined stages don't guarantee not to clobber unused buffer slots and screw it up when we use linear textures. #jira UE-53851 Change 3835802 by JeanMichel.Dignard UBT changes for Enterprise deployment - Allow building enterprise against an installed engine version - Added enterprise to the cleanup process if its not installed #jira UEENT-748 Change 3835625 by Bogdan.Vasilache UE-50257 --> (Skeletal meshes silently fail to render if they have more than 75 bones) --> changed logged error with a warning #jira UE-50257 Change 3833649 by Mike.Beach Enabling debug layer when multiview is enabled. #jira UE-49954 Change 3833525 by Ethan.Geller Fix copyright in ActiveSound.cpp #jira none #rb none Change 3642649 by Stewart.Lynch Renamed loctext key to stop it clashing with an existing entry #jira UE-49432 Change 3644762 by Stewart.Lynch LLM update: Added Total, Untracked and FMalloc Unused to LLMFULL stat page. Fixed occasionally missing allocs/frees. Removed platform csv. * removed CheckSize arg from OnLowLevelFree * show a warning in LLM Map when replacing existing value. This means that there has been an alloc/free mismatch. * minor optimization in LLMMap::GetMaxIndex - cache Mask value * added Total and Untracked stats to LLMFULL. LLMFULL now tracks almost all of the memory that LLMPlatform does, so there is no real need to use LLMPlatform. Removed the LLMPlatform csv. * added FMalloc Unused stat to LLMFULL to account for memory Binned2 has allocated internally. This can be used to track Binned2 fragmentation over time. * renamed Binned stats to FMemory to make it more general * added Default tracking to CustomVirtualAlloc and disable it where necessary. This catches the few VirtualAlloc calls that were missed. * added AllocType arg to all allocation tracking. This was needed in order to track the FMalloc total, and also to fix the pausing * fixed a bug in pausing where alloc/frees were being missed. Now only pauses a specific allocation type. * Trackers now maintain totals for each enum tag * tracking of Texture and mesh allocation on Windows D3D11 & D3D12 Change 3651334 by Joe.Barnes Fix misspelled function name. #jira 39441 #3016 Change 3653857 by Ben.Woodhouse Integrate from //UE4/Main/...@3653675 to //UE4/Dev-Console/... Change 3656553 by Joe.Barnes Add path for SCS_DeviceDepth. Change 3662703 by Ben.Woodhouse Merging CL 3659069 from //Fortnite/Main/... to to //ue4/dev-console/...: [FORTNITE] [CONSOLE] [+] Improved frame syncing mechanism - Improves input latency by allowing the game thread to sync to the swap chain flip of the previous frame. - Added "r.GTSyncType" CVar to control how the game thread syncs with the rest of the pipe. - r.GTSyncType 2 will sync the game thread with the flip of the swap chain, preventing the pipe from getting too long and causing excess input latency. Platforms are required to implement RHIWaitForFlip and RHISignalFlipEvent, and call RHIInitializeFlipTracking on RHI startup. A separate thread monitors the progress of frame flips and signals task graph events as they pass their corresponding frame index. In r.GTSyncType 2 mode, the game thread is signaled by this flip tracking thread. [~] Unified platform specific sync interval CVars into one: rhi.SyncInterval - 1 == 60Hz - 2 == 30Hz - 3 == 20Hz Change 3675239 by Keith.Judge Fixed thread priorities for Windows so that BelowNormal and SlightlyBelowNormal are the same. Bumped Lowest down a notch so they all fit. #jira UE-50626 Change 3676709 by Ben.Woodhouse Integrate from //UE4/Main/...@3675008 to //UE4/Dev-Console/... Change 3689712 by Ben.Woodhouse Integrate from //UE4/Main/...@3687781 to //UE4/Dev-Console/... Change 3701778 by Ben.Woodhouse Integrate from //UE4/Main/...@3699491 to //UE4/Dev-Console/... Change 3677043 by Ben.Woodhouse From StewartL: I also found that on Windows Fortnite is overflowing int32 values due to the number of allocations. I changed LLMArray and LLMMap to use uint32 and it seems to be Ok now. I didn't want to check this in at the last minute, so here's the shelf: 3645336 Change 3726532 by Luke.Thatcher [CONSOLE] [~] Enable XGE shader compilation by default. - Also set XGE mode to "force interception". With XGE on by default, we don't want people with an old Incredibuild version using the old system inadvertently. Change 3726554 by Luke.Thatcher [CONSOLE] [+] Improved Scoped Named Events - Added SCOPED_NAMED_EVENT(_FSTRING/_TEXT/_F) macros to allow use of string literals, FString and printf in scoped named event strings. - Replaced explicit use of FPlatformMisc::Begin/EndNamedEvent throughout the engine with macros, so the events can be compiled out. - Fixed performance issues on various platforms with named events. SCOPED_NAMED_EVENT macros were not considering whether the platform uses wide or ansi char strings. Change 3751378 by Ben.Woodhouse Integrate from //UE4/Main/...@3748735 to //UE4/Dev-Console/... Change 3751812 by Ben.Woodhouse Integrate from //UE4/Main/...@3750870 to //UE4/Dev-Console/... Change 3728571 by Luke.Thatcher [CONSOLE] [!] Drop another XGE controller warning to log. Change 3747150 by Joe.Barnes Add AuthoringToolHelper.bat file to installed build copy list. Change 3768585 by Ben.Woodhouse Integrate from //UE4/Main/...@3767531 to //UE4/Dev-Console/... Change 3772333 by Ben.Woodhouse Integrate from //UE4/Main/...@3771573 to //UE4/Dev-Console/... Change 3786872 by Ben.Woodhouse Integrate from //UE4/Main/...@3786785 to //UE4/Dev-Console/... Change 3787279 by Luke.Thatcher [CONSOLE] [~] Unified present threshold CVars. - CVars are now in RHIUtilities.cpp, and are renamed to rhi.PresentThreshold.Top and rhi.PresentThreshold.Bottom. - Platform implementations will be checked in shortly. Change 3787445 by Luke.Thatcher [CONSOLE] [^] Merging (as edit) improvements to low-latency frame syncing from //Fortnite/Main to //UE4/Dev-Console Original CLs - 3708949 - Added rhi.SyncSlackMS cvar to allow an offset of the game thread sync time by a number of milliseconds. - 3712693 - Fix for crash on startup in new frame syncing. - 3735765 - Fix r.GTSyncType logic when vsync is disabled (falls back to old behaviour when vsync is off). Change 3788417 by Ben.Woodhouse Duplicate from FN CL 3712515 CSV profiler GPU and pre-declared stat support - refactor the GPU profiler so it's no longer dependent on the stats system and can work in Test builds - add support for pre-declared CSV stats, using FNames (these are required for GPU stats) - add DECLARE_GPU_STAT macro which handles STATS and CsvProfiler declarations Note: still a few issues to resolve with GPU stats: these randomly go to 0 at times during a replay on XB1, the GPU total is lower than the stat unit number, and the unaccounted stat is too large due to missing stats Change 3807818 by Ben.Woodhouse Integrate from //UE4/Main/...@3803271 to //UE4/Dev-Console/... Change 3818577 by Ben.Woodhouse Integrate from //UE4/Main/...@3812936 to //UE4/Dev-Console/... Change 3821198 by Ben.Woodhouse Integrate from //UE4/Release-4.19/...@3820127 to //UE4/Dev-Console/... Change 3821519 by Ben.Woodhouse Integrate from //UE4/Release-4.19/...@3820753 to //UE4/Dev-Console/... #robomerge none Change 3813513 by Ben.Woodhouse CSV profiler refactor+ bug fix - Move the CSV profiler to core, so we can use it in modules other than engine - Profiler no longer enqueues RT commands - this is handled by a new core delegate type - Make begin/end requests more robust, enqueued via a command queue and processed in order - Defer end capture requests by a frame. This ensures stats on threads other than the gamethread (e.g. renderthread etc) are complete, so the last frame is not truncated - Fix long-standing bug with multiple captures where old/stale frames would appear in the first <128 frames of captures - Move unit stats and dynamic resolution out of the profiler itself and into the engine. Only frametime is recorded in the profiler now - Fix longstanding bug in first frame renderthread time in the engine Change 3814039 by Ben.Woodhouse More Csvprofiler improvements - Event support (via CSV_EVENT macros). These appear in the "EVENTS" column of the CSV and can be used to add context to the stat data - Reduced memory overhead for timestamps through bit-packing (now 16 bytes per marker instead of 24), and splitting stats into different types Change 3814041 by Ben.Woodhouse Integrate as edit CL 3796390 from Fortnite/Main: Fix CsvProfiler not compiling in shipping for now Change 3814229 by Ben.Woodhouse Integrate + refactor of CL 3792591 to reduce complexity and fix bugs Original changelist description: CSV profiler improvements: - The CSV profiler is now always compiled in on the server - The CSV profiler can now handle both int32 and float stats - In BeginCapture, the function can take additional arguments for some customization of filenames Fixes to the above: - Remove FCustomValue class - Fixes bug where all timestamp values from CSV_SCOPED_STATs were garbage (due to issues resulting from FCustomValue type ambiguity when adding values together) - FCsvCustomStat now just uses simple union + bitfield flag to reduce size and complexity (4 bytes instead of 8 per value) - FCsvColumn class modified to use doubles, which can represent both ints and floats without loss of precision - this class is not memory or time critical - Replace multiple overrides used by the server for filenameprefix/folder/postfix etc with a single FilenameOverride Change 3814242 by Ben.Woodhouse Disable CSV unit stats on the dedicated server Change 3817339 by Ben.Woodhouse Duplicate from 3816641: CSV profiler improvements - Added a low-pri processing thread to compress raw timing data into a much more efficient format - Reduces memory usage for 15 minute 30k frame capture with GPU stats enabled from 110MB to 3.4MB - Processing time : 0.1ms per frame - Improved name handling for char literal stats. We now use the string as the ID rather than the pointer so multiple stat uses of the same name string apply only to a single stat - Reworked thread data access to eliminate locking for anything time-critical. Frame boundaries now handled via a lock-free helper class - Fixed bug with queue implementation where 1 in 128 reads would duplicate the last block of stat data - Reduced #include dependencies for CSVProfiler.h - Removed AccumulateMax because it doesn't work, and implementing properly would add a lot of complexity - Added a simple test harness Change 3817582 by Ben.Woodhouse Fix android compile warning Change 3823242 by Ben.Woodhouse Integrate as edit from Fortnite/Main 3820067: Fix threading issue with D3D12 pipeline state caches for windows. This was caused by the usage of FRwScopeLock::RaiseLockToWrite. A pointer read before RaiseLockToWrite was called was invalidated because RaiseLockToWrite has to release the read lock before acquiring the write lock. Rename FRwScopeLock::RaiseLockToWrite to ReleaseReadOnlyLockAndAcquireWriteLock_USE_WITH_CAUTION to make it more explicit what's happening. As the comment says: // This function should be used with caution. // It releases the read lock _before_ acquiring a new write lock. This is not an atomic operation and the caller should // not treat it as such. // E.g. Pointers read from protected data structures prior to this call may be invalid after the function is called. Change 3823840 by Ben.Woodhouse Edigrate from 3823816 Fix an issue where the csvprofile console commands would sometimes result in an empty CSV. The root cause was GFrameNumber incrementing between the console command being read and FCSVProfiler::EndFrame(). We now use our own frame counter which is updated in EndFrame, so this can't happen Also fix an issue where calling csvprofile stop twice would cause all further commands to be ignored. Change 3827787 by Ben.Woodhouse Integrate-as-edit CL 3820678 from Fortnite/Main Allow the CSV Profiler to be compiled in to shipping dedicated server builds Change 3827842 by Ben.Woodhouse Integrate-as-edit CL 3827079 from Fortnite/Main CSV profiler category support Change 3827918 by Luke.Thatcher [CONSOLE] [!] Fix compile error in CSV custom stats. Change 3827964 by Luke.Thatcher [CONSOLE] [!] Fix inverted logic and spelling of boolean. - Functionally, the boolean did the correct thing, but the logic was backwards inside the build tool. Change 3831661 by Ben.Woodhouse Integrate-as-edit CL 3830630 from Fortnite/Main Fix CSVProfiler assert in dev builds on XB1 Change 3860300 by Joe.Barnes Use same method for src and dest rect calculation as other post processing passes so rects match between passes. Prevents read of unprocessed pixels. Change 3860347 by Joe.Barnes Delete existing SourceConfigFile before allocating a new one to prevent them leaking. Change 3860348 by Joe.Barnes Completely encapsulate GetLLMAlloc() in #ifdef. Change 3861772 by Ben.Woodhouse Integrate-as-edit CL 3861688 from Fortnite/Main: Forward lighting GPU crash fixes Change 3861774 by Ben.Woodhouse Integrate as edit CL 3833918 from dev-rendering (courtesy of DanielW): D3D12 RHI: only refcount uniform buffers if GRHINeedsExtraDeletionLatency is false, which is no longer the case for PC. The refcounting was heavy on performance as reported by a licensee because FRHIResource uses atomics for refcounting, which is only necessary when GRHINeedsExtraDeletionLatency is disabled. Change 3862214 by Ben.Woodhouse Integrate-as-edit CL 3859637 from Fortnite/Main Dynamic resolution console tweaks - Dynamic resolution high level switch driven by a cvar instead of code - Disable user settings dynamic resolution handling on non-desktop platforms. DynamicRes as a user setting does not make sense on consoles/mobile - we'll drive it from device profiles/scalability - Modify naming of GPUHeadRoom to make it clear that it's a percentage, not millseconds Change 3863919 by Ben.Woodhouse [Copy] Integrate console dynamic resolution interface changes from CL 3863354, 3862754, 3862639 Change 3864347 by Ben.Woodhouse Fix the editor build. This will need a proper fix before 4.19 ships. #lockdown Nick.Penwarden #rb none [CL 3913399 by Ben Marsh in Main branch]
2018-02-27 17:30:35 -05:00
if (ContainerType == EPinContainerType::Map && NumValuePinsWithLinks == 0 && (OutputPin->PinType.PinValueType.TerminalCategory == UEdGraphSchema_K2::PC_Wildcard && Pin->LinkedTo[0]->PinType.PinValueType.TerminalCategory != UEdGraphSchema_K2::PC_Wildcard))
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
{
OutputPin->PinType.PinValueType = Pin->LinkedTo[0]->PinType.PinValueType;
bNotifyGraphChanged = true;
}
}
else if (ValuePins.Contains(Pin))
{
// Just made a connection to a value pin, was it the first?
Copying //UE4/Release-Staging-4.19 to //UE4/Dev-Main (Source: //UE4/Release-4.19 @ 3873914) ============================ MAJOR FEATURES & CHANGES ============================ Change 3873906 by Dan.Oconnor Revised fix for preventing delegate functions from appearing in context menu when using the compilation manager - needed to run after CallDelegateHandler changed statement type #jira UE-51726 Change 3873614 by Dan.Oconnor Prevent delegate functions from appearing in context menu when using the compilation manager and prevent crash if such a function is somehow compiled #jira UE-51726 Change 3873428 by Ben.Zeigler #jira UE-54753 Fix class pin on SpawnActorFromClass to correctly support browse. It was inherting from the wrong pin widget Copy of 3873408 Change 3873083 by Ethan.Geller [4.19]#jira UE-54865 fix seconds -> milliseconds conversion issue. #rb aaron.mcleran #lockdown cristina.riveron Change 3872714 by Dan.Oconnor Further revise fix for UE-53840, mistakenly reverted to old behavior when compiling synchronously #jira UE-53840 Change 3872648 by Ben.Zeigler #jira UE-54845 Fix crash in NextDebugTarget when there are no valid debug targets Copy of CL #3872636 Change 3872500 by Arne.Schober Back out changelist 3870283 #jira UE-54838 Change 3872412 by Mark.Satterthwaite Remove now unnecessary r.Metal.ManualVertexFetch from the device profiles. #jira UE-54853 Change 3872313 by Martin.Wilson Add UI to Live Link Client to warn live link users about background performance throttling #jira none Change 3872272 by Martin.Wilson Fix crash when clearing a skeletal mesh on a skeletal mesh component with an active Post Process Anim Instance #jira none Change 3872238 by Mark.Satterthwaite Duplicate CL #3871025 Make Manual Vertex Fetch a property of the shader platform for Metal - only the desktop platforms (METAL SM5/SM5_NoTess/MRT) will use manual vertex fetch. The mobile platforms use vertex descriptors. Prevents problems with cooked versions of games not working properly on Metal due to a mismatch between the runtime's Manual-Vertex-Fetch state versus the state used by the cooker when compiling shaders. #jira UE-54843 Change 3872087 by Yasiman.Ahsani Adding Python, libdisasm, musl, and LSS licenses. #JIRA n/a - adding licenses for new TPS Change 3872037 by Ben.Marsh BuildGraph: Add a task for compiling MSBuild projects. #jira Change 3871934 by Lina.Halper #jira: UE-54703 Change 3871595 by Michael.Trepka Fixed a problem with Mac editor not exiting with error code returned from GuardedMain function #jira UE-54830 Change 3870829 by Joe.Barnes Fix unintentional change to PhysX libs used in Debug builds. #jira ue-54817 Change 3870820 by Nick.Atamas Copying //Tasks/UE4/Dev-VR-4.19a@3870772 to Release-4.19 (//UE4/Release-4.19) #jira UE-54816 Change 3870755 by Chance.Ivey Min Android version set - should fix camera permissions issue found in #JIRA UE-54024 #rb none #fyi nick.atamas Change 3870547 by Krzysztof.Narkowicz Fixed FreezeRendering on non editor builds: ComputeAndMarkRelevanceForViewParallel was calling FrozenMatricesGuard on multiple threads, reading and writing view matrices state in parallel. #jira UE-53640 Change 3870546 by Krzysztof.Narkowicz Fixed tesselation shader tex/uniform initialization in OpenGL3/4 path #jira UE-54471 Change 3870284 by Ben.Zeigler #jira UE-54583 Fix issue where loading multiple already loaded assets via Async Load Asset node could return the wrong asset on the loaded pin. The assign variable node was happening at a slightly wrong time Copy of CL #3870279 Change 3870283 by Arne.Schober SafeRelease SRVs that might be hold by the Vertexfactories (maybe due to indirect use in GlobalResources) Note that the VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should be uneccessary #jira none Change 3870098 by Ben.Marsh Fix OptimizeCode = CodeOptimization.Always causing compile errors in Linux debug builds. bUseInlining was not set correctly on the global compile environment used to build shared PCHs. Also fixed other settings not being propogated down from the target correctly. #jira UE-53855 Change 3870013 by Ben.Marsh UBT: Add an error if a user attempts to clean a target through hot-reload, rather than just failing to delete DLLs because they are locked. #jira UE-54179 Change 3870010 by Ben.Marsh UBT: Add an option to format output messages in a form that can be parsed by MSBuild. Prevents errors showing as "EXEC: Error:", and displays them correctly in the error list window. #jira Change 3869814 by Ben.Marsh UBT: Unify command line arguments to use -Name=Value syntax. -Module <Name>, -ModuleWithSuffix <Name> <Suffix>, -Plugin <Path> and -Receipt <Path> are no longer supported. Also remove the RemoteRoot option, which was not used anywhere. #jira Change 3869786 by Martin.Wilson Fix Live Link Remove Source button not working #Jira UE-54652 Change 3869660 by Martin.Wilson Fix missing message bus sources in the live link client (not repolling for new sources) #Jira UE-54712 Change 3869659 by Guillaume.Abadie Fixes SimpleComposure's BP_AdvancedCompositing keep allocating memory every frame. Credits for fixing the issue to Ron Radeztsk. #jira UE-54780 Change 3869401 by Lauren.Ridge Adding to the conditional in FindAllAncestorNamedSlotHostWidgetsForContent #jira UE-51470 Change 3869384 by Brandon.Schaefer Open the project in the explorer when NullSourceCodeAccess is done creating the project #jira UE-54630 Change 3869308 by Ben.Marsh PR #4452: Fixed FindFilesRecursively in IPlatformFilePak (Contributed by user37337) #jira UE-54568 Change 3869265 by Martin.Wilson Fix crash and subsequently found issues with unloading/reloading Maya Live Link plugin -Crash on reload due to core code getting reinitialize, made this a one time only thing (as Maya never gets rid of the module from memory) -Added manual ticking of FTicker, allows message bus objects to be cleaned up properly (cannot do this as part of normal flow as it is in engine code which we dont have) -rebuild binaries for Engine/Extras #Jira UE-54643 Change 3869206 by Benn.Gallagher Fixed crash updating clothing paint mode after tab spawners have been destroyed by the hosting application. #jira UE-54116 Change 3869064 by Benn.Gallagher Resolved skeletal mesh data changes and clothing section disable changes after collision. Re-added ability to disable sections at the mesh level and removed the ability to strip editor sections as these are required for a number of other features to correctly function. #jira UE-52557 Change 3869062 by Guillaume.Abadie Fixes "dynamic resolution is not supported on this platform" warning message being always visible. #jira UE-54655 Change 3868202 by Lauren.Ridge Fix for assert on expanding vector param in layered material #jira UE-54737 Change 3868161 by zak.parrish Replacing FaceARDebugUI with a blank UI until a new one can be created, due to a crash bug. #rb none #JIRA UE-54639 Change 3867750 by Ethan.Geller [4.19] #jira UE-54725 Fix for Envelope attack and release values not being properly set on Synth Components #rb aaron.mcleran #lockdown cristina.riveron Change 3867657 by Lauren.Ridge Adding if with editor wrapper to new function #jira cis fix Change 3867646 by Aaron.McLeran #jira UE-53867 Access violation on Switch when playing sound with specified time out of range Change 3867340 by Lauren.Ridge Fixes to Material Layers from 4.19 preview feedback -Need to pass through base attributes better/have better default nodes in layer (optional Example Layers and Blends checkbox now enables this in Experimental Settings) -Parent in function should be editable -Enforce only two layers in a blend -Mat layer should warn if it has incorrect output in the layer itself -Enforce not being able to delete outputs -Warn about creating a MAL node inside a function #jira UETOOL-1312 Change 3867317 by Aaron.McLeran #jira UE-53867 Access violation on Switch when playing sound with specified time out of range Change 3867000 by Lauren.Ridge Fix for folder favorites possibly becoming very large #jira UE-54704 Change 3866892 by Martin.Wilson Fix crash if clicking ok on message bus add source without having a source selected #jira UE-54572 Change 3866391 by Matt.Kuhlenschmidt Fix static analysis #jira UE-53379 Change 3866241 by Ryan.Vance #jira UE-54681 Fixed missing Vulkan texture GetNativeResource implementation that was lost in a bad merge. Change 3866071 by Nick.Shin UDN 412414 update HTMl5 readme file #jira none Change 3866005 by Max.Preussner Messaging: Preventing dangling references when removing message subscribers #jira UE-54680 Change 3865988 by Simon.Tourangeau Fix static analysis warnings #jira none Change 3865895 by zachary.wilson Renaming QA-PhysicalLightUnits to TM-PhysicalLightUnits in QAGame. #JIRA UE-29618 Change 3865469 by Simon.Tourangeau Support for DX11 quad buffer stereo rendering #jira UEENT-704 Change 3865461 by Chris.Babcock Add a wait for audio thread to pause audio on going to background #jira UE-54301 #ue4 #android Change 3865350 by Matt.Kuhlenschmidt Fix issue where cascade emitter UI would disapper #jira UE-53379 Change 3865336 by Arne.Schober REL - Fix UE-52356 Bone Weight #jira UE-52356 Change 3865257 by Ben.Marsh Fix editor failing to load content-only projects when compiled in DebugGame. #jira UE-54661 Change 3865238 by Simon.Tovey Pulling Olaf's fix from 3832595 over to release #tests EngineTests boots in vulkan #JIRA UE-54394 Change 3865191 by Sorin.Gradinaru UE-54317 DXT apps fail on first launch when 'For Distribution' enabled, Unsupported Texture Format #jira UE-54317 #Android #4.19 From //Dev-Mobile/3863322 Change 3865190 by Sorin.Gradinaru UE-54175 Selecting For Distribution no longer sets configuration to Shipping #UE4 #4.19 #jira UE-54175 From //Dev-Mobile/3863371 "For Distribution" enable-> reset "Build COnfiguration" to Shipping and force serialization to DefaultGame.ini (see UE-52845) Change 3865056 by Jamie.Dale Fixed culture being incorrect when added via the Localization Dashboard #jira none Change 3864826 by Max.Preussner WmfMedia: Added missing scope lock #jira UE-54365 Change 3864055 by Aaron.McLeran #jira UE-54213 Crash fix for GC'd plugin settings objects. Adding to AddReferencedObjects. Change 3863775 by Andrew.Porter MediaFrameworkTest: Removing Platform Media Source TVOS test content #jira UE-29618 Change 3863714 by Dan.Oconnor Make array, set, and map nodes no longer switch object type when a pin is disconnected. Also, you can no longer attach unrelated map types to the MakeMap node if only the value pin has been inferred #jira UE-54634 Change 3863696 by Max.Chen Sequencer: Fix crash open a new sequence while another is still active. #jira UE-54620 #jira UE-54624 Change 3863638 by Dan.Oconnor Make sure all blueprints that are skeleton compiled get a BroadcastChanged notification, also run BroadcastChanged after reinstancing, matching pre compilation manager behavior #jira UE-54193 Change 3863494 by Jamie.Dale Ensure Py_SetPythonHome is set correctly before the embedded Python interpreter is initialized #jira UE-54345 Change 3863433 by Max.Preussner MediaPlayerEditor: Removed tvOS from list of available platforms in Platform Media Source assets tvOS currently reports itself as iOS, so it cannot have its own setting. #jira UE-54559 Change 3863406 by Lauren.Ridge Fix for a crash when filtering a dropdown with no set value #jira UE-54631 Change 3863238 by Michael.Kirzinger #jira UE-52730: Fix mac voip crash Change 3862586 by Marc.Audy Clean up rendering thread heartbeat checks that got mangled in various integrations #jira Change 3862247 by Guillaume.Abadie Fixes editor lines that were using a simple element blending mode that was generating an incorrect alpha channel. #jira UE-53830 Change 3862120 by Guillaume.Abadie Fixes USceneCaptureComponent::HiddenActors always staying gray out in world editor. #jira UE-51458 Change 3861363 by Jamie.Dale Static analysis fixes #jira none Change 3861150 by Matt.Kuhlenschmidt Fix static mesh editor displaying 0 for all stats on LODs > 0 #jira UE-53776 Change 3860990 by Dan.Oconnor Clear subobjects not recreated on load, e.g. because we're running with -game and the subobject was created using CreateEditorOnlySubobject #jira UE-54551 Change 3860972 by Nick.Shin HTML5 - detect "SyntaxError: " and do a forced reload - an actual syntax error would be caught during compile time - this is usually error condition is usually seen when browser is running "old/partial" cached data and it's fairly safe to just reload the page #jira UE-54017 QAGame fails to launch properly on HTML5 Firefox 64 bit Change 3860951 by Arne.Schober Fix not releaseing SRV on render thread for FPositionVertexBuffer, FStaticMeshVertexBuffer, FColorVertexBuffer, FStaticMeshInstanceBuffer. #jira UE-54587 Change 3860950 by tim.gautier QAGame: Updating ML_Stone to include Texture Coordinate and Panner functions #jira UE-29618 Change 3860833 by Michael.Dupuis #jira UE-54181: Repopulate the foliage list when existing simulate mode Let the GC know that internal struct hold UObject ptr Change 3860762 by Jamie.Dale Ensure we invoke the correct version of Python from UBT #jira UE-54345 Change 3860676 by Simon.Tourangeau Remove DirectoryWatcher warning in output log #jira UEENT-846 Change 3860598 by Lauren.Ridge Fix for crash on opening new material instance #jira UE-54589 Change 3860338 by Michael.Lentine Integrate changes for fixing MorphTargets. #jira 54398 Change 3860215 by Ben.Marsh UAT: Fix exception consturcting target rules assembly inside UAT, now that there's an abstract TargetRules class. #jira UE-54578 Change 3860186 by Matt.Kuhlenschmidt Fix crash top 10 with the font editor shutting down and then a dpi event occuring #jira UE-54543 Change 3859854 by Graeme.Thornton PR #4124: VSCode: Changed VisualStudioCodeSourceCodeAccessor to work with non-default VSCode install paths on Linux (Contributed by christopherreed) #jira UE-51289 Change 3859848 by Graeme.Thornton Fix crypto.cs reading the wrong ini setting names for uasset encryption settings #jira UE-54566 Change 3859684 by Ben.Marsh PR #4436: Fix compile error when building BlankProgram because incorrect directory path (Contributed by windkey) #jira UE-54392 Change 3859657 by Ben.Marsh Fix FTransform being passed by value, causing alignment error when compiling for Win32. #jira Change 3859312 by nick.bullard Updating AEOverviewMan to remove reference to sub-level AEOverviewSWP which was deleted in 3859278 Still need to update menu to remove selection #jira UE-50784 Change 3859278 by Nick.Bullard Deleteing AEOverviewSWP.umap per request of Developer. Also updated TM-AnimPhys which refereneced this map as well. "This test map is a custom C++ implementation of a "procedural sound wave". This code is super janky and not worth fixing up. I'm sure there's a legit thread safety problem in there but the code is in QAGame only. We've since implemented "synth components" which do what this test does in a much safer/better way and maintaining/testing this old thing is *not* worth the time." #jira UE-50784 Change 3859124 by Dan.Oconnor Fix long standing crash when duplicating a blueprint that is missing its parent class. Entries in CrashReport go back to 4.16 #jira UE-54468 Change 3859086 by Ryan.Vance #jira UE-54470 We need to set the viewport in both cases. Change 3859006 by Dan.Oconnor Revise fix for archetype lookup when reinstancing. During compilation we do not want to force use of the up to date class #jira UE-54541 Change 3858990 by mason.seay Cleaned up blueprints to remove compile errors #jira UE-29618 Change 3858945 by Aaron.McLeran #jira UE-54265 PR #4428: Fixing Envelope Bug in AudioMixer (Contributed by Chrispykins) Change 3858719 by Aaron.McLeran #jira UE-54552 Fix for sample buffer reader Change 3858647 by Ethan.Geller PR #4439: Removes ambiX -> FuMa conversion (Contributed by mgorzel) #jira UE-54407 Change 3858364 by Michael.Dupuis #jira UE-52049: There was a case where adding and removing multiple time would lead to reordering the instances and this would cause the regeneration of the random stream for all the reorded instances. Change 3858268 by Dan.Oconnor Prevent postload logic running on REINST and SKEL classes #jira UE-54531 Change 3858205 by Mitchell.Wilson Removed particle looping from some emitters to resolve anim notify warnings. #jira UE-53823 Change 3858148 by Lauren.Ridge Changes based on Material Layer Feedback from previews - (Temporary) Disabled being able to create a layer or blend in the asset dropdown - Sections of the stack that have been disabled now inactivate that part of the UI - Create Function Instance now indicates if you are making a layer or a blend - Parent dropdown has been removed from layers and blends. Where relevant, a filter button has been added instead. #jira UETOOL-1328 Change 3857933 by Michael.Dupuis #jira UE-45854: Properly unregister callback when replacing foliage type with another one Change 3857898 by Michael.Dupuis #jira UE-54396: Remove the Ensure as it could be possible that the Landscape Info is invalid during an undo operation Change 3857878 by Max.Chen Sequencer: Assign the sequence id after the template is compiled. Copy from Dev-Sequencer #jira UE-54462 Change 3857808 by Michael.Dupuis #jira UE-54421: Prevent edition during Simulate when clicking on actor Change 3857786 by Rolando.Caloca UE4.19 - Fix recompute tangents and skin cache for OpenGL #jira UE-42108 PR #3271 Change 3857549 by Lina.Halper another jittering issue due to revision number change clear the motion vector after compile #jira: UE-53930 Change 3857439 by Lina.Halper Clear motion vector when end of sequencer when in editor world #jira:UE-54057 Change 3857384 by Graeme.Thornton Restore fix for visual studio source code accessor not correctly determining that a content project has no solution and opening a fresh instance of visual studio #jira UE-50020 Change 3856596 by Chris.Babcock Fix ResonanceAudioApi Android library architecture filtering #jira UE-54478 #ue4 #android Change 3856449 by Michael.Dupuis #jira UE-35097: Various cosmetic changes that were done in phase 2 that help improve clarity of the design. Change 3856415 by Dan.Oconnor Fix regression when loading instances that have had their class deleted. Issue detected by static analysis #jira UE-54467 Change 3856332 by Ben.Marsh Resaving TP_HandheldARBP assets to fix version again. #jira Change 3856319 by Ben.Marsh Back out changelist 3855588 Causes build failure in UFE because it introduces a dependency on the Engine module. UFE compiles with WITH_ENGINE = 0. #jira UE-54472 Change 3856292 by Ben.Marsh Fix app-local dependencies not being included in binary builds, and only working for code projects in source builds. #jira UE-54448 Change 3856190 by Martin.Wilson Fix bone access mismatch between raw mesh bones and final bones (that include virtual bones too) #jira UE-54266 Change 3856169 by Ben.Marsh Tag XGEControlWorker.exe as a build product, so it's included in the binary distro. #jira UE-54283 Change 3856123 by Chris.Babcock Fix missing ARCore file #jira UE-54453 #ue4 #android Change 3856005 by Richard.Wallis Clone of Dev-Rendering CL 3855993 - turn off FShaderCache. #jira UE-52928 Change 3855961 by Jian.Ru Copy 3855047 - fix DFAO Nan problem #jira UE-54403 Change 3855811 by Martin.Wilson Add build process for Maya Live Link plugin (standalone, manually triggered) + add built binaries to Engine/Extras (Maya 2016, Maya 2017, Maya 2018) #jira none Change 3855758 by Cosmin.Sulea UE-53569 - tvOS does not package or launch-on #jira UE-53569 Change 3855727 by Ben.Marsh Resaving assets with a versioned build in the editor, to fix warnings building DDC. #jira Change 3855626 by Adrian.Siminciuc https://jira.it.epicgames.net/browse/UE-50979 (MP4 doesn't resume playback when iOS 11 device wakes from sleep) #jira UE-50979 Change 3855588 by Graeme.Thornton Fix visual studio solution path being incorrect for content projects #jira UE-50020 Change 3855283 by Ben.Marsh Fix race condition where stdout/stderr write handles could be inherited by multiple processes, resulting in them not being closed (and the process exit being detected) until all processes that inherited them had been closed. Improves performance of ParallelExecutor. #jira Change 3855009 by Chance.Ivey Resaving with version number. #JIRA-54330 #rb none Change 3854943 by Dan.Oconnor Fix archetype lookup when searching hierarchy that has been partially reinstanced #jira UE-53840 Change 3854882 by Ryan.Vance #jira UE-54438 Removing vr related references to screen percentage. Removing previously removed gvr screen percentage code that came back in an integration from google. Change 3854806 by Mike.Beach Mirroring part of CL 3802176 to fix a crash that can occur when users try to use the default 'DisplayModel' on MotionController components. Also provided users a better error message to explain why a model might not be showing up. #jira UE-54214 Change 3854680 by Chance.Ivey Saving assets with version number#JIRA UE-54330 #rb none Change 3854652 by Uriel.Doyon Added a tooltip to the EV100 slider in the exposure menu. Using game settings now disables the slider. #jira UE-53945 Change 3854605 by Dan.Oconnor Make sure we don't create objects outered to a placeholder object, also make sure that archetypes that are reinstanced on load are relinked in to the linker table so that they are postload'd (and the old instance isn't) #jira UE-53954 Change 3854274 by Brandon.Schaefer Changes in CL 3842286 changed the function glslang::GlslangToSpv and requires a rebuild on Linux #jira UE-54302 #codeview Arciel.Rekman Change 3854255 by Phillip.Kavan Fix a scoping issue for local instanced subobject references in nativized Blueprint C++ code. Also, don't emit redundant assignment statements for instanced subobject reference properties. - Mirrored from //UE4/Dev-Framework (3853349). #jira UE-53960 Change 3854177 by Ethan.Geller #jira UE-54415 set EnabledByDefault to false for Resonance Audio Change 3854123 by Ethan.Geller #jira UE-54410 set AudioComponentID Change 3853775 by Lauren.Ridge Minor cleanup #jira UE-54054 Change 3853772 by Lauren.Ridge Don't create widgets when just testing if the selected widget is a replacement candidate #jira UE-54054 Change 3853715 by Rolando.Caloca UE4.19 - Fix for OpenGL overwriting texture units #jira UE-54401 Change 3853655 by Ben.Marsh Add a retry loop on creating the first directory before copying files. Attempt to work around problems copying to shared folders. #jira Change 3853535 by Ben.Marsh Expose the engine compatible changelist to Perforce. If EnginePatchVersion > 0, this will be the changelist of the original .0 release. #jira Change 3852583 by Nick.Atamas Resaved assets so they don't produce DDC warnings. #jira none Change 3852552 by Uriel.Doyon Fixed Pre-Exposure shader compilation and Temporal AA issue. #jira UE-54276 Change 3852354 by Nick.Atamas Hopefully fixes the static analysis warning from jira issue. #jira UE-54332 Change 3852281 by Nick.Atamas Merging CL 3851690 from //Tasks/UE4/Dev-VR-4.19a/... to //UE4/Telease-4.19/... #jira UE-54331 Change 3852274 by Simon.Tourangeau Back out changelist 3851041 until Win7 issue is resolved. #jira UE-54354 Change 3852208 by Jamie.Dale Merging CL# 3821754 from //UE4/Dev-Enterprise Class property conversion now goes through NativizeClass/PythonizeClass This allows it to coerce from Python wrapped object types #jira none Change 3852202 by Jamie.Dale More explicit handling of EngineDir for Python SDK #jira UE-54345 Change 3851982 by Brandon.Schaefer Workaround using a hardcoded path #jira UE-54136 Change 3851748 by Michael.Dupuis #jira UE-53904: Put the code back to what it was before, as we really only want to perform this code if bIsLayerThumbnail is true, it was changed to fix another issue complaining about a missing shader, that end up being added to the existing functions Change 3851545 by Marc.Audy Remove debugging code that slipped in #jira none Change 3851461 by Ben.Marsh Fix #includes with backslashes from crashing UBT. #jira UE-53996 Change 3851391 by Jamie.Dale Updated Python to prefer our TPS SDK #jira UE-54345 Change 3851372 by Jamie.Dale Added bat file to copy the Python SDK into TPS #jira UE-54345 Change 3851218 by Ben.Marsh Add missing template to installed engine build. #jira UE-54339 Change 3851117 by andrew.porter QAGame: Removing duplicate map #jira UE-29618 Change 3851041 by Simon.Tourangeau Support for DX11 quad buffer stereo rendering #jira UEENT-704 Change 3850548 by Ben.Marsh Add TP_HandheldARBP to installed engine build. #jira Change 3850424 by Ben.Zeigler Fix reported memory for asset registry to be correct, extracted from a larger change #jira none Change 3850324 by Ryan.Vance #jira UEVR-1050 Hook up the Rift dynamic res to the new IDynamicResolutionState framework Change 3849819 by JeanLuc.Corenthin Unhide Datasmith plugins in "regular" projects to allow easy project conversion #jira UEENT-795 Change 3849302 by Martin.Wilson Live Link is no longer experimental in 4.19 (moved from experimental folder to Animation) #jira none Change 3849238 by Max.Chen Sequencer: Remove bKeepStaleTracks so that stale tracks are now always purged. #jira UE-54248 Change 3849211 by Michael.Dupuis #jira UE-54181: Prevent foliage edition during PIE or simulate mode #coderevire jack.porter Change 3849123 by Benn.Gallagher Fixed crash in clothing actor creation when the clothing simulation mesh has no simulated vertices #jira UE-53741 Change 3849120 by Benn.Gallagher Fixed crash adding empty materials to destructible meshes in the destructible mesh editor #jira UE-53938 Change 3849047 by Jurre.deBaare Move material baking out of experimental #fix follow-up also remove the entry from experimental settings #jira UE-52685 Change 3848808 by Michael.Dupuis #jira UE-35097: Remove IncludeTessellationInShadowLOD & RestrictTessellationToShadowCascade from 4.19 as there is currently a bug regarding this in the dynamic rendering code path and would be too risky to fix for now. Fixed dynamic shadow code path issue vs static code path Change 3848659 by Lina.Halper Fix issue with animation resetting in the sequencer #jira: UE-54047 Change 3848635 by Rolando.Caloca UE4.19 - Fix static analysis #jira UE-50449 Change 3848515 by Sorin.Gradinaru Unshelved from pending changelist '3843541': WebBrowser Android crash on 4.4.3 #jira UE-53247 #Android #4.19 Crash on Android 4.x.x caused by a call to a Api Level 21 method Change 3848514 by Jurre.deBaare Moving over: CL 3832173 "Failed to import Alembic files #jira UE-53941 #fix Change Alembic thirdparty library setup - Removed old unused library files - Updated batch files for building HDF5 ILMBase and Alembic libraries to use new AlembicDeploy path - HDF5 is now build as a Dynamic library (which also enableds multi-threading) - Added DLLs for HDF5 to build.cs file CL 3838053 "Adding missing hdf5 dynamic libraries Change 3848245 by Ben.Marsh Downgrade warning about not using XGE shader compilation to a log message. Build machines do not have XGE. #jira UE-54237 Change 3847300 by Phillip.Kavan Fix shadowed local variable. #jira UE-54141 Change 3846922 by Max.Preussner ImgMedia: Fixed image media player never finished initialization if loading failed Copied from Dev-Sequencer CL# 3846902 #jira UE-54247 Change 3846831 by Arciel.Rekman Linux: only use lld for x86_64 (UE-54144). - lld support for other architectures seems to not ready for prime time. #jira UE-54144 Change 3846771 by Lauren.Ridge Material window now uses the background color set in preview scene. #jira UE-52215 Change 3846705 by Ben.Marsh Fix batch file paths not being quoted correctly when run through XGE. #jira Change 3846550 by Lauren.Ridge Toggling Show Background now updates the background as well #jira UE-52250 Change 3846417 by Matt.Kuhlenschmidt Fix crash resizing shootergame window #jira UE-53137 Change 3846295 by Rolando.Caloca UE4.19 - New Vulkan descriptor pooling mechanism (enabled on non-android) #jira UE-50449 Change 3846273 by tim.gautier QAGame: Updating Material Layer test assets to include more Params - Added temp assets, quicker repros for bugs #jira UE-54176, UE-54165 Change 3846255 by Lauren.Ridge Parameter tab is the primary tab for material instances #jira UE-54092 Change 3846086 by Chris.Babcock Add missing SecureHash.h include #jira UE-54026 #PR #4417 #ue4 #android Change 3846049 by Martin.Wilson Fix Set Root Motion Enabled Anim Data Modifier node (previously didn't set the enabled flag) #jira UE-54220 Change 3846033 by Martin.Wilson Fix root motion being repeatedly applied ( Clear() call only clears bHasRootMotion flag, not the transform itself ) #Jira UE-54219 Change 3845991 by andrew.porter QAGame: Updating bindings on activechannels sequencer test content #jira UE-29618 Change 3845933 by Lauren.Ridge Check for original material being valid #jira UE-54166 Change 3845920 by Martin.Wilson Optimized redundant key removal #jira UE-51303 Change 3845812 by Matt.Kuhlenschmidt Fix not being able to change BSP brush shape #jira UE-53738 Change 3845790 by Martin.Wilson Fix for assert failure when accumulating root motion in debug. #jira UE-53955 Change 3845730 by JeanLuc.Corenthin Fix build breakage warning: resaved disc.uasset with 4.19.0 preview #1 failure: set the correct default mesh for AreaLightStruct.uasset #jira none Change 3845693 by Lina.Halper Fix issue with previewing pose asset with curve data #jira: UE-53967 Change 3845533 by Andrew.Rodham Sequencer: Fixed sub sequences potentially being loaded during AddReferencedObjects #jira UE-54173 Change 3845472 by Thomas.Sarkanen Prevented debug object selection dropdown from displaying objects with pending kill outers #jira UE-54045 - Animation Blueprint Editor Crashes on Compile if the Debug Instance Selection is Other Than No Object or Preview Instance Change 3845401 by Yannick.Lange Reverting thumbnail capture from viewport. #jira UE-53775 #jira UE-53701 Change 3844693 by JeanMichel.Dignard Changed IES texture brightness to be the max candela value and set the texture multiplier to be 1. This fixes the IES lights intensity being too high. #jira UEENT-632 Change 3844689 by JeanLuc.Corenthin Update Datasmith content assets to latest Copying fix from Dev-Enterprise by Jean-Luc Corenthin CL 3809803 Updated assets with correct release version Cleanup some paths on static meshes and texture #jira UEENT-759 #jira UEENT-657 Change 3844571 by Martin.Wilson Fix motion controller motion source pin still showing when pin is connected to something #Jira UE-53236 Change 3844564 by Martin.Wilson Due to previously fixed bug some anim blueprint nodes could have duplicated guids, this fixes them #Jira UE-54174 Change 3844545 by Jamie.Dale No longer attempt to parse group separators for numeric inputs This avoids some ambiguity when parsing numbers for languages such as German #jira UE-54170 Change 3844221 by Nick.Shin HTML5 - filter out "windows/super" keys - these are not used in UE4 - but, keycode are not the expected "91 or 92" values, SDL keys are "227 & 231" instead... #jira UE-54056 HTML5 crashes inside browser upon pressing windows key Change 3843937 by JeanMichel.Dignard Fixed a crash when right clicking on a static mesh for which its AssetImportData class is currently unavailable (ie: in an unloaded plugin). #jira UEENT-764 Change 3843929 by Peter.Sauerbrei pull over fix for bad directory when copying launch images #jira UE-53177 Change 3843658 by Thomas.Sarkanen Text is red again in anim viewports #jira UE-53224 - Colouring removed from "Animation is being edited" warning messages Change 3843657 by Thomas.Sarkanen Enable picking via Enter for details panel asset pickers The previous (4.18) behavior was to only allow selection of the previous/next item in the list with arrow keys. A fix (CL 3783114) for pickers with many assets broke this. This change now allows for selection of any item by navigating with arrow keys and pressing Enter, as suggested in the Jira. #jira UE-53440 - Unable to select assets within modal Asset Selection dropdowns after navigating with keyboard entry Change 3843120 by Dan.Oconnor Avoid fixing component template games outside the editor, this logic does not work for games that have been nativized #jira UE-54009 Change 3842841 by Ben.Zeigler #jira UE-50020 Switch visual studio module back to using absolute paths so go to definition works, broken in CL #3796157 Change 3842582 by Lauren.Ridge Guards against the widget passed to scrollwidgetintoview being null #jira UE-54037 Change 3842575 by Max.Chen Sequence Recorder: Stop recording if the preview window is destroyed. #jira UE-49778 Change 3842551 by Michael.Dupuis #jira UE-35097: Minor bug fix, documentation, etc. to the landscape optim that was done in the phase 2 that have 0 risk. Change 3842371 by Max.Preussner Media: Merged 4.19 fixes from Dev-Sequencer CL 3807293 WmfMedia: Fixed YUY2 video format strides CL 3827988 MediaPlayerAssets: Fixed Media Texture is not linked to Media Player when created together CL 3805414 MediaAssets: Setting valid GUID when initializing media texture resource CL 3804183 MediaAssets: Added missing lock in media sound component CL 3831580 MfMedia: Media open events generated in same order as on other platforms CL 3807193 WmfMedia: Fixed incorrect buffer stride for RGB32 video tracks #jira UE-53532 #jira UE-53328 Change 3842356 by Max.Preussner ImgMedia: Fixed ensure when cooking project that uses ImgMediaSource #jira UE-51631 Change 3842335 by Aaron.McLeran #jira UE-54087 PR #4419: Fixes a crash due to nullptr dereference (Contributed by mgorzel) Change 3842286 by Rolando.Caloca UE4.19 - Fix for static analysis - Glslang 1.0.65.1 #jira UE-54128 Change 3842222 by andrew.porter QAGame: Updating framerate of EXR_Sequence #jira UE-29618 Change 3842211 by Ben.Marsh Fix determination of Windows version string. The manifest for UE4 applications declares compatibility with Windows 10 nowadays, so we get accurate version numbers returned from GetOSVersionInfo(). #jira UE-54035 Change 3842163 by Cosmin.Sulea UE-53303 - We do not check for remote connection before attempting remote shader compile, causing crashes when misconfigured #jira UE-53303 Change 3841770 by Max.Chen Sequencer: Fix to allow keying of an arbitrarily deep property path. #jira UE-54095 Change 3841758 by Max.Chen Sequencer: Fix unbound possessable components when pasting spawnables. #jira UE-54104 Change 3841415 by Lauren.Ridge Renaming a material layer or material layer blend will no longer cause the asset to appear removed from the stack #jira UE-53942 Change 3841327 by Arciel.Rekman Linux: fix Debug build (UE-53855) - A workaround. UBT should be using proper PCH files instead. #jira UE-53855 Change 3840975 by Rolando.Caloca UE4.19 - Updated VulkanRHI - Fixes for GPU frame time - Fixes for CPU performance #jira UE-50449 Change 3840838 by Michael.Dupuis #jira UE-53944: Make sure the LOD generated is in the valid range to prevent the crash Change 3840693 by Ben.Zeigler #jira UE-53923 Fix regression in 4.19 where PrintScriptCallstack is not always safe to call from the immediate window. I narrowed down the issue to some confusing optimized code so I turned off optimization Copy of CL #3840692 Change 3840680 by Aaron.McLeran Bringing fixes from Dev-AnimPhys to 4.19. #jira UE-53903 crash on load with oculus audio and old audio engine #jira UE-52786, UE-53910 Fix for broken spatialization on xaudio2, old audio engine. Change 3840663 by Rolando.Caloca UE4.19 - Fix for layout ensure on HMD projects on Vulkan #jira UE-50265 Change 3840577 by Rolando.Caloca UE4.19 - Fix for CPUs with more than 16 cores #jira UE-53434 Change 3840551 by andrew.porter QAGame: Setting Allow Bindings from Asset to false #jira UE-29618 Change 3840491 by Ben.Zeigler #jira UE-31662 Fix regression with renaming parent inherited function. It was not correctly searching the parent's skeleton class during the child's recompile so it was erroneously detecting the parent function as missing Copy of CL #3840489 Change 3840297 by Max.Chen Sequencer: Fix copy/paste crash for lights #jira UE-54084 Change 3840284 by Michael.Dupuis #jira UE-53053: Was having a mismatch between the remove reorder and the actual remove Change 3840215 by Sorin.Gradinaru Unshelved from pending changelist '3812852': UE-53550 Level doesn't render on Lenovo 939 UE-53592 Assertion right after rendering scene on Lenovo S939 #jira UE-53550 #jira UE-53592 #4.19 #Android UE-53550 Removed force disabling texture2DLodEXT and textureCubeLodEXT on Mali-400 devices The problem was that the shader compiler complains about code lines before the #extension directives. Placeholder // end extensions in the original shader code - to be replaced with round() functions UE-53592 Always use a new task for devices that have GIsThreadedRendering=false, even when the call is from the rendering thread Change 3840048 by Michael.Dupuis #jira UE-52975: Was always performing the equivalent of an Add, so now we use the Transform during the duplicate Change 3840005 by Richard.Wallis Clone of CL 3835252 Fix for shader library not working with iterative cooking, also fixes native Metal library not working with iterative cook. This works by saving a "backup" of the shader library file - this is reloaded only during iterative cook and adds back in shaders that are missing from the current cook. Fix for extracting/searching .metal files in different directories so debug tgz archiving wasn't working correctly and also support iterative cook. Includes first pass code review suggestions by Mark Sat and Dmitriy Dyomin. #jira UE-53815 Change 3839968 by Michael.Dupuis #jira UE-52289: When OnRegister is called on the component make sure our PerInstanceRenderData is up to date Prevent a possible crash if ClearInstanceSelection was called on a component with no PerInstanceRenderData existing ##codereview jack.porter Change 3839924 by Richard.Wallis Clone of CL 3838093 Fix for rewind / seek bugs in AvfMediaPlayer. - Don't initialise and send audio buffers that have a duration of Zero from the audio tap. This chokes the audio sink and adds overhead we don't need. - Don't faff around with current play rates during loop operation - normal seek doesn't do this so loop seek shouldn't either. - SetRate() should not required to be passed to media tracks - should be enough to do this on audio track select only. #jira UE-54019, UE-53027 Change 3839321 by andrew.porter QAGame: Adding missing bookmark to QA-Sequencer_Blending #jira UE-29618 Change 3839286 by Marcus.Wassmer Duplicate CL: 3823296 #jira UE-52784 Change 3839229 by Brandon.Schaefer Fix audio clean up crash when exiting PIE #jira UE-54050 #review-3839109 @Arciel.Rekman, @Aaron.McLeran Change 3839223 by andrew.porter QAGame: Rebinding pointlight actor to sequences #jira UE-29618 Change 3839098 by andrew.porter QAGame: Fixing missing sequencer blending test content #jira UE-29618 Change 3838919 by Mike.Erwin glTF: binary format's BIN chunk is not necessarily right after the JSON chunk. Discussed this with glTF spec authors. See https://github.com/KhronosGroup/glTF/issues/1177 Rearranged how we read "chunks" from the file since they are not fixed in number or order, besides JSON always being first. #jira UE-50695 Change 3838909 by Mike.Erwin glTF: base64 decoding of data buffers and images Data can be encoded inside the glTF JSON as a Base64 data URI. This CL addresses a known limitation of initial commit CL 3793018. I added this after because base64 is expected to be uncommon in the wild. Authoring software will typically use external BIN files (.gltf) or a BIN chunk (.glb) to store data. #jira UE-50695 Change 3838812 by Uriel.Doyon Integrated CL 3838576, 3838581 and 3831760 from DevRendering, fixing issues with texture streaming. #jira none Change 3838773 by Lauren.Ridge Fixing material layer filters #jira UE-54064 Change 3838748 by Michael.Trepka Fixed EngineTest runtime warning caused by CL 3838626 #jira UE-53893 Change 3838730 by Max.Chen Sequencer: Add notification when the blend type is changed. #jira UE-54046 Change 3838626 by Michael.Trepka Changed FMacMenu to store MultiBox and MenuEntryBox as weak pointers instead of shared pointers. This way we avoid a situation where FMacMenu would try to release them on the main Cocoa thread or where we'd try to execute a menu action for menu items that Slate considers released. #jira UE-53893 Change 3838392 by Arciel.Rekman Fix assert on a policy removal (UE-54042). - Applying Gil's safe fix which just sweeps the problem under the rug. #jira UE-54042 Change 3838162 by Arciel.Rekman Linux: fix crash due to lambda lifetime issues (UE-54040). - The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+). #jira UE-54040 (Edigrating 3819174 to Release-4.19) Change 3838156 by Rolando.Caloca UE4.19 - Support for Vulkan devices that have no cached memory type #jira UE-54039 Change 3838096 by Brandon.Schaefer Set sound to unfocused volume multiplier if not focused #jira UE-51327 #review-3835736 arciel.rekman Change 3838087 by Brandon.Schaefer Fix arm server building. A fix from CL 3617084 remove inheriting from IHeadMountedDisplayVulkanExtensions. Remove overrides #jira UE-53901 #review-3838088 arciel.rekman Change 3837072 by Phillip.Kavan Fix for a build failure that could occur with Blueprint nativization enabled and EDL disabled. This was a regression introduced in 4.18. - Mirrored from //UE4/Dev-Framework (3836768). #jira UE-53908 Change 3837071 by Phillip.Kavan Emit proper syntax for set/map fields containing converted assets to generated C++ Blueprint class headers when Blueprint nativization is enabled. - Mirrored from //UE4/Dev-Framework (3835944, 3835965). #jira UE-42614 Change 3837070 by Phillip.Kavan #4202 - Blueprint nativization bug fixes (PR). - Mirrored from //UE4/Dev-Framework (3830562, 3832292). #jira UE-52188 Change 3836507 by Ryan.Vance #jira UE-53992 Due to hijacking the depth target directly from the scene context, we can't support depth compositing if it's being scaled by screen percentage since it wont match our color render target dimensions. Change 3836390 by Dan.Oconnor Fix failure to resolve archetype when using the compilation manager #jira UE-53840 Change 3836251 by Ryan.Vance #jira UE-53992 Change 3835852 by Mark.Satterthwaite Fix tessellation shaders in Metal with Manual Vertex Fetch enabled: - The control points idnex buffer shouldn't collide with anything else. - We can't use the optimisation of loading texture width & height from the buffer meta-table in tessellation shaders as the combined stages don't guarantee not to clobber unused buffer slots and screw it up when we use linear textures. #jira UE-53851 Change 3835802 by JeanMichel.Dignard UBT changes for Enterprise deployment - Allow building enterprise against an installed engine version - Added enterprise to the cleanup process if its not installed #jira UEENT-748 Change 3835625 by Bogdan.Vasilache UE-50257 --> (Skeletal meshes silently fail to render if they have more than 75 bones) --> changed logged error with a warning #jira UE-50257 Change 3833649 by Mike.Beach Enabling debug layer when multiview is enabled. #jira UE-49954 Change 3833525 by Ethan.Geller Fix copyright in ActiveSound.cpp #jira none #rb none Change 3642649 by Stewart.Lynch Renamed loctext key to stop it clashing with an existing entry #jira UE-49432 Change 3644762 by Stewart.Lynch LLM update: Added Total, Untracked and FMalloc Unused to LLMFULL stat page. Fixed occasionally missing allocs/frees. Removed platform csv. * removed CheckSize arg from OnLowLevelFree * show a warning in LLM Map when replacing existing value. This means that there has been an alloc/free mismatch. * minor optimization in LLMMap::GetMaxIndex - cache Mask value * added Total and Untracked stats to LLMFULL. LLMFULL now tracks almost all of the memory that LLMPlatform does, so there is no real need to use LLMPlatform. Removed the LLMPlatform csv. * added FMalloc Unused stat to LLMFULL to account for memory Binned2 has allocated internally. This can be used to track Binned2 fragmentation over time. * renamed Binned stats to FMemory to make it more general * added Default tracking to CustomVirtualAlloc and disable it where necessary. This catches the few VirtualAlloc calls that were missed. * added AllocType arg to all allocation tracking. This was needed in order to track the FMalloc total, and also to fix the pausing * fixed a bug in pausing where alloc/frees were being missed. Now only pauses a specific allocation type. * Trackers now maintain totals for each enum tag * tracking of Texture and mesh allocation on Windows D3D11 & D3D12 Change 3651334 by Joe.Barnes Fix misspelled function name. #jira 39441 #3016 Change 3653857 by Ben.Woodhouse Integrate from //UE4/Main/...@3653675 to //UE4/Dev-Console/... Change 3656553 by Joe.Barnes Add path for SCS_DeviceDepth. Change 3662703 by Ben.Woodhouse Merging CL 3659069 from //Fortnite/Main/... to to //ue4/dev-console/...: [FORTNITE] [CONSOLE] [+] Improved frame syncing mechanism - Improves input latency by allowing the game thread to sync to the swap chain flip of the previous frame. - Added "r.GTSyncType" CVar to control how the game thread syncs with the rest of the pipe. - r.GTSyncType 2 will sync the game thread with the flip of the swap chain, preventing the pipe from getting too long and causing excess input latency. Platforms are required to implement RHIWaitForFlip and RHISignalFlipEvent, and call RHIInitializeFlipTracking on RHI startup. A separate thread monitors the progress of frame flips and signals task graph events as they pass their corresponding frame index. In r.GTSyncType 2 mode, the game thread is signaled by this flip tracking thread. [~] Unified platform specific sync interval CVars into one: rhi.SyncInterval - 1 == 60Hz - 2 == 30Hz - 3 == 20Hz Change 3675239 by Keith.Judge Fixed thread priorities for Windows so that BelowNormal and SlightlyBelowNormal are the same. Bumped Lowest down a notch so they all fit. #jira UE-50626 Change 3676709 by Ben.Woodhouse Integrate from //UE4/Main/...@3675008 to //UE4/Dev-Console/... Change 3689712 by Ben.Woodhouse Integrate from //UE4/Main/...@3687781 to //UE4/Dev-Console/... Change 3701778 by Ben.Woodhouse Integrate from //UE4/Main/...@3699491 to //UE4/Dev-Console/... Change 3677043 by Ben.Woodhouse From StewartL: I also found that on Windows Fortnite is overflowing int32 values due to the number of allocations. I changed LLMArray and LLMMap to use uint32 and it seems to be Ok now. I didn't want to check this in at the last minute, so here's the shelf: 3645336 Change 3726532 by Luke.Thatcher [CONSOLE] [~] Enable XGE shader compilation by default. - Also set XGE mode to "force interception". With XGE on by default, we don't want people with an old Incredibuild version using the old system inadvertently. Change 3726554 by Luke.Thatcher [CONSOLE] [+] Improved Scoped Named Events - Added SCOPED_NAMED_EVENT(_FSTRING/_TEXT/_F) macros to allow use of string literals, FString and printf in scoped named event strings. - Replaced explicit use of FPlatformMisc::Begin/EndNamedEvent throughout the engine with macros, so the events can be compiled out. - Fixed performance issues on various platforms with named events. SCOPED_NAMED_EVENT macros were not considering whether the platform uses wide or ansi char strings. Change 3751378 by Ben.Woodhouse Integrate from //UE4/Main/...@3748735 to //UE4/Dev-Console/... Change 3751812 by Ben.Woodhouse Integrate from //UE4/Main/...@3750870 to //UE4/Dev-Console/... Change 3728571 by Luke.Thatcher [CONSOLE] [!] Drop another XGE controller warning to log. Change 3747150 by Joe.Barnes Add AuthoringToolHelper.bat file to installed build copy list. Change 3768585 by Ben.Woodhouse Integrate from //UE4/Main/...@3767531 to //UE4/Dev-Console/... Change 3772333 by Ben.Woodhouse Integrate from //UE4/Main/...@3771573 to //UE4/Dev-Console/... Change 3786872 by Ben.Woodhouse Integrate from //UE4/Main/...@3786785 to //UE4/Dev-Console/... Change 3787279 by Luke.Thatcher [CONSOLE] [~] Unified present threshold CVars. - CVars are now in RHIUtilities.cpp, and are renamed to rhi.PresentThreshold.Top and rhi.PresentThreshold.Bottom. - Platform implementations will be checked in shortly. Change 3787445 by Luke.Thatcher [CONSOLE] [^] Merging (as edit) improvements to low-latency frame syncing from //Fortnite/Main to //UE4/Dev-Console Original CLs - 3708949 - Added rhi.SyncSlackMS cvar to allow an offset of the game thread sync time by a number of milliseconds. - 3712693 - Fix for crash on startup in new frame syncing. - 3735765 - Fix r.GTSyncType logic when vsync is disabled (falls back to old behaviour when vsync is off). Change 3788417 by Ben.Woodhouse Duplicate from FN CL 3712515 CSV profiler GPU and pre-declared stat support - refactor the GPU profiler so it's no longer dependent on the stats system and can work in Test builds - add support for pre-declared CSV stats, using FNames (these are required for GPU stats) - add DECLARE_GPU_STAT macro which handles STATS and CsvProfiler declarations Note: still a few issues to resolve with GPU stats: these randomly go to 0 at times during a replay on XB1, the GPU total is lower than the stat unit number, and the unaccounted stat is too large due to missing stats Change 3807818 by Ben.Woodhouse Integrate from //UE4/Main/...@3803271 to //UE4/Dev-Console/... Change 3818577 by Ben.Woodhouse Integrate from //UE4/Main/...@3812936 to //UE4/Dev-Console/... Change 3821198 by Ben.Woodhouse Integrate from //UE4/Release-4.19/...@3820127 to //UE4/Dev-Console/... Change 3821519 by Ben.Woodhouse Integrate from //UE4/Release-4.19/...@3820753 to //UE4/Dev-Console/... #robomerge none Change 3813513 by Ben.Woodhouse CSV profiler refactor+ bug fix - Move the CSV profiler to core, so we can use it in modules other than engine - Profiler no longer enqueues RT commands - this is handled by a new core delegate type - Make begin/end requests more robust, enqueued via a command queue and processed in order - Defer end capture requests by a frame. This ensures stats on threads other than the gamethread (e.g. renderthread etc) are complete, so the last frame is not truncated - Fix long-standing bug with multiple captures where old/stale frames would appear in the first <128 frames of captures - Move unit stats and dynamic resolution out of the profiler itself and into the engine. Only frametime is recorded in the profiler now - Fix longstanding bug in first frame renderthread time in the engine Change 3814039 by Ben.Woodhouse More Csvprofiler improvements - Event support (via CSV_EVENT macros). These appear in the "EVENTS" column of the CSV and can be used to add context to the stat data - Reduced memory overhead for timestamps through bit-packing (now 16 bytes per marker instead of 24), and splitting stats into different types Change 3814041 by Ben.Woodhouse Integrate as edit CL 3796390 from Fortnite/Main: Fix CsvProfiler not compiling in shipping for now Change 3814229 by Ben.Woodhouse Integrate + refactor of CL 3792591 to reduce complexity and fix bugs Original changelist description: CSV profiler improvements: - The CSV profiler is now always compiled in on the server - The CSV profiler can now handle both int32 and float stats - In BeginCapture, the function can take additional arguments for some customization of filenames Fixes to the above: - Remove FCustomValue class - Fixes bug where all timestamp values from CSV_SCOPED_STATs were garbage (due to issues resulting from FCustomValue type ambiguity when adding values together) - FCsvCustomStat now just uses simple union + bitfield flag to reduce size and complexity (4 bytes instead of 8 per value) - FCsvColumn class modified to use doubles, which can represent both ints and floats without loss of precision - this class is not memory or time critical - Replace multiple overrides used by the server for filenameprefix/folder/postfix etc with a single FilenameOverride Change 3814242 by Ben.Woodhouse Disable CSV unit stats on the dedicated server Change 3817339 by Ben.Woodhouse Duplicate from 3816641: CSV profiler improvements - Added a low-pri processing thread to compress raw timing data into a much more efficient format - Reduces memory usage for 15 minute 30k frame capture with GPU stats enabled from 110MB to 3.4MB - Processing time : 0.1ms per frame - Improved name handling for char literal stats. We now use the string as the ID rather than the pointer so multiple stat uses of the same name string apply only to a single stat - Reworked thread data access to eliminate locking for anything time-critical. Frame boundaries now handled via a lock-free helper class - Fixed bug with queue implementation where 1 in 128 reads would duplicate the last block of stat data - Reduced #include dependencies for CSVProfiler.h - Removed AccumulateMax because it doesn't work, and implementing properly would add a lot of complexity - Added a simple test harness Change 3817582 by Ben.Woodhouse Fix android compile warning Change 3823242 by Ben.Woodhouse Integrate as edit from Fortnite/Main 3820067: Fix threading issue with D3D12 pipeline state caches for windows. This was caused by the usage of FRwScopeLock::RaiseLockToWrite. A pointer read before RaiseLockToWrite was called was invalidated because RaiseLockToWrite has to release the read lock before acquiring the write lock. Rename FRwScopeLock::RaiseLockToWrite to ReleaseReadOnlyLockAndAcquireWriteLock_USE_WITH_CAUTION to make it more explicit what's happening. As the comment says: // This function should be used with caution. // It releases the read lock _before_ acquiring a new write lock. This is not an atomic operation and the caller should // not treat it as such. // E.g. Pointers read from protected data structures prior to this call may be invalid after the function is called. Change 3823840 by Ben.Woodhouse Edigrate from 3823816 Fix an issue where the csvprofile console commands would sometimes result in an empty CSV. The root cause was GFrameNumber incrementing between the console command being read and FCSVProfiler::EndFrame(). We now use our own frame counter which is updated in EndFrame, so this can't happen Also fix an issue where calling csvprofile stop twice would cause all further commands to be ignored. Change 3827787 by Ben.Woodhouse Integrate-as-edit CL 3820678 from Fortnite/Main Allow the CSV Profiler to be compiled in to shipping dedicated server builds Change 3827842 by Ben.Woodhouse Integrate-as-edit CL 3827079 from Fortnite/Main CSV profiler category support Change 3827918 by Luke.Thatcher [CONSOLE] [!] Fix compile error in CSV custom stats. Change 3827964 by Luke.Thatcher [CONSOLE] [!] Fix inverted logic and spelling of boolean. - Functionally, the boolean did the correct thing, but the logic was backwards inside the build tool. Change 3831661 by Ben.Woodhouse Integrate-as-edit CL 3830630 from Fortnite/Main Fix CSVProfiler assert in dev builds on XB1 Change 3860300 by Joe.Barnes Use same method for src and dest rect calculation as other post processing passes so rects match between passes. Prevents read of unprocessed pixels. Change 3860347 by Joe.Barnes Delete existing SourceConfigFile before allocating a new one to prevent them leaking. Change 3860348 by Joe.Barnes Completely encapsulate GetLLMAlloc() in #ifdef. Change 3861772 by Ben.Woodhouse Integrate-as-edit CL 3861688 from Fortnite/Main: Forward lighting GPU crash fixes Change 3861774 by Ben.Woodhouse Integrate as edit CL 3833918 from dev-rendering (courtesy of DanielW): D3D12 RHI: only refcount uniform buffers if GRHINeedsExtraDeletionLatency is false, which is no longer the case for PC. The refcounting was heavy on performance as reported by a licensee because FRHIResource uses atomics for refcounting, which is only necessary when GRHINeedsExtraDeletionLatency is disabled. Change 3862214 by Ben.Woodhouse Integrate-as-edit CL 3859637 from Fortnite/Main Dynamic resolution console tweaks - Dynamic resolution high level switch driven by a cvar instead of code - Disable user settings dynamic resolution handling on non-desktop platforms. DynamicRes as a user setting does not make sense on consoles/mobile - we'll drive it from device profiles/scalability - Modify naming of GPUHeadRoom to make it clear that it's a percentage, not millseconds Change 3863919 by Ben.Woodhouse [Copy] Integrate console dynamic resolution interface changes from CL 3863354, 3862754, 3862639 Change 3864347 by Ben.Woodhouse Fix the editor build. This will need a proper fix before 4.19 ships. #lockdown Nick.Penwarden #rb none [CL 3913399 by Ben Marsh in Main branch]
2018-02-27 17:30:35 -05:00
if (NumValuePinsWithLinks == 1 && (OutputPin->PinType.PinValueType.TerminalCategory == UEdGraphSchema_K2::PC_Wildcard && Pin->LinkedTo[0]->PinType.PinCategory != UEdGraphSchema_K2::PC_Wildcard))
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
{
// Update the types on all the pins
OutputPin->PinType.PinValueType = FEdGraphTerminalType::FromPinType(Pin->LinkedTo[0]->PinType);
bNotifyGraphChanged = true;
}
}
else
{
// Just made a connection to a key pin, was it the first?
Copying //UE4/Release-Staging-4.19 to //UE4/Dev-Main (Source: //UE4/Release-4.19 @ 3873914) ============================ MAJOR FEATURES & CHANGES ============================ Change 3873906 by Dan.Oconnor Revised fix for preventing delegate functions from appearing in context menu when using the compilation manager - needed to run after CallDelegateHandler changed statement type #jira UE-51726 Change 3873614 by Dan.Oconnor Prevent delegate functions from appearing in context menu when using the compilation manager and prevent crash if such a function is somehow compiled #jira UE-51726 Change 3873428 by Ben.Zeigler #jira UE-54753 Fix class pin on SpawnActorFromClass to correctly support browse. It was inherting from the wrong pin widget Copy of 3873408 Change 3873083 by Ethan.Geller [4.19]#jira UE-54865 fix seconds -> milliseconds conversion issue. #rb aaron.mcleran #lockdown cristina.riveron Change 3872714 by Dan.Oconnor Further revise fix for UE-53840, mistakenly reverted to old behavior when compiling synchronously #jira UE-53840 Change 3872648 by Ben.Zeigler #jira UE-54845 Fix crash in NextDebugTarget when there are no valid debug targets Copy of CL #3872636 Change 3872500 by Arne.Schober Back out changelist 3870283 #jira UE-54838 Change 3872412 by Mark.Satterthwaite Remove now unnecessary r.Metal.ManualVertexFetch from the device profiles. #jira UE-54853 Change 3872313 by Martin.Wilson Add UI to Live Link Client to warn live link users about background performance throttling #jira none Change 3872272 by Martin.Wilson Fix crash when clearing a skeletal mesh on a skeletal mesh component with an active Post Process Anim Instance #jira none Change 3872238 by Mark.Satterthwaite Duplicate CL #3871025 Make Manual Vertex Fetch a property of the shader platform for Metal - only the desktop platforms (METAL SM5/SM5_NoTess/MRT) will use manual vertex fetch. The mobile platforms use vertex descriptors. Prevents problems with cooked versions of games not working properly on Metal due to a mismatch between the runtime's Manual-Vertex-Fetch state versus the state used by the cooker when compiling shaders. #jira UE-54843 Change 3872087 by Yasiman.Ahsani Adding Python, libdisasm, musl, and LSS licenses. #JIRA n/a - adding licenses for new TPS Change 3872037 by Ben.Marsh BuildGraph: Add a task for compiling MSBuild projects. #jira Change 3871934 by Lina.Halper #jira: UE-54703 Change 3871595 by Michael.Trepka Fixed a problem with Mac editor not exiting with error code returned from GuardedMain function #jira UE-54830 Change 3870829 by Joe.Barnes Fix unintentional change to PhysX libs used in Debug builds. #jira ue-54817 Change 3870820 by Nick.Atamas Copying //Tasks/UE4/Dev-VR-4.19a@3870772 to Release-4.19 (//UE4/Release-4.19) #jira UE-54816 Change 3870755 by Chance.Ivey Min Android version set - should fix camera permissions issue found in #JIRA UE-54024 #rb none #fyi nick.atamas Change 3870547 by Krzysztof.Narkowicz Fixed FreezeRendering on non editor builds: ComputeAndMarkRelevanceForViewParallel was calling FrozenMatricesGuard on multiple threads, reading and writing view matrices state in parallel. #jira UE-53640 Change 3870546 by Krzysztof.Narkowicz Fixed tesselation shader tex/uniform initialization in OpenGL3/4 path #jira UE-54471 Change 3870284 by Ben.Zeigler #jira UE-54583 Fix issue where loading multiple already loaded assets via Async Load Asset node could return the wrong asset on the loaded pin. The assign variable node was happening at a slightly wrong time Copy of CL #3870279 Change 3870283 by Arne.Schober SafeRelease SRVs that might be hold by the Vertexfactories (maybe due to indirect use in GlobalResources) Note that the VFs are not owners of the data, e.g the underlying Buffers might be released before this and this reference counting should be uneccessary #jira none Change 3870098 by Ben.Marsh Fix OptimizeCode = CodeOptimization.Always causing compile errors in Linux debug builds. bUseInlining was not set correctly on the global compile environment used to build shared PCHs. Also fixed other settings not being propogated down from the target correctly. #jira UE-53855 Change 3870013 by Ben.Marsh UBT: Add an error if a user attempts to clean a target through hot-reload, rather than just failing to delete DLLs because they are locked. #jira UE-54179 Change 3870010 by Ben.Marsh UBT: Add an option to format output messages in a form that can be parsed by MSBuild. Prevents errors showing as "EXEC: Error:", and displays them correctly in the error list window. #jira Change 3869814 by Ben.Marsh UBT: Unify command line arguments to use -Name=Value syntax. -Module <Name>, -ModuleWithSuffix <Name> <Suffix>, -Plugin <Path> and -Receipt <Path> are no longer supported. Also remove the RemoteRoot option, which was not used anywhere. #jira Change 3869786 by Martin.Wilson Fix Live Link Remove Source button not working #Jira UE-54652 Change 3869660 by Martin.Wilson Fix missing message bus sources in the live link client (not repolling for new sources) #Jira UE-54712 Change 3869659 by Guillaume.Abadie Fixes SimpleComposure's BP_AdvancedCompositing keep allocating memory every frame. Credits for fixing the issue to Ron Radeztsk. #jira UE-54780 Change 3869401 by Lauren.Ridge Adding to the conditional in FindAllAncestorNamedSlotHostWidgetsForContent #jira UE-51470 Change 3869384 by Brandon.Schaefer Open the project in the explorer when NullSourceCodeAccess is done creating the project #jira UE-54630 Change 3869308 by Ben.Marsh PR #4452: Fixed FindFilesRecursively in IPlatformFilePak (Contributed by user37337) #jira UE-54568 Change 3869265 by Martin.Wilson Fix crash and subsequently found issues with unloading/reloading Maya Live Link plugin -Crash on reload due to core code getting reinitialize, made this a one time only thing (as Maya never gets rid of the module from memory) -Added manual ticking of FTicker, allows message bus objects to be cleaned up properly (cannot do this as part of normal flow as it is in engine code which we dont have) -rebuild binaries for Engine/Extras #Jira UE-54643 Change 3869206 by Benn.Gallagher Fixed crash updating clothing paint mode after tab spawners have been destroyed by the hosting application. #jira UE-54116 Change 3869064 by Benn.Gallagher Resolved skeletal mesh data changes and clothing section disable changes after collision. Re-added ability to disable sections at the mesh level and removed the ability to strip editor sections as these are required for a number of other features to correctly function. #jira UE-52557 Change 3869062 by Guillaume.Abadie Fixes "dynamic resolution is not supported on this platform" warning message being always visible. #jira UE-54655 Change 3868202 by Lauren.Ridge Fix for assert on expanding vector param in layered material #jira UE-54737 Change 3868161 by zak.parrish Replacing FaceARDebugUI with a blank UI until a new one can be created, due to a crash bug. #rb none #JIRA UE-54639 Change 3867750 by Ethan.Geller [4.19] #jira UE-54725 Fix for Envelope attack and release values not being properly set on Synth Components #rb aaron.mcleran #lockdown cristina.riveron Change 3867657 by Lauren.Ridge Adding if with editor wrapper to new function #jira cis fix Change 3867646 by Aaron.McLeran #jira UE-53867 Access violation on Switch when playing sound with specified time out of range Change 3867340 by Lauren.Ridge Fixes to Material Layers from 4.19 preview feedback -Need to pass through base attributes better/have better default nodes in layer (optional Example Layers and Blends checkbox now enables this in Experimental Settings) -Parent in function should be editable -Enforce only two layers in a blend -Mat layer should warn if it has incorrect output in the layer itself -Enforce not being able to delete outputs -Warn about creating a MAL node inside a function #jira UETOOL-1312 Change 3867317 by Aaron.McLeran #jira UE-53867 Access violation on Switch when playing sound with specified time out of range Change 3867000 by Lauren.Ridge Fix for folder favorites possibly becoming very large #jira UE-54704 Change 3866892 by Martin.Wilson Fix crash if clicking ok on message bus add source without having a source selected #jira UE-54572 Change 3866391 by Matt.Kuhlenschmidt Fix static analysis #jira UE-53379 Change 3866241 by Ryan.Vance #jira UE-54681 Fixed missing Vulkan texture GetNativeResource implementation that was lost in a bad merge. Change 3866071 by Nick.Shin UDN 412414 update HTMl5 readme file #jira none Change 3866005 by Max.Preussner Messaging: Preventing dangling references when removing message subscribers #jira UE-54680 Change 3865988 by Simon.Tourangeau Fix static analysis warnings #jira none Change 3865895 by zachary.wilson Renaming QA-PhysicalLightUnits to TM-PhysicalLightUnits in QAGame. #JIRA UE-29618 Change 3865469 by Simon.Tourangeau Support for DX11 quad buffer stereo rendering #jira UEENT-704 Change 3865461 by Chris.Babcock Add a wait for audio thread to pause audio on going to background #jira UE-54301 #ue4 #android Change 3865350 by Matt.Kuhlenschmidt Fix issue where cascade emitter UI would disapper #jira UE-53379 Change 3865336 by Arne.Schober REL - Fix UE-52356 Bone Weight #jira UE-52356 Change 3865257 by Ben.Marsh Fix editor failing to load content-only projects when compiled in DebugGame. #jira UE-54661 Change 3865238 by Simon.Tovey Pulling Olaf's fix from 3832595 over to release #tests EngineTests boots in vulkan #JIRA UE-54394 Change 3865191 by Sorin.Gradinaru UE-54317 DXT apps fail on first launch when 'For Distribution' enabled, Unsupported Texture Format #jira UE-54317 #Android #4.19 From //Dev-Mobile/3863322 Change 3865190 by Sorin.Gradinaru UE-54175 Selecting For Distribution no longer sets configuration to Shipping #UE4 #4.19 #jira UE-54175 From //Dev-Mobile/3863371 "For Distribution" enable-> reset "Build COnfiguration" to Shipping and force serialization to DefaultGame.ini (see UE-52845) Change 3865056 by Jamie.Dale Fixed culture being incorrect when added via the Localization Dashboard #jira none Change 3864826 by Max.Preussner WmfMedia: Added missing scope lock #jira UE-54365 Change 3864055 by Aaron.McLeran #jira UE-54213 Crash fix for GC'd plugin settings objects. Adding to AddReferencedObjects. Change 3863775 by Andrew.Porter MediaFrameworkTest: Removing Platform Media Source TVOS test content #jira UE-29618 Change 3863714 by Dan.Oconnor Make array, set, and map nodes no longer switch object type when a pin is disconnected. Also, you can no longer attach unrelated map types to the MakeMap node if only the value pin has been inferred #jira UE-54634 Change 3863696 by Max.Chen Sequencer: Fix crash open a new sequence while another is still active. #jira UE-54620 #jira UE-54624 Change 3863638 by Dan.Oconnor Make sure all blueprints that are skeleton compiled get a BroadcastChanged notification, also run BroadcastChanged after reinstancing, matching pre compilation manager behavior #jira UE-54193 Change 3863494 by Jamie.Dale Ensure Py_SetPythonHome is set correctly before the embedded Python interpreter is initialized #jira UE-54345 Change 3863433 by Max.Preussner MediaPlayerEditor: Removed tvOS from list of available platforms in Platform Media Source assets tvOS currently reports itself as iOS, so it cannot have its own setting. #jira UE-54559 Change 3863406 by Lauren.Ridge Fix for a crash when filtering a dropdown with no set value #jira UE-54631 Change 3863238 by Michael.Kirzinger #jira UE-52730: Fix mac voip crash Change 3862586 by Marc.Audy Clean up rendering thread heartbeat checks that got mangled in various integrations #jira Change 3862247 by Guillaume.Abadie Fixes editor lines that were using a simple element blending mode that was generating an incorrect alpha channel. #jira UE-53830 Change 3862120 by Guillaume.Abadie Fixes USceneCaptureComponent::HiddenActors always staying gray out in world editor. #jira UE-51458 Change 3861363 by Jamie.Dale Static analysis fixes #jira none Change 3861150 by Matt.Kuhlenschmidt Fix static mesh editor displaying 0 for all stats on LODs > 0 #jira UE-53776 Change 3860990 by Dan.Oconnor Clear subobjects not recreated on load, e.g. because we're running with -game and the subobject was created using CreateEditorOnlySubobject #jira UE-54551 Change 3860972 by Nick.Shin HTML5 - detect "SyntaxError: " and do a forced reload - an actual syntax error would be caught during compile time - this is usually error condition is usually seen when browser is running "old/partial" cached data and it's fairly safe to just reload the page #jira UE-54017 QAGame fails to launch properly on HTML5 Firefox 64 bit Change 3860951 by Arne.Schober Fix not releaseing SRV on render thread for FPositionVertexBuffer, FStaticMeshVertexBuffer, FColorVertexBuffer, FStaticMeshInstanceBuffer. #jira UE-54587 Change 3860950 by tim.gautier QAGame: Updating ML_Stone to include Texture Coordinate and Panner functions #jira UE-29618 Change 3860833 by Michael.Dupuis #jira UE-54181: Repopulate the foliage list when existing simulate mode Let the GC know that internal struct hold UObject ptr Change 3860762 by Jamie.Dale Ensure we invoke the correct version of Python from UBT #jira UE-54345 Change 3860676 by Simon.Tourangeau Remove DirectoryWatcher warning in output log #jira UEENT-846 Change 3860598 by Lauren.Ridge Fix for crash on opening new material instance #jira UE-54589 Change 3860338 by Michael.Lentine Integrate changes for fixing MorphTargets. #jira 54398 Change 3860215 by Ben.Marsh UAT: Fix exception consturcting target rules assembly inside UAT, now that there's an abstract TargetRules class. #jira UE-54578 Change 3860186 by Matt.Kuhlenschmidt Fix crash top 10 with the font editor shutting down and then a dpi event occuring #jira UE-54543 Change 3859854 by Graeme.Thornton PR #4124: VSCode: Changed VisualStudioCodeSourceCodeAccessor to work with non-default VSCode install paths on Linux (Contributed by christopherreed) #jira UE-51289 Change 3859848 by Graeme.Thornton Fix crypto.cs reading the wrong ini setting names for uasset encryption settings #jira UE-54566 Change 3859684 by Ben.Marsh PR #4436: Fix compile error when building BlankProgram because incorrect directory path (Contributed by windkey) #jira UE-54392 Change 3859657 by Ben.Marsh Fix FTransform being passed by value, causing alignment error when compiling for Win32. #jira Change 3859312 by nick.bullard Updating AEOverviewMan to remove reference to sub-level AEOverviewSWP which was deleted in 3859278 Still need to update menu to remove selection #jira UE-50784 Change 3859278 by Nick.Bullard Deleteing AEOverviewSWP.umap per request of Developer. Also updated TM-AnimPhys which refereneced this map as well. "This test map is a custom C++ implementation of a "procedural sound wave". This code is super janky and not worth fixing up. I'm sure there's a legit thread safety problem in there but the code is in QAGame only. We've since implemented "synth components" which do what this test does in a much safer/better way and maintaining/testing this old thing is *not* worth the time." #jira UE-50784 Change 3859124 by Dan.Oconnor Fix long standing crash when duplicating a blueprint that is missing its parent class. Entries in CrashReport go back to 4.16 #jira UE-54468 Change 3859086 by Ryan.Vance #jira UE-54470 We need to set the viewport in both cases. Change 3859006 by Dan.Oconnor Revise fix for archetype lookup when reinstancing. During compilation we do not want to force use of the up to date class #jira UE-54541 Change 3858990 by mason.seay Cleaned up blueprints to remove compile errors #jira UE-29618 Change 3858945 by Aaron.McLeran #jira UE-54265 PR #4428: Fixing Envelope Bug in AudioMixer (Contributed by Chrispykins) Change 3858719 by Aaron.McLeran #jira UE-54552 Fix for sample buffer reader Change 3858647 by Ethan.Geller PR #4439: Removes ambiX -> FuMa conversion (Contributed by mgorzel) #jira UE-54407 Change 3858364 by Michael.Dupuis #jira UE-52049: There was a case where adding and removing multiple time would lead to reordering the instances and this would cause the regeneration of the random stream for all the reorded instances. Change 3858268 by Dan.Oconnor Prevent postload logic running on REINST and SKEL classes #jira UE-54531 Change 3858205 by Mitchell.Wilson Removed particle looping from some emitters to resolve anim notify warnings. #jira UE-53823 Change 3858148 by Lauren.Ridge Changes based on Material Layer Feedback from previews - (Temporary) Disabled being able to create a layer or blend in the asset dropdown - Sections of the stack that have been disabled now inactivate that part of the UI - Create Function Instance now indicates if you are making a layer or a blend - Parent dropdown has been removed from layers and blends. Where relevant, a filter button has been added instead. #jira UETOOL-1328 Change 3857933 by Michael.Dupuis #jira UE-45854: Properly unregister callback when replacing foliage type with another one Change 3857898 by Michael.Dupuis #jira UE-54396: Remove the Ensure as it could be possible that the Landscape Info is invalid during an undo operation Change 3857878 by Max.Chen Sequencer: Assign the sequence id after the template is compiled. Copy from Dev-Sequencer #jira UE-54462 Change 3857808 by Michael.Dupuis #jira UE-54421: Prevent edition during Simulate when clicking on actor Change 3857786 by Rolando.Caloca UE4.19 - Fix recompute tangents and skin cache for OpenGL #jira UE-42108 PR #3271 Change 3857549 by Lina.Halper another jittering issue due to revision number change clear the motion vector after compile #jira: UE-53930 Change 3857439 by Lina.Halper Clear motion vector when end of sequencer when in editor world #jira:UE-54057 Change 3857384 by Graeme.Thornton Restore fix for visual studio source code accessor not correctly determining that a content project has no solution and opening a fresh instance of visual studio #jira UE-50020 Change 3856596 by Chris.Babcock Fix ResonanceAudioApi Android library architecture filtering #jira UE-54478 #ue4 #android Change 3856449 by Michael.Dupuis #jira UE-35097: Various cosmetic changes that were done in phase 2 that help improve clarity of the design. Change 3856415 by Dan.Oconnor Fix regression when loading instances that have had their class deleted. Issue detected by static analysis #jira UE-54467 Change 3856332 by Ben.Marsh Resaving TP_HandheldARBP assets to fix version again. #jira Change 3856319 by Ben.Marsh Back out changelist 3855588 Causes build failure in UFE because it introduces a dependency on the Engine module. UFE compiles with WITH_ENGINE = 0. #jira UE-54472 Change 3856292 by Ben.Marsh Fix app-local dependencies not being included in binary builds, and only working for code projects in source builds. #jira UE-54448 Change 3856190 by Martin.Wilson Fix bone access mismatch between raw mesh bones and final bones (that include virtual bones too) #jira UE-54266 Change 3856169 by Ben.Marsh Tag XGEControlWorker.exe as a build product, so it's included in the binary distro. #jira UE-54283 Change 3856123 by Chris.Babcock Fix missing ARCore file #jira UE-54453 #ue4 #android Change 3856005 by Richard.Wallis Clone of Dev-Rendering CL 3855993 - turn off FShaderCache. #jira UE-52928 Change 3855961 by Jian.Ru Copy 3855047 - fix DFAO Nan problem #jira UE-54403 Change 3855811 by Martin.Wilson Add build process for Maya Live Link plugin (standalone, manually triggered) + add built binaries to Engine/Extras (Maya 2016, Maya 2017, Maya 2018) #jira none Change 3855758 by Cosmin.Sulea UE-53569 - tvOS does not package or launch-on #jira UE-53569 Change 3855727 by Ben.Marsh Resaving assets with a versioned build in the editor, to fix warnings building DDC. #jira Change 3855626 by Adrian.Siminciuc https://jira.it.epicgames.net/browse/UE-50979 (MP4 doesn't resume playback when iOS 11 device wakes from sleep) #jira UE-50979 Change 3855588 by Graeme.Thornton Fix visual studio solution path being incorrect for content projects #jira UE-50020 Change 3855283 by Ben.Marsh Fix race condition where stdout/stderr write handles could be inherited by multiple processes, resulting in them not being closed (and the process exit being detected) until all processes that inherited them had been closed. Improves performance of ParallelExecutor. #jira Change 3855009 by Chance.Ivey Resaving with version number. #JIRA-54330 #rb none Change 3854943 by Dan.Oconnor Fix archetype lookup when searching hierarchy that has been partially reinstanced #jira UE-53840 Change 3854882 by Ryan.Vance #jira UE-54438 Removing vr related references to screen percentage. Removing previously removed gvr screen percentage code that came back in an integration from google. Change 3854806 by Mike.Beach Mirroring part of CL 3802176 to fix a crash that can occur when users try to use the default 'DisplayModel' on MotionController components. Also provided users a better error message to explain why a model might not be showing up. #jira UE-54214 Change 3854680 by Chance.Ivey Saving assets with version number#JIRA UE-54330 #rb none Change 3854652 by Uriel.Doyon Added a tooltip to the EV100 slider in the exposure menu. Using game settings now disables the slider. #jira UE-53945 Change 3854605 by Dan.Oconnor Make sure we don't create objects outered to a placeholder object, also make sure that archetypes that are reinstanced on load are relinked in to the linker table so that they are postload'd (and the old instance isn't) #jira UE-53954 Change 3854274 by Brandon.Schaefer Changes in CL 3842286 changed the function glslang::GlslangToSpv and requires a rebuild on Linux #jira UE-54302 #codeview Arciel.Rekman Change 3854255 by Phillip.Kavan Fix a scoping issue for local instanced subobject references in nativized Blueprint C++ code. Also, don't emit redundant assignment statements for instanced subobject reference properties. - Mirrored from //UE4/Dev-Framework (3853349). #jira UE-53960 Change 3854177 by Ethan.Geller #jira UE-54415 set EnabledByDefault to false for Resonance Audio Change 3854123 by Ethan.Geller #jira UE-54410 set AudioComponentID Change 3853775 by Lauren.Ridge Minor cleanup #jira UE-54054 Change 3853772 by Lauren.Ridge Don't create widgets when just testing if the selected widget is a replacement candidate #jira UE-54054 Change 3853715 by Rolando.Caloca UE4.19 - Fix for OpenGL overwriting texture units #jira UE-54401 Change 3853655 by Ben.Marsh Add a retry loop on creating the first directory before copying files. Attempt to work around problems copying to shared folders. #jira Change 3853535 by Ben.Marsh Expose the engine compatible changelist to Perforce. If EnginePatchVersion > 0, this will be the changelist of the original .0 release. #jira Change 3852583 by Nick.Atamas Resaved assets so they don't produce DDC warnings. #jira none Change 3852552 by Uriel.Doyon Fixed Pre-Exposure shader compilation and Temporal AA issue. #jira UE-54276 Change 3852354 by Nick.Atamas Hopefully fixes the static analysis warning from jira issue. #jira UE-54332 Change 3852281 by Nick.Atamas Merging CL 3851690 from //Tasks/UE4/Dev-VR-4.19a/... to //UE4/Telease-4.19/... #jira UE-54331 Change 3852274 by Simon.Tourangeau Back out changelist 3851041 until Win7 issue is resolved. #jira UE-54354 Change 3852208 by Jamie.Dale Merging CL# 3821754 from //UE4/Dev-Enterprise Class property conversion now goes through NativizeClass/PythonizeClass This allows it to coerce from Python wrapped object types #jira none Change 3852202 by Jamie.Dale More explicit handling of EngineDir for Python SDK #jira UE-54345 Change 3851982 by Brandon.Schaefer Workaround using a hardcoded path #jira UE-54136 Change 3851748 by Michael.Dupuis #jira UE-53904: Put the code back to what it was before, as we really only want to perform this code if bIsLayerThumbnail is true, it was changed to fix another issue complaining about a missing shader, that end up being added to the existing functions Change 3851545 by Marc.Audy Remove debugging code that slipped in #jira none Change 3851461 by Ben.Marsh Fix #includes with backslashes from crashing UBT. #jira UE-53996 Change 3851391 by Jamie.Dale Updated Python to prefer our TPS SDK #jira UE-54345 Change 3851372 by Jamie.Dale Added bat file to copy the Python SDK into TPS #jira UE-54345 Change 3851218 by Ben.Marsh Add missing template to installed engine build. #jira UE-54339 Change 3851117 by andrew.porter QAGame: Removing duplicate map #jira UE-29618 Change 3851041 by Simon.Tourangeau Support for DX11 quad buffer stereo rendering #jira UEENT-704 Change 3850548 by Ben.Marsh Add TP_HandheldARBP to installed engine build. #jira Change 3850424 by Ben.Zeigler Fix reported memory for asset registry to be correct, extracted from a larger change #jira none Change 3850324 by Ryan.Vance #jira UEVR-1050 Hook up the Rift dynamic res to the new IDynamicResolutionState framework Change 3849819 by JeanLuc.Corenthin Unhide Datasmith plugins in "regular" projects to allow easy project conversion #jira UEENT-795 Change 3849302 by Martin.Wilson Live Link is no longer experimental in 4.19 (moved from experimental folder to Animation) #jira none Change 3849238 by Max.Chen Sequencer: Remove bKeepStaleTracks so that stale tracks are now always purged. #jira UE-54248 Change 3849211 by Michael.Dupuis #jira UE-54181: Prevent foliage edition during PIE or simulate mode #coderevire jack.porter Change 3849123 by Benn.Gallagher Fixed crash in clothing actor creation when the clothing simulation mesh has no simulated vertices #jira UE-53741 Change 3849120 by Benn.Gallagher Fixed crash adding empty materials to destructible meshes in the destructible mesh editor #jira UE-53938 Change 3849047 by Jurre.deBaare Move material baking out of experimental #fix follow-up also remove the entry from experimental settings #jira UE-52685 Change 3848808 by Michael.Dupuis #jira UE-35097: Remove IncludeTessellationInShadowLOD & RestrictTessellationToShadowCascade from 4.19 as there is currently a bug regarding this in the dynamic rendering code path and would be too risky to fix for now. Fixed dynamic shadow code path issue vs static code path Change 3848659 by Lina.Halper Fix issue with animation resetting in the sequencer #jira: UE-54047 Change 3848635 by Rolando.Caloca UE4.19 - Fix static analysis #jira UE-50449 Change 3848515 by Sorin.Gradinaru Unshelved from pending changelist '3843541': WebBrowser Android crash on 4.4.3 #jira UE-53247 #Android #4.19 Crash on Android 4.x.x caused by a call to a Api Level 21 method Change 3848514 by Jurre.deBaare Moving over: CL 3832173 "Failed to import Alembic files #jira UE-53941 #fix Change Alembic thirdparty library setup - Removed old unused library files - Updated batch files for building HDF5 ILMBase and Alembic libraries to use new AlembicDeploy path - HDF5 is now build as a Dynamic library (which also enableds multi-threading) - Added DLLs for HDF5 to build.cs file CL 3838053 "Adding missing hdf5 dynamic libraries Change 3848245 by Ben.Marsh Downgrade warning about not using XGE shader compilation to a log message. Build machines do not have XGE. #jira UE-54237 Change 3847300 by Phillip.Kavan Fix shadowed local variable. #jira UE-54141 Change 3846922 by Max.Preussner ImgMedia: Fixed image media player never finished initialization if loading failed Copied from Dev-Sequencer CL# 3846902 #jira UE-54247 Change 3846831 by Arciel.Rekman Linux: only use lld for x86_64 (UE-54144). - lld support for other architectures seems to not ready for prime time. #jira UE-54144 Change 3846771 by Lauren.Ridge Material window now uses the background color set in preview scene. #jira UE-52215 Change 3846705 by Ben.Marsh Fix batch file paths not being quoted correctly when run through XGE. #jira Change 3846550 by Lauren.Ridge Toggling Show Background now updates the background as well #jira UE-52250 Change 3846417 by Matt.Kuhlenschmidt Fix crash resizing shootergame window #jira UE-53137 Change 3846295 by Rolando.Caloca UE4.19 - New Vulkan descriptor pooling mechanism (enabled on non-android) #jira UE-50449 Change 3846273 by tim.gautier QAGame: Updating Material Layer test assets to include more Params - Added temp assets, quicker repros for bugs #jira UE-54176, UE-54165 Change 3846255 by Lauren.Ridge Parameter tab is the primary tab for material instances #jira UE-54092 Change 3846086 by Chris.Babcock Add missing SecureHash.h include #jira UE-54026 #PR #4417 #ue4 #android Change 3846049 by Martin.Wilson Fix Set Root Motion Enabled Anim Data Modifier node (previously didn't set the enabled flag) #jira UE-54220 Change 3846033 by Martin.Wilson Fix root motion being repeatedly applied ( Clear() call only clears bHasRootMotion flag, not the transform itself ) #Jira UE-54219 Change 3845991 by andrew.porter QAGame: Updating bindings on activechannels sequencer test content #jira UE-29618 Change 3845933 by Lauren.Ridge Check for original material being valid #jira UE-54166 Change 3845920 by Martin.Wilson Optimized redundant key removal #jira UE-51303 Change 3845812 by Matt.Kuhlenschmidt Fix not being able to change BSP brush shape #jira UE-53738 Change 3845790 by Martin.Wilson Fix for assert failure when accumulating root motion in debug. #jira UE-53955 Change 3845730 by JeanLuc.Corenthin Fix build breakage warning: resaved disc.uasset with 4.19.0 preview #1 failure: set the correct default mesh for AreaLightStruct.uasset #jira none Change 3845693 by Lina.Halper Fix issue with previewing pose asset with curve data #jira: UE-53967 Change 3845533 by Andrew.Rodham Sequencer: Fixed sub sequences potentially being loaded during AddReferencedObjects #jira UE-54173 Change 3845472 by Thomas.Sarkanen Prevented debug object selection dropdown from displaying objects with pending kill outers #jira UE-54045 - Animation Blueprint Editor Crashes on Compile if the Debug Instance Selection is Other Than No Object or Preview Instance Change 3845401 by Yannick.Lange Reverting thumbnail capture from viewport. #jira UE-53775 #jira UE-53701 Change 3844693 by JeanMichel.Dignard Changed IES texture brightness to be the max candela value and set the texture multiplier to be 1. This fixes the IES lights intensity being too high. #jira UEENT-632 Change 3844689 by JeanLuc.Corenthin Update Datasmith content assets to latest Copying fix from Dev-Enterprise by Jean-Luc Corenthin CL 3809803 Updated assets with correct release version Cleanup some paths on static meshes and texture #jira UEENT-759 #jira UEENT-657 Change 3844571 by Martin.Wilson Fix motion controller motion source pin still showing when pin is connected to something #Jira UE-53236 Change 3844564 by Martin.Wilson Due to previously fixed bug some anim blueprint nodes could have duplicated guids, this fixes them #Jira UE-54174 Change 3844545 by Jamie.Dale No longer attempt to parse group separators for numeric inputs This avoids some ambiguity when parsing numbers for languages such as German #jira UE-54170 Change 3844221 by Nick.Shin HTML5 - filter out "windows/super" keys - these are not used in UE4 - but, keycode are not the expected "91 or 92" values, SDL keys are "227 & 231" instead... #jira UE-54056 HTML5 crashes inside browser upon pressing windows key Change 3843937 by JeanMichel.Dignard Fixed a crash when right clicking on a static mesh for which its AssetImportData class is currently unavailable (ie: in an unloaded plugin). #jira UEENT-764 Change 3843929 by Peter.Sauerbrei pull over fix for bad directory when copying launch images #jira UE-53177 Change 3843658 by Thomas.Sarkanen Text is red again in anim viewports #jira UE-53224 - Colouring removed from "Animation is being edited" warning messages Change 3843657 by Thomas.Sarkanen Enable picking via Enter for details panel asset pickers The previous (4.18) behavior was to only allow selection of the previous/next item in the list with arrow keys. A fix (CL 3783114) for pickers with many assets broke this. This change now allows for selection of any item by navigating with arrow keys and pressing Enter, as suggested in the Jira. #jira UE-53440 - Unable to select assets within modal Asset Selection dropdowns after navigating with keyboard entry Change 3843120 by Dan.Oconnor Avoid fixing component template games outside the editor, this logic does not work for games that have been nativized #jira UE-54009 Change 3842841 by Ben.Zeigler #jira UE-50020 Switch visual studio module back to using absolute paths so go to definition works, broken in CL #3796157 Change 3842582 by Lauren.Ridge Guards against the widget passed to scrollwidgetintoview being null #jira UE-54037 Change 3842575 by Max.Chen Sequence Recorder: Stop recording if the preview window is destroyed. #jira UE-49778 Change 3842551 by Michael.Dupuis #jira UE-35097: Minor bug fix, documentation, etc. to the landscape optim that was done in the phase 2 that have 0 risk. Change 3842371 by Max.Preussner Media: Merged 4.19 fixes from Dev-Sequencer CL 3807293 WmfMedia: Fixed YUY2 video format strides CL 3827988 MediaPlayerAssets: Fixed Media Texture is not linked to Media Player when created together CL 3805414 MediaAssets: Setting valid GUID when initializing media texture resource CL 3804183 MediaAssets: Added missing lock in media sound component CL 3831580 MfMedia: Media open events generated in same order as on other platforms CL 3807193 WmfMedia: Fixed incorrect buffer stride for RGB32 video tracks #jira UE-53532 #jira UE-53328 Change 3842356 by Max.Preussner ImgMedia: Fixed ensure when cooking project that uses ImgMediaSource #jira UE-51631 Change 3842335 by Aaron.McLeran #jira UE-54087 PR #4419: Fixes a crash due to nullptr dereference (Contributed by mgorzel) Change 3842286 by Rolando.Caloca UE4.19 - Fix for static analysis - Glslang 1.0.65.1 #jira UE-54128 Change 3842222 by andrew.porter QAGame: Updating framerate of EXR_Sequence #jira UE-29618 Change 3842211 by Ben.Marsh Fix determination of Windows version string. The manifest for UE4 applications declares compatibility with Windows 10 nowadays, so we get accurate version numbers returned from GetOSVersionInfo(). #jira UE-54035 Change 3842163 by Cosmin.Sulea UE-53303 - We do not check for remote connection before attempting remote shader compile, causing crashes when misconfigured #jira UE-53303 Change 3841770 by Max.Chen Sequencer: Fix to allow keying of an arbitrarily deep property path. #jira UE-54095 Change 3841758 by Max.Chen Sequencer: Fix unbound possessable components when pasting spawnables. #jira UE-54104 Change 3841415 by Lauren.Ridge Renaming a material layer or material layer blend will no longer cause the asset to appear removed from the stack #jira UE-53942 Change 3841327 by Arciel.Rekman Linux: fix Debug build (UE-53855) - A workaround. UBT should be using proper PCH files instead. #jira UE-53855 Change 3840975 by Rolando.Caloca UE4.19 - Updated VulkanRHI - Fixes for GPU frame time - Fixes for CPU performance #jira UE-50449 Change 3840838 by Michael.Dupuis #jira UE-53944: Make sure the LOD generated is in the valid range to prevent the crash Change 3840693 by Ben.Zeigler #jira UE-53923 Fix regression in 4.19 where PrintScriptCallstack is not always safe to call from the immediate window. I narrowed down the issue to some confusing optimized code so I turned off optimization Copy of CL #3840692 Change 3840680 by Aaron.McLeran Bringing fixes from Dev-AnimPhys to 4.19. #jira UE-53903 crash on load with oculus audio and old audio engine #jira UE-52786, UE-53910 Fix for broken spatialization on xaudio2, old audio engine. Change 3840663 by Rolando.Caloca UE4.19 - Fix for layout ensure on HMD projects on Vulkan #jira UE-50265 Change 3840577 by Rolando.Caloca UE4.19 - Fix for CPUs with more than 16 cores #jira UE-53434 Change 3840551 by andrew.porter QAGame: Setting Allow Bindings from Asset to false #jira UE-29618 Change 3840491 by Ben.Zeigler #jira UE-31662 Fix regression with renaming parent inherited function. It was not correctly searching the parent's skeleton class during the child's recompile so it was erroneously detecting the parent function as missing Copy of CL #3840489 Change 3840297 by Max.Chen Sequencer: Fix copy/paste crash for lights #jira UE-54084 Change 3840284 by Michael.Dupuis #jira UE-53053: Was having a mismatch between the remove reorder and the actual remove Change 3840215 by Sorin.Gradinaru Unshelved from pending changelist '3812852': UE-53550 Level doesn't render on Lenovo 939 UE-53592 Assertion right after rendering scene on Lenovo S939 #jira UE-53550 #jira UE-53592 #4.19 #Android UE-53550 Removed force disabling texture2DLodEXT and textureCubeLodEXT on Mali-400 devices The problem was that the shader compiler complains about code lines before the #extension directives. Placeholder // end extensions in the original shader code - to be replaced with round() functions UE-53592 Always use a new task for devices that have GIsThreadedRendering=false, even when the call is from the rendering thread Change 3840048 by Michael.Dupuis #jira UE-52975: Was always performing the equivalent of an Add, so now we use the Transform during the duplicate Change 3840005 by Richard.Wallis Clone of CL 3835252 Fix for shader library not working with iterative cooking, also fixes native Metal library not working with iterative cook. This works by saving a "backup" of the shader library file - this is reloaded only during iterative cook and adds back in shaders that are missing from the current cook. Fix for extracting/searching .metal files in different directories so debug tgz archiving wasn't working correctly and also support iterative cook. Includes first pass code review suggestions by Mark Sat and Dmitriy Dyomin. #jira UE-53815 Change 3839968 by Michael.Dupuis #jira UE-52289: When OnRegister is called on the component make sure our PerInstanceRenderData is up to date Prevent a possible crash if ClearInstanceSelection was called on a component with no PerInstanceRenderData existing ##codereview jack.porter Change 3839924 by Richard.Wallis Clone of CL 3838093 Fix for rewind / seek bugs in AvfMediaPlayer. - Don't initialise and send audio buffers that have a duration of Zero from the audio tap. This chokes the audio sink and adds overhead we don't need. - Don't faff around with current play rates during loop operation - normal seek doesn't do this so loop seek shouldn't either. - SetRate() should not required to be passed to media tracks - should be enough to do this on audio track select only. #jira UE-54019, UE-53027 Change 3839321 by andrew.porter QAGame: Adding missing bookmark to QA-Sequencer_Blending #jira UE-29618 Change 3839286 by Marcus.Wassmer Duplicate CL: 3823296 #jira UE-52784 Change 3839229 by Brandon.Schaefer Fix audio clean up crash when exiting PIE #jira UE-54050 #review-3839109 @Arciel.Rekman, @Aaron.McLeran Change 3839223 by andrew.porter QAGame: Rebinding pointlight actor to sequences #jira UE-29618 Change 3839098 by andrew.porter QAGame: Fixing missing sequencer blending test content #jira UE-29618 Change 3838919 by Mike.Erwin glTF: binary format's BIN chunk is not necessarily right after the JSON chunk. Discussed this with glTF spec authors. See https://github.com/KhronosGroup/glTF/issues/1177 Rearranged how we read "chunks" from the file since they are not fixed in number or order, besides JSON always being first. #jira UE-50695 Change 3838909 by Mike.Erwin glTF: base64 decoding of data buffers and images Data can be encoded inside the glTF JSON as a Base64 data URI. This CL addresses a known limitation of initial commit CL 3793018. I added this after because base64 is expected to be uncommon in the wild. Authoring software will typically use external BIN files (.gltf) or a BIN chunk (.glb) to store data. #jira UE-50695 Change 3838812 by Uriel.Doyon Integrated CL 3838576, 3838581 and 3831760 from DevRendering, fixing issues with texture streaming. #jira none Change 3838773 by Lauren.Ridge Fixing material layer filters #jira UE-54064 Change 3838748 by Michael.Trepka Fixed EngineTest runtime warning caused by CL 3838626 #jira UE-53893 Change 3838730 by Max.Chen Sequencer: Add notification when the blend type is changed. #jira UE-54046 Change 3838626 by Michael.Trepka Changed FMacMenu to store MultiBox and MenuEntryBox as weak pointers instead of shared pointers. This way we avoid a situation where FMacMenu would try to release them on the main Cocoa thread or where we'd try to execute a menu action for menu items that Slate considers released. #jira UE-53893 Change 3838392 by Arciel.Rekman Fix assert on a policy removal (UE-54042). - Applying Gil's safe fix which just sweeps the problem under the rug. #jira UE-54042 Change 3838162 by Arciel.Rekman Linux: fix crash due to lambda lifetime issues (UE-54040). - The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+). #jira UE-54040 (Edigrating 3819174 to Release-4.19) Change 3838156 by Rolando.Caloca UE4.19 - Support for Vulkan devices that have no cached memory type #jira UE-54039 Change 3838096 by Brandon.Schaefer Set sound to unfocused volume multiplier if not focused #jira UE-51327 #review-3835736 arciel.rekman Change 3838087 by Brandon.Schaefer Fix arm server building. A fix from CL 3617084 remove inheriting from IHeadMountedDisplayVulkanExtensions. Remove overrides #jira UE-53901 #review-3838088 arciel.rekman Change 3837072 by Phillip.Kavan Fix for a build failure that could occur with Blueprint nativization enabled and EDL disabled. This was a regression introduced in 4.18. - Mirrored from //UE4/Dev-Framework (3836768). #jira UE-53908 Change 3837071 by Phillip.Kavan Emit proper syntax for set/map fields containing converted assets to generated C++ Blueprint class headers when Blueprint nativization is enabled. - Mirrored from //UE4/Dev-Framework (3835944, 3835965). #jira UE-42614 Change 3837070 by Phillip.Kavan #4202 - Blueprint nativization bug fixes (PR). - Mirrored from //UE4/Dev-Framework (3830562, 3832292). #jira UE-52188 Change 3836507 by Ryan.Vance #jira UE-53992 Due to hijacking the depth target directly from the scene context, we can't support depth compositing if it's being scaled by screen percentage since it wont match our color render target dimensions. Change 3836390 by Dan.Oconnor Fix failure to resolve archetype when using the compilation manager #jira UE-53840 Change 3836251 by Ryan.Vance #jira UE-53992 Change 3835852 by Mark.Satterthwaite Fix tessellation shaders in Metal with Manual Vertex Fetch enabled: - The control points idnex buffer shouldn't collide with anything else. - We can't use the optimisation of loading texture width & height from the buffer meta-table in tessellation shaders as the combined stages don't guarantee not to clobber unused buffer slots and screw it up when we use linear textures. #jira UE-53851 Change 3835802 by JeanMichel.Dignard UBT changes for Enterprise deployment - Allow building enterprise against an installed engine version - Added enterprise to the cleanup process if its not installed #jira UEENT-748 Change 3835625 by Bogdan.Vasilache UE-50257 --> (Skeletal meshes silently fail to render if they have more than 75 bones) --> changed logged error with a warning #jira UE-50257 Change 3833649 by Mike.Beach Enabling debug layer when multiview is enabled. #jira UE-49954 Change 3833525 by Ethan.Geller Fix copyright in ActiveSound.cpp #jira none #rb none Change 3642649 by Stewart.Lynch Renamed loctext key to stop it clashing with an existing entry #jira UE-49432 Change 3644762 by Stewart.Lynch LLM update: Added Total, Untracked and FMalloc Unused to LLMFULL stat page. Fixed occasionally missing allocs/frees. Removed platform csv. * removed CheckSize arg from OnLowLevelFree * show a warning in LLM Map when replacing existing value. This means that there has been an alloc/free mismatch. * minor optimization in LLMMap::GetMaxIndex - cache Mask value * added Total and Untracked stats to LLMFULL. LLMFULL now tracks almost all of the memory that LLMPlatform does, so there is no real need to use LLMPlatform. Removed the LLMPlatform csv. * added FMalloc Unused stat to LLMFULL to account for memory Binned2 has allocated internally. This can be used to track Binned2 fragmentation over time. * renamed Binned stats to FMemory to make it more general * added Default tracking to CustomVirtualAlloc and disable it where necessary. This catches the few VirtualAlloc calls that were missed. * added AllocType arg to all allocation tracking. This was needed in order to track the FMalloc total, and also to fix the pausing * fixed a bug in pausing where alloc/frees were being missed. Now only pauses a specific allocation type. * Trackers now maintain totals for each enum tag * tracking of Texture and mesh allocation on Windows D3D11 & D3D12 Change 3651334 by Joe.Barnes Fix misspelled function name. #jira 39441 #3016 Change 3653857 by Ben.Woodhouse Integrate from //UE4/Main/...@3653675 to //UE4/Dev-Console/... Change 3656553 by Joe.Barnes Add path for SCS_DeviceDepth. Change 3662703 by Ben.Woodhouse Merging CL 3659069 from //Fortnite/Main/... to to //ue4/dev-console/...: [FORTNITE] [CONSOLE] [+] Improved frame syncing mechanism - Improves input latency by allowing the game thread to sync to the swap chain flip of the previous frame. - Added "r.GTSyncType" CVar to control how the game thread syncs with the rest of the pipe. - r.GTSyncType 2 will sync the game thread with the flip of the swap chain, preventing the pipe from getting too long and causing excess input latency. Platforms are required to implement RHIWaitForFlip and RHISignalFlipEvent, and call RHIInitializeFlipTracking on RHI startup. A separate thread monitors the progress of frame flips and signals task graph events as they pass their corresponding frame index. In r.GTSyncType 2 mode, the game thread is signaled by this flip tracking thread. [~] Unified platform specific sync interval CVars into one: rhi.SyncInterval - 1 == 60Hz - 2 == 30Hz - 3 == 20Hz Change 3675239 by Keith.Judge Fixed thread priorities for Windows so that BelowNormal and SlightlyBelowNormal are the same. Bumped Lowest down a notch so they all fit. #jira UE-50626 Change 3676709 by Ben.Woodhouse Integrate from //UE4/Main/...@3675008 to //UE4/Dev-Console/... Change 3689712 by Ben.Woodhouse Integrate from //UE4/Main/...@3687781 to //UE4/Dev-Console/... Change 3701778 by Ben.Woodhouse Integrate from //UE4/Main/...@3699491 to //UE4/Dev-Console/... Change 3677043 by Ben.Woodhouse From StewartL: I also found that on Windows Fortnite is overflowing int32 values due to the number of allocations. I changed LLMArray and LLMMap to use uint32 and it seems to be Ok now. I didn't want to check this in at the last minute, so here's the shelf: 3645336 Change 3726532 by Luke.Thatcher [CONSOLE] [~] Enable XGE shader compilation by default. - Also set XGE mode to "force interception". With XGE on by default, we don't want people with an old Incredibuild version using the old system inadvertently. Change 3726554 by Luke.Thatcher [CONSOLE] [+] Improved Scoped Named Events - Added SCOPED_NAMED_EVENT(_FSTRING/_TEXT/_F) macros to allow use of string literals, FString and printf in scoped named event strings. - Replaced explicit use of FPlatformMisc::Begin/EndNamedEvent throughout the engine with macros, so the events can be compiled out. - Fixed performance issues on various platforms with named events. SCOPED_NAMED_EVENT macros were not considering whether the platform uses wide or ansi char strings. Change 3751378 by Ben.Woodhouse Integrate from //UE4/Main/...@3748735 to //UE4/Dev-Console/... Change 3751812 by Ben.Woodhouse Integrate from //UE4/Main/...@3750870 to //UE4/Dev-Console/... Change 3728571 by Luke.Thatcher [CONSOLE] [!] Drop another XGE controller warning to log. Change 3747150 by Joe.Barnes Add AuthoringToolHelper.bat file to installed build copy list. Change 3768585 by Ben.Woodhouse Integrate from //UE4/Main/...@3767531 to //UE4/Dev-Console/... Change 3772333 by Ben.Woodhouse Integrate from //UE4/Main/...@3771573 to //UE4/Dev-Console/... Change 3786872 by Ben.Woodhouse Integrate from //UE4/Main/...@3786785 to //UE4/Dev-Console/... Change 3787279 by Luke.Thatcher [CONSOLE] [~] Unified present threshold CVars. - CVars are now in RHIUtilities.cpp, and are renamed to rhi.PresentThreshold.Top and rhi.PresentThreshold.Bottom. - Platform implementations will be checked in shortly. Change 3787445 by Luke.Thatcher [CONSOLE] [^] Merging (as edit) improvements to low-latency frame syncing from //Fortnite/Main to //UE4/Dev-Console Original CLs - 3708949 - Added rhi.SyncSlackMS cvar to allow an offset of the game thread sync time by a number of milliseconds. - 3712693 - Fix for crash on startup in new frame syncing. - 3735765 - Fix r.GTSyncType logic when vsync is disabled (falls back to old behaviour when vsync is off). Change 3788417 by Ben.Woodhouse Duplicate from FN CL 3712515 CSV profiler GPU and pre-declared stat support - refactor the GPU profiler so it's no longer dependent on the stats system and can work in Test builds - add support for pre-declared CSV stats, using FNames (these are required for GPU stats) - add DECLARE_GPU_STAT macro which handles STATS and CsvProfiler declarations Note: still a few issues to resolve with GPU stats: these randomly go to 0 at times during a replay on XB1, the GPU total is lower than the stat unit number, and the unaccounted stat is too large due to missing stats Change 3807818 by Ben.Woodhouse Integrate from //UE4/Main/...@3803271 to //UE4/Dev-Console/... Change 3818577 by Ben.Woodhouse Integrate from //UE4/Main/...@3812936 to //UE4/Dev-Console/... Change 3821198 by Ben.Woodhouse Integrate from //UE4/Release-4.19/...@3820127 to //UE4/Dev-Console/... Change 3821519 by Ben.Woodhouse Integrate from //UE4/Release-4.19/...@3820753 to //UE4/Dev-Console/... #robomerge none Change 3813513 by Ben.Woodhouse CSV profiler refactor+ bug fix - Move the CSV profiler to core, so we can use it in modules other than engine - Profiler no longer enqueues RT commands - this is handled by a new core delegate type - Make begin/end requests more robust, enqueued via a command queue and processed in order - Defer end capture requests by a frame. This ensures stats on threads other than the gamethread (e.g. renderthread etc) are complete, so the last frame is not truncated - Fix long-standing bug with multiple captures where old/stale frames would appear in the first <128 frames of captures - Move unit stats and dynamic resolution out of the profiler itself and into the engine. Only frametime is recorded in the profiler now - Fix longstanding bug in first frame renderthread time in the engine Change 3814039 by Ben.Woodhouse More Csvprofiler improvements - Event support (via CSV_EVENT macros). These appear in the "EVENTS" column of the CSV and can be used to add context to the stat data - Reduced memory overhead for timestamps through bit-packing (now 16 bytes per marker instead of 24), and splitting stats into different types Change 3814041 by Ben.Woodhouse Integrate as edit CL 3796390 from Fortnite/Main: Fix CsvProfiler not compiling in shipping for now Change 3814229 by Ben.Woodhouse Integrate + refactor of CL 3792591 to reduce complexity and fix bugs Original changelist description: CSV profiler improvements: - The CSV profiler is now always compiled in on the server - The CSV profiler can now handle both int32 and float stats - In BeginCapture, the function can take additional arguments for some customization of filenames Fixes to the above: - Remove FCustomValue class - Fixes bug where all timestamp values from CSV_SCOPED_STATs were garbage (due to issues resulting from FCustomValue type ambiguity when adding values together) - FCsvCustomStat now just uses simple union + bitfield flag to reduce size and complexity (4 bytes instead of 8 per value) - FCsvColumn class modified to use doubles, which can represent both ints and floats without loss of precision - this class is not memory or time critical - Replace multiple overrides used by the server for filenameprefix/folder/postfix etc with a single FilenameOverride Change 3814242 by Ben.Woodhouse Disable CSV unit stats on the dedicated server Change 3817339 by Ben.Woodhouse Duplicate from 3816641: CSV profiler improvements - Added a low-pri processing thread to compress raw timing data into a much more efficient format - Reduces memory usage for 15 minute 30k frame capture with GPU stats enabled from 110MB to 3.4MB - Processing time : 0.1ms per frame - Improved name handling for char literal stats. We now use the string as the ID rather than the pointer so multiple stat uses of the same name string apply only to a single stat - Reworked thread data access to eliminate locking for anything time-critical. Frame boundaries now handled via a lock-free helper class - Fixed bug with queue implementation where 1 in 128 reads would duplicate the last block of stat data - Reduced #include dependencies for CSVProfiler.h - Removed AccumulateMax because it doesn't work, and implementing properly would add a lot of complexity - Added a simple test harness Change 3817582 by Ben.Woodhouse Fix android compile warning Change 3823242 by Ben.Woodhouse Integrate as edit from Fortnite/Main 3820067: Fix threading issue with D3D12 pipeline state caches for windows. This was caused by the usage of FRwScopeLock::RaiseLockToWrite. A pointer read before RaiseLockToWrite was called was invalidated because RaiseLockToWrite has to release the read lock before acquiring the write lock. Rename FRwScopeLock::RaiseLockToWrite to ReleaseReadOnlyLockAndAcquireWriteLock_USE_WITH_CAUTION to make it more explicit what's happening. As the comment says: // This function should be used with caution. // It releases the read lock _before_ acquiring a new write lock. This is not an atomic operation and the caller should // not treat it as such. // E.g. Pointers read from protected data structures prior to this call may be invalid after the function is called. Change 3823840 by Ben.Woodhouse Edigrate from 3823816 Fix an issue where the csvprofile console commands would sometimes result in an empty CSV. The root cause was GFrameNumber incrementing between the console command being read and FCSVProfiler::EndFrame(). We now use our own frame counter which is updated in EndFrame, so this can't happen Also fix an issue where calling csvprofile stop twice would cause all further commands to be ignored. Change 3827787 by Ben.Woodhouse Integrate-as-edit CL 3820678 from Fortnite/Main Allow the CSV Profiler to be compiled in to shipping dedicated server builds Change 3827842 by Ben.Woodhouse Integrate-as-edit CL 3827079 from Fortnite/Main CSV profiler category support Change 3827918 by Luke.Thatcher [CONSOLE] [!] Fix compile error in CSV custom stats. Change 3827964 by Luke.Thatcher [CONSOLE] [!] Fix inverted logic and spelling of boolean. - Functionally, the boolean did the correct thing, but the logic was backwards inside the build tool. Change 3831661 by Ben.Woodhouse Integrate-as-edit CL 3830630 from Fortnite/Main Fix CSVProfiler assert in dev builds on XB1 Change 3860300 by Joe.Barnes Use same method for src and dest rect calculation as other post processing passes so rects match between passes. Prevents read of unprocessed pixels. Change 3860347 by Joe.Barnes Delete existing SourceConfigFile before allocating a new one to prevent them leaking. Change 3860348 by Joe.Barnes Completely encapsulate GetLLMAlloc() in #ifdef. Change 3861772 by Ben.Woodhouse Integrate-as-edit CL 3861688 from Fortnite/Main: Forward lighting GPU crash fixes Change 3861774 by Ben.Woodhouse Integrate as edit CL 3833918 from dev-rendering (courtesy of DanielW): D3D12 RHI: only refcount uniform buffers if GRHINeedsExtraDeletionLatency is false, which is no longer the case for PC. The refcounting was heavy on performance as reported by a licensee because FRHIResource uses atomics for refcounting, which is only necessary when GRHINeedsExtraDeletionLatency is disabled. Change 3862214 by Ben.Woodhouse Integrate-as-edit CL 3859637 from Fortnite/Main Dynamic resolution console tweaks - Dynamic resolution high level switch driven by a cvar instead of code - Disable user settings dynamic resolution handling on non-desktop platforms. DynamicRes as a user setting does not make sense on consoles/mobile - we'll drive it from device profiles/scalability - Modify naming of GPUHeadRoom to make it clear that it's a percentage, not millseconds Change 3863919 by Ben.Woodhouse [Copy] Integrate console dynamic resolution interface changes from CL 3863354, 3862754, 3862639 Change 3864347 by Ben.Woodhouse Fix the editor build. This will need a proper fix before 4.19 ships. #lockdown Nick.Penwarden #rb none [CL 3913399 by Ben Marsh in Main branch]
2018-02-27 17:30:35 -05:00
if (NumKeyPinsWithLinks == 1 && (OutputPin->PinType.PinCategory == UEdGraphSchema_K2::PC_Wildcard && Pin->LinkedTo[0]->PinType.PinCategory != UEdGraphSchema_K2::PC_Wildcard))
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
{
FEdGraphTerminalType TerminalType = MoveTemp(OutputPin->PinType.PinValueType);
OutputPin->PinType = Pin->LinkedTo[0]->PinType;
OutputPin->PinType.PinValueType = MoveTemp(TerminalType);
OutputPin->PinType.ContainerType = ContainerType;
bNotifyGraphChanged = true;
}
}
}
}
else if (OutputPin->LinkedTo.Num() == 0)
{
// Return to wildcard if theres nothing in any of the input pins
TFunction<bool(TArray<UEdGraphPin*>&)> PinsInUse = [this, &PinsInUse](TArray<UEdGraphPin*>& PinsToConsider)
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
{
bool bPinInUse = false;
for (UEdGraphPin* CurrentPin : PinsToConsider)
{
// Is there something in this pin?
if (CurrentPin->SubPins.Num() > 0 || !CurrentPin->DoesDefaultValueMatchAutogenerated())
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
{
bPinInUse = true;
break;
}
}
return bPinInUse;
};
const bool bResetOutputPinPrimary = ((NumKeyPinsWithLinks == 0) && !PinsInUse(KeyPins));
const bool bResetOutputPinSecondary = ((NumValuePinsWithLinks == 0) && !PinsInUse(ValuePins));
if (bResetOutputPinPrimary)
{
OutputPin->PinType.PinCategory = UEdGraphSchema_K2::PC_Wildcard;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3716594) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3623720 by Phillip.Kavan #jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build. Change summary: - Temporarily excluded all AnimBP assets from nativization as a workaround. Change 3626305 by Phillip.Kavan #jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default. Change 3629145 by Marc.Audy Don't hide developer nativization tool behind ini Change 3630849 by Marc.Audy Fix nativization uncompilable code when using a non-referenceable term in a switch statement. #jira UE-44085 Change 3631037 by Marc.Audy (4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it #jira UE-49440 Change 3631206 by Marc.Audy Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT("")) Change 3631232 by Marc.Audy Remove outdated diagnostic code throwing false positives #jira UE-47986 Change 3631573 by Marc.Audy Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's' Change 3633168 by Lukasz.Furman fixed behavior tree changing its state during latent abort, modified order of operations during abort to: abort & wait -> change aux nodes -> execute Change 3633609 by Marc.Audy Don't get unneeded string Change 3633691 by Marc.Audy Fix copy-pasting of a collapsed graph containing a map input losing the value type #jira UE-49517 Change 3633967 by Ben.Zeigler Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript Fixed a few other fields to be private that were accidentally made public in 4.17 Change 3633984 by Michael.Noland Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links Change 3634464 by Ben.Zeigler Header cleanups for Pawn, Controller, Character, and PlayerController Change 3636858 by Marc.Audy In preview worlds don't display the light error sprite #jira UE-49555 Change 3636903 by Marc.Audy Fix numerous issues with copy/pasting editable pin bases #jira UE-49532 Change 3638898 by Marc.Audy Allow right-click creation of local variables in blueprint function libraries #jira UE-49590 Change 3639086 by Marc.Audy PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin) #jira UE-49591 Change 3639445 by Marc.Audy Fix mistaken override and virtual markup on niagara schema function. Change 3641202 by Marc.Audy (4.17.2) Fix crash undoing pin changes with split pins #jira UE-49634 Change 3643825 by Marc.Audy (4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted #jira UE-49756 Change 3645110 by mason.seay Fixed up QA-ClickHUD map so it's usable and makes more sense Change 3646428 by Dan.Oconnor Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data #jira None Change 3647298 by Marc.Audy PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist) #jira UE-49748 Change 3647815 by Marc.Audy Minor performance improvements Change 3648931 by Lina.Halper #Compiler : fixed so that each type of BP can provide module info, and compiler info - Moved out AnimBlueprint Compiler - Refactored WidgetBlueprint - DUPE - Merging using ControlRig_Dev-Framework Change 3654310 by Marc.Audy Shrink USkinnedMeshComponent 64 bytes Shrink USkeletalMeshComponent 224 bytes (160 bytes internal) Change 3654636 by Lina.Halper Fix crashing on shutdown #jira: UE-50004 Change 3654960 by Lina.Halper - Fix with automation test of creation/duplication - Fixed shut down crash with editor again due to uobject GCed #jira: UE-50028 Change 3655023 by Ben.Zeigler #jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag Change 3655426 by Ben.Zeigler #jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them Change 3657627 by Ben.Zeigler #jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction Change 3662086 by Mieszko.Zielinski Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4 This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList #jira UE-50101 Change 3662294 by Ben.Zeigler Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check Change 3662825 by Mieszko.Zielinski Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4 there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no Change 3664424 by Marc.Audy UE-50076 test assets #rb none #rnx Change 3664441 by Mieszko.Zielinski PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist) Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated. Change 3664506 by Phillip.Kavan #jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets. Change summary: - UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization. - UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths. - UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished. - UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option). - UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed. - UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead. - UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead. - UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file. - UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file. - UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first). - UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness. - UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed. - UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc. - UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file. - UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string. - UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>. - UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin. - UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed). - UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed). - UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it. - UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished. - UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed. - UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context. - UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail. - UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT). - UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders. Notes: - After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release). - Advanced users and build engineers can override this value per task. Instructions to do that are as follows: - For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line. - When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly. - We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT. - We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above). Change 3665061 by Phillip.Kavan Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum. Mirrored from //UE4/Release-4.18 (CL# 3664993). #3969 #jira UE-49233 Change 3665108 by Marc.Audy (4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted + additional code cleanup #jira UE-50076 Change 3665114 by Marc.Audy Minor change that could potentially improve performance in some cases Change 3665410 by Mieszko.Zielinski Fixed naming of Vislog's BP API #UE4 Change 3665634 by Ben.Zeigler #jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk Change 3666970 by Phillip.Kavan Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8. #jira UE-46814 Change 3667058 by Phillip.Kavan Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage. Mirrored from //UE4/Release-4.18 (CL# 3667043). #jira UE-50403 Change 3667150 by Mieszko.Zielinski PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM) Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend. #jira UE-50249 Change 3667152 by Mieszko.Zielinski PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM) #jira UE-50298 Change 3667166 by Mieszko.Zielinski Fixed FRichCurve baking so that it doesn't loose its curvature #UE4 Also, added some baking sanity checking (like if the range is larger than a single point). Change 3668025 by Dan.Oconnor Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed #jira UE-50453 Change 3672063 by Ben.Zeigler #jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case Change 3672306 by Ben.Zeigler #jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it Change 3672683 by Marc.Audy Code cleanup Change 3672749 by Ben.Zeigler Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build Change 3672831 by Ben.Zeigler #jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId. Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project Change 3673551 by Ben.Zeigler #jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load Change 3675074 by mason.seay Test map for VisLog Testing Change 3675084 by Mieszko.Zielinski Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4 #jira UE-43430 Change 3676490 by Ben.Zeigler #jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset Change 3676579 by Lukasz.Furman fixed crash in behavior tree's search rollback Change 3676586 by Lukasz.Furman added local scope mode to behavior tree's composite nodes Change 3676587 by Ben.Zeigler Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case Add browse, use selected, and clear buttons, and make ID selector font the normal property font Change 3676715 by Lukasz.Furman changed order of behavior tree's aux node ticking Change 3676867 by Ben.Zeigler #jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early Change 3677892 by Ben.Zeigler Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites Change 3678247 by Marc.Audy Fix static analysis warning Change 3678357 by Ben.Zeigler #jira UE-50696 Add some container variables to diff test to track down crashes Change 3678385 by Ben.Zeigler #jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match Change 3678600 by Ben.Zeigler #jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference Change 3679075 by Dan.Oconnor Mirror 3679030 from Release-4.18 Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on #jira UE-48692 Change 3679087 by Dan.Oconnor Filter out unnecessary relink jobs from the compilation manager #jira None Change 3680221 by Ben.Zeigler #jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary Change 3680561 by Lukasz.Furman fixed unsafe StopTree calls in behavior tree #jira nope Change 3680788 by Ben.Zeigler Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind Change 3683001 by mason.seay Submitting various test maps and assets Change 3686837 by Mieszko.Zielinski Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion #jira UE-50857 Change 3688451 by Marc.Audy Fix up new material expression to work with String -> Name refactor Change 3689097 by Mason.Seay Test content for nativization and enum testing Change 3689106 by Mieszko.Zielinski Made NavMeshBoundsVolume react to undo in the editor #Orion #jira UE-51013 Change 3689347 by Mieszko.Zielinski Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4 Manual merge of CL#3689316 over from 4.18 #jira UE-51019 Change 3692524 by mason.seay Moved some assets to folder for org, fixed up redirectors Change 3692540 by mason.seay Renaming test maps so they are clearly indicated for testing nativization Change 3692577 by mason.seay Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed Change 3692724 by mason.seay Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps Change 3693184 by mason.seay Assets for testing nativization with structs Change 3693367 by mason.seay Improvements to test content Change 3695395 by Dan.Oconnor Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced #jira None Change 3695484 by Marc.Audy Fix sound cue connection drawing policy not getting returned. #jira UE-51032 Change 3695494 by mason.seay More test content for nativization testing Change 3697829 by Mieszko.Zielinski PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei) Change 3700541 by mason.seay Test map for containers with function bug Change 3703459 by Marc.Audy Remove poorly named InverseLerp Fix degenerate behavior returning bad value #jira UE-50295 Change 3703803 by Marc.Audy Clean up autos Minor improvement to ShouldGenerateCluster Change 3704496 by Mason.Seay More test content for testing nativization Change 3706314 by Marc.Audy PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar) #jira UE-50874 Change 3707502 by Mason.Seay Final changes to nativization test content (hopefully) Change 3709478 by Marc.Audy PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel) Same as CL# 3689702 implemented in Fortnite #jira UE-51453 Change 3709967 by Marc.Audy PR #4139: fixed a typo in a comment (Contributed by derekvanvliet) #jira UE-51372 Change 3709970 by Marc.Audy PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman) #jira UE-51495 Change 3709971 by Marc.Audy PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas) #jira UE-51492 Change 3710041 by Marc.Audy Minor code cleanup Change 3711223 by Phillip.Kavan Move some Blueprint nativization log spam into the verbose category. #jira UE-49770 Change 3713398 by Marc.Audy PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM) #jira UE-51517 Change 3713601 by Marc.Audy Fix merge error Change 3713994 by Marc.Audy (4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event. #jira UE-50738 Change 3714270 by Marc.Audy Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors #jira UE-51534 Change 3714406 by Marc.Audy Fix dumb inverted boolean check Change 3716594 by Dan.Oconnor Integrate 3681301 from 4.18 Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior #jira UE-50780, UE-51568 Change 3686450 by Marc.Audy PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString. CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither. CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters. Material Expressions now store input and output names as FName instead of FString FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString Most existing pin related functions using string have been deprecated. Change 3713796 by Marc.Audy Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not. IsTickable no longer a pure virtual (defaults to true). Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject. Change 3638554 by Marc.Audy Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected. Change 3676502 by Ben.Zeigler Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635 [CL 3718205 by Marc Audy in Main branch]
2017-10-25 09:30:36 -04:00
OutputPin->PinType.PinSubCategory = NAME_None;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
OutputPin->PinType.PinSubCategoryObject = nullptr;
bNotifyGraphChanged = true;
}
if (bResetOutputPinSecondary && ContainerType == EPinContainerType::Map)
{
OutputPin->PinType.PinValueType.TerminalCategory = UEdGraphSchema_K2::PC_Wildcard;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3716594) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3623720 by Phillip.Kavan #jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build. Change summary: - Temporarily excluded all AnimBP assets from nativization as a workaround. Change 3626305 by Phillip.Kavan #jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default. Change 3629145 by Marc.Audy Don't hide developer nativization tool behind ini Change 3630849 by Marc.Audy Fix nativization uncompilable code when using a non-referenceable term in a switch statement. #jira UE-44085 Change 3631037 by Marc.Audy (4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it #jira UE-49440 Change 3631206 by Marc.Audy Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT("")) Change 3631232 by Marc.Audy Remove outdated diagnostic code throwing false positives #jira UE-47986 Change 3631573 by Marc.Audy Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's' Change 3633168 by Lukasz.Furman fixed behavior tree changing its state during latent abort, modified order of operations during abort to: abort & wait -> change aux nodes -> execute Change 3633609 by Marc.Audy Don't get unneeded string Change 3633691 by Marc.Audy Fix copy-pasting of a collapsed graph containing a map input losing the value type #jira UE-49517 Change 3633967 by Ben.Zeigler Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript Fixed a few other fields to be private that were accidentally made public in 4.17 Change 3633984 by Michael.Noland Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links Change 3634464 by Ben.Zeigler Header cleanups for Pawn, Controller, Character, and PlayerController Change 3636858 by Marc.Audy In preview worlds don't display the light error sprite #jira UE-49555 Change 3636903 by Marc.Audy Fix numerous issues with copy/pasting editable pin bases #jira UE-49532 Change 3638898 by Marc.Audy Allow right-click creation of local variables in blueprint function libraries #jira UE-49590 Change 3639086 by Marc.Audy PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin) #jira UE-49591 Change 3639445 by Marc.Audy Fix mistaken override and virtual markup on niagara schema function. Change 3641202 by Marc.Audy (4.17.2) Fix crash undoing pin changes with split pins #jira UE-49634 Change 3643825 by Marc.Audy (4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted #jira UE-49756 Change 3645110 by mason.seay Fixed up QA-ClickHUD map so it's usable and makes more sense Change 3646428 by Dan.Oconnor Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data #jira None Change 3647298 by Marc.Audy PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist) #jira UE-49748 Change 3647815 by Marc.Audy Minor performance improvements Change 3648931 by Lina.Halper #Compiler : fixed so that each type of BP can provide module info, and compiler info - Moved out AnimBlueprint Compiler - Refactored WidgetBlueprint - DUPE - Merging using ControlRig_Dev-Framework Change 3654310 by Marc.Audy Shrink USkinnedMeshComponent 64 bytes Shrink USkeletalMeshComponent 224 bytes (160 bytes internal) Change 3654636 by Lina.Halper Fix crashing on shutdown #jira: UE-50004 Change 3654960 by Lina.Halper - Fix with automation test of creation/duplication - Fixed shut down crash with editor again due to uobject GCed #jira: UE-50028 Change 3655023 by Ben.Zeigler #jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag Change 3655426 by Ben.Zeigler #jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them Change 3657627 by Ben.Zeigler #jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction Change 3662086 by Mieszko.Zielinski Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4 This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList #jira UE-50101 Change 3662294 by Ben.Zeigler Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check Change 3662825 by Mieszko.Zielinski Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4 there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no Change 3664424 by Marc.Audy UE-50076 test assets #rb none #rnx Change 3664441 by Mieszko.Zielinski PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist) Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated. Change 3664506 by Phillip.Kavan #jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets. Change summary: - UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization. - UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths. - UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished. - UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option). - UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed. - UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead. - UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead. - UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file. - UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file. - UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first). - UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness. - UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed. - UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc. - UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file. - UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string. - UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>. - UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin. - UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed). - UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed). - UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it. - UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished. - UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed. - UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context. - UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail. - UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT). - UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders. Notes: - After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release). - Advanced users and build engineers can override this value per task. Instructions to do that are as follows: - For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line. - When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly. - We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT. - We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above). Change 3665061 by Phillip.Kavan Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum. Mirrored from //UE4/Release-4.18 (CL# 3664993). #3969 #jira UE-49233 Change 3665108 by Marc.Audy (4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted + additional code cleanup #jira UE-50076 Change 3665114 by Marc.Audy Minor change that could potentially improve performance in some cases Change 3665410 by Mieszko.Zielinski Fixed naming of Vislog's BP API #UE4 Change 3665634 by Ben.Zeigler #jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk Change 3666970 by Phillip.Kavan Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8. #jira UE-46814 Change 3667058 by Phillip.Kavan Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage. Mirrored from //UE4/Release-4.18 (CL# 3667043). #jira UE-50403 Change 3667150 by Mieszko.Zielinski PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM) Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend. #jira UE-50249 Change 3667152 by Mieszko.Zielinski PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM) #jira UE-50298 Change 3667166 by Mieszko.Zielinski Fixed FRichCurve baking so that it doesn't loose its curvature #UE4 Also, added some baking sanity checking (like if the range is larger than a single point). Change 3668025 by Dan.Oconnor Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed #jira UE-50453 Change 3672063 by Ben.Zeigler #jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case Change 3672306 by Ben.Zeigler #jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it Change 3672683 by Marc.Audy Code cleanup Change 3672749 by Ben.Zeigler Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build Change 3672831 by Ben.Zeigler #jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId. Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project Change 3673551 by Ben.Zeigler #jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load Change 3675074 by mason.seay Test map for VisLog Testing Change 3675084 by Mieszko.Zielinski Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4 #jira UE-43430 Change 3676490 by Ben.Zeigler #jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset Change 3676579 by Lukasz.Furman fixed crash in behavior tree's search rollback Change 3676586 by Lukasz.Furman added local scope mode to behavior tree's composite nodes Change 3676587 by Ben.Zeigler Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case Add browse, use selected, and clear buttons, and make ID selector font the normal property font Change 3676715 by Lukasz.Furman changed order of behavior tree's aux node ticking Change 3676867 by Ben.Zeigler #jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early Change 3677892 by Ben.Zeigler Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites Change 3678247 by Marc.Audy Fix static analysis warning Change 3678357 by Ben.Zeigler #jira UE-50696 Add some container variables to diff test to track down crashes Change 3678385 by Ben.Zeigler #jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match Change 3678600 by Ben.Zeigler #jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference Change 3679075 by Dan.Oconnor Mirror 3679030 from Release-4.18 Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on #jira UE-48692 Change 3679087 by Dan.Oconnor Filter out unnecessary relink jobs from the compilation manager #jira None Change 3680221 by Ben.Zeigler #jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary Change 3680561 by Lukasz.Furman fixed unsafe StopTree calls in behavior tree #jira nope Change 3680788 by Ben.Zeigler Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind Change 3683001 by mason.seay Submitting various test maps and assets Change 3686837 by Mieszko.Zielinski Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion #jira UE-50857 Change 3688451 by Marc.Audy Fix up new material expression to work with String -> Name refactor Change 3689097 by Mason.Seay Test content for nativization and enum testing Change 3689106 by Mieszko.Zielinski Made NavMeshBoundsVolume react to undo in the editor #Orion #jira UE-51013 Change 3689347 by Mieszko.Zielinski Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4 Manual merge of CL#3689316 over from 4.18 #jira UE-51019 Change 3692524 by mason.seay Moved some assets to folder for org, fixed up redirectors Change 3692540 by mason.seay Renaming test maps so they are clearly indicated for testing nativization Change 3692577 by mason.seay Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed Change 3692724 by mason.seay Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps Change 3693184 by mason.seay Assets for testing nativization with structs Change 3693367 by mason.seay Improvements to test content Change 3695395 by Dan.Oconnor Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced #jira None Change 3695484 by Marc.Audy Fix sound cue connection drawing policy not getting returned. #jira UE-51032 Change 3695494 by mason.seay More test content for nativization testing Change 3697829 by Mieszko.Zielinski PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei) Change 3700541 by mason.seay Test map for containers with function bug Change 3703459 by Marc.Audy Remove poorly named InverseLerp Fix degenerate behavior returning bad value #jira UE-50295 Change 3703803 by Marc.Audy Clean up autos Minor improvement to ShouldGenerateCluster Change 3704496 by Mason.Seay More test content for testing nativization Change 3706314 by Marc.Audy PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar) #jira UE-50874 Change 3707502 by Mason.Seay Final changes to nativization test content (hopefully) Change 3709478 by Marc.Audy PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel) Same as CL# 3689702 implemented in Fortnite #jira UE-51453 Change 3709967 by Marc.Audy PR #4139: fixed a typo in a comment (Contributed by derekvanvliet) #jira UE-51372 Change 3709970 by Marc.Audy PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman) #jira UE-51495 Change 3709971 by Marc.Audy PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas) #jira UE-51492 Change 3710041 by Marc.Audy Minor code cleanup Change 3711223 by Phillip.Kavan Move some Blueprint nativization log spam into the verbose category. #jira UE-49770 Change 3713398 by Marc.Audy PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM) #jira UE-51517 Change 3713601 by Marc.Audy Fix merge error Change 3713994 by Marc.Audy (4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event. #jira UE-50738 Change 3714270 by Marc.Audy Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors #jira UE-51534 Change 3714406 by Marc.Audy Fix dumb inverted boolean check Change 3716594 by Dan.Oconnor Integrate 3681301 from 4.18 Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior #jira UE-50780, UE-51568 Change 3686450 by Marc.Audy PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString. CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither. CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters. Material Expressions now store input and output names as FName instead of FString FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString Most existing pin related functions using string have been deprecated. Change 3713796 by Marc.Audy Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not. IsTickable no longer a pure virtual (defaults to true). Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject. Change 3638554 by Marc.Audy Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected. Change 3676502 by Ben.Zeigler Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635 [CL 3718205 by Marc Audy in Main branch]
2017-10-25 09:30:36 -04:00
OutputPin->PinType.PinValueType.TerminalSubCategory = NAME_None;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
OutputPin->PinType.PinValueType.TerminalSubCategoryObject = nullptr;
bNotifyGraphChanged = true;
}
}
if (bNotifyGraphChanged)
{
PropagatePinType();
GetGraph()->NotifyGraphChanged();
}
}
void UK2Node_MakeContainer::PropagatePinType()
{
const UEdGraphPin* OutputPin = GetOutputPin();
if (OutputPin)
{
UClass const* CallingContext = nullptr;
if (UBlueprint const* Blueprint = GetBlueprint())
{
CallingContext = Blueprint->GeneratedClass;
if (CallingContext == nullptr)
{
CallingContext = Blueprint->ParentClass;
}
}
TArray<UEdGraphPin*> KeyPins;
TArray<UEdGraphPin*> ValuePins;
GetKeyAndValuePins(KeyPins, ValuePins);
// Propagate pin type info (except for array info!) to pins with dependent types
const UEdGraphSchema_K2* Schema = GetDefault<UEdGraphSchema_K2>();
auto PropagateToPin = [Schema](UEdGraphPin* CurrentPin, const FEdGraphPinType& PinType)
{
// if we've reset to wild card or the parent pin no longer matches we need to collapse the split pin(s)
// otherwise everything should be OK:
if (CurrentPin->SubPins.Num() != 0 &&
(CurrentPin->PinType.PinCategory != PinType.PinCategory ||
CurrentPin->PinType.PinSubCategory != PinType.PinSubCategory ||
CurrentPin->PinType.PinSubCategoryObject != PinType.PinSubCategoryObject)
)
{
Schema->RecombinePin(CurrentPin->SubPins[0]);
}
CurrentPin->PinType.PinCategory = PinType.PinCategory;
CurrentPin->PinType.PinSubCategory = PinType.PinSubCategory;
CurrentPin->PinType.PinSubCategoryObject = PinType.PinSubCategoryObject;
};
for (UEdGraphPin* CurrentKeyPin : KeyPins)
{
PropagateToPin(CurrentKeyPin, OutputPin->PinType);
}
if (ValuePins.Num() > 0)
{
const FEdGraphPinType ValuePinType = FEdGraphPinType::GetPinTypeForTerminalType(OutputPin->PinType.PinValueType);
for (UEdGraphPin* CurrentValuePin : ValuePins)
{
PropagateToPin(CurrentValuePin, ValuePinType);
}
}
for (UEdGraphPin* CurrentPin : Pins)
{
if (CurrentPin && CurrentPin != OutputPin)
{
if (CurrentPin->PinType.PinCategory == UEdGraphSchema_K2::PC_Wildcard || CurrentPin->GetDefaultAsString().IsEmpty() == true)
{
// Only reset default value if there isn't one set or it is a wildcard. Otherwise this deletes data!
Schema->SetPinAutogeneratedDefaultValueBasedOnType(CurrentPin);
}
// Verify that all previous connections to this pin are still valid with the new type
TArray<UEdGraphPin*> LinkedToCopy = CurrentPin->LinkedTo;
for (UEdGraphPin* ConnectedPin : LinkedToCopy)
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
{
if (!Schema->ArePinsCompatible(CurrentPin, ConnectedPin, CallingContext))
{
CurrentPin->BreakLinkTo(ConnectedPin);
}
}
}
}
// If we have a valid graph we should refresh it now to refelect any changes we made
if (UEdGraphNode* OwningNode = OutputPin->GetOwningNode())
{
if (UEdGraph* Graph = OwningNode->GetGraph())
{
Graph->NotifyGraphChanged();
}
}
}
}
void UK2Node_MakeContainer::PostReconstructNode()
{
// Find a pin that has connections to use to jumpstart the wildcard process
FEdGraphPinType OutputPinType;
FEdGraphTerminalType OutputPinValueType;
const bool bMapContainer = ContainerType == EPinContainerType::Map;
bool bFoundKey = false;
bool bFoundValue = !bMapContainer;
UEdGraphPin* OutputPin = GetOutputPin();
if (OutputPin->LinkedTo.Num() > 0)
{
OutputPinType = OutputPin->LinkedTo[0]->PinType;
bFoundKey = true;
if (bMapContainer)
{
OutputPinValueType = OutputPin->LinkedTo[0]->PinType.PinValueType;
bFoundValue = true;
}
}
else
{
bool bKeyPin = !bMapContainer;
UEdGraphPin* CurrentTopParent = nullptr;
check(Pins[0] == OutputPin);
for (int32 PinIndex = 1; PinIndex < Pins.Num() && (!bFoundKey || !bFoundValue); ++PinIndex)
{
if (UEdGraphPin* CurrentPin = Pins[PinIndex])
{
if (CurrentPin->ParentPin == nullptr)
{
CurrentTopParent = CurrentPin;
if (bMapContainer)
{
bKeyPin = !bKeyPin;
}
}
if ((bKeyPin && !bFoundKey) || (!bKeyPin && !bFoundValue))
{
checkSlow((CurrentPin->ParentPin == nullptr) || (CurrentTopParent != nullptr));
if (CurrentPin->LinkedTo.Num() > 0)
{
// The pin is linked, use its type as the type for the key or value type as appropriate
// If this is a split pin, so we want to base the pin type on the parent rather than the linked to pin
const FEdGraphPinType& PinType = (CurrentPin->ParentPin ? CurrentTopParent->PinType : CurrentPin->LinkedTo[0]->PinType);
if (bKeyPin)
{
OutputPinType = PinType;
bFoundKey = true;
}
else
{
OutputPinValueType = FEdGraphTerminalType::FromPinType(PinType);
bFoundValue = true;
}
}
else if (!Pins[PinIndex]->DoesDefaultValueMatchAutogenerated())
{
// The pin has user data in it, continue to use its type as the type for all pins.
// If this is a split pin, so we want to base the pin type on the parent rather than this pin
const FEdGraphPinType& PinType = (CurrentPin->ParentPin ? CurrentTopParent->PinType : CurrentPin->PinType);
if (bKeyPin)
{
OutputPinType = PinType;
bFoundKey = true;
}
else
{
OutputPinValueType = FEdGraphTerminalType::FromPinType(PinType);
bFoundValue = true;
}
}
}
}
}
}
if (bFoundKey)
{
OutputPin->PinType = MoveTemp(OutputPinType);
}
else
{
OutputPin->PinType.PinCategory = UEdGraphSchema_K2::PC_Wildcard;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3716594) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3623720 by Phillip.Kavan #jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build. Change summary: - Temporarily excluded all AnimBP assets from nativization as a workaround. Change 3626305 by Phillip.Kavan #jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default. Change 3629145 by Marc.Audy Don't hide developer nativization tool behind ini Change 3630849 by Marc.Audy Fix nativization uncompilable code when using a non-referenceable term in a switch statement. #jira UE-44085 Change 3631037 by Marc.Audy (4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it #jira UE-49440 Change 3631206 by Marc.Audy Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT("")) Change 3631232 by Marc.Audy Remove outdated diagnostic code throwing false positives #jira UE-47986 Change 3631573 by Marc.Audy Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's' Change 3633168 by Lukasz.Furman fixed behavior tree changing its state during latent abort, modified order of operations during abort to: abort & wait -> change aux nodes -> execute Change 3633609 by Marc.Audy Don't get unneeded string Change 3633691 by Marc.Audy Fix copy-pasting of a collapsed graph containing a map input losing the value type #jira UE-49517 Change 3633967 by Ben.Zeigler Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript Fixed a few other fields to be private that were accidentally made public in 4.17 Change 3633984 by Michael.Noland Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links Change 3634464 by Ben.Zeigler Header cleanups for Pawn, Controller, Character, and PlayerController Change 3636858 by Marc.Audy In preview worlds don't display the light error sprite #jira UE-49555 Change 3636903 by Marc.Audy Fix numerous issues with copy/pasting editable pin bases #jira UE-49532 Change 3638898 by Marc.Audy Allow right-click creation of local variables in blueprint function libraries #jira UE-49590 Change 3639086 by Marc.Audy PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin) #jira UE-49591 Change 3639445 by Marc.Audy Fix mistaken override and virtual markup on niagara schema function. Change 3641202 by Marc.Audy (4.17.2) Fix crash undoing pin changes with split pins #jira UE-49634 Change 3643825 by Marc.Audy (4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted #jira UE-49756 Change 3645110 by mason.seay Fixed up QA-ClickHUD map so it's usable and makes more sense Change 3646428 by Dan.Oconnor Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data #jira None Change 3647298 by Marc.Audy PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist) #jira UE-49748 Change 3647815 by Marc.Audy Minor performance improvements Change 3648931 by Lina.Halper #Compiler : fixed so that each type of BP can provide module info, and compiler info - Moved out AnimBlueprint Compiler - Refactored WidgetBlueprint - DUPE - Merging using ControlRig_Dev-Framework Change 3654310 by Marc.Audy Shrink USkinnedMeshComponent 64 bytes Shrink USkeletalMeshComponent 224 bytes (160 bytes internal) Change 3654636 by Lina.Halper Fix crashing on shutdown #jira: UE-50004 Change 3654960 by Lina.Halper - Fix with automation test of creation/duplication - Fixed shut down crash with editor again due to uobject GCed #jira: UE-50028 Change 3655023 by Ben.Zeigler #jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag Change 3655426 by Ben.Zeigler #jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them Change 3657627 by Ben.Zeigler #jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction Change 3662086 by Mieszko.Zielinski Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4 This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList #jira UE-50101 Change 3662294 by Ben.Zeigler Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check Change 3662825 by Mieszko.Zielinski Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4 there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no Change 3664424 by Marc.Audy UE-50076 test assets #rb none #rnx Change 3664441 by Mieszko.Zielinski PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist) Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated. Change 3664506 by Phillip.Kavan #jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets. Change summary: - UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization. - UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths. - UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished. - UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option). - UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed. - UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead. - UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead. - UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file. - UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file. - UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first). - UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness. - UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed. - UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc. - UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file. - UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string. - UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>. - UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin. - UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed). - UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed). - UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it. - UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished. - UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed. - UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context. - UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail. - UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT). - UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders. Notes: - After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release). - Advanced users and build engineers can override this value per task. Instructions to do that are as follows: - For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line. - When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly. - We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT. - We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above). Change 3665061 by Phillip.Kavan Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum. Mirrored from //UE4/Release-4.18 (CL# 3664993). #3969 #jira UE-49233 Change 3665108 by Marc.Audy (4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted + additional code cleanup #jira UE-50076 Change 3665114 by Marc.Audy Minor change that could potentially improve performance in some cases Change 3665410 by Mieszko.Zielinski Fixed naming of Vislog's BP API #UE4 Change 3665634 by Ben.Zeigler #jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk Change 3666970 by Phillip.Kavan Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8. #jira UE-46814 Change 3667058 by Phillip.Kavan Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage. Mirrored from //UE4/Release-4.18 (CL# 3667043). #jira UE-50403 Change 3667150 by Mieszko.Zielinski PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM) Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend. #jira UE-50249 Change 3667152 by Mieszko.Zielinski PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM) #jira UE-50298 Change 3667166 by Mieszko.Zielinski Fixed FRichCurve baking so that it doesn't loose its curvature #UE4 Also, added some baking sanity checking (like if the range is larger than a single point). Change 3668025 by Dan.Oconnor Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed #jira UE-50453 Change 3672063 by Ben.Zeigler #jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case Change 3672306 by Ben.Zeigler #jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it Change 3672683 by Marc.Audy Code cleanup Change 3672749 by Ben.Zeigler Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build Change 3672831 by Ben.Zeigler #jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId. Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project Change 3673551 by Ben.Zeigler #jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load Change 3675074 by mason.seay Test map for VisLog Testing Change 3675084 by Mieszko.Zielinski Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4 #jira UE-43430 Change 3676490 by Ben.Zeigler #jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset Change 3676579 by Lukasz.Furman fixed crash in behavior tree's search rollback Change 3676586 by Lukasz.Furman added local scope mode to behavior tree's composite nodes Change 3676587 by Ben.Zeigler Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case Add browse, use selected, and clear buttons, and make ID selector font the normal property font Change 3676715 by Lukasz.Furman changed order of behavior tree's aux node ticking Change 3676867 by Ben.Zeigler #jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early Change 3677892 by Ben.Zeigler Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites Change 3678247 by Marc.Audy Fix static analysis warning Change 3678357 by Ben.Zeigler #jira UE-50696 Add some container variables to diff test to track down crashes Change 3678385 by Ben.Zeigler #jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match Change 3678600 by Ben.Zeigler #jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference Change 3679075 by Dan.Oconnor Mirror 3679030 from Release-4.18 Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on #jira UE-48692 Change 3679087 by Dan.Oconnor Filter out unnecessary relink jobs from the compilation manager #jira None Change 3680221 by Ben.Zeigler #jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary Change 3680561 by Lukasz.Furman fixed unsafe StopTree calls in behavior tree #jira nope Change 3680788 by Ben.Zeigler Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind Change 3683001 by mason.seay Submitting various test maps and assets Change 3686837 by Mieszko.Zielinski Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion #jira UE-50857 Change 3688451 by Marc.Audy Fix up new material expression to work with String -> Name refactor Change 3689097 by Mason.Seay Test content for nativization and enum testing Change 3689106 by Mieszko.Zielinski Made NavMeshBoundsVolume react to undo in the editor #Orion #jira UE-51013 Change 3689347 by Mieszko.Zielinski Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4 Manual merge of CL#3689316 over from 4.18 #jira UE-51019 Change 3692524 by mason.seay Moved some assets to folder for org, fixed up redirectors Change 3692540 by mason.seay Renaming test maps so they are clearly indicated for testing nativization Change 3692577 by mason.seay Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed Change 3692724 by mason.seay Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps Change 3693184 by mason.seay Assets for testing nativization with structs Change 3693367 by mason.seay Improvements to test content Change 3695395 by Dan.Oconnor Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced #jira None Change 3695484 by Marc.Audy Fix sound cue connection drawing policy not getting returned. #jira UE-51032 Change 3695494 by mason.seay More test content for nativization testing Change 3697829 by Mieszko.Zielinski PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei) Change 3700541 by mason.seay Test map for containers with function bug Change 3703459 by Marc.Audy Remove poorly named InverseLerp Fix degenerate behavior returning bad value #jira UE-50295 Change 3703803 by Marc.Audy Clean up autos Minor improvement to ShouldGenerateCluster Change 3704496 by Mason.Seay More test content for testing nativization Change 3706314 by Marc.Audy PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar) #jira UE-50874 Change 3707502 by Mason.Seay Final changes to nativization test content (hopefully) Change 3709478 by Marc.Audy PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel) Same as CL# 3689702 implemented in Fortnite #jira UE-51453 Change 3709967 by Marc.Audy PR #4139: fixed a typo in a comment (Contributed by derekvanvliet) #jira UE-51372 Change 3709970 by Marc.Audy PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman) #jira UE-51495 Change 3709971 by Marc.Audy PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas) #jira UE-51492 Change 3710041 by Marc.Audy Minor code cleanup Change 3711223 by Phillip.Kavan Move some Blueprint nativization log spam into the verbose category. #jira UE-49770 Change 3713398 by Marc.Audy PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM) #jira UE-51517 Change 3713601 by Marc.Audy Fix merge error Change 3713994 by Marc.Audy (4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event. #jira UE-50738 Change 3714270 by Marc.Audy Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors #jira UE-51534 Change 3714406 by Marc.Audy Fix dumb inverted boolean check Change 3716594 by Dan.Oconnor Integrate 3681301 from 4.18 Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior #jira UE-50780, UE-51568 Change 3686450 by Marc.Audy PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString. CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither. CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters. Material Expressions now store input and output names as FName instead of FString FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString Most existing pin related functions using string have been deprecated. Change 3713796 by Marc.Audy Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not. IsTickable no longer a pure virtual (defaults to true). Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject. Change 3638554 by Marc.Audy Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected. Change 3676502 by Ben.Zeigler Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635 [CL 3718205 by Marc Audy in Main branch]
2017-10-25 09:30:36 -04:00
OutputPin->PinType.PinSubCategory = NAME_None;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
OutputPin->PinType.PinSubCategoryObject = nullptr;
}
if (bMapContainer)
{
if (bFoundValue)
{
OutputPin->PinType.PinValueType = MoveTemp(OutputPinValueType);
}
else
{
OutputPin->PinType.PinValueType.TerminalCategory = UEdGraphSchema_K2::PC_Wildcard;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3716594) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3623720 by Phillip.Kavan #jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build. Change summary: - Temporarily excluded all AnimBP assets from nativization as a workaround. Change 3626305 by Phillip.Kavan #jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default. Change 3629145 by Marc.Audy Don't hide developer nativization tool behind ini Change 3630849 by Marc.Audy Fix nativization uncompilable code when using a non-referenceable term in a switch statement. #jira UE-44085 Change 3631037 by Marc.Audy (4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it #jira UE-49440 Change 3631206 by Marc.Audy Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT("")) Change 3631232 by Marc.Audy Remove outdated diagnostic code throwing false positives #jira UE-47986 Change 3631573 by Marc.Audy Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's' Change 3633168 by Lukasz.Furman fixed behavior tree changing its state during latent abort, modified order of operations during abort to: abort & wait -> change aux nodes -> execute Change 3633609 by Marc.Audy Don't get unneeded string Change 3633691 by Marc.Audy Fix copy-pasting of a collapsed graph containing a map input losing the value type #jira UE-49517 Change 3633967 by Ben.Zeigler Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript Fixed a few other fields to be private that were accidentally made public in 4.17 Change 3633984 by Michael.Noland Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links Change 3634464 by Ben.Zeigler Header cleanups for Pawn, Controller, Character, and PlayerController Change 3636858 by Marc.Audy In preview worlds don't display the light error sprite #jira UE-49555 Change 3636903 by Marc.Audy Fix numerous issues with copy/pasting editable pin bases #jira UE-49532 Change 3638898 by Marc.Audy Allow right-click creation of local variables in blueprint function libraries #jira UE-49590 Change 3639086 by Marc.Audy PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin) #jira UE-49591 Change 3639445 by Marc.Audy Fix mistaken override and virtual markup on niagara schema function. Change 3641202 by Marc.Audy (4.17.2) Fix crash undoing pin changes with split pins #jira UE-49634 Change 3643825 by Marc.Audy (4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted #jira UE-49756 Change 3645110 by mason.seay Fixed up QA-ClickHUD map so it's usable and makes more sense Change 3646428 by Dan.Oconnor Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data #jira None Change 3647298 by Marc.Audy PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist) #jira UE-49748 Change 3647815 by Marc.Audy Minor performance improvements Change 3648931 by Lina.Halper #Compiler : fixed so that each type of BP can provide module info, and compiler info - Moved out AnimBlueprint Compiler - Refactored WidgetBlueprint - DUPE - Merging using ControlRig_Dev-Framework Change 3654310 by Marc.Audy Shrink USkinnedMeshComponent 64 bytes Shrink USkeletalMeshComponent 224 bytes (160 bytes internal) Change 3654636 by Lina.Halper Fix crashing on shutdown #jira: UE-50004 Change 3654960 by Lina.Halper - Fix with automation test of creation/duplication - Fixed shut down crash with editor again due to uobject GCed #jira: UE-50028 Change 3655023 by Ben.Zeigler #jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag Change 3655426 by Ben.Zeigler #jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them Change 3657627 by Ben.Zeigler #jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction Change 3662086 by Mieszko.Zielinski Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4 This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList #jira UE-50101 Change 3662294 by Ben.Zeigler Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check Change 3662825 by Mieszko.Zielinski Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4 there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no Change 3664424 by Marc.Audy UE-50076 test assets #rb none #rnx Change 3664441 by Mieszko.Zielinski PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist) Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated. Change 3664506 by Phillip.Kavan #jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets. Change summary: - UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization. - UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths. - UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished. - UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option). - UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed. - UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead. - UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead. - UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file. - UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file. - UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first). - UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness. - UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed. - UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc. - UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file. - UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string. - UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>. - UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin. - UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed). - UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed). - UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it. - UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished. - UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed. - UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context. - UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail. - UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT). - UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders. Notes: - After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release). - Advanced users and build engineers can override this value per task. Instructions to do that are as follows: - For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line. - When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly. - We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT. - We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above). Change 3665061 by Phillip.Kavan Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum. Mirrored from //UE4/Release-4.18 (CL# 3664993). #3969 #jira UE-49233 Change 3665108 by Marc.Audy (4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted + additional code cleanup #jira UE-50076 Change 3665114 by Marc.Audy Minor change that could potentially improve performance in some cases Change 3665410 by Mieszko.Zielinski Fixed naming of Vislog's BP API #UE4 Change 3665634 by Ben.Zeigler #jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk Change 3666970 by Phillip.Kavan Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8. #jira UE-46814 Change 3667058 by Phillip.Kavan Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage. Mirrored from //UE4/Release-4.18 (CL# 3667043). #jira UE-50403 Change 3667150 by Mieszko.Zielinski PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM) Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend. #jira UE-50249 Change 3667152 by Mieszko.Zielinski PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM) #jira UE-50298 Change 3667166 by Mieszko.Zielinski Fixed FRichCurve baking so that it doesn't loose its curvature #UE4 Also, added some baking sanity checking (like if the range is larger than a single point). Change 3668025 by Dan.Oconnor Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed #jira UE-50453 Change 3672063 by Ben.Zeigler #jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case Change 3672306 by Ben.Zeigler #jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it Change 3672683 by Marc.Audy Code cleanup Change 3672749 by Ben.Zeigler Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build Change 3672831 by Ben.Zeigler #jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId. Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project Change 3673551 by Ben.Zeigler #jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load Change 3675074 by mason.seay Test map for VisLog Testing Change 3675084 by Mieszko.Zielinski Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4 #jira UE-43430 Change 3676490 by Ben.Zeigler #jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset Change 3676579 by Lukasz.Furman fixed crash in behavior tree's search rollback Change 3676586 by Lukasz.Furman added local scope mode to behavior tree's composite nodes Change 3676587 by Ben.Zeigler Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case Add browse, use selected, and clear buttons, and make ID selector font the normal property font Change 3676715 by Lukasz.Furman changed order of behavior tree's aux node ticking Change 3676867 by Ben.Zeigler #jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early Change 3677892 by Ben.Zeigler Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites Change 3678247 by Marc.Audy Fix static analysis warning Change 3678357 by Ben.Zeigler #jira UE-50696 Add some container variables to diff test to track down crashes Change 3678385 by Ben.Zeigler #jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match Change 3678600 by Ben.Zeigler #jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference Change 3679075 by Dan.Oconnor Mirror 3679030 from Release-4.18 Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on #jira UE-48692 Change 3679087 by Dan.Oconnor Filter out unnecessary relink jobs from the compilation manager #jira None Change 3680221 by Ben.Zeigler #jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary Change 3680561 by Lukasz.Furman fixed unsafe StopTree calls in behavior tree #jira nope Change 3680788 by Ben.Zeigler Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind Change 3683001 by mason.seay Submitting various test maps and assets Change 3686837 by Mieszko.Zielinski Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion #jira UE-50857 Change 3688451 by Marc.Audy Fix up new material expression to work with String -> Name refactor Change 3689097 by Mason.Seay Test content for nativization and enum testing Change 3689106 by Mieszko.Zielinski Made NavMeshBoundsVolume react to undo in the editor #Orion #jira UE-51013 Change 3689347 by Mieszko.Zielinski Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4 Manual merge of CL#3689316 over from 4.18 #jira UE-51019 Change 3692524 by mason.seay Moved some assets to folder for org, fixed up redirectors Change 3692540 by mason.seay Renaming test maps so they are clearly indicated for testing nativization Change 3692577 by mason.seay Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed Change 3692724 by mason.seay Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps Change 3693184 by mason.seay Assets for testing nativization with structs Change 3693367 by mason.seay Improvements to test content Change 3695395 by Dan.Oconnor Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced #jira None Change 3695484 by Marc.Audy Fix sound cue connection drawing policy not getting returned. #jira UE-51032 Change 3695494 by mason.seay More test content for nativization testing Change 3697829 by Mieszko.Zielinski PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei) Change 3700541 by mason.seay Test map for containers with function bug Change 3703459 by Marc.Audy Remove poorly named InverseLerp Fix degenerate behavior returning bad value #jira UE-50295 Change 3703803 by Marc.Audy Clean up autos Minor improvement to ShouldGenerateCluster Change 3704496 by Mason.Seay More test content for testing nativization Change 3706314 by Marc.Audy PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar) #jira UE-50874 Change 3707502 by Mason.Seay Final changes to nativization test content (hopefully) Change 3709478 by Marc.Audy PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel) Same as CL# 3689702 implemented in Fortnite #jira UE-51453 Change 3709967 by Marc.Audy PR #4139: fixed a typo in a comment (Contributed by derekvanvliet) #jira UE-51372 Change 3709970 by Marc.Audy PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman) #jira UE-51495 Change 3709971 by Marc.Audy PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas) #jira UE-51492 Change 3710041 by Marc.Audy Minor code cleanup Change 3711223 by Phillip.Kavan Move some Blueprint nativization log spam into the verbose category. #jira UE-49770 Change 3713398 by Marc.Audy PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM) #jira UE-51517 Change 3713601 by Marc.Audy Fix merge error Change 3713994 by Marc.Audy (4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event. #jira UE-50738 Change 3714270 by Marc.Audy Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors #jira UE-51534 Change 3714406 by Marc.Audy Fix dumb inverted boolean check Change 3716594 by Dan.Oconnor Integrate 3681301 from 4.18 Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior #jira UE-50780, UE-51568 Change 3686450 by Marc.Audy PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString. CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither. CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters. Material Expressions now store input and output names as FName instead of FString FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString Most existing pin related functions using string have been deprecated. Change 3713796 by Marc.Audy Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not. IsTickable no longer a pure virtual (defaults to true). Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject. Change 3638554 by Marc.Audy Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected. Change 3676502 by Ben.Zeigler Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635 [CL 3718205 by Marc Audy in Main branch]
2017-10-25 09:30:36 -04:00
OutputPin->PinType.PinValueType.TerminalSubCategory = NAME_None;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
OutputPin->PinType.PinValueType.TerminalSubCategoryObject = nullptr;
}
}
OutputPin->PinType.ContainerType = ContainerType;
PropagatePinType();
Super::PostReconstructNode();
}
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3628051) #lockdown Nick.Penwarden #rb none #rnx ============================ MAJOR FEATURES & CHANGES ============================ Change 3582363 by Marc.Audy Make ComponentToWorld fully private and remove deprecation informing of this #jira UE-46286 Change 3582885 by Ben.Zeigler #jira UE-47642 Add ToString for SoftObjectReference/SoftClassReference/PrimaryAssetId/PrimaryAssetType to use for debugging. The other direction is not provided because the type validation cannot be done at runtime Change 3584468 by Ben.Zeigler #jira UE-48301 Avoid infinite recursion crash when cooking client/server only component blueprints Change 3584596 by Marc.Audy (4.17) Ensure that old user defined structs have their members properly marked as blueprint visible #jira UE-48346 Change 3586057 by Ben.Zeigler #jira UE-48413 Fix issue where running a dedicated server with a fixed framerate could cause a time crash because the "last time" was out of sync. Clarified code to indicate which times are real and which are logical. This manifested as a crash in EngineTest but could happen in any game with a fixed framerate Change 3588211 by Marc.Audy PR #3889: Added BLUEPRINTGRAPH_API module specifier to the input nodes. (Contributed by karanseqwb) #jira UE-48318 Change 3588826 by Marc.Audy Don't ensure when connecting the output pin of a create delegate node to a wildcard input #jira UE-48157 Change 3588827 by Marc.Audy Always throw error when unable to validate a link connection instead of allowing totally broken content to compile Change 3588872 by Ben.Zeigler #jira UE-48457 Add Export To CSV to content browser/asset audit windows that are in the column view. This is useful for preparing memory/disk usage reports Change 3589134 by Dan.Oconnor Mirror 3585244 from Release 4.17 Run actor construction via UBlueprint::BroadcastCompiled after reinstancing, matching non-compilation manager behavior #jira UE-48189 Change 3589140 by Dan.Oconnor Mirror 3588406 from Release-4.17 Set "WorldContext" metadata earlier in the compilation process, so that it can be used reliably in other blueprints. This fixes occasionally 'None' WorldContext references #jira UE-48464 Change 3589141 by Dan.Oconnor Mirror 3588681 from Release-4.17 Set Default values and CallInEditor meta data for event nodes #jira UE-48386 Change 3590690 by Ben.Zeigler #jira UE-48509 Fix crash in incremental cook when a file in the incremental cook was deleted from p4 Change 3590909 by Ben.Zeigler #jira UE-48509 Fix crash in incremental cooker when DDC data is not built for a package that is skipped for rebuilding. The cached data would not be checked for completness, but would assert becuase it was not complete. WillNeverCacheCookedPlatformDataAgain no longer does anything other than assert, so remove it. Change 3591386 by Marc.Audy Split pins are now correctly handled when expanding macros and functions. #jira UE-47747 Change 3591939 by Dan.Oconnor Mirror 3591923 from Release-4.17 Split ReplaceInstancesOfClass_Inner into two passes, one for objects and one for actors because actor reconstruction needs all components to be of final class type (e.g. not REINST_ or HOT_RELOAD_) #jira UE-48250 Change 3593243 by Marc.Audy PR #3910: Add FQuat initialization from FString (Contributed by cneumann) #jira UE-48534 Change 3593407 by Marc.Audy Properly expose Lex::To/FromString for FName Change 3593648 by Marc.Audy Refactor AActor::PostEditUndo to have a single implementation to avoid incosistent fixes Change 3593917 by Marc.Audy Improved comment Change 3594501 by Marc.Audy Fix biased shuffle algorithm #jira UE-48432 Change 3594699 by Ben.Zeigler #jira UE-48555 Fix crash where async loading flush update callback was happening in the async loading thread, it's supposed to be a game delegate Fix InstancedStaticMesh to not ensure when loaded via the async loading thread Change 3595327 by Phillip.Kavan #jira UE-16485 - Add an option to host global Blueprint searches in a dockable tab that's not tied to any Blueprint editor context. Change summary: - Added a few additional Slate editor style descriptors specifically for the Find Results tab. - Added a private dependency on the 'WorkspaceMenuStructure' module to the 'Kismet' editor module. - Added a new Blueprint Editor settings option to the "Workflow" section to toggle the feature on/off (now set to 'on' by default). - Added a UBluepriintEditorSettings::PostEditChangeProperty() implementation to reset FiB state upon changing the experimental toggle switch. - Modified the FFindResultsSummoner ctor to use an alternate tooltip when the feature is turned on. In that case the "local" Find Results tab will always search only the local BP context. - Modified FBlueprintEditor::OnRequestClose() to additionally find and close the local Find Results tab if the feature is turned on and we're not in a full BP editor context. This ensures that the local Find Results tab context will be reset to hidden if the option is toggled while a defaults-only BP editor context is active. - Modified FBlueprintEditor::SummonSearchUI() to invoke the global Find Results tab if the feature is turned on and 'bSetFindWithinBlueprint' is true. - Simplified FBlueprintEditor::FindInBlueprint_Clicked() and FBlueprintEditor::FindInBlueprints_OnClicked() to call SummonSearchUI(). - Moved the FFindInBlueprintsResult declaration into FindInBlueprintManager.h. Also relocated the ExpandAllChildren API out of this class and into the localized FindInBlueprintsHelpers util class. - Added new FFindInBlueprintSearchManager public APIs - GetGlobalFindResults() and CloseAllGlobalResults(). Also added a delegate for handling cleanup after a global Find Results tab is closed. - When the feature is turned on, global Find Results tabs will be named "Find in Blueprints" to correlate to the menu command that's bound to CTRL-SHIFT-F. An index will be appended to the tab name if more than one context is active. - Extended FFindInBlueprintSearchManager to support spawning and maintaining up to 4 global Find Results widget contexts. These are registered and spawned as "nomad" tabs, but they don't currently auto-insert into the menu. Instead, they are invoked internally by the GetGlobalFindResults() API as needed, in response to the BP editor's "Find in Blueprints" command. - Extended the SFindInBlueprints widget to support a "locked" state and allow users to toggle it via an SButton. This is visible only in the global Find Results context. - Extended the SFindInBlueprints widget to support an additional "Find in All Blueprints" button on the local Find Results context. Clicking the button will invoke an unlocked global Find Results tab and initiate a global search with the text taken from the local context. This is visible only in the local Find Results context. - Removed the "Find in Current Blueprint only" checkbox from the local Find Results context when the feature is enabled. Global searches are instead redirected to the global Find Results tab. Change 3596499 by Marc.Audy Fix non-editor CIS error Change 3596653 by Marc.Audy When a transaction is cancelled the previous redo buffer will now be restored instead of lost #jira UE-48513 Change 3598187 by Ben.Zeigler Add ability for automation command line to run as remote session with Automation StartRemoteSession (SessionGuid). In this mode it waits for external clients to be ready Fix functional tests to work in editor builds with -game by forcing an asset registry scan Change 3598193 by Ben.Zeigler Add support for -TcpMessagingListen=IP:port and TcpMessagingConnect=IP:Port command line options to the TCP messaging layer, this is used by automation to connect a specific device to an editor coordinator. Change 3600168 by Marc.Audy (4.17.2) Protect against crash when ParentClass has become null for unknown reasons #jira UE-47467 Change 3600457 by Ben.Zeigler Fix issue where nonblocking BSD sockets on some platforms may return EINPROGRESS on initial connect, which should not be treated as an error Change 3600462 by Ben.Zeigler Remove platform whitelist from TcpMessaging plugin, this was effectively blocking it on all other platforms Change 3600685 by Marc.Audy (4.17.2) ParentClass is known to be able to be null if a class has been deleted without redirector. Allow the class to be marked deprecated under this circumstance. #jira UE-47467 Change 3600859 by Marc.Audy (4.17.2) Prevent error pop ups about failing to save world due to save on compile of blueprints #jira UE-48672 Change 3600918 by Marc.Audy Transient child actor components should create transient child actors. #jira UE-48605 Change 3601012 by Ben.Zeigler Fix TCP Messaging system to work better on non desktop by sleeping for some real time during the thread tick. Add verbose logs and fix warning spam about thread stats being duplicated by renaming the thread per connection. Change 3602595 by Marc.Audy (4.17.2) PR #3930: Fix compiler error for PS4 if a nativized blueprint invokes a method of its own through interface (Contributed by hillin) #jira UE-48684 Change 3602644 by Ben.Zeigler Add game game thread asserts to streamable manager to track down possible async loading thread issues Change 3602745 by Ben.Zeigler Add Tolerance parameters to AssertEqual_Rotator and Transform, Vector and Float already had them Change 3602807 by Phillip.Kavan #jira UE-48426 - Fix runtime crash in a nativized child Blueprint that includes a parent function call node in a replicated function implementation. Change summary: - Modified FBlueprintCompilerCppBackend::EmitCallStatmentInner() to append the "_Implementation" postfix to parent RPC calls in a child class RPC implementation. Change 3602856 by Ben.Zeigler Fix fixed frame rate to be more stable by computing delta time as doubles, to avoid rounding issues Change 3602903 by Marc.Audy Allow Scale to be set on an AnimNotify as well as the spawn emitter gameplay statics #jira UE-39362 Change 3602963 by Marc.Audy PR #3762: DisableHaptics disables haptics properly (Contributed by projectgheist) #jira UE-46960 Change 3603249 by Marc.Audy Prevent compilation of a blueprint containing a child actor component to mark the blueprint the child actor's class dirty #jira UE-43328 Change 3603311 by Ben.Zeigler Add -nocodesign option to disable code signing during staging Change 3603504 by Ben.Zeigler #jira UE-27124 Fix crash during PIE by ensuring the world package PIE flag is always set, even if it's loaded via redirector Change 3604790 by Marc.Audy Fix inability to undo Add Pin via context menu to make container nodes. #jira UE-48751 Change 3605079 by mason.seay Renamed component from Cube to Cylinder, because it's actually a Cylinder Change 3605113 by Mieszko.Zielinski PR #3927: Fixed issue of behavior if setting InfiniteLoopTimeoutTime variable (Contributed by yhase7) Change 3605276 by mason.seay Fixed comment error in level bp Change 3605706 by Zak.Middleton #ue4 - Fix redundant GetDefault<>. #jira none Change 3605850 by Zak.Middleton #ue4 - Fix client assert when trying to send RPCs while connection is pending closure due to queued bunches. ChIndex is -1 during this time, though the channel is not actually closed. Added ensure when calling SendBunch() under this condition to catch future cases like this. (Mirror CL 3602849 in Fortnite) #jira FORT-51215, UT-6139 Change 3607677 by Dan.Oconnor Mirror 3597636 from Release-4.17 Don't clear UClass CDO until after we've duplicated the class, in case class duplication wants to read from the CDO (e.g. when duplicating a class that has ChildActorComponents) #jira UE-48524 Change 3607704 by Dan.Oconnor Back out changelist 3607677 - want to obliterate integration record Change 3607727 by Dan.Oconnor Mirror 3597636 from Release-4.17 - now with integrations converted to edits Don't clear UClass CDO until after we've duplicated the class, in case class duplication wants to read from the CDO (e.g. when duplicating a class that has ChildActorComponents) #jira UE-48524 Change 3607735 by Dan.Oconnor Mirror 3606248 from Release-4.17 When copying data from old archetypes to new archetypes we want to use delta's from the old instances, but only when reliable (e.g. not CDO) #jira UE-48697, UE-48465 Change 3607919 by Ben.Zeigler #jira UE- 48815 Fix issue where StreamableHandle CompletedDelegate wasn't being reset after being called. If this had a payload pointing to the handle the handle would then be kept alive forever due to the reference counting, causing bad memory leaks Copy of CL #3607743 Change 3608447 by mason.seay Fixing deprecated node Change 3608779 by Ben.Zeigler #jira UE-48762 Do not rename a PIE world in place if it was loaded by redirector, this corrupts the redirector and later crashes if used again Change 3609860 by Marc.Audy Allow uint8:1 properties to be used as expose on spawn #jira FORT-52043 Change 3609877 by Marc.Audy Reduce size of UProperty and UWidgetBlueprintGeneratedClass by 8 bytes Reduce size UBlueprintGeneratedClass by 32 bytes #jira FORT-52043 Change 3609944 by Marc.Audy Remove unused per instance physics create/destroyed delegates from UActorComponent (reduce size by 224 bytes) Change 3610009 by mason.seay Moving assets to another folder for organization Change 3610840 by Ben.Zeigler #jira UE-47351 Fix multiple launch ons inside the editor to correctly detect changed source files by refreshing the asset registry each time. Packages are now always saved to disk before launch on so we just need to load the data off disk and then refresh the registry generators. Change 3610961 by Ben.Zeigler Fix it so when a test times out it writes out the full report with a proper error Fix typo with ErrorCount Change 3611183 by Marc.Audy (4.17.2) Don't crash clicking the variable of a deleted component #jira UE-47678 Change 3611262 by Ben.Zeigler #jira UE-41412 Fix Delegate ImportText to check the outer chain for owning object before searching all packages, this fixes several issues with copy-pasting actors that have bound delegates Change 3611667 by Phillip.Kavan #jira UE-48450 - Fix UHT C++ codegen compile error (regression) after choosing to package with Blueprint nativization enabled if the project includes a converted User-Defined Structure asset. Change 3612641 by Marc.Audy Private StaticMesh, remove deprecation warning Change 3612990 by Marc.Audy Reduce memory footprint of UClass Change 3613137 by Ben.Zeigler #jira UE-44570 Fix issue with GUID struct customization where it would generate a post edit after modifying only the first element in the GUID, which caused the property handle to get invalidated Change 3613161 by Ben.Zeigler #jira UE-48372 Add InRange (Int) for Blueprints, and cleanup KismetMathLibrary.h comments PR #3899 Change 3613192 by Ben.Zeigler #jira UE-48366 PR #3895 Fix missing small icons within the blueprint Merge and diff tools Change 3613320 by Mason.Seay Submitting deleted redirectors Change 3613321 by Marc.Audy Shrink AActor 32 bytes Change 3613326 by Marc.Audy Move Serialize to be editoronly Change 3613358 by Phillip.Kavan #jira UE-48525 - Fix non-native script interface property value initialization for nativized Blueprint class default objects. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to special-case interface property values when emitting initialization code for converted class subobjects. Change 3613827 by Marc.Audy Combine material parameter caches of UMeshComponent in to a single sorted map instead of 3 independent maps (saves ~224 bytes) Change 3613841 by Ben.Zeigler #jira UE-48800 Fix crash with undoing blueprint changes while blueprint differ is open, it now listens for blueprint changes Change 3614031 by Marc.Audy Fix initialization order Change 3614033 by Marc.Audy Use Reset instead of Empty in get functions Change 3615211 by Ben.Zeigler Fix CIS warning Change 3615386 by Ben.Zeigler #jira UE-48976 Fix crash compiling user struct when out of date nodes point to it Change 3615571 by Ben.Zeigler #jira UE-48974 Fix crash trying to reconnect blueprint pins with null connections Change 3615844 by Marc.Audy (4.17.2) Reexpose WeightedBlendables/Post Process Materials to blueprints #jira UE-48977 Change 3615887 by Marc.Audy (4.17.2) Don't crash getting context menu actions if the variable get doesn't have a value pin #jira UE-48970 Change 3615965 by Dan.Oconnor Make sure that depedent blueprints are bytecode recompiled (e.g. child blueprints that are also dependent must also be bytecode recompiled), also no longer call RefreshNodes on dependent blueprints of interfaces, as this is no longer needed and can result in incoherent skeleton class hierarchies #jira UE-48429, UE-48433, UE-48437, UE-48445, UE-48692 Change 3616149 by mason.seay Updated BP for more thorough Find in BP testing Change 3616261 by Dan.Oconnor Mirror 3594264 and 3594798 from Release-4.17 Fix crash after compiling a blueprint that has an invalid ParentClass #jira UE-48430, UE-48903 Change 3616816 by Zak.Middleton #ue4 - Add GetTargetRotation() to SpringArmComponent, which returns the rotation target based on the combination of various rotation setting flags (bUsePawnControlRotation, bInheritPitch, bInheritYaw, bInheritRoll, absolute rotation flags). #jira UE-48351 Change 3616934 by Phillip.Kavan #jira UE-48877 - Close a disabled new-style global find tab if docked after restoring a previously-saved Blueprint editor layout. Change summary: - Modified FBlueprintEditor::PostLayoutBlueprintEditorInitialization() to close any active global tabs after restoring from a saved layout if the option is disabled. Change 3616946 by Phillip.Kavan #jira UE-48595 - Global FiB Results are now accessible through the main Window menu. Change 3618007 by Marc.Audy (4.17.2) Ensure that RootComponent is correct after undo/redo #jira UE-48995 Change 3618014 by Phillip.Kavan #jira UE-49025 - Fix global FiB menu item names. Change 3618206 by Dan.Oconnor Make sure instances in the same package as a UBlueprintGeneratedClass are properly created after the CDO #jira UE-47991, UE-47726 Change 3618211 by Dan.Oconnor Fix 'bad' USE_DEFERRED_DEPENDENCY_CHECK_VERIFICATION_TEST - this is only broken until we get the fix from core that restores CLASS_Intrinsic Change 3618299 by Zak.Middleton #ue4 - Fix comment in GetComponents (UActorComponent version) #jira none Change 3618409 by Marc.Audy Make linker placeholder properly support map and set properties #jira UE-48925 Change 3618436 by Marc.Audy Fix shadow variable Change 3618682 by Ben.Zeigler Fix issue where pressing escape or losing focus while using a SpinBox would leave the UI in a state where the SpinBox could never be used again, caused by CL #3173966. Also fix the initial value to be correct the first time it is dragged Change 3618783 by Ben.Zeigler Fix several issues with the Component Transform details UI #jira UE-48959 Fix it so the world/relative transform type bools are correctly propagated to inherited components when modified via editor customizations #jira UE-48963 Refactor Transform customization to handle paste and reset to default as atomic operations, allowing them to work properly on blueprint component instances #jira UE-48960 Correctly notify blueprint system when component transforms are changed #jira UE-4311 Preserve exact rotation typed into component rotation field in most cases Fix the "Reset to Defaults" icon to be correct in transform details Change 3618904 by Ben.Zeigler #jira UE-489999 Fix blueprint breakpoint crash when breakpoint data is out of date with UI Change 3618984 by Zak.Middleton #ue4 - Reduce memory churn/allocations when duplicating for PIE. #jira none Change 3619895 by Marc.Audy Very minor cleanup Change 3620129 by Marc.Audy PR #3958: Exposing GetOwningPlayerController and GetOwningPawn as public in AHUD. (Contributed by ill) #jira UE-49083 Change 3620350 by Lukasz.Furman restored intended behavior of path following's acceptance radius: additive with goal and agent radii (included when FAIMoveRequest flags allow it) copy of CL# 3618825, 3618828 #ue4 Change 3620628 by Zak.Middleton #ue4 - Moved hardcoded limits on FCollisionShape extents to a static value and refactored external code to reference that instead. Fixed Capsules where axis length (half-height - radius) < 1 were clamped to a new capsule with axis length of 1. Changed the clamp threshold to 1e-4 and changed FPhysXShapeAdaptor to use a Sphere instead when Radius >= HalfHeight. This would cause sweeps using the capsule params to use a capsule of a different size, up to 1 UU different along the axis. #jira UE-49035 Change 3620700 by Lukasz.Furman moved blackboard decortator's version of requesting abort to parent class, so all decorators can use it with external events #ue4 Change 3620716 by mason.seay Test map for flow control save issue Change 3620723 by mason.seay Minor improvement Change 3620792 by Ben.Zeigler Clang doesn't like template specializations in classes, switch to an overload instead to fix CIS Change 3621084 by Marc.Audy Fix NegateInt/Float in StandardMacros #jira UE-36242 #jira UE-36470 Change 3621152 by Marc.Audy Fix backwards compatibility on FEdGraphPinType for particularly old blueprints. #jira UE-49111 Change 3621246 by mason.seay Test BP for UE-48800 Change 3621257 by Michael.Noland Animation: Corrected a comment on the LegIK node Change 3621480 by Zak.Middleton #ue4 - Added FTransform::TransformRotation(FQuat) and FTransform::InverseTransformRotation(FQuat). Added matching Blueprint library functions taking FRotator. #jira UE-39088 #github PR 2985 (modified) Change 3621685 by Phillip.Kavan #jira UE-49024 - Add/remove global FiB menu items from the Main Menu when the global FiB option is enabled/disabled. Change summary: - Added FFindInBlueprintSearchManager::EnableGlobalFindResults(). Now using this API to enable/disable both the Main menu items as well as the global FiB workflow change within the BP editor context. - Renamed FFindInBlueprintSearchManager::CloseAllGlobalResults() to CloseOrphanedGlobalFindResultsTabs(). This is now being called to clean up any orphaned global FiB tabs when opening the BP editor context. Change 3622629 by Marc.Audy Reduce memory footprint of UMG/Slate classes: UWidget, UBorder, UImage, UUserWidget, SWidget, SButton, SOverlay, SBoxPanel, SInlineEditableTextBlock, FSlateFontInfo, EVisibility, FSlateBrush, FCheckBoxStyle, FButtonStyle, FComboBoxStyle Change 3622779 by Zak.Middleton #ue4 - Rename USceneComponent::bWorldToComponentUpdated to bComponentToWorldUpdated (since the transform is called ComponentToWorld). #jira none Change 3623020 by Marc.Audy Fix initialization order Change 3623021 by Marc.Audy Reorganize USceneComponent to improve cache coherency Change 3623261 by Ben.Zeigler #jira UE-48555: Fix for corruption of shared pointers by the async loading thread. It is unsafe to copy delegates by value on the async loading threads because they may have shared pointers on them that are being used by the main thread. Instead of copying by value, we now allocate once on the game thread and copy by TUniquePtr. Change 3623294 by Marc.Audy Realign UActorComponent to avoid members crossing cache lines Change 3623383 by Marc.Audy Compress UParticleSystemComponent and fix up cases of members crossing cache lines Change 3623492 by Marc.Audy (4.17.2) Fix pin values on function nodes not correctly carrying the value between reloads/refreshes #jira UE-49189 #jira UE-49196 Change 3623573 by Ben.Zeigler #jira UE-49223 Fix crash when undoing changes to actors that have been recompiled. We need to skip most of PostEditUndo when the class is out of date and this got broken in a recent refactor Change 3623642 by Dan.Oconnor Make sure we don't attempt to defer exports that rely on CDOs that have been regenerated #jira UE-49211 Change 3623719 by Marc.Audy PR #3387: Added new Swap method (blueprint KismetArrayLibrary). (Contributed by RChehowski) #jira UE-42970 Change 3624191 by Marc.Audy Cache GetWorld() Change 3624232 by Marc.Audy Remove accidentally checked in change Change 3624688 by Marc.Audy PR #3491: Client play force feedback can now ignore time dilation. (Contributed by miracle7) Force feedback component can also ignore time dilation #jira UE-44155 Change 3624880 by Marc.Audy PR #3970: SpawnObject not checking for a nullptr causing an editor crash Change 3625740 by Mason.Seay Check in the correct file this time... Change 3625806 by Ben.Zeigler #jira UE-48555 Code review fix for async loading thread fixes, disable an assert when cancel is called in non-EDL, and add comment + assert if Cancel is re-enabled for EDL in the future Change 3626128 by Marc.Audy Fix dragging off component tree in to graph showing an error message #jira UE-49114 Change 3626655 by Ben.Zeigler #jira OR-43846 Fix asset import objects to correctly load off disk again. They aren't marked as SubObjects so the special case code to add the NeedsLoad flag wasn't getting hit. Change it so in the editor it marks all unloaded subobjects as needs load, need to talk to Core about rather this fix should be editor specific or not Change 3626740 by Marc.Audy Fix compile errors when nativizing when a property references a sub object of a dervied type with modified default properties #jira UE-49276 Change 3626831 by Marc.Audy Remove BOM Change 3627162 by Phillip.Kavan #jira UE-49239 - Fix an invalid cast emitted to nativized codegen for converted AnimBP types. - Regression introduced in CL# 3613358. Change 3628051 by Marc.Audy Fix spelling of redundant #jira UE-49343 Change 3596437 by Marc.Audy Don't copy metadata unnecessarily Change 3613302 by Marc.Audy Reduce size of UStaticMeshComponent by 224 bytes (cumulative, 56 bytes exclusive) Reduce size of UPrimitiveComponent by 176 bytes (cumulative, 64 bytes exclusive). Reduce size of USceneComponent by 112 bytes. Reduce size of FLightingChannels from 3 bytes to 1. Reduce size of FBodyInstance by 16 bytes. Change 3620363 by Lukasz.Furman split UBTTask_MoveTo.bStopOnOverlap flag to separate goal & agent parts to match actual parameters of AI move request, added simple versioning for behavior tree nodes copy of CL# 3620248 #ue4 Change 3622569 by Marc.Audy Remove unnecessarily deprecated visibility member and use redirect instead Change 3624879 by Marc.Audy Add a deprecated version of ClientPlayForceFeedback for backwards compatibility. Adjust existing game calls to ClientPlayrForceFeedback to use new API [CL 3628687 by Marc Audy in Main branch]
2017-09-06 14:17:59 -04:00
void UK2Node_MakeContainer::InteractiveAddInputPin()
{
FScopedTransaction Transaction(LOCTEXT("AddPinTx", "Add Pin"));
AddInputPin();
}
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
void UK2Node_MakeContainer::AddInputPin()
{
Modify();
++NumInputs;
const FEdGraphPinType& OutputPinType = GetOutputPin()->PinType;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3716594) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3623720 by Phillip.Kavan #jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build. Change summary: - Temporarily excluded all AnimBP assets from nativization as a workaround. Change 3626305 by Phillip.Kavan #jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default. Change 3629145 by Marc.Audy Don't hide developer nativization tool behind ini Change 3630849 by Marc.Audy Fix nativization uncompilable code when using a non-referenceable term in a switch statement. #jira UE-44085 Change 3631037 by Marc.Audy (4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it #jira UE-49440 Change 3631206 by Marc.Audy Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT("")) Change 3631232 by Marc.Audy Remove outdated diagnostic code throwing false positives #jira UE-47986 Change 3631573 by Marc.Audy Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's' Change 3633168 by Lukasz.Furman fixed behavior tree changing its state during latent abort, modified order of operations during abort to: abort & wait -> change aux nodes -> execute Change 3633609 by Marc.Audy Don't get unneeded string Change 3633691 by Marc.Audy Fix copy-pasting of a collapsed graph containing a map input losing the value type #jira UE-49517 Change 3633967 by Ben.Zeigler Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript Fixed a few other fields to be private that were accidentally made public in 4.17 Change 3633984 by Michael.Noland Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links Change 3634464 by Ben.Zeigler Header cleanups for Pawn, Controller, Character, and PlayerController Change 3636858 by Marc.Audy In preview worlds don't display the light error sprite #jira UE-49555 Change 3636903 by Marc.Audy Fix numerous issues with copy/pasting editable pin bases #jira UE-49532 Change 3638898 by Marc.Audy Allow right-click creation of local variables in blueprint function libraries #jira UE-49590 Change 3639086 by Marc.Audy PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin) #jira UE-49591 Change 3639445 by Marc.Audy Fix mistaken override and virtual markup on niagara schema function. Change 3641202 by Marc.Audy (4.17.2) Fix crash undoing pin changes with split pins #jira UE-49634 Change 3643825 by Marc.Audy (4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted #jira UE-49756 Change 3645110 by mason.seay Fixed up QA-ClickHUD map so it's usable and makes more sense Change 3646428 by Dan.Oconnor Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data #jira None Change 3647298 by Marc.Audy PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist) #jira UE-49748 Change 3647815 by Marc.Audy Minor performance improvements Change 3648931 by Lina.Halper #Compiler : fixed so that each type of BP can provide module info, and compiler info - Moved out AnimBlueprint Compiler - Refactored WidgetBlueprint - DUPE - Merging using ControlRig_Dev-Framework Change 3654310 by Marc.Audy Shrink USkinnedMeshComponent 64 bytes Shrink USkeletalMeshComponent 224 bytes (160 bytes internal) Change 3654636 by Lina.Halper Fix crashing on shutdown #jira: UE-50004 Change 3654960 by Lina.Halper - Fix with automation test of creation/duplication - Fixed shut down crash with editor again due to uobject GCed #jira: UE-50028 Change 3655023 by Ben.Zeigler #jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag Change 3655426 by Ben.Zeigler #jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them Change 3657627 by Ben.Zeigler #jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction Change 3662086 by Mieszko.Zielinski Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4 This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList #jira UE-50101 Change 3662294 by Ben.Zeigler Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check Change 3662825 by Mieszko.Zielinski Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4 there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no Change 3664424 by Marc.Audy UE-50076 test assets #rb none #rnx Change 3664441 by Mieszko.Zielinski PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist) Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated. Change 3664506 by Phillip.Kavan #jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets. Change summary: - UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization. - UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths. - UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished. - UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option). - UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed. - UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead. - UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead. - UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file. - UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file. - UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first). - UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness. - UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed. - UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc. - UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file. - UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string. - UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>. - UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin. - UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed). - UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed). - UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it. - UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished. - UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed. - UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context. - UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail. - UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT). - UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders. Notes: - After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release). - Advanced users and build engineers can override this value per task. Instructions to do that are as follows: - For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line. - When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly. - We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT. - We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above). Change 3665061 by Phillip.Kavan Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum. Mirrored from //UE4/Release-4.18 (CL# 3664993). #3969 #jira UE-49233 Change 3665108 by Marc.Audy (4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted + additional code cleanup #jira UE-50076 Change 3665114 by Marc.Audy Minor change that could potentially improve performance in some cases Change 3665410 by Mieszko.Zielinski Fixed naming of Vislog's BP API #UE4 Change 3665634 by Ben.Zeigler #jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk Change 3666970 by Phillip.Kavan Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8. #jira UE-46814 Change 3667058 by Phillip.Kavan Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage. Mirrored from //UE4/Release-4.18 (CL# 3667043). #jira UE-50403 Change 3667150 by Mieszko.Zielinski PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM) Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend. #jira UE-50249 Change 3667152 by Mieszko.Zielinski PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM) #jira UE-50298 Change 3667166 by Mieszko.Zielinski Fixed FRichCurve baking so that it doesn't loose its curvature #UE4 Also, added some baking sanity checking (like if the range is larger than a single point). Change 3668025 by Dan.Oconnor Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed #jira UE-50453 Change 3672063 by Ben.Zeigler #jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case Change 3672306 by Ben.Zeigler #jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it Change 3672683 by Marc.Audy Code cleanup Change 3672749 by Ben.Zeigler Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build Change 3672831 by Ben.Zeigler #jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId. Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project Change 3673551 by Ben.Zeigler #jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load Change 3675074 by mason.seay Test map for VisLog Testing Change 3675084 by Mieszko.Zielinski Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4 #jira UE-43430 Change 3676490 by Ben.Zeigler #jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset Change 3676579 by Lukasz.Furman fixed crash in behavior tree's search rollback Change 3676586 by Lukasz.Furman added local scope mode to behavior tree's composite nodes Change 3676587 by Ben.Zeigler Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case Add browse, use selected, and clear buttons, and make ID selector font the normal property font Change 3676715 by Lukasz.Furman changed order of behavior tree's aux node ticking Change 3676867 by Ben.Zeigler #jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early Change 3677892 by Ben.Zeigler Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites Change 3678247 by Marc.Audy Fix static analysis warning Change 3678357 by Ben.Zeigler #jira UE-50696 Add some container variables to diff test to track down crashes Change 3678385 by Ben.Zeigler #jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match Change 3678600 by Ben.Zeigler #jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference Change 3679075 by Dan.Oconnor Mirror 3679030 from Release-4.18 Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on #jira UE-48692 Change 3679087 by Dan.Oconnor Filter out unnecessary relink jobs from the compilation manager #jira None Change 3680221 by Ben.Zeigler #jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary Change 3680561 by Lukasz.Furman fixed unsafe StopTree calls in behavior tree #jira nope Change 3680788 by Ben.Zeigler Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind Change 3683001 by mason.seay Submitting various test maps and assets Change 3686837 by Mieszko.Zielinski Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion #jira UE-50857 Change 3688451 by Marc.Audy Fix up new material expression to work with String -> Name refactor Change 3689097 by Mason.Seay Test content for nativization and enum testing Change 3689106 by Mieszko.Zielinski Made NavMeshBoundsVolume react to undo in the editor #Orion #jira UE-51013 Change 3689347 by Mieszko.Zielinski Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4 Manual merge of CL#3689316 over from 4.18 #jira UE-51019 Change 3692524 by mason.seay Moved some assets to folder for org, fixed up redirectors Change 3692540 by mason.seay Renaming test maps so they are clearly indicated for testing nativization Change 3692577 by mason.seay Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed Change 3692724 by mason.seay Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps Change 3693184 by mason.seay Assets for testing nativization with structs Change 3693367 by mason.seay Improvements to test content Change 3695395 by Dan.Oconnor Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced #jira None Change 3695484 by Marc.Audy Fix sound cue connection drawing policy not getting returned. #jira UE-51032 Change 3695494 by mason.seay More test content for nativization testing Change 3697829 by Mieszko.Zielinski PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei) Change 3700541 by mason.seay Test map for containers with function bug Change 3703459 by Marc.Audy Remove poorly named InverseLerp Fix degenerate behavior returning bad value #jira UE-50295 Change 3703803 by Marc.Audy Clean up autos Minor improvement to ShouldGenerateCluster Change 3704496 by Mason.Seay More test content for testing nativization Change 3706314 by Marc.Audy PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar) #jira UE-50874 Change 3707502 by Mason.Seay Final changes to nativization test content (hopefully) Change 3709478 by Marc.Audy PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel) Same as CL# 3689702 implemented in Fortnite #jira UE-51453 Change 3709967 by Marc.Audy PR #4139: fixed a typo in a comment (Contributed by derekvanvliet) #jira UE-51372 Change 3709970 by Marc.Audy PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman) #jira UE-51495 Change 3709971 by Marc.Audy PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas) #jira UE-51492 Change 3710041 by Marc.Audy Minor code cleanup Change 3711223 by Phillip.Kavan Move some Blueprint nativization log spam into the verbose category. #jira UE-49770 Change 3713398 by Marc.Audy PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM) #jira UE-51517 Change 3713601 by Marc.Audy Fix merge error Change 3713994 by Marc.Audy (4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event. #jira UE-50738 Change 3714270 by Marc.Audy Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors #jira UE-51534 Change 3714406 by Marc.Audy Fix dumb inverted boolean check Change 3716594 by Dan.Oconnor Integrate 3681301 from 4.18 Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior #jira UE-50780, UE-51568 Change 3686450 by Marc.Audy PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString. CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither. CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters. Material Expressions now store input and output names as FName instead of FString FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString Most existing pin related functions using string have been deprecated. Change 3713796 by Marc.Audy Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not. IsTickable no longer a pure virtual (defaults to true). Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject. Change 3638554 by Marc.Audy Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected. Change 3676502 by Ben.Zeigler Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635 [CL 3718205 by Marc Audy in Main branch]
2017-10-25 09:30:36 -04:00
UEdGraphPin* Pin = CreatePin(EGPD_Input, OutputPinType.PinCategory, OutputPinType.PinSubCategory, OutputPinType.PinSubCategoryObject.Get(), GetPinName(NumInputs-1));
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
GetDefault<UEdGraphSchema_K2>()->SetPinAutogeneratedDefaultValueBasedOnType(Pin);
const bool bIsCompiling = GetBlueprint()->bBeingCompiled;
if( !bIsCompiling )
{
FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified(GetBlueprint());
}
}
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3716594) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3623720 by Phillip.Kavan #jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build. Change summary: - Temporarily excluded all AnimBP assets from nativization as a workaround. Change 3626305 by Phillip.Kavan #jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default. Change 3629145 by Marc.Audy Don't hide developer nativization tool behind ini Change 3630849 by Marc.Audy Fix nativization uncompilable code when using a non-referenceable term in a switch statement. #jira UE-44085 Change 3631037 by Marc.Audy (4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it #jira UE-49440 Change 3631206 by Marc.Audy Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT("")) Change 3631232 by Marc.Audy Remove outdated diagnostic code throwing false positives #jira UE-47986 Change 3631573 by Marc.Audy Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's' Change 3633168 by Lukasz.Furman fixed behavior tree changing its state during latent abort, modified order of operations during abort to: abort & wait -> change aux nodes -> execute Change 3633609 by Marc.Audy Don't get unneeded string Change 3633691 by Marc.Audy Fix copy-pasting of a collapsed graph containing a map input losing the value type #jira UE-49517 Change 3633967 by Ben.Zeigler Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript Fixed a few other fields to be private that were accidentally made public in 4.17 Change 3633984 by Michael.Noland Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links Change 3634464 by Ben.Zeigler Header cleanups for Pawn, Controller, Character, and PlayerController Change 3636858 by Marc.Audy In preview worlds don't display the light error sprite #jira UE-49555 Change 3636903 by Marc.Audy Fix numerous issues with copy/pasting editable pin bases #jira UE-49532 Change 3638898 by Marc.Audy Allow right-click creation of local variables in blueprint function libraries #jira UE-49590 Change 3639086 by Marc.Audy PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin) #jira UE-49591 Change 3639445 by Marc.Audy Fix mistaken override and virtual markup on niagara schema function. Change 3641202 by Marc.Audy (4.17.2) Fix crash undoing pin changes with split pins #jira UE-49634 Change 3643825 by Marc.Audy (4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted #jira UE-49756 Change 3645110 by mason.seay Fixed up QA-ClickHUD map so it's usable and makes more sense Change 3646428 by Dan.Oconnor Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data #jira None Change 3647298 by Marc.Audy PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist) #jira UE-49748 Change 3647815 by Marc.Audy Minor performance improvements Change 3648931 by Lina.Halper #Compiler : fixed so that each type of BP can provide module info, and compiler info - Moved out AnimBlueprint Compiler - Refactored WidgetBlueprint - DUPE - Merging using ControlRig_Dev-Framework Change 3654310 by Marc.Audy Shrink USkinnedMeshComponent 64 bytes Shrink USkeletalMeshComponent 224 bytes (160 bytes internal) Change 3654636 by Lina.Halper Fix crashing on shutdown #jira: UE-50004 Change 3654960 by Lina.Halper - Fix with automation test of creation/duplication - Fixed shut down crash with editor again due to uobject GCed #jira: UE-50028 Change 3655023 by Ben.Zeigler #jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag Change 3655426 by Ben.Zeigler #jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them Change 3657627 by Ben.Zeigler #jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction Change 3662086 by Mieszko.Zielinski Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4 This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList #jira UE-50101 Change 3662294 by Ben.Zeigler Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check Change 3662825 by Mieszko.Zielinski Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4 there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no Change 3664424 by Marc.Audy UE-50076 test assets #rb none #rnx Change 3664441 by Mieszko.Zielinski PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist) Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated. Change 3664506 by Phillip.Kavan #jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets. Change summary: - UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization. - UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths. - UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished. - UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option). - UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed. - UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead. - UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead. - UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file. - UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file. - UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first). - UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness. - UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed. - UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc. - UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file. - UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string. - UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>. - UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin. - UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed). - UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed). - UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it. - UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished. - UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed. - UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context. - UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail. - UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT). - UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders. Notes: - After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release). - Advanced users and build engineers can override this value per task. Instructions to do that are as follows: - For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line. - When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly. - We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT. - We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above). Change 3665061 by Phillip.Kavan Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum. Mirrored from //UE4/Release-4.18 (CL# 3664993). #3969 #jira UE-49233 Change 3665108 by Marc.Audy (4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted + additional code cleanup #jira UE-50076 Change 3665114 by Marc.Audy Minor change that could potentially improve performance in some cases Change 3665410 by Mieszko.Zielinski Fixed naming of Vislog's BP API #UE4 Change 3665634 by Ben.Zeigler #jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk Change 3666970 by Phillip.Kavan Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8. #jira UE-46814 Change 3667058 by Phillip.Kavan Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage. Mirrored from //UE4/Release-4.18 (CL# 3667043). #jira UE-50403 Change 3667150 by Mieszko.Zielinski PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM) Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend. #jira UE-50249 Change 3667152 by Mieszko.Zielinski PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM) #jira UE-50298 Change 3667166 by Mieszko.Zielinski Fixed FRichCurve baking so that it doesn't loose its curvature #UE4 Also, added some baking sanity checking (like if the range is larger than a single point). Change 3668025 by Dan.Oconnor Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed #jira UE-50453 Change 3672063 by Ben.Zeigler #jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case Change 3672306 by Ben.Zeigler #jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it Change 3672683 by Marc.Audy Code cleanup Change 3672749 by Ben.Zeigler Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build Change 3672831 by Ben.Zeigler #jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId. Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project Change 3673551 by Ben.Zeigler #jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load Change 3675074 by mason.seay Test map for VisLog Testing Change 3675084 by Mieszko.Zielinski Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4 #jira UE-43430 Change 3676490 by Ben.Zeigler #jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset Change 3676579 by Lukasz.Furman fixed crash in behavior tree's search rollback Change 3676586 by Lukasz.Furman added local scope mode to behavior tree's composite nodes Change 3676587 by Ben.Zeigler Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case Add browse, use selected, and clear buttons, and make ID selector font the normal property font Change 3676715 by Lukasz.Furman changed order of behavior tree's aux node ticking Change 3676867 by Ben.Zeigler #jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early Change 3677892 by Ben.Zeigler Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites Change 3678247 by Marc.Audy Fix static analysis warning Change 3678357 by Ben.Zeigler #jira UE-50696 Add some container variables to diff test to track down crashes Change 3678385 by Ben.Zeigler #jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match Change 3678600 by Ben.Zeigler #jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference Change 3679075 by Dan.Oconnor Mirror 3679030 from Release-4.18 Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on #jira UE-48692 Change 3679087 by Dan.Oconnor Filter out unnecessary relink jobs from the compilation manager #jira None Change 3680221 by Ben.Zeigler #jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary Change 3680561 by Lukasz.Furman fixed unsafe StopTree calls in behavior tree #jira nope Change 3680788 by Ben.Zeigler Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind Change 3683001 by mason.seay Submitting various test maps and assets Change 3686837 by Mieszko.Zielinski Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion #jira UE-50857 Change 3688451 by Marc.Audy Fix up new material expression to work with String -> Name refactor Change 3689097 by Mason.Seay Test content for nativization and enum testing Change 3689106 by Mieszko.Zielinski Made NavMeshBoundsVolume react to undo in the editor #Orion #jira UE-51013 Change 3689347 by Mieszko.Zielinski Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4 Manual merge of CL#3689316 over from 4.18 #jira UE-51019 Change 3692524 by mason.seay Moved some assets to folder for org, fixed up redirectors Change 3692540 by mason.seay Renaming test maps so they are clearly indicated for testing nativization Change 3692577 by mason.seay Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed Change 3692724 by mason.seay Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps Change 3693184 by mason.seay Assets for testing nativization with structs Change 3693367 by mason.seay Improvements to test content Change 3695395 by Dan.Oconnor Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced #jira None Change 3695484 by Marc.Audy Fix sound cue connection drawing policy not getting returned. #jira UE-51032 Change 3695494 by mason.seay More test content for nativization testing Change 3697829 by Mieszko.Zielinski PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei) Change 3700541 by mason.seay Test map for containers with function bug Change 3703459 by Marc.Audy Remove poorly named InverseLerp Fix degenerate behavior returning bad value #jira UE-50295 Change 3703803 by Marc.Audy Clean up autos Minor improvement to ShouldGenerateCluster Change 3704496 by Mason.Seay More test content for testing nativization Change 3706314 by Marc.Audy PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar) #jira UE-50874 Change 3707502 by Mason.Seay Final changes to nativization test content (hopefully) Change 3709478 by Marc.Audy PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel) Same as CL# 3689702 implemented in Fortnite #jira UE-51453 Change 3709967 by Marc.Audy PR #4139: fixed a typo in a comment (Contributed by derekvanvliet) #jira UE-51372 Change 3709970 by Marc.Audy PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman) #jira UE-51495 Change 3709971 by Marc.Audy PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas) #jira UE-51492 Change 3710041 by Marc.Audy Minor code cleanup Change 3711223 by Phillip.Kavan Move some Blueprint nativization log spam into the verbose category. #jira UE-49770 Change 3713398 by Marc.Audy PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM) #jira UE-51517 Change 3713601 by Marc.Audy Fix merge error Change 3713994 by Marc.Audy (4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event. #jira UE-50738 Change 3714270 by Marc.Audy Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors #jira UE-51534 Change 3714406 by Marc.Audy Fix dumb inverted boolean check Change 3716594 by Dan.Oconnor Integrate 3681301 from 4.18 Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior #jira UE-50780, UE-51568 Change 3686450 by Marc.Audy PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString. CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither. CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters. Material Expressions now store input and output names as FName instead of FString FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString Most existing pin related functions using string have been deprecated. Change 3713796 by Marc.Audy Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not. IsTickable no longer a pure virtual (defaults to true). Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject. Change 3638554 by Marc.Audy Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected. Change 3676502 by Ben.Zeigler Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635 [CL 3718205 by Marc Audy in Main branch]
2017-10-25 09:30:36 -04:00
FName UK2Node_MakeContainer::GetPinName(const int32 PinIndex) const
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
{
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3716594) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3623720 by Phillip.Kavan #jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build. Change summary: - Temporarily excluded all AnimBP assets from nativization as a workaround. Change 3626305 by Phillip.Kavan #jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default. Change 3629145 by Marc.Audy Don't hide developer nativization tool behind ini Change 3630849 by Marc.Audy Fix nativization uncompilable code when using a non-referenceable term in a switch statement. #jira UE-44085 Change 3631037 by Marc.Audy (4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it #jira UE-49440 Change 3631206 by Marc.Audy Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT("")) Change 3631232 by Marc.Audy Remove outdated diagnostic code throwing false positives #jira UE-47986 Change 3631573 by Marc.Audy Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's' Change 3633168 by Lukasz.Furman fixed behavior tree changing its state during latent abort, modified order of operations during abort to: abort & wait -> change aux nodes -> execute Change 3633609 by Marc.Audy Don't get unneeded string Change 3633691 by Marc.Audy Fix copy-pasting of a collapsed graph containing a map input losing the value type #jira UE-49517 Change 3633967 by Ben.Zeigler Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript Fixed a few other fields to be private that were accidentally made public in 4.17 Change 3633984 by Michael.Noland Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links Change 3634464 by Ben.Zeigler Header cleanups for Pawn, Controller, Character, and PlayerController Change 3636858 by Marc.Audy In preview worlds don't display the light error sprite #jira UE-49555 Change 3636903 by Marc.Audy Fix numerous issues with copy/pasting editable pin bases #jira UE-49532 Change 3638898 by Marc.Audy Allow right-click creation of local variables in blueprint function libraries #jira UE-49590 Change 3639086 by Marc.Audy PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin) #jira UE-49591 Change 3639445 by Marc.Audy Fix mistaken override and virtual markup on niagara schema function. Change 3641202 by Marc.Audy (4.17.2) Fix crash undoing pin changes with split pins #jira UE-49634 Change 3643825 by Marc.Audy (4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted #jira UE-49756 Change 3645110 by mason.seay Fixed up QA-ClickHUD map so it's usable and makes more sense Change 3646428 by Dan.Oconnor Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data #jira None Change 3647298 by Marc.Audy PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist) #jira UE-49748 Change 3647815 by Marc.Audy Minor performance improvements Change 3648931 by Lina.Halper #Compiler : fixed so that each type of BP can provide module info, and compiler info - Moved out AnimBlueprint Compiler - Refactored WidgetBlueprint - DUPE - Merging using ControlRig_Dev-Framework Change 3654310 by Marc.Audy Shrink USkinnedMeshComponent 64 bytes Shrink USkeletalMeshComponent 224 bytes (160 bytes internal) Change 3654636 by Lina.Halper Fix crashing on shutdown #jira: UE-50004 Change 3654960 by Lina.Halper - Fix with automation test of creation/duplication - Fixed shut down crash with editor again due to uobject GCed #jira: UE-50028 Change 3655023 by Ben.Zeigler #jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag Change 3655426 by Ben.Zeigler #jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them Change 3657627 by Ben.Zeigler #jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction Change 3662086 by Mieszko.Zielinski Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4 This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList #jira UE-50101 Change 3662294 by Ben.Zeigler Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check Change 3662825 by Mieszko.Zielinski Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4 there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no Change 3664424 by Marc.Audy UE-50076 test assets #rb none #rnx Change 3664441 by Mieszko.Zielinski PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist) Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated. Change 3664506 by Phillip.Kavan #jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets. Change summary: - UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization. - UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths. - UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished. - UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option). - UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed. - UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead. - UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead. - UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file. - UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file. - UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first). - UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness. - UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed. - UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc. - UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file. - UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string. - UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>. - UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin. - UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed). - UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed). - UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it. - UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished. - UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed. - UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context. - UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail. - UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT). - UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders. Notes: - After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release). - Advanced users and build engineers can override this value per task. Instructions to do that are as follows: - For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line. - When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly. - We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT. - We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above). Change 3665061 by Phillip.Kavan Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum. Mirrored from //UE4/Release-4.18 (CL# 3664993). #3969 #jira UE-49233 Change 3665108 by Marc.Audy (4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted + additional code cleanup #jira UE-50076 Change 3665114 by Marc.Audy Minor change that could potentially improve performance in some cases Change 3665410 by Mieszko.Zielinski Fixed naming of Vislog's BP API #UE4 Change 3665634 by Ben.Zeigler #jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk Change 3666970 by Phillip.Kavan Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8. #jira UE-46814 Change 3667058 by Phillip.Kavan Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage. Mirrored from //UE4/Release-4.18 (CL# 3667043). #jira UE-50403 Change 3667150 by Mieszko.Zielinski PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM) Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend. #jira UE-50249 Change 3667152 by Mieszko.Zielinski PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM) #jira UE-50298 Change 3667166 by Mieszko.Zielinski Fixed FRichCurve baking so that it doesn't loose its curvature #UE4 Also, added some baking sanity checking (like if the range is larger than a single point). Change 3668025 by Dan.Oconnor Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed #jira UE-50453 Change 3672063 by Ben.Zeigler #jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case Change 3672306 by Ben.Zeigler #jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it Change 3672683 by Marc.Audy Code cleanup Change 3672749 by Ben.Zeigler Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build Change 3672831 by Ben.Zeigler #jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId. Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project Change 3673551 by Ben.Zeigler #jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load Change 3675074 by mason.seay Test map for VisLog Testing Change 3675084 by Mieszko.Zielinski Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4 #jira UE-43430 Change 3676490 by Ben.Zeigler #jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset Change 3676579 by Lukasz.Furman fixed crash in behavior tree's search rollback Change 3676586 by Lukasz.Furman added local scope mode to behavior tree's composite nodes Change 3676587 by Ben.Zeigler Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case Add browse, use selected, and clear buttons, and make ID selector font the normal property font Change 3676715 by Lukasz.Furman changed order of behavior tree's aux node ticking Change 3676867 by Ben.Zeigler #jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early Change 3677892 by Ben.Zeigler Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites Change 3678247 by Marc.Audy Fix static analysis warning Change 3678357 by Ben.Zeigler #jira UE-50696 Add some container variables to diff test to track down crashes Change 3678385 by Ben.Zeigler #jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match Change 3678600 by Ben.Zeigler #jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference Change 3679075 by Dan.Oconnor Mirror 3679030 from Release-4.18 Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on #jira UE-48692 Change 3679087 by Dan.Oconnor Filter out unnecessary relink jobs from the compilation manager #jira None Change 3680221 by Ben.Zeigler #jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary Change 3680561 by Lukasz.Furman fixed unsafe StopTree calls in behavior tree #jira nope Change 3680788 by Ben.Zeigler Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind Change 3683001 by mason.seay Submitting various test maps and assets Change 3686837 by Mieszko.Zielinski Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion #jira UE-50857 Change 3688451 by Marc.Audy Fix up new material expression to work with String -> Name refactor Change 3689097 by Mason.Seay Test content for nativization and enum testing Change 3689106 by Mieszko.Zielinski Made NavMeshBoundsVolume react to undo in the editor #Orion #jira UE-51013 Change 3689347 by Mieszko.Zielinski Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4 Manual merge of CL#3689316 over from 4.18 #jira UE-51019 Change 3692524 by mason.seay Moved some assets to folder for org, fixed up redirectors Change 3692540 by mason.seay Renaming test maps so they are clearly indicated for testing nativization Change 3692577 by mason.seay Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed Change 3692724 by mason.seay Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps Change 3693184 by mason.seay Assets for testing nativization with structs Change 3693367 by mason.seay Improvements to test content Change 3695395 by Dan.Oconnor Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced #jira None Change 3695484 by Marc.Audy Fix sound cue connection drawing policy not getting returned. #jira UE-51032 Change 3695494 by mason.seay More test content for nativization testing Change 3697829 by Mieszko.Zielinski PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei) Change 3700541 by mason.seay Test map for containers with function bug Change 3703459 by Marc.Audy Remove poorly named InverseLerp Fix degenerate behavior returning bad value #jira UE-50295 Change 3703803 by Marc.Audy Clean up autos Minor improvement to ShouldGenerateCluster Change 3704496 by Mason.Seay More test content for testing nativization Change 3706314 by Marc.Audy PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar) #jira UE-50874 Change 3707502 by Mason.Seay Final changes to nativization test content (hopefully) Change 3709478 by Marc.Audy PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel) Same as CL# 3689702 implemented in Fortnite #jira UE-51453 Change 3709967 by Marc.Audy PR #4139: fixed a typo in a comment (Contributed by derekvanvliet) #jira UE-51372 Change 3709970 by Marc.Audy PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman) #jira UE-51495 Change 3709971 by Marc.Audy PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas) #jira UE-51492 Change 3710041 by Marc.Audy Minor code cleanup Change 3711223 by Phillip.Kavan Move some Blueprint nativization log spam into the verbose category. #jira UE-49770 Change 3713398 by Marc.Audy PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM) #jira UE-51517 Change 3713601 by Marc.Audy Fix merge error Change 3713994 by Marc.Audy (4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event. #jira UE-50738 Change 3714270 by Marc.Audy Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors #jira UE-51534 Change 3714406 by Marc.Audy Fix dumb inverted boolean check Change 3716594 by Dan.Oconnor Integrate 3681301 from 4.18 Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior #jira UE-50780, UE-51568 Change 3686450 by Marc.Audy PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString. CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither. CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters. Material Expressions now store input and output names as FName instead of FString FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString Most existing pin related functions using string have been deprecated. Change 3713796 by Marc.Audy Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not. IsTickable no longer a pure virtual (defaults to true). Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject. Change 3638554 by Marc.Audy Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected. Change 3676502 by Ben.Zeigler Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635 [CL 3718205 by Marc Audy in Main branch]
2017-10-25 09:30:36 -04:00
return *FString::Printf(TEXT("[%d]"), PinIndex);
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
}
void UK2Node_MakeContainer::SyncPinNames()
{
int32 CurrentNumParentPins = 0;
for (int32 PinIndex = 0; PinIndex < Pins.Num(); ++PinIndex)
{
UEdGraphPin*& CurrentPin = Pins[PinIndex];
if (CurrentPin->Direction == EGPD_Input &&
CurrentPin->ParentPin == nullptr)
{
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3716594) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3623720 by Phillip.Kavan #jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build. Change summary: - Temporarily excluded all AnimBP assets from nativization as a workaround. Change 3626305 by Phillip.Kavan #jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default. Change 3629145 by Marc.Audy Don't hide developer nativization tool behind ini Change 3630849 by Marc.Audy Fix nativization uncompilable code when using a non-referenceable term in a switch statement. #jira UE-44085 Change 3631037 by Marc.Audy (4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it #jira UE-49440 Change 3631206 by Marc.Audy Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT("")) Change 3631232 by Marc.Audy Remove outdated diagnostic code throwing false positives #jira UE-47986 Change 3631573 by Marc.Audy Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's' Change 3633168 by Lukasz.Furman fixed behavior tree changing its state during latent abort, modified order of operations during abort to: abort & wait -> change aux nodes -> execute Change 3633609 by Marc.Audy Don't get unneeded string Change 3633691 by Marc.Audy Fix copy-pasting of a collapsed graph containing a map input losing the value type #jira UE-49517 Change 3633967 by Ben.Zeigler Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript Fixed a few other fields to be private that were accidentally made public in 4.17 Change 3633984 by Michael.Noland Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links Change 3634464 by Ben.Zeigler Header cleanups for Pawn, Controller, Character, and PlayerController Change 3636858 by Marc.Audy In preview worlds don't display the light error sprite #jira UE-49555 Change 3636903 by Marc.Audy Fix numerous issues with copy/pasting editable pin bases #jira UE-49532 Change 3638898 by Marc.Audy Allow right-click creation of local variables in blueprint function libraries #jira UE-49590 Change 3639086 by Marc.Audy PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin) #jira UE-49591 Change 3639445 by Marc.Audy Fix mistaken override and virtual markup on niagara schema function. Change 3641202 by Marc.Audy (4.17.2) Fix crash undoing pin changes with split pins #jira UE-49634 Change 3643825 by Marc.Audy (4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted #jira UE-49756 Change 3645110 by mason.seay Fixed up QA-ClickHUD map so it's usable and makes more sense Change 3646428 by Dan.Oconnor Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data #jira None Change 3647298 by Marc.Audy PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist) #jira UE-49748 Change 3647815 by Marc.Audy Minor performance improvements Change 3648931 by Lina.Halper #Compiler : fixed so that each type of BP can provide module info, and compiler info - Moved out AnimBlueprint Compiler - Refactored WidgetBlueprint - DUPE - Merging using ControlRig_Dev-Framework Change 3654310 by Marc.Audy Shrink USkinnedMeshComponent 64 bytes Shrink USkeletalMeshComponent 224 bytes (160 bytes internal) Change 3654636 by Lina.Halper Fix crashing on shutdown #jira: UE-50004 Change 3654960 by Lina.Halper - Fix with automation test of creation/duplication - Fixed shut down crash with editor again due to uobject GCed #jira: UE-50028 Change 3655023 by Ben.Zeigler #jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag Change 3655426 by Ben.Zeigler #jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them Change 3657627 by Ben.Zeigler #jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction Change 3662086 by Mieszko.Zielinski Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4 This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList #jira UE-50101 Change 3662294 by Ben.Zeigler Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check Change 3662825 by Mieszko.Zielinski Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4 there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no Change 3664424 by Marc.Audy UE-50076 test assets #rb none #rnx Change 3664441 by Mieszko.Zielinski PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist) Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated. Change 3664506 by Phillip.Kavan #jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets. Change summary: - UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization. - UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths. - UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished. - UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option). - UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed. - UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead. - UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead. - UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file. - UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file. - UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first). - UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness. - UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed. - UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc. - UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file. - UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string. - UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>. - UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin. - UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed). - UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed). - UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it. - UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished. - UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed. - UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context. - UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail. - UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT). - UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders. Notes: - After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release). - Advanced users and build engineers can override this value per task. Instructions to do that are as follows: - For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line. - When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly. - We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT. - We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above). Change 3665061 by Phillip.Kavan Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum. Mirrored from //UE4/Release-4.18 (CL# 3664993). #3969 #jira UE-49233 Change 3665108 by Marc.Audy (4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted + additional code cleanup #jira UE-50076 Change 3665114 by Marc.Audy Minor change that could potentially improve performance in some cases Change 3665410 by Mieszko.Zielinski Fixed naming of Vislog's BP API #UE4 Change 3665634 by Ben.Zeigler #jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk Change 3666970 by Phillip.Kavan Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8. #jira UE-46814 Change 3667058 by Phillip.Kavan Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage. Mirrored from //UE4/Release-4.18 (CL# 3667043). #jira UE-50403 Change 3667150 by Mieszko.Zielinski PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM) Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend. #jira UE-50249 Change 3667152 by Mieszko.Zielinski PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM) #jira UE-50298 Change 3667166 by Mieszko.Zielinski Fixed FRichCurve baking so that it doesn't loose its curvature #UE4 Also, added some baking sanity checking (like if the range is larger than a single point). Change 3668025 by Dan.Oconnor Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed #jira UE-50453 Change 3672063 by Ben.Zeigler #jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case Change 3672306 by Ben.Zeigler #jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it Change 3672683 by Marc.Audy Code cleanup Change 3672749 by Ben.Zeigler Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build Change 3672831 by Ben.Zeigler #jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId. Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project Change 3673551 by Ben.Zeigler #jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load Change 3675074 by mason.seay Test map for VisLog Testing Change 3675084 by Mieszko.Zielinski Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4 #jira UE-43430 Change 3676490 by Ben.Zeigler #jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset Change 3676579 by Lukasz.Furman fixed crash in behavior tree's search rollback Change 3676586 by Lukasz.Furman added local scope mode to behavior tree's composite nodes Change 3676587 by Ben.Zeigler Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case Add browse, use selected, and clear buttons, and make ID selector font the normal property font Change 3676715 by Lukasz.Furman changed order of behavior tree's aux node ticking Change 3676867 by Ben.Zeigler #jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early Change 3677892 by Ben.Zeigler Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites Change 3678247 by Marc.Audy Fix static analysis warning Change 3678357 by Ben.Zeigler #jira UE-50696 Add some container variables to diff test to track down crashes Change 3678385 by Ben.Zeigler #jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match Change 3678600 by Ben.Zeigler #jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference Change 3679075 by Dan.Oconnor Mirror 3679030 from Release-4.18 Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on #jira UE-48692 Change 3679087 by Dan.Oconnor Filter out unnecessary relink jobs from the compilation manager #jira None Change 3680221 by Ben.Zeigler #jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary Change 3680561 by Lukasz.Furman fixed unsafe StopTree calls in behavior tree #jira nope Change 3680788 by Ben.Zeigler Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind Change 3683001 by mason.seay Submitting various test maps and assets Change 3686837 by Mieszko.Zielinski Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion #jira UE-50857 Change 3688451 by Marc.Audy Fix up new material expression to work with String -> Name refactor Change 3689097 by Mason.Seay Test content for nativization and enum testing Change 3689106 by Mieszko.Zielinski Made NavMeshBoundsVolume react to undo in the editor #Orion #jira UE-51013 Change 3689347 by Mieszko.Zielinski Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4 Manual merge of CL#3689316 over from 4.18 #jira UE-51019 Change 3692524 by mason.seay Moved some assets to folder for org, fixed up redirectors Change 3692540 by mason.seay Renaming test maps so they are clearly indicated for testing nativization Change 3692577 by mason.seay Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed Change 3692724 by mason.seay Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps Change 3693184 by mason.seay Assets for testing nativization with structs Change 3693367 by mason.seay Improvements to test content Change 3695395 by Dan.Oconnor Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced #jira None Change 3695484 by Marc.Audy Fix sound cue connection drawing policy not getting returned. #jira UE-51032 Change 3695494 by mason.seay More test content for nativization testing Change 3697829 by Mieszko.Zielinski PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei) Change 3700541 by mason.seay Test map for containers with function bug Change 3703459 by Marc.Audy Remove poorly named InverseLerp Fix degenerate behavior returning bad value #jira UE-50295 Change 3703803 by Marc.Audy Clean up autos Minor improvement to ShouldGenerateCluster Change 3704496 by Mason.Seay More test content for testing nativization Change 3706314 by Marc.Audy PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar) #jira UE-50874 Change 3707502 by Mason.Seay Final changes to nativization test content (hopefully) Change 3709478 by Marc.Audy PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel) Same as CL# 3689702 implemented in Fortnite #jira UE-51453 Change 3709967 by Marc.Audy PR #4139: fixed a typo in a comment (Contributed by derekvanvliet) #jira UE-51372 Change 3709970 by Marc.Audy PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman) #jira UE-51495 Change 3709971 by Marc.Audy PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas) #jira UE-51492 Change 3710041 by Marc.Audy Minor code cleanup Change 3711223 by Phillip.Kavan Move some Blueprint nativization log spam into the verbose category. #jira UE-49770 Change 3713398 by Marc.Audy PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM) #jira UE-51517 Change 3713601 by Marc.Audy Fix merge error Change 3713994 by Marc.Audy (4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event. #jira UE-50738 Change 3714270 by Marc.Audy Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors #jira UE-51534 Change 3714406 by Marc.Audy Fix dumb inverted boolean check Change 3716594 by Dan.Oconnor Integrate 3681301 from 4.18 Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior #jira UE-50780, UE-51568 Change 3686450 by Marc.Audy PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString. CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither. CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters. Material Expressions now store input and output names as FName instead of FString FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString Most existing pin related functions using string have been deprecated. Change 3713796 by Marc.Audy Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not. IsTickable no longer a pure virtual (defaults to true). Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject. Change 3638554 by Marc.Audy Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected. Change 3676502 by Ben.Zeigler Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635 [CL 3718205 by Marc Audy in Main branch]
2017-10-25 09:30:36 -04:00
const FName OldName = CurrentPin->PinName;
const FName ElementName = GetPinName(CurrentNumParentPins++);
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
CurrentPin->Modify();
CurrentPin->PinName = ElementName;
if (CurrentPin->SubPins.Num() > 0)
{
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3716594) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3623720 by Phillip.Kavan #jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build. Change summary: - Temporarily excluded all AnimBP assets from nativization as a workaround. Change 3626305 by Phillip.Kavan #jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default. Change 3629145 by Marc.Audy Don't hide developer nativization tool behind ini Change 3630849 by Marc.Audy Fix nativization uncompilable code when using a non-referenceable term in a switch statement. #jira UE-44085 Change 3631037 by Marc.Audy (4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it #jira UE-49440 Change 3631206 by Marc.Audy Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT("")) Change 3631232 by Marc.Audy Remove outdated diagnostic code throwing false positives #jira UE-47986 Change 3631573 by Marc.Audy Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's' Change 3633168 by Lukasz.Furman fixed behavior tree changing its state during latent abort, modified order of operations during abort to: abort & wait -> change aux nodes -> execute Change 3633609 by Marc.Audy Don't get unneeded string Change 3633691 by Marc.Audy Fix copy-pasting of a collapsed graph containing a map input losing the value type #jira UE-49517 Change 3633967 by Ben.Zeigler Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript Fixed a few other fields to be private that were accidentally made public in 4.17 Change 3633984 by Michael.Noland Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links Change 3634464 by Ben.Zeigler Header cleanups for Pawn, Controller, Character, and PlayerController Change 3636858 by Marc.Audy In preview worlds don't display the light error sprite #jira UE-49555 Change 3636903 by Marc.Audy Fix numerous issues with copy/pasting editable pin bases #jira UE-49532 Change 3638898 by Marc.Audy Allow right-click creation of local variables in blueprint function libraries #jira UE-49590 Change 3639086 by Marc.Audy PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin) #jira UE-49591 Change 3639445 by Marc.Audy Fix mistaken override and virtual markup on niagara schema function. Change 3641202 by Marc.Audy (4.17.2) Fix crash undoing pin changes with split pins #jira UE-49634 Change 3643825 by Marc.Audy (4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted #jira UE-49756 Change 3645110 by mason.seay Fixed up QA-ClickHUD map so it's usable and makes more sense Change 3646428 by Dan.Oconnor Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data #jira None Change 3647298 by Marc.Audy PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist) #jira UE-49748 Change 3647815 by Marc.Audy Minor performance improvements Change 3648931 by Lina.Halper #Compiler : fixed so that each type of BP can provide module info, and compiler info - Moved out AnimBlueprint Compiler - Refactored WidgetBlueprint - DUPE - Merging using ControlRig_Dev-Framework Change 3654310 by Marc.Audy Shrink USkinnedMeshComponent 64 bytes Shrink USkeletalMeshComponent 224 bytes (160 bytes internal) Change 3654636 by Lina.Halper Fix crashing on shutdown #jira: UE-50004 Change 3654960 by Lina.Halper - Fix with automation test of creation/duplication - Fixed shut down crash with editor again due to uobject GCed #jira: UE-50028 Change 3655023 by Ben.Zeigler #jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag Change 3655426 by Ben.Zeigler #jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them Change 3657627 by Ben.Zeigler #jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction Change 3662086 by Mieszko.Zielinski Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4 This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList #jira UE-50101 Change 3662294 by Ben.Zeigler Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check Change 3662825 by Mieszko.Zielinski Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4 there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no Change 3664424 by Marc.Audy UE-50076 test assets #rb none #rnx Change 3664441 by Mieszko.Zielinski PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist) Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated. Change 3664506 by Phillip.Kavan #jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets. Change summary: - UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization. - UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths. - UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished. - UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option). - UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed. - UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead. - UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead. - UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file. - UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file. - UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first). - UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness. - UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed. - UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc. - UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file. - UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string. - UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>. - UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin. - UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed). - UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed). - UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it. - UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished. - UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed. - UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context. - UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail. - UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT). - UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders. Notes: - After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release). - Advanced users and build engineers can override this value per task. Instructions to do that are as follows: - For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line. - When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly. - We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT. - We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above). Change 3665061 by Phillip.Kavan Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum. Mirrored from //UE4/Release-4.18 (CL# 3664993). #3969 #jira UE-49233 Change 3665108 by Marc.Audy (4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted + additional code cleanup #jira UE-50076 Change 3665114 by Marc.Audy Minor change that could potentially improve performance in some cases Change 3665410 by Mieszko.Zielinski Fixed naming of Vislog's BP API #UE4 Change 3665634 by Ben.Zeigler #jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk Change 3666970 by Phillip.Kavan Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8. #jira UE-46814 Change 3667058 by Phillip.Kavan Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage. Mirrored from //UE4/Release-4.18 (CL# 3667043). #jira UE-50403 Change 3667150 by Mieszko.Zielinski PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM) Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend. #jira UE-50249 Change 3667152 by Mieszko.Zielinski PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM) #jira UE-50298 Change 3667166 by Mieszko.Zielinski Fixed FRichCurve baking so that it doesn't loose its curvature #UE4 Also, added some baking sanity checking (like if the range is larger than a single point). Change 3668025 by Dan.Oconnor Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed #jira UE-50453 Change 3672063 by Ben.Zeigler #jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case Change 3672306 by Ben.Zeigler #jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it Change 3672683 by Marc.Audy Code cleanup Change 3672749 by Ben.Zeigler Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build Change 3672831 by Ben.Zeigler #jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId. Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project Change 3673551 by Ben.Zeigler #jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load Change 3675074 by mason.seay Test map for VisLog Testing Change 3675084 by Mieszko.Zielinski Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4 #jira UE-43430 Change 3676490 by Ben.Zeigler #jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset Change 3676579 by Lukasz.Furman fixed crash in behavior tree's search rollback Change 3676586 by Lukasz.Furman added local scope mode to behavior tree's composite nodes Change 3676587 by Ben.Zeigler Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case Add browse, use selected, and clear buttons, and make ID selector font the normal property font Change 3676715 by Lukasz.Furman changed order of behavior tree's aux node ticking Change 3676867 by Ben.Zeigler #jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early Change 3677892 by Ben.Zeigler Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites Change 3678247 by Marc.Audy Fix static analysis warning Change 3678357 by Ben.Zeigler #jira UE-50696 Add some container variables to diff test to track down crashes Change 3678385 by Ben.Zeigler #jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match Change 3678600 by Ben.Zeigler #jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference Change 3679075 by Dan.Oconnor Mirror 3679030 from Release-4.18 Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on #jira UE-48692 Change 3679087 by Dan.Oconnor Filter out unnecessary relink jobs from the compilation manager #jira None Change 3680221 by Ben.Zeigler #jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary Change 3680561 by Lukasz.Furman fixed unsafe StopTree calls in behavior tree #jira nope Change 3680788 by Ben.Zeigler Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind Change 3683001 by mason.seay Submitting various test maps and assets Change 3686837 by Mieszko.Zielinski Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion #jira UE-50857 Change 3688451 by Marc.Audy Fix up new material expression to work with String -> Name refactor Change 3689097 by Mason.Seay Test content for nativization and enum testing Change 3689106 by Mieszko.Zielinski Made NavMeshBoundsVolume react to undo in the editor #Orion #jira UE-51013 Change 3689347 by Mieszko.Zielinski Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4 Manual merge of CL#3689316 over from 4.18 #jira UE-51019 Change 3692524 by mason.seay Moved some assets to folder for org, fixed up redirectors Change 3692540 by mason.seay Renaming test maps so they are clearly indicated for testing nativization Change 3692577 by mason.seay Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed Change 3692724 by mason.seay Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps Change 3693184 by mason.seay Assets for testing nativization with structs Change 3693367 by mason.seay Improvements to test content Change 3695395 by Dan.Oconnor Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced #jira None Change 3695484 by Marc.Audy Fix sound cue connection drawing policy not getting returned. #jira UE-51032 Change 3695494 by mason.seay More test content for nativization testing Change 3697829 by Mieszko.Zielinski PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei) Change 3700541 by mason.seay Test map for containers with function bug Change 3703459 by Marc.Audy Remove poorly named InverseLerp Fix degenerate behavior returning bad value #jira UE-50295 Change 3703803 by Marc.Audy Clean up autos Minor improvement to ShouldGenerateCluster Change 3704496 by Mason.Seay More test content for testing nativization Change 3706314 by Marc.Audy PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar) #jira UE-50874 Change 3707502 by Mason.Seay Final changes to nativization test content (hopefully) Change 3709478 by Marc.Audy PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel) Same as CL# 3689702 implemented in Fortnite #jira UE-51453 Change 3709967 by Marc.Audy PR #4139: fixed a typo in a comment (Contributed by derekvanvliet) #jira UE-51372 Change 3709970 by Marc.Audy PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman) #jira UE-51495 Change 3709971 by Marc.Audy PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas) #jira UE-51492 Change 3710041 by Marc.Audy Minor code cleanup Change 3711223 by Phillip.Kavan Move some Blueprint nativization log spam into the verbose category. #jira UE-49770 Change 3713398 by Marc.Audy PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM) #jira UE-51517 Change 3713601 by Marc.Audy Fix merge error Change 3713994 by Marc.Audy (4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event. #jira UE-50738 Change 3714270 by Marc.Audy Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors #jira UE-51534 Change 3714406 by Marc.Audy Fix dumb inverted boolean check Change 3716594 by Dan.Oconnor Integrate 3681301 from 4.18 Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior #jira UE-50780, UE-51568 Change 3686450 by Marc.Audy PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString. CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither. CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters. Material Expressions now store input and output names as FName instead of FString FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString Most existing pin related functions using string have been deprecated. Change 3713796 by Marc.Audy Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not. IsTickable no longer a pure virtual (defaults to true). Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject. Change 3638554 by Marc.Audy Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected. Change 3676502 by Ben.Zeigler Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635 [CL 3718205 by Marc Audy in Main branch]
2017-10-25 09:30:36 -04:00
const FString OldNameStr = OldName.ToString();
const FString ElementNameStr = ElementName.ToString();
FString OldFriendlyName = OldNameStr;
FString ElementFriendlyName = ElementNameStr;
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
// SubPin Friendly Name has an extra space in it so we need to account for that
OldFriendlyName.InsertAt(1, " ");
ElementFriendlyName.InsertAt(1, " ");
for (UEdGraphPin* SubPin : CurrentPin->SubPins)
{
FString SubPinFriendlyName = SubPin->PinFriendlyName.ToString();
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3716594) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3623720 by Phillip.Kavan #jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build. Change summary: - Temporarily excluded all AnimBP assets from nativization as a workaround. Change 3626305 by Phillip.Kavan #jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default. Change 3629145 by Marc.Audy Don't hide developer nativization tool behind ini Change 3630849 by Marc.Audy Fix nativization uncompilable code when using a non-referenceable term in a switch statement. #jira UE-44085 Change 3631037 by Marc.Audy (4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it #jira UE-49440 Change 3631206 by Marc.Audy Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT("")) Change 3631232 by Marc.Audy Remove outdated diagnostic code throwing false positives #jira UE-47986 Change 3631573 by Marc.Audy Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's' Change 3633168 by Lukasz.Furman fixed behavior tree changing its state during latent abort, modified order of operations during abort to: abort & wait -> change aux nodes -> execute Change 3633609 by Marc.Audy Don't get unneeded string Change 3633691 by Marc.Audy Fix copy-pasting of a collapsed graph containing a map input losing the value type #jira UE-49517 Change 3633967 by Ben.Zeigler Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript Fixed a few other fields to be private that were accidentally made public in 4.17 Change 3633984 by Michael.Noland Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links Change 3634464 by Ben.Zeigler Header cleanups for Pawn, Controller, Character, and PlayerController Change 3636858 by Marc.Audy In preview worlds don't display the light error sprite #jira UE-49555 Change 3636903 by Marc.Audy Fix numerous issues with copy/pasting editable pin bases #jira UE-49532 Change 3638898 by Marc.Audy Allow right-click creation of local variables in blueprint function libraries #jira UE-49590 Change 3639086 by Marc.Audy PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin) #jira UE-49591 Change 3639445 by Marc.Audy Fix mistaken override and virtual markup on niagara schema function. Change 3641202 by Marc.Audy (4.17.2) Fix crash undoing pin changes with split pins #jira UE-49634 Change 3643825 by Marc.Audy (4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted #jira UE-49756 Change 3645110 by mason.seay Fixed up QA-ClickHUD map so it's usable and makes more sense Change 3646428 by Dan.Oconnor Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data #jira None Change 3647298 by Marc.Audy PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist) #jira UE-49748 Change 3647815 by Marc.Audy Minor performance improvements Change 3648931 by Lina.Halper #Compiler : fixed so that each type of BP can provide module info, and compiler info - Moved out AnimBlueprint Compiler - Refactored WidgetBlueprint - DUPE - Merging using ControlRig_Dev-Framework Change 3654310 by Marc.Audy Shrink USkinnedMeshComponent 64 bytes Shrink USkeletalMeshComponent 224 bytes (160 bytes internal) Change 3654636 by Lina.Halper Fix crashing on shutdown #jira: UE-50004 Change 3654960 by Lina.Halper - Fix with automation test of creation/duplication - Fixed shut down crash with editor again due to uobject GCed #jira: UE-50028 Change 3655023 by Ben.Zeigler #jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag Change 3655426 by Ben.Zeigler #jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them Change 3657627 by Ben.Zeigler #jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction Change 3662086 by Mieszko.Zielinski Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4 This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList #jira UE-50101 Change 3662294 by Ben.Zeigler Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check Change 3662825 by Mieszko.Zielinski Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4 there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no Change 3664424 by Marc.Audy UE-50076 test assets #rb none #rnx Change 3664441 by Mieszko.Zielinski PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist) Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated. Change 3664506 by Phillip.Kavan #jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets. Change summary: - UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization. - UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths. - UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished. - UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option). - UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed. - UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead. - UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead. - UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file. - UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file. - UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first). - UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness. - UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed. - UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc. - UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file. - UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string. - UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>. - UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin. - UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed). - UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed). - UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it. - UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished. - UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed. - UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context. - UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail. - UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT). - UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders. Notes: - After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release). - Advanced users and build engineers can override this value per task. Instructions to do that are as follows: - For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line. - When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly. - We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT. - We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above). Change 3665061 by Phillip.Kavan Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum. Mirrored from //UE4/Release-4.18 (CL# 3664993). #3969 #jira UE-49233 Change 3665108 by Marc.Audy (4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted + additional code cleanup #jira UE-50076 Change 3665114 by Marc.Audy Minor change that could potentially improve performance in some cases Change 3665410 by Mieszko.Zielinski Fixed naming of Vislog's BP API #UE4 Change 3665634 by Ben.Zeigler #jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk Change 3666970 by Phillip.Kavan Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8. #jira UE-46814 Change 3667058 by Phillip.Kavan Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage. Mirrored from //UE4/Release-4.18 (CL# 3667043). #jira UE-50403 Change 3667150 by Mieszko.Zielinski PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM) Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend. #jira UE-50249 Change 3667152 by Mieszko.Zielinski PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM) #jira UE-50298 Change 3667166 by Mieszko.Zielinski Fixed FRichCurve baking so that it doesn't loose its curvature #UE4 Also, added some baking sanity checking (like if the range is larger than a single point). Change 3668025 by Dan.Oconnor Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed #jira UE-50453 Change 3672063 by Ben.Zeigler #jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case Change 3672306 by Ben.Zeigler #jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it Change 3672683 by Marc.Audy Code cleanup Change 3672749 by Ben.Zeigler Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build Change 3672831 by Ben.Zeigler #jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId. Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project Change 3673551 by Ben.Zeigler #jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load Change 3675074 by mason.seay Test map for VisLog Testing Change 3675084 by Mieszko.Zielinski Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4 #jira UE-43430 Change 3676490 by Ben.Zeigler #jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset Change 3676579 by Lukasz.Furman fixed crash in behavior tree's search rollback Change 3676586 by Lukasz.Furman added local scope mode to behavior tree's composite nodes Change 3676587 by Ben.Zeigler Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case Add browse, use selected, and clear buttons, and make ID selector font the normal property font Change 3676715 by Lukasz.Furman changed order of behavior tree's aux node ticking Change 3676867 by Ben.Zeigler #jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early Change 3677892 by Ben.Zeigler Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites Change 3678247 by Marc.Audy Fix static analysis warning Change 3678357 by Ben.Zeigler #jira UE-50696 Add some container variables to diff test to track down crashes Change 3678385 by Ben.Zeigler #jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match Change 3678600 by Ben.Zeigler #jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference Change 3679075 by Dan.Oconnor Mirror 3679030 from Release-4.18 Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on #jira UE-48692 Change 3679087 by Dan.Oconnor Filter out unnecessary relink jobs from the compilation manager #jira None Change 3680221 by Ben.Zeigler #jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary Change 3680561 by Lukasz.Furman fixed unsafe StopTree calls in behavior tree #jira nope Change 3680788 by Ben.Zeigler Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind Change 3683001 by mason.seay Submitting various test maps and assets Change 3686837 by Mieszko.Zielinski Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion #jira UE-50857 Change 3688451 by Marc.Audy Fix up new material expression to work with String -> Name refactor Change 3689097 by Mason.Seay Test content for nativization and enum testing Change 3689106 by Mieszko.Zielinski Made NavMeshBoundsVolume react to undo in the editor #Orion #jira UE-51013 Change 3689347 by Mieszko.Zielinski Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4 Manual merge of CL#3689316 over from 4.18 #jira UE-51019 Change 3692524 by mason.seay Moved some assets to folder for org, fixed up redirectors Change 3692540 by mason.seay Renaming test maps so they are clearly indicated for testing nativization Change 3692577 by mason.seay Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed Change 3692724 by mason.seay Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps Change 3693184 by mason.seay Assets for testing nativization with structs Change 3693367 by mason.seay Improvements to test content Change 3695395 by Dan.Oconnor Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced #jira None Change 3695484 by Marc.Audy Fix sound cue connection drawing policy not getting returned. #jira UE-51032 Change 3695494 by mason.seay More test content for nativization testing Change 3697829 by Mieszko.Zielinski PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei) Change 3700541 by mason.seay Test map for containers with function bug Change 3703459 by Marc.Audy Remove poorly named InverseLerp Fix degenerate behavior returning bad value #jira UE-50295 Change 3703803 by Marc.Audy Clean up autos Minor improvement to ShouldGenerateCluster Change 3704496 by Mason.Seay More test content for testing nativization Change 3706314 by Marc.Audy PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar) #jira UE-50874 Change 3707502 by Mason.Seay Final changes to nativization test content (hopefully) Change 3709478 by Marc.Audy PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel) Same as CL# 3689702 implemented in Fortnite #jira UE-51453 Change 3709967 by Marc.Audy PR #4139: fixed a typo in a comment (Contributed by derekvanvliet) #jira UE-51372 Change 3709970 by Marc.Audy PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman) #jira UE-51495 Change 3709971 by Marc.Audy PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas) #jira UE-51492 Change 3710041 by Marc.Audy Minor code cleanup Change 3711223 by Phillip.Kavan Move some Blueprint nativization log spam into the verbose category. #jira UE-49770 Change 3713398 by Marc.Audy PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM) #jira UE-51517 Change 3713601 by Marc.Audy Fix merge error Change 3713994 by Marc.Audy (4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event. #jira UE-50738 Change 3714270 by Marc.Audy Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors #jira UE-51534 Change 3714406 by Marc.Audy Fix dumb inverted boolean check Change 3716594 by Dan.Oconnor Integrate 3681301 from 4.18 Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior #jira UE-50780, UE-51568 Change 3686450 by Marc.Audy PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString. CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither. CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters. Material Expressions now store input and output names as FName instead of FString FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString Most existing pin related functions using string have been deprecated. Change 3713796 by Marc.Audy Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not. IsTickable no longer a pure virtual (defaults to true). Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject. Change 3638554 by Marc.Audy Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected. Change 3676502 by Ben.Zeigler Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635 [CL 3718205 by Marc Audy in Main branch]
2017-10-25 09:30:36 -04:00
SubPinFriendlyName.ReplaceInline(*OldFriendlyName, *ElementFriendlyName);
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
SubPin->Modify();
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3716594) #lockdown Nick.Penwarden ============================ MAJOR FEATURES & CHANGES ============================ Change 3623720 by Phillip.Kavan #jira UE-49239 - Temp fix for QAGame animations not updating in a nativized build. Change summary: - Temporarily excluded all AnimBP assets from nativization as a workaround. Change 3626305 by Phillip.Kavan #jira UE-49269 - Workaround fix for crash after packaging a nativized QAGame build with all AnimBP assets disabled for nativization by default. Change 3629145 by Marc.Audy Don't hide developer nativization tool behind ini Change 3630849 by Marc.Audy Fix nativization uncompilable code when using a non-referenceable term in a switch statement. #jira UE-44085 Change 3631037 by Marc.Audy (4.17.2) Fix crash when nativizing blueprint with MakeMap or MakeSet node in it #jira UE-49440 Change 3631206 by Marc.Audy Make NAME_None == TEXT("") behave the same as NAME_None == FName(TEXT("")) Change 3631232 by Marc.Audy Remove outdated diagnostic code throwing false positives #jira UE-47986 Change 3631573 by Marc.Audy Fix containers of vector, rotator, or transform placing a space between the type and the pluralization 's' Change 3633168 by Lukasz.Furman fixed behavior tree changing its state during latent abort, modified order of operations during abort to: abort & wait -> change aux nodes -> execute Change 3633609 by Marc.Audy Don't get unneeded string Change 3633691 by Marc.Audy Fix copy-pasting of a collapsed graph containing a map input losing the value type #jira UE-49517 Change 3633967 by Ben.Zeigler Actor.h header cleanup, fix various comments and reorganize some members, saves 80 bytes per actor in a cooked Win64 build bRunningUserConstructionScript is now private, exposed with IsRunningUserConstructionScript Fixed a few other fields to be private that were accidentally made public in 4.17 Change 3633984 by Michael.Noland Blueprints: Fixed a potential crash when collapsing nodes to a function when a potential entry pin had no links Change 3634464 by Ben.Zeigler Header cleanups for Pawn, Controller, Character, and PlayerController Change 3636858 by Marc.Audy In preview worlds don't display the light error sprite #jira UE-49555 Change 3636903 by Marc.Audy Fix numerous issues with copy/pasting editable pin bases #jira UE-49532 Change 3638898 by Marc.Audy Allow right-click creation of local variables in blueprint function libraries #jira UE-49590 Change 3639086 by Marc.Audy PR #4006: Mark UEdGraphSchema::BreakSinglePinLink as const (Contributed by leyyin) #jira UE-49591 Change 3639445 by Marc.Audy Fix mistaken override and virtual markup on niagara schema function. Change 3641202 by Marc.Audy (4.17.2) Fix crash undoing pin changes with split pins #jira UE-49634 Change 3643825 by Marc.Audy (4.17.2) Fix crash right clicking a struct pin when the struct it represented has been deleted #jira UE-49756 Change 3645110 by mason.seay Fixed up QA-ClickHUD map so it's usable and makes more sense Change 3646428 by Dan.Oconnor Fix for UbergraphFrame layout changing during bytecode recompile, which would cause actual ubergraph frame layout to mismatch reflection data #jira None Change 3647298 by Marc.Audy PR #4016: Rename argument name for SetInputMode (Contributed by projectgheist) #jira UE-49748 Change 3647815 by Marc.Audy Minor performance improvements Change 3648931 by Lina.Halper #Compiler : fixed so that each type of BP can provide module info, and compiler info - Moved out AnimBlueprint Compiler - Refactored WidgetBlueprint - DUPE - Merging using ControlRig_Dev-Framework Change 3654310 by Marc.Audy Shrink USkinnedMeshComponent 64 bytes Shrink USkeletalMeshComponent 224 bytes (160 bytes internal) Change 3654636 by Lina.Halper Fix crashing on shutdown #jira: UE-50004 Change 3654960 by Lina.Halper - Fix with automation test of creation/duplication - Fixed shut down crash with editor again due to uobject GCed #jira: UE-50028 Change 3655023 by Ben.Zeigler #jira UE-50101 Fix level streaming transform when PIE-duplicating a level that has been preloaded but not made visible in the editor. Instead of always saying actors have been moved we copy the source level's flag Change 3655426 by Ben.Zeigler #jira UE-50019 Fix issue where StreamableManager could return objects that are partially loaded if called from PostLoad. StreamableManager never wants half-loaded objects, so change it to explicitly skip them Change 3657627 by Ben.Zeigler #jira UE-50157 Fix EDL load dependency issue where the simple construction script/ICH are not guaranteed to be serialized in time for subobject construction Change 3662086 by Mieszko.Zielinski Fixed navmesh not loading properly in PIE when owning world has been duplicated-for-play #UE4 This can happen when navigation containing level is loaded via AsyncLoadPrimaryAssetList #jira UE-50101 Change 3662294 by Ben.Zeigler Fix enum redirects to handle non-class enums properly where a value redirect is not specified. It needs to convert from EOldEnum::Value to ENewEnum::Value before doing the name check Change 3662825 by Mieszko.Zielinski Fixed VisLog debug drawing crashing when using UI to change log lines to be displayed #UE4 there was a loop iterating over elements of a map and was modifying the map as it went, which is a big no-no Change 3664424 by Marc.Audy UE-50076 test assets #rb none #rnx Change 3664441 by Mieszko.Zielinski PR #3993: UE-25907: Added logging to Log Text, Log Location, and Log Box Shape (Contributed by projectgheist) Piggybacking on this PR I've redone how visual log is using categories. Now it's using FName rather than FLogCategoryBase to indicated log category. All UE_VLOG macros have been updated. Change 3664506 by Phillip.Kavan #jira UE-47852 - Fix various issues with both UAT/UBT-driven and manually-configured code/data build workflows involving nativized Blueprint assets. Change summary: - UAT: Removed '-nativizedAssets' command-line option. It's no longer required to specify this flag when cooking/building in order to enable nativization. - UAT: Removed AutomationTool.ProjectParams.BlueprintPluginPaths. - UAT: Modified AutomationTool.ProjectParams.ProjectParams() to initialize the 'RunAssetNativization' field based on the current 'BlueprintNativizationMethod' config setting. This flag is now used just to direct UAT to defer invoking UBT for '-build' until after the '-cook' stage has finished. - UAT: Modified BuildCookRun.DoBuildCookRun() to remove the 'bWarnIfPackagedWithoutNativizationFlag' case (since we removed the '-nativizedAssets' command-line option). - UAT: Removed Project.AddBlueprintPluginPathArgument() and Project.GetBlueprintPluginPathArgument(). These utility functions are no longer needed. - UAT: Modified Project.Cook() to remove the registration of each NativizedAssets plugin path for '-build' along with the addition of the '-nativizedAssets' argument with the platform-agnostic path to the NativizedAssets plugin when invoking UE4Editor.exe for '-cook'. This is now handled by the UE4Editor cook commandlet instead. - UAT: Modified Project.Build() to remove the addition of the '-plugin' argument with the path to the NativizedAssets plugin when invoking UBT for '-build'. This is now handled by UBT instead. - UBT: Modified UnrealBuildTool.ProjectFileGenerator.DiscoverExtraPlugins() to remove the previously-added search for intermediate plugin assets based on the 'AdditionalPluginDirectories' optionally found in the .uproject file. Instead, this search is now handled via a Plugins.EnumeratePlugins() LINQ query. It is also gated by a new Advanced project setting in DefaultGame.ini that defaults to off, but this way users can still add generated assets into the solution file. - UBT: Added UnrealBuildTool.UEBuildTarget.ShouldIncludeNativizedAssets() as a utility method for checking the current 'BlueprintNativizationMethod' setting in the game's config file. - UBT: Modified UnrealBuildTool.UEBuildTarget.CreateTarget() to confirm the existence of a NativizedAssets plugin (generated at cook time) when the project is configured for nativization. If the plugin is found, it is added to the RulesAssembly chain and the ProjectDescriptor.ForeignPlugins list. If the plugin is not found, then a BuildException is thrown informing the user that the plugin must exist in order to build (with a note to make sure to cook the target platform first). - UE4: Added 'Lex' namespace utility functions for converting PlatformInfo::EPlatformType to/from an FString. Note: Lex::FromString() is simply a proxy to the already-existing PlatformInfo::EPlaformTypeFromString() API, but it was included for completeness. - UE4: Removed the UProjectPackagingSettings::bWarnIfPackagedWithoutNativizationFlag. This is no longer needed since the '-nativizedAssets' command-line option has been removed. - UE4: Added UProjectPackagingSettings::bIncludeNativizedAssetsInProjectGeneration (advanced setting). This defaults to 'false' (off). When true, running GenerateProjects.bat will also generate project files for any NativizedAssets plugins previously generated at cook time. This gives advanced users/engineers an option to include nativized Blueprint class sources in the set of generated C++ code projects for faster browsing, etc. - UE4: Modified UProjectPackagingSettings::PostEditChangeProperty() to remove the case that handles the 'BlueprintNativizationMethod' property. When this value changes, we no longer make an attempt to modify the .uproject file. - UE4: Removed BlueprintNativeCodeGenManifestImpl::PlatformPlaceholderPattern. This pattern string is no longer in use. Also modified the FBlueprintNativeCodeGenPaths ctor to remove the replacement logic for the pattern string. - UE4: Modified FBlueprintNativeCodeGenPaths::GetDefaultCodeGenPaths() to construct and return a new directory pattern for the generated NativizedAssets plugin. This is now generated to: Intermediate/Plugins/NativizedAssets/<Platform>/<Type:Game|Client|Server>. - UE4: Modified FBlueprintNativeCodeGenPaths::PluginRootDir() to no longer append "NativizedAssets" to the end of the path to the generated NativizedAssets plugin. - UE4: Removed FCookByTheBookStartupOptions::bNativizeAssets and NativizedPluginPath (no longer in use since the '-nativizeAssets' command-line option has been removed). - UE4: Modified UCookCommandlet::CookByTheBook() to remove initialization of the 'bNativizeAssets' field in the startup options (since the corresponding command-line argument has been removed). - UE4: Removed FNativeCodeGenData::DestPluginPath and modified FBlueprintNativeCodeGenModule::Initialize() to remove the check for it. - UE4: Added FBlueprintNativeCodeGenModule::ShutdownModule(). This now handles cleanup for the nativization module after the cook process has finished. - UE4: Modified UCookCommandlet::CookByTheBook() to no longer look for the '-nativizedAssets' command-line option as well as to remove the initialization of the nativization-related startup option flags that were removed. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to check the 'BlueprintNativizationMethod' config setting in order to determine whether or not to nativize assets. This replaces the '-nativizedAssets' command-line flag. - UE4: Modified UCookOnTheFlyServer::StartCookByTheBook() to remove the case that previously handled the 'bWarnIfPackagedWithoutNativizationFlag' check. This is no longer needed since the '-nativizedAssets' flag was removed. - UE4: Modified UCookOnTheFlyServer::CookByTheBookFinished() to unload the IBlueprintNativeCodeGenModule instance after cooking, in order to reset module state for another potential pass within the same process context. - UE4: Modified UWidgetBlueprintGeneratedClass::InitializeTemplate() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we shift the OldArchetype object into the transient package, it doesn't invalidate the outer package's linker. We need that to remain valid so that multiple nativized cooks within the same process don't fail. - UE4: Modified FMainFrameActionCallbacks::PackageProject() to remove the addition of '-nativizedAssets' to the UAT command line based on project settings (this is no longer needed, as it is now handled internally by UAT). - UE4: Modified SaveWorld() to append 'REN_ForceNoResetLoaders' to the Rename() flags so that when we rename the world instead of duplicating it, it no longer triggers a reset of *all* object loaders. Notes: - After this change, all nativization workflows (e.g. UAT, UBT and UE4Editor) now look to the 'BlueprintNativizationMethod' flag in the Project settings (UProjectPackagingSettings). This unifies everything on a single flag by default, and removes the feature added in 4.17 that touched the .uproject file when that setting changed (which itself introduced a couple of new regressions in that release). - Advanced users and build engineers can override this value per task. Instructions to do that are as follows: - For UAT/UBT/UE4Editor.exe tasks, adding '-ini:Game:[/Script/UnrealEd.ProjectPackagingSettings]:BlueprintNativizationMethod=<Disabled|Inclusive|Exclusive>' will allow the current setting to be overridden on the command line. - When '-cook' is included on the RunUAT BuildCookRun command line, the above needs to also be embedded within the '-AdditionalCookerOptions' command-line argument. This means that if both '-cook' and '-build' are included, then both the '-ini' argument shown above as well as the same '-ini' argument embedded inside the '-AdditionalCookerOptions' argument will need to be included for the build pipeline to work properly. - We should add a release note instructing users to check their .uproject file and remove any 'AdditionalPluginDirectories' entries that list the "Intermediate/Plugins" path. This will avoid issues when building the cooked target with UBT. - We should also add a release note and/or documentation to explain the "advanced" build pipeline options (i.e. the '-ini' argument noted above). Change 3665061 by Phillip.Kavan Fix crash on load in a nativized build caused by a reference to a BP class containing a nativized enum. Mirrored from //UE4/Release-4.18 (CL# 3664993). #3969 #jira UE-49233 Change 3665108 by Marc.Audy (4.18) Fix crash when diffing a blueprint whose older version's parent blueprint has been deleted + additional code cleanup #jira UE-50076 Change 3665114 by Marc.Audy Minor change that could potentially improve performance in some cases Change 3665410 by Mieszko.Zielinski Fixed naming of Vislog's BP API #UE4 Change 3665634 by Ben.Zeigler #jira UE-50045 Mark PIE-duplicated packages as explicitly fully loaded to fix PIE networking crash. These used to be accidentally treated as fully loaded because it was checking the wrong package name on disk Change 3666970 by Phillip.Kavan Do not emit a BOM when generating nativized Blueprint asset source files encoded as UTF-8. #jira UE-46814 Change 3667058 by Phillip.Kavan Ensure that '-build' is always passed to BuildCookRun automation for projects configured with Blueprint nativization enabled so that it doesn't skip that stage. Mirrored from //UE4/Release-4.18 (CL# 3667043). #jira UE-50403 Change 3667150 by Mieszko.Zielinski PR #4042: BT CompositeDecorator node clears RF_Transient flag for all owned Decorator nodes. (Contributed by BibbitM) Minor tweak from the original PR - made UBehaviorTreeDecoratorGraphNode_Decorator::ResetNodeOwner protected and added UBehaviorTreeGraphNode_CompositeDecorator class a a friend. #jira UE-50249 Change 3667152 by Mieszko.Zielinski PR #4047: Clearing RF_Transient flag when reseting EQS node owner - single change. (Contributed by BibbitM) #jira UE-50298 Change 3667166 by Mieszko.Zielinski Fixed FRichCurve baking so that it doesn't loose its curvature #UE4 Also, added some baking sanity checking (like if the range is larger than a single point). Change 3668025 by Dan.Oconnor Added a step to the compilation manager to skip recompilation of classes that are dependent on a given classes function signatures when those signatures have not changed #jira UE-50453 Change 3672063 by Ben.Zeigler #jira UE-49049 Fix issue with StreamableHandle ParentHandles array being modified during iteration, I had already fixed the Cancel case but not the complete case Change 3672306 by Ben.Zeigler #jira UE-50571 Fix issue where PrimaryAsset blueprints would be incorrectly added to the dictionary if their base class had an active class redirect referencing it Change 3672683 by Marc.Audy Code cleanup Change 3672749 by Ben.Zeigler Fix issue where deleting a source package would not cause the generated cooked package to get deleted while doing an incremental build Change 3672831 by Ben.Zeigler #jira UE-50507 Add a cook/save warning when a registered PrimaryAssetId does not match the object's real exported PrimaryAssetId. Make PrimaryDataAsset blueprintable so you can make primary assets in a blueprint-only project Change 3673551 by Ben.Zeigler #jira UE-50029 Fix it so data-only blueprints will never create a UCS function in the final class. If you manually compiled the blueprint or it got recompiled due to inheritance it would create a UCS function that just calls its parent, which could cause problems later on when it did not create a UCS function during normal load Change 3675074 by mason.seay Test map for VisLog Testing Change 3675084 by Mieszko.Zielinski Fixed BT editor constantly marking BT asset as dirty if it has a "RunBehavior" node #UE4 #jira UE-43430 Change 3676490 by Ben.Zeigler #jira UE-50635 Fix it so directly blueprinting PrimaryDataAsset will give you a useful PrimaryAssetType. Unless overridden the Type of a PrimaryDataAsset will be the first native class found in the hierarchy, or the the blueprint class that directly blueprints PrimaryDataAsset Change 3676579 by Lukasz.Furman fixed crash in behavior tree's search rollback Change 3676586 by Lukasz.Furman added local scope mode to behavior tree's composite nodes Change 3676587 by Ben.Zeigler Swap PrimaryAssetId property customization to use the same ui as the Pin customization. This one better handles objects that aren't loaded into memory, the old Property one would show None in that case Add browse, use selected, and clear buttons, and make ID selector font the normal property font Change 3676715 by Lukasz.Furman changed order of behavior tree's aux node ticking Change 3676867 by Ben.Zeigler #jira UE-50665 Fix issue where resolving Soft Object Ptrs that are stored inside static assets or Blueprint CDOs from PIE will return the editor actor, not the PIE actor. So when resolving a path/ptr during PIE add a failsafe to do a PIE fixup Fix issue where Lazy pointer fixup could corrupt Soft Object Ptrs by applying the PIE fixup too early Change 3677892 by Ben.Zeigler Fix crash when additional level viewport sprites are added after level editor module is loaded. This is basically the same fix as CL #3491406, but for sprites Change 3678247 by Marc.Audy Fix static analysis warning Change 3678357 by Ben.Zeigler #jira UE-50696 Add some container variables to diff test to track down crashes Change 3678385 by Ben.Zeigler #jira UE-50696 Fix crash diffing blueprints where array properties were changed. It needs to not run the generic identical check until it's sure the container types match Change 3678600 by Ben.Zeigler #jira UE-50703 Fix crash when a soft actor reference is not actually pointing to an actor, treat it like a broken reference Change 3679075 by Dan.Oconnor Mirror 3679030 from Release-4.18 Fix crash when compiling a level blueprint that has delegates to a blueprint that it also has a direct dependency on #jira UE-48692 Change 3679087 by Dan.Oconnor Filter out unnecessary relink jobs from the compilation manager #jira None Change 3680221 by Ben.Zeigler #jira UE-50764 Fix crash when converting a property from a soft object reference to hard, it needs to validate the class after the conversion and null if necessary Change 3680561 by Lukasz.Furman fixed unsafe StopTree calls in behavior tree #jira nope Change 3680788 by Ben.Zeigler Fix issue where scrubbing sequencer in simulate would not modify actors. We need to temporarily set the PIE context global when doing this specific type of actor bind Change 3683001 by mason.seay Submitting various test maps and assets Change 3686837 by Mieszko.Zielinski Fixed NavMeshBoundsVolume not updating navmesh when its location gets changed via the Transform Details widget #Orion #jira UE-50857 Change 3688451 by Marc.Audy Fix up new material expression to work with String -> Name refactor Change 3689097 by Mason.Seay Test content for nativization and enum testing Change 3689106 by Mieszko.Zielinski Made NavMeshBoundsVolume react to undo in the editor #Orion #jira UE-51013 Change 3689347 by Mieszko.Zielinski Fixed a crash on FAIDynamicParam creation resulting from uninitialized member variables #UE4 Manual merge of CL#3689316 over from 4.18 #jira UE-51019 Change 3692524 by mason.seay Moved some assets to folder for org, fixed up redirectors Change 3692540 by mason.seay Renaming test maps so they are clearly indicated for testing nativization Change 3692577 by mason.seay Deleted a bunch of old assets I created specifically for various bugs reported. All issues are closed so they're no longer needed Change 3692724 by mason.seay Deleting handful of assets found in developer folders of those no longer with the team. Moved assets that are still used by test maps Change 3693184 by mason.seay Assets for testing nativization with structs Change 3693367 by mason.seay Improvements to test content Change 3695395 by Dan.Oconnor Fix for rare linker issue, IsBlueprintFinalizationPending would return true when we were trying to force load subobjects that were now ready to be loaded. This would prevent some placeholder objects from being replaced #jira None Change 3695484 by Marc.Audy Fix sound cue connection drawing policy not getting returned. #jira UE-51032 Change 3695494 by mason.seay More test content for nativization testing Change 3697829 by Mieszko.Zielinski PR #4104: Fixed a typo CaclulateMaxTilesCount to CalculateMaxTilesCount (Contributed by YuchenMei) Change 3700541 by mason.seay Test map for containers with function bug Change 3703459 by Marc.Audy Remove poorly named InverseLerp Fix degenerate behavior returning bad value #jira UE-50295 Change 3703803 by Marc.Audy Clean up autos Minor improvement to ShouldGenerateCluster Change 3704496 by Mason.Seay More test content for testing nativization Change 3706314 by Marc.Audy PR #4085: GetDefaultPawnClassForController -> BlueprintCallable (Contributed by Allar) #jira UE-50874 Change 3707502 by Mason.Seay Final changes to nativization test content (hopefully) Change 3709478 by Marc.Audy PR #4144: Exposed MassageAxisInput for inheritence (Contributed by jackknobel) Same as CL# 3689702 implemented in Fortnite #jira UE-51453 Change 3709967 by Marc.Audy PR #4139: fixed a typo in a comment (Contributed by derekvanvliet) #jira UE-51372 Change 3709970 by Marc.Audy PR #4150: Fixed a typo in movement override comment (Contributed by ruffenman) #jira UE-51495 Change 3709971 by Marc.Audy PR #4149: Fixing typo on movement pawn component (Contributed by celsodantas) #jira UE-51492 Change 3710041 by Marc.Audy Minor code cleanup Change 3711223 by Phillip.Kavan Move some Blueprint nativization log spam into the verbose category. #jira UE-49770 Change 3713398 by Marc.Audy PR #4157: Renamed AActor::InternalTakePointDamage function's parameter. (Contributed by BibbitM) #jira UE-51517 Change 3713601 by Marc.Audy Fix merge error Change 3713994 by Marc.Audy (4.18) Just mark level script actor pending kill when the level script blueprint has been recompiled, instead of trying to send it through the destroy actor lifecycle event. #jira UE-50738 Change 3714270 by Marc.Audy Fix crashes with tickables as a result of virtuals not being usable in constructors/destructors #jira UE-51534 Change 3714406 by Marc.Audy Fix dumb inverted boolean check Change 3716594 by Dan.Oconnor Integrate 3681301 from 4.18 Only run OnLevelScriptBlueprintChanged when explicitly compiling a level blueprint, this matches the old behavior #jira UE-50780, UE-51568 Change 3686450 by Marc.Audy PinCategory, PinSubcategory, and PinName are now stored as FName instead of FString. CreatePin has several simplified overrides so you can only specify Subcategory or SubcategoryObject or neither. CreatePin also takes a parameter bundle for reference, const, container type, index, and value terminal type rather than a long list of default parameters. Material Expressions now store input and output names as FName instead of FString FNiagaraParameterHandle now stores the parameter handle, namespace, and name as FName instead of FString Most existing pin related functions using string have been deprecated. Change 3713796 by Marc.Audy Added virtual GetTickableType function to FTickableBaseObject that can return Conditional (default), Always, or Never. Tickable Never objects will not get added to the tickable array or ever evaluated. Tickable Always objects do not call IsTickable and assume it will return true. Tickable Conditional objects work as in the past with IsTickable called each frame to make the determination whether to call Tick or not. IsTickable no longer a pure virtual (defaults to true). Applied fixes to avoid array corruption when a FTickableEditorObject is deleted during the tick phase consistent with previous fixes to FTickableGameObject. Change 3638554 by Marc.Audy Add enum expansion functional test to validate that the metadata ExpandEnumAsExecs works as expected. Change 3676502 by Ben.Zeigler Add Blueprint-only primary asset type to EngineTest, to cover testing UE-50635 [CL 3718205 by Marc Audy in Main branch]
2017-10-25 09:30:36 -04:00
SubPin->PinName = *SubPin->PinName.ToString().Replace(*OldNameStr, *ElementNameStr);
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
SubPin->PinFriendlyName = FText::FromString(SubPinFriendlyName);
}
}
}
}
}
void UK2Node_MakeContainer::RemoveInputPin(UEdGraphPin* Pin)
{
check(Pin->Direction == EGPD_Input);
check(Pin->ParentPin == nullptr);
checkSlow(Pins.Contains(Pin));
FScopedTransaction Transaction(LOCTEXT("RemovePinTx", "RemovePin"));
Modify();
TFunction<void(UEdGraphPin*)> RemovePinLambda = [this, &RemovePinLambda](UEdGraphPin* PinToRemove)
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
{
for (int32 SubPinIndex = PinToRemove->SubPins.Num()-1; SubPinIndex >= 0; --SubPinIndex)
{
RemovePinLambda(PinToRemove->SubPins[SubPinIndex]);
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
}
int32 PinRemovalIndex = INDEX_NONE;
if (Pins.Find(PinToRemove, PinRemovalIndex))
{
Pins.RemoveAt(PinRemovalIndex);
PinToRemove->MarkAsGarbage();
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
}
};
if (ContainerType == EPinContainerType::Map)
{
TArray<UEdGraphPin*> KeyPins;
TArray<UEdGraphPin*> ValuePins;
GetKeyAndValuePins(KeyPins, ValuePins);
int32 PinIndex = INDEX_NONE;
if (ValuePins.Find(Pin, PinIndex))
{
RemovePinLambda(KeyPins[PinIndex]);
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
}
else
{
verify(KeyPins.Find(Pin, PinIndex));
RemovePinLambda(ValuePins[PinIndex]);
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
}
}
RemovePinLambda(Pin);
PinConnectionListChanged(Pin);
Copying //UE4/Dev-Framework to //UE4/Dev-Main (Source: //UE4/Dev-Framework @ 3544039) #lockdown Nick.Penwarden #rb none #rnx ===================================== MAJOR FEATURES + CHANGES ===================================== Change 3343905 by Dan.Oconnor ResolveMember optimizations and moved into cpp. ResolveMember<UFunction> now checks UClass::FuncMap before doing more expensive searches Change 3346637 by Ben.Zeigler Actually fix in non editor builds Change 3355484 by Dan.Oconnor Back out FMemberReference Optimization Change 3425833 by Ben.Zeigler #jira UE-31749 Fix it so Undo works properly when modifying a local variable #jira UE-44736 Fix it so changing the type of a local variable correctly resets the default value Change 3510091 by Marc.Audy Expose on Spawn functional test #rnx Change 3510100 by Marc.Audy Fix spelling error #rnx Change 3510132 by Marc.Audy Fix issues with marking a widget blueprint class as abstract Change 3510133 by Marc.Audy Minor code cleanup #rnx Change 3510178 by Ben.Zeigler #jira UE-46500 Fix it so editor-only and transient stuct members are not serialized for literal blueprint structs. It's unsafe to serialize them because they may not exist in the cooked build Change 3510466 by Ben.Zeigler Start adding basic ability system tests to enginetest, very minimal so far Change 3511295 by Marc.Audy Fix wasted work going weak -> object -> weak -> object #rnx Change 3511824 by Marc.Audy Fix spelling error in tooltip #jira UE-46515 #rnx Change 3514446 by Ben.Zeigler Fix ActorBoundEvent and ComponentBoundEvent to always refresh their event signature from the delegate property they are bound to. This is required to correctly deal with delegate signatures being moved or renamed. Both types now do the fixup one time, in ReconstructNode. Change 3514578 by Marc.Audy Move clearing of the actor component need end of frame update mark to base class instead of just primitive component Change 3514583 by Ben.Zeigler Better fix to last delegate checkin that also handles moving functions between modules but not renaming Change 3515325 by Dan.Oconnor Fix for rare orphan pin false positive, rare exposed on spawn false positive #rnx Change 3515761 by Marc.Audy fix shipping configuration #rnx Change 3515772 by Marc.Audy Fix static analysis warnings #rnx Change 3516287 by Marc.Audy Fix references to instanced components not being updated when resetting component to default #jira UE-44706 #rnx Change 3516303 by Marc.Audy Back out CL# 3516287 while an oddity is investigated #rnx Change 3516563 by Marc.Audy (4.17) Fix references to instanced components not being updated when resetting component to default #jira UE-44706 Change 3516637 by Phillip.Kavan #jira UE-44661 - Fix potential crash when changing the ChildActorComponent class default value on a Blueprint that also sets the class in the Construction Script. Change summary: - Modified UChildActorComponent::DestroyChildActor() to move the check for PendingKill/Unreachable so that we can also rename a defunct ChildActor instance out of the way in order to allow for a new ChildActor instance w/ the cached name. Change 3517735 by Marc.Audy Avoid unnecessary string copy #rnx Change 3517931 by Marc.Audy Small optimization to CleanupActors Change 3518221 by Dan.Oconnor Fix rare crash when running ConformImplementedEvents when async loading #jira UE-45348 Change 3518270 by Ben.Zeigler #jira UE-46574 Add FCollectionReference type and customization to allow setting an FName to an editor collection Add AssetCollection to PrimaryAssetLabel that derives the bundled assets from an editor collection Change 3518271 by Marc.Audy Get rid of unnecessary construction differentiation if custom reset is being used Change 3518310 by Ben.Marsh Re-adding IOS files with correct case. Change 3518423 by Ben.Zeigler #jira UE-46574 Initial support for chunk installation in Asset Manager. Refactor AssetManagerSettings so it copies runtime bools into the asset manager for fast access Add a concept of a stalled streamable manager handle, handles can be created stalled and will not execute their async load until all needed resources have been acquired externally Change 3518480 by Marc.Audy Correctly get the variable reference for an input variable get from the member scope rather than a member variable of the same name on the class #jira UE-46737 Change 3518498 by Ben.Zeigler Fix bug with AssetManager where requesting the same load twice in a row before the first one finishes caused the complete callback to get called too early for the second load Update test map to catch this Change 3518526 by Ben.Zeigler IOS Fix Change 3518619 by Ben.Zeigler #jira UE-46744 Fix issue where refreshing asset manager editor settings would throw away asset label rules overrides, causing the recursive flag to accidentally get set Change 3518747 by Phillip.Kavan #jira UE-43154 - Prevent ConstructGenericObject nodes from compiling if the selected type does not include 'BlueprintType' in its inheritance hierarchy. Change summary: - Moved UGameplayStatics::CanSpawnObjectOfClass() into UK2Node_GenericCreateObject as a local util method (per JIRA notes). This was not exposed to Blueprints and as such was inconsistent with the rest of the API. - Modified UGameplayStatics::SpawnObject() to no longer call CanSpawnObjectOfClass(). This seemed redundant as this will already have been called during node validation at Blueprint compile time. - Refactored CanSpawnObjectOfClass() into FK2Node_GenericCreateObject_Utils. Walking up the inheritance chain no longer starts out w/ the assumption that 'BlueprintType' is set by default, which was previously including a lot of engine-specific classes into the "allowed" set (e.g. UByteProperty). Also unified the 2 loop iterations that were being used to check for 'BlueprintType'/'NotBlueprintType' and 'DontUseGenericSpawnObjectName', as well as the check for whether or not the class is a derivative of AActor/UActorComponent. - Modified UK2Node_GenericCreateObject::EarlyValidation() to call FK2Node_GenericCreateObject_Utils::CanSpawnObjectOfClass() and emit a slightly more informative error message to the BP compiler message log. Change 3518756 by Michael.Noland (4.17) Framework: Prevent various asserts when USplineComponent methods are called on a spline with no points Change 3518760 by Michael.Noland Core: Changed FRuntimeAssetCache ensures to ensureAsRuntimeWarning Change 3518771 by Michael.Noland AI: Prevent an ensure in UBlackboardComponent::ClearValue when called on a component with a null BlackboardAsset Change 3518818 by Michael.Noland Rendering: Fixed a whitespace issue in UCanvasRenderTarget2D::RepaintCanvas() #rnx Change 3518822 by Michael.Noland Sequencer: Prevented crashes in some methods of UMovieSceneSequencePlayer when there is no Sequence set Sequencer: Prevented a crash in FMovieSceneRootEvaluationTemplateInstance::Evaluate when the instance has no template set Change 3518824 by Michael.Noland Landscape: Marked ULandscapeComponent and ULandscapeHeightfieldCollisionComponent as Within=LandscapeProxy, since they do CastChecked on their Outer all the time Change 3519073 by Michael.Noland QAGame: Fixed a crash in UQASynth::PlaySynth() if called on a directly created instance rather than using the factory method Change 3519076 by Michael.Noland Preventing crashes in UAutomationPerformaceHelper (sic) when spawned abnormally for fuzzing (assumes that the outer will have a route to a world) #rnx Change 3519079 by Michael.Noland Sequencer: Fixed a potential crash in UMediaPlaylist::Insert and UMediaPlaylist::RemoveAt when passed an invalid index Change 3519081 by Michael.Noland Blueprints: Added support for creating appropriate outers for objects that must be nested within another class during fuzzing (ones that specify Within=, other relationships aren't knowable yet) Change 3519082 by Michael.Noland VR: Prevent a crash in UMRMeshComponent::ConnectReconstructor when passed a null reconstructor Change 3519084 by Michael.Noland Rendering: Prevent crashes when UNiagaraComponent::GetEffectDataInterface is called on a component with no effect asset set Change 3521889 by Michael.Noland Sequencer: Prevented a bogus static analysis warning by reworking the code (FixedFrameInterval could have only been set if the pointer were valid from the line above) #rnx Change 3521987 by Michael.Noland Animation: Prevent a couple of potential asserts in UControlRig::GetOrAllocateSubControlRig Change 3522101 by Michael.Noland Physics: Improved the comment on UPhysicalMaterial::Friction #rn Change 3522105 by Michael.Noland Physics: Fixed a few crashes in UVehicleWheel when spawned directly Change 3522106 by Michael.Noland Framework: Marked ULevelStreaming as Within=World, since it does CastChecked on the Outer all the time Change 3522109 by Michael.Noland Animation: Marked UAnimInstance as Within=SkeletalMeshComponent since it assumes the outer in various places Change 3522121 by Michael.Noland Mobile: Prevent UMobileInstalledContent methods from crashing when called on a created instance in an uncooked build (no installed manifest) Change 3522783 by Zak.Middleton #ue4 - Imported new simple collision for Engine/Content/BasicShaps/Cylinder.uasset which is a single convex shape (rather than being 4 shapes as before). Change 3525477 by Dan.Oconnor Remove Tooltip, Category, and HideCategories tooltip from the blueprint generated class if source data is cleared Change 3526538 by Ben.Zeigler Refresh primary asset labels if their bundles are different at all and not just if they're added or removed. This is required because they now work based on collections or directories. This fixes issue with the onboarding collection changes not correctly modifying chunks Copy of CL #3526501 Change 3526817 by Ben.Zeigler #jira UE-46917 Fix issue where maps that do not contain level script blueprints were being counted as unindexed for find in blueprints. The old behavior depended on detecting the existence of empty tags, but the asset registry now filters those out so treat maps with no FiB data as indexed Change 3526873 by Ben.Zeigler #jira UE-46627 Change it so blueprint or native subclasses of static mesh actor cannot be added to clusters, as they are not likely to be immutable the way the base class is Add code to to the ubergraph frame to fall back to hard reference serialization if the reference collector doesn't support weak references, such as the cluster collector Change 3526958 by Marc.Audy (4.17) Don't copy and then break pin links when reconstructing. Instead simply move. #jira UE-46935 Change 3528916 by Marc.Audy PR #3609: Adds GetKeysForAxis() to complement GetKeysForAction() in UPlayerInput (Contributed by alanedwardes) #jira UE-45347 Change 3529080 by mason.seay BP asset for undetermined type bug Change 3529381 by Marc.Audy Fix ability to insert duplicates in to a set or map Change 3529471 by Dan.Oconnor Fix for clang 4.0 error: definition of builtin function '__rdtsc' inline unsigned long long __rdtsc() Change 3530876 by Marc.Audy Based on PR #3457: Add MakeSet BP node (Contributed by projectgheist) Also refactored MakeArray/Set to share a base MakeContainer class Cleaned up some dead code from MakeArray Added icon for MakeSet Added Functional Test for MakeSet #jira UE-43717 Change 3531070 by Phillip.Kavan #jira UE-46866 - Fix crash on load when an external variable member reference's owning type cannot be loaded. Change summary: - Modified FBlueprintEditorUtils::GetSkeletonClass() to check for NULL before attempting to check for the generating BP. Change 3531081 by Marc.Audy Remove deprecated CustomMapParamValue code Change 3531094 by Phillip.Kavan #jira UE-46952 - Fix a packaging code build failure that will occur with a nativized Blueprint class that contains a UInterfaceProperty. Change summary: - Modified TScriptInterface::operator=() to cast the given 'SourceObject' instance to the 'InterfaceType' type before assigning to 'SourceInterface'. This was necessary because if the caller (in this case nativized codegen) passes in a UObject* that does not explicitly inherit from 'InterfaceType', then it will need to go through the object's GetInterfaceAddress() API instead and cast the result back to an 'InterfaceType' pointer. Change 3531186 by Phillip.Kavan Back out changelist 3531094 (temp CIS fix). #rnx Change 3532082 by Marc.Audy Move garbage collection timers and other management to UEngine instead of UWorld Fixes CollectGarbage blueprint node not working in shipping #jira UE-46566 Change 3532134 by Phillip.Kavan Restored changelist 3531094 w/ fix for non-unity. - Mirrored from //UE4/Release-4.17 (CL# 3531232). #rnx Change 3533009 by Marc.Audy Fixup missing function and deprecation warnings Change 3534056 by Marc.Audy (4.17) Fix expose on spawn of map and sets to work #jira UE-47140 Change 3534761 by Marc.Audy (4.17) Apply code review changes to Dev-Framework as well #rnx Change 3535147 by Dan.Oconnor Build fix, already made in 4.17 #rnx Change 3535530 by mason.seay Resaving to remove error when opening level blueprint Change 3535581 by Marc.Audy Class Properties are only identical if they are literally the same object. Do not consider the deep compare port flags as object property base does. #jira UE-46533 Change 3535583 by Marc.Audy When properties are imported in to a child actor component the cached instance data is invalidated, so clear it. #jira UE-46533 Change 3535617 by Marc.Audy PR #3788: UE-39237: Prevent (im-)pure casting during BP debugging (Contributed by projectgheist) #jira UE-47188 #jira UE-39237 Change 3535671 by Marc.Audy Change NodeFactory to look at interface to use sequence node instead of each node having to add itself Change 3535955 by Marc.Audy Prevent MakeSet from removing split pins Change 3536114 by Michael.Noland Paper2D: Removing deprecated code from 4.3/4.4 era #rnx Change 3536120 by Michael.Noland Animation: Removed deprecated FTAlphaBlend class and AlphaBlendType.h header Change 3536124 by Michael.Noland Physics: Removed deprecated methods that were replaced by _AssumesLocked variations Change 3536131 by Michael.Noland Slate: Converting remaining uses of EKeyboardFocusCause to EFocusCause and properly deprecating it Change 3536138 by Michael.Noland Slate: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536167 by Dan.Oconnor When a client provides a skeleton class as the self scope, make sure we also use a skel class for non-self scopes - but only if using the compilation manager. Skel classes are not reliably up to date when not using the compilation manager #jira UE-46904 Change 3536221 by Michael.Noland Editor: Removing deprecated code from 4.9 or earlier Change 3536240 by Michael.Noland Blueprints: Removed long-deprecated TypeToString method from the K2 schema #rnx Change 3536243 by Michael.Noland AI: Prevent crashes if UMockTask_Log is created manually rather than via the CreateTask factory method Change 3536244 by Michael.Noland Core: Prevent FScopedExternalProfilerBase::StopScopedTimer() from asserting if called an unmatched number of times with StartScopedTimer, as both are exposed to BPs now Change 3536250 by Michael.Noland CoreUObject: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536253 by Michael.Noland Core: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536310 by Michael.Noland Engine: Removed any deprecated code older than 4.10 that didn't affect content compatibility Change 3536397 by Mieszko.Zielinski Fixed UCrowdFollowingComponent::UpdateCachedDirections crashing when CharacterMovement is not set #UE4 #jira UE-46860 Change 3536404 by Michael.Noland Platform: Added a warning for others when they try to remove this 'deprecated' method Change 3536639 by Michael.Noland CharacterMovement: Changed the name of a variable introduced in CL# 3536397 to better match intent #rnx Change 3536893 by Michael.Noland Blueprints: Clear the stale value on the value pin when a map find node fails to find an item #jira UE-47233 Change 3536902 by Michael.Noland Framework: Killed a couple of more deprecated methods that were not exposed to Blueprints #rnx Change 3537038 by Ben.Marsh Fixing case of iOS directories, pt1 Change 3537039 by Ben.Marsh Fixing case of iOS directories, pt2 Change 3538246 by Michael.Noland UnrealTournament: Fixing issues with renamed enum #rnx Change 3538618 by Ben.Zeigler Fix ensure when closing sequencer transform UI Change 3540213 by Ben.Zeigler #jira UE-47313 Fix crash serializing a MapProperty where the value type has changed for a type that implements ConvertFromType. The address passed to ConvertFromType needs to be the container root, not the specific value address, keys worked because the offset was 0. Change 3540253 by Marc.Audy Only copy default values for input pins as output pins do not have them #rnx Change 3540376 by Marc.Audy Add utility FromPinType for FEdGraphTerminalType #rnx Change 3540433 by Marc.Audy Add MakeMap #jira UE-47093 Unify IsConnectionDisallowed for containers and fix static analysis warning #jira UE-47291 Change 3540585 by Phillip.Kavan #jira UE-47117 - Fix crash on launch of a nativized build that includes an instanced default subobject that's referenced by another instanced default subobject. Change summary: - Modified FEmitDefaultValueHelper::HandleSpecialTypes() to only direct HandleInstancedSubobject() to emit code to create the instanced subobject if it's not a default subobject. This was previously being incorrectly interpreted as an object having the 'RF_ArchetypeObject' flag set; however, default subobjects will also have that flag set in addition to the 'RF_DefaultSubobject' flag. - Modified FEmitDefaultValueHelper::HandleInstancedSubobject() to assert in the 'GetDefaultSubobjectByName' case if the given object is not also a default subobject. Change 3541147 by Dan.Oconnor Fix for not being able to override custom events when using the compilation manager post 3536167 #jira UE-47292 #rnx Change 3541177 by Ben.Zeigler #jira UE-46595, UE-46553 Fix issue where creating a widget template could cause a widget blueprint being cooked to have the wrong package flags, making it appear to be an uncooked package Copy of CL #3541027 Change 3541325 by Dan.Oconnor K2node data table data needs to preload data before the compilation queue is flushed #rnx #jira UE-47319 Change 3541409 by Michael.Noland Blueprints: Added code to reapply any active breakpoints after recompilation when using the BP compilation manager #jira UE-47322 [reimplementing CL# 3541404 in Dev-Framework] Change 3541418 by Dan.Oconnor Fix for bad SKEL_ CDO reference in blueprint bytecode #jira UE-47265 #rnx Change 3541482 by Dan.Oconnor Blanket fix up of preload calls that are being done in AllocateDefaultPins. AllocatDefaultPins is not called until compile, meaning if these preload calls load blueprints they will be loaded while the compilation manager is compiling blueprints #rnx #jira UE-47319 Change 3541817 by Marc.Audy Fix static analysis warnings #rnx Change 3542299 by Michael.Noland Blueprints: Speculative fix for static analysis warning #rnx Change 3542406 by Marc.Audy Use a check slow to avoid any cost #rnx Change 3542486 by Michael.Noland Asset Manager: Removing an unnecessary ensure (it's a potentially expected case) #jira UE-47380 Change 3542659 by Michael.Noland Blueprints: Clear out null entries in the LastEditedDocuments list during PostLoad() and remove entries when a graph is being deleted to prevent their generation in the first place #jira UE-47385 Change 3543620 by Dan.Oconnor Remove overzealous ensure - we may recompile blueprints that are asynchronously loading when a user triggers a synchronous compile #jira UE-47415 #rnx Change 3518415 by Ben.Zeigler #jira UE-46574 Deprecate IPlatformChunkInstall::SetChunkInstallDelgate as it was spelled wrong, was only half implemented, and did not support success vs failure Replace with AddChunkInstallDelegate, which supports a bool error code and is bound once instead of separately for each chunk. All implementations support this delegate at a basic level, although several could be improved to call the failure delegate in more cases Change 3534339 by Michael.Noland Platforms: Changed DEPRECATED() macro description to use 4.xx rather than a speciifc version in examples, so it doesn't show up when removing deprecated code [CL 3544050 by Marc Audy in Main branch]
2017-07-19 09:49:59 -04:00
--NumInputs;
SyncPinNames();
FBlueprintEditorUtils::MarkBlueprintAsStructurallyModified(GetBlueprint());
}
void UK2Node_MakeContainer::GetMenuActions(FBlueprintActionDatabaseRegistrar& ActionRegistrar) const
{
// actions get registered under specific object-keys; the idea is that
// actions might have to be updated (or deleted) if their object-key is
// mutated (or removed)... here we use the node's class (so if the node
// type disappears, then the action should go with it)
// actions get registered under specific object-keys; the idea is that
// actions might have to be updated (or deleted) if their object-key is
// mutated (or removed)... here we use the node's class (so if the node
// type disappears, then the action should go with it)
UClass* ActionKey = GetClass();
// to keep from needlessly instantiating a UBlueprintNodeSpawner, first
// check to make sure that the registrar is looking for actions of this type
// (could be regenerating actions for a specific asset, and therefore the
// registrar would only accept actions corresponding to that asset)
if (ActionRegistrar.IsOpenForRegistration(ActionKey))
{
UBlueprintNodeSpawner* NodeSpawner = UBlueprintNodeSpawner::Create(GetClass());
check(NodeSpawner != nullptr);
ActionRegistrar.AddBlueprintAction(ActionKey, NodeSpawner);
}
}
bool UK2Node_MakeContainer::IsConnectionDisallowed(const UEdGraphPin* MyPin, const UEdGraphPin* OtherPin, FString& OutReason) const
{
if (!ensure(OtherPin))
{
return true;
}
// if MyPin has a ParentPin then we are dealing with a split pin and we should evaluate it with default behavior
if (MyPin->ParentPin == nullptr && OtherPin->PinType.IsContainer() == true && MyPin->Direction == EGPD_Input)
{
OutReason = NSLOCTEXT("K2Node", "MakeContainer_InputIsContainer", "Cannot make a container with an input of a container!").ToString();
return true;
}
if (UEdGraphSchema_K2::IsExecPin(*OtherPin))
{
OutReason = NSLOCTEXT("K2Node", "MakeContainer_InputIsExec", "Cannot make a container with an execution input!").ToString();
return true;
}
return false;
}
#undef LOCTEXT_NAMESPACE