2021-01-06 05:44:12 -04:00
|
|
|
// Copyright Epic Games, Inc. All Rights Reserved.
|
|
|
|
|
|
|
|
|
|
#include "ModuleProvider.h"
|
|
|
|
|
#include <atomic>
|
2022-01-05 05:39:03 -05:00
|
|
|
|
|
|
|
|
#include "Algo/Find.h"
|
2021-06-01 06:05:43 -04:00
|
|
|
#include "Algo/Transform.h"
|
|
|
|
|
#include "Common/CachedPagedArray.h"
|
|
|
|
|
#include "Common/CachedStringStore.h"
|
|
|
|
|
#include "Common/Utils.h"
|
|
|
|
|
#include "Containers/Map.h"
|
2022-01-06 05:46:18 -05:00
|
|
|
#include "GenericPlatform/GenericPlatformFile.h"
|
2022-01-05 05:39:03 -05:00
|
|
|
#include "HAL/PlatformFileManager.h"
|
2022-01-06 05:46:18 -05:00
|
|
|
#include "Misc/Paths.h"
|
2021-06-01 06:05:43 -04:00
|
|
|
#include "Misc/PathViews.h"
|
|
|
|
|
#include "TraceServices/Model/AnalysisCache.h"
|
|
|
|
|
#include "TraceServices/Model/AnalysisSession.h"
|
2021-01-06 05:44:12 -04:00
|
|
|
|
2021-04-06 11:04:09 -04:00
|
|
|
// Choose which symbol resolver to use.
|
|
|
|
|
// If both are enabled and the RAD Syms library fails to initialize, it will fall back to DbgHelp (on Windows).
|
|
|
|
|
#define USE_SYMSLIB 1
|
|
|
|
|
#define USE_DBGHELP 1
|
2021-03-31 07:56:27 -04:00
|
|
|
|
2021-01-06 05:44:12 -04:00
|
|
|
// Symbol files implementations
|
2021-04-06 11:04:09 -04:00
|
|
|
#if USE_SYMSLIB
|
2021-03-31 07:56:27 -04:00
|
|
|
#include "SymslibResolver.h"
|
2021-04-06 11:04:09 -04:00
|
|
|
#endif
|
|
|
|
|
#if USE_DBGHELP
|
2021-03-31 07:56:27 -04:00
|
|
|
#include "DbgHelpResolver.h"
|
2021-04-06 11:04:09 -04:00
|
|
|
#endif
|
2021-01-06 05:44:12 -04:00
|
|
|
|
|
|
|
|
namespace TraceServices {
|
|
|
|
|
|
|
|
|
|
/////////////////////////////////////////////////////////////////////
|
2021-06-01 06:05:43 -04:00
|
|
|
template<typename SymbolResolverType>
|
2021-01-06 05:44:12 -04:00
|
|
|
class TModuleProvider : public IModuleAnalysisProvider
|
|
|
|
|
{
|
|
|
|
|
public:
|
2021-07-22 11:24:23 -04:00
|
|
|
explicit TModuleProvider(IAnalysisSession& Session);
|
|
|
|
|
virtual ~TModuleProvider();
|
2021-01-06 05:44:12 -04:00
|
|
|
|
|
|
|
|
//Query interface
|
|
|
|
|
const FResolvedSymbol* GetSymbol(uint64 Address) override;
|
2022-01-05 05:39:03 -05:00
|
|
|
uint32 GetNumModules() const override;
|
|
|
|
|
void EnumerateModules(uint32 Start, TFunctionRef<void(const FModule& Module)> Callback) const override;
|
|
|
|
|
FGraphEventRef LoadSymbolsForModuleUsingPath(uint64 Base, const TCHAR* Path) override;
|
|
|
|
|
void EnumerateSymbolSearchPaths(TFunctionRef<void(FStringView Path)> Callback) const override;
|
2021-01-18 05:51:01 -04:00
|
|
|
void GetStats(FStats* OutStats) const override;
|
2021-04-06 11:04:09 -04:00
|
|
|
|
2021-01-06 05:44:12 -04:00
|
|
|
//Analysis interface
|
2021-03-31 07:56:27 -04:00
|
|
|
void OnModuleLoad(const FStringView& Module, uint64 Base, uint32 Size, const uint8* Checksum, uint32 ChecksumSize) override;
|
2021-01-06 05:44:12 -04:00
|
|
|
void OnModuleUnload(uint64 Base) override;
|
2021-03-15 10:43:52 -04:00
|
|
|
void OnAnalysisComplete() override;
|
2021-06-01 06:05:43 -04:00
|
|
|
void SaveSymbolsToCache(IAnalysisCache& Cache);
|
|
|
|
|
void LoadSymbolsFromCache(IAnalysisCache& Cache);
|
2021-01-06 05:44:12 -04:00
|
|
|
|
|
|
|
|
private:
|
2022-01-05 05:39:03 -05:00
|
|
|
uint32 GetNumCachedSymbolsFromModule(uint64 Base, uint32 Size);
|
2021-01-06 05:44:12 -04:00
|
|
|
|
2021-06-01 06:05:43 -04:00
|
|
|
struct FSavedSymbol
|
|
|
|
|
{
|
|
|
|
|
uint64 Address;
|
|
|
|
|
uint32 ModuleOffset;
|
|
|
|
|
uint32 NameOffset;
|
|
|
|
|
uint32 FileOffset;
|
|
|
|
|
uint32 Line;
|
|
|
|
|
};
|
2022-03-09 10:40:47 -05:00
|
|
|
|
2022-01-05 05:39:03 -05:00
|
|
|
mutable FRWLock ModulesLock;
|
|
|
|
|
TPagedArray<FModule> Modules;
|
2021-01-06 05:44:12 -04:00
|
|
|
|
2022-01-05 05:39:03 -05:00
|
|
|
FRWLock SymbolsLock;
|
2021-06-01 06:05:43 -04:00
|
|
|
// Persistently stored symbol strings
|
|
|
|
|
FCachedStringStore Strings;
|
|
|
|
|
// Efficient representation of symbols
|
|
|
|
|
TPagedArray<FResolvedSymbol> SymbolCache;
|
|
|
|
|
// Lookup table to for symbols
|
|
|
|
|
TMap<uint64, const FResolvedSymbol*> SymbolCacheLookup;
|
2021-10-25 20:05:28 -04:00
|
|
|
// Number of cached symbols that was loaded (used for stats)
|
|
|
|
|
uint32 NumCachedSymbols;
|
2022-01-05 05:39:03 -05:00
|
|
|
// Number of discovered symbols
|
|
|
|
|
std::atomic<uint32> SymbolsDiscovered;
|
2022-03-09 10:40:47 -05:00
|
|
|
|
2021-01-06 05:44:12 -04:00
|
|
|
IAnalysisSession& Session;
|
|
|
|
|
FString Platform;
|
2021-06-01 06:05:43 -04:00
|
|
|
TUniquePtr<SymbolResolverType> Resolver;
|
2022-01-05 05:39:03 -05:00
|
|
|
FGraphEventRef LoadSymbolsTask;
|
|
|
|
|
bool LoadSymbolsAbort = false;
|
2021-01-06 05:44:12 -04:00
|
|
|
};
|
|
|
|
|
|
|
|
|
|
/////////////////////////////////////////////////////////////////////
|
2021-06-01 06:05:43 -04:00
|
|
|
template<typename SymbolResolverType>
|
|
|
|
|
TModuleProvider<SymbolResolverType>::TModuleProvider(IAnalysisSession& Session)
|
2021-01-06 05:44:12 -04:00
|
|
|
: Modules(Session.GetLinearAllocator(), 128)
|
2021-06-01 06:05:43 -04:00
|
|
|
, Strings(TEXT("ModuleProvider.Strings"), Session.GetCache())
|
|
|
|
|
, SymbolCache(Session.GetLinearAllocator(), 1024*1024)
|
2021-10-25 20:05:28 -04:00
|
|
|
, NumCachedSymbols(0)
|
2021-01-06 05:44:12 -04:00
|
|
|
, Session(Session)
|
|
|
|
|
{
|
2021-06-01 06:05:43 -04:00
|
|
|
Resolver = TUniquePtr<SymbolResolverType>(new SymbolResolverType(Session));
|
|
|
|
|
LoadSymbolsFromCache(Session.GetCache());
|
2021-01-06 05:44:12 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/////////////////////////////////////////////////////////////////////
|
2021-06-01 06:05:43 -04:00
|
|
|
template <typename SymbolResolverType>
|
|
|
|
|
TModuleProvider<SymbolResolverType>::~TModuleProvider()
|
|
|
|
|
{
|
2022-01-05 05:39:03 -05:00
|
|
|
if (LoadSymbolsTask)
|
|
|
|
|
{
|
|
|
|
|
LoadSymbolsAbort = true;
|
|
|
|
|
LoadSymbolsTask->Wait();
|
|
|
|
|
}
|
2021-06-01 06:05:43 -04:00
|
|
|
// Delete the resolver in order to flush all pending resolves
|
|
|
|
|
Resolver.Reset();
|
|
|
|
|
SaveSymbolsToCache(Session.GetCache());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/////////////////////////////////////////////////////////////////////
|
|
|
|
|
template<typename SymbolResolverType>
|
|
|
|
|
const FResolvedSymbol* TModuleProvider<SymbolResolverType>::GetSymbol(uint64 Address)
|
2021-01-06 05:44:12 -04:00
|
|
|
{
|
|
|
|
|
{
|
|
|
|
|
// Attempt to read from the cached symbols.
|
|
|
|
|
FReadScopeLock _(SymbolsLock);
|
2021-06-01 06:05:43 -04:00
|
|
|
if (const FResolvedSymbol** Entry = SymbolCacheLookup.Find(Address))
|
2021-01-06 05:44:12 -04:00
|
|
|
{
|
|
|
|
|
return *Entry;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2022-03-09 10:40:47 -05:00
|
|
|
FResolvedSymbol* ResolvedSymbol = nullptr;
|
2021-01-06 05:44:12 -04:00
|
|
|
{
|
|
|
|
|
FWriteScopeLock _(SymbolsLock);
|
2022-03-09 10:40:47 -05:00
|
|
|
|
|
|
|
|
// Attempt again to read from the cached symbols.
|
|
|
|
|
const FResolvedSymbol* CachedResolvedSymbol = SymbolCacheLookup.FindRef(Address);
|
|
|
|
|
if (CachedResolvedSymbol)
|
2021-01-06 05:44:12 -04:00
|
|
|
{
|
2022-03-09 10:40:47 -05:00
|
|
|
return CachedResolvedSymbol;
|
2021-01-06 05:44:12 -04:00
|
|
|
}
|
2022-03-09 10:40:47 -05:00
|
|
|
|
|
|
|
|
// Add a pending entry to our cache.
|
2021-06-01 06:05:43 -04:00
|
|
|
ResolvedSymbol = &SymbolCache.EmplaceBack(ESymbolQueryResult::Pending, nullptr, nullptr, nullptr, 0);
|
|
|
|
|
SymbolCacheLookup.Add(Address, ResolvedSymbol);
|
2022-01-05 05:39:03 -05:00
|
|
|
++SymbolsDiscovered;
|
2021-01-06 05:44:12 -04:00
|
|
|
}
|
|
|
|
|
check(ResolvedSymbol);
|
2022-03-09 10:40:47 -05:00
|
|
|
|
|
|
|
|
// If not in cache yet, queue it up in the resolver.
|
2021-06-01 06:05:43 -04:00
|
|
|
Resolver->QueueSymbolResolve(Address, ResolvedSymbol);
|
2021-01-06 05:44:12 -04:00
|
|
|
|
|
|
|
|
return ResolvedSymbol;
|
|
|
|
|
}
|
|
|
|
|
|
2022-01-05 05:39:03 -05:00
|
|
|
/////////////////////////////////////////////////////////////////////
|
|
|
|
|
template <typename SymbolResolverType>
|
|
|
|
|
uint32 TModuleProvider<SymbolResolverType>::GetNumModules() const
|
|
|
|
|
{
|
|
|
|
|
FReadScopeLock _(ModulesLock);
|
|
|
|
|
return Modules.Num();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/////////////////////////////////////////////////////////////////////
|
|
|
|
|
template <typename SymbolResolverType>
|
2022-03-09 10:40:47 -05:00
|
|
|
void TModuleProvider<SymbolResolverType>::EnumerateModules(uint32 Start, TFunctionRef<void(const FModule& Module)> Callback) const
|
2022-01-05 05:39:03 -05:00
|
|
|
{
|
|
|
|
|
FReadScopeLock _(ModulesLock);
|
|
|
|
|
for (uint32 i = Start; i < Modules.Num(); ++i)
|
|
|
|
|
{
|
|
|
|
|
Callback(Modules[i]);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/////////////////////////////////////////////////////////////////////
|
|
|
|
|
template <typename SymbolResolverType>
|
|
|
|
|
FGraphEventRef TModuleProvider<SymbolResolverType>::LoadSymbolsForModuleUsingPath(uint64 Base, const TCHAR* Path)
|
|
|
|
|
{
|
|
|
|
|
FReadScopeLock _(ModulesLock);
|
|
|
|
|
const FModule* Module = Algo::FindBy(Modules, Base, &FModule::Base);
|
|
|
|
|
if (Module)
|
|
|
|
|
{
|
|
|
|
|
const FString FullPath = FPaths::ConvertRelativePathToFull(Path);
|
|
|
|
|
if (Resolver && !FullPath.IsEmpty() && Module->Status.load() != EModuleStatus::Loaded)
|
|
|
|
|
{
|
|
|
|
|
// Setup a task to queue and watch the queued module. If it succeeds in resolving with the new path
|
2022-03-09 10:40:47 -05:00
|
|
|
// re-resolve any cached symbols
|
2022-01-05 05:39:03 -05:00
|
|
|
LoadSymbolsTask = FFunctionGraphTask::CreateAndDispatchWhenReady([this, Module, FullPath]()
|
|
|
|
|
{
|
|
|
|
|
auto ReloadModuleFn = [this] (const FModule* InModule, const TCHAR* InPath)
|
|
|
|
|
{
|
|
|
|
|
const uint32 DiscoveredSymbols = InModule->Stats.Discovered.load();
|
|
|
|
|
const uint64 ModuleBegin = InModule->Base;
|
|
|
|
|
const uint64 ModuleEnd = InModule->Base + InModule->Size;
|
|
|
|
|
|
|
|
|
|
auto ReresolveOnSuccess = [this, DiscoveredSymbols, ModuleBegin, ModuleEnd] (TArray<TTuple<uint64,FResolvedSymbol*>>& OutSymbols)
|
|
|
|
|
{
|
|
|
|
|
OutSymbols.Reserve(DiscoveredSymbols);
|
2022-03-09 10:40:47 -05:00
|
|
|
|
2022-01-05 05:39:03 -05:00
|
|
|
FReadScopeLock _(SymbolsLock);
|
|
|
|
|
for (auto Pair : SymbolCacheLookup)
|
|
|
|
|
{
|
2022-01-05 08:45:47 -05:00
|
|
|
const uint64 Address = Pair.template Get<0>();
|
|
|
|
|
FResolvedSymbol* Symbol = const_cast<FResolvedSymbol*>(Pair.template Get<1>());
|
|
|
|
|
if (FMath::IsWithin(Address, ModuleBegin, ModuleEnd))
|
2022-01-05 05:39:03 -05:00
|
|
|
{
|
|
|
|
|
OutSymbols.Add(TTuple<uint64,FResolvedSymbol*>(Address, Symbol));
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
Resolver->QueueModuleReload(InModule, InPath, ReresolveOnSuccess);
|
2022-03-09 10:40:47 -05:00
|
|
|
|
2022-01-05 05:39:03 -05:00
|
|
|
// Wait for the resolver to do it's work
|
|
|
|
|
while (InModule->Status.load() == EModuleStatus::Pending)
|
|
|
|
|
{
|
2022-03-09 10:40:47 -05:00
|
|
|
FPlatformProcess::Sleep(0.1f);
|
2022-01-05 05:39:03 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return InModule->Status.load();
|
|
|
|
|
};
|
2022-03-09 10:40:47 -05:00
|
|
|
|
2022-01-05 05:39:03 -05:00
|
|
|
UE_LOG(LogTraceServices, Display, TEXT("Queing symbol loading using path %s."), *FullPath);
|
|
|
|
|
|
|
|
|
|
// Load the requested module
|
|
|
|
|
const EModuleStatus Result = ReloadModuleFn(Module, *FullPath);
|
|
|
|
|
|
|
|
|
|
if (Result == EModuleStatus::Loaded)
|
|
|
|
|
{
|
|
|
|
|
// Queue up any other failed module using the directory.
|
|
|
|
|
IPlatformFile* PlatformFile = &FPlatformFileManager::Get().GetPlatformFile();
|
|
|
|
|
const FString Directory = PlatformFile->DirectoryExists(*FullPath) ? FullPath : FPaths::GetPath(FullPath);
|
|
|
|
|
for (auto& OtherModule : Modules)
|
|
|
|
|
{
|
|
|
|
|
if (LoadSymbolsAbort)
|
|
|
|
|
{
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
const EModuleStatus ModuleStatus = OtherModule.Status.load();
|
2022-03-09 10:40:47 -05:00
|
|
|
if (&OtherModule != Module && ModuleStatus >= EModuleStatus::FailedStatusStart)
|
2022-01-05 05:39:03 -05:00
|
|
|
{
|
|
|
|
|
ReloadModuleFn(&OtherModule, *Directory);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
UE_LOG(LogTraceServices, Display, TEXT("Loading symbols for path %s complete."), *FullPath);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
return LoadSymbolsTask;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return FGraphEventRef();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/////////////////////////////////////////////////////////////////////
|
|
|
|
|
template <typename SymbolResolverType>
|
|
|
|
|
void TModuleProvider<SymbolResolverType>::EnumerateSymbolSearchPaths(TFunctionRef<void(FStringView Path)> Callback) const
|
|
|
|
|
{
|
|
|
|
|
Resolver->EnumerateSymbolSearchPaths(Callback);
|
|
|
|
|
}
|
|
|
|
|
|
2021-01-06 05:44:12 -04:00
|
|
|
/////////////////////////////////////////////////////////////////////
|
2021-06-01 06:05:43 -04:00
|
|
|
template<typename SymbolResolverType>
|
|
|
|
|
void TModuleProvider<SymbolResolverType>::GetStats(FStats* OutStats) const
|
2021-01-06 05:44:12 -04:00
|
|
|
{
|
2021-06-01 06:05:43 -04:00
|
|
|
Resolver->GetStats(OutStats);
|
2022-01-05 05:39:03 -05:00
|
|
|
OutStats->SymbolsDiscovered = SymbolsDiscovered.load();
|
2021-10-25 20:05:28 -04:00
|
|
|
// Add the cached symbols (the resolver doesn't know about them)
|
|
|
|
|
OutStats->SymbolsResolved += NumCachedSymbols;
|
2021-01-06 05:44:12 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/////////////////////////////////////////////////////////////////////
|
2021-06-01 06:05:43 -04:00
|
|
|
template<typename SymbolResolverType>
|
|
|
|
|
void TModuleProvider<SymbolResolverType>::OnModuleLoad(const FStringView& Module, uint64 Base, uint32 Size, const uint8* ImageId, uint32 ImageIdSize)
|
2021-01-06 05:44:12 -04:00
|
|
|
{
|
|
|
|
|
if (Module.Len() == 0)
|
|
|
|
|
{
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
2022-01-05 05:39:03 -05:00
|
|
|
const FStringView NameTemp = FPathViews::GetCleanFilename(Module);
|
|
|
|
|
const TCHAR* Name = Session.StoreString(NameTemp);
|
|
|
|
|
const TCHAR* FullName = Session.StoreString(Module);
|
2021-01-06 05:44:12 -04:00
|
|
|
|
2022-01-05 05:39:03 -05:00
|
|
|
FWriteScopeLock _(ModulesLock);
|
2022-03-09 10:40:47 -05:00
|
|
|
FModule& NewModule = Modules.EmplaceBack(Name, FullName, Base, Size, EModuleStatus::Discovered);
|
2021-01-06 05:44:12 -04:00
|
|
|
|
2022-01-05 05:39:03 -05:00
|
|
|
// The number of cached symbols for this module is equal to the number
|
|
|
|
|
// of matching addresses in the cache.
|
|
|
|
|
NewModule.Stats.Cached = GetNumCachedSymbolsFromModule(Base, Size);
|
2022-03-09 10:40:47 -05:00
|
|
|
|
2022-01-05 05:39:03 -05:00
|
|
|
Resolver->QueueModuleLoad(ImageId, ImageIdSize, &NewModule);
|
2021-01-06 05:44:12 -04:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/////////////////////////////////////////////////////////////////////
|
2021-06-01 06:05:43 -04:00
|
|
|
template<typename SymbolResolverType>
|
|
|
|
|
void TModuleProvider<SymbolResolverType>::OnModuleUnload(uint64 Base)
|
2021-01-06 05:44:12 -04:00
|
|
|
{
|
|
|
|
|
//todo: Find entry, set bLoaded to false
|
|
|
|
|
}
|
|
|
|
|
|
2021-03-15 10:43:52 -04:00
|
|
|
/////////////////////////////////////////////////////////////////////
|
2021-06-01 06:05:43 -04:00
|
|
|
template<typename SymbolResolverType>
|
|
|
|
|
void TModuleProvider<SymbolResolverType>::OnAnalysisComplete()
|
2021-03-15 10:43:52 -04:00
|
|
|
{
|
2021-06-01 06:05:43 -04:00
|
|
|
Resolver->OnAnalysisComplete();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/////////////////////////////////////////////////////////////////////
|
|
|
|
|
template <typename SymbolResolverType>
|
|
|
|
|
void TModuleProvider<SymbolResolverType>::SaveSymbolsToCache(IAnalysisCache& Cache)
|
|
|
|
|
{
|
|
|
|
|
// Create a temporary reverse lookup for symbol -> address
|
|
|
|
|
TMap<const FResolvedSymbol*, uint64> SymbolReverseLookup;
|
|
|
|
|
SymbolReverseLookup.Reserve(SymbolCacheLookup.Num());
|
2022-03-09 10:40:47 -05:00
|
|
|
Algo::Transform(SymbolCacheLookup, SymbolReverseLookup, [](const TTuple<uint64, const FResolvedSymbol*>& Pair) {
|
2021-06-01 06:05:43 -04:00
|
|
|
return TTuple<const FResolvedSymbol*, uint64>(Pair.Value, Pair.Key);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
// Save new symbols
|
|
|
|
|
TCachedPagedArray<FSavedSymbol, 1024> SavedSymbols(TEXT("ModuleProvider.Symbols"), Cache);
|
|
|
|
|
const uint32 NumPreviouslySavedSymbols = SavedSymbols.Num();
|
|
|
|
|
uint32 NumSavedSymbols = 0;
|
|
|
|
|
for (uint32 SymbolIndex = SavedSymbols.Num(); SymbolIndex < SymbolCache.Num(); ++SymbolIndex)
|
|
|
|
|
{
|
|
|
|
|
const FResolvedSymbol& Symbol = SymbolCache[SymbolIndex];
|
|
|
|
|
if (Symbol.GetResult() != ESymbolQueryResult::OK)
|
|
|
|
|
{
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
const uint64* Address = SymbolReverseLookup.Find(&Symbol);
|
|
|
|
|
const uint32 ModuleOffset = Strings.Store_GetOffset(Symbol.Module);
|
|
|
|
|
const uint32 NameOffset = Strings.Store_GetOffset(Symbol.Name);
|
|
|
|
|
const uint32 FileOffset = Strings.Store_GetOffset(Symbol.File);
|
|
|
|
|
SavedSymbols.EmplaceBack(FSavedSymbol{*Address, ModuleOffset, NameOffset, FileOffset, Symbol.Line});
|
|
|
|
|
++NumSavedSymbols;
|
|
|
|
|
}
|
2021-06-03 11:34:07 -04:00
|
|
|
UE_LOG(LogTraceServices, Display, TEXT("Added %d symbols to the %d previously saved symbols."), NumSavedSymbols, NumPreviouslySavedSymbols);
|
2021-06-01 06:05:43 -04:00
|
|
|
}
|
|
|
|
|
|
2022-01-05 05:39:03 -05:00
|
|
|
/////////////////////////////////////////////////////////////////////
|
2021-06-01 06:05:43 -04:00
|
|
|
template <typename SymbolResolverType>
|
|
|
|
|
void TModuleProvider<SymbolResolverType>::LoadSymbolsFromCache(IAnalysisCache& Cache)
|
|
|
|
|
{
|
|
|
|
|
// Load saved symbols
|
|
|
|
|
TCachedPagedArray<FSavedSymbol, 1024> SavedSymbols(TEXT("ModuleProvider.Symbols"), Cache);
|
|
|
|
|
for (uint64 SymbolIndex = 0; SymbolIndex < SavedSymbols.Num(); ++SymbolIndex)
|
|
|
|
|
{
|
|
|
|
|
const FSavedSymbol& Symbol = SavedSymbols[SymbolIndex];
|
|
|
|
|
const TCHAR* Module = Strings.GetStringAtOffset(Symbol.ModuleOffset);
|
|
|
|
|
const TCHAR* Name = Strings.GetStringAtOffset(Symbol.NameOffset);
|
|
|
|
|
const TCHAR* File = Strings.GetStringAtOffset(Symbol.FileOffset);
|
|
|
|
|
if (Module == nullptr || Name == nullptr || File == nullptr)
|
|
|
|
|
{
|
|
|
|
|
UE_LOG(LogTraceServices, Warning, TEXT("Found cached symbol (adress %llx) which referenced unknown string."), Symbol.Address);
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
FResolvedSymbol& Resolved = SymbolCache.EmplaceBack(ESymbolQueryResult::OK, Module, Name, File, Symbol.Line);
|
|
|
|
|
SymbolCacheLookup.Add(Symbol.Address, &Resolved);
|
|
|
|
|
}
|
2021-10-25 20:05:28 -04:00
|
|
|
NumCachedSymbols = SymbolCacheLookup.Num();
|
2021-06-01 06:05:43 -04:00
|
|
|
UE_LOG(LogTraceServices, Display, TEXT("Loaded %d symbols from cache."), SymbolCacheLookup.Num());
|
2021-03-15 10:43:52 -04:00
|
|
|
}
|
|
|
|
|
|
2022-01-05 05:39:03 -05:00
|
|
|
/////////////////////////////////////////////////////////////////////
|
|
|
|
|
template <typename SymbolResolverType>
|
|
|
|
|
uint32 TModuleProvider<SymbolResolverType>::GetNumCachedSymbolsFromModule(uint64 Base, uint32 Size)
|
|
|
|
|
{
|
|
|
|
|
uint32 Count(0);
|
|
|
|
|
const uint64 Start = Base;
|
|
|
|
|
const uint64 End = Base + Size;
|
|
|
|
|
FWriteScopeLock _(SymbolsLock);
|
|
|
|
|
for (auto& AddressSymbolPair : SymbolCacheLookup)
|
|
|
|
|
{
|
2022-01-05 08:45:47 -05:00
|
|
|
const uint64 Address = AddressSymbolPair.template Get<0>();
|
2022-01-05 05:39:03 -05:00
|
|
|
if (FMath::IsWithin(Address, Start, End))
|
|
|
|
|
{
|
|
|
|
|
++Count;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return Count;
|
|
|
|
|
}
|
|
|
|
|
|
2021-01-06 05:44:12 -04:00
|
|
|
/////////////////////////////////////////////////////////////////////
|
|
|
|
|
IModuleAnalysisProvider* CreateModuleProvider(IAnalysisSession& InSession, const FAnsiStringView& InSymbolFormat)
|
|
|
|
|
{
|
2021-03-31 07:56:27 -04:00
|
|
|
IModuleAnalysisProvider* Provider(nullptr);
|
2021-08-10 20:07:09 -04:00
|
|
|
#if PLATFORM_WINDOWS && USE_SYMSLIB
|
|
|
|
|
if (!Provider && (InSymbolFormat.Equals("pdb") || InSymbolFormat.Equals("dwarf")))
|
2021-01-06 05:44:12 -04:00
|
|
|
{
|
2021-03-31 07:56:27 -04:00
|
|
|
Provider = new TModuleProvider<FSymslibResolver>(InSession);
|
2021-01-06 05:44:12 -04:00
|
|
|
}
|
2021-08-10 20:07:09 -04:00
|
|
|
#endif // PLATFORM_WINDOWS && USE_SYMSLIB
|
|
|
|
|
#if PLATFORM_WINDOWS && USE_DBGHELP
|
2021-03-31 07:56:27 -04:00
|
|
|
if (!Provider && InSymbolFormat.Equals("pdb"))
|
|
|
|
|
{
|
|
|
|
|
Provider = new TModuleProvider<FDbgHelpResolver>(InSession);
|
|
|
|
|
}
|
2021-08-10 20:07:09 -04:00
|
|
|
#endif // PLATFORM_WINDOWS && USE_DBGHELP
|
2021-03-31 07:56:27 -04:00
|
|
|
return Provider;
|
2021-01-06 05:44:12 -04:00
|
|
|
}
|
|
|
|
|
|
[Insights]
- TraceServices: Changed ReadNetProfilerProvider, ReadMemoryProvider, ReadDiagnosticsProvider to return a pointer to the respective provider (instead of a reference). Can return nullptr. The UI should not assume the provider exists.
- TraceServices: Added GetNetProfilerProviderName, GetMemoryProviderName, GetDiagnosticsProviderName, GetAllocationsProviderName to return name of respective provider.
- TraceServices: Added ReadModuleProvider + GetModuleProviderName, ReadCallstacksProvider + GetCallstacksProviderName to access respective providers.
- TraceServices: Added a default empty implementation to IModule for GenerateReports, GetLoggers and GetCommandLineArgument.
- TraceServices: Changed FAnalysisService::StartAnalysis to not create default providers for Memory (LLM Stats), NetProfiler and Diagnostics, but to allow the respective modules (FMemoryModule, FNetProfilerModule, FDiagnosticsModule) to create the providers.
- TraceInsights: Fixed UI code to check if the Memory, NetProfiler and Diagnostics provider are available.
#rb Catalin.Dragoiu, Johan.Berg
#ROBOMERGE-SOURCE: CL 16967698 in //UE5/Main/...
#ROBOMERGE-BOT: STARSHIP (Main -> Release-Engine-Test) (v838-16927207)
[CL 16967704 by ionut matasaru in ue5-release-engine-test branch]
2021-07-27 08:19:49 -04:00
|
|
|
/////////////////////////////////////////////////////////////////////
|
|
|
|
|
FName GetModuleProviderName()
|
|
|
|
|
{
|
|
|
|
|
static FName Name(TEXT("ModuleProvider"));
|
|
|
|
|
return Name;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/////////////////////////////////////////////////////////////////////
|
|
|
|
|
const IModuleProvider* ReadModuleProvider(const IAnalysisSession& Session)
|
|
|
|
|
{
|
|
|
|
|
return Session.ReadProvider<IModuleProvider>(GetModuleProviderName());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/////////////////////////////////////////////////////////////////////
|
|
|
|
|
|
2021-01-06 05:44:12 -04:00
|
|
|
} // namespace TraceServices
|
2021-04-06 11:04:09 -04:00
|
|
|
|
|
|
|
|
#undef USE_SYMSLIB
|
|
|
|
|
#undef USE_DBGHELP
|