Files
UnrealEngineUWP/Engine/Plugins/Runtime/HTTPChunkInstaller/Source/Private/LocalTitleFile.cpp

139 lines
2.8 KiB
C++
Raw Normal View History

// Copyright Epic Games, Inc. All Rights Reserved.
#include "LocalTitleFile.h"
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3847469) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3805828 by Gil.Gribb UE4 - Fixed a bug in the lock free stalling task queue and adjusted a comment. The code is not current used, so this is not actually change the way the code works. Change 3806784 by Ben.Marsh UAT: Remove code to compile UBT when using UE4Build. It should already be compiled as a dependency of UAT. Change 3807549 by Graeme.Thornton Add a cook timer around VerifyCanCookPackage. A licensee reports this taking a lot of time so it'll be good to account for it. Change 3807727 by Graeme.Thornton Unhide the text asset format experimental editor option Change 3807746 by Josh.Engebretson Remove WER from iOS platform Change 3807928 by Robert.Manuszewski When async loading, GC Clusters will be created after packages have been processed to avoid situations where some of the objects that are being added to a cluster haven't been fully loaded yet Change 3808221 by Steve.Robb GitHub #4307 - Made GetModulePtr() thread safe by not using GetModule() ^ I'm not convinced by how much thread-safer this is really, but it's tidier anyway. Change 3809233 by Graeme.Thornton TBA: Misc changes to text asset commandlet - Rename mode to "loadsave" - Add -outputFormat option which can be assigned "text" or "binary" - When saving binary, use a differentiated filename so that source assets aren't overwritten Change 3809518 by Ben.Marsh Remove the outdated UnrealSync automation script. Change 3809643 by Steve.Robb GitHub #4277 : fix bug; FMath::FormatIntToHumanReadable 3rd comma and negative value #jira UE-53037 Change 3809862 by Steve.Robb GitHub #3342 : [FRotator.h] Fix to DecompressAxisFromByte to be more efficient and reflect its intent accurately #jira UE-42593 Change 3811190 by Graeme.Thornton Add support for writing specific log channels to their own files Change 3811197 by Graeme.Thornton Minor updates to output formatting and timing for the text asset commandlet Change 3811257 by Robert.Manuszewski Cluster creation will now be time-sliced Change 3811565 by Steve.Robb Define out non-monolithic module functions. Change 3812561 by Steve.Robb GitHub #3886 : Enable Brace-Initialization for Declaring Variables Incorrect semi-colon search removed after discussion with author. Test added. #jira UE-48242 Change 3812864 by Steve.Robb Removal of some unproven code which was supposed to fix hot reloading BP class functions in plugins. See: https://udn.unrealengine.com/questions/376978/aitask-blueprint-nodes-disappear-when-their-module.html #jira UE-53089 Change 3820358 by Ben.Marsh PR #4358: Incredibuild use ShowAgent by default (Contributed by projectgheist) Change 3822594 by Ben.Marsh UAT: Improvements to log file handling. - Always create log files in the final location, rather than writing to a temp directory and copying in later. - Now supports -Verbose and -VeryVerbose for increasing log verbosity, rather than -Verbose=XXX. - Keep a backlog of log output before the log system is initialized, and flush it to the log file once it is. - Allow buildmachines to specify the uebp_FinalLogFolder environment variable, which is used to form paths for display. When build machines copy log files elsewhere after UAT finishes (eg. a network share), this allows error messages to display the right location. Change 3823695 by Ben.Marsh UGS: Fix issue where precompiled binaries would not be shown as available for a change until scrolling the last submitted code change into the buffer (other symptoms, like de-focussing the main window would cause it to go back to an unavailable state, since the changes buffer was shrunk). Now always queries changes up to the last change for which zipped binaries are available. Change 3823845 by Ben.Marsh UBT: Exclude C# projects for unsupported platforms when generating project files. Change 3824180 by Ben.Marsh UGS: Add an option to show changes by build machines, and move the "only show reviewed" option in there too (Options > Show Changes). #jira Change 3825777 by Steve.Robb Fix to return value of StringToBytes. Change 3825810 by Ben.Marsh UBT: Reduce length of include paths for MSVC toolchain. Change 3825822 by Robert.Manuszewski Optimized PIE lazy pointer fixup. Should be up to 8x faster now. Change 3826734 by Ben.Marsh Remove code to disable TextureFormatAndroid on Linux. It seems to be an editor dependency. Change 3827730 by Steve.Robb Try to avoid decltype(auto) if it's not supported. See: https://udn.unrealengine.com/questions/395644/build-417-with-c11-on-linux-ttuple-errors.html Change 3827745 by Steve.Robb Initializer list support for TMap. Change 3827770 by Steve.Robb GitHub #4399 : Added a CONSTEXPR qualifiers to FVariant::GetType() #jira UE-53813 Change 3829189 by Ben.Marsh UBT: Now always writes a minimal log file. By default, just contains the regular console output and any reasons why actions are outdated and needed to be executed. UAT directs child UBT instances to output logs into its own log folder, so that build machines can save them off. Change 3830444 by Steve.Robb BuildVersion and ModuleManifest moved to Core, and parsing of these files reimplemented to avoid a JSON library. This should be revisited when Core has its own JSON library. Change 3830718 by Ben.Marsh Fix incorrect group name being returned by FStatNameAndInfo::GetGroupName() for stat groups. The editor populates the viewport stats list by calling this for every registered stat and stat group (via FLevelViewportCommands::HandleNewStatGroup). The menu entry attempts to show the stat name with STAT_XXX stripped from the start as the menu item label, with the free-form text description as a tooltip. For stat groups, the it would previously just return the stat group name as "Groups" (due to the raw naming convention of "//Groups//STATGROUP_Foo//..."). Since this didn't match the expected naming convention in FLevelViewportCommands::HandleNewStat (ie. STAT_XXX or STATGROUP_XXX), it would fail to add it. When the first actual stat belonging to that group is added, it would add a menu entry for the group based on that, but the stat description no longer makes sense as a tooltip for the group. As a result, all the editor tooltips were junk. #jira UE-53845 Change 3831064 by Ben.Marsh Fix log file contention when spawning UBT recursively. Change 3832654 by Ben.Marsh UGS: Fix error panel not being selected when opened, and weird alignment/color issues on it. Change 3832680 by Ben.Marsh UGS: Fix failing to detect workspace if synced to a different stream. Seems to be a regression caused by recent P4D upgrade. Change 3832695 by Ben.Marsh UGS: Invert the options in the 'Show Changes' submenu for simplicity. Change 3833528 by Ben.Marsh UAT: Script to rewrite source files with public include paths relative to the 'Public' folder. Usage is: RebasePublicIncludePaths -UpdateDir=<Dir> [-Project=<Dir>] [-Write]. Change 3833543 by Ben.Marsh UBT: Allow targets to opt-out of having public include paths added for every dependent module. This reduces the command line length when building a target, which has recently become a problem with larger games (due to Microsoft's compiler embedding the command line into each object file, with a maximum length of 64kb). All engine modules are compiled with this enabled; games may opt into it by setting bLegacyPublicIncludePaths = false; from their .target.cs, as may individual modules. Change 3834354 by Robert.Manuszewski Archetype pointer will now be cached to avoid locking the object tables when acquiring its info. It should also be faster this way regardless of any locks. #jira UE-52035 Change 3834400 by Robert.Manuszewski Fixing crash on exit caused by cached archetypes not being cleaned up before static exit cleanup. #jira UE-52035 Change 3834947 by Steve.Robb USE_FORMAT_STRING_TYPE_CHECKING removed from FMsg::Logf and FMsg::Logf_Internal. Change 3835004 by Ben.Marsh Fix code that relies on dubious behavior of requiring referenced "include path only" modules having their _API macros set to be empty, even if the module is actually implemented in a separate DLL. Change 3835340 by Ben.Marsh Fix errors making installed build from directories with spaces in the name. Change 3835972 by Ben.Marsh UBT: Improved diagnostic message for targets which don't need a version file. Change 3836019 by Ben.Marsh UBT: Fix warnings caused by defining linkage macros for third party libraries. Change 3836269 by Ben.Marsh Fix message box larger than the screen height being created when a large number of modules are incompatible on startup. Change 3836543 by Ben.Marsh Enable SoundMod plugin on Linux, since it's already supported through the editor. Change 3836546 by Ben.Marsh PR #4412: fix type mismatch (Contributed by nakapon) Change 3836805 by Ben.Marsh Fix commandlet to compile marketplace plugins. Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3837036 by Ben.Marsh UBT: Write the previous and new contents of intermediate files to the log if they change. Makes it easier to debug unexpected rebuilds. Change 3837037 by Ben.Marsh UBT: Fix engine modules having inconsistent definitions depending on whether modules are only referenced for their include paths vs being linked into a binary (due to different _API macro). Change 3837040 by Ben.Marsh UBT: Remove code that initializes members in ModuleRules and TargetRules objects before the constructor is run. This is no longer necessary, now that the backwards-compatible default constructors have been removed. Change 3837247 by Ben.Marsh UBT: Remove UELinkerFixups module, now that plugins and precompiled modules do not require hacks to force initialization (since they're linked in as object files). Encryption and signing keys are now set via macros expanded from the IMPLEMENT_PRIMARY_GAME_MODULE macro, via project-specific macros added in the TargetRules constructor. Change 3837262 by Ben.Marsh UBT: Set whether a module is an engine module or not via a default value for the rules assembly. All non-program engine and enterprise modules are created with this flag set to true; program targets and modules are now created from a different assembly that sets it to false. This removes hacks from UEBuildModule needed to adjust behavior for different module types based on the directory containing the module. Also add a bUseBackwardsCompatibleDefaults flag to the TargetRules class, also initialized to a default value from a setting passed to the RulesAssembly constructor. This controls whether modules created for the target should be configured to allow breaking changes to default settings, and is set to false for all engine targets, and true for all project targets. Change 3837343 by Ben.Marsh UBT: Remove the OverrideExecutableFileExtension target property. Change the only current use for this (the MayaLiveLinkPlugin target) to use a post build step to copy the file instead. Change 3837356 by Ben.Marsh Fix invalid character encodings. Change 3837727 by Graeme.Thornton UnrealPak: KeyGenerator: Only generate prime table when required, not all the time Change 3837823 by Ben.Marsh UBT: Output warnings and errors when compiling module rules assembly in a way that allows them to be double-clicked in the Visual Studio output window. Change 3837831 by Graeme.Thornton UBT: When parsing crypto settings, always load legacy data first, then allow the new system to override it. Provides the same key backwards compatibility that the editor settings class gives Change 3837857 by Robert.Manuszewski PR #4404: Make FGCArrayPool singleton global instead of per-CU (Contributed by mhutch) Change 3837943 by Robert.Manuszewski PR #4405: Fix FGarbageCollectionTracer (Contributed by mhutch) Change 3838451 by Ben.Marsh UBT: Fix exceptions thrown on a background thread while caching C++ includes not being caught and logged correctly. Now captures exceptions and re-throws on the main thread. #jira UE-53996 Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 3843790 by Graeme.Thornton UnrealPak: Log the size of all encrypted data Change 3844258 by Ben.Marsh Fix plugin compile failure when created via new plugin wizard. Passing -plugin on the command line is unnecessary, and is now reserved for packaging external plugins for the marketplace. Also extend the length of time that the error toast stays visible, and don't delete the plugin on failure. #jira UE-54157 Change 3845796 by Ben.Marsh Workaround for slow performance of String.EndsWith() on Mono. Change 3845823 by Ben.Marsh Fix case sensitive matching of platform names in -TargetPlatform=X argument to BuildCookRun. #jira UE-54123 Change 3845901 by Arciel.Rekman Linux: fix crash due to lambda lifetime issues (UE-54040). - The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+). (Edigrating 3819174 to Dev-Core) Change 3846439 by Ben.Marsh Revert CL 3822742 to always call Process.WaitForExit(). The Android target platform module in the editor spawns ADB.EXE, which inherits the editor's stdout/stderr handles and forks itself. Process.WaitForExit() waits for EOF on those pipes, which never occurs because the forked process never terminates. Proper fix is probably to have the engine explicitly duplicate stdout/stderr handles for new pipes to output process, but too risky before copying up to Main. Change 3816608 by Ben.Marsh UBT: Use DirectoryReference objects for all include paths. Change 3816954 by Ben.Marsh UBT: Remove bIncludeDependentLibrariesInLibrary option. This is not widely supported by platform toolchains, and is not used anywhere. Change 3816986 by Ben.Marsh UBT: Remove UEBuildBinaryConfig; UEBuildBinary objects are now just created directly. Change 3816991 by Ben.Marsh UBT: Deprecate PlatformSpecificDynamicallyLoadedModules. We no longer have any special behavior for these modules. Change 3823090 by Ben.Marsh UAT: Improve logging for child UAT instances. - Calling RunUAT now requires an identifier for prefixing into the parent log, which is also used to determine the name of the log folder. - Stdout is no longer written to its own output file, since it's written to the parent stdout, the parent log file, and the child log file anyway. - Log folders for child UAT instances are left intact, rather than being copied to the parent folder. The derived names for the copied names were confusing and hard to read. - Output from UAT is no longer returned as a string. It should not be parsed anyway (but may be huge!). ProcessResult now supports running without capturing output. Change 3826082 by Ben.Marsh UBT: Add a check to make sure that all modules that are precompiled are correctly marked to enable it, even if they are part of the build target. Change 3827025 by Ben.Marsh UBT: Move the compile output directory into a property on the module, and explicitly pass it to the toolchain when compiling. Change 3829927 by James.Hopkin Made HTTP interface const correct Change 3833533 by Ben.Marsh Rewrite engine source files to base include paths relative to the "Public" directory. This allows reducing the number of public include paths that have to be added for engine modules. Change 3835826 by Ben.Marsh UBT: Precompiled targets now generate a separate manifest for each precompiled module, rather than adding object files to a library. This fixes issues where object files from static libraries would not be linked into a target if a symbol in them was not referenced. Change 3835969 by Ben.Marsh UBT: Fix cases where text is being written directly to the console rather than via logging functions. Change 3837777 by Steve.Robb Format string type checking added to FOutputDevice::Logf. Fixes for those. Change 3838569 by Steve.Robb Algo moved up a folder. [CL 3847482 by Ben Marsh in Main branch]
2018-01-20 11:19:29 -05:00
#include "HAL/FileManagerGeneric.h"
#include "Misc/Paths.h"
#include "Misc/FileHelper.h"
FLocalTitleFile::FLocalTitleFile(const FString& InRootDirectory)
: RootDirectory(InRootDirectory)
{
RootDirectory.ReplaceInline(TEXT("\\"), TEXT("/"));
if (!RootDirectory.EndsWith(TEXT("/")))
{
RootDirectory.Append(TEXT("/"));
}
}
bool FLocalTitleFile::GetFileContents(const FString& DLName, TArray<uint8>& FileContents)
{
const TArray< uint8 >* ExistingFileContents = DLNameToFileContents.Find(DLName);
if (ExistingFileContents == nullptr)
{
return false;
}
FileContents.Append(*ExistingFileContents);
return true;
}
bool FLocalTitleFile::ClearFiles()
{
FileHeaders.Empty();
DLNameToFileContents.Empty();
return true;
}
bool FLocalTitleFile::ClearFile(const FString& DLName)
{
bool ClearedFile = false;
const FString FileName = GetFileNameFromDLName(DLName);
for (int Index = 0; Index < FileHeaders.Num(); Index++)
{
if (FileHeaders[Index].DLName == DLName)
{
FileHeaders.RemoveAt(Index);
ClearedFile = true;
}
}
DLNameToFileContents.Remove(DLName);
return ClearedFile;
}
void FLocalTitleFile::DeleteCachedFiles(bool bSkipEnumerated)
{
// not implemented
}
bool FLocalTitleFile::EnumerateFiles(const FCloudPagedQuery& Page)
{
const FString WildCard = FPaths::Combine(*RootDirectory, TEXT("*"));
TArray<FString> Filenames;
IFileManager::Get().FindFiles(Filenames, *WildCard, true, false);
for(int32 FileIdx = 0; FileIdx < Filenames.Num(); ++FileIdx)
{
const FString Filename = Filenames[FileIdx];
FCloudHeader NewHeader;
NewHeader.FileName = Filename;
Copying //UE4/GamePlugins-Staging to //UE4/Main (Source: //UE4/GamePlugins-Staging @ 3367064) #lockdown Nick.Penwarden ========================== MAJOR FEATURES + CHANGES ========================== Change 3358095 on 2017/03/22 by robomerge #ROBOMERGE-AUTHOR: allan.bentham Added Android option to enable builds with hidden symbol visbility by default. (bBuildWithHiddenSymbolVisibility) Android links with -gc-sections to remove unused code/data Add JNI_METHOD for java accessible native functions, fix up existing JNI functions to use macro. Add support to generate a map file with android. #jira WEX-5193 #ROBOMERGE-SOURCE: CL 3358094 Change 3356546 on 2017/03/21 by robomerge #ROBOMERGE-AUTHOR: rob.cannaday Possible fix for Mac compile error #ROBOMERGE-SOURCE: CL 3356544 Change 3356276 on 2017/03/21 by robomerge #ROBOMERGE-AUTHOR: rob.cannaday Minor formatting #ROBOMERGE-SOURCE: CL 3356275 Change 3356173 on 2017/03/21 by robomerge #ROBOMERGE-AUTHOR: rob.cannaday Fix "friends of friends" party privacy Restrict publishing of fields to xmpp presence #jira FORT-37155 #ROBOMERGE-SOURCE: CL 3356171 Change 3355310 on 2017/03/20 by robomerge #ROBOMERGE-AUTHOR: justin.sargent Copying //UE4/Portal-Staging to Dev-Main (//UE4/Dev-Main) (Source: //Portal/Main @ 3352026) ========================== MAJOR FEATURES + CHANGES ========================== Change 3351920 on 2017/03/17 by Leigh.Swift #jira OPP-6870: [Crash] Assertion failed: ctx->ReadOffset + length <= (uint32)ctx->CompressedData.Num() [File:D:\Build\++Portal+Release-Live+Compile\Sync\Engine\Source\Runtime\ImageWrapper\Private\PngImageWrapper.cpp] [Line: 420] Instead of asserting for an incorrect data size for png image being loaded, set an error on the wrapper object. This will result in the slate brush rendering as white box, and errors going to the log which include the png resource path. Change 3350561 on 2017/03/16 by Justin.Sargent Updated the Slate standalone D3D renderer to be more fault tolerant. Added new HasLostDevice() function to SlateRenderer. If the launcher detects that it has lost the device context it will attempt to perform a full rebuild of the UI and Presentation layers, but also a full reboot of slate application and the renderer. The launcher will attempt to re-establish the device context for 5 minutes if not interrupted by the user. If the user interacts with the launcher while attempting to re-establish the device context it will instead pop up a system dialog explaining it is having issues with the video card and then will close the application. Change 3341299 on 2017/03/10 by Richard.Fawcett Validate JSON files as we're pushing to EMS Added a flexible validation framework to the system files (EMS) sync operation. Implemented a JSON validator which by default will validate .json files. Adds a "ValidationRules" property to the EMS sync config file to allow each product to define its own regex patterns for filenames which should be validated with each validator. Configured launcher's EMS to validate .product, .v?product, .layout, .sdmeta and .panel files as JSON. The great news is that this validation actually discovered a minor syntactical issue with Wex.v2product during testing, which is also fixed with this submission. \o/ #epicfriday Change 3336908 on 2017/03/08 by Leigh.Swift #jira OPP-5126: All disk size checks for BPS installations should be handled internally to BPS, the Portal code should not need to check this and can only do so less accurately. Removing disk space checks from portal code which block installers from running. NB: There is still a check in selective download code which provides tooltip information only. Moving BuildPatchInstaller disk size check to the file constructor, which is the class that most accurately knows the required amount of space. The disk check now occurs after resume and just before we start to write data. A secondary disk check is also made if a file fails to construct so that we can detect problems caused by change in available disk space. Disk space error message extended to include useful information for the user. Change 3323366 on 2017/02/27 by Richard.Fawcett Fix reference to Newtonsoft in Publishing.Automation. Change 3323205 on 2017/02/27 by Wes.Fudala Adding language support to the windows installer. Significantly expandes OneSky upload functionality. OPP-5438 Launcher installer should support the same language set supported by the launcher. Change 3316926 on 2017/02/22 by Richard.Fawcett Prevent Amazon S3 download glitches from issuing warnings until half of the maximum retries have been attempted. In practice, when we download thousands of files, we _do_ get failures which need to be retried. This means that pretty much all jobs result in warnings, which isn't appropriate. This should turn jobs green again, and only warn us when things look unusual. #jira OPP-6607 Change 3315996 on 2017/02/21 by Justin.Sargent Incrementing Portal version number I'm incrementing this earlier than normal due to a need to depend on a new version number for EMS layout change versioning. Change 3312760 on 2017/02/20 by Wes.Fudala Users can now select desired environment/region from the UI. New login screen. Adds slid out settings menu to login screen. Adds region and language selection to the settings menu. Adds support for PortalRegions ini. Adds DefaultPortalRegions ini. Adds RegionRepository, RegionPublisher, RegionSelectService, and RegionIdentificationService. Adds region select option in debugtools general section. Adds RegionSelectService unit test with associated mocks. Changes the way all backend connections are configured so that values are now pulled from config files. Renames product region selector files to avoid some confusion with portal region files. Updated EmsConfigUpdater and HotfixManager so they support optional overwrite and save of ini files. Region publisher now restricts regions that require permissions in shipping builds. Fixes a bug causing items to get stuck in the download queue UI after we failed to obtain a manifest when reaching out the the backend. #jira OPP-6121, OPP-5809 Change 3311664 on 2017/02/20 by Andrew.Brown Added GetTypeHash support for FDelegateHandle Change 3311505 on 2017/02/20 by Richard.Fawcett Rename/move file(s) Change 3309004 on 2017/02/17 by Chad.Garyet adding in additional platforms for the BuildPlugin commandline Change 3299188 on 2017/02/13 by Leigh.Swift #jira OPP-6711: [CRASH] Assertion failed: IsComplete() Race condition in portal hack allowed an installer to attempt to execute complete delegate before being complete. Change 3294197 on 2017/02/09 by Richard.Fawcett Adding ValidPrereqIds.json This is needed now because the script to enforce correct prereq ids reaches out to Perforce to access this file! #jira OPP-6583 Change 3294059 on 2017/02/09 by Richard.Fawcett Fix comment on PostBuild parameter to reference correct name of "Manifest" property. Change 3293377 on 2017/02/08 by Richard.Fawcett Remove need for a metadata file containing name of generated manifest when using randomized manifest filenames. Change 3282865 on 2017/02/02 by Richard.Fawcett Simplify params to BuildGraph's ChunkTask / PostBuildTask Also, downgrade warnings to simple log messages when falling back to legacy manifest filename construction to ease transition into randomized manifest filenames for game teams. #jira OPP-6435 Change 3282809 on 2017/02/02 by Leigh.Swift #jira OPP-6564: BPT will crash if the FileIgnoreList input instructs the build streamer to ignore every build file. A race condition for getting to the first scanner creation code, vs the build stream exiting with no data. If the former wins, a scanner will be created without enough data to scan. Scanners are now no longer created if the buildstream provided no data. Change 3280848 on 2017/02/01 by Leigh.Swift #jira OPP-3864: BuildPatchServices will log a FATAL error on shutdown even if it's fine to be shutting down. When BPS is shutdown, it will only set error states and cancellation logic if any installers are actually created. Change 3280839 on 2017/02/01 by Leigh.Swift Fixing whitespace damage incoming from Dev-Staging Change 3280820 on 2017/02/01 by Andrew.Brown Copying //Portal/Dev-Main-Staging to Main (//Portal/Main) Change 3280797 on 2017/02/01 by Leigh.Swift #jira OPP-6649: BPS sends undocumented analytics events. Adding documentation for the following events: Patcher.Error.Download Patcher.Warning.ChunkAborted Patcher.Error.Cache Patcher.Error.Construction Patcher.Error.Prerequisites Change 3278887 on 2017/01/31 by Richard.Fawcett Downgrade cleanup warnings to normal log output. The conditions which used to trigger these warnings are now considered to be normal behavior, in a world in which we carry out cross-app game promotions. This results in a perma-yellow state for cleanup, which is unhelpful. #nojira Change 3278738 on 2017/01/31 by Richard.Fawcett Tweak Conan launch parameters Change 3277066 on 2017/01/30 by Richard.Fawcett Remove temporary code which cleans up P:\Builds\UnrealEngineLauncher\BuildGraph, as the location no longer exists. Change 3274907 on 2017/01/27 by Leigh.Swift #jira OPP-6615: Receiving a whisper while in game may minimize game client. Refactoring SWindow ActivateOnFirstShown bool to be ActivationPolicy to give more accurate control. This also allows fixing of misuses of previous ActivateOnFirstShown variables in the implementations, which appear to mostly be interpreting it as 'AlwaysActivate'. The upgrade path is therefore ActivateOnFirstShown true/false becomes ActivationPolicy Always/Never. Moving initial minimize and maximise logic for FWindowsWindow into the Show() call on first show to gain control of activation and respect the provided policy. Refactoring existing uses to use the new variables/functions instead. The refactor of existing code is focused on preserving current always activate behaviour as opposed to changing behaviour to actually only activate on first show. Change 3273466 on 2017/01/26 by Alex.Fennell New build of OpenSSL libraries #JIRA OPP-6408 PriceEngine configuration and fixes for bugs it introduced. Change 3268045 on 2017/01/23 by Richard.Fawcett Re-adding Funcom folk to Conan chunk notification emails Change 3267709 on 2017/01/23 by Richard.Fawcett Fix launch arguments for Conan Exiles editor. Temporarily remove FunCom recipients from notification list to avoid spamming. Change 3265774 on 2017/01/20 by Chad.Garyet Merge of Engine/Build/Buildfarm over to //Portal from Dev-Build Change 3264674 on 2017/01/19 by Alex.Fennell On demand catalog requests Change 3263654 on 2017/01/19 by Leigh.Swift #jira OPP6562: Support looking up tagging and sdmeta info and using it in build diff output Adding tag use understanding to the manifest diff tool of BPT. Adding Selective Download feature support to PPT for it's diff tool, making use of portal's metadata for the feature. Change 3263623 on 2017/01/19 by Richard.Fawcett Fix issue where ManifestFilename is not always available at post build time. #jira OPP-6606 Change 3262013 on 2017/01/18 by Richard.Fawcett Remote potential for success email being sent on third party chunk failure Change 3261914 on 2017/01/18 by Richard.Fawcett Fix for user content generation job not specifying a manifest filename. Change 3261800 on 2017/01/18 by Richard.Fawcett Implement streaming S3 downloads to disk, rather than just to memory This is needed because C# has a 2 billion maximum array dimension, so files > 2GB can't be downloaded using the existing code. Change 3261675 on 2017/01/18 by Richard.Fawcett Support for overriding, or generating randomized unique manifest filenames to avoid automated harvesting from CDN BuildGraph's ChunkTask takes three new parameters ... * ManifestFilename (string) - The filename of the manifest to produce. If omitted, the value of RandomizeManifestFilename will determine how the manifest filename is determined. * RandomizeManifestFilename (bool) - If true, we'll generate a random, unique manifest filename. If false (default), we'll use legacy behavior of combining app name and build version. * LocalManifestDir (string) - Required if RandomizedManifestFilename is true. This directory will receive local copies of any manifest file produced, and a metadata file containing the name of the most recently produced manifest BuildGraph's PostBuildTask takes two new parameters ... * ManifestFilename (string) - The filename of the manifest to post. If omitted, we'll use the value from the metadat file in LocalManifestDir is this is set, otherwise use legacy behavior. * LocalManifestDir (string) - A directory containing local copies of manifest files, along with a metadata file containing the name of the manifest file produced by the most recent ChunkTask operation. Support added to the launcher build script's to use the new parameters to randomize its manifest filename, and post the randomized filename to MCP. Use of a contructor of BuildPatchToolStagingInfo which does not specify a manifest filename is now considered deprecated, and will output a warning. Remove requirement of having a BuildPatchToolStagingInfo when performing a chunking operation, instead just passing in the specific values we need from it as parameters in their own right. Remove support for non-chunk based manifests from C# wrapper, as these are no longer supported in BuildPatchTool itself. #jira OPP-6432 Change 3261647 on 2017/01/18 by Leigh.Swift Adding some cleanup to the end of some BPT functional tests so that they do not affect proceeding tests and cause red-herring warning output. Change 3261639 on 2017/01/18 by Richard.Fawcett Update app name of Conan to ConanExiles to match back-end catalog. Fix Conan launch exe and args so that launcher can detect when product is running. Was previously using a batch file which terminates after launching editor. Change 3258815 on 2017/01/16 by Wes.Fudala UTM and product info will be parsed from installer name and passed to the launcher. UTM info will be passed along as part of all analytics events. #jira OPP-6404: Add user funnel tracking Change 3258809 on 2017/01/16 by Wes.Fudala Back out changelist 3258800. Backing out changes that were intended to be made in a different stream. Change 3258800 on 2017/01/16 by Wes.Fudala App version is now also appended to user agent string. Change 3256999 on 2017/01/13 by Richard.Fawcett Fix issue where JSON file included in Publishing csproj is not reliably copied to output folder on build farm. Change 3256941 on 2017/01/13 by Richard.Fawcett Move configuration for Third Party build pipeline out of code and into its own configuration file. #epicfriday Change 3255072 on 2017/01/12 by Richard.Fawcett Add additional logging around multithreaded upload of files to S3. Fix bug ensuring that the failure of any single part of multi-part upload results in the whole file being failed. #jira OPP-6392 Change 3253672 on 2017/01/11 by Richard.Fawcett Add support for third-party Conan editor. Alter third party process so it doesn't crash if version.txt doesn't already exist in the third party S3 bucket, to allow us to setup in advance of third party publishing their first version. Change 3251901 on 2017/01/10 by Barnabas.McManners Compile fix on mac, fix for hidden method in AutomationTest define. Without this GoogleMock.spec.cpp wont compile on mac. #nojira #ReviewedBy Leigh.Swift Change 3250907 on 2017/01/09 by Justin.Sargent Changed the automation controller to uses a non-zero exit code when performing a 'quit' command if tests failed. Change 3245328 on 2017/01/03 by Justin.Sargent Enabling the logic to lowercase all C++ members exposed to javascript. Added additional to-lowering behavior to UObject binding. #jira OPP-6494 Change 3240667 on 2016/12/20 by Andrew.Brown Copying //Tasks/Portal/Dev-OPP-6109-DedicatedServer to Dev-Main (//Portal/Dev-Main) Change 3236972 on 2016/12/15 by Bob.Ferreira Updating compliation changes for AutomationDriver Change 3236567 on 2016/12/15 by Richard.Fawcett Ensure that third party product chunking uses latest CL across our P4 depot in its version number. Change 3236188 on 2016/12/15 by Richard.Fawcett Combine all launcher purchases into single workflow using the new quickPurchase API call as the initial request. #jira OPP-6257 Change 3231134 on 2016/12/12 by Alex.Fennell Improving fail case handling for the waiting room service #jira OPP-5648 Change 3228514 on 2016/12/09 by Richard.Fawcett Change filetype Change 3227080 on 2016/12/08 by Barnabas.McManners Merging CL 3226840 from Dev Editor Fixing a bug in FText formatting where it would ignore the rebuild and Rebuild as Source arguments for the format string itself #jira OPP-6485 Change 3219810 on 2016/12/02 by Ben.Marsh UAT: Fix unzip output being completely discarded. Switch it to just be verbose instead. Change 3219602 on 2016/12/02 by Ben.Marsh Add the -q (quiet) option to the Mac unzip command, since it's creating too much log output to be useful. #ROBOMERGE-SOURCE: CL 3355309 Change 3354720 on 2017/03/20 by robomerge #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Rename GetSessionJoinabilityFromSettings now that it handles more than just join - New name is GetLiveSessionRestrictionFromSettings #RB Rob.Cannaday #ROBOMERGE-SOURCE: CL 3354716 Change 3351603 on 2017/03/17 by robomerge #ROBOMERGE-AUTHOR: peter.sauerbrei make it so the chunk installer knows about pre-installed chunks (chunks in the IPA/APK) #jira WEX-4037 #ROBOMERGE-SOURCE: CL 3351599 Change 3350895 on 2017/03/16 by robomerge #ROBOMERGE-AUTHOR: peter.knepley Revert change to OGF module load times, the real culprit was found #ROBOMERGE-SOURCE: CL 3350891 Change 3350492 on 2017/03/16 by robomerge #ROBOMERGE-AUTHOR: peter.knepley Load some modules in predefault stage, was causing issues loading editor #ROBOMERGE-SOURCE: CL 3350490 Change 3350251 on 2017/03/16 by robomerge #ROBOMERGE-AUTHOR: sam.spiro #fort When the MCP attempts to grant items into the theater profile and fails, it will failover to granting the items into the outpost profile Outpost profile does not respect 'max number of stacks allowed per template' rules Results structure from granting rewards on the MCP will contain the profile that the result item was placed in #RB david.nikdel [CODEREVIEW] todd.eckert, billy.bramer #ROBOMERGE-SOURCE: CL 3350247 Change 3349312 on 2017/03/16 by robomerge #ROBOMERGE-AUTHOR: andrew.grant Merging //Orion/Main to Dev-General (//Orion/Dev-General) #tests compiled #ROBOMERGE-SOURCE: CL 3349305 Change 3348530 on 2017/03/15 by Rob.Cannaday Unblock robomerge conflict Source=CL 3345747 in //UE4/Main/Engine/Plugins/... Author=ben.marsh Change 3347162 on 2017/03/15 by robomerge #ROBOMERGE-AUTHOR: david.nikdel #MCP #Analytics #ECom: - Added storefrontName and gameContext strings to the standard EComGameCatalogPurchase event - Storefront name is derived from the offer (Which storefront it was listed on, should be a game-specific enum) - gameContext is a place for clients to put additional game-specific purchase annotations like UI state etc - Also added Storefront string to FStorefrontOffer on the client - Client hookup should just involve setting a GameContextProvider TFunction on your catalog helper. [CODEREVIEW] Chris.Bosley, Darren.Clarey, Sam.Zamani, Philip.Buuck, Ian.Fox #JIRA: WEX-5504 #ROBOMERGE-SOURCE: CL 3347161 Change 3346599 on 2017/03/14 by robomerge #ROBOMERGE-AUTHOR: sam.spiro #fort Remove bInStorageVault Make being in the outpost inventory mean being in storage Switch batch profile updates to use commandrevision instead of profilerevision Migration to move outpost storage items to the new outpost profile Make fortinventory check to determine correct profile be correct #RB billy.bramer, todd.eckert, david.nikdel #ROBOMERGE-SOURCE: CL 3346596 Change 3344207 on 2017/03/13 by robomerge #ROBOMERGE-AUTHOR: rob.cannaday Replace MakeShareable with MakeShared in OnlinePartyMcp.cpp #ROBOMERGE-SOURCE: CL 3344205 Change 3343608 on 2017/03/13 by robomerge #ROBOMERGE-AUTHOR: james.brinkerhoff Hotfix from CL 3343509 for crash in McpProfile during hot reload [CODEREVIEW] Josh.Andersen, Jaren.Peterson, Scott.Bowen #ROBOMERGE-SOURCE: CL 3343607 Change 3343510 on 2017/03/13 by robomerge #ROBOMERGE-AUTHOR: david.nikdel #Profile #OGF: - Check for State in AddReferencedObjects (apparently there's an invisible ctor just for CDOs?) - Don't make a new FMcpProfileState in the ctor since the call to ResetInternal will just re-create one. [CODEREVIEW] Josh.Andersen, Josh.Markiewicz, Sam.Zamani, Scott.Bowen #JIRA: none #ROBOMERGE-SOURCE: CL 3343509 Change 3343086 on 2017/03/13 by robomerge #ROBOMERGE-AUTHOR: bart.hawthorne Fully implement play together. Invites are sent to the player's party, and if the party is full at the time, go back to the frontend and send the invites (to comply with Sony's recommended flow). Also if no party exists, wait until the frontend is navigated to to send them. [CODEREVIEW] ian.fox #ROBOMERGE-SOURCE: CL 3343085 Change 3341765 on 2017/03/10 by robomerge #ROBOMERGE-AUTHOR: james.brinkerhoff Merging //UE4/Ocean-Staging to //Ocean/Main for GamePlugins @ CL 3334799 #ROBOMERGE-SOURCE: CL 3337558 Change 3341763 on 2017/03/10 by robomerge #ROBOMERGE-AUTHOR: james.brinkerhoff Merging //UE4/Ocean-Staging/Ocean/Plugins/Online to //Ocean/Main/Ocean/Plugins/Online @ CL 3334799 #ROBOMERGE-SOURCE: CL 3336358 Change 3341754 on 2017/03/10 by Sam.Zamani =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Merging //UE4/Ocean-Staging to //Ocean/Main @ CL 3331740 #ROBOMERGE-SOURCE: CL 3334652 #ROBOMERGE-SAYS: Unresolved conflicts. james.brinkerhoff, please merge this change by hand. //ROBOMERGE_OGS_Main/PluginTestGame/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/Private/OnlineChatMcp.cpp //ROBOMERGE_OGS_Main/PluginTestGame/Plugins/Online/NotForLicensees/PurchaseFlow/Source/Private/SPurchaseFlow.cpp //ROBOMERGE_OGS_Main/PluginTestGame/Plugins/Online/PS4/OnlineSubsystemPS4/Source/OnlineSubsystemPS4.Build.cs #CodeReview: james.brinkerhoff, david.nikdel, greg.latcovich, sam.zamani =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Change 3341618 on 2017/03/10 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - added define for OGS feature [CODEREVIEW] sam.zamani #tests compiles #ROBOMERGE-SOURCE: CL 3341616 Change 3341613 on 2017/03/10 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - removed old define #tests compiles #ROBOMERGE-SOURCE: CL 3341612 Change 3340771 on 2017/03/09 by robomerge #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystem - Add move semantics to OnlineSessionSetting classes #ROBOMERGE-SOURCE: CL 3340769 Change 3340693 on 2017/03/09 by robomerge #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Support JoinSession for non-player hosted sessions - Compare UniqueNetIdStr directly instead of copying and comparing when finding users - Live JoinSession now calls delegates on next tick (OSS is moving into this pattern) #ROBOMERGE-SOURCE: CL 3340692 Change 3339360 on 2017/03/09 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - one more unity fix #JIRA none #ROBOMERGE-SOURCE: CL 3339359 Change 3339281 on 2017/03/09 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - removed WebBrowser moduel dependency on OnlineSubsystem - added 2 functions to online engine interface [CODEREVIEW] sam.zaman, ben.marsh #ROBOMERGE-SOURCE: CL 3339280 Change 3337834 on 2017/03/08 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - add refresh auth call to Windows implementation of Google sign - expanded auth token to handle refresh auth credentials passed in by app #JIRA none #ROBOMERGE-SOURCE: CL 3337833 Change 3337281 on 2017/03/08 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - added GetEmptyUniqueId to MCP - added it in two quick places, but more widespread use is needed #JIRA none #ROBOMERGE-SOURCE: CL 3337041 Change 3337276 on 2017/03/08 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Facebook fixups - GetEmptyUniqueId for consistent creation of a empty unique id without more memory allocations - non unity fixes - tabify #JIRA none #ROBOMERGE-SOURCE: CL 3337039 Change 3337273 on 2017/03/08 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Google fixups - GetEmptyUniqueId for consistent creation of a empty unique id without more memory allocations - non unity fixes - tabify #JIRA none #ROBOMERGE-SOURCE: CL 3337038 Change 3334384 on 2017/03/06 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Google auth cleanup and storage of additional auth data #JIRA none #ROBOMERGE-SOURCE: CL 3334379 Change 3333910 on 2017/03/06 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - added boolean to redirect handling code to indicate that the redirect was handled by the OSS - Google works via other redirects to get you back to login/pass screen, ignoring this leaves game in soft lock #JIRA none #ROBOMERGE-SOURCE: CL 3333907 Change 3333891 on 2017/03/06 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - fixed base64 encoded JWT handling #JIRA none #ROBOMERGE-SOURCE: CL 3333887 Change 3333341 on 2017/03/06 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - added basic parsing of Google JWT id token - fixed compiler issue related to default syntax #JIRA none #ROBOMERGE-SOURCE: CL 3333340 Change 3333115 on 2017/03/06 by robomerge #ROBOMERGE-AUTHOR: peter.sauerbrei fix for Win32 compile failure [CODEREVIEW] josh.markiewicz #jira none #ROBOMERGE-SOURCE: CL 3333114 Change 3332169 on 2017/03/03 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - fixed unity compile issue #JIRA none #ROBOMERGE-SOURCE: CL 3332165 Change 3331990 on 2017/03/03 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - missed pragma declaration accidentally left on #JIRA none #ROBOMERGE-SOURCE: CL 3331989 Change 3331983 on 2017/03/03 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Online Subsystem consistency cleanup - all OSS classes use the instance name passed into the CreateFactory function - nothing should be using the default constructor - OnlineSubsystemImpl requires two params now (OSS name, Instance name) - added GetSubsystemName to return OSS name from OnlineSubsystemNames.h #JIRA none #ROBOMERGE-SOURCE: CL 3331981 Change 3331967 on 2017/03/03 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Facebook - tighten redirect check so that the URL must start with a specific value #JIRA none #ROBOMERGE-SOURCE: CL 3331966 Change 3331963 on 2017/03/03 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Facebook - changed literals to FString default constructors - added explicit keyword to several constructors #JIRA none #ROBOMERGE-SOURCE: CL 3331962 Change 3331959 on 2017/03/03 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Login Flow manager - multiple OSS's can be registered with manager to handle web user consent forms - added delegate firing for "before browse" to catch Google redirects #JIRA none #ROBOMERGE-SOURCE: CL 3331958 Change 3331956 on 2017/03/03 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Google sign-in first pass - discovery service query - user consent screen - token exchange for access/refresh token - retrieve user profile - logout #JIRA WEX-5103 #ROBOMERGE-SOURCE: CL 3331955 Change 3331421 on 2017/03/03 by robomerge #ROBOMERGE-AUTHOR: james.hopkin #ogf Fixed incorrect copy/pasted log message #ROBOMERGE-SOURCE: CL 3331420 Change 3330392 on 2017/03/02 by robomerge #ROBOMERGE-AUTHOR: andrew.grant Merging //Orion/Main to Dev-General (//Orion/Dev-General) #tests #rb na #ROBOMERGE-SOURCE: CL 3330388 Change 3330341 on 2017/03/02 by robomerge #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemPS4 - Port Friend Session from engine OSS [CODEREVIEW] Bart.Hawthorne #ROBOMERGE-SOURCE: CL 3330340 Change 3330222 on 2017/03/02 by robomerge #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemPS4 - Fix invite/join panel on PS4 to show friends [CODEREVIEW] Bart.Hawthorne #ROBOMERGE-SOURCE: CL 3330220 Change 3330206 on 2017/03/02 by Sam.Zamani fix for bad merge Change 3330089 on 2017/03/02 by robomerge #ROBOMERGE-AUTHOR: sam.zamani Fix for missing persona service #tests none #ROBOMERGE-SOURCE: CL 3330054 Change 3330088 on 2017/03/02 by robomerge #ROBOMERGE-AUTHOR: sam.zamani fixed updated module rules #tests regen projects #ROBOMERGE-SOURCE: CL 3329982 Change 3330084 on 2017/03/02 by Sam.Zamani Copying //Tasks/Orion/Dev-Online-Tencent to Dev-General (//Orion/Dev-General) #tests none #ROBOMERGE-SOURCE: CL 3329964 Change 3329937 on 2017/03/02 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Moved Filter Substring out of MCP into common class for sharing with other OSS code [CODEREVIEW] sam.zamani #ROBOMERGE-SOURCE: CL 3329934 Change 3329907 on 2017/03/02 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Tabify #ROBOMERGE-SOURCE: CL 3329902 Change 3329653 on 2017/03/02 by robomerge #ROBOMERGE-AUTHOR: andrew.grant Merging from //UE4/Main @ 3322856 through Orion-Staging #tests QA #ROBOMERGE-SOURCE: CL 3329651 Change 3328946 on 2017/03/02 by Ian.Fox #OnlineSubsystemNEX - Fix compile errors for latest engine - Identity change matches upstream's fix Change 3328918 on 2017/03/02 by Ian.Fox #OnlineSubsystemNEX - Configure NEX PCH usage to match the rest of OSS Change 3328902 on 2017/03/02 by robomerge #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Fix non-unity include #ROBOMERGE-SOURCE: CL 3328901 Change 3327277 on 2017/03/01 by robomerge #ROBOMERGE-AUTHOR: andrew.grant Merging //Orion/Main to Dev-General (//Orion/Dev-General) #tests preflighted #ROBOMERGE-SOURCE: CL 3327270 Change 3326725 on 2017/03/01 by Ian.Fox #Social - Fix XboxOne EC warnings #CodeReview Justin.Sargent Change 3326719 on 2017/03/01 by Ian.Fox #OnlineSubsystemNEX - Fix UBT include order warning Change 3326607 on 2017/02/28 by robomerge #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Fix non-unity include - The real include is required due to TUniquePtr deletion #ROBOMERGE-SOURCE: CL 3326589 Change 3326604 on 2017/02/28 by robomerge #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Use an error number constant instead of the literal #ROBOMERGE-SOURCE: CL 3326582 Change 3326601 on 2017/02/28 by robomerge #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Fix lamda capture #ROBOMERGE-SOURCE: CL 3326561 Change 3326597 on 2017/02/28 by robomerge #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Auto-Update friend/presence session information when it changes [CODEREVIEW] Ryan.Gerleve #ROBOMERGE-SOURCE: CL 3326560 Change 3326262 on 2017/02/28 by robomerge #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Set live session readability to match joinability [CODEREVIEW] Ryan.Gerleve #ROBOMERGE-SOURCE: CL 3326261 Change 3325970 on 2017/02/28 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #Orion - added command line overrides for non-shipping builds - force cloud saves to disk -skipusersettings - skip hotfix checks -skiphotfixcheck #tests login golden path #ROBOMERGE-SOURCE: CL 3325969 Change 3325429 on 2017/02/28 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - tabify #ROBOMERGE-SOURCE: CL 3325427 Change 3322857 on 2017/02/25 by robomerge #ROBOMERGE-AUTHOR: andrew.grant Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3316439) Change 3315047 on 2017/02/21 by Mieszko.Zielinski HTN code first check in #UE4 #test currently unused Change 3314042 on 2017/02/21 by Jason.Bestimt #ORION_DG - DAILY Main @ CL 3313484 #RB:none #Tests:none Change 3313355 on 2017/02/20 by Uriel.Doyon Changed the preliminary GPU benchmark workloads to take into account the target workload. This is to prevent running the last test with poor performance, risking a driver reset. #jira OR-29915 #test Run the game triggering benchmarks Change 3312553 on 2017/02/20 by Mieszko.Zielinski Implemented a simple AITask for running EQS queries #UE4 #test golden path Change 3311661 on 2017/02/20 by Jason.Bestimt #ORION_DG - Merge MAIN @ CL 3311631 #RB:none #Tests:none Change 3310392 on 2017/02/17 by Daniel.Lamb Unreal pak now outputs to named log files instead of timestamps. #test Cook deploy paragon #jira OR-36057 Change 3310196 on 2017/02/17 by Clayton.Langford Created an event to be fired whenever a GameplayCue is routed that passes all relevant info about that GC. Added a listener in OrionPhasedFunctionalTest that parses that event into a string and stores it in an array to be accessed from a test phase later. #test PIE Change 3308437 on 2017/02/16 by Jason.Bestimt #ORION_DG - Merge MAIN @ CL 3308413 (Prep for Merge up) #RB:none #Tests:none Change 3306497 on 2017/02/16 by Andrew.Grant Fix for compilation issue with USE_MALLOC_STOMP #tests compiled with malloc_stomp Change 3306468 on 2017/02/16 by Cody.Haskell #Orion - Text popup work for Shield. If you click on an OrionEditableTextBox while running the game with -gfn, a special popup is called. Should do nothing normally. #tests PIE, golden path. Change 3305945 on 2017/02/16 by David.Ratti Remove unused/deprecated UGameplayEffectExtension class Change 3304630 on 2017/02/15 by Jason.Bestimt #ORION_DG - Merge Mieszko stuff from MAIN to DG #RB:none #TestS:none #!codereview: mieszko.zielinski Change 3303785 on 2017/02/15 by jason.bestimt #ORION_MAIN - Merge 38.3 @ CL 3303224 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3303718 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) #!ROBOMERGE-SAYS: Unresolved conflicts. jason.bestimt, please merge this change by hand. //Orion/Dev-General/OrionGame/Content/UI/DeckBuilder/DeckBuilderRoot.uasset - can't integrate exclusive file already opened //Orion/Dev-General/OrionGame/Content/UI/Master_Layouts/FrontEnd.uasset - can't integrate exclusive file already opened #!codereview: jason.bestimt Change 3302382 on 2017/02/14 by Alexis.Matte Fix import of morph target when there is no animation #jira UE-41383 #jira OR-35859 #test none Change 3301538 on 2017/02/14 by Jason.Bestimt #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 38.3 @ CL 3301392 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3301481 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3299985 on 2017/02/13 by Lukasz.Furman added time limit to "get out of overlap" move for minons to avoid getting stuck in moving to inaccessbile spots #jira OR-35834 #tests PIE Change 3299732 on 2017/02/13 by Mieszko.Zielinski Tweaked the way EQS tests of negative score get normalized #UE4 #test golden path + math #!codereview Lukasz.Furman, John.Abercrombie Change 3299724 on 2017/02/13 by Mieszko.Zielinski Generic AI interface extensions #UE4 Mostly getters #test golden path Change 3299717 on 2017/02/13 by Mieszko.Zielinski A little tweak to VisLog's point labels drawing - if there's only one point in a set it will no longer append '_0' to the label #UE4 #test PIE Change 3299527 on 2017/02/13 by Paul.Moore #orion #mms - Update libWebSockets binaries to fix Linux server web socket connections. #tests matchmaking, mms Change 3299278 on 2017/02/13 by David.Ratti Ability Task Pass: tasks should not broadcast out (back into ability graph) if the owning ability has completed EndAbility. #tests pie, golden path Change 3297884 on 2017/02/10 by Paul.Moore #mms - Enable SSL module for PS4 (needed by OpenSSL when using WebSockets). - Turn on verbose logging for WebSockets module for initial MMS debugging. #tests PS4 Change 3296911 on 2017/02/10 by John.Pollard Encode user search string so we support special characters #tests Replays Change 3296746 on 2017/02/10 by Jason.Bestimt #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 38.3 @ CL 3296659 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3296735 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3296705 on 2017/02/10 by Daniel.Lamb Added support to the cooker for iterating shared builds. #test Fast cook paragon Change 3295747 on 2017/02/09 by Paul.Moore #orion #mms - Integrated WS upgrade header functionality with latest Fortnite libws changes. - Added "ws" and "wss" protocols to web socket manager context. #!codereview rob.cannaday, james.hopkin #tests win64, ps4 Change 3295579 on 2017/02/09 by John.Pollard Fix for replay backward compatibility from John.Pollard #tests #rb na Merging using OrionScratchReleaseMapping Change 3295506 on 2017/02/09 by Rolando.Caloca O - Added option for force recompute tangents using skin cache #jira UE-41541 #tests Editor run, toggle, restart Change 3295461 on 2017/02/09 by Lukasz.Furman fixed huge interpolation times for linear network smoothing on stationary characters, fixed mismatch in movement Base between NavWalking server and Walking client, causing some stationary characters to float in midair copy of CL# 3295439 #jira OR-35664, OR-35572 #tests game Change 3294954 on 2017/02/09 by Paul.Moore #orion #mms - Integrating Fortnite WebSocket changes into Orion that fixes some win10 issues. #!codereview rob.cannaday, james.hopkin #tests compile ps4, linux, win64 Change 3294947 on 2017/02/09 by Daniel.Lamb The generate stub return result is considered as success when saving cooked packages. Fixes bug with cooking blueprint nativized packages. #test Cook paragon Change 3293307 on 2017/02/08 by Andrew.Grant Fix for issue in last checkin - need to clear activecontext regardless #tests solo smoke with nullrhi Change 3293284 on 2017/02/08 by Ryan.Gerleve Allow setting the per-frame time limit for processing queued bunches separately for instant replays, since they may have more strict timing/framerate requirements. #tests golden path Change 3293148 on 2017/02/08 by Andrew.Grant Fixed invalid memory access* with nullrhi and suppressed IME warning if no valid window handle exists (*Likely only an issue when running with memory validation) #tests verified invalid access exception no longer occurs with nullrhi #!review-3293149 @Matt.Khulenschmidt Change 3293103 on 2017/02/08 by Max.Chen Sequencer: Fix build #jira OR-34918 #tests none Change 3292921 on 2017/02/08 by Max.Chen Sequencer: Force local player to maintain x fov axis. #jira OR-34918 #tests Render/PIE a level sequence and test that the camera isn't zoomed in. Change 3292869 on 2017/02/08 by David.Ratti Yet more logging for OR-35448 Change 3292821 on 2017/02/08 by Jason.Bestimt #!ROBOMERGE-AUTHOR: rob.cannaday PS4 libwebsockets build fix Update build cs files to point to PS4 file location Copy libwebsocket include directory from Fortnite to Orion #tests compile/link Win64 Development Editor, PS4 Debug, Linux Development Server #!ROBOMERGE-SOURCE: CL 3292820 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3292277 on 2017/02/08 by Jason.Bestimt #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge DMM @ CL 3292219 #RB:none #Tests:none [CODEREVIEW] paul.moore, benjamin.crocker [QAREVIEW] #!ROBOMERGE-SOURCE: CL 3292276 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3292211 on 2017/02/08 by Andrew.Grant Pulling new ags library from Release-4.15 and reverting hack that disabled feature for AMD users #tests compiled Change 3292167 on 2017/02/08 by David.Ratti Additional logging for OR-35448 #tests pie Change 3289462 on 2017/02/06 by Ben.Salem Adding priority filters to Automation tests, also commands to filter on priority levels. #tests Compiled, ran a few commands to verify it works. Change 3288801 on 2017/02/06 by Jason.Bestimt #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 (38.3) @ CL 3288681 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3288800 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3288750 on 2017/02/06 by Daniel.Lamb Fixed issue when cooking client and server platforms in single cook some packages would be marked incorrectly because they would be stripped when from client / server. #test Cook paragon Change 3288624 on 2017/02/06 by Andrew.Grant Unlocked network version OR-35603 Change 3288612 on 2017/02/06 by Daniel.Lamb Added more ini settings to the iterative ini blacklist. #test Iterative Cook Paragon Change 3288184 on 2017/02/06 by Andrew.Grant Downgraded warning to display #!review-3288185 @David.Ratti #tests none Change 3287634 on 2017/02/06 by Jason.Bestimt #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ 3287498 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3287619 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3286668 on 2017/02/03 by Alexis.Matte Fix a crash when importing a LOD containing different material with less sections #test none Change 3286112 on 2017/02/03 by Alexis.Matte Fix the re-import skeletal mesh regression, where all material disapear. #jira UE-41294 #test see the jira Change 3285859 on 2017/02/03 by Daniel.Lamb Fixed merge error from last checkin with the DDC commandlet #!codereview Matthew.Griffin #test DDC commandlet paragon Change 3285637 on 2017/02/03 by Ryan.Gerleve Pass in the DemoNetDriver pointer to the ConcurrentWithSlateTickTask instead of accessing it from the world in the task itself. #tests golden path Change 3285479 on 2017/02/03 by Mieszko.Zielinski Made bot communicate ults when they're up, not when they're using it #Orion CL also contains a bit of code shuffling around, preparing ground for HTN plug in #test golden path Change 3285125 on 2017/02/03 by Jason.Bestimt #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3285078 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3285124 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3283996 on 2017/02/02 by Michael.Trepka Added UGameUserSettings::GetRecommandedResolutionScale() to replace UOrionGameUserSettings::GetDefaultResolutionScale(). This makes things less confusing (UGameUserSettings::GetRecommandedResolutionScale() returns scale recommended based on results of the benchmark and UGameUserSettings::GetDefaultResolutionScale() returns scale based on user settings) and fixes a regression introduced in 3257936 (OR-35544) #tests Tested on PC Change 3283951 on 2017/02/02 by Daniel.Lamb Ensure DDC commandlet calls begincacheforcookedplatformdata correctly. #!codereview Matthew.Griffin #test DDC commandlet paragon. Change 3283874 on 2017/02/02 by Lina.Halper fix for invalid resource issue #rb: none #code review: Daniel.Wright #tests: compile and editor with wolf Change 3283621 on 2017/02/02 by Laurent.Delayen Femme WIP whip aiming for Q ability. #tests Femme Change 3283216 on 2017/02/02 by jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3282900 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3283199 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3282954 on 2017/02/02 by Lina.Halper It becomes invalid on the resource, so checking null, but still wip on verifying this with Daniel Wright. He's sick out. #rb:none #tests: compile #code review:Daniel.Wright #Jira: OR-35418 Change 3281993 on 2017/02/01 by Daniel.Lamb Removed default unattended flag. #test PS4 cook run paragon. Change 3281990 on 2017/02/01 by Daniel.Lamb Potential fix for deterministic cooking issue with UMovieSceneSignedObjects. #!codereview Max.Preussner #test Cook and run paragon ps4. Change 3281610 on 2017/02/01 by Laurent.Delayen AimOffsetLookAt is now thread safe. #tests femme Change 3281609 on 2017/02/01 by Laurent.Delayen Fixed 'Convert to AimOffset LookAt' option being broken in Persona. #tests works for Femme now. Change 3281019 on 2017/02/01 by Jason.Bestimt #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3280498 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3281018 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3280813 on 2017/02/01 by Jason.Bestimt #!ROBOMERGE-AUTHOR: matthew.griffin Prevent inclusion of NotForLicensees files when staging CrashReportClient config files #tests none #!ROBOMERGE-SOURCE: CL 3280812 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3279921 on 2017/01/31 by Yanni.Tripolitis Fixed an error in the Round MF, that was somehow "leaked" into Paragon from Odin. #!codereview Tim.Elek Change 3279178 on 2017/01/31 by Daniel.Lamb Fixed up diff files commandlet stack information #test Diff cooked packages Change 3279084 on 2017/01/31 by Andrew.Grant Merging //UE4/Main at 3276432 through Orion-Staging Change 3279078 on 2017/01/31 by Jason.Bestimt #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3279032 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3279077 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3277908 on 2017/01/30 by Jason.Bestimt #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_37 - Fix for "-game" crash with missing meta data #RB:none #Tests:none [CodeReviewed]: andrew.grant, jamie.dale, mieszko.zielinski #!ROBOMERGE-SOURCE: CL 3277901 in //Orion/Release-37/... via CL 3277902 via CL 3277904 via CL 3277905 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3277520 on 2017/01/30 by Andrew.Grant Workaround for OR-35418 #!ROBOMERGE: Main #tests verified ShortSoloGame test completes without a crash Change 3277357 on 2017/01/30 by Daniel.Lamb Fixed the rebuild lighting commandlet. #test Rebuild lighting dev general Change 3277322 on 2017/01/30 by Jason.Bestimt #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3277275 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3277296 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3277210 on 2017/01/30 by Jason.Bestimt #!ROBOMERGE-AUTHOR: andrew.grant Non-shipping test changes: Fixed issue where with -stdout messages would be duplicated due to FeedbackContextAnsi echoing to stdout by default Changed stdout output to postfix instead of trail newlines Firstpass of finding and displaying crash callstacks in Orion Test Framework. #tests ran test framework with tests that purposefully crashed/checked #!ROBOMERGE-SOURCE: CL 3276889 in //Orion/Release-37/... via CL 3277207 via CL 3277208 via CL 3277209 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3276774 on 2017/01/29 by Andrew.Grant Fix for non-unity issue. #tests compiled #!ROBOMERGE: Main, DUI Change 3276594 on 2017/01/28 by Lina.Halper Checked in potential fix for nonunity build issue #rb:none #tests:compile Change 3275806 on 2017/01/27 by Ben.Salem Adding in a checkpointing system for automated test passes where, if a client crashes while running a pass, on reboot and reissue of the automation command the test pass will start off where it left off, skipping the crashing test. #tests Ran several dozen test passses. Seriously. #!codereview steve.white, bob.ferreira, clayton.langford, adric.worley Change 3275803 on 2017/01/27 by Shaun.Kime Paragon has retainer widgets with no World set. When encountered, they can cause the scene list to be desynchronized with the rendering thread. This logic resolves the issue by registering a null scene in this case, properly setting the slate scene index for subsequent slate draw calls. #jira OR-34919 #TESTS na Change 3275533 on 2017/01/27 by Max.Chen Sequencer: Switch to static pointer to fix crash when tearing down curve editor. #jira UE-40796 #tests none Change 3275093 on 2017/01/27 by Jason.Bestimt #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3273298 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3273417 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3274700 on 2017/01/26 by Lina.Halper #Anim curve crash on cooking - fixed crash during cooking while accessing default value of material - this code doesn't have to run during cooking with inactive world, so I'm checking that #code review: Daniel.Wright, Chris.Bunner, Jurre.DeBaare #rb: none #tests: cooking Change 3274129 on 2017/01/26 by Lina.Halper Fixed safer to get featurelevel #rb: Daniel.Wright #tests: compile/wolf Change 3274012 on 2017/01/26 by Lukasz.Furman fixed crash in navigation grids #jira OR-35356 #tests PIE Change 3273803 on 2017/01/26 by Lina.Halper Fixed issue with animation curve getting reset to 0.f - the issue is that skeleton contains material flag types, so now it just keeps setting the value - even after I fix validation check, it still cleared it due to the material curve not found anymore, so added to support default value setting #jira: OR-34563 #rb: Martin.Wilson, Chris.Bunner, Benn.Gallagher #code review: Martin.Wilson, Daniel.Wright #tests: wolf, coil Change 3273257 on 2017/01/26 by Alexis.Matte Isolate by material slot instead of section index. Add UI to isolate and highlight material in the material panel #jira UE-41131 #tests none Change 3272527 on 2017/01/25 by Jason.Bestimt #!ROBOMERGE-AUTHOR: chris.bunner Ensure FSceneRenderTargets snapshot copies default clear colors. #tests Golden path on lowest and high settings #jira OR-34905 #!ROBOMERGE-SOURCE: CL 3272507 in //Orion/Release-37.1/... via CL 3272521 via CL 3272525 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3272244 on 2017/01/25 by Rolando.Caloca Show more info when a material instance failed to compile #jira OR-34626 #tests Forced crash in the debugger Change 3272109 on 2017/01/25 by Jason.Bestimt #!ROBOMERGE-AUTHOR: philip.buuck Fix bad merge from Main #tests PIE [CodeReviewed] Andrew.Grant #!ROBOMERGE-SOURCE: CL 3272106 in //Orion/Release-37.1/... via CL 3272107 via CL 3272108 #!ROBOMERGE-BOT: ORION (Main -> Dev-General) Change 3271721 on 2017/01/25 by Lukasz.Furman jungle minions will spawn navigation obstacles when they are stuck in static geometry, fixed issues with falling off cliffs #jira OR-35054 #tests PIE Change 3271432 on 2017/01/25 by Jason.Bestimt #!ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3271043 #RB:none #Tests:none #!ROBOMERGE-SOURCE: CL 3271429 in //Orion/Main/... #!ROBOMERGE-BOT: ORION (Main -> Dev-General) #ROBOMERGE-SOURCE: CL 3322856 Change 3321772 on 2017/02/24 by robomerge #ROBOMERGE-AUTHOR: marc.audy Copying //UE4/Release-Staging-4.15 to //UE4/Dev-Main (Source: //UE4/Release-Staging-4.15 @ 3321730) #ROBOMERGE-SOURCE: CL 3321770 Change 3321594 on 2017/02/24 by robomerge #ROBOMERGE-AUTHOR: jason.bestimt #ORION_DG - MAIN @ CL 3321563 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3321591 Change 3321303 on 2017/02/24 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Facebook fixups - shadow variable - include header fixups #ROBOMERGE-SOURCE: CL 3321301 Change 3320921 on 2017/02/24 by Ian.Fox #OnlineGameplayFramework - Fix 4.16 deprecations #CodeReview James.Hopkin Change 3320799 on 2017/02/23 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - speculative fix for unity compile issue #ROBOMERGE-SOURCE: CL 3320797 Change 3320541 on 2017/02/23 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - more Facebook cleanup #ROBOMERGE-SOURCE: CL 3320172 Change 3320540 on 2017/02/23 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - whitelist android platform for Facebook plugin #ROBOMERGE-SOURCE: CL 3319948 Change 3320539 on 2017/02/23 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Last of the facebook cleanup - moved profile fields to common - added facebook profile picture to profile and friends structures - moved FacebookError to OnlineSubsystemFacebookTypes.h #ROBOMERGE-SOURCE: CL 3319897 Change 3319183 on 2017/02/23 by robomerge #ROBOMERGE-AUTHOR: david.nikdel #CatalogHelper - Add a delegate to allow providing game-specific purchase limit behavior #ROBOMERGE-SOURCE: CL 3319182 Change 3317973 on 2017/02/22 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Facebook SDK for Android enabled #ROBOMERGE-SOURCE: CL 3317968 Change 3317967 on 2017/02/22 by robomerge #ROBOMERGE-AUTHOR: josh.markiewicz #WEX - first pass at friends and sharing permission features for Facebook Android #ROBOMERGE-SOURCE: CL 3317964 Change 3317698 on 2017/02/22 by rob.cannaday Remove OnlinePersonaMcp, replace with calls to OnlineAccountMappingMcp #jira TEN-49 #tests console command "online test users queryuser <displayname, email address>" #ROBOMERGE-SOURCE: CL 3317384 #ROBOMERGE-SAYS: Unresolved conflicts. rob.cannaday, please merge this change by hand. //ROBOMERGE_OGS_Main/PluginTestGame/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/Private/OnlineSubsystemMcp.cpp #CodeReview: rob.cannaday, david.nikdel, greg.latcovich, sam.zamani Change 3317429 on 2017/02/22 by robomerge #ROBOMERGE-AUTHOR: peter.knepley Fix excel bridge dll loading for UT #ROBOMERGE-SOURCE: CL 3317428 Change 3317095 on 2017/02/22 by Sam.Zamani =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3314870) ========================== MAJOR FEATURES + CHANGES ========================== Change 3284872 on 2017/02/03 by Graeme.Thornton Seperate pak cache granularity from pak signing chunk size Change 3285765 on 2017/02/03 by Graeme.Thornton Fix stats warnings because each slate new loading screen thread has the same stat name, but is assigned to a different thread #jira UE-41478 Change 3286913 on 2017/02/04 by Ben.Marsh IncludeTool: Merging fixes. * Don't remove existing forward declarations unless explicitly instructed to do so. Files are optimized with these declarations in place, so removing them can cause output files to fail to build. It can be a useful separate step though, so expose it as a command-line option instead. * Add a specific option for which files should be output by the tool. Any files which are excluded from this list are treated specially when generating output files, so as to prevent them from causing files to be omitted from other files that include them. Also add an option to force this mode for all headers, for use when testing formatting/include path generation. Change 3287100 on 2017/02/05 by Ben.Marsh UBT: Move platform settings into platform-specific TargetRules objects. Change 3287106 on 2017/02/05 by Ben.Marsh Merge UEBuildPlatformContext into UEBuildPlatform. Now that targets can have platform-specific settings, there is no need to separate a platform class which contains target-specific information. Change 3287398 on 2017/02/06 by Steve.Robb Fix for UHT failing when -WarningsAsErrors and -Verbose are specified together. Change 3287399 on 2017/02/06 by Steve.Robb Log verbosities made more readable in the debugger. Change 3287410 on 2017/02/06 by Steve.Robb Fix for TStructOpsTypeTraits where WithCopy gives a different result between specializing the traits and not providing WithCopy and not specializing the traits at all. [FYI] marc.audy Change 3288020 on 2017/02/06 by Ben.Marsh Prevent forward declaration of the ITextData class. We need to include the header for the debugger visualizers to work correctly. Change 3291817 on 2017/02/08 by Steve.Robb New EBlueprintCompileReinstancerFlags used to construct FBlueprintCompileReinstancer, instead of lots of bools. Change 3292090 on 2017/02/08 by Graeme.Thornton Crash fix - don't update font engine services if it was never created #jira UE-33953 Change 3292993 on 2017/02/08 by Ben.Marsh Add an option to disable force-including PCHs for files in the non-unity working set. (bAdaptiveUnityDisablesPCH) Change 3293231 on 2017/02/08 by Ben.Marsh BuildGraph: Allow overriding the changelist that a badge should be displayed for (with the Change="" attribute on the Badge declaration in XML), so the code changelist can be used if necessary. Also link to the failed step if only one has failed. Change 3294213 on 2017/02/09 by Ben.Marsh EC: Allow setting a property on frequent CI jobs that allows us to exclude it from job searches for generating the dashboard. Filtering on the client side is causing dashboard pages to be almost empty. Change 3294753 on 2017/02/09 by Ben.Zeigler #jira UE-41151 Fix UObjectLibrary::RemoveObject to remove from the correct array, and add comment mentioning that the dynamic use of Object Library is semi-deprecated Change 3296070 on 2017/02/09 by Ben.Zeigler Explicitly turn off Copy for a struct that has a linked list internally. I think turning Copy on by default for all non POD Types is pretty risky and is likely to crash for other games. In this case it was being copied for network replication, and it didn't have one defined so the default C++ one copied the linked list and crashed on destruction. Change 3296420 on 2017/02/10 by Graeme.Thornton Remove remaining references to AES_KEY, instead using the encryption key delegates to access the key where needed Refactored encryption and signing key access in unrealpak to make it easier to use Change 3296609 on 2017/02/10 by Ben.Marsh BuildGraph: Fix error running the <Copy> task with an empty "From" argument. * FileSystemReference.IsUnderDirectory() was not correctly handling cases where the directory was a root directory (and has to end in a path separator) * FilePattern.AsDirectoryReference() with an empty token would append a path separator to an empty string, resulting in it referencing the root directory rather than the given base directory. Change 3297440 on 2017/02/10 by Ben.Marsh UBT: Move the FileFilter class into UnrealBuildTool. Change 3297725 on 2017/02/10 by Ben.Zeigler #jira UE-39199 Fix issue with enum value redirects using the wrong short or long name, it now fully supports both. Clean up a lot of confusingly named and broken functions on UEnum: #jira UE-41348 Deprecate FindEnumIndex, GetEnum, GetEnumName, replace with GetIndexByName, GetNameByIndex, and GetNameStringByIndex and clean up warnings #jira UE-38187 Deprecate GetDisplayNameText and GetEnumText, replaced both with GetDisplayNameTextAtIndex which is now callable outside the editor and has a better comment Deprecate FindEnumRedirects and replace with GetIndexByNameString. Fix code to not check the redirects array 5 times per enum lookup Fix GetValueAsString to actually act on a value, not an index. This matches common usage and the function's name While fixing deprecation warnings on internal games, fixed dozens of cases where it was using Index functions when it should have been using Value functions Delete some now redundant enum editor code and pipe everything through UEnum Change 3297979 on 2017/02/10 by Ben.Zeigler Fix issues parsing Enums that are literally the string "None", which is allowed but leads to some odd behavior Change 3298299 on 2017/02/10 by Steve.Robb TTuple improvements: - equality comparable - serializable - in the correct folder 2-tuples are specialized to be syntactically compatible with both TPair and TTuple. TPair is now an alias for a 2-tuple and is no longer bound to TPairInitializer. [FYI] robert.manuszewski,ben.marsh Change 3298460 on 2017/02/11 by Ben.Marsh UGS: Set the correct result from running custom tasks. Change 3298462 on 2017/02/11 by Ben.Marsh UBT: Fix some deprecated messages that have the wrong release version, and add a better message for how ModuleRules constructors need to be updated. Change 3299447 on 2017/02/13 by Graeme.Thornton Fix AES and pak signing key embedding for content only projects - Force temp target when any keys are specified by project config Change 3299649 on 2017/02/13 by Steve.Robb PLATFORM_HAS_DEFAULTED_OPERATORS fixed. Other obsolete compiler switches removed. Change 3299787 on 2017/02/13 by Steve.Robb IsAbstract() for testing if a reflected native type contains pure virtual functions. Needed for BP nativization. [FYI] robert.manuszewski Change 3300576 on 2017/02/13 by Ben.Marsh EC: Add support for starting builds on any agent type. Mapping from agent types to resource pools is stored in an EC property sheet (/Generated/<Stream>/AgentTypes), allowing EC procedures to map it to a resource pool from a parameter. Change 3300600 on 2017/02/13 by Ben.Marsh EC: Add the -ClearHistory argument to UAT run to export BuildGraph settings, to allow running on incremental workspaces. Change 3300624 on 2017/02/13 by Ben.Marsh Switch incremental builds for all streams to start up on the incremental agent. Change 3302134 on 2017/02/14 by Steve.Robb UnrealCodeAnalyzer removed. [FYI] ben.marsh,robert.manuszewski Change 3302639 on 2017/02/14 by Ben.Zeigler Fix crash cooking odin with default command line #jira UE-41952 Delete StealthTeleport map that crashes on load, and update default cook list that gets used if nothing specified Change 3303002 on 2017/02/14 by Ben.Zeigler #jira UE-41061 Fix it so editor only filtering on savepackage is uniformly applied regardless of if it's at package or object level #jira UE-41880 Rewrite editor/client/server only filtering logic in SavePackage to fix various bugs. It now does all of the filtering up front, and won't process any filtered objects for imports or exports Rename NotForEditorGame to NotAlwaysLoadedForEditorGame and improve comments, this flag says that the asset should be loaded EVEN IF it is editor only, it does not affect loading for normal objects Change the non-map cook flags to RF_Public instead of RF_Standalone. Blueprint classes aren't RF_Standalone so were only being cooked before due to an accident of the dependency checker Change it so anything with a Transient outer is marked transient at save time. These objects would not save out properly anyway Fix it so -cooksinglepackage works properly again and excludes localization and startup packages Tested with Fortnite and Odin, Odin works but with lots of warnings with nativization on which I need to investigate Change 3303084 on 2017/02/14 by Ben.Zeigler Attempt to get Nativization and EDL working without warnings Change 3305153 on 2017/02/15 by Ben.Zeigler Fix Fortnite and Orion cook, I don't understand why this passed my local testing Fix the CDO subobject finder to actually return things instead of doing nothing, and fix a shadow variable warning Change 3305959 on 2017/02/16 by Gil.Gribb UE4 - Tweaked out the EDL loader for the switch with benefits to all platforms. Change 3306159 on 2017/02/16 by Ben.Marsh Fix path to target binaries when building non-monolithic in a unique build environment. Change 3306584 on 2017/02/16 by Steve.Robb UEnum internal functions renamed from Index to Value. GetValueAsString_Internal() parameter now takes an int64, as is expected for enum values. [FYI] ben.zeigler Change 3307836 on 2017/02/16 by Ben.Zeigler #jira UE-42055 Load very old redirects in cooked builds. Matinee has no way of resaving redirects, so as long as matinee exists we need to keep them around forever, or fix matinee manually Fixes lighting in Infiltrator demo Change 3307929 on 2017/02/16 by Ben.Zeigler #jira UE-42055 Second half of matinee redirector fix Change 3308840 on 2017/02/17 by Matthew.Griffin Reimplementing CL#3305808 from 4.15 Changed QA label build process so that it only allows version with 3 components (we always add the .0 for initial releases) Change 3309115 on 2017/02/17 by Ben.Marsh Windows: Fix the GetModulesDirectory() function always returning the engine binaries directory. It's possible to build non-monolithic targets which output all engine binaries to the game binaries directory - a requirement to being able to set game-specific defines or build settings, because we don't want shared engine binaries to be tainted with them. The module manager needs to be able to operate early on, before many of the game settings have been initialized, so just return the directory containing the Core module instead. Change 3309120 on 2017/02/17 by Ben.Marsh Fix support for creating modular builds which don't use the shared build environment. Change 3309125 on 2017/02/17 by Ben.Marsh Require that -CookDir arguments are specified separately on the command line. '+' is a valid path character (and common in build versions), so we shouldn't treat it as an argument separator. Change 3309128 on 2017/02/17 by Ben.Marsh Fix UnrealPak failures when enumerating all files from a source directory, if that directory happens to contain spaces. Change 3309131 on 2017/02/17 by Ben.Marsh Fix list of discovered assets being cleared by second call to FindFilesRecursive() when building DDC. Disable the -cookdir parameter again. Change 3309140 on 2017/02/17 by Ben.Marsh UAT: Fix exception moving a file from one location to another if the target directory does not exist. Change 3309212 on 2017/02/17 by Ben.Marsh Fixes/improvements for mod editor and code mods: * A separate top-level project is generated for each code mod in the Visual Studio solution. * Plugin descriptors now have a flag to identify themselves as mod as opposed to a regular game plugin, which prevents project plugins from getting their own VS project. New mods created with the mod editor will have this set by default, as do the three existing sample mods. * Cleaning and building code mods will never modify engine binaries. Presence of the Engine/Build/InstalledProjectBuild.txt file is used to indicate running in this environment. This flag also disables options to edit metadata for non-mod plugins in installed builds. * Plugin browser now includes a separate category for mods. * Mod editor now behaves as an "installed" program by default, and will use the user's home folder for storing settings. Change 3309231 on 2017/02/17 by Steve.Robb Fix for Ar << bSomeBool where Ar is a derived class which overrides an operator<<. #jira UE-42052 Change 3309248 on 2017/02/17 by Ben.Marsh Add support for hot-reloading game plugin modules from Visual Studio, as long as their module returns IsGameModule() = true. Change 3309257 on 2017/02/17 by Ben.Marsh Prevent game binaries from being renamed for hot reload when working with installed projects. Change 3309355 on 2017/02/17 by Steven.Hutton Changes to make the website compatible with the new database changes. Change 3309371 on 2017/02/17 by Ben.Marsh Fix exception on shutdown when running asset registry with threads disabled. #jira UE-41951 Change 3309389 on 2017/02/17 by Ben.Zeigler #jira UE-42051 Fix ensure and crash when loading a null asset ID via the LoadAsset BP node Change 3309570 on 2017/02/17 by Gil.Gribb UE4 - Switch load time performace tweaks, plus abstracted the IO tracker and handle manager for other platforms and applied it to the PS4. Change 3310039 on 2017/02/17 by Ben.Marsh BuildGraph: Prevent exception when trying to delete a file that does not exist. Change 3311484 on 2017/02/20 by Chris.Wood CrashReportProcess crash add retry logic improvements (CRP v1.2.16) Change 3311600 on 2017/02/20 by Matthew.Griffin Updated StripSymbols functions so that all platforms can deal with the source and target file being the same Change 3311675 on 2017/02/20 by Steve.Robb FNativeClassHeaderGenerator::CurrentSourceFile stack replaced with C++ stack. Change 3311893 on 2017/02/20 by Ben.Marsh UGS: Add support for notifying users if CIS steps fail for content changes. Badges which test content should be listed in the [Notifications] section of the project-specific INI file, through +ContentBadges= lines. Change 3313966 on 2017/02/21 by Ben.Marsh Fix EC parsing of error messages output by the editor in the form "LogXYZ:Error:". Greedy optional subexpression in regex was matching everything until a space, so terminate a colon too. Change 3314398 on 2017/02/21 by Ben.Zeigler #jira UE-42212 Fix shutdown of AnimGraph module to be safer #ROBOMERGE-SOURCE: CL 3315211 =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Change 3316706 by David.Nikdel (ROBOMERGE_OGS_GamePlugins_Main) on 2017-02-22 10:47:02 files affected: //GamePlugins/Main/PluginTestGame/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/Private/OnlineIdentityMcp.cpp#19 (integrate) //GamePlugins/Main/PluginTestGame/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/Private/OnlineServiceAvailabilityMcp.cpp#3 (integrate) //GamePlugins/Main/PluginTestGame/Plugins/Online/OnlineFramework/Source/Hotfix/Private/UpdateManager.cpp#6 (integrate) //GamePlugins/Main/PluginTestGame/Plugins/Online/OnlineFramework/Source/Lobby/Public/LobbyBeaconState.h#3 (integrate) //GamePlugins/Main/PluginTestGame/Plugins/Online/OnlineSubsystem/Source/Private/OnlineKeyValuePair.cpp#10 (integrate) //GamePlugins/Main/PluginTestGame/Plugins/Online/OnlineSubsystemOculus/Source/Private/IPAddressOculus.h#3 (integrate) Change 3316369 on 2017/02/22 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Mark Team Chat as rejoin on XMPP reconnect #jira OR-36143 #ROBOMERGE-SOURCE: CL 3316368 Change 3316365 on 2017/02/22 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Make UPartyGameState::ProcessJoinRequest const #ROBOMERGE-SOURCE: CL 3316363 Change 3316270 on 2017/02/22 by James.Hopkin Merging CL#3289494 (update of Steam plugin to match new Steam SDK version in engine) //UE4/Main/Engine/Plugins/Online/OnlineSubsystemSteam/... to //GamePlugins/Main/PluginTestGame/Plugins/Online/OnlineSubsystemSteam/... Change 3315836 on 2017/02/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: sam.spiro #fort Create separate outpost profile and synch it in conjunction with the theater profile [CODEREVIEW] billy.bramer #ROBOMERGE-SOURCE: CL 3315835 Change 3315831 on 2017/02/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystem - Remove double include of ThreadSafeBool #ROBOMERGE-SOURCE: CL 3315829 Change 3315592 on 2017/02/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Facebook Android .pom formatting #ROBOMERGE-SOURCE: CL 3315588 Change 3315561 on 2017/02/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Facebook TPS files for iOS and Android latest SDKs #ROBOMERGE-SOURCE: CL 3315560 Change 3315559 on 2017/02/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Facebook SDK for Android - New POMs / JARs / AARs #ROBOMERGE-SOURCE: CL 3315558 Change 3315551 on 2017/02/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Facebook iOS auth canceled string uses define #ROBOMERGE-SOURCE: CL 3315550 Change 3315504 on 2017/02/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Facebook Android #ROBOMERGE-SOURCE: CL 3315500 Change 3315495 on 2017/02/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Facebook IOS #ROBOMERGE-SOURCE: CL 3315492 Change 3315494 on 2017/02/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Facebook Windows #ROBOMERGE-SOURCE: CL 3315491 Change 3315493 on 2017/02/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Facebook Common #ROBOMERGE-SOURCE: CL 3315490 Change 3315292 on 2017/02/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - GooglePlay IAP fixed bad raw prices, forgot to add conversion to base units #ROBOMERGE-SOURCE: CL 3315290 Change 3313971 on 2017/02/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Disable UPartyBeaconState::SanityCheckReservations in shipping builds #ROBOMERGE-SOURCE: CL 3313969 Change 3313537 on 2017/02/20 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Add temp debug logging to failed NP init for packaged builds #ROBOMERGE-SOURCE: CL 3313535 Change 3312801 on 2017/02/20 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Disable debug logging for entitlements - This was accidentally left on on commit #ROBOMERGE-SOURCE: CL 3312798 Change 3312380 on 2017/02/20 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Fix party leader not able to kick players from lobby #jira FORT-36881 #ROBOMERGE-SOURCE: CL 3312376 Change 3310721 on 2017/02/18 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Fix casing typo #ROBOMERGE-SOURCE: CL 3310719 Change 3310708 on 2017/02/18 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Fix live session join restrictions not properly being set on session creation #ROBOMERGE-SOURCE: CL 3310706 Change 3309877 on 2017/02/17 by Jason.Bestimt #ROBOMERGE-AUTHOR: peter.sauerbrei Merging using WEX_Main_to_UE4_WEX_Staging [CODEREVIEW] david.nikdel, greg.latcovich, sam.zamani #ROBOMERGE-SOURCE: CL 3305019 Change 3308440 on 2017/02/16 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_DG - Merge MAIN @ CL 3308413 (Prep for Merge up) #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3308437 Change 3308433 on 2017/02/16 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Improve error messages for AsyncTask exceptions #ROBOMERGE-SOURCE: CL 3308431 Change 3308186 on 2017/02/16 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Move QueryOffers into async task #ROBOMERGE-SOURCE: CL 3308183 Change 3307625 on 2017/02/16 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Fix some non-unity includes #ROBOMERGE-SOURCE: CL 3307621 Change 3304276 on 2017/02/15 by Jason.Bestimt #ROBOMERGE-AUTHOR: justin.sargent Made changes to support the new shopping cart feature being integrated into the UE marketplace. Add support for javascript access to client and api version information #jira OPP-6632 Add support for bulk purchasing offers #jira OPP-6631 Error pages now properly load even after multiple navigations #jira OPP-6613 Changed the UE marketplace to no longer use two different CEF windows to manage it's UI and instead only one. Changed the catalog mcp to always return all the offers/items queried for instead of just the ones that were updated. Fixed regressions with local host support #ROBOMERGE-SOURCE: CL 3304273 Change 3303904 on 2017/02/15 by Jason.Bestimt #ROBOMERGE-AUTHOR: peter.knepley QosModule needs to be exported so that UT can link with it non-monolithicly #ROBOMERGE-SOURCE: CL 3303902 Change 3303845 on 2017/02/15 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 -removed newly added short circuit in qos to prevent assert when setting forced regions #tests dev mode through to main menu #ROBOMERGE-SOURCE: CL 3303838 Change 3303789 on 2017/02/15 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 38.3 @ CL 3303224 #RB:none #Tests:none //Orion/Dev-General/OrionGame/Content/UI/DeckBuilder/DeckBuilderRoot.uasset - can't integrate exclusive file already opened //Orion/Dev-General/OrionGame/Content/UI/Master_Layouts/FrontEnd.uasset - can't integrate exclusive file already opened [CODEREVIEW] jason.bestimt #ROBOMERGE-SOURCE: CL 3303718 Change 3302970 on 2017/02/14 by Jason.Bestimt #ROBOMERGE-AUTHOR: joe.wilcox UT-7568 Hooked up Jin's new URL for production UT-7665 No longer bring up the chat window when the game begins if there happens to be some chat in the box. #ROBOMERGE-SOURCE: CL 3302964 Change 3302832 on 2017/02/14 by Jason.Bestimt #ROBOMERGE-AUTHOR: james.hopkin #oss Fixed tabbing #ROBOMERGE-SOURCE: CL 3302817 Change 3302569 on 2017/02/14 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Qos pings marked incomplete if region doesn't hit all N of the request pings - number of responses recorded during pass - added AllRegionsFound function that returns true only if ping was received from all known regions - added IsPingable function to differentiate from IsUsable #tests pings on login and network settings screen #ROBOMERGE-SOURCE: CL 3302543 Change 3302076 on 2017/02/14 by Jason.Bestimt #ROBOMERGE-AUTHOR: david.nikdel #WEX: Force redownloading the master manifest when we change environments during chunk download [CODEREVIEW] Peter.Sauerbrei, Bruce.Knapik #ROBOMERGE-SOURCE: CL 3302067 Change 3301829 on 2017/02/14 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Implement QueryPartyJoinability in UParty Intended to be used to check a party invitations validity prior to leaving the current party / zone, as invitations can linger for extended periods of time and the party can become full, or the inviter could join a different party, or could go offline, etc. #jira FORT-35747 #ROBOMERGE-SOURCE: CL 3301821 Change 3301815 on 2017/02/14 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Add a method to query a party's joinability to do a light weight check prior to leaving current party to attempt a full join Intended to be used to check a party invitations validity prior to leaving the current party / zone, as invitations can linger for extended periods of time and the party can become full, or the inviter could join a different party, or could go offline, etc. #jira FORT-35747 #ROBOMERGE-SOURCE: CL 3301811 Change 3301319 on 2017/02/14 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday When players advertise a new party leader, move their player reservation to the new leader's party reservation If there isn't a reservation that has the new leader as the leader, a new reservation will be created #jira FORT-34793 #ROBOMERGE-SOURCE: CL 3301317 Change 3300556 on 2017/02/13 by Jason.Bestimt #ROBOMERGE-AUTHOR: david.nikdel #ChunkInstaller - CompatibleClientVersion is now parsed from a "CL_###" string (also handles getting a number directly which future manifests will do, to avoid the brittleness). - IsClientCompatible now returns an enum to disambiguate a number of "failure" cases - Use the numeric CompatibleClientVersion compared to the build CL to differentiate between client-newer and mcp-newer incompatability scenarios. - Added EChunkInstallErrorCode::ClientIsTooNew to mirror the new state from IsClientCompatible [CODEREVIEW] Peter.Sauerbrei #ROBOMERGE-SOURCE: CL 3300545 Change 3300395 on 2017/02/13 by Jason.Bestimt #ROBOMERGE-AUTHOR: david.nikdel #WEX: if the scheduled events call fails, give it 5 min before trying again #ROBOMERGE-SOURCE: CL 3300389 Change 3299375 on 2017/02/13 by Jason.Bestimt #ROBOMERGE-AUTHOR: james.hopkin Manually applied this change, ensuring that McpItem.cpp/h and McpProfileRequestTypes.h now have the latest code from GamePlugins Unshelved from pending changelist '3299317': #ogf Moved McpItem and request structures into their own source files //ROBOMERGE_OGS_Release_Online_1_0/PluginTestGame/Plugins/OnlineGameplayFramework/Source/McpProfileSys/Private/McpProfile.cpp //ROBOMERGE_OGS_Release_Online_1_0/PluginTestGame/Plugins/OnlineGameplayFramework/Source/McpProfileSys/Public/McpProfile.h [CODEREVIEW] james.hopkin, david.nikdel, greg.latcovich, sam.zamani #ROBOMERGE-SOURCE: CL 3299316 Change 3297447 on 2017/02/10 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Call error delegates next tick instead #ROBOMERGE-SOURCE: CL 3297441 Change 3297084 on 2017/02/10 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Small join party refactor #ROBOMERGE-SOURCE: CL 3297081 Change 3296885 on 2017/02/10 by Jason.Bestimt #ROBOMERGE-AUTHOR: david.nikdel #OGF: Made FMcpLootResult editable #ROBOMERGE-SOURCE: CL 3296882 Change 3296642 on 2017/02/10 by Jason.Bestimt #ROBOMERGE-AUTHOR: james.hopkin #oss Switched a load of MakeShareables over to MakeShared. Saves some allocations - every little helps. [CODEREVIEW] Ian.Fox #ROBOMERGE-SOURCE: CL 3296576 Change 3296641 on 2017/02/10 by Jason.Bestimt #ROBOMERGE-AUTHOR: james.hopkin #ogf Removed unnecessary #includes and added missing ones #ROBOMERGE-SOURCE: CL 3296572 Change 3296432 on 2017/02/10 by Nicholas.Davies Social: Fixing up Social compile issues after engine integration Change 3296430 on 2017/02/10 by Nicholas.Davies #Social: Fixing up a build error in testgame Change 3295930 on 2017/02/09 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystem - Add move semantics to FOnlineKeyValuePair varient #ROBOMERGE-SOURCE: CL 3295928 Change 3295650 on 2017/02/09 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Fix for broken party state when a party member leaves while being promoted #jira FORT-32736 #ROBOMERGE-SOURCE: CL 3295647 Change 3294787 on 2017/02/09 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Build fix #ROBOMERGE-SOURCE: CL 3294785 Change 3294739 on 2017/02/09 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday #party Support for rejoining a party you were disconnected from. When the party state changes to Disconnected, cache the members of the party and the party id. We will then leave that party and create a new party in the Disconnected state. When that party enters the Active state, attempt to rejoin the cached party. #jira FORT-35637 #ROBOMERGE-SOURCE: CL 3294734 Change 3294735 on 2017/02/09 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday #party #mcp Support for rejoining a party you were disconnected from. Given a party ID and a list of known members, ping each of the members to see if they are in the party and you are able to rejoin. When receiving a response saying to rejoin, go through the normal join flow. If we don't receive an affirmative message, see if any of the members are broadcasting a joinable presence for the specified party. #jira FORT-35637 #ROBOMERGE-SOURCE: CL 3294730 Change 3294326 on 2017/02/09 by Jason.Bestimt #ROBOMERGE-AUTHOR: alex.fennell Fix for improper handling of zero length item and offer request results. #jira: OPP-6639 #ROBOMERGE-SOURCE: CL 3294324 Change 3293306 on 2017/02/08 by Jason.Bestimt #ROBOMERGE-AUTHOR: bob.tellez Engine merge. This is based on CL#3292805 from UE4/Main #ROBOMERGE-SOURCE: CL 3293300 Change 3293086 on 2017/02/08 by Jason.Bestimt #ROBOMERGE-AUTHOR: sam.zamani fix for using wrong expiration date from the Mcp catalog for invalidating offers #tests none #ROBOMERGE-SOURCE: CL 3293078 Change 3292875 on 2017/02/08 by Jason.Bestimt #ROBOMERGE-AUTHOR: david.nikdel #McpProfile: Adjusted the attribute parsing code on McpItem to be more robust about using the supplied default and added code for parsing FDateTime [CODEREVIEW] James.Hopkin #ROBOMERGE-SOURCE: CL 3292867 Change 3292282 on 2017/02/08 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge DMM @ CL 3292219 #RB:none #Tests:none [CODEREVIEW] paul.moore, benjamin.crocker #QAReview #ROBOMERGE-SOURCE: CL 3292276 Change 3290939 on 2017/02/07 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystem - Minor ExecuteNextTick optimization #ROBOMERGE-SOURCE: CL 3290930 Change 3289880 on 2017/02/07 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Identity interface refactor to use common code - iOS now has a TMap of user ids for consistency, but really only ever has one logged in user at a time [CODEREVIEW] sam.zamani #ROBOMERGE-SOURCE: CL 3289876 Change 3289812 on 2017/02/07 by James.Hopkin #gameplugins Compile fix: updated use of ESizingType, since it's now an enum class Change 3289381 on 2017/02/06 by Jason.Bestimt #ROBOMERGE-AUTHOR: sam.spiro #fort Phase out ItemIdAndQuantity as a structure, as it has been deemed insufficient. It has been replaced with LootResultItem. [CODEREVIEW] david.nikdel, todd.eckert #ROBOMERGE-SOURCE: CL 3289377 Change 3289094 on 2017/02/06 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Added email permission to sharing list - permission for app to request user's email address #ROBOMERGE-SOURCE: CL 3289087 Change 3289037 on 2017/02/06 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday #party #mcp Add a party state changed delegate to the online party interface When not logged into XMPP, create party in the Disconnected state, and move it to the Active state when reconnecting to XMPP When logged out of XMPP, briefly move the party to the Disconnected state before the CleanUp state [CODEREVIEW] ian.fox #ROBOMERGE-SOURCE: CL 3289035 Change 3288834 on 2017/02/06 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday #party #mcp Rename PartyMemberChanged to PartyMemberPromoted as the other reasons for changing are unsupported Remove Reconnecting party state, perform Reconnecting logic into logged into xmpp function Remove timer from FOnlinePartyMemberMcp. Because it is only used for pending joiners, move timeout logic to FOnlinePartyMcp::MembersPendingJoinTimeout #ROBOMERGE-SOURCE: CL 3288828 Change 3287666 on 2017/02/06 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ROBOMERGE-AUTHOR: david.nikdel #WEX: Importing old column names from Excel should now go through the same PostLoadFixup as when we load the old uasset. This should enable continuing to use requiredFulfillments and denyFulfillments columns, though it would be ideal to convert the sheet to use the new combined offerRequirements column syntax [CODEREVIEW] David.Hunt #JIRA: WEX-5024 #ROBOMERGE-SOURCE: CL 3287662 #ROBOMERGE-SOURCE: CL 3287663 Change 3287550 on 2017/02/06 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ROBOMERGE-AUTHOR: joe.wilcox UT-3115 External Player Card Imporvements continue Player Card is now based on the unique id. Character model/etc are pulled from the player's profile if they aren't in the same server space Profiles can now be view on by a player in the hub even if the viewed player is in an instance Changed the OnReadUserFileComplete delegate call chain to be ondemand instead of always active #ROBOMERGE-SOURCE: CL 3287481 #ROBOMERGE-SOURCE: CL 3287537 Change 3287548 on 2017/02/06 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Fix friend uninitialized value - Use the standard SessionReference to URI method instead of just the session's name as the friend session id #ROBOMERGE-SOURCE: CL 3287162 #ROBOMERGE-SOURCE: CL 3287536 Change 3286972 on 2017/02/04 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Implement Live GetSessionSettings #ROBOMERGE-SOURCE: CL 3286969 #ROBOMERGE-SOURCE: CL 3286971 Change 3286896 on 2017/02/04 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Implement Live FindSessionById #ROBOMERGE-SOURCE: CL 3286893 #ROBOMERGE-SOURCE: CL 3286894 Change 3285120 on 2017/02/03 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - second pass at more common code between Facebook Windows/iOS - moved FacebookHelper class into its own file - moved facebook user account common code to its own file [CodeReviewed] sam.zamani #ROBOMERGE-SOURCE: CL 3285118 Change 3284447 on 2017/02/02 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineGameplayFramework - Better error message for waiting room failures #ROBOMERGE-SOURCE: CL 3284444 Change 3284420 on 2017/02/02 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Ensure we have a valid user before we try to add them to local voice #ROBOMERGE-SOURCE: CL 3284418 Change 3284069 on 2017/02/02 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Handle party xmpp connection being removed before receiving xmpp logged out event #mcp #party #jira OGS-517 #ROBOMERGE-SOURCE: CL 3284062 Change 3284032 on 2017/02/02 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Facebook changes to get Windows/iOS up to date - Facebook user data structure gets information from proper URL request with valid public fields, stores consistently on both platforms -- store values in generic key value pairs - RequestElevatedPermissions feature that goes through external ui to grant more permissions (Windows) - Reorder shutdown so that sharing interface can properly register/unregister from LoginStatusChanged events #ROBOMERGE-SOURCE: CL 3284022 Change 3284030 on 2017/02/02 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - updated sharing interface for Facebook - proper parsing / querying of Facebook permission request - added common structs/types for storing user permissions - combined two permissions enums into one - more code sharing between Windows and iOS [CodeReviewed] sam.zamani #ROBOMERGE-SOURCE: CL 3284021 Change 3284023 on 2017/02/02 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - updated Facebook friends interface - share more code between iOS and Windows - added proper Facebook pagination for retrieving large numbers of friends - updated URLs to use v2.8 - fixed test friends interface to not crash removing array elements that don't exist -- added permission elevation request if sharing interface is valid [CodeReviewed] sam.zamani #ROBOMERGE-SOURCE: CL 3284019 Change 3283474 on 2017/02/02 by Jason.Bestimt #ROBOMERGE-AUTHOR: ben.zeigler Add support for Queuing mcp profile responses as they come in, if a profile returns false from IsReadyToHandleProfileUpdate the profile group will stop processing that update until the profile calls ProcessPendingProfileUpdates Emit errors for some json parsing cases that previously would pass with incorrect data Add an override struct name to catalog meta parse, so you can parse into multiple different runtime structures [CodeReviewed] david.nikdel, james.hopkin, ian.fox #ROBOMERGE-SOURCE: CL 3283467 Change 3283011 on 2017/02/02 by Jason.Bestimt #ROBOMERGE-AUTHOR: peter.sauerbrei fix for Facebook variable name change [CodeReviewed] josh.markiewicz #ROBOMERGE-SOURCE: CL 3283008 Change 3282603 on 2017/02/01 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - more comment typos #ROBOMERGE-SOURCE: CL 3282601 Change 3282600 on 2017/02/01 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - comment typo #ROBOMERGE-SOURCE: CL 3282597 Change 3281430 on 2017/02/01 by Jason.Bestimt #ROBOMERGE-AUTHOR: david.nikdel #MCP #OGF #Catalog - Added support for specifying metaData on store filters - CatalogManager now exposes a StorefrontActiveFilter that gives the game a chance to hook in and say whether an individual filter (based on metaData) should apply or not. #ROBOMERGE-SOURCE: CL 3281425 Change 3280948 on 2017/02/01 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Verify presence session id is valid #jira OGSSOCIAL-74 #ROBOMERGE-SOURCE: CL 3280944 Change 3280823 on 2017/02/01 by Jason.Bestimt #ROBOMERGE-AUTHOR: andrew.brown Copying //Portal/Dev-Main-Staging to Main (//Portal/Main) #ROBOMERGE-SOURCE: CL 3280820 Change 3280683 on 2017/02/01 by Jason.Bestimt #ROBOMERGE-AUTHOR: peter.sauerbrei fix for failure to install new chunks in launcher builds #jira WEX-4840 #ROBOMERGE-SOURCE: CL 3280681 Change 3280335 on 2017/01/31 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - CreateAccount will now return the proper external auth credentials on completion - previously only handled pure internal accounts properly [CodeReviewed] sam.zamani #ROBOMERGE-SOURCE: CL 3280332 Change 3280016 on 2017/01/31 by Jason.Bestimt #ROBOMERGE-AUTHOR: david.nikdel #OSS: Don't clear ErrorRaw on HTTP success since that contains the raw HTTP result which is useful. [CodeReviewed]: Sam.Zamani #ROBOMERGE-SOURCE: CL 3280009 Change 3279964 on 2017/01/31 by Jason.Bestimt #ROBOMERGE-AUTHOR: david.nikdel #ScheduledEvents: Make EventHelper robust against the outer UMcpProfile being pending kill since the ticker doesn't know anything about that. [CodeReviewed]: Josh.Markiewicz #ROBOMERGE-SOURCE: CL 3279951 Change 3279619 on 2017/01/31 by Jason.Bestimt #ROBOMERGE-AUTHOR: andrew.grant Merging //UE4/Main at 3276432 through Orion-Staging //ROBOMERGE_OGS_Release_Online_1_0/PluginTestGame/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/Private/OnlineChatMcp.cpp //ROBOMERGE_OGS_Release_Online_1_0/PluginTestGame/Plugins/Online/OnlineFramework/Source/Hotfix/Private/OnlineHotfixManager.cpp [CodeReviewed]: andrew.grant, david.nikdel, greg.latcovich, sam.zamani #ROBOMERGE-SOURCE: CL 3279084 Change 3279519 on 2017/01/31 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystem - Remove explicit from FUniqueNetIdString copy/move constructors #Review-3279517 @Rob.Cannaday #ROBOMERGE-SOURCE: CL 3279515 Change 3279417 on 2017/01/31 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Update EMemberExitedReason documentation in Party.cpp #ROBOMERGE-SOURCE: CL 3279413 Change 3279412 on 2017/01/31 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Make UPartyGameState::InitFromCreate virtual so the party state can be initialized from current game state #ROBOMERGE-SOURCE: CL 3279410 Change 3279132 on 2017/01/31 by Jason.Bestimt #ROBOMERGE-AUTHOR: david.nikdel #ScheduledEvents - EventChannel now always has an initialized state (return reference from GetState) - Rearranged some of the event parsing code to be more reusable to facilitate easy creation of very custom game-specific events - Added support for including special strings (starting with $) in the operations list which are swapped out for Instance properties when the instance is created. - Specials are not unrolled by default. Must be opt-in. #ROBOMERGE-SOURCE: CL 3279128 Change 3279064 on 2017/01/31 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Deprecate unused ELeavePartyCompletionResult reasons, document used reasons. #ROBOMERGE-SOURCE: CL 3279062 Change 3278985 on 2017/01/31 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Change FOnlinePartySystemMcp::BroadcastPartyConfigChanged to use TSharedRef<const FUniqueNetId> for the local user #party #mcp //ROBOMERGE_OGS_Release_Online_1_0/PluginTestGame/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/Private/OnlinePartyMcp.cpp //ROBOMERGE_OGS_Release_Online_1_0/PluginTestGame/Plugins/Online/NotForLicensees/OnlineSubsystemMcp/Source/Private/OnlinePartyMcp.h [CodeReviewed]: rob.cannaday, david.nikdel, greg.latcovich, sam.zamani #ROBOMERGE-SOURCE: CL 3278957 Change 3278785 on 2017/01/31 by James.Hopkin #gameplugins Updated chunk installer build script to match new target rules syntax Change 3278779 on 2017/01/31 by James.Hopkin Merged build script changes for Online plugins from CL#3278101 to get editor building again This changelist appears to be a breaking change which might cause some trouble for our branching strategy //UE4/Main/Engine/Plugins/Online/... to //GamePlugins/Main/PluginTestGame/Plugins/Online/... Change 3277676 on 2017/01/30 by Jason.Bestimt #ROBOMERGE-AUTHOR: david.nikdel #MCP #Catalog #GameplayUtils: - Re-formalizing requiredFulfillments, denyFulfillments, and denyItems into an array of generic OfferRequirements - Offer requirements may require/deny template/fulfillment and provide a count (previously only 1 was supported) - Added C++ code to convert old offers on load * offers that specified a templateId will continue to work, but further editing will require pointing to an McpItemDefinitionBase (for type safety) which is the new pattern - C++ now outputs the new JSON format - MCP can read both old and new JSON format (old format is fixed up on loading) - Replaced Inventory isItemOwned check with getItemCount so we can support minQuantity (can still be overridden similar to isItemOwned for custom logic) - If any deny requirements (Fulfillments or items) are specified it's now an error to specify purchaseQuantity > 1 (since we can't correctly account for items/fulfillments this purchase may grant). Ran though testing required/deny fulfillments on WEX. Wasn't able to test deny TemplateIds in the wild but code path is 95% similar now. @JB may want to keep an eye out for any JIRAs that look related. Follow-up commit to fix usage of DenyFulfillmentIds in WEX Client and isItemOwned in Orion MCP forthcoming #RB: Ian.Fox [CodeReviewed]: Ian.Fox, Jason.Bestimt #ROBOMERGE-SOURCE: CL 3277666 Change 3277340 on 2017/01/30 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3277275 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3277296 Change 3277334 on 2017/01/30 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Non-editor build fix #ROBOMERGE-SOURCE: CL 3277280 Change 3276433 on 2017/01/27 by andrew.grant Copying //UE4/Orion-Staging to //UE4/Main (Source: //Orion/Dev-General @ 3271386) Change 3270776 on 2017/01/24 by Laurent.Delayen Fixed missing call to CacheBones in AnimNode_SubInstance. Fixes Mudang crash. #c0der3view benn.ghallager, lina.halper #tests does not crash Change 3270483 on 2017/01/24 by Shaun.Kime Removing the ensure and making it behave safely whenever the scene count is out of sync. Since Paragon isn't using the primary driving feature of MaterialParameterCollections in the UI that required this feature, Nick Darnell and I deemed this okay. #jira OR-34919 #tests PIE and golden path Change 3270067 on 2017/01/24 by Laurent.Delayen Fixed crash when recompiling Mudang's AnimBP. (SubInstances array holding null references) #tests doesn not crash Change 3269760 on 2017/01/24 by Daniel.Lamb Added more files to inisettings blacklist. #test cook paragon. Change 3269578 on 2017/01/24 by jason.bestimt #ORION_MAIN - Merge 37.2 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3269570 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) #R0BOMERGE-SAYS: Unresolved conflicts. jason.bestimt, please merge this change by hand. //R0BOMERGE_ORION_Dev_General/OrionGame/Content/Characters/Heroes/Grux/Abilities/Stampede/GA_Grux_Stampede.uasset //R0BOMERGE_ORION_Dev_General/OrionGame/Content/Characters/Heroes/Ice/Icons/Minimap_char_portrait_Ice.uasset //R0BOMERGE_ORION_Dev_General/OrionGame/Content/Characters/Heroes/Ice/Icons/PORT_Ice.uasset #c0der3view: jason.bestimt Change 3269141 on 2017/01/23 by Mieszko.Zielinski TSimpleCellGrid::InvalidCell refactor to avoid it being a static member variable #UE4 #test golden path Change 3268953 on 2017/01/23 by Jason.Bestimt #ORION_DG - R0BOMERGE resolution from MAIN to DG of compile fix and banner stuff #RB:none #Tests:none #c0der3view: matt.schembari, andrew.grant Change 3268576 on 2017/01/23 by John.Pollard Add DemoNetDriver to the level collection earlier to remove small window where World->DemoNetDriver could be null as a result of FScopedLevelCollectionContextSwitch #tests Live game play + replays + instant replay Change 3268119 on 2017/01/23 by Daniel.Lamb Added support for splitting up chunks into maximum sizes. #test Cook paragon ps4 windows windowserver Change 3268020 on 2017/01/23 by Dan.Hertzka Moving TreeFilterHandler.h out into Slate/Public via branch & delete #c0der3view Nick.Darnell #tests compile Change 3267820 on 2017/01/23 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3267817 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3266798 on 2017/01/20 by Daniel.Lamb Make the diff files commandlet more helpful. #test Diff files commandlet. Change 3266795 on 2017/01/20 by Daniel.Lamb Fixed issue with Cooked packages trying to load dependencies from a dependency offset which is incorrect. #c0der3view Gil.Gribb #test Load cooked packages using the editor. Change 3266310 on 2017/01/20 by Daniel.Lamb Fixed issue with cook ont he fly not resolving string asset reference redirectors on load. Added fastcook to the iterative cook detection. #test Cook Paragon Change 3265879 on 2017/01/20 by Jon.Lietz fixing PS4 compile error #tests compiles #c0der3view andrew.grant Change 3265756 on 2017/01/20 by Jon.Lietz quest evaluator - added in an ability type that will evaluate in game events and increments player stats for quests, these abilities can be granted by quests or the hero data - added support to the ability system to have ability specs not replicated to the client, this will allow for passive only abillities for quest evaluation to only live and exicute on the dedicated server - now support loading in data for quest info asynchronously - orion quests can now grant evaluator abilities to the players that own the quests - AOrionPlayerState_Game::GiveAbilityData() now grabs all the abilities from active quests - at the end of the match unload any data loaded by the quests #RB david.ratti #test granting abilities Change 3265658 on 2017/01/20 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3265627 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3265530 on 2017/01/20 by Robert.Manuszewski Making sure all package dependencies are loaded before post loading its objects #jira OR-34891 #tests Golden path x 12 Change 3265126 on 2017/01/19 by Frank.Gigliotti Notifies for abilities waiting on input confirmation; * Ability tasks waiting for input confirmation will now notify the ability when it begins and ends waiting. #RB Dave.Ratti #Tests PIE Change 3264489 on 2017/01/19 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Merged fix from 36.2. #R0BOMERGE-SOURCE: CL 3264488 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3263948 on 2017/01/19 by Andrew.Grant Non-unity fixes. #tests compiled WIn64 editor #R0BOMERGE: Main, 37 Change 3263755 on 2017/01/19 by Laurent.Delayen OR-34970 FRootMotionSource_ConstantForce now has DisablePartialEndTick set, so we end up with a consistent velocity when the root motion ends. Added VelocityOnFinishMode to UAbilityTask_ApplyRootMotionConstantForce so we can optionally override or clamp velocity. CVarDebugRootMotionSources now displays Velocity and LastPreAdditiveVelocity on HUD to help debugging RootMotionSources. #tests Ice Q Change 3263616 on 2017/01/19 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3263613 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3262543 on 2017/01/18 by Eric.Newman Added GetAttributeSetValues feature to Ability System. Allows for pulling attribute rows without needing an Actor or AbilitySystemComponent #c0der3view david.ratti #tests used to export paragon hero attributes #jira TON-25429 Change 3262414 on 2017/01/18 by Laurent.Delayen Fixed crash opening up Ice's AnimBP. #c0der3view thomas.sarkanen #tests opening up AnimBP doesn't crash anymore. Change 3262291 on 2017/01/18 by Ryan.Gerleve Cache the network role of AbilitySystemComponents in PreNetReceive, to make sure the role is correct during serialization if properties are received before BeginPlay. Factor out the caching into its own function to reduce code duplication. #tests golden path, bug repro #jira OR-31424 Change 3262062 on 2017/01/18 by Max.Chen Sequencer: Fixed crash caused by lingering persistent evaluation data Copy from Release-4.15 #jira UE-40775 #tests none Change 3262061 on 2017/01/18 by Max.Chen Sequencer: Evaluation templates are now only fully rebuilt in PIE, and will not re-cycle track identifiers - This addresses issues with newly compiled tracks recycling the persistent data of old stale tracks. - This commit also ensures we don't fully rebuild templates in the editor when in Sequencer Copy from Release-4.15 #jira UE-40775 #tests none Change 3261946 on 2017/01/18 by Jason.Bestimt #ORION_DG - Fix for event tracks in sequencer #RB:none #Tests:none #R0BOMERGE: MAIN #c0der3view: Max.Chen, andrew.rodham, scott.james Change 3261812 on 2017/01/18 by Mieszko.Zielinski Made bos' perception component vlog information #Orion #test golden path Change 3261731 on 2017/01/18 by Benn.Gallagher Readded fix to clothing index buffer overflow (lost in merge a while back) #tests Editor, assigned clothing to skel mesh Change 3261730 on 2017/01/18 by Robert.Manuszewski Build script sdk upgrade #tests Ran the script that was upgraded Change 3261392 on 2017/01/17 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant non-unity fix #tests compiled #R0BOMERGE-SOURCE: CL 3261391 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3261096 on 2017/01/17 by Laurent.Delayen OR-33666 Removed 'bImpartsVelocityOnRemoval' for additive root motion sources, as that can create a 'bouncing' effect when Velocity is modified externally. #tests Preflight QA test https://jira.it.epicgames.net/browse/PQATC-8713 Change 3261030 on 2017/01/17 by Laurent.Delayen Fix crash in Persona. #tests doesn't crash Change 3260561 on 2017/01/17 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Merging Fix from UE 4.15 Look at the body instance's desired collision enabled value rather than the primitive component's current collision enabled value when determining whether physics state should be created #jira UE-39994 #tests na #R0BOMERGE-SOURCE: CL 3260557 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3260553 on 2017/01/17 by Ryan.Gerleve Change cvar in UDemoNetDriver::ShouldSaveCheckpoint to use GetValueOnAnyThread. Fixes OR-34759. #tests bug repro, golden path Change 3260202 on 2017/01/17 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37/36.2 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3260201 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3259560 on 2017/01/16 by Marcus.Wassmer Fix reflections #c0der3view Brian.Karis #tests added some reflections Change 3259348 on 2017/01/16 by Daniel.Lamb Moved automation maps from alwayscookmaps to AllAutomationMaps. #test Cook Paragon + Fast Cook Paragon + Preflight Cook Paragon Change 3259113 on 2017/01/16 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant #ORION_MAIN - Merge 36.2 #RB:none #Tests:compiled Win64 editor #R0BOMERGE-SOURCE: CL 3258986 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3259090 on 2017/01/16 by Chris.Bunner Duplicating CL 3246830: Allow AllocGBuffer call when in simple-forward so dummy uniform buffer creation can occur. #tests Editor, -game, epic and min settings Change 3258910 on 2017/01/16 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - DAILY DG #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3258871 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3258807 on 2017/01/16 by Rolando.Caloca O - Fix for outlines #tests Ran sovereign2 game #c0der3view Andrew.Grant Change 3258637 on 2017/01/16 by Charles.Anderson Removing wrongly added files (agrant) Change 3258601 on 2017/01/16 by Andrew.Grant Temp fix for rendering crash by disabling custom depth rendering #tests PIE'd Change 3258590 on 2017/01/16 by Tom.Wright One of these files are not syncing properly in my UnrealGameSync so I'm adding them manually (the .exe). Change 3258523 on 2017/01/16 by Andrew.Grant Removing intermediate build file that was checked in Change 3258464 on 2017/01/16 by Andrew.Grant Fixes for non-unity #R0BOMERGE: Main #tests compiled Win64 Change 3258208 on 2017/01/15 by Mieszko.Zielinski FMetaNavMeshPath's Waypoints have been expanded to store user flags. #UE4 #test golden path Change 3258042 on 2017/01/14 by andrew.grant Merging test framework changes from //Orion/Release-36.2 to Main (//Orion/Main) #R0BOMERGE-SOURCE: CL 3258036 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) #R0BOMERGE-SAYS: Beep boop! I couldn't merge this change. Please do it yourself, human. //R0BOMERGE_ORION_Dev_General/OrionGame/Build/OrionBuild.xml #c0der3view: andrew.grant, jason.bestimt Change 3258035 on 2017/01/14 by Andrew.Grant Disable MfMedia plugin by default Change 3257936 on 2017/01/14 by Andrew.Grant Merging from //UE4/Main #tests QA smoke in staging, built locally, preflighted Change 3257583 on 2017/01/13 by Daniel.Lamb Removed nomcp from the commandline when running on PC #test Buildcookrun paragon windows Change 3257320 on 2017/01/13 by Cody.Haskell #Orion - Ansel Integration into Replay Mode - Updated Ansel SDK - Bug Fix for Ansel plugin - Made it not look terrible when you pause the game in regular replay mode #r3view-3256093 #tests Golden Path, compiles on PS4 Change 3257239 on 2017/01/13 by Frank.Gigliotti ApplyRootMotionJumpForce end velocity options; * "ApplyRootMotionJumpForce" task now supports setting the end velocity. * Moved root motion end velocity options from the individual tasks into the base class. * Fixed a property on UAbilityTask_ApplyRootMotionConstantForce not replicating properly. #RB None #Tests PIE Change 3256173 on 2017/01/12 by Laurent.Delayen Added additional debug message to ShowResaveMessage. #test loaded broken Femme assets. Change 3256082 on 2017/01/12 by Andrew.Grant Temp fix for BuildHealth warning. Following up with BP team #tests verifierd compile warnings are gone Change 3255991 on 2017/01/12 by Ben.Woodhouse Cherry pick NV gpu hang fix from //ue4/release-4.14 Disable timestamp queries on pre-Maxwell nvidia hardware. Local testing suggests that this is the major cause of instability in the UE4.14 release. It's possible that we could be more targeted by only excluding Fermi and older hardware, but identifying fermi hardware by device ID is difficult in practice, since the range overlaps with Kepler. #jira OR-22580 #tests run locally on PC (change is windows-specific) Change 3255185 on 2017/01/12 by John.Nielson Made it so that PS4 compiles without warning from misordered initialization. #RB: r3view #r3view-3255186: Andrew.Grant #Test: None Change 3254885 on 2017/01/11 by Michael.Trepka CIS fix #tests none Change 3254568 on 2017/01/11 by Andrew.Grant Merging relay fix from //Orion/Release-36.2 to Dev-General (//Orion/Dev-General) Change 3254544 on 2017/01/11 by Jason.Bestimt #R0BOMERGE-AUTHOR: andrew.grant Robomerging previous fix to Dev-Gen #R0BOMERGE-SOURCE: CL 3254532 in //Orion/Release-36.1/... via CL 3254537 via CL 3254540 #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3254204 on 2017/01/11 by Michael.Trepka Added title bar area to the game layer manager, so that games can easily setup custom title bar content when using borderless windows. Disabled/hidden by default #tests Tested in editor build on PC Change 3254074 on 2017/01/11 by Ryan.Gerleve Fix for gameplay tags not being recorded in client replays. #tests golden path, replays Change 3254035 on 2017/01/11 by Laurent.Delayen OR-28756 Added WaitForMovementInput Ability Task to use with Emote ability. #tests Kallari's emotes Change 3253736 on 2017/01/11 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3253715 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3252981 on 2017/01/10 by Daniel.Lamb Added async load package delegate. #test BuildCookRun Paragon with local server Change 3252975 on 2017/01/10 by Daniel.Lamb Added EditorPerProjectUserSettings to the ignore config field for iterative cooking #test cook paragon. Change 3252784 on 2017/01/10 by Daniel.Lamb Integrated fix for rebuild lighting commandlet from Greg Korman #test Rebuild lighting Paragon Change 3252460 on 2017/01/10 by Aaron.Eady #jira UE-40390 Fix crash saving blueprint with an inherited DataTable/CurveTable reference. Delta serialization meant that the necessary name wasn't in the name table, so adding it manually now. Copied from CL #3252418 Written by Ben.Zeigler #c0der3view Ben.Zeigler, David.Ratti, Andrew.Grant #tests PIE Change 3252222 on 2017/01/10 by Jason.Bestimt #R0BOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 #RB:none #Tests:none #R0BOMERGE-SOURCE: CL 3252221 in //Orion/Main/... #R0BOMERGE-BOT: ORION (Main -> Dev-General) Change 3251379 on 2017/01/09 by Ori.Cohen Fix build #tests none Change 3276357 on 2017/01/27 by Jason.Bestimt #ROBOMERGE-AUTHOR: scott.bowen #ocean - WARNING: HACK - Fix build until OGS can tell us how to fix. [CodeReviewed]:james.brinkerhoff, shon.love #ROBOMERGE-SOURCE: CL 3276356 Change 3275919 on 2017/01/27 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Fix Live Voice Chat crash on unregister #ROBOMERGE-SOURCE: CL 3275918 Change 3275800 on 2017/01/27 by Jason.Bestimt #ROBOMERGE-AUTHOR: james.brinkerhoff Merging //UE4/Ocean-Staging/Ocean/Plugins/Online to //Ocean/Main/Ocean/Plugins/Online #ROBOMERGE-SOURCE: CL 3275799 Change 3275388 on 2017/01/27 by James.Hopkin Compile fixes Change 3275267 on 2017/01/27 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Facebook iOS upgrade to 4.18 IdentityInterface should be using proper in app dialogs now #ROBOMERGE-SOURCE: CL 3275266 Change 3275125 on 2017/01/27 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - fixed OnlineBeaconClients leaking when the net driver is destroyed - they would be set to pending destroy during DestroyBeacon, but NetDriver destruction prevented UNetConnection ticking - these objects would never timeout properly in this state and so would remain attached to the ULevel - would eventually clean up on server travel [CodeReviewed] bob.tellez #tests quitting lobby during connection phase, noticing actors previously leaking are no longer #ROBOMERGE-SOURCE: CL 3275124 Change 3275101 on 2017/01/27 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37.2 @ CL 3273298 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3273417 Change 3275071 on 2017/01/27 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday OSS Party logging pass + Include more information in function logging (such as user, party) + Reduced amount of FString::Printf that did not add information + Remove As*String functions from OnlinePartyMcp #ROBOMERGE-SOURCE: CL 3275070 Change 3274720 on 2017/01/26 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Session Router cleanup #ROBOMERGE-SOURCE: CL 3274719 Change 3274715 on 2017/01/26 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Use SessionRestrictions instead of visibility constant to restrict session access - Fixes updating sessions failing #ROBOMERGE-SOURCE: CL 3274714 Change 3274708 on 2017/01/26 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Request session information for friends - Fix friend query failures possibly not cleaning up correctly #ROBOMERGE-SOURCE: CL 3274707 Change 3274351 on 2017/01/26 by Jason.Bestimt #ROBOMERGE-AUTHOR: james.brinkerhoff Merging //UE4/Ocean-Staging to //Ocean/Main @ CL 3269883 #ROBOMERGE-SOURCE: CL 3274292 Change 3274350 on 2017/01/26 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday [AUTOMERGE] On XMPP or MCP logout, cancel pending party ops and call completion delegates #jira OGS-481 #ROBOMERGE-SOURCE: CL 3274314 Change 3273603 on 2017/01/26 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Call failure delegate for unimplemented CancelFindSessions #ROBOMERGE-SOURCE: CL 3273601 Change 3273594 on 2017/01/26 by Jason.Bestimt #ROBOMERGE-AUTHOR: james.longstreet #fortnite #jira FORT-35962 Fix crash when disconnecting WAN. Error log was using %s to print a float. #ROBOMERGE-SOURCE: CL 3273593 Change 3273379 on 2017/01/26 by Andrew.Brown Merging //Portal/Main/Engine/Plugins/Online/... to //GamePlugins/Main/PluginTestGame/Plugins/Online/... Change 3273275 on 2017/01/26 by Ian.Fox Unblock Robomerge Source=CL 3272229 in //UE4/Main/Engine/Plugins/... Author=matthew.griffin Change 3273222 on 2017/01/26 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Add additional logging to track down FORT-35510 #ROBOMERGE-SOURCE: CL 3273220 Change 3272573 on 2017/01/25 by Jason.Bestimt #ROBOMERGE-AUTHOR: peter.sauerbrei improvements to the chunk update and download process #ROBOMERGE-SOURCE: CL 3272569 Change 3272554 on 2017/01/25 by Jason.Bestimt #ROBOMERGE-AUTHOR: david.nikdel #ScheduledEvents: First draft of client API #ROBOMERGE-SOURCE: CL 3272047 Change 3272550 on 2017/01/25 by Peter.Sauerbrei Merging using WEX_Main_to_UE4_WEX_Staging #ROBOMERGE-SOURCE: CL 3270051 Change 3272164 on 2017/01/25 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineGameplayFramework, #Mcp - Add support for changing the display presentation of DynamicBundles - Can now set them to Strikethrough, AmountOff, PercentOff, or PercentOn #tests none #review-3271867 @Philip.Buuck #ROBOMERGE-SOURCE: CL 3272163 Change 3271712 on 2017/01/25 by Ian.Fox Manual Merge to fix robomerge blockage Source=CL 3271588 Author=adam.szpakowski #CodeReview Adam.Szpakowski Change 3271035 on 2017/01/24 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Session Improvements - Add ability to specify what visiblity a Live Session is when creating it - Add ability to update session visiblity when updating a session - Normalize updating of session host #ROBOMERGE-SOURCE: CL 3271033 Change 3271031 on 2017/01/24 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Live Presence fixes and improvements - Subscribe to automatic presence updates; this also updates cached friends presence information - Call failure delegates on error cases in SetPresence - Optimize some presence code - OnlineSubsystemLive GetAppId now return the TitleId instead of empty string #ROBOMERGE-SOURCE: CL 3271030 Change 3271019 on 2017/01/24 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineGameplayFramework - Revert accidental change #ROBOMERGE-SOURCE: CL 3271018 Change 3271013 on 2017/01/24 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Store Title Id as uint on startup - Use cached TitleId instead of converting from string multiple times #ROBOMERGE-SOURCE: CL 3271012 Change 3269306 on 2017/01/24 by Jason.Bestimt #ROBOMERGE-AUTHOR: james.hopkin #online #stomp Added error log if reconnects don't succeed after specified time, currently 30 seconds. #ROBOMERGE-SOURCE: CL 3269305 Change 3268378 on 2017/01/23 by James.Hopkin #gameplugins Fix for bad merge Change 3268176 on 2017/01/23 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Remove usages of AddGenericToOutQueue in favour of ExecuteNextTick - This is part of the effort to remove usages of the TaskManager in Live code in favour of more abstracted OSS calls #ROBOMERGE-SOURCE: CL 3268174 Change 3268160 on 2017/01/23 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Remove unused SessionVisiblity value #ROBOMERGE-SOURCE: CL 3268159 Change 3267730 on 2017/01/23 by Jason.Bestimt #ROBOMERGE-AUTHOR: steve.robb Fix for stat metadata mismatch warning during PIE. #jira UE-40808 #ROBOMERGE-SOURCE: CL 3267671 Change 3267097 on 2017/01/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Clean up Live Session interface #ROBOMERGE-SOURCE: CL 3267096 Change 3267086 on 2017/01/20 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemUtils - Use ThisClass instead of class name for consistency #ROBOMERGE-SOURCE: CL 3267085 Change 3266276 on 2017/01/20 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Add async task for tracking SetSessionActivity results #ROBOMERGE-SOURCE: CL 3266275 Change 3265839 on 2017/01/20 by Andrew.Brown Merging //Portal/Dev-Main-Staging/Engine/Plugins/Online/... to //GamePlugins/Main/PluginTestGame/Plugins/Online/... OnlineOrderServiceMcp - Combine all launcher purchases into single workflow using the new quickPurchase API call as the initial request - CL#3236188 OnlineWaitingRoomMcp - Improving fail case handling for the waiting room service (removes connection failed message we added recently) - CL#3231134 Icon128.png - Not sure if you'll want this, but it looks like we ended up with it from a merge CL#3246498 Change 3265837 on 2017/01/20 by Andrew.Brown Compiler issue, missing header Change 3265753 on 2017/01/20 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday #MCP - Misc party log cleanup #RB Rob.Cannaday, Ian.Fox #ROBOMERGE-SOURCE: CL 3265752 Change 3265720 on 2017/01/20 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Build fix. #ROBOMERGE-SOURCE: CL 3265719 Change 3265692 on 2017/01/20 by Sam.Zamani fix for merge issue Change 3265667 on 2017/01/20 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Don't send party config update to yourself, or if it hasn't changed #party #jira FORT-26415 #ROBOMERGE-SOURCE: CL 3265666 Change 3265607 on 2017/01/20 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 37/36.2 @ CL 3261774 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3261952 Change 3265603 on 2017/01/20 by Sam.Zamani Unshelved from pending changelist '3263592': =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Merging from //UE4/Main @ 3253977 through Orion-Staging #tests QA smoke in staging, built locally, preflighted #ROBOMERGE-SOURCE: CL 3257936 #ROBOMERGE-SAYS: Unresolved conflicts. andrew.grant, please merge this change by hand. //ROBOMERGE_OGS_Main/PluginTestGame/Plugins/OnlineGameplayFramework/Source/McpProfileSys/Private/McpProfileGroup.cpp //ROBOMERGE_OGS_Main/PluginTestGame/Plugins/OnlineGameplayFramework/Source/McpProfileSys/Public/McpProfileGroup.h #CodeReview: andrew.grant, david.nikdel, greg.latcovich, sam.zamani =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Change 3263958 on 2017/01/19 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Differentiate join party errors that originate locally vs from a remote player AlreadyJoiningParty can be received from a remote player if the remote player has us in the PendingJoinRequests list. AlreadyJoiningParty was previously being issued locally if we were waiting for a response from our previous join request, now we use WaitingForRemoteJoinResponse. AlreadyInParty can be received from a remote player if the remote player thinks we are already in the party (this should not happen). AlreadyInParty was previously issued locally if we knew we were in the party we were requesting to join, now we use LocallyAlreadyInParty. #fort #party #jira FORT-35381 #ROBOMERGE-SOURCE: CL 3263957 Change 3263765 on 2017/01/19 by Jason.Bestimt #ROBOMERGE-AUTHOR: shon.love #ocn, #mcp: Added new Mcp RPC - Query Clan Display Info for Account. Takes a list of accountIds and returns all clans to which those accounts beolong. No association between the accounts and the clans is in the results. Also cleaned up some of the searching internals to remove an old serialization class. [CodeReviewed]: Scott.Bowen, Zack.Derouiche #ROBOMERGE-SOURCE: CL 3263764 Change 3263675 on 2017/01/19 by James.Hopkin #gameplugins Added localisation artifacts for plugins #jira FORT-33793 Change 3263662 on 2017/01/19 by James.Hopkin #gameplugins Added localisation ini files for all the plugins and added a localization target to each plugin. #jira FORT-33793 Change 3263316 on 2017/01/18 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Add support for natively inviting friends to XB Live sessions #review-3263315 @Jeff.Campeau #ROBOMERGE-SOURCE: CL 3263314 Change 3262767 on 2017/01/18 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Provide specific warning message when we receive a muc room message from a JID that does not have a resource. #ROBOMERGE-SOURCE: CL 3262765 Change 3262755 on 2017/01/18 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - added a "needs price check" boolean to catalog helper - if the low level code fails to get prices, this bool remains true so that calls to Refresh will try again [CodeReviewed] david.nikdel #ROBOMERGE-SOURCE: CL 3262754 Change 3262745 on 2017/01/18 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - OSS GooglePlay login logging - added an else clause to Start_OnTaskThread that won't call StartAuthorizationUI if already authorized - added an if check to current IAP query task just in case it could be null (hasn't been so far) [CodeReviewed] ryan.gerleve #ROBOMERGE-SOURCE: CL 3262744 Change 3262230 on 2017/01/18 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Don't remove party from party map when receiving an unexpected join request approval message. #ROBOMERGE-SOURCE: CL 3262229 Change 3262176 on 2017/01/18 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Fix CreateSession and FindSessions failure cases not fully cleaning up state #JIRA UE-39110 #RB Rob.Cannaday #ROBOMERGE-SOURCE: CL 3262175 Change 3259530 on 2017/01/16 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Save our presence to our local cache after having successfully published it to Live - This fixes printing "Setting up first time rich presence" multiple times #ROBOMERGE-SOURCE: CL 3259529 Change 3258450 on 2017/01/16 by Jason.Bestimt #ROBOMERGE-AUTHOR: rob.cannaday Add a parameter bIsLeader to FPartyState::Reset to allow some fields to only optionally be reset if you are not the leader. #party #jira FORT-35144 #ROBOMERGE-SOURCE: CL 3258448 Change 3258425 on 2017/01/16 by Jason.Bestimt #ROBOMERGE-AUTHOR: james.hopkin #ogf Added comments and logging to profile system - reduced spam of single pending notification (pretty common case), but added log of time (encoded for grouping on Sumo) between an HTTP response and its associated notification. #ROBOMERGE-SOURCE: CL 3258357 Change 3258385 on 2017/01/16 by Nicholas.Davies Back out changelist 3254217 Change 3257660 on 2017/01/13 by david.nikdel #Profile: Added OnMcpVersionChanged and OnContentVersionChanged callbacks to profiles (so they can force reload global config). Noops by default. #ROBOMERGE-SOURCE: CL 3257629 #CodeReview: david.nikdel, greg.latcovich, sam.zamani Change 3256956 on 2017/01/13 by Justin.Sargent Fixed the social styling to properly handle composite fonts when constructing the message break fontinfo, otherwise it produces the following warning. Warning: FSlateFontInfo was constructed with a null UFont. Slate will be forced to use the fallback font path which may be slower. #jira OGSSOCIAL-358 Change 3256342 on 2017/01/12 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Do not allow empty user queries #ROBOMERGE-SOURCE: CL 3256339 Change 3256341 on 2017/01/12 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Remove spammy local-user lookup log #ROBOMERGE-SOURCE: CL 3256338 Change 3256340 on 2017/01/12 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Fix friendslist change subscriptions - Add listener on UserContextCreation, but it is disabled until that user's first query - Call FriendsListChanged delegate when the friendslist is empty #ROBOMERGE-SOURCE: CL 3256337 Change 3254531 on 2017/01/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: joe.wilcox UT-7038 Fixed a crash with lan servers #ROBOMERGE-SOURCE: CL 3254528 Change 3254366 on 2017/01/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - Added ability to login with existing Facebook auth token from regular Login() function - added class to serialize Facebook json error codes [CodeReviewed] sam.zamani #ROBOMERGE-SOURCE: CL 3254362 Change 3254365 on 2017/01/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - login flow feedback changes - made a better interface for login flow management - removed culture code - more/better comments [CodeReviewed] justin.sargent #ROBOMERGE-SOURCE: CL 3254360 Change 3254260 on 2017/01/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Change log message for user presence to be more verbose #RB Rob.Cannaday #ROBOMERGE-SOURCE: CL 3254258 Change 3254254 on 2017/01/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Fix iterating by value instead of reference #ROBOMERGE-SOURCE: CL 3254253 Change 3254217 on 2017/01/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: shon.love #ocn, #mcp: Fixed call to find a group by name match. [CodeReviewed]: Scott.Bowen, Zack.Derouiche #ROBOMERGE-SOURCE: CL 3254215 Change 3253739 on 2017/01/11 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3253668 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3253715 Change 3253204 on 2017/01/10 by Jason.Bestimt #ROBOMERGE-AUTHOR: bob.tellez Duplicating CL#3214265 from //GamePlugins/Main #OnlineGameplayFramework, #Orion - Add entitlement filter for VerifyRealMoneyPurChase Access Entitlements can not be claimed for an item, they go through a different code path. So instead we store our list of access entitlement names, and save that into our MTXHelper. When the MTXHelper goes to claim entitlements, it checks if the entitlement is on our filter list. If it is on our filter list, we just skip it. #RB Wes.Hunt [CodeReviewed] Wes.Hunt, Jason.Bestimt #Tests PS4 + PC MTX purchasing, Golden Path #ROBOMERGE-SOURCE: CL 3253202 Change 3253026 on 2017/01/10 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Fix using FName in UE_LOG message #ROBOMERGE-SOURCE: CL 3253025 Change 3252734 on 2017/01/10 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Fix friendslist query never finishing #ROBOMERGE-SOURCE: CL 3252733 Change 3252732 on 2017/01/10 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Mark friend status as accepted instead of unknown - Xbox friends are single-directional so they are always "accepted" if Live tells us they exist at all #ROBOMERGE-SOURCE: CL 3252731 Change 3252309 on 2017/01/10 by James.Hopkin #gameplugins Fixed some LOCTEXT macros causing localization gather warnings. Change 3251643 on 2017/01/09 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OGF - Only allow epic login on xbox when that account isn't linked to another XBL account [CodeReviewed] Jeff.Campeau #ROBOMERGE-SOURCE: CL 3251642 Change 3251575 on 2017/01/09 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Listen for Friend Changed notifications - We requery our friendslist when there is a notification that our friends have changed in some way - Friend change notifications can come in for multiple friends at once so there shouldn't be issues where a bunch of friends update all at once and we make a ton of requests - We also now call TriggerOnFriendsChangeDelegates when we finish querying our friends list #ROBOMERGE-SOURCE: CL 3251574 Change 3251573 on 2017/01/09 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Throttle our Presence to only update when we change status - This fixes us going over the live-services rate-limit at login #ROBOMERGE-SOURCE: CL 3251572 Change 3251383 on 2017/01/09 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Fixup Live SetUserAttribute #ROBOMERGE-SOURCE: CL 3251382 Change 3250094 on 2017/01/06 by Jason.Bestimt #ROBOMERGE-AUTHOR: jeff.campeau libstrophe UE4 modifications #ROBOMERGE-SOURCE: CL 3250093 Change 3249288 on 2017/01/06 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3249117 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3249278 Change 3247849 on 2017/01/05 by Jason.Bestimt #ROBOMERGE-AUTHOR: james.hopkin #ogf Profile notifications: Stomp OnConnect delegate now gets correctly unbound on profile group destruction. Also hardened UMcpProfileGroup against null profile entries. There's no explicit code nulling them, but Fortnite code explicitly marks profiles as pending kill, which causes the garbage collector to null out the pointers in the profile list entries. Crash prevented in three separate ways: delegate unbound, profile list cleared in Finalize and null checks (with ensures) in all accesses. #jira FORT-35113 [CodeReviewed] Sam.Zamani,David.Nikdel #ROBOMERGE-SOURCE: CL 3247848 Change 3247718 on 2017/01/05 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3247673 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3247716 Change 3247715 on 2017/01/05 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Add optional debug logging for owned xbox inventory items #ROBOMERGE-SOURCE: CL 3247714 Change 3247494 on 2017/01/05 by Jason.Bestimt #ROBOMERGE-AUTHOR: james.hopkin #oss Fixed tabbing #ROBOMERGE-SOURCE: CL 3247493 Change 3247491 on 2017/01/05 by Jason.Bestimt #ROBOMERGE-AUTHOR: james.hopkin #fortnite Added more logging for connecting to Stomp and sending unsubscribe requests. #ROBOMERGE-SOURCE: CL 3247490 Change 3246698 on 2017/01/04 by Jason.Bestimt #ROBOMERGE-AUTHOR: joe.wilcox UT-7041 Fixed a possible null access crash in the OSSSI #ROBOMERGE-SOURCE: CL 3246697 Change 3246230 on 2017/01/04 by Jason.Bestimt #ROBOMERGE-AUTHOR: jason.bestimt #ORION_MAIN - Merge 36.2 @ CL 3246134 #RB:none #Tests:none #ROBOMERGE-SOURCE: CL 3246204 Change 3246105 on 2017/01/04 by Jason.Bestimt #ROBOMERGE-AUTHOR: james.hopkin #ogf Profile notifications: added ensures and fallback in case OSS or game back-end isn't available when formatting Stomp topic. Should only ever be an issue in error circumstances - was causing shutdown crashes. #FORT-34585 #ROBOMERGE-SOURCE: CL 3246104 Change 3245623 on 2017/01/03 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - fixed Facebook iOS compile errors #ROBOMERGE-SOURCE: CL 3245622 Change 3245481 on 2017/01/03 by Jason.Bestimt #ROBOMERGE-AUTHOR: joe.wilcox UT-6837 - Added code from Fortnite that should fix this UT-6453 - Readded the hand off to HasPermission in OnlineIdentityMCP Updated the showdown tutorial with better encoding #ROBOMERGE-SOURCE: CL 3245480 Change 3245391 on 2017/01/03 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Make accessing/updating local player cache thread safe - Hopefully fixes crash where we're iterating over the local player cache while it's being updated [CodeReviewed] Jeff.Campeau #ROBOMERGE-SOURCE: CL 3245390 Change 3245367 on 2017/01/03 by josh.markiewicz #UE4 - FB OSS for PC - login flow implemented using web based LoginFlow module - implemented ShowLoginUI for external UI interface - added Login function with existing access token - fixed GetAuthType function - added reference to main online subsystem to Friend/Identity interfaces [CodeReviewed] sam.zamani #ROBOMERGE-SOURCE: CL 3245184 #CodeReview: josh.markiewicz, david.nikdel, greg.latcovich, sam.zamani Change 3245283 on 2017/01/03 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - LoginFlow module - supports other interfaces requesting a web browser widget for the purposes of capturing login flow and the resulting access token - OnlineSubsystemFacebook for Windows depends on this for starters - Applications are expected to initialize a LoginFlowManager and set up the callbacks to position the widget in their UI #ROBOMERGE-SOURCE: CL 3243109 Change 3245277 on 2017/01/03 by josh.markiewicz #UE4 - top level external UI interfaces changes to support calling out to a web browser widget for login flow requests #ROBOMERGE-SOURCE: CL 3243108 //ROBOMERGE_OGS_Main/PluginTestGame/Plugins/Online/OnlineSubsystem/Source/Public/Interfaces/OnlineExternalUIInterface.h #CodeReview: josh.markiewicz, david.nikdel, greg.latcovich, sam.zamani Change 3242995 on 2016/12/22 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Convert usages of MakeShareable to MakeShared #ROBOMERGE-SOURCE: CL 3242992 Change 3242505 on 2016/12/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Fix copyright line #ROBOMERGE-SOURCE: CL 3242504 Change 3242499 on 2016/12/21 by Jason.Bestimt #ROBOMERGE-AUTHOR: ian.fox #OnlineSubsystemLive - Add User Query interface - Rename FOnlineUserLive to FOnlineUserInfoLive (as our user query interface should be called FOnlineUserLive) #ROBOMERGE-SOURCE: CL 3242498 Change 3240229 on 2016/12/19 by Jason.Bestimt #ROBOMERGE-AUTHOR: josh.markiewicz #UE4 - added code to check for iOS app store updates for running game - OnlineAppStoreUtils.* contains code to download the app store metadata and parse it into an NSDictionary [CodeReviewed] david.nikdel, josh.adams, peter.sauerbrei #ROBOMERGE-SOURCE: CL 3240228 [CL 3367711 by Ian Fox in Main branch]
2017-03-28 12:36:26 -04:00
NewHeader.DLName = Filename + FString::Printf(TEXT("%d"),FileIdx);
NewHeader.FileSize = 0;
NewHeader.Hash.Empty();
FileHeaders.Add(NewHeader);
}
TriggerOnEnumerateFilesCompleteDelegates(true);
return true;
}
void FLocalTitleFile::GetFileList(TArray<FCloudHeader>& InFileHeaders)
{
InFileHeaders.Append(FileHeaders);
}
bool FLocalTitleFile::ReadFile(const FString& DLName)
{
const TArray< uint8 >* ExistingFileContents = DLNameToFileContents.Find(DLName);
if (ExistingFileContents != nullptr)
{
TriggerOnReadFileCompleteDelegates(true, DLName);
return true;
}
const FString FileName = GetFileNameFromDLName(DLName);
TArray<uint8> FileContents;
if (!FFileHelper::LoadFileToArray(FileContents, *(RootDirectory + FileName)))
{
TriggerOnReadFileCompleteDelegates(false, DLName);
return false;
}
DLNameToFileContents.Add(DLName, FileContents);
TriggerOnReadFileCompleteDelegates(true, DLName);
return true;
}
FString FLocalTitleFile::GetFileNameFromDLName(const FString& DLName) const
{
for (int Index = 0; Index < FileHeaders.Num(); Index++)
{
if (FileHeaders[Index].DLName == DLName)
{
return FileHeaders[Index].FileName;
}
}
return FString();
Copying //UE4/Dev-Core to //UE4/Dev-Main (Source: //UE4/Dev-Core @ 3847469) #lockdown Nick.Penwarden #rb none ============================ MAJOR FEATURES & CHANGES ============================ Change 3805828 by Gil.Gribb UE4 - Fixed a bug in the lock free stalling task queue and adjusted a comment. The code is not current used, so this is not actually change the way the code works. Change 3806784 by Ben.Marsh UAT: Remove code to compile UBT when using UE4Build. It should already be compiled as a dependency of UAT. Change 3807549 by Graeme.Thornton Add a cook timer around VerifyCanCookPackage. A licensee reports this taking a lot of time so it'll be good to account for it. Change 3807727 by Graeme.Thornton Unhide the text asset format experimental editor option Change 3807746 by Josh.Engebretson Remove WER from iOS platform Change 3807928 by Robert.Manuszewski When async loading, GC Clusters will be created after packages have been processed to avoid situations where some of the objects that are being added to a cluster haven't been fully loaded yet Change 3808221 by Steve.Robb GitHub #4307 - Made GetModulePtr() thread safe by not using GetModule() ^ I'm not convinced by how much thread-safer this is really, but it's tidier anyway. Change 3809233 by Graeme.Thornton TBA: Misc changes to text asset commandlet - Rename mode to "loadsave" - Add -outputFormat option which can be assigned "text" or "binary" - When saving binary, use a differentiated filename so that source assets aren't overwritten Change 3809518 by Ben.Marsh Remove the outdated UnrealSync automation script. Change 3809643 by Steve.Robb GitHub #4277 : fix bug; FMath::FormatIntToHumanReadable 3rd comma and negative value #jira UE-53037 Change 3809862 by Steve.Robb GitHub #3342 : [FRotator.h] Fix to DecompressAxisFromByte to be more efficient and reflect its intent accurately #jira UE-42593 Change 3811190 by Graeme.Thornton Add support for writing specific log channels to their own files Change 3811197 by Graeme.Thornton Minor updates to output formatting and timing for the text asset commandlet Change 3811257 by Robert.Manuszewski Cluster creation will now be time-sliced Change 3811565 by Steve.Robb Define out non-monolithic module functions. Change 3812561 by Steve.Robb GitHub #3886 : Enable Brace-Initialization for Declaring Variables Incorrect semi-colon search removed after discussion with author. Test added. #jira UE-48242 Change 3812864 by Steve.Robb Removal of some unproven code which was supposed to fix hot reloading BP class functions in plugins. See: https://udn.unrealengine.com/questions/376978/aitask-blueprint-nodes-disappear-when-their-module.html #jira UE-53089 Change 3820358 by Ben.Marsh PR #4358: Incredibuild use ShowAgent by default (Contributed by projectgheist) Change 3822594 by Ben.Marsh UAT: Improvements to log file handling. - Always create log files in the final location, rather than writing to a temp directory and copying in later. - Now supports -Verbose and -VeryVerbose for increasing log verbosity, rather than -Verbose=XXX. - Keep a backlog of log output before the log system is initialized, and flush it to the log file once it is. - Allow buildmachines to specify the uebp_FinalLogFolder environment variable, which is used to form paths for display. When build machines copy log files elsewhere after UAT finishes (eg. a network share), this allows error messages to display the right location. Change 3823695 by Ben.Marsh UGS: Fix issue where precompiled binaries would not be shown as available for a change until scrolling the last submitted code change into the buffer (other symptoms, like de-focussing the main window would cause it to go back to an unavailable state, since the changes buffer was shrunk). Now always queries changes up to the last change for which zipped binaries are available. Change 3823845 by Ben.Marsh UBT: Exclude C# projects for unsupported platforms when generating project files. Change 3824180 by Ben.Marsh UGS: Add an option to show changes by build machines, and move the "only show reviewed" option in there too (Options > Show Changes). #jira Change 3825777 by Steve.Robb Fix to return value of StringToBytes. Change 3825810 by Ben.Marsh UBT: Reduce length of include paths for MSVC toolchain. Change 3825822 by Robert.Manuszewski Optimized PIE lazy pointer fixup. Should be up to 8x faster now. Change 3826734 by Ben.Marsh Remove code to disable TextureFormatAndroid on Linux. It seems to be an editor dependency. Change 3827730 by Steve.Robb Try to avoid decltype(auto) if it's not supported. See: https://udn.unrealengine.com/questions/395644/build-417-with-c11-on-linux-ttuple-errors.html Change 3827745 by Steve.Robb Initializer list support for TMap. Change 3827770 by Steve.Robb GitHub #4399 : Added a CONSTEXPR qualifiers to FVariant::GetType() #jira UE-53813 Change 3829189 by Ben.Marsh UBT: Now always writes a minimal log file. By default, just contains the regular console output and any reasons why actions are outdated and needed to be executed. UAT directs child UBT instances to output logs into its own log folder, so that build machines can save them off. Change 3830444 by Steve.Robb BuildVersion and ModuleManifest moved to Core, and parsing of these files reimplemented to avoid a JSON library. This should be revisited when Core has its own JSON library. Change 3830718 by Ben.Marsh Fix incorrect group name being returned by FStatNameAndInfo::GetGroupName() for stat groups. The editor populates the viewport stats list by calling this for every registered stat and stat group (via FLevelViewportCommands::HandleNewStatGroup). The menu entry attempts to show the stat name with STAT_XXX stripped from the start as the menu item label, with the free-form text description as a tooltip. For stat groups, the it would previously just return the stat group name as "Groups" (due to the raw naming convention of "//Groups//STATGROUP_Foo//..."). Since this didn't match the expected naming convention in FLevelViewportCommands::HandleNewStat (ie. STAT_XXX or STATGROUP_XXX), it would fail to add it. When the first actual stat belonging to that group is added, it would add a menu entry for the group based on that, but the stat description no longer makes sense as a tooltip for the group. As a result, all the editor tooltips were junk. #jira UE-53845 Change 3831064 by Ben.Marsh Fix log file contention when spawning UBT recursively. Change 3832654 by Ben.Marsh UGS: Fix error panel not being selected when opened, and weird alignment/color issues on it. Change 3832680 by Ben.Marsh UGS: Fix failing to detect workspace if synced to a different stream. Seems to be a regression caused by recent P4D upgrade. Change 3832695 by Ben.Marsh UGS: Invert the options in the 'Show Changes' submenu for simplicity. Change 3833528 by Ben.Marsh UAT: Script to rewrite source files with public include paths relative to the 'Public' folder. Usage is: RebasePublicIncludePaths -UpdateDir=<Dir> [-Project=<Dir>] [-Write]. Change 3833543 by Ben.Marsh UBT: Allow targets to opt-out of having public include paths added for every dependent module. This reduces the command line length when building a target, which has recently become a problem with larger games (due to Microsoft's compiler embedding the command line into each object file, with a maximum length of 64kb). All engine modules are compiled with this enabled; games may opt into it by setting bLegacyPublicIncludePaths = false; from their .target.cs, as may individual modules. Change 3834354 by Robert.Manuszewski Archetype pointer will now be cached to avoid locking the object tables when acquiring its info. It should also be faster this way regardless of any locks. #jira UE-52035 Change 3834400 by Robert.Manuszewski Fixing crash on exit caused by cached archetypes not being cleaned up before static exit cleanup. #jira UE-52035 Change 3834947 by Steve.Robb USE_FORMAT_STRING_TYPE_CHECKING removed from FMsg::Logf and FMsg::Logf_Internal. Change 3835004 by Ben.Marsh Fix code that relies on dubious behavior of requiring referenced "include path only" modules having their _API macros set to be empty, even if the module is actually implemented in a separate DLL. Change 3835340 by Ben.Marsh Fix errors making installed build from directories with spaces in the name. Change 3835972 by Ben.Marsh UBT: Improved diagnostic message for targets which don't need a version file. Change 3836019 by Ben.Marsh UBT: Fix warnings caused by defining linkage macros for third party libraries. Change 3836269 by Ben.Marsh Fix message box larger than the screen height being created when a large number of modules are incompatible on startup. Change 3836543 by Ben.Marsh Enable SoundMod plugin on Linux, since it's already supported through the editor. Change 3836546 by Ben.Marsh PR #4412: fix type mismatch (Contributed by nakapon) Change 3836805 by Ben.Marsh Fix commandlet to compile marketplace plugins. Change 3836829 by Ben.Marsh UBT: Fix ability to precompile plugins from installed engine builds. Change 3837036 by Ben.Marsh UBT: Write the previous and new contents of intermediate files to the log if they change. Makes it easier to debug unexpected rebuilds. Change 3837037 by Ben.Marsh UBT: Fix engine modules having inconsistent definitions depending on whether modules are only referenced for their include paths vs being linked into a binary (due to different _API macro). Change 3837040 by Ben.Marsh UBT: Remove code that initializes members in ModuleRules and TargetRules objects before the constructor is run. This is no longer necessary, now that the backwards-compatible default constructors have been removed. Change 3837247 by Ben.Marsh UBT: Remove UELinkerFixups module, now that plugins and precompiled modules do not require hacks to force initialization (since they're linked in as object files). Encryption and signing keys are now set via macros expanded from the IMPLEMENT_PRIMARY_GAME_MODULE macro, via project-specific macros added in the TargetRules constructor. Change 3837262 by Ben.Marsh UBT: Set whether a module is an engine module or not via a default value for the rules assembly. All non-program engine and enterprise modules are created with this flag set to true; program targets and modules are now created from a different assembly that sets it to false. This removes hacks from UEBuildModule needed to adjust behavior for different module types based on the directory containing the module. Also add a bUseBackwardsCompatibleDefaults flag to the TargetRules class, also initialized to a default value from a setting passed to the RulesAssembly constructor. This controls whether modules created for the target should be configured to allow breaking changes to default settings, and is set to false for all engine targets, and true for all project targets. Change 3837343 by Ben.Marsh UBT: Remove the OverrideExecutableFileExtension target property. Change the only current use for this (the MayaLiveLinkPlugin target) to use a post build step to copy the file instead. Change 3837356 by Ben.Marsh Fix invalid character encodings. Change 3837727 by Graeme.Thornton UnrealPak: KeyGenerator: Only generate prime table when required, not all the time Change 3837823 by Ben.Marsh UBT: Output warnings and errors when compiling module rules assembly in a way that allows them to be double-clicked in the Visual Studio output window. Change 3837831 by Graeme.Thornton UBT: When parsing crypto settings, always load legacy data first, then allow the new system to override it. Provides the same key backwards compatibility that the editor settings class gives Change 3837857 by Robert.Manuszewski PR #4404: Make FGCArrayPool singleton global instead of per-CU (Contributed by mhutch) Change 3837943 by Robert.Manuszewski PR #4405: Fix FGarbageCollectionTracer (Contributed by mhutch) Change 3838451 by Ben.Marsh UBT: Fix exceptions thrown on a background thread while caching C++ includes not being caught and logged correctly. Now captures exceptions and re-throws on the main thread. #jira UE-53996 Change 3839519 by Ben.Marsh UBT: Simplify configuring bPrecompile and bUsePrecompile settings for modules. Each rules assembly can now be configured as installed, which defaults the module rules it creates to use precompiled data. Change 3843790 by Graeme.Thornton UnrealPak: Log the size of all encrypted data Change 3844258 by Ben.Marsh Fix plugin compile failure when created via new plugin wizard. Passing -plugin on the command line is unnecessary, and is now reserved for packaging external plugins for the marketplace. Also extend the length of time that the error toast stays visible, and don't delete the plugin on failure. #jira UE-54157 Change 3845796 by Ben.Marsh Workaround for slow performance of String.EndsWith() on Mono. Change 3845823 by Ben.Marsh Fix case sensitive matching of platform names in -TargetPlatform=X argument to BuildCookRun. #jira UE-54123 Change 3845901 by Arciel.Rekman Linux: fix crash due to lambda lifetime issues (UE-54040). - The lambda goes out of scope in FBufferVisualizationMenuCommands::CreateVisualizationCommands, crashing the editor if compiled with a recent clang (5.0+). (Edigrating 3819174 to Dev-Core) Change 3846439 by Ben.Marsh Revert CL 3822742 to always call Process.WaitForExit(). The Android target platform module in the editor spawns ADB.EXE, which inherits the editor's stdout/stderr handles and forks itself. Process.WaitForExit() waits for EOF on those pipes, which never occurs because the forked process never terminates. Proper fix is probably to have the engine explicitly duplicate stdout/stderr handles for new pipes to output process, but too risky before copying up to Main. Change 3816608 by Ben.Marsh UBT: Use DirectoryReference objects for all include paths. Change 3816954 by Ben.Marsh UBT: Remove bIncludeDependentLibrariesInLibrary option. This is not widely supported by platform toolchains, and is not used anywhere. Change 3816986 by Ben.Marsh UBT: Remove UEBuildBinaryConfig; UEBuildBinary objects are now just created directly. Change 3816991 by Ben.Marsh UBT: Deprecate PlatformSpecificDynamicallyLoadedModules. We no longer have any special behavior for these modules. Change 3823090 by Ben.Marsh UAT: Improve logging for child UAT instances. - Calling RunUAT now requires an identifier for prefixing into the parent log, which is also used to determine the name of the log folder. - Stdout is no longer written to its own output file, since it's written to the parent stdout, the parent log file, and the child log file anyway. - Log folders for child UAT instances are left intact, rather than being copied to the parent folder. The derived names for the copied names were confusing and hard to read. - Output from UAT is no longer returned as a string. It should not be parsed anyway (but may be huge!). ProcessResult now supports running without capturing output. Change 3826082 by Ben.Marsh UBT: Add a check to make sure that all modules that are precompiled are correctly marked to enable it, even if they are part of the build target. Change 3827025 by Ben.Marsh UBT: Move the compile output directory into a property on the module, and explicitly pass it to the toolchain when compiling. Change 3829927 by James.Hopkin Made HTTP interface const correct Change 3833533 by Ben.Marsh Rewrite engine source files to base include paths relative to the "Public" directory. This allows reducing the number of public include paths that have to be added for engine modules. Change 3835826 by Ben.Marsh UBT: Precompiled targets now generate a separate manifest for each precompiled module, rather than adding object files to a library. This fixes issues where object files from static libraries would not be linked into a target if a symbol in them was not referenced. Change 3835969 by Ben.Marsh UBT: Fix cases where text is being written directly to the console rather than via logging functions. Change 3837777 by Steve.Robb Format string type checking added to FOutputDevice::Logf. Fixes for those. Change 3838569 by Steve.Robb Algo moved up a folder. [CL 3847482 by Ben Marsh in Main branch]
2018-01-20 11:19:29 -05:00
}