2019-12-26 15:33:43 -05:00
// Copyright Epic Games, Inc. All Rights Reserved.
2014-03-14 14:13:41 -04:00
# include "SPackagesDialog.h"
Copying //UE4/Dev-Build to //UE4/Dev-Main (Source: //UE4/Dev-Build @ 3209340)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3209340 on 2016/11/23 by Ben.Marsh
Convert UE4 codebase to an "include what you use" model - where every header just includes the dependencies it needs, rather than every source file including large monolithic headers like Engine.h and UnrealEd.h.
Measured full rebuild times around 2x faster using XGE on Windows, and improvements of 25% or more for incremental builds and full rebuilds on most other platforms.
* Every header now includes everything it needs to compile.
* There's a CoreMinimal.h header that gets you a set of ubiquitous types from Core (eg. FString, FName, TArray, FVector, etc...). Most headers now include this first.
* There's a CoreTypes.h header that sets up primitive UE4 types and build macros (int32, PLATFORM_WIN64, etc...). All headers in Core include this first, as does CoreMinimal.h.
* Every .cpp file includes its matching .h file first.
* This helps validate that each header is including everything it needs to compile.
* No engine code includes a monolithic header such as Engine.h or UnrealEd.h any more.
* You will get a warning if you try to include one of these from the engine. They still exist for compatibility with game projects and do not produce warnings when included there.
* There have only been minor changes to our internal games down to accommodate these changes. The intent is for this to be as seamless as possible.
* No engine code explicitly includes a precompiled header any more.
* We still use PCHs, but they're force-included on the compiler command line by UnrealBuildTool instead. This lets us tune what they contain without breaking any existing include dependencies.
* PCHs are generated by a tool to get a statistical amount of coverage for the source files using it, and I've seeded the new shared PCHs to contain any header included by > 15% of source files.
Tool used to generate this transform is at Engine\Source\Programs\IncludeTool.
[CL 3209342 by Ben Marsh in Main branch]
2016-11-23 15:48:37 -05:00
# include "Widgets/Text/STextBlock.h"
# include "Widgets/Views/SListView.h"
# include "UObject/UObjectHash.h"
# include "Textures/SlateIcon.h"
# include "Framework/Commands/UIAction.h"
# include "Widgets/Layout/SSpacer.h"
# include "Widgets/Images/SImage.h"
# include "Framework/MultiBox/MultiBoxBuilder.h"
# include "Widgets/Input/SButton.h"
# include "Widgets/Input/SCheckBox.h"
# include "EditorStyleSet.h"
# include "IAssetTools.h"
# include "IAssetTypeActions.h"
2021-03-04 10:30:31 -04:00
# include "AssetRegistry/IAssetRegistry.h"
2014-03-14 14:13:41 -04:00
# include "AssetToolsModule.h"
2021-01-14 12:45:46 -04:00
# include "SWarningOrErrorBox.h"
2014-03-14 14:13:41 -04:00
# define LOCTEXT_NAMESPACE "SPackagesDialog"
2014-04-02 18:09:23 -04:00
namespace SPackagesDialogDefs
{
const FName ColumnID_CheckBoxLabel ( " CheckBox " ) ;
const FName ColumnID_IconLabel ( " Icon " ) ;
2020-08-11 01:36:57 -04:00
const FName ColumnID_AssetLabel ( " Asset " ) ;
2020-09-03 08:20:02 -04:00
const FName ColumnID_OwnerLabel ( " Owner " ) ;
2020-08-11 01:36:57 -04:00
const FName ColumnID_PackageLabel ( " Package " ) ;
2014-04-02 18:09:23 -04:00
const FName ColumnID_TypeLabel ( " Type " ) ;
2015-01-12 11:19:17 -05:00
const FName ColumnID_CheckedOutByLabel ( " CheckedOutBy " ) ;
2014-04-02 18:09:23 -04:00
2021-01-14 12:45:46 -04:00
const float CheckBoxColumnWidth = 38.0f ;
const float IconColumnWidth = 22.0f ;
2014-04-02 18:09:23 -04:00
}
UObject * FPackageItem : : GetPackageObject ( ) const
{
2021-04-27 09:34:50 -04:00
UObject * FoundObject = nullptr ;
2020-08-11 01:36:57 -04:00
if ( ! FileName . StartsWith ( TEXT ( " /Temp/Untitled " ) ) )
2014-04-02 18:09:23 -04:00
{
Copying //UE4/Fortnite-Staging to //UE4/Main
#lockdown nick.penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2806454 on 2015/12/16 by Bob.Tellez
#UE4 Getting crash reporting working again on linux servers. Since -Unattended is now being passed BEFORE the target folder, the cmd line parsing code was failing so now it parses tokens and switches in a more general way. Also, diagnostics.txt had the incorrect case, since the d is supposed to be capitolized and the crash report processor is case sensitive.
#rb Ben.Zeigler
#codereview Dmitry.Rekman
Change 2805502 on 2015/12/16 by Ben.Zeigler
#UE4 Move ValidateEnumProperties into ValidateGeneratedClass, it was happening too early in the generation process so was being called at an invalid time.
As a result of this ValidateEnumProperties will not be called correctly for compile on load blueprints, that issue is covered in UE-24569
#codereview mike.beach, bob.tellez
Change 2805288 on 2015/12/16 by David.Nikdel
#HTTP #HttpRetry
- Add new Failed_ConnectionError code to EHttpRequestStatus to distinguish between connection errors and protocol errors.
- Changed HTTP retry logic a little bit
* If a response was received, retry on service-specific explicit HTTP codes (defaults to empty)
* If a response was not received and we did not send a full request, automatically retry
* If a response was not received and a request may have been sent, retry if the verb is GET or HEAD (should be idempotent)
- Adjusted Curl/IOS/Mac/PS4/WinInet to try and distinguish Failed_ConnectionError where possible
* Other systems will default to Failed which is ok (ConnectionError is an opportunistic categorization)
* Opened a PS4 ticket to try to improve detection, but unfortunately there's no way (currently) to distinguish between send timeout, connection timeout, and receive timeout, the latter being the problematic case.
- Removed the concept of global/default HTTP retry status codes. No system has enough knowledge to set those globally.
* Individual requests still specify explicit "retryable" codes and McpServiceBase sets that on each request on a per-service basis
#RB: Sam.Zamani
#CodeReview: Sam.Zamani, Josh.Markiewicz, Alex.Fennell, Dmitry.Rekman, Sam.Spiro
#Fixes: FORT-17804
Change 2803864 on 2015/12/15 by Bob.Tellez
#UE4 Changed usage of !UE_SERVER to !IsRunningDedicatedServer in cases where we are preventing load attempts on UFonts. This is so running an editor build with -server works the same as running a cooked server.
#rb Dmitry.Rekman
#codereview Nick.Darnell
Change 2803677 on 2015/12/15 by Billy.Bramer
- Expose equality and inequality operators for gameplay attributes
#rb Todd.Eckert
Change 2802881 on 2015/12/14 by Bob.Tellez
#UE4 InheritableComponentHandler no longer keeps records for components that we are no longer inheriting.
#rb Phillip.Kavan, Maciej.Mroz
#codereview Phillip.Kavan, Maciej.Mroz
Change 2801636 on 2015/12/14 by Bob.Tellez
#UE4 Returning package insert order for non-imports back to being after those of matching priorities unconditionally since this is what you want even when you are not using the asset registry to preload packages.
#codereview Graeme.Thornton
Change 2800400 on 2015/12/11 by Jonathan.Lindquist
Submitting a new Pivot Painter Edition
- now renders to textures
- improved workflow
- greater capabilities
Change 2799579 on 2015/12/11 by John.Abercrombie
[AUTOMERGE]
Fixed EQS BP query wrappers getting GCed before wrapped query finishes #UE4
Fixes FORT-18649 - Patrols don't spawn consistently
- The patrol blueprint was waiting (endlessly) for an EQS query to finish but because the wrapper could be GC-ed while the EQS query was running the delegate would never fire
#rb me (this code was written by MieszkoZ)
(removed code review for integration of Mieszko.Zielinski, Phil.Cole, Dominic.Barile)
--------
Integrated using branch UE4-Fortnite-To-UE4-FortniteReleases/0.10 (reversed) of change#2799575 by John.Abercrombie on 2015/12/11 09:55:11.
Change 2799018 on 2015/12/10 by Bob.Tellez
#UE4 The asset registry tags stripped from cooked builds is now a blacklist by default that includes only the FiB tag. You can opt-in to using the whitelist by flipping the bUseAssetRegistryTagsWhitelistInsteadOfBlacklist flag.
#rb Fred.Kimberley
#codereview Peter.Knepley
Change 2798926 on 2015/12/10 by Bob.Tellez
#UE4 Removed some showflags from the list of "Fixed" showflags since they were actually in use at runtime in Fortnite in a scene capture.
#jira FORT-18514
#codereview Martin.Mittring
Change 2797758 on 2015/12/10 by Mark.Satterthwaite
Defer calls to AUGraphUpdate into FCoreAudioDevice::UpdateHardware - this call will synchronise the calling thread with the CoreAudio thread/run-loop so that the CoreAudio graph is safe to modify and this may incur a significant stall. This means it is far more efficient to amortise the cost of all changes to the graph with a single call. To ensure correctness the audio format conversion components are cached and disposed of after the call to AUGraphUpdate so that any existing operations on the CoreAudio thread are completed prior to disposal.
Change 2781204 on 2015/11/25 by Dmitry.Rekman
Linux: use jemalloc by default if available.
- Alleviates one of the reasons for player disconnect (FORT-18048), which was machines running OOM.
#rb Bob.Tellez
#codereview Bob.Tellez, Ben.Zeigler
Change 2779398 on 2015/11/24 by Mark.Satterthwaite
Switch the default graphics API on Mac back to OpenGL, but allow Metal to run with -metal (or -metalsm5 for experimental SM5 support).
2016-01-08 19:10:43 -05:00
TArray < UObject * > ObjectsInPackage ;
2020-08-11 01:36:57 -04:00
GetObjectsWithPackage ( Package , ObjectsInPackage , false ) ;
Copying //UE4/Fortnite-Staging to //UE4/Main
#lockdown nick.penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2806454 on 2015/12/16 by Bob.Tellez
#UE4 Getting crash reporting working again on linux servers. Since -Unattended is now being passed BEFORE the target folder, the cmd line parsing code was failing so now it parses tokens and switches in a more general way. Also, diagnostics.txt had the incorrect case, since the d is supposed to be capitolized and the crash report processor is case sensitive.
#rb Ben.Zeigler
#codereview Dmitry.Rekman
Change 2805502 on 2015/12/16 by Ben.Zeigler
#UE4 Move ValidateEnumProperties into ValidateGeneratedClass, it was happening too early in the generation process so was being called at an invalid time.
As a result of this ValidateEnumProperties will not be called correctly for compile on load blueprints, that issue is covered in UE-24569
#codereview mike.beach, bob.tellez
Change 2805288 on 2015/12/16 by David.Nikdel
#HTTP #HttpRetry
- Add new Failed_ConnectionError code to EHttpRequestStatus to distinguish between connection errors and protocol errors.
- Changed HTTP retry logic a little bit
* If a response was received, retry on service-specific explicit HTTP codes (defaults to empty)
* If a response was not received and we did not send a full request, automatically retry
* If a response was not received and a request may have been sent, retry if the verb is GET or HEAD (should be idempotent)
- Adjusted Curl/IOS/Mac/PS4/WinInet to try and distinguish Failed_ConnectionError where possible
* Other systems will default to Failed which is ok (ConnectionError is an opportunistic categorization)
* Opened a PS4 ticket to try to improve detection, but unfortunately there's no way (currently) to distinguish between send timeout, connection timeout, and receive timeout, the latter being the problematic case.
- Removed the concept of global/default HTTP retry status codes. No system has enough knowledge to set those globally.
* Individual requests still specify explicit "retryable" codes and McpServiceBase sets that on each request on a per-service basis
#RB: Sam.Zamani
#CodeReview: Sam.Zamani, Josh.Markiewicz, Alex.Fennell, Dmitry.Rekman, Sam.Spiro
#Fixes: FORT-17804
Change 2803864 on 2015/12/15 by Bob.Tellez
#UE4 Changed usage of !UE_SERVER to !IsRunningDedicatedServer in cases where we are preventing load attempts on UFonts. This is so running an editor build with -server works the same as running a cooked server.
#rb Dmitry.Rekman
#codereview Nick.Darnell
Change 2803677 on 2015/12/15 by Billy.Bramer
- Expose equality and inequality operators for gameplay attributes
#rb Todd.Eckert
Change 2802881 on 2015/12/14 by Bob.Tellez
#UE4 InheritableComponentHandler no longer keeps records for components that we are no longer inheriting.
#rb Phillip.Kavan, Maciej.Mroz
#codereview Phillip.Kavan, Maciej.Mroz
Change 2801636 on 2015/12/14 by Bob.Tellez
#UE4 Returning package insert order for non-imports back to being after those of matching priorities unconditionally since this is what you want even when you are not using the asset registry to preload packages.
#codereview Graeme.Thornton
Change 2800400 on 2015/12/11 by Jonathan.Lindquist
Submitting a new Pivot Painter Edition
- now renders to textures
- improved workflow
- greater capabilities
Change 2799579 on 2015/12/11 by John.Abercrombie
[AUTOMERGE]
Fixed EQS BP query wrappers getting GCed before wrapped query finishes #UE4
Fixes FORT-18649 - Patrols don't spawn consistently
- The patrol blueprint was waiting (endlessly) for an EQS query to finish but because the wrapper could be GC-ed while the EQS query was running the delegate would never fire
#rb me (this code was written by MieszkoZ)
(removed code review for integration of Mieszko.Zielinski, Phil.Cole, Dominic.Barile)
--------
Integrated using branch UE4-Fortnite-To-UE4-FortniteReleases/0.10 (reversed) of change#2799575 by John.Abercrombie on 2015/12/11 09:55:11.
Change 2799018 on 2015/12/10 by Bob.Tellez
#UE4 The asset registry tags stripped from cooked builds is now a blacklist by default that includes only the FiB tag. You can opt-in to using the whitelist by flipping the bUseAssetRegistryTagsWhitelistInsteadOfBlacklist flag.
#rb Fred.Kimberley
#codereview Peter.Knepley
Change 2798926 on 2015/12/10 by Bob.Tellez
#UE4 Removed some showflags from the list of "Fixed" showflags since they were actually in use at runtime in Fortnite in a scene capture.
#jira FORT-18514
#codereview Martin.Mittring
Change 2797758 on 2015/12/10 by Mark.Satterthwaite
Defer calls to AUGraphUpdate into FCoreAudioDevice::UpdateHardware - this call will synchronise the calling thread with the CoreAudio thread/run-loop so that the CoreAudio graph is safe to modify and this may incur a significant stall. This means it is far more efficient to amortise the cost of all changes to the graph with a single call. To ensure correctness the audio format conversion components are cached and disposed of after the call to AUGraphUpdate so that any existing operations on the CoreAudio thread are completed prior to disposal.
Change 2781204 on 2015/11/25 by Dmitry.Rekman
Linux: use jemalloc by default if available.
- Alleviates one of the reasons for player disconnect (FORT-18048), which was machines running OOM.
#rb Bob.Tellez
#codereview Bob.Tellez, Ben.Zeigler
Change 2779398 on 2015/11/24 by Mark.Satterthwaite
Switch the default graphics API on Mac back to OpenGL, but allow Metal to run with -metal (or -metalsm5 for experimental SM5 support).
2016-01-08 19:10:43 -05:00
for ( UObject * Obj : ObjectsInPackage )
{
2021-03-16 16:26:34 -04:00
// Don't filter pending kill objects here as we need to determine if the package contains
// a single, pending kill object to properly show it in the save dialog.
2021-04-27 09:34:50 -04:00
// Still choose non pending kill objects over pending kill objects.
2021-03-17 08:59:59 -04:00
if ( Obj - > IsAsset ( ) & & ! UE : : AssetRegistry : : FFiltering : : ShouldSkipAsset ( Obj ) )
Copying //UE4/Fortnite-Staging to //UE4/Main
#lockdown nick.penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2806454 on 2015/12/16 by Bob.Tellez
#UE4 Getting crash reporting working again on linux servers. Since -Unattended is now being passed BEFORE the target folder, the cmd line parsing code was failing so now it parses tokens and switches in a more general way. Also, diagnostics.txt had the incorrect case, since the d is supposed to be capitolized and the crash report processor is case sensitive.
#rb Ben.Zeigler
#codereview Dmitry.Rekman
Change 2805502 on 2015/12/16 by Ben.Zeigler
#UE4 Move ValidateEnumProperties into ValidateGeneratedClass, it was happening too early in the generation process so was being called at an invalid time.
As a result of this ValidateEnumProperties will not be called correctly for compile on load blueprints, that issue is covered in UE-24569
#codereview mike.beach, bob.tellez
Change 2805288 on 2015/12/16 by David.Nikdel
#HTTP #HttpRetry
- Add new Failed_ConnectionError code to EHttpRequestStatus to distinguish between connection errors and protocol errors.
- Changed HTTP retry logic a little bit
* If a response was received, retry on service-specific explicit HTTP codes (defaults to empty)
* If a response was not received and we did not send a full request, automatically retry
* If a response was not received and a request may have been sent, retry if the verb is GET or HEAD (should be idempotent)
- Adjusted Curl/IOS/Mac/PS4/WinInet to try and distinguish Failed_ConnectionError where possible
* Other systems will default to Failed which is ok (ConnectionError is an opportunistic categorization)
* Opened a PS4 ticket to try to improve detection, but unfortunately there's no way (currently) to distinguish between send timeout, connection timeout, and receive timeout, the latter being the problematic case.
- Removed the concept of global/default HTTP retry status codes. No system has enough knowledge to set those globally.
* Individual requests still specify explicit "retryable" codes and McpServiceBase sets that on each request on a per-service basis
#RB: Sam.Zamani
#CodeReview: Sam.Zamani, Josh.Markiewicz, Alex.Fennell, Dmitry.Rekman, Sam.Spiro
#Fixes: FORT-17804
Change 2803864 on 2015/12/15 by Bob.Tellez
#UE4 Changed usage of !UE_SERVER to !IsRunningDedicatedServer in cases where we are preventing load attempts on UFonts. This is so running an editor build with -server works the same as running a cooked server.
#rb Dmitry.Rekman
#codereview Nick.Darnell
Change 2803677 on 2015/12/15 by Billy.Bramer
- Expose equality and inequality operators for gameplay attributes
#rb Todd.Eckert
Change 2802881 on 2015/12/14 by Bob.Tellez
#UE4 InheritableComponentHandler no longer keeps records for components that we are no longer inheriting.
#rb Phillip.Kavan, Maciej.Mroz
#codereview Phillip.Kavan, Maciej.Mroz
Change 2801636 on 2015/12/14 by Bob.Tellez
#UE4 Returning package insert order for non-imports back to being after those of matching priorities unconditionally since this is what you want even when you are not using the asset registry to preload packages.
#codereview Graeme.Thornton
Change 2800400 on 2015/12/11 by Jonathan.Lindquist
Submitting a new Pivot Painter Edition
- now renders to textures
- improved workflow
- greater capabilities
Change 2799579 on 2015/12/11 by John.Abercrombie
[AUTOMERGE]
Fixed EQS BP query wrappers getting GCed before wrapped query finishes #UE4
Fixes FORT-18649 - Patrols don't spawn consistently
- The patrol blueprint was waiting (endlessly) for an EQS query to finish but because the wrapper could be GC-ed while the EQS query was running the delegate would never fire
#rb me (this code was written by MieszkoZ)
(removed code review for integration of Mieszko.Zielinski, Phil.Cole, Dominic.Barile)
--------
Integrated using branch UE4-Fortnite-To-UE4-FortniteReleases/0.10 (reversed) of change#2799575 by John.Abercrombie on 2015/12/11 09:55:11.
Change 2799018 on 2015/12/10 by Bob.Tellez
#UE4 The asset registry tags stripped from cooked builds is now a blacklist by default that includes only the FiB tag. You can opt-in to using the whitelist by flipping the bUseAssetRegistryTagsWhitelistInsteadOfBlacklist flag.
#rb Fred.Kimberley
#codereview Peter.Knepley
Change 2798926 on 2015/12/10 by Bob.Tellez
#UE4 Removed some showflags from the list of "Fixed" showflags since they were actually in use at runtime in Fortnite in a scene capture.
#jira FORT-18514
#codereview Martin.Mittring
Change 2797758 on 2015/12/10 by Mark.Satterthwaite
Defer calls to AUGraphUpdate into FCoreAudioDevice::UpdateHardware - this call will synchronise the calling thread with the CoreAudio thread/run-loop so that the CoreAudio graph is safe to modify and this may incur a significant stall. This means it is far more efficient to amortise the cost of all changes to the graph with a single call. To ensure correctness the audio format conversion components are cached and disposed of after the call to AUGraphUpdate so that any existing operations on the CoreAudio thread are completed prior to disposal.
Change 2781204 on 2015/11/25 by Dmitry.Rekman
Linux: use jemalloc by default if available.
- Alleviates one of the reasons for player disconnect (FORT-18048), which was machines running OOM.
#rb Bob.Tellez
#codereview Bob.Tellez, Ben.Zeigler
Change 2779398 on 2015/11/24 by Mark.Satterthwaite
Switch the default graphics API on Mac back to OpenGL, but allow Metal to run with -metal (or -metalsm5 for experimental SM5 support).
2016-01-08 19:10:43 -05:00
{
2021-04-27 09:34:50 -04:00
if ( ! FoundObject | | ( FoundObject - > IsPendingKill ( ) & & ! Obj - > IsPendingKill ( ) ) )
{
FoundObject = Obj ;
}
Copying //UE4/Fortnite-Staging to //UE4/Main
#lockdown nick.penwarden
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2806454 on 2015/12/16 by Bob.Tellez
#UE4 Getting crash reporting working again on linux servers. Since -Unattended is now being passed BEFORE the target folder, the cmd line parsing code was failing so now it parses tokens and switches in a more general way. Also, diagnostics.txt had the incorrect case, since the d is supposed to be capitolized and the crash report processor is case sensitive.
#rb Ben.Zeigler
#codereview Dmitry.Rekman
Change 2805502 on 2015/12/16 by Ben.Zeigler
#UE4 Move ValidateEnumProperties into ValidateGeneratedClass, it was happening too early in the generation process so was being called at an invalid time.
As a result of this ValidateEnumProperties will not be called correctly for compile on load blueprints, that issue is covered in UE-24569
#codereview mike.beach, bob.tellez
Change 2805288 on 2015/12/16 by David.Nikdel
#HTTP #HttpRetry
- Add new Failed_ConnectionError code to EHttpRequestStatus to distinguish between connection errors and protocol errors.
- Changed HTTP retry logic a little bit
* If a response was received, retry on service-specific explicit HTTP codes (defaults to empty)
* If a response was not received and we did not send a full request, automatically retry
* If a response was not received and a request may have been sent, retry if the verb is GET or HEAD (should be idempotent)
- Adjusted Curl/IOS/Mac/PS4/WinInet to try and distinguish Failed_ConnectionError where possible
* Other systems will default to Failed which is ok (ConnectionError is an opportunistic categorization)
* Opened a PS4 ticket to try to improve detection, but unfortunately there's no way (currently) to distinguish between send timeout, connection timeout, and receive timeout, the latter being the problematic case.
- Removed the concept of global/default HTTP retry status codes. No system has enough knowledge to set those globally.
* Individual requests still specify explicit "retryable" codes and McpServiceBase sets that on each request on a per-service basis
#RB: Sam.Zamani
#CodeReview: Sam.Zamani, Josh.Markiewicz, Alex.Fennell, Dmitry.Rekman, Sam.Spiro
#Fixes: FORT-17804
Change 2803864 on 2015/12/15 by Bob.Tellez
#UE4 Changed usage of !UE_SERVER to !IsRunningDedicatedServer in cases where we are preventing load attempts on UFonts. This is so running an editor build with -server works the same as running a cooked server.
#rb Dmitry.Rekman
#codereview Nick.Darnell
Change 2803677 on 2015/12/15 by Billy.Bramer
- Expose equality and inequality operators for gameplay attributes
#rb Todd.Eckert
Change 2802881 on 2015/12/14 by Bob.Tellez
#UE4 InheritableComponentHandler no longer keeps records for components that we are no longer inheriting.
#rb Phillip.Kavan, Maciej.Mroz
#codereview Phillip.Kavan, Maciej.Mroz
Change 2801636 on 2015/12/14 by Bob.Tellez
#UE4 Returning package insert order for non-imports back to being after those of matching priorities unconditionally since this is what you want even when you are not using the asset registry to preload packages.
#codereview Graeme.Thornton
Change 2800400 on 2015/12/11 by Jonathan.Lindquist
Submitting a new Pivot Painter Edition
- now renders to textures
- improved workflow
- greater capabilities
Change 2799579 on 2015/12/11 by John.Abercrombie
[AUTOMERGE]
Fixed EQS BP query wrappers getting GCed before wrapped query finishes #UE4
Fixes FORT-18649 - Patrols don't spawn consistently
- The patrol blueprint was waiting (endlessly) for an EQS query to finish but because the wrapper could be GC-ed while the EQS query was running the delegate would never fire
#rb me (this code was written by MieszkoZ)
(removed code review for integration of Mieszko.Zielinski, Phil.Cole, Dominic.Barile)
--------
Integrated using branch UE4-Fortnite-To-UE4-FortniteReleases/0.10 (reversed) of change#2799575 by John.Abercrombie on 2015/12/11 09:55:11.
Change 2799018 on 2015/12/10 by Bob.Tellez
#UE4 The asset registry tags stripped from cooked builds is now a blacklist by default that includes only the FiB tag. You can opt-in to using the whitelist by flipping the bUseAssetRegistryTagsWhitelistInsteadOfBlacklist flag.
#rb Fred.Kimberley
#codereview Peter.Knepley
Change 2798926 on 2015/12/10 by Bob.Tellez
#UE4 Removed some showflags from the list of "Fixed" showflags since they were actually in use at runtime in Fortnite in a scene capture.
#jira FORT-18514
#codereview Martin.Mittring
Change 2797758 on 2015/12/10 by Mark.Satterthwaite
Defer calls to AUGraphUpdate into FCoreAudioDevice::UpdateHardware - this call will synchronise the calling thread with the CoreAudio thread/run-loop so that the CoreAudio graph is safe to modify and this may incur a significant stall. This means it is far more efficient to amortise the cost of all changes to the graph with a single call. To ensure correctness the audio format conversion components are cached and disposed of after the call to AUGraphUpdate so that any existing operations on the CoreAudio thread are completed prior to disposal.
Change 2781204 on 2015/11/25 by Dmitry.Rekman
Linux: use jemalloc by default if available.
- Alleviates one of the reasons for player disconnect (FORT-18048), which was machines running OOM.
#rb Bob.Tellez
#codereview Bob.Tellez, Ben.Zeigler
Change 2779398 on 2015/11/24 by Mark.Satterthwaite
Switch the default graphics API on Mac back to OpenGL, but allow Metal to run with -metal (or -metalsm5 for experimental SM5 support).
2016-01-08 19:10:43 -05:00
}
}
2014-04-02 18:09:23 -04:00
}
2021-04-27 09:34:50 -04:00
return FoundObject ;
2014-04-02 18:09:23 -04:00
}
2018-05-23 21:04:31 -04:00
bool FPackageItem : : HasMultipleAssets ( ) const
{
bool bHasMultipleAssets = false ;
2020-08-11 01:36:57 -04:00
if ( ! FileName . StartsWith ( TEXT ( " /Temp/Untitled " ) ) )
2018-05-23 21:04:31 -04:00
{
TArray < UObject * > ObjectsInPackage ;
2020-08-11 01:36:57 -04:00
GetObjectsWithPackage ( Package , ObjectsInPackage , false ) ;
2018-05-23 21:04:31 -04:00
UObject * FirstObj = nullptr ;
for ( UObject * Obj : ObjectsInPackage )
{
2021-03-16 16:26:34 -04:00
// Filter pending kill objects here because we don't want the case where a package contains
// an actor and a deleted actor to be reported as multiple assets.
2021-03-17 08:59:59 -04:00
if ( Obj - > IsAsset ( ) & & ! Obj - > IsPendingKill ( ) & & ! UE : : AssetRegistry : : FFiltering : : ShouldSkipAsset ( Obj ) )
2018-05-23 21:04:31 -04:00
{
if ( FirstObj = = nullptr )
{
FirstObj = Obj ;
}
else
{
bHasMultipleAssets = true ;
break ;
}
}
}
}
return bHasMultipleAssets ;
}
2021-02-11 19:52:08 -04:00
bool FPackageItem : : GetTypeNameAndColor ( FText & OutName , FColor & OutColor ) const
2014-04-02 18:09:23 -04:00
{
Copying //UE4/Dev-Editor to //UE4/Main
==========================
MAJOR FEATURES + CHANGES
==========================
Change 2756103 on 2015/11/05 by Jamie.Dale
Implemented UFont::GetResourceSize to work correctly with the Size Map tool
Change 2756104 on 2015/11/05 by Jamie.Dale
Changed the font used when a font is missing or invalid to be the last resort font, rather than the localized fallback font
The localized fallback font could cause different results based on your culture, and the last resort font makes it clearer that something is set-up incorrectly as it just draws invalid glyph markers for all of the text.
Change 2756105 on 2015/11/05 by Jamie.Dale
Fixed a crash when using an empty FKey property with a Data Table
FKeyStructCustomization was asserting because there were no objects being edited, due to a newly added Data Table containing zero rows.
I've removed this assert, and also updated SKeySelector to no longer require a separate argument to say whether multiple keys with different values are selected (this is now calculated from the call to get the current key, which will return an empty TOptional for multiple values).
#jira UE-22897
Change 2757015 on 2015/11/06 by Joe.Tidmarsh
SSProgressBar marquee tint. Accounts for widget color and opacity.
PR #1698
Change 2757156 on 2015/11/06 by Joe.Tidmarsh
Implemented "Go to Variable" functionality for widgets in Widget Blueprint Editor.
When we switch modes in UMG from Designer to Graph. We select the variable (In "My Blueprint"), if one exists, for the currently selected widget. Additionally we update the details panel.
* Added SelectGraphActionItemByName to FBlueprintEditor. This selects an item in My Blueprint and also displays it in the details panel of graph mode. SMyBlueprint is not available to FWidgetBlueprintEditor in UMGEditor module as it's privately implemented within Kismet.
#rb Ben.Cosh
#jira UE-20170
Change 2757181 on 2015/11/06 by Jamie.Dale
Cleaned up some duplication in UMG text widgets, and exposed the text shaping options
The common properties used by all text widgets that are text layout based have been moved into a UTextLayoutWidget base class, and all text layout based widgets now derive from this.
The options needed to control the text shaping method used by a text based widget have been exposed via the FShapedTextOptions struct. This contains a way to manage these optional (and advanced) overrides. You typically wouldn't change these from the default unless you knew exactly what you were doing (eg, you have a text block containing only numbers).
This change also updates SRichTextBlock to work with an invalidation panel in the same way that STextBlock does
Change 2757734 on 2015/11/06 by David.Nikdel
#UE4 #Editor
- Added support for meta=(TitleProperty="StructPropertyNameHere") on properties of type TArray<FSomeStruct>.
- This changes the editor rolled-up display of these values from "{0} members" to a stringified version of the specified property (if found).
#CodeReview: Matt.Kuhlenschmidt
Change 2758786 on 2015/11/09 by Joe.Tidmarsh
Border widget now correctly synchronizes padding property
#jira UE-23070
Change 2758791 on 2015/11/09 by Joe.Tidmarsh
Shadow of FCanvasTextItem should be drawn before the outline color. Consulted with Bruce.N who believes this is not the intended behavior and was an oversight when refactoring FCanvas (CL 1695138)
#jira UE-21623
#1608
#rb Simon.Tovey, Bruce.Nesbit
Change 2758813 on 2015/11/09 by Joe.Tidmarsh
UMG: Attempting to parent multiple widgets (in Hierarchy tree) to a widget that can't have multiple children will notify the user and ignore the operation.
[UE-22921] [CrashReport] Parenting multiple actors under border crashes editor
#jira UE-22921
Change 2759234 on 2015/11/09 by Nick.Darnell
Slate - Improving the way we track references to materials in slate to better keep things alive until they're no longer needed for rendering. Additionally, making it so the we use the material and texture free list when possible when cleaning up things as to not allocate new memory if not required. Concidentually this can help with problems with corrupted memory on destruct as well, because it means the memory isn't really going to become garbage any more.
#codereview Matt.Kuhlenschmidt, Bob.Tellez
Change 2760954 on 2015/11/10 by Nick.Darnell
Slate - A bug in the introduction of custom rendered elements accidentally broke filling out the texture coordinates for standard material usage. Materials should once again tile correctly just like images do.
#jira UE-23118
Change 2761129 on 2015/11/10 by Nick.Darnell
Slate - Removing the Pre-Multiply alpha path the way it was added, introducing it in a way that doesn't require changes inside the shader. Continuing to improve the SRetainerWidget to no longer have a frame delay between resizes and painting, also working on getting it handle clipping correctly but still not there yet.
Change 2761391 on 2015/11/10 by Alexis.Matte
jira UE-20281 and UE-22259
Fbx scene Re-import workflow
- First draft of the reimport workflow using a reimport asset in the content browser
#codereview nick.darnell
Change 2762323 on 2015/11/11 by Alexis.Matte
fix build compilation
Change 2762407 on 2015/11/11 by Jamie.Dale
UDataTable::SaveStructData now writes out dummy data when RowStruct is null
This didn't used to happen, which would cause a miss-match between what UDataTable::LoadStructData was expecting, and would result in a Data Table that could never be loaded again.
This change also improves the error message when editing a Data Table with a null row struct, and adds the editor-only RowStructName property to cache the name of the last used struct (for error reporting).
#jira UE-22789
Change 2762508 on 2015/11/11 by Nick.Darnell
UMG - Making it more obvious what keys do special stuff with anchors in UMG. Fixing the way snapping to anchors works with Control, it now only zeros out the side you're dragging instead of the entire widget, which was silly. Enhancing the designer message system to no longer be based on an enum and instead let arbitrary systems push and pop FText messages. Fixing animations in the anchor drop down to properly animate, broke when we introduced active timers.
Change 2763241 on 2015/11/11 by Nick.Darnell
Slate - We no longer allow popup windows to be larger than the primary display window for windows where max width/height is unspecified. This is to prevent accidential creation of tooltip windows that are larger than the driver allows causing crashes.
#jira UE-20336
2015-12-12 08:54:23 -05:00
// Resolve the object belonging to the package and cache.
if ( ! Object . IsValid ( ) )
{
Object = GetPackageObject ( ) ;
}
2020-08-11 01:36:57 -04:00
if ( Object . IsValid ( /*bEvenIfPendingKill*/ true , /*bThreadsafeTest*/ false ) )
2014-04-02 18:09:23 -04:00
{
// Load the asset tools module to get access to the class color
2020-08-11 01:36:57 -04:00
UObject * ObjectPtr = Object . Get ( /*bEvenIfPendingKill*/ true ) ;
2014-04-02 18:09:23 -04:00
const FAssetToolsModule & AssetToolsModule = FModuleManager : : LoadModuleChecked < FAssetToolsModule > ( TEXT ( " AssetTools " ) ) ;
2020-08-11 01:36:57 -04:00
const TSharedPtr < IAssetTypeActions > AssetTypeActions = AssetToolsModule . Get ( ) . GetAssetTypeActionsForClass ( ObjectPtr - > GetClass ( ) ) . Pin ( ) ;
2014-04-02 18:09:23 -04:00
if ( AssetTypeActions . IsValid ( ) )
{
2018-05-23 21:04:31 -04:00
if ( HasMultipleAssets ( ) )
{
OutColor = FColor : : White ;
2021-02-11 19:52:08 -04:00
OutName = LOCTEXT ( " MultipleAssets " , " Multiple Assets " ) ;
2018-05-23 21:04:31 -04:00
}
else
{
2021-01-14 12:45:46 -04:00
OutColor = ObjectPtr - > IsPendingKill ( ) ? FColor : : Red : AssetTypeActions - > GetTypeColor ( ) ;
2021-02-11 19:52:08 -04:00
OutName = AssetTypeActions - > GetDisplayNameFromAssetData ( FAssetData ( ObjectPtr ) ) ;
if ( OutName . IsEmpty ( ) )
{
OutName = AssetTypeActions - > GetName ( ) ;
}
2018-05-23 21:04:31 -04:00
}
2014-04-02 18:09:23 -04:00
return true ;
}
}
2020-08-11 01:36:57 -04:00
// if we do not find any package object, consider the package empty, return a red `Empty Package`
else
{
2021-02-11 19:52:08 -04:00
OutName = LOCTEXT ( " NoAssets " , " Empty Package " ) ;
2020-08-11 01:36:57 -04:00
OutColor = FColor ( // Copied from ContentBrowserCLR.cpp
127 + FColor : : Red . R / 2 , // Desaturate the colors a bit (GB colors were too.. much)
127 + FColor : : Red . G / 2 ,
127 + FColor : : Red . B / 2 ,
200 ) ; // Opacity
return true ;
}
2014-04-02 18:09:23 -04:00
return false ;
}
2014-03-14 14:13:41 -04:00
/**
* Construct this widget
*
* @ param InArgs The declaration data for this widget
*/
void SPackagesDialog : : Construct ( const FArguments & InArgs )
{
2019-06-07 11:22:52 -04:00
bSortDirty = false ;
2014-03-14 14:13:41 -04:00
bReadOnly = InArgs . _ReadOnly . Get ( ) ;
bAllowSourceControlConnection = InArgs . _AllowSourceControlConnection . Get ( ) ;
Message = InArgs . _Message ;
2015-01-12 11:19:17 -05:00
Warning = InArgs . _Warning ;
2015-02-04 05:20:41 -05:00
OnSourceControlStateChanged = InArgs . _OnSourceControlStateChanged ;
2020-08-11 01:36:57 -04:00
SortByColumn = SPackagesDialogDefs : : ColumnID_AssetLabel ;
2014-04-02 18:09:23 -04:00
SortMode = EColumnSortMode : : Ascending ;
2014-03-14 14:13:41 -04:00
ButtonsBox = SNew ( SHorizontalBox ) ;
if ( bAllowSourceControlConnection )
{
ButtonsBox - > AddSlot ( )
. AutoWidth ( )
. Padding ( 2 )
[
SNew ( SButton )
. Text ( LOCTEXT ( " ConnectToSourceControl " , " Connect To Source Control " ) )
. ToolTipText ( LOCTEXT ( " ConnectToSourceControl_Tooltip " , " Connect to source control to allow source control operations to be performed on content and levels. " ) )
. ContentPadding ( FMargin ( 10 , 3 ) )
. HAlign ( HAlign_Right )
2021-01-20 11:53:39 -04:00
. VAlign ( VAlign_Center )
2014-03-14 14:13:41 -04:00
. Visibility ( this , & SPackagesDialog : : GetConnectToSourceControlVisibility )
. OnClicked ( this , & SPackagesDialog : : OnConnectToSourceControlClicked )
] ;
}
2014-04-02 18:09:23 -04:00
TSharedRef < SHeaderRow > HeaderRowWidget = SNew ( SHeaderRow ) ;
if ( ! bReadOnly )
{
HeaderRowWidget - > AddColumn (
SHeaderRow : : Column ( SPackagesDialogDefs : : ColumnID_CheckBoxLabel )
[
2021-01-14 12:45:46 -04:00
SNew ( SBox )
. Padding ( FMargin ( 6 , 3 , 6 , 3 ) )
. HAlign ( HAlign_Center )
[
SAssignNew ( ToggleSelectedCheckBox , SCheckBox )
. IsChecked ( this , & SPackagesDialog : : GetToggleSelectedState )
. OnCheckStateChanged ( this , & SPackagesDialog : : OnToggleSelectedCheckBox )
]
2014-04-02 18:09:23 -04:00
]
. FixedWidth ( SPackagesDialogDefs : : CheckBoxColumnWidth )
) ;
}
HeaderRowWidget - > AddColumn (
SHeaderRow : : Column ( SPackagesDialogDefs : : ColumnID_IconLabel )
[
SNew ( SSpacer )
]
. SortMode ( this , & SPackagesDialog : : GetColumnSortMode , SPackagesDialogDefs : : ColumnID_IconLabel )
. OnSort ( this , & SPackagesDialog : : OnColumnSortModeChanged )
. FixedWidth ( SPackagesDialogDefs : : IconColumnWidth )
2021-01-14 12:45:46 -04:00
) ;
2014-04-02 18:09:23 -04:00
HeaderRowWidget - > AddColumn (
2020-08-11 01:36:57 -04:00
SHeaderRow : : Column ( SPackagesDialogDefs : : ColumnID_AssetLabel )
. DefaultLabel ( LOCTEXT ( " AssetColumnLabel " , " Asset " ) )
. SortMode ( this , & SPackagesDialog : : GetColumnSortMode , SPackagesDialogDefs : : ColumnID_AssetLabel )
. OnSort ( this , & SPackagesDialog : : OnColumnSortModeChanged )
. FillWidth ( 5.0f )
) ;
2021-01-14 12:45:46 -04:00
/*
2020-08-11 01:36:57 -04:00
2020-09-03 08:20:02 -04:00
HeaderRowWidget - > AddColumn (
2021-01-14 12:45:46 -04:00
SHeaderRow : : Column ( SPackagesDialogDefs : : ColumnID_OwnerLabel )
. DefaultLabel ( LOCTEXT ( " OwnerColumnLabel " , " Owner " ) )
. SortMode ( this , & SPackagesDialog : : GetColumnSortMode , SPackagesDialogDefs : : ColumnID_OwnerLabel )
. OnSort ( this , & SPackagesDialog : : OnColumnSortModeChanged )
. FillWidth ( 7.0f )
2020-09-03 08:20:02 -04:00
) ;
2021-01-14 12:45:46 -04:00
*/
2020-09-03 08:20:02 -04:00
2020-08-11 01:36:57 -04:00
HeaderRowWidget - > AddColumn (
SHeaderRow : : Column ( SPackagesDialogDefs : : ColumnID_PackageLabel )
2014-11-26 12:46:05 -05:00
. DefaultLabel ( LOCTEXT ( " FileColumnLabel " , " File " ) )
2020-08-11 01:36:57 -04:00
. SortMode ( this , & SPackagesDialog : : GetColumnSortMode , SPackagesDialogDefs : : ColumnID_PackageLabel )
2014-04-02 18:09:23 -04:00
. OnSort ( this , & SPackagesDialog : : OnColumnSortModeChanged )
. FillWidth ( 7.0f )
) ;
HeaderRowWidget - > AddColumn (
SHeaderRow : : Column ( SPackagesDialogDefs : : ColumnID_TypeLabel )
2014-11-26 12:46:05 -05:00
. DefaultLabel ( LOCTEXT ( " TypeColumnLabel " , " Type " ) )
2014-04-02 18:09:23 -04:00
. SortMode ( this , & SPackagesDialog : : GetColumnSortMode , SPackagesDialogDefs : : ColumnID_TypeLabel )
. OnSort ( this , & SPackagesDialog : : OnColumnSortModeChanged )
. FillWidth ( 2.0f )
) ;
2015-01-12 11:19:17 -05:00
if ( bAllowSourceControlConnection )
{
HeaderRowWidget - > AddColumn (
SHeaderRow : : Column ( SPackagesDialogDefs : : ColumnID_CheckedOutByLabel )
. DefaultLabel ( LOCTEXT ( " CheckedOutByColumnLabel " , " Checked Out By " ) )
. SortMode ( this , & SPackagesDialog : : GetColumnSortMode , SPackagesDialogDefs : : ColumnID_CheckedOutByLabel )
. OnSort ( this , & SPackagesDialog : : OnColumnSortModeChanged )
. FillWidth ( 4.0f )
) ;
}
2014-03-14 14:13:41 -04:00
this - > ChildSlot
[
SNew ( SBorder )
2021-01-14 12:45:46 -04:00
. BorderImage ( FAppStyle : : Get ( ) . GetBrush ( " Brushes.Panel " ) )
. Padding ( FMargin ( 16 ) )
2014-03-14 14:13:41 -04:00
[
SNew ( SVerticalBox )
2021-01-14 12:45:46 -04:00
+ SVerticalBox : : Slot ( )
. AutoHeight ( )
. Padding ( 0.0f , 0.0f , 0.0f , 8.0f )
2014-03-14 14:13:41 -04:00
[
2021-01-14 12:45:46 -04:00
SNew ( STextBlock )
. Text ( this , & SPackagesDialog : : GetMessage )
. AutoWrapText ( true )
2014-03-14 14:13:41 -04:00
]
2021-01-14 12:45:46 -04:00
+ SVerticalBox : : Slot ( )
. FillHeight ( 0.8 )
2014-03-14 14:13:41 -04:00
[
2014-04-02 18:09:23 -04:00
SAssignNew ( ItemListView , SListView < TSharedPtr < FPackageItem > > )
. ListItemsSource ( & Items )
. OnGenerateRow ( this , & SPackagesDialog : : MakePackageListItemWidget )
. OnContextMenuOpening ( this , & SPackagesDialog : : MakePackageListContextMenu )
. ItemHeight ( 20 )
. HeaderRow ( HeaderRowWidget )
. SelectionMode ( ESelectionMode : : None )
2014-03-14 14:13:41 -04:00
]
2021-01-14 12:45:46 -04:00
+ SVerticalBox : : Slot ( )
. Padding ( 0 , 16.0f , 0 , 0 )
. AutoHeight ( )
[
SNew ( SWarningOrErrorBox )
. Visibility ( this , & SPackagesDialog : : GetWarningVisibility )
. Message ( this , & SPackagesDialog : : GetWarning )
]
+ SVerticalBox : : Slot ( )
. AutoHeight ( )
. Padding ( 0.0f , 16.0f , 0.0f , 0.0f )
. HAlign ( HAlign_Right )
. VAlign ( VAlign_Bottom )
2014-03-14 14:13:41 -04:00
[
ButtonsBox . ToSharedRef ( )
]
]
] ;
}
2015-02-04 05:20:41 -05:00
/**
* Removes all checkbox items from the dialog
*/
void SPackagesDialog : : RemoveAll ( )
{
Items . Reset ( ) ;
}
2014-03-14 14:13:41 -04:00
/**
* Adds a new checkbox item to the dialog
*
* @ param Item The item to be added
*/
void SPackagesDialog : : Add ( TSharedPtr < FPackageItem > Item )
{
FSimpleDelegate RefreshCallback = FSimpleDelegate : : CreateSP ( this , & SPackagesDialog : : RefreshButtons ) ;
Item - > SetRefreshCallback ( RefreshCallback ) ;
Items . Add ( Item ) ;
2014-04-02 18:09:23 -04:00
RequestSort ( ) ;
2014-03-14 14:13:41 -04:00
}
/**
* Adds a new button to the dialog
*
* @ param Button The button to be added
*/
void SPackagesDialog : : AddButton ( TSharedPtr < FPackageButton > Button )
{
Buttons . Add ( Button ) ;
ButtonsBox - > AddSlot ( )
. AutoWidth ( )
2021-01-14 12:45:46 -04:00
. Padding ( 5 , 0 )
2014-03-14 14:13:41 -04:00
[
SNew ( SButton )
2021-01-14 12:45:46 -04:00
. ButtonStyle ( & FAppStyle : : Get ( ) , ( Button - > GetType ( ) = = DRT_Save | | Button - > GetType ( ) = = DRT_CheckOut ) ? " PrimaryButton " : " Button " )
2020-07-30 19:42:24 -04:00
. TextStyle ( & FAppStyle : : Get ( ) , " DialogButtonText " )
2014-03-14 14:13:41 -04:00
. Text ( Button - > GetName ( ) )
. ToolTipText ( Button - > GetToolTip ( ) )
2021-01-14 12:45:46 -04:00
. IsEnabled ( Button . Get ( ) , & FPackageButton : : IsEnabled )
2014-03-14 14:13:41 -04:00
. HAlign ( HAlign_Right )
2021-01-20 11:53:39 -04:00
. VAlign ( VAlign_Center )
2014-03-14 14:13:41 -04:00
. OnClicked ( Button . Get ( ) , & FPackageButton : : OnButtonClicked )
] ;
}
/**
* Sets the message of the widget
*
* @ param InMessage The string that the message should be set to
*/
void SPackagesDialog : : SetMessage ( const FText & InMessage )
{
Message = InMessage ;
}
2015-01-12 11:19:17 -05:00
/**
* Sets the warning message of the widget
*
* @ param InMessage The string that the warning message should be set to
*/
void SPackagesDialog : : SetWarning ( const FText & InWarning )
{
Warning = InWarning ;
}
2014-03-14 14:13:41 -04:00
/**
* Gets the return type of the dialog and it populates the package array results
*
* @ param OutCheckedPackages Will be populated with the checked packages
* @ param OutUncheckedPackages Will be populated with the unchecked packages
* @ param OutUndeterminedPackages Will be populated with the undetermined packages
*
* @ return returns the button that was pressed to remove the dialog
*/
EDialogReturnType SPackagesDialog : : GetReturnType ( OUT TArray < UPackage * > & OutCheckedPackages , OUT TArray < UPackage * > & OutUncheckedPackages , OUT TArray < UPackage * > & OutUndeterminedPackages )
{
/** Set the return type to which button was pressed */
EDialogReturnType ReturnType = DRT_None ;
for ( int32 ButtonIndex = 0 ; ButtonIndex < Buttons . Num ( ) ; + + ButtonIndex )
{
FPackageButton & Button = * Buttons [ ButtonIndex ] ;
if ( Button . IsClicked ( ) )
{
ReturnType = Button . GetType ( ) ;
break ;
}
}
/** Populate the results */
if ( ReturnType ! = DRT_Cancel & & ReturnType ! = DRT_None )
{
for ( int32 ItemIndex = 0 ; ItemIndex < Items . Num ( ) ; + + ItemIndex )
{
FPackageItem & item = * Items [ ItemIndex ] ;
2014-12-10 14:24:09 -05:00
if ( item . GetState ( ) = = ECheckBoxState : : Checked )
2014-03-14 14:13:41 -04:00
{
OutCheckedPackages . Add ( item . GetPackage ( ) ) ;
}
2014-12-10 14:24:09 -05:00
else if ( item . GetState ( ) = = ECheckBoxState : : Unchecked )
2014-03-14 14:13:41 -04:00
{
OutUncheckedPackages . Add ( item . GetPackage ( ) ) ;
}
else
{
OutUndeterminedPackages . Add ( item . GetPackage ( ) ) ;
}
}
}
return ReturnType ;
}
/**
* Gets the widget which is to have keyboard focus on activating the dialog
*
* @ return returns the widget
*/
TSharedPtr < SWidget > SPackagesDialog : : GetWidgetToFocusOnActivate ( ) const
{
Copying //UE4/Dev-Editor to //UE4/Dev-Main (Source: //UE4/Dev-Editor @ 3133954)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3077573 on 2016/08/04 by Nick.Darnell
Removing some unused code, adding additional needed modules to editor tests.
#rb none
Change 3077580 on 2016/08/04 by Nick.Darnell
Removing the test plugins, going to be recreating them in EngineTest.
Change 3082659 on 2016/08/09 by Nick.Darnell
Automation - Presets are now stored in json files stored in Config so they can be shared, and human readable. Working on screenshot automation, getting it where it needs to be to permit us to have repeatable tests for comarison. Removing the option to not take full size screenshots, that defeats the purpose of being able to compare them.
#rb none
Change 3082766 on 2016/08/09 by Jamie.Dale
Fixed crashes when dealing with code-points outside the BMP on platforms with UTF-32 FStrings
ICU always deals with its offsets as UTF-16 (as it always uses UTF-16 internally with icu::UnicodeString), so there were a couple of places in code (break iteration, and bidi detection) where we needed to adjust those UTF-16 offsets to UTF-32 offsets in the case where FString is UTF-32.
#jira UE-33971
#rb James.Hopkin
Change 3083067 on 2016/08/09 by Nick.Darnell
Automation - Working on screenshot support, system now allows a lot more customization in terms of how large the shot is.
#rb none
Change 3084475 on 2016/08/10 by Richard.TalbotWatkin
Fixed issue with ModelComponent replication in client/server PIE if BSP is rebuilt. ModelComponent now implements IsNameStableForNetworking and always returns true, as a level's model components will never be rebuilt during a game session. Brush poly normals are now only fixed up in Editor builds.
#jira UE-34391 - No run animation on client that is not focused when running 2 player and dedicated server
#codereview Matt.Kuhlenschmidt
#rb none
Change 3084661 on 2016/08/10 by Matt.Kuhlenschmidt
Added grayscale texture importing support
#rb none
Change 3084774 on 2016/08/10 by Cody.Albert
Adding controller support for ComboBox widget
#jira UE-33826
#rb nick.darnell
Change 3085716 on 2016/08/11 by Nick.Darnell
UMG - Taking the Widget Component and Widget Interaction Components out of experimental. Removed old importing support for upgrading ancient versions of widget components. Removing parbola distortion, as users can now do whatever they want in their custom MID they can override the widget with.
#rb none
Change 3085733 on 2016/08/11 by Nick.Darnell
UMG - Documenting the meta parameters allowed on widgets, like we do for regular UObjects. For binding widgets from blueprints you can now do BindWidget (unchanged), and to simplify binding widgets optionally, you can now just do (BindWidgetOptional), rather than the combination of BindWidget + OptionalWidget=true. Made generating the Design time wrapper call a little more efficent, by optimizing it away by force inlining a noop. Also added some additional checking when we forcefully set focus in UMG, to help people catch cases where they set focus, but didn't make the widget focusable.
#rb none
Change 3085734 on 2016/08/11 by Nick.Darnell
Texture - Making GetDefaultMipMapBias a bit more efficent in the common case.
#rb none
Change 3085736 on 2016/08/11 by Nick.Darnell
Static Lighting - Warning the user when they build lighting, but have bForceNoPrecomputedLighting set to true on the world settings.
#rb none
Change 3085737 on 2016/08/11 by Nick.Darnell
Editor - code organization.
#rb none
Change 3085875 on 2016/08/11 by Nick.Darnell
UMG - You can now use 'G' to toggle game mode on the designer so that you can disable and enable the dashed lines around containers. The option in the settings is now used as the default when you startup a designer.
#rb none
Change 3086209 on 2016/08/11 by Ben.Salem
Make our automated test pass reporting more robust and pipe out to JSON in \saved\automation\logs\AutomationReport-{CL}-{Timestamp}.json format.
#rb adric.worley, william.ewen
Change 3086515 on 2016/08/11 by Nick.Darnell
Editor - Fixing a crash in the curve table customization. If the row doesn't exist, it would crash, we now protect against that case.
#rb Matt.Kuhlenschmidt
Change 3087216 on 2016/08/12 by Jamie.Dale
Fixed an issue where re-scanning a package file may leave old assets in the asset registry
We didn't used to clear out anything associated with the old package before scanning the file, which could result in old assets being left if they'd since been removed from the package.
This also exposes a PackageDeleted function to allow people to manually clear anything associated with a package (if doing some custom asset work).
#rb Andrew.Rodham
Change 3087219 on 2016/08/12 by Jamie.Dale
Updated TextRenderComponent to support multiple font pages
It used to use the correct UV data, but wouldn't set the correct texture page when rendering. It now creates MIDs for all of the texture pages used by the font, and will use these MIDs (which override the font page on the material) when rendering the text (batched on sequential index/vertex buffer data with the same texture page).
#rb Matt.Kuhlenschmidt
Change 3087308 on 2016/08/12 by Alex.Delesky
#jira UE-14727 - Support for editing TSet properties in the editor's Details panel has been added.
#rb Matt.Kuhlenschmidt
Change 3089140 on 2016/08/15 by Jamie.Dale
We now abort a directory watch if we lose access to the directory in question
This prevents an infinite loop in the call to MsgWaitForMultipleObjectsEx if a watched directory is deleted.
#jira UE-30172
#rb Andrew.Rodham
Change 3089148 on 2016/08/15 by Alexis.Matte
Allow fbx export of any actor type.
#rb none
#codereview dmitriy.dyomin
Change 3089211 on 2016/08/15 by Jamie.Dale
Unified access to the parent window for external dialogs
A lot of places used to ad-hoc use the MainFrame window, even when they had access to a widget that may be belong to a different window. This could cause issues where an external dialog could appear behind a modal UE4 window (as it would appear above the MainFrame), and be inaccessible.
You can now use IMainFrameModule::GetBestParentWindowHandleForDialogs to get the best window handle to use for an external dialog. This will either be the parent window for the given widget (if known), or failing that, the MainFrame window.
#rb Andrew.Rodham
Change 3089640 on 2016/08/15 by Jamie.Dale
Wrapped UMaterialExpression::MenuCategories in WITH_EDITORONLY_DATA to avoid gathering it for game-only loc
#rb none
Change 3089661 on 2016/08/15 by Nick.Darnell
Editor - There's a new view option "Show C++ Classes" in the content browser. Lets you hide all those C++ folders most folks probably don't care to see.
#rb none
Change 3089667 on 2016/08/15 by Cody.Albert
Updating RoutePointerUpEvent to call OnDrop for touch events when dragging
#jira UE-34709
#rb nick.darnell
Change 3089694 on 2016/08/15 by Jamie.Dale
Applied a fix to the ExcludeClasses setting in the loc gather
#rb none
Change 3089889 on 2016/08/15 by Nick.Darnell
Automation - Continued work on the screenshot portion of the automation system. Going to start using the adapter information in the screenshots taken, otherwise we can't accurately test a plethora of devices sharing the same OS, with different capabilities.
#rb none
Change 3090256 on 2016/08/16 by Nick.Darnell
Automation - working on screenshots.
#rb none
Change 3090322 on 2016/08/16 by Nick.Darnell
Automation - Adding modified screenshot function.
#rb none
Change 3090335 on 2016/08/16 by Nick.Darnell
Automation - The tests were determined to need to be shared afterall, but at least keeping them as plugins. Moved to Engine plugins.
#rb none
Change 3090881 on 2016/08/16 by Nick.Darnell
Automation - Moving the content over and fixing up some code so that the AutoRimport tests work as expected.
#rb none
Change 3090884 on 2016/08/16 by Nick.Darnell
Plugins - There's now support for generating a Content Only plugin from the new plugin wizard.
#rb none
Change 3090911 on 2016/08/16 by Nick.Darnell
Feature Packs - If there's an error loading a manifest, it's now an error, not a warning.
#rb none
Change 3090913 on 2016/08/16 by Jamie.Dale
Optimization and usability improvements of the MemoryProfiler2 tool
- Optimized the processing of the Callgraph, Histogram, and Short lived allocations views.
- The callgraph view is now using a virtualized tree view mapped to our own internal tree. This allows us to amortize the cost of adding nodes to the TreeView as the user views the nodes in the tree. In my own test, this took callgraph generation from ~45 seconds to ~5 seconds.
- The Histogram view was vastly optimized via the use of a HashSet on the callstack filter, and the batch addition of unsorted callstacks that are sorted once at the end. In my own test, this took histogram generation from ~15 minutes to ~2 seconds.
- The Short lived allocations view was optimized by avoiding redundant sorting, including maintaining a sorted order while inserting items, and instead doing a final sort at the end. The column selection was also optimized by avoiding copying the entire dataset just to resort it. In my own test, this took short lived allocation generation from ~1 minute to ~3 seconds.
- Added a user-configurable list of allocator functions to trim (which now includes FMemory and operator new by default, and produces much cleaner callstacks).
#jira UETOOL-948
#jira UETOOL-949
#rb James.Hopkin
Change 3090962 on 2016/08/16 by Jamie.Dale
Fixed double assignment of filter functions
#rb none
Change 3090989 on 2016/08/16 by Nick.Darnell
Editor - Attempting to fix the build, non-unity issue I suspect.
#rb none
Change 3091754 on 2016/08/17 by Nick.Darnell
FbxAutomationTestBuilder is now a plugin. Users won't see it unless they've enabled the plugin (so primarily internal QA). Reorganized the automation tools and testing menu to be a bit lower in the main menu, and gave them a more test sounding name. Additionally made some modifications to the workspace menu structure to allow generating just a subset of a workplace menu so that I could target where I wanted to insert all of the automation tool menu items, rather than just allowing the general placement of them under developer tools...etc.
#rb none
#codereview Alexis.Matte
Change 3091758 on 2016/08/17 by Nick.Darnell
Slate / Editor - Trying to make the editor less focus greedy. Now when there are notification popups and tabs attempt to grab your attention we now do a few activation ownership checks to ensure that it or a parent window actually owns activation. Not doing this has the nasty side effect of things like notifications and message log errors that popup while playing the game (if the game is in new window PIE), causing the game to be hidden, and focus returned to the editor. Ran into this a lot running the automation tests, the new PIE window that's launched to run tests is immediately hidden as soon as the tests log a warning or error or a notification about high res screenshots happens.
#rb none
#codereview Nick.Atamas,Matt.Kuhlenschmidt
Change 3091829 on 2016/08/17 by Nick.Darnell
Build - Attempting to repair the build.
#rb none
Change 3091920 on 2016/08/17 by Nick.Darnell
Build - Another attempt at fixing the mac build.
#rb none
Change 3093380 on 2016/08/18 by Matt.Kuhlenschmidt
Ignore group actors when checking for references to other actors when deleting. The check for references is designed for gameplay affecting references which groups are not. Having this show up for groups is annoying
#rb none
Change 3094474 on 2016/08/19 by Jamie.Dale
Fixed PS4 error when building with USE_MALLOC_PROFILER, and optimized symbol name resolution for a build with USE_MALLOC_PROFILER enabled
#jira UETOOL-951
#rb James.Hopkin
Change 3094581 on 2016/08/19 by Jamie.Dale
Added missing allocator filter needed by PS4 profiles
#rb none
Change 3094681 on 2016/08/19 by Richard.TalbotWatkin
Fixed issue where painting override vertex colors on a SpeedTree mesh would cause its wind animation to cease. The OverrideVertexColors vertex factory needed to be registered with the SpeedTree renderer.
#jira UE-32762 - Custom VertexPaint on SpeedTrees interferes with wind animation
#rb none
Change 3095163 on 2016/08/19 by Trung.Le
#jira UE-20849: Added tooltips to the inputs of the Material final result node
#rb matt.kuhlenschmidt
Change 3095285 on 2016/08/19 by Trung.Le
#jira UE-20849 In SGraphNodeMaterialResult, renamed ToolTip to ToolTipWidget so we're not hiding class member
#rb none
Change 3095344 on 2016/08/19 by Alexis.Matte
#jira UE-34690 When using the optionnal matrix to change the scene root node, we have to flush the fbx evaluation engine.
Add also a new option to allow the user to automatically convert the fbx scene to unreal unit (centimeter).
#rb none
#codereview matt.kuhlenschmidt
Change 3096162 on 2016/08/22 by Alexis.Matte
#jira UE-34763 Remove offending no-action combo box entry when the json file is readonly. Also clean up other combo box menu.
#rb none
#codereview matt.kuhlenschmidt
Change 3096261 on 2016/08/22 by Alexis.Matte
#jira UE-33121 Make sure re-import all and import all fix all the issue before starting the job. So it get not interrupt during the process.
#rb lina.halper
#codereview lina.halper
Change 3096344 on 2016/08/22 by Jamie.Dale
NSString conversion fix for UTF-32 strings containing characters outside of the BMP
#jira UE-33971
#rb Peter.Sauerbrei, James.Hopkin
Change 3096605 on 2016/08/22 by Alex.Delesky
#jira UE-34787 - Dropdown menus in standalone programs will now correctly display tooltips if they have any.
#rb Matt.Kuhlenschmidt
Change 3096615 on 2016/08/22 by Alex.Delesky
#jira UE-33334 - Scrolling up on the mouse wheel when using the orbit camera should no longer move away from the orbit point when the camera moves too close to the orbit origin.
#rb Matt.Kuhlenschmidt
Change 3096619 on 2016/08/22 by Alex.Delesky
#jira UE-34084 - Structs containing an enum with a value that contains a whitespace character will now serialize correctly when copied from the Details Panel.
#rb Matt.Kuhlenschmidt
Change 3097644 on 2016/08/23 by Matt.Kuhlenschmidt
PR #2729: Fix a typo in the comment (Contributed by adcentury)
#rb none
Change 3097648 on 2016/08/23 by Matt.Kuhlenschmidt
PR #2726: Undef unused macros (Contributed by shrimpy56)
#rb none
Change 3097697 on 2016/08/23 by Matt.Kuhlenschmidt
Guard against crash when details panels rebuild when their customizations have been torn down
https://jira.ol.epicgames.net/browse/UE-35048
#rb none
Change 3097757 on 2016/08/23 by Alex.Delesky
#jira UE-14727 - Support for editing TMap properties in the editor's Details panel has been added. This change also removes the Duplicate option from TSet elements, and disallows entry of duplicates elements into a TSet or duplicate keys into a TMap
#rb Matt.Kuhlenschmidt
Change 3098164 on 2016/08/23 by Alexis.Matte
#jira UE-34686 Fbx importer bImportMeshesInBoneHierarchy is used also by the animation.
#rb none
#codereview matt.kuhlenschmidt
Change 3098502 on 2016/08/23 by Alexis.Matte
#jira UE-30951 Fbx option dialog, we disable the option to bake pivot if transform vertex position is true
#rb none
#codereview matt.kuhlenschmidt
Change 3099986 on 2016/08/24 by Jamie.Dale
Fixing non-editor builds
#rb none
Change 3101138 on 2016/08/25 by Matt.Kuhlenschmidt
Fixed viewport redraw callback not being called when certian property modifications occur in the details panel (reset to default, array size changes, etc)
#rb none
Change 3101280 on 2016/08/25 by Jamie.Dale
Fixed crash when counting memory over internationalization meta-data
- The serialization code only used to handle loading or saving, now it handles loading or not loading.
- The Type of the meta-data wasn't set by all constructors. For safety it has been removed and replaced with a virtual function that the derived types override.
#rb James.Hopkin
Change 3101283 on 2016/08/25 by Jamie.Dale
MProf2 platform and symbol parsing improvements
- Updated ISymbolParser to work with lazy symbol resolution (handled via the UI when looking at full callstacks).
- Added a PS4 symbol parser which handles performing full file/line resolution for symbols.
- Removed all the V3 file format support and legacy platform handling.
- Optimized FStreamInfo.GetNameIndex so it can be used by the lazy symbol fixup.
#rb James.Hopkin
Change 3101586 on 2016/08/25 by Jamie.Dale
Small code cleanup and path normalization
#rb James.Hopkin
Change 3101837 on 2016/08/25 by Alexis.Matte
#jira UE-35101 we now store the sourceanimationname to retrieve the correct animtrack when re-importing animations
#rb none
#codereview matt.kuhlenschmidt
Change 3102537 on 2016/08/26 by Jamie.Dale
Fix for potential crash in FICUCamelCaseBreakIterator
In platforms with UTF-32 strings, the index returned by FICUTextCharacterIterator may not be in the same range as FString, so we need to call InternalIndexToSourceIndex to ensure that it is.
#rb James.Hopkin
Change 3102582 on 2016/08/26 by Matt.Kuhlenschmidt
Log the freetype version when it starts up (for debugging purposes)
#rb none
Change 3102657 on 2016/08/26 by Alexis.Matte
#jira UE-29177 When re-importing a texture we want to notify materials using this texture so they can recompile the shader.
#review-3101585 @uriel.doyon
#rb matt.kuhlenschmidt
Change 3102704 on 2016/08/26 by Jamie.Dale
Added symbol meta-data support to MProf2
You can now define platform specific meta-data using FPlatformStackWalk::GetSymbolMetaData, which is then stored within the generated .mprof file.
PS4 uses this meta-data to say where the original .self file can be found, so that MProf2 can usually automatically load the .self file without having to bother the user.
#rb James.Hopkin
Change 3102878 on 2016/08/26 by Matt.Kuhlenschmidt
Added support for outline fonts
- An outline size (in slate units), optional material and optional fill color can be specified with each font info.
- Outlines do not contribute to measurement directly so the text measuring and shaping methods have been modified to account for outlines
- Fixed a bug where font materials do not work properly if part of the font's rendered glyphs were in a different atlas
#rb jamie.dale
Change 3102879 on 2016/08/26 by Jamie.Dale
Bumped the MProf2 version so we can tell which build of the tool can load v6 mprof files
#rb none
Change 3102960 on 2016/08/26 by Alexis.Matte
build fix
#rb none
Change 3103032 on 2016/08/26 by Jamie.Dale
Fixed SEditableText and SMultiLineEditableText not setting the correct foreground color when painting
#jira UE-34936
#rb Matt.Kuhlenschmidt
Change 3103278 on 2016/08/26 by Jamie.Dale
Fixing Clang warnings
#rb none
Change 3104211 on 2016/08/29 by Ben.Marsh
Add build script for automated tests, and create settings file for Dev-Editor which adds an agent pool for running them.
#rb none
Change 3104290 on 2016/08/29 by Alex.Delesky
Adding additional documentation accessible from the editor for TSet and TMap properties, along with a quick clarification on container properties to let the user know what kind of container they're working with.
#rb Matt.Kuhlenschmidt
Change 3104292 on 2016/08/29 by Alex.Delesky
#jira UE-35039 - Command/Control user keybindings will no longer flip-flop when the editor is opened on Mac.
#rb Matt.Kuhlenschmidt
Change 3104294 on 2016/08/29 by Alex.Delesky
#jira UE-34952 - The user will no longer encounter an ensure when setting the value of Period equal to or less than 0 on the circular throbber widget
#rb Matt.Kuhlenschmidt
Change 3104295 on 2016/08/29 by Matt.Kuhlenschmidt
PR #2682: Remove unused bUseDesktopResolutionForFullscreen (Contributed by stfx)
#rb none
Change 3104296 on 2016/08/29 by Alex.Delesky
#jira UE-35160 - The Auto Distance Error for LOD meshes can now be set to any value larger than zero.
#rb Matt.Kuhlenschmidt
Change 3104348 on 2016/08/29 by Matt.Kuhlenschmidt
Added the ability to clear the preview mesh on a material instance. Previously there was no way to null it out.
#rb none
Change 3104355 on 2016/08/29 by Matt.Kuhlenschmidt
Guard against crash with invalid path to the default physical material. Just create a new one if it doesnt exist and warn about it.
#rb none
#jira UE-31865
Change 3104396 on 2016/08/29 by Ben.Marsh
Fix incrorrect agent names for running automated tests
Change 3104610 on 2016/08/29 by Alex.Delesky
Fix for AutomationTool compile editor from changes introduced today.
#rb None
Change 3104611 on 2016/08/29 by Michael.Dupuis
#jira UETOOL-253
#rb Alexis.Matte
Change 3105826 on 2016/08/30 by Gareth.Martin
Added console variables to discard grass and/or scalable foliage data on load
#jira UE-35086
#rb Benn
Change 3106126 on 2016/08/30 by Matt.Kuhlenschmidt
Eliminated bad code duplication between retainer widgets and element batcher
#rb none
#codereview nick.darnell
Change 3106449 on 2016/08/30 by Michael.Dupuis
#jira UETOOL-229 Added generic command icons used in Edit Menu (including contextual menu)
#rb Alexis.Matte
Change 3106966 on 2016/08/30 by Jamie.Dale
Fixed FApp::IsAuthorizedUser not considering the SessionOwner override
#rb Max.Preussner
Change 3107687 on 2016/08/31 by Michael.Dupuis
Checkout/Make Writable on proper config file
#rb Matt Kuhlenschmidt
Change 3107736 on 2016/08/31 by Matt.Kuhlenschmidt
Fixed mode typos in the lerp instruction
#rb none
Change 3107830 on 2016/08/31 by Matt.Kuhlenschmidt
Logging and guard against UEditorEngine::TeardownPlaySession crash.
#rb none
https://jira.ol.epicgames.net/browse/UE-35325
Change 3107912 on 2016/08/31 by Alex.Delesky
#jira UE-35181 - Normalizing paths when retrieving absolute filenames for source control operations.
#rb Matt.Kuhlenschmidt
Change 3107986 on 2016/08/31 by Matt.Kuhlenschmidt
Removed PropertyTestObject.h out of UnrealEd.h so you dont have to compile the entire editor when changing this one file.
#rb none
Change 3108027 on 2016/08/31 by Chris.Wood
Re-added lost doc comment for analytics event "Engine.AbnormalShutdown".
#rb none - just a comment in a cpp file
#codereview wes.hunt
Change 3108580 on 2016/08/31 by Mike.Fricker
Deleted the "Live Editor" plugins from UE4
- These were undocumented, buggy and never finished, and we have no plans to complete them
- Both the "LiveEditor" and "LiveEditorListenServer" plugins were deleted, along with related icon files
#codereview matt.kuhlenschmidt
#rb matt.kuhlenschmidt
Change 3108604 on 2016/08/31 by Mike.Fricker
Added new "MIDI Device" plugin (disabled by default)
- This is a simple MIDI interface that allows you to receive MIDI events from devices connected to your computer
- Currently only input is supported. In the future we might allow for output, as well.
- In Blueprints, here's how to use it:
- Look for "MIDI Device Manager" in the Blueprint RMB menu
- Call "Find MIDI Devices" to choose your favorite device. Break the "Found MIDI Device" struct to see what's available.
- Then call "Create MIDI Device Controller" for the device you want. Store that in a variable.
- On your MIDI Device Controller, bind your own Event to the "On MIDI Event" event. This will be called every game Tick when there is at least one new MIDI event to receive.
- Process the data passed into the Event to make your project do stuff!
- This plugin makes use of the "PortMidi" third party library (which already existed in UE4 -- it was used by the now-deprecated 'LiveEditor' plugin)
#codereview matt.kuhlenschmidt
#rb none
Change 3108760 on 2016/08/31 by Alexis.Matte
#jira UE-25840 Fbx export collision mesh, we now export collision: box, sphere, capsule and convex mesh. There is an option in the editor preference to enable the export of collisions, default value is false.
#rb none
#codereview matt.kuhlenschmidt
Change 3109006 on 2016/08/31 by Alex.Delesky
#ignore Source Control rename test - initial commit
Change 3109044 on 2016/08/31 by Alex.Delesky
#ignore Testing asset rename from P4 to observe correct behavior.
#rb none
Change 3109048 on 2016/08/31 by Alex.Delesky
#ignore Testing P4 rename to identify correct behavior
#rb none
Change 3110044 on 2016/09/01 by Gareth.Martin
Fixed painting foliage on blocking "query" actors not working
#jira UE-33852
#rb Allan.Bentham
Change 3110133 on 2016/09/01 by Alexis.Matte
Fix crash in function GetForceRecompileTextureIdsHash
#rb none
#codereview jamie.dale
Change 3111848 on 2016/09/02 by Mike.Fricker
MIDI Device plugin: Fixed compilation error on Clang compilers (Mac, Linux)
- Fixed bad enum cast
#rb none
Change 3111995 on 2016/09/02 by Michael.Dupuis
#jira UE-35263
Do not try selecting the actor if the actor is in the blueprint
Properly Refresh the ToopTip & Hyper Link to take into account blueprint recreation process
#rb Alexis Matte
Change 3112280 on 2016/09/02 by Michael.Dupuis
Call MakeWritable if source control fail
#rb Alexis Matte
Change 3112335 on 2016/09/02 by Cody.Albert
Updating cursor hiding logic to not improperly hide cursor when left clicking in ortho mode
#jira UE-35306
#rb none
Change 3112478 on 2016/09/02 by Alexis.Matte
#jira UE-20059 Use a base material to import fbx material.
#rb uriel.doyon
#codereview matt.kuhlenschmidt
#1468 Github pull request number
Change 3113912 on 2016/09/06 by Michael.Dupuis
#jira UE-32288 Fixed Console params display
#rb Alexis Matte
Change 3114026 on 2016/09/06 by Alex.Delesky
#jira UE-35123 - The Details panel in a Texture editor or Simple Asset editor window will no longer disappear when the inspected asset is imported again.
#rb Matt.Kuhlenschmidt
Change 3114032 on 2016/09/06 by Alex.Delesky
PR #2733: Improved the project launcher progress page (Contributed by projectgheist)
#jira UE-34027
#rb Matt.Kuhlenschmidt
Change 3114034 on 2016/09/06 by Alex.Delesky
#jira UE-35265 - Copying a comment node from a Material Function and pasting it inside a Material will no longer render the Material unsaveable
#rb Matt.Kuhlenschmidt
Change 3114071 on 2016/09/06 by Nick.Darnell
[AUTOMATED TEST] Automatic checkin, testing functionality.
Change 3114109 on 2016/09/06 by Nick.Darnell
[AUTOMATED TEST] Automatic checkin, testing functionality.
Change 3114562 on 2016/09/06 by Nick.Darnell
Adding LevelEditor to the FbxAutomationTestBuilder to fix a compiler issue.
#rb none
Change 3114701 on 2016/09/06 by Michael.Dupuis
#jira UE-31988 add const to all usage of TArray<ItemType>* as it was done in SListView
#rb Alexis Matte
Change 3114861 on 2016/09/06 by Matt.Kuhlenschmidt
Prevent non-thread safe slate code from running on the slate loading thread
#rb none
Change 3115698 on 2016/09/07 by Nick.Darnell
Make sure the commands are available - during functional testing that was found to not always be the case.
#rb none
Change 3115719 on 2016/09/07 by Nick.Darnell
Adding an IsRegistered command to commands.
#rb none
Change 3115721 on 2016/09/07 by Nick.Darnell
Adding a new built VirtualReality feature pack, this new one contains the update manifest that will parse correctly.
#rb none
Change 3115722 on 2016/09/07 by Nick.Darnell
IsBindWidgetProperty now returns false if the property passed in is null.
#rb none
Change 3115734 on 2016/09/07 by Alexis.Matte
#jira UE-30166 Support fbx sdk 2017
#rb none
Change 3115737 on 2016/09/07 by Nick.Darnell
Adding an image comparer for screenshots. Removing some content from EngineTest.
#rb none
Change 3115743 on 2016/09/07 by Nick.Darnell
Checkpointing a bunch of progress towards a screenshot comparison workflow that allows us to diff screenshots taken on various platforms and hardware. Disabling many tests that are not passing. Updating a few tests to log better errors, and fixed a few tests with easy bugs in them so they would start passing again. All editor tests currently passing!
#rb none
Change 3115748 on 2016/09/07 by Nick.Darnell
Making the RuntimeTests plugin a Developer module, so that it doesn't get included in shipping builds.
#rb none
Change 3115789 on 2016/09/07 by Jamie.Dale
We now favor Traditional Chinese for Hong Kong and Macau
#rb James.Hopkin
Change 3115799 on 2016/09/07 by Jamie.Dale
Removed validity check on source cultures when remapping, as platforms may use invalid cultures that need to be remapped
#rb James.Hopkin
Change 3115826 on 2016/09/07 by Nick.Darnell
Adding missing files.
#rb none
Change 3115838 on 2016/09/07 by Nick.Darnell
Back out revision 6 from //UE4/Dev-Editor/Engine/Source/Runtime/UMG/Public/Components/WidgetInteractionComponent.h
#rb none
Change 3116007 on 2016/09/07 by Alexis.Matte
build fix
#rb none
Change 3116057 on 2016/09/07 by Jamie.Dale
Fixed widget snapshot messages so they appear in the message debugger
#rb none
Change 3116112 on 2016/09/07 by Nick.Darnell
Removing the FbxAutomationBuilder file that go recreated on a merge from main.
#rb none
Change 3116365 on 2016/09/07 by Michael.Dupuis
#jira UE-20765 Added missing class flag to test (CLASS_CONFIG) and change a bit how the checkout/make writable work.
#codereview Matt.Kuhlenschmidt
#rb Alexis.Matte
Change 3116622 on 2016/09/07 by Alexis.Matte
#jira UE-35608 Use the same naming convention when trying to retrieve uv channel by name.
#rb matt.kuhlenschmidt
Change 3116638 on 2016/09/07 by Jamie.Dale
Ensured that manifests and archives don't try and load data that they can't parse
#rb none
Change 3117397 on 2016/09/08 by Gareth.Martin
Added rotate and blend support to the landscape mirror tool
#jira UE-34829
#rb Jack.Porter
Change 3117459 on 2016/09/08 by Gareth.Martin
Fixed crash saving a hidden landscape level with an offset (cloned from 4.13.1)
#jira UE-35301
#rb Jack.Porter
Change 3117462 on 2016/09/08 by Gareth.Martin
Fixed invisible landscape components and crashes when tessellation is enabled (cloned from 4.13.1)
#jira UE-35494
#rb Benn.Gallagher
Change 3117583 on 2016/09/08 by Nick.Darnell
Continued work on automation support for screenshot comparison, stubbing in a commandlet that can be run after automation tests that would perform the diffing. Need to finish rigging it up so that deltas and results can be dumped out somewhere and consumed by a tool to approve shots.
#rb none
Change 3117595 on 2016/09/08 by Nick.Darnell
Updating the build script for AutomatedTests, going to see if this works!
#rb none
Change 3117808 on 2016/09/08 by Nick.Darnell
Adding header includes for async.
#rb none
Change 3117812 on 2016/09/08 by Matt.Kuhlenschmidt
Partially taken from Pr 2381
Fixed Array Properties to handle duplicates properly and fixed Material Parameter Collection duplicate Guid problem.
#rb none
Change 3117851 on 2016/09/08 by Jamie.Dale
Silenced some redundant P4 errors that could be generated when running a stat update on a file
Some of the options produced errors when working with newly added files. These errors are now downgraded to infos like they are for the main stat command.
#rb Ben.Marsh
#codereview Thomas.Sarkanen
Change 3117853 on 2016/09/08 by Gareth.Martin
Clean up landscape includes and PCH
#rb steve.robb
Change 3117859 on 2016/09/08 by Alex.Delesky
#jira UE-35321 - Minimized windows will no longer act like they are visible when determining what widgets are currently underneath the mouse.
#rb Nick.Darnell
Change 3117997 on 2016/09/08 by Nick.Darnell
Updating the automation tests build script to use Editor-Cmd
#rb none
Change 3118005 on 2016/09/08 by Matt.Kuhlenschmidt
Properly reference graph node on material expressions so they are not GC'd while an expression still uses them
#jira UE-35362
#rb none
Change 3118043 on 2016/09/08 by Alex.Delesky
#jira UE-30649 - Removed unnecessary returns from UWidget API.
PR #2377: fix widget bug. (Contributed by dorgonman)
#rb none
Change 3118045 on 2016/09/08 by Matt.Kuhlenschmidt
Guard against crash saving config during level editor shutdown
#rb none
#jira UE-35605
Change 3118074 on 2016/09/08 by Matt.Kuhlenschmidt
PR #2783: Removed #pragme once from CPP files (Contributed by projectgheist)
#rb none
Change 3118078 on 2016/09/08 by Michael.Dupuis
#jira UE-32065 Removed the -windows that was added as a default option and add it simply if fullscreen is not specified
#rb Alexis.Matte
Change 3118080 on 2016/09/08 by Michael.Dupuis
#jira UE-31131 Do not show a contextual menu if the menu is empty
#rb Alexis.Matte
Change 3118087 on 2016/09/08 by Matt.Kuhlenschmidt
Constify this method
#rb none
Change 3118166 on 2016/09/08 by Nick.Darnell
Trying additional command options for the build machine for automation.
#rb none
Change 3118222 on 2016/09/08 by Matt.Kuhlenschmidt
Fix actor delete during mesh paint not working during undo
#rb none
#jira UE-35684
Change 3118298 on 2016/09/08 by Alexis.Matte
#jira UE-35302 Export all LODs for static mesh when there is no force LOD
#rb uriel.doyon
Change 3118325 on 2016/09/08 by Matt.Kuhlenschmidt
Fixed reset to default not appearing for slate brushes
#rb none
#jira UE-34958
Change 3119321 on 2016/09/09 by Matt.Kuhlenschmidt
Guard against crash with an invalid world trying to be opened from the content browser
#rb none
https://jira.ol.epicgames.net/browse/UE-35712
Change 3119433 on 2016/09/09 by Nick.Darnell
Removing a hack added by Paragon that prevents applications from resizing in real time as the user drags the size of the window around.
#rb Matt.Kuklenschmidt
#jira UE-35789
Change 3119448 on 2016/09/09 by Alex.Delesky
When simulating touch events using the mouse, clicking the mouse will no longer let a drag operation continue. This should also allow the finger that started a drag to continue dragging items until it is released from the surface.
#rb Nick.Darnell
Change 3119522 on 2016/09/09 by Jamie.Dale
Fixed FDetailCategoryImpl::ShouldBeExpanded not honoring bShouldBeInitiallyCollapsed when bRestoreExpansionState was true
#rb Matt.Kuhlenschmidt
Change 3119528 on 2016/09/09 by Jamie.Dale
Some UI re-work to the localization dashboard
This makes a better use of the available space, and will make it easier to make some other planned changes in the future.
#rb James.Hopkin
Change 3119861 on 2016/09/09 by Michael.Dupuis
#jira UE-9284 Added the Play/Stop button on the thumbnail
#rb Alexis.Matte
Change 3120027 on 2016/09/09 by Alexis.Matte
incorporate some fixes from licensee for LOD group re-import workflow
#jira UE-32268
#rb uriel.doyon
#codereview matt.kuhlenschmidt
Change 3120845 on 2016/09/12 by Gareth.Martin
Fixed crash in landscape editor when "Early Z" is enabled (cloned from 4.13.1)
#jira UE-35850
#rb Allan.Bentham
Change 3120980 on 2016/09/12 by Nick.Darnell
Adding a commandlet that is runnable for comparing screenshots. Adding comparing and exporting capability to the screenshot manager.
#rb none
Change 3120992 on 2016/09/12 by Alex.Delesky
#jira UE-35575 - TScriptInterface UProperties now have asset picker support.
#rb Matt.Kuhlenschmidt
Change 3121074 on 2016/09/12 by Michael.Dupuis
#jira UE-30092
Added path length in error message when typing
Added display of current filepath lenght for cooking
#rb Alexis.Matte
Change 3121113 on 2016/09/12 by Nick.Darnell
Adding some placeholder examples to show people how to author tests in EngineTest.
#rb none
Change 3121152 on 2016/09/12 by Gareth.Martin
Added TElementType, TIsContiguousContainer traits
Added GetData(), GetNum() generic functions
#rb Steve.Robb
Change 3121702 on 2016/09/12 by Jamie.Dale
Optimized a loop over a sorted list to instead use a binary search
This speeds up the short-lived allocation view generation.
We also now dump the exception information to the Trace log when in a non-debug build.
#rb James.Hopkin
Change 3121721 on 2016/09/12 by Jamie.Dale
We now set the window mode first when resizing the game viewport to ensure that the work area is correct
Fullscreen windows can affect the available work area size, which can break centering when moving between fullscreen and windowed mode.
#jira UE-32842
#rb Matt.Kuhlenschmidt
Change 3122578 on 2016/09/13 by Jamie.Dale
Small code clean up
Removed a use of the placement new style array addition.
#rb none
Change 3122634 on 2016/09/13 by Jamie.Dale
We now immediately update DefaultConfigCheckOutNeeded when checking out/making writable the config file, rather than wait for the text tick
#jira UE-34865
#rb James.Hopkin
Change 3122656 on 2016/09/13 by Jamie.Dale
Fixed array combo button not focusing its contents, which prevented the menu closing correctly
#jira UE-33667
#rb none
Change 3122661 on 2016/09/13 by Nick.Darnell
Checkpointing additional work on the screenshot compare dialog, moving some Directory path picker widget into a more common area. Moving some "Find the best top level window handle for this widget for dialogs' code out of the main frame module and into Slate Application where it probably belongs.
#rb none
Change 3122678 on 2016/09/13 by Jamie.Dale
Fixing CIS error on Clang
CoreUObject needs to be included before USTRUCT can be used.
#rb none
Change 3122686 on 2016/09/13 by Jamie.Dale
Fixing CIS error on Clang
CoreUObject needs to be included before UCLASS can be used.
#rb none
Change 3122728 on 2016/09/13 by Nick.Darnell
UMG - Exposing a trace channel for the WIC, defaults to Visibility. Improving how the WIC handles the cursor moving off the widget, it now maintains the last hit location rather than 0,0 which would cause things like dragged Sliders to reset to the left. Ideally - the WIC would know the underlying widget has capture and continue to fake collision against an imaginary plane to simulate a continuous surface.
#jira UE-35167
#rb none
Change 3122775 on 2016/09/13 by Nick.Darnell
Automation - Fixing an error with the ScreenshotTools plugin, needed to add an the include for Engine.h to the PCH.
#rb none
Change 3122779 on 2016/09/13 by Nick.Darnell
Widgetnimation - Exposing more of the class to C++.
#rb none
Change 3122793 on 2016/09/13 by Nick.Darnell
Fixing a crash in UWidgetComponent::UpdateRenderTarget updating a null material instance.
#jira UE-35796
#rb none
Change 3122834 on 2016/09/13 by Matt.Kuhlenschmidt
Fixed crash undoing moves after bsp creation
https://jira.ol.epicgames.net/browse/UE-35880
#rb none
Change 3122835 on 2016/09/13 by Nick.Darnell
Reverting changes to WIdgetAnimation
#rb none
Change 3122897 on 2016/09/13 by Matt.Kuhlenschmidt
Fixed non-editor compile error
#rb none
Change 3122988 on 2016/09/13 by Alexis.Matte
Material workflow refactor
#jira UETOOL-774
#rb matt.kuhlenschmidt
Change 3123006 on 2016/09/13 by Jamie.Dale
Fixed dynamic collections not returning anything
#jira UE-35869
#rb James.Hopkin
Change 3123145 on 2016/09/13 by Alexis.Matte
Fix fbx automation test. The test found a regression cause by CL: 3120027. In the case where we dont have a LODGroup we dont want to add LODs before the build.
#jira UE-32268
#rb none
#codereview matt.kuhlenschmidt
Change 3123148 on 2016/09/13 by Matt.Kuhlenschmidt
Fix fortnite compile error
#rb alexis.matte
Change 3123208 on 2016/09/13 by Jamie.Dale
The 'find culprit' dialog now honors the user choice
#rb RichTW
Change 3123545 on 2016/09/13 by Nick.Darnell
Slate - Adjusting the window dialog host finding code to do a better job of searching for slate windows and excluding popups and non-regular windows.
#rb none
Change 3124494 on 2016/09/14 by Jamie.Dale
Added ~ to the list of invalid characters for object/package names
#jira UE-12908
#rb Matt.Kuhlenschmidt
Change 3124513 on 2016/09/14 by Gareth.Martin
Implemented filter to allow painting foliage on other foliage
- Altered foliage filters so it will no longer paint on object types which don't have a filter, e.g. skeletal meshes
#rb Allan.Bentham
#2472
Change 3124523 on 2016/09/14 by Jamie.Dale
PR #2724: Fix ScrollBox right mouse/touch grab scrolling functionality (Contributed by aarmbruster)
#jira UE-34811
#jira UE-32082
#rb none
Change 3124607 on 2016/09/14 by Nick.Darnell
UMG - Adding BoundsScale support to the WidgetComponent's CalcBounds function.
#jira UE-35667
#rb none
Change 3124785 on 2016/09/14 by Gareth.Martin
Made some foliage functions editor-only to fix non-editor build
#rb none
Change 3124795 on 2016/09/14 by Gareth.Martin
Saved/loaded the new foliage filter
#rb Allan.Bentham
#2472
Change 3124915 on 2016/09/14 by Michael.Dupuis
#jira UE-19511
Add support for Add to source control on DefaultEditorPerProjectUserSettings file
Remove CheckoutNotice when not editing a DefaultXXXX.ini file
Edit proper config file either we're modifying settings from a Default file or Local user file
#codereview Matt.Kuhlenschmidt Max.Preussner
#rb Alexis.Matte
Change 3125266 on 2016/09/14 by Jamie.Dale
Fixed ULocalizationTarget::DeleteFiles not deleting cultures, and using SCC wrong
#rb none
Change 3125385 on 2016/09/14 by Matt.Kuhlenschmidt
Fix crash when using SaveAs to save over top of an existing level
#rb none
https://jira.ol.epicgames.net/browse/UE-35919
https://jira.ol.epicgames.net/browse/UE-35921
Change 3125487 on 2016/09/14 by Alexis.Matte
Fix cook content, regression induce by the material workflow refactor
#rb matt.kuhlenschmidt
Change 3126217 on 2016/09/15 by Gareth.Martin
Unset bHasPerInstanceHitProxies on landscape grass components, as they don't have individually editable instances
#rb Allan.Bentham
Change 3126311 on 2016/09/15 by Jamie.Dale
Placement mode fixes
- The display name is now cached correctly on construction, and the FPlaceableItem instance used with SPlacementAssetEntry is now const.
- Ensured that the ID used by FPlaceableItem could never overflow.
- Fixed some types being missing from the "All Classes" list.
- Fixed the escape key not cancelling the search.
#jira UE-35972
#rb James.Hopkin
Change 3126325 on 2016/09/15 by Jamie.Dale
Made sure that UWorld::GetAssetRegistryTags called its Super function so that properties tagged as AssetRegistrySearchable will be added.
#rb Andrew.Rodham
Change 3126403 on 2016/09/15 by Gareth.Martin
Added Find and Contains functions to TBitArray
#rb Steve.Robb
Change 3126405 on 2016/09/15 by Gareth.Martin
Allowed instances of Hierarchical Instanced Mesh Components to be moved around with the transform widget in the blueprint editor
- Just like regular instanced mesh components!
Also fixed not being able to move instances of an instanced mesh component when it is the root component
Also also fixed Hierarchical Instanced Mesh Components not flushing their async tree build on saving (this was causing log spam from PostLoad when dragging instances around as the blueprint would constantly reinstance the component before the async tree build had finished)
#jira UE-29357
#rb Allan.Bentham
Change 3126444 on 2016/09/15 by Jamie.Dale
Fixed the loc dashboard configs not working with SCC
This isn't a great solution, but the whole way the loc dashboard manages its config data is in need of an overhaul.
#rb none
Change 3126446 on 2016/09/15 by Jamie.Dale
Fixed loc dashboard game and engine targets sharing the same expansion settting
#rb none
Change 3126555 on 2016/09/15 by Chris.Wood
Removed WER from Windows crash handling. Crashes saved to log folder and passed to CRC with explicit path.
[UE-34470] - Investigate WER settings and if they can conflict with CRC on Windows
#rb Steve.Robb
Change 3126586 on 2016/09/15 by Gareth.Martin
Fixed missing landscape components when using a LODBias (cloned from 4.13.1)
#jira UE-35873
#rb Jack.Porter
Change 3126610 on 2016/09/15 by Jamie.Dale
Stopped PS4 from always staging all ICU data files
#rb Marcus.Wassmer
Change 3126779 on 2016/09/15 by Michael.Dupuis
#jira UE-32914 Improve the help text to provide usage examples and params
#rb Alexis.Matte
Change 3126849 on 2016/09/15 by Matt.Kuhlenschmidt
Fix font material and outline font material not being animatable in sequencer
#rb frank.fella
Change 3126858 on 2016/09/15 by Matt.Kuhlenschmidt
File not saved
#rb none
Change 3127001 on 2016/09/15 by Matt.Kuhlenschmidt
Fixed reset to default state still not appearing in all cases after changing a property.
#rb none
Change 3127038 on 2016/09/15 by Nick.Darnell
UMG - Improving focus setting for users on widgets. If we're unable to set the focus immediately, possibly because the user is setting focus in the Construct callback before the widget is in the tree, we now update the SlateOperations FReply on LocalPlayer to set focus next frame when it's more likely the widget will become focusable.
#rb none
Change 3127061 on 2016/09/15 by Nick.Darnell
Slate - We now have a reentrancy guard in TPanelChildren to avoid the broad cases where users might attempt to remove children while all children are being removed. Which is an easy case to engineer if you've got widgets spawning children managed by another widget, that all go away at the same time, thus causing the parent to attempt to cleanup children. The end result is a delete while deleting. So now TPanelChildren prevents adds/removes while emptying the list of children.
#jira UE-35726
#rb Matt.Kuchlenschmidt
Change 3127205 on 2016/09/15 by Alex.Delesky
#jira UE-18013 - Users can now add Textures, Materials, or Sprites to a Widget Blueprint directly from the content browser. This also fixes a few issues with adding Widget Blueprints to another Widget BP from the content browser, such as adding a widget to itself or creating a circular dependency.
#rb Nick.Darnell
Change 3127971 on 2016/09/16 by Matt.Kuhlenschmidt
Fix crash in scene outliner if actors become invalid
#rb none
https://jira.ol.epicgames.net/browse/UE-35932
Change 3128011 on 2016/09/16 by Matt.Kuhlenschmidt
Added guards for crashes accessing slate resources for deleted uobjects
#rb nick.darnell
Change 3128067 on 2016/09/16 by Michael.Dupuis
#jira UE-34158 Add an option to auto expand advanced details
#rb Alexis.Matte
Change 3128073 on 2016/09/16 by Michael.Dupuis
#jira UE-1145
Set Save As to Ctrl + Alt + S
Set Save All to Ctrl + Shift + S
Set Save Current to Ctrl + S
#rb Alexis.Matte
Change 3128117 on 2016/09/16 by Jamie.Dale
Updated the pin-type filter combo to filter on both the localized and source type descriptions
#jira UE-36081
#rb none
Change 3128177 on 2016/09/16 by Alexis.Matte
#jira UE-35946 Remove unnecessary GetReadValue call with bad parameter. The read value call is cache so subsequent call was returning the bad cache value.
#rb michael.dupuis
#codereview matt.kuhlenschmidt
Change 3128387 on 2016/09/16 by Gareth.Martin
Fixed location and rotation of arrow widget in the landscape mirror tool when using one of the new "Rotate" modes
#jira UE-36093
#rb none
Change 3128445 on 2016/09/16 by Matt.Kuhlenschmidt
Guard against scene outliner crash. Print out tree when items appear twice.
https://jira.ol.epicgames.net/browse/UE-35935
#rb none
Change 3128454 on 2016/09/16 by Matt.Kuhlenschmidt
Remove category for WindowTitleBarArea. It is very custom for internal use and should not be a top level widget
#rb none
Change 3128482 on 2016/09/16 by Michael.Dupuis
Added new key binding for generic Save, Save As
Added new key binding for Save All for the content browser
#rb Alexis.Matte (approved by MattK)
Change 3128560 on 2016/09/16 by Matt.Kuhlenschmidt
Fix build warning
#codereview nick.darnell
#rb none
Change 3128642 on 2016/09/16 by Alexis.Matte
#jira UE-36047 We now convert the light color correctly when importing and exporting fbx files. UE4 is sRGB and FBX is linear
#rb none
#codereview matt.kuhlenschmidt
Change 3128733 on 2016/09/16 by Nick.Darnell
UMG - Fixing a bad merge, some code was removed causing all BindWidget statements to fail to compile correctly.
#jira UE-36105
#rb none
Change 3128768 on 2016/09/16 by Matt.Kuhlenschmidt
Fix selection outline showing around edges of all internal mesh sections of a component instead of around the entire actor
#rb none
Change 3128779 on 2016/09/16 by Matt.Kuhlenschmidt
Fix offset characters on some small fonts
#rb none
Change 3130057 on 2016/09/19 by Jamie.Dale
Fixing volatility and invalidation issues for text widgets
#jira UE-33988
#rb Nick.Darnell
Change 3130064 on 2016/09/19 by Jamie.Dale
Changed mprof meta-data to allow unicode strings and updated ReadString to deal with them correctly
#rb James.Hopkin
Change 3130233 on 2016/09/19 by Michael.Dupuis
#jira UE-32914 Added missing args that the UI supported
#rb Alexis.Matte
Change 3130265 on 2016/09/19 by Nick.Darnell
Automation - Cleaning up some API items.
#rb none
Change 3130378 on 2016/09/19 by Matt.Kuhlenschmidt
Fix reentrancy saving assets while a prompt for checkout dialog is open
#rb none
Change 3130398 on 2016/09/19 by Jamie.Dale
Fixing UHT error when building
#rb none
Change 3132101 on 2016/09/20 by Nick.Darnell
UMG - Adding a toolbar option in the designer for the 'G' command, similar to 'Game View' in the level editor, it disables all the dashed lines / future editor visuals.
#rb none
Change 3132110 on 2016/09/20 by Nick.Darnell
PR #2792: ShowFlags for WidgetComponents (Contributed by projectgheist)
#jira UE-13770
#rb Nick.Darnell
Change 3132111 on 2016/09/20 by Nick.Darnell
UMG - The retainer now embeds a virtual window into the focus path so that paths are resolved correctly.
#rb none
Change 3132138 on 2016/09/20 by Michael.Dupuis
#jira UE-30945 Added missing PostEditComponentMove after drag is finished
#rb Alexis.Matte
Change 3132147 on 2016/09/20 by Michael.Dupuis
#jira UE-30866 Fixed the filter to work properly
#rb Alexis.Matte
Change 3132190 on 2016/09/20 by Matt.Kuhlenschmidt
Fix static analysis warnings in this file
#rb none
Change 3132231 on 2016/09/20 by Nick.Darnell
Slate - Updating the material blend states to match what is expected of Slate rendering, which differs a lot from the scene renderer with the way it treats alpha. This fixes translucent rendering with the retainer widget, users will need to set their materials to Alpha Composite though for it to behave as expected.
#jira UE-33285
#rb none
Change 3132255 on 2016/09/20 by Alex.Delesky
#jira UE-36048 - TMap and TSet properties are now disallowed from adding more children through the Details panel when they contain the dfault value for a key or element. Reset to Default is also no longer allowed on a Map or Set child when it will result in a second default value existing within the container.
#rb Matt.Kuhlenschmidt
Change 3132587 on 2016/09/20 by Mike.Fricker
MIDI Plugin: Fixed a CIS error in shipping configuration (introduced in CL 3108604)
#rb none
#lockdown matt.kuhlenschmidt
Change 3132623 on 2016/09/20 by Matt.Kuhlenschmidt
Fix crash opening the cooker settings
https://jira.it.epicgames.net/browse/UE-36197
#rb none
#lockdown nick.darnell
Change 3133144 on 2016/09/20 by Nick.Darnell
Build configuration for automation tests.
#rb none
#lockdown matt.kuhlenschmidt
Change 3133206 on 2016/09/20 by Matt.Kuhlenschmidt
Fix default material on odin text
#rb none
#lockdown nick.darnell
Change 3133913 on 2016/09/21 by Nick.Darnell
Back out revision 17 from //UE4/Dev-Editor/Engine/Source/Runtime/UMG/Private/Slate/SRetainerWidget.cpp
#rb none
#jira UE-36231
#lockdown matt.kuhlenschmidt
[CL 3133983 by Matt Kuhlenschmidt in Main branch]
2016-09-21 10:07:18 -04:00
// Find the first visible button. That will be our widget to focus
FChildren * ButtonBoxChildren = ButtonsBox - > GetChildren ( ) ;
for ( int ButtonIndex = 0 ; ButtonIndex < ButtonBoxChildren - > Num ( ) ; + + ButtonIndex )
{
Copying //UE4/Dev-Editor to //UE4/Dev-Main (Source: //UE4/Dev-Editor @ 4048875)
#lockdown Nick.Penwarden
#rb none
============================
MAJOR FEATURES & CHANGES
============================
Change 3808185 by Cody.Albert
Added missing calls to FEditorViewportClient::AddReferencedObjects in overrides
Change 3809824 by Michael.Trepka
Improved the way we generate groups in Xcode project's source code navigator. They are now sorted alphabetically and have correct paths so Xcode no longer displays them in red. Also, added __INTELLISENSE__ to preprocessor definitions for indexing to improve indexing without game header files generated.
Change 3810089 by Jamie.Dale
Fixed PO files failing to import translations containing only whitespace
Change 3811281 by Matt.Kuhlenschmidt
PR #4331: Toggle SIE shortcut only in PIE (Contributed by projectgheist)
Change 3813031 by Matt.Kuhlenschmidt
Fix undocked tabs not dropping at users mouse location
#jira UE-53427
Change 3813361 by Brandon.Schaefer
Print what SDL video driver we are using
Change 3818430 by Matt.Kuhlenschmidt
PR #4365: Incorrect font name and forgotten undef (Contributed by projectgheist)
Change 3818432 by Matt.Kuhlenschmidt
PR #4366: Asset Color Strip updates correct on drag and drop (Contributed by projectgheist)
Change 3818436 by Matt.Kuhlenschmidt
PR #4367: Improved logging (Contributed by projectgheist)
Change 3819886 by Matt.Kuhlenschmidt
Add a way to optionally disable the warning about referenced actors being moved to other levels. Useful for bulk actor moves via script
Change 3819888 by Matt.Kuhlenschmidt
Avoid crashing when a window size becomes too large to render. Instead just ensure and clamp to the maximum allowed size. Avoids crashes where the screen dimensions are saved with super large numbers for unknown reasons
Change 3821773 by Brandon.Schaefer
Fix crash when importing to level
#jira UE-31573
Change 3821892 by Jamie.Dale
Improved the localized asset cooking so that it only cooks L10N variants if their source asset is cooked
#jira UE-53010
Change 3823714 by Christina.TempelaarL
#jira UE-52179 added support for grayscale PSD files
Change 3826805 by Christina.TempelaarL
#jira UE-49636 SceneCaptureComponent2D hidden actor and show only actors disabled in blueprints
#jira UE-53445 SceneCaptureComponent2D hidden actors always disabled in details layout
Change 3828444 by Anthony.Bills
Add LXC container script for building third party libraries.
The intention is that this should become the only way to rebuild the third party libraries that require system dependencies not included in the cross-compile toolchain and also to rebuild the toolchains. Other third party libraries without any system dependencies could be rebuilt via the cross-compile toolchains/UBT.
This script has been tested running on CentOS 7 and Ubuntu 17.10.
Buy default the x86 and x86_64 builds will be built against a CentOS 6 container (and targeting glibc 1.12) and the aarch64 and armhf builds will use an Ubuntu Ubuntu Trusty (14.04) but this is not yet complete.
Change 3828754 by Brandon.Schaefer
Linux: Fix gamepad thumbstick clicks not registering (github #4209 thanks J??rn M??ller)
#jira UE-45722
#review-3828733 Arciel.Rekman
Change 3830414 by Brandon.Schaefer
Remove circular referencing to a parent window. Move to use AddSP vs AddRaw as well to be safe manually remove ourselves from the selection event delegate list due to Linux pending deletion of windows.
Looks like this should fix UE-28322 as well which I've removed the work around placed in for that.
#jira UE-53918
#review @michael.trepka, @matt.kuhlenschmidt, @arciel.rekman
Change 3830916 by Brandon.Schaefer
More verbose message about missing VK extensions (from Marcin Undak)
#review-3830710 marcin.undak, arciel.rekman
Change 3831339 by Brandon.Schaefer
Default to as-needed for debug mode
#jira none
#review-3830658 Arciel.Rekman
Change 3833102 by Jamie.Dale
Re-added warning for duplicate package localization IDs when gathering asset localization
Change 3834600 by Jamie.Dale
Optimized asset registry filter intersection
Change 3838024 by Brandon.Schaefer
Remove tracking of CLion/CMake build files (from github #4346 thanks reapazor!)
#jira UE-53551
#review-3835803 arciel.rekman
Change 3839969 by Michael.Dupuis
#jira UE-52289: When OnRegister is called on the component make sure our PerInstanceRenderData is up to date
Prevent a possible crash if ClearInstanceSelection was called on a component with no PerInstanceRenderData existing
Change 3840049 by Michael.Dupuis
#jira UE-52975: Was always performing the equivalent of an Add, so now we use the Transform during the duplicate
Change 3840071 by Matt.Kuhlenschmidt
- Combine some shader params for slate in order to reduce overhead setting uniform buffers
- Added better stats for slate draw call rendering
- cleaned up huge lambda in Slate rendering main function so we can read the main slate rendering function again
Change 3840291 by Michael.Dupuis
#jira UE-53053: Was having a mismatch between the remove reorder and the actual remove
Change 3840840 by Michael.Dupuis
#jira UE-53944: Make sure the LOD generated is in the valid range to prevent the crash
Change 3842072 by Michael.Dupuis
#jira UE-50299: Include NumSubsection in calculation of component quad factor
Change 3842487 by Christina.TempelaarL
#jira UE-50573 HighResShot has wrong res in immersive mode
Change 3845702 by Matt.Kuhlenschmidt
PR #4381: DefaultASTCQualityBySpeed too high max value. (Contributed by kallehamalainen)
Change 3845706 by Matt.Kuhlenschmidt
PR #4388: Only restore window if minimized (Contributed by projectgheist)
Change 3845993 by Christina.TempelaarL
#jira UE-41558 crash when selecting PostProcessingVolumes in separate levels
Change 3856395 by Brandon.Schaefer
No longer using ALAudio on Linux
#jira UE-53717
Change 3858324 by Michael.Trepka
Preserve command line arguments in Xcode project when regenerating it
Change 3858365 by Michael.Dupuis
#jira UE-52049: There was a case where adding and removing multiple time would lead to reordering the instances and this would cause the regeneration of the random stream for all the reorded instances.
Change 3858492 by Michael.Trepka
Updated dependencies for Mac dSYM files so that only cross-referenced modules have their dSYMs recreated on subsequent builds instead of all modules.
Change 3859470 by Michael.Trepka
CIS fix. Make sure a scheme file exists before trying to read it when generating Xcode project.
Change 3859900 by Joe.Conley
Fix for "Check Out Assets" window not properly receiving focus.
Change 3865218 by Michael.Dupuis
#jira UE-45784: Exposed the possibility to edit LDMaxDrawDistance
Change 3866957 by Michael.Dupuis
#jira UE-42509: Added BodyInstance to ULandscapeSplineSegment and ULandscapeSplineControlPoint
Deprecated bEnabledCollision and migrate data as it's replaced by BodyInstance
Change 3867220 by Cody.Albert
Fixed Project Launcher scrollbar to properly stay anchored at the bottom of the scroll area.
Change 3869117 by Michael.Dupuis
#jira UE-42509:Fixed compile error when not having editor data
Change 3872478 by Arciel.Rekman
Linux: disable PIE if compiler enables it by default.
Change 3874786 by Michael.Dupuis
#jira UE-46925: Remove the guessing functionality when importing a heightmap, and instead propose to the user valid size that can be used for the import through a combo button.
Improved usability of the UI by disabling size field when no file was specified
Change 3875859 by Jamie.Dale
Implemented our own canonization for culture codes
Change 3877604 by Cody.Albert
We now validate actor names passed to SetActorLabel to ensure None isn't passed in, which can corrupt levels
Change 3877777 by Nick.Shin
PhysX build fix - this came from CL: 3809757
#jira UE-54924 Cannot rebuild Apex/PhysX/NvCloth .emscripten missing
Change 3881693 by Alexis.Matte
Fix local path search to not search in memory only
#jira UE-55018
Change 3882512 by Michael.Dupuis
#jira none : Fixed screen size calculation to take aspect ratio into account correctly
Change 3886926 by Arciel.Rekman
Linux: fixed checking clang settings during the cross-build (UE-55132).
#jira UE-55132
Change 3887080 by Anthony.Bills
Updated SDL2 build script.
- Now allows compiling inside a CentOS 6 or Ubuntu 12.04 container with wayland support when using the ContainerBuildThirdParty.sh.
- Added multiple build arch support to the BuildThirdParty script and pass this down to the SDL2 build script.
Change 3887260 by Arciel.Rekman
Linux: fix leaking process handles in the cross-toolchain.
Change 3889072 by Brandon.Schaefer
Fix RPath workaround, to better handle both cases
#jira UE-55150
#review-3888119 @Arciel.Rekman, @Ben.Marsh
Change 3892546 by Alexis.Matte
Remove fbx exporter welded vertices options
#jira UE-51575
Change 3893516 by Michael.Dupuis
Remove static mesh instancing async buffer filling, as with all the changes made, it's no longer necessary, the cost of loading very large buffer is negligable
Rebuild the occlusion tree when using foliage.DensityScale with something other than 1.0
Change 3894365 by Brandon.Schaefer
Pass FileReference over a raw string to the LinkEnvironment
#jira none
#review-3894241 @Ben.Marsh, @Arciel.Rekman
Change 3895251 by Brandon.Schaefer
Use X11 pointer barriers to bound the cursor to a region over warping the pointers. Patch from Cengiz
#jira UE-25615
#jira UE-30714
#review-3894886 @Arciel.Rekman
Change 3897541 by Michael.Dupuis
#jira UE-53787: Added guard if for some reason the material is null we should not try to draw using this material
Change 3904143 by Rex.Hill
#jira UE-55366: Fix crash when overwriting existing level during level save as
#jira UE-42426: Map '_BuiltData' can now be deleted when selected at same time as map
- Map '_BuiltData' package is now garbage collected when switching maps in the editor
Change 3906373 by Brandon.Schaefer
Fix splash image. Use alias format for big/little endian machines.
#jira none
Change 3906711 by Rex.Hill
#jira UE-42426: BuiltData now deleted with maps
Change 3907221 by Cody.Albert
Add support for relative asset source paths in content plugins
Change 3911670 by Alexis.Matte
Fix assetimportdata creation owner
#jira UE-55567
Change 3912382 by Anthony.Bills
Linux: Add binaries for GoogleTest and add to BuildThirdParty script.
Change 3914634 by Cody.Albert
Added missing include that could cause compile errors if IWYU was disabled.
Change 3916227 by Cody.Albert
Fixing some cases where we check #ifdef WITH_EDITOR instead of #if WITH_EDITOR
Change 3917245 by Michael.Dupuis
#jira UE-35097: Fixed crash when creating a new landscape with 2x2 subsection and material containing grass spawning
Change 3918331 by Anthony.Bills
Linux: Bundled Mono - Explicilty pick libc.so.6 as libc.so is a linker script and store the config file directly.
Change 3920191 by Rex.Hill
#jira UE-44197 Fix saving sub-level level causing MapBuildData to be deleted
Improved MapBuildData rename, move, duplicate, copy
Change 3920333 by Matt.Kuhlenschmidt
Render target clear color property now settable in editor
#jira UE-55347
Change 3926094 by Michael.Dupuis
#jira UE-51502: Added some min/max values to foliage and grass settings to prevent overflow/crash
#coderevew jack.porter
Change 3926243 by Michael.Dupuis
#jira UE-54669: cleaned up invalid/duplicate shader and moved some shaders to appropriate list
Change 3926760 by Jamie.Dale
Added support for TTC/OTC fonts
These can be used via a sub-face index on FFontData, which can be set via a new combo in the font editor. You can also see the cached list of sub-faces within a font file from the UFontFace asset.
Change 3927793 by Anthony.Bills
Mono: Remove SharpZipLib and references from bundled Mono.
#review-3887212 @ben.marsh, @michael.trepka
Change 3928029 by Anthony.Bills
Linux: Add support for UnrealVersionSelector.
- Supports using UVS to launch without a project file. This will then launch the selected engine's project wizard.
- Linux UVS uses Slate for the version selection and error log dialogs.
- Mime-types and desktop file support added to DesktopPlatformLinux to allow associating with UVS as per the Windows binary and git builds.
- Icons added for Linux.
#review-3882197 @arciel.rekman, @brandon.schaefer
Change 3931293 by Alexis.Matte
Add generic Levenshtein edit distance to core algo. This algorithm will help suggesting name matching when users have to resolve material name conflict when re-import fbx meshes.
Add also plenty of automation tests for it.
#jira none
Change 3931436 by Arciel.Rekman
Stop RHI thread before shutting down RHI.
- Prevents crashes for some drivers that create TLS objects with destructors; those destructors will get called after the thread exited, but the library will already be unloaded on RHI shutdown.
Change 3934287 by Alexis.Matte
Fix crash when re-importing skeletal mesh. Skinned component render data resource is now release when re-importing.
#jira none
Change 3937585 by Lauren.Ridge
Added labels to the colors stored in the theme bar.
Change 3937738 by Alexis.Matte
Make sure content browser do not show a preview asset created when we cancel an export animation preview
#jira UE-49743
Change 3941345 by Michael.Dupuis
#jira UE-26959: Prevent reusing multiple type the same grass type into the same material grass output node
Change 3941453 by Michael.Dupuis
#jira UE-47492: Added a guard to validate LayerIndex
Change 3942065 by Jamie.Dale
Fixed crash trying to use FSlateApplication when it wasn't available (eg, in a commandlet)
Change 3942573 by Alexis.Matte
Fix static analysis
Change 3942623 by Michael.Dupuis
#jira 0
Cast to ulong as TaskIndex * NumStripes could exceed an int limit and add an assert if the wraparound is negative
Change 3942993 by Matt.Kuhlenschmidt
PR #4547: Verify the return value of FT_New_Memory_Face (Contributed by jorgenpt)
Change 3942998 by Matt.Kuhlenschmidt
PR #4554: Cleanup log printing (Contributed by projectgheist)
Change 3943003 by Matt.Kuhlenschmidt
PR #4534: Prevent Fatal log when alt tabbing during a level save (Contributed by projectgheist)
Change 3943011 by Matt.Kuhlenschmidt
PR #4518: edit (Contributed by pdlogingithub)
Change 3943027 by Matt.Kuhlenschmidt
PR #4524: Notifications always render on the screen with the main viewport (Contributed by projectgheist)
Change 3943074 by Matt.Kuhlenschmidt
PR #4484: Add group actor to folder (Contributed by ggsharkmob)
Change 3943079 by Matt.Kuhlenschmidt
PR #4431: Git Plugin: replace usage of the 2 cli args "--work-tree" and "--git-dir" by "-C" (Contributed by SRombauts)
Change 3943092 by Matt.Kuhlenschmidt
PR #4434: Git plugin: configure the default remote URL 'origin' (Contributed by SRombauts)
Change 3943132 by Matt.Kuhlenschmidt
PR #4247: Add File picker to Git Path setting on GitSourceControl (Contributed by shiena)
Change 3943141 by Matt.Kuhlenschmidt
PR #4303: Fix ULevelExporterT3D so that it works in a commandlet (Contributed by DSDambuster)
Change 3943349 by Jamie.Dale
Cleaned up PR #4547
Made the assert non-fatal to avoid it being able to take down the editor if you load up a bad font.
Fixed some code that was deleted during the merge.
Change 3943976 by Michael.Trepka
Copy of CL 3940687
Fixed long link times when building for Mac in Debug by passing -no_deduplicate flag to the linker, which is what Xcode does in Debug configs.
#jira none
Change 3944882 by Matt.Kuhlenschmidt
Fix a few regressions with scene viewport activation locking can capturing the cursor in editor
#jira UE-56080, UE-56081
Change 3947339 by Michael.Dupuis
#jira UE-55664: Fixed undo/redo buffer handling so we remove from the beginning of the buffer during undo buffer where buffer is at max memory and from the end during redo operation.
Fixed cancel also to re add removed transaction at the end or the start depending if we're doing a redo or undo operation
Fixed the Undo History UI to listen to an event when the undo buffer changed instead of checking every frame, as when the buffer was full, no changes would occur, thus no UI update.
Change 3948179 by Jamie.Dale
Fixed monochromatic font rendering
- All non-8bpp images are now converted to 8bpp images for processing in Slate.
- We convert the gray color of any images not using 256 grays (eg, monochromatic images that use 2 grays).
- Fixed a case where the temporary bitmap wasn't being deleted.
- Fixed a case where the bitmap could be used after it was deleted.
- Added a CVar (Slate.EnableFontAntiAliasing) to control whether you want anti-aliased (256 grayscale) rendering (default), or monochromatic (2 grayscale) rendering.
Change 3949922 by Alexis.Matte
Ensure fbx node name are not empty when loading a fbx file. I use the same naming convention as Maya
#jira UE-56079
Change 3950202 by Rex.Hill
Fix crash during editor asset automation tests.
Now skips showing modal progress window when opening asset editor window. ActiveTopLevelWindow is not set when modal windows are open.
#jira UE-56112
Change 3950484 by Michael.Dupuis
#jira UE-52176: delete the Cluster tree when the builder is no longer needed
Change 3954628 by Michael.Dupuis
Bring back 4.19/4.19.1 Landscape changes
Change 3957037 by Michael.Dupuis
#jira UE-53343: Add foliage instances back when changing component size
Changed the formulation for the Clip/Expand behavior to make it more explicit on what will happen
Added SlowTask stuff to manage big landscape change
Change 3959020 by Rex.Hill
Rename/move file MallocLeakDetection.h
Change 3960325 by Michael.Dupuis
Fixed static analysis
Change 3961416 by Michael.Dupuis
#jira UE-46100: Exposed UseDynamicInstanceBuffer on Foliage type, so user can decide if they want to update them dynamically
#jira UE-55092: Fixed the warning to appear when having resource array as empty but VB as set up
Added data conssitency that when using Dynamic buffer, Keep CPU Access should also be true, even if implicitly it's already the case, now it's explicit
Change 3962372 by Michael.Trepka
Copy of CL 3884121
Fix for SProgressBar rendering incorreclty on Mac
#jira UE-56241
Change 3964931 by Anthony.Bills
Linux: Add cross-compiled binary of UVS Shipping.
Change 3966719 by Matt.Kuhlenschmidt
Fix parameters out of order here
#jira UE-56399
Change 3966724 by Matt.Kuhlenschmidt
PR #4585: Export symbols for the FDragTool (Contributed by Begounet)
Change 3966734 by Matt.Kuhlenschmidt
PR #4596: fix the slider issue of the HighResolutionScreenshot window (Contributed by mamoniem)
Change 3966739 by Matt.Kuhlenschmidt
Removed duplicated code
#jira UE-56369
Change 3966744 by Matt.Kuhlenschmidt
PR #4602: Fixes check for existing extensions when generating "All Extensions". (Contributed by PhilBax)
Change 3966758 by Matt.Kuhlenschmidt
PR #4604: Fixed an issue where the Modules and DebugTools tabs would be unrecognized after startup if docked in the level editor (Contributed by tstaples)
Change 3966780 by Matt.Kuhlenschmidt
Fix crash accessing graph node title widgets when objects have become stale.
#jira UE-56442
Change 3966884 by Alexis.Matte
Fix speedtree uninitialized values
#jira none
Change 3967568 by Alexis.Matte
Do not override the screensize when importing a skeletal mesh, let the value set by the AddLodInfo function
#jira UE-56493
Change 3968333 by Brandon.Schaefer
Fix order of operation
#jira UE-56400
Change 3969070 by Anthony.Bills
Linux: Make sure to set the UE_ENGINE_DIRECTORY
#jira UE-56503
#review-3966609 @arciel.rekman, @brandon.schaefer
Change 3971431 by Michael.Dupuis
#jira UE-56515: Fixed an issue where ForcedLOD > MaxLOD and make sure that LastLOD will at least contain current streamed in LOD.
#jira UE-56517: When using ParallelInitView 1 there was a memory leak related to a reallocate that happen with the TArray of FMemstack
Pass correctly LODDistanceFactor instead of View.LODScale as we do not want StaticMeshScale to affect us.
Change 3971467 by Matt.Kuhlenschmidt
Fixed crash deleting a texture with texture painting on it
#jira UE-56994
Change 3971557 by Matt.Kuhlenschmidt
Fix temporary exporter objects being potentially GC'd and causing crashes during export
#jira UE-56981
Change 3971713 by Cody.Albert
PR #4597: [FPS Template] Small null pointer check fix and cleanup (Contributed by TheCodez)
Change 3971846 by Michael.Dupuis
#jira UE-56517: Properly "round" the count so we have the right amount of memory reserved
#jira UE-56515: Still had a edge case left, so when using forced lod i simply make sure the value is in valid range, and allocate all the required data for this range
Change 3973035 by Nick.Atamas
Line and Spline rendering changes:
* Lines/Splines now use 1 UV channel to anti-alias (this channel can be used for texturing)
* Anti-aliasing filter now adjusted based on resolution
* Modified Line/Spline topology to accomodate new UV requirements
* Disabled vertex snapping for anti-aliased lines/splines; previously vertexes were snapped, but vertex positions did not affect line rendering (behavior effectively unchanged)
* Splines now adaptively subdivided to avoid certain edge-cases
Change 3973345 by Nick.Atamas
- Number tweaks to maintain previously perceived wire thickness in various editors.
Change 3977764 by Rex.Hill
MallocTBB no longer debug fills bytes in development configuration
Change 3978713 by Arciel.Rekman
UVS: Fix stale dependency.
Change 3980520 by Matt.Kuhlenschmidt
Fix typo
#jira UE-57059
Change 3980557 by Matt.Kuhlenschmidt
Fixed negative pie window sizes causing crashes
#jira UE-57100
Change 3980565 by Matt.Kuhlenschmidt
PR #4628: Fixed revert action, now correctly uses CanRevert() condition (Contributed by Kryofenix)
Change 3980568 by Matt.Kuhlenschmidt
PR #4626: UE-57111: Handle CaptureRegion for HighResShot in PIE (Contributed by projectgheist)
Change 3980580 by Matt.Kuhlenschmidt
PR #4567: [Editor UI] Pick Parent Class dialog: set keyboard focus and handle Escape & Enter (Contributed by SRombauts)
Change 3980581 by Matt.Kuhlenschmidt
PR #4565: [Editor UI] Add C++ Class dialog: set keyboard focus and handle Escape & Enter (Contributed by SRombauts)
Change 3981341 by Jamie.Dale
Re-added GIsEditor condition around package namespace access
#jira UE-55816
Change 3981808 by Ryan.Brucks
Added LandscapeProxy functions to push RenderTarget data to Heightmaps and Weightmaps
Change 3983344 by Jack.Porter
#include fixes for CL 3981808
#jira 0
Change 3983391 by Jack.Porter
One for #include fix for CL 3981808
#jira 0
Change 3983562 by Michael.Dupuis
#jira UE-53787: Make sure the material array is valid before trying to generate static mesh batch element
#jira UE-56451: Instead of asserting, simply skip this element as it had invalid custom data anyway, so we can't render it
Change 3983600 by Matt.Kuhlenschmidt
PR #4289: Pragma Once/Include guard cleanup (Contributed by projectgheist)
Change 3983637 by Matt.Kuhlenschmidt
PR #4408: Add a template pregeneration hook (Contributed by mhutch)
Change 3984392 by Michael.Dupuis
#jira UE-56314: Correctly apply LODBias on calculated LOD
Fixed some Landscape popping that could occur when we were forcing a LOD that didn't match the component screen size
Change 3984950 by Rex.Hill
Optimized texture import speed 2-3x depending on number of cpu cores and image size
Change 3985033 by Rex.Hill
File drag and drop is more quick to respond when editor is in background
#jira UE-57192
Change 3986218 by Jack.Porter
Missing template parameter fix for CL 3981808
#jira 0
Change 3986376 by Michael.Dupuis
#jira UE-56453: Do not use the CreateDynamicMaterialInstance as it will change the parenting of the actor used material, instead simply use the function to generate the MID and parent it correctly.
Change 3989391 by Matt.Kuhlenschmidt
Fix constant FName lookup in level editor when checking various states of level editor tabs
Change 3990182 by Rex.Hill
Optimize editor startup time: GetCurrentProjectModules
Change 3990365 by Alexis.Matte
Fix crash with spline mesh when the attach SM get a new imported LOD
#jira UE-57119
Change 3991151 by Rex.Hill
VR Editor module now waits to load images until VR mode activated in editor. Saves 0.4 seconds of editor startup time.
Change 3991164 by Rex.Hill
Optimize editor startup time: FindModulePaths()
- Invalidates cache when search paths added
- Use cache during wildcard searches containing * and ?
Change 3995366 by Anthony.Bills
Update BuildCrossToolchain script to allow a Linux host targeting multiple Linux architectures (including the hosts arch). Added a patch to support a gcc 4.8.5 based toolchain on windows (potentially useful for users crosscompiling using GCC and libstdc++ and targeting CentOS 7).
#review-3848487 @arciel.rekman, @brandon.schaefer
Change 3996109 by Jamie.Dale
Reworked BP error messages to be more localization friendly
#jira UETOOL-1356
Change 3996123 by Michael.Dupuis
#jira UE-57427: Update random color on load of the component
#jira UE-56272:
Change 3996279 by Merritt.Cely
Removed hardware survey from editor
#jira an-2243
#tests launched the editor
Change 3996626 by Alexis.Matte
Fix crash when SkeletalMesh tangent buffer is empty after the build and we serialize the tangent array.
#jira UE-57227
Change 3996663 by Max.Chen
Sequencer: Fix fbx animation export - rotation and scale channels were flipped.
#jira UE-57509
#jira UE-57512
#jira UE-57514
Change 4000331 by Brandon.Schaefer
Add a GFNameTableForDebuggerVisualizers_MT back only for Unix under the Core module
#review-3999426 @Arciel.Rekman
#jira UE-55298
Change 4000450 by Matt.Kuhlenschmidt
Another guard against a factory being destroyed during import
#jira UE-57674
Change 4000459 by Matt.Kuhlenschmidt
Added check for valid game viewport to see if this is the problem in UE-57677
#jira UE-57677
Change 4000493 by Matt.Kuhlenschmidt
Remove stale GC'd components when refreshing paint mode to prevent crashes
#jira UE-52618
Change 4000683 by Jamie.Dale
Fixed target being incorrect when added via the Localization Dashboard
#jira UE-57588
Change 4000738 by Alexis.Matte
Add a section settings to ignore the section when reducing
#jira UE-52580
Change 4000920 by Alexis.Matte
PR #4219: Fix for SColorGradingPicker preventing PIE (Contributed by projectgheist)
author projectgheist projectgheist@gmail.com
Change 4001432 by Alexis.Matte
Add a fbx re-import resolve material windows, user can now help resolving the material in case the importer fail to found a match.
Change 4001447 by Jamie.Dale
Fixed property table not working with multi-line editable text
Change 4001449 by Jamie.Dale
PR #4531: Localization multiline fix (Contributed by Lallapallooza)
Change 4001557 by Alexis.Matte
Fix a check in fbx scene importer, in case the user import a fbx LOD group with no geometry under it
#jira UE-57676
Change 4002539 by Alexis.Matte
Make the fbx importer global transform options persist in the config file
#jira UE-50897
Change 4002562 by Anthony.Bills
Linux: Enable UVS registering for git builds only and remove old Mono and pre-UVS script code.
Change 4003241 by Alexis.Matte
Fix the staticmesh import socket logic, it was duplicating socket when re-importing
#jira UE-53635
Change 4003368 by Michael.Dupuis
#jira UE-57276:
#jira UE-56239:
#jira UE-54547:
Make sure we can't go above MaxLOD even for texture streaming
Change 4003534 by Alexis.Matte
Fix re-import mesh name match
#jira UE-56485
Change 4005069 by Michael.Dupuis
#jira UE-57594: Add a guard to prevent crash if we have an invalid resource for the heightmap texture (happen when component is deleted, for example)
Change 4005468 by Lauren.Ridge
Widgets should not be removed from parent when they are pending GC
#jira UE-52260
Change 4006075 by Michael.Dupuis
Fixed foliage density scaling to be applied even in editor, except in Foliage edit mode.
Change 4006332 by Arciel.Rekman
UBT: Adding support for bundled toolchains on Linux.
- Authored by Anthony Bills, with modifications.
Change 4007528 by Matt.Kuhlenschmidt
PR #4665: Source control History Window: enlarge column Description (Contributed by SRombauts)
Change 4007531 by Matt.Kuhlenschmidt
PR #4656: UE-57200: Ignore reference to actor if same actor (Contributed by projectgheist)
Change 4007548 by Matt.Kuhlenschmidt
PR #4664: Set Password on EditableText (Contributed by projectgheist)
Change 4007730 by Brandon.Schaefer
Add a new way to symbolicate symbols for a crash at runtime
Two new tools are used for this.
1) dump_syms Will generate a symbol file, which is to large to read from at runtime
2) BreakpadSymbolEncoder Takes the dump_syms file and encodes it in such a way we can do
a binary search at runtime to find a Program Counter to a symbol we are looking for
#review @Arciel.Rekman, @Anthony.Bills
#jira UETOOL-1206
Change 4008429 by Lauren.Ridge
Fixing undo bug when deleting user widgets from the widget tree
#jira UE-56394
Change 4008581 by Cody.Albert
Reinitialize needs to set the audio and caption tracks in addition to the video track or the currently selected track will be lost
Change 4009605 by Lauren.Ridge
Added Recently Opened assets filter under Other Filters in the Content Browser
Change 4009797 by Anthony.Bills
Linux: Update MultiArchRoot path to not cache. Move in tree toolchain location to match UBT convention and make sure the MultiArchRoot is checked before the system.
Change 4010266 by Michael.Trepka
Copy of CL 4010052
Moved some key event handling calls to the main thread on Mac to satisfy new macOS requirements
#jira UE-54623
Change 4010838 by Arciel.Rekman
Linux: limit allowed clang versions to 3.8-6.0.
Change 4012160 by Matt.Kuhlenschmidt
Changed the messagiing on the crash reporter dialog to reflect new bug submission process
#jira UE-56475
Change 4013432 by Lauren.Ridge
Fix for non-assets attempting to add to the Content Browser's recent filter
#jira none
Change 4016353 by Cody.Albert
Improved copy/paste behavior for UMG editor:
-Pasting in the designer while a canvas is selected will place the new widget under the cursor
-Pasting multiple times while a canvas panel is selected in the hierarchy view will cascade the widgets starting at 0,0
-Pasting while something that isn't a panel is selected is now allowed, and will cascade the pasted widgets off the position of the selected widget (as siblings)
-Newly pasted widgets will now be selected automatically
-Pasting multiple widgets at once will try and maintain their relative positions if they're being pasted into a canvas panel
Change 4017274 by Matt.Kuhlenschmidt
Added some guards against invalid property handle access
#jira UE-58026
Change 4017295 by Matt.Kuhlenschmidt
Fix trying to apply delta to a mix of scene components and non scene components. Its acceptable to not have scene components in the selected component list
#jira UE-57980
Change 4022021 by Rex.Hill
Fix for audio desync and video fast-forwarding behavior.
There long delay (500ms+) until samples start arriving unless we use RequestedTimeCurrent.
After delay occurs samples begin arriving at accelerated speed until caught up to playback time leading to visual and audio problems.
#jira UE-54592
Change 4023608 by Brandon.Schaefer
Downscale memory if we dont have enough
#jira UE-58073
#review-4023609 @Arciel.Rekman
Change 4025618 by Michael.Dupuis
#jira UE-58036: Apply world position offset correctly
Change 4025661 by Michael.Dupuis
#jira UE-57681: Added guard to prevent possible crash if either we have an invalid material or the material parent is invalid
Change 4025675 by Michael.Dupuis
#jira UE-52919: if no actor was found in the level skip moving the instances
Change 4026336 by Brandon.Schaefer
Manually generate *.sym files for Physx3
This should be done in the BuildPhysx file
Change 4026627 by Rex.Hill
Fix memory leak fix when playing video and main thread blocks
#jira UE-57873
Change 4029635 by Yannick.Lange
Fix VRMode loading assets only when VRMode starts.
#jira UE-57797
Change 4030288 by Jamie.Dale
Null FreeType face on load error to prevent potential crashes
Change 4030782 by Rex.Hill
Fix save BuildData after changing reflection capture in a new level
#jira UE-57949
Change 4033560 by Michael.Dupuis
#jira UE-57710: Added some guard to prevent crash/assert
Change 4034244 by Michael.Trepka
Copy of CL 4034116
Fixed arrow keys handling on Mac
Change 4034708 by Lauren.Ridge
PR #4699: UE-8508: Update config file to keep folder color in sync (Contributed by projectgheist)
#jira UE-58251
Change 4034746 by Lauren.Ridge
PR #4701: Add option to close tabs to the right of the active tab (Contributed by jesseyeh)
#jira UE-58277
Change 4034873 by Lauren.Ridge
Fix for not being able to enter simulate more than once in a row.
#jira UE-58261
Change 4034922 by Lauren.Ridge
PR #4387: Commands mapped in incorrect location (Contributed by projectgheist)
#jira UE-53752
Change 4035484 by Lauren.Ridge
Tentative fix for crash on pasting comment. All other accesses to UMaterialExpressionComment check its validity first
#jira UE-57979
Change 4037111 by Brandon.Schaefer
Try to use absolute path from dladdr if we can to find the sym files
#jira UE-57858
#review-4013964 @Arciel.Rekman
Change 4037366 by Brandon.Schaefer
Dont check the command line before its inited
#review-4037183 @Arciel.Rekman
#jira UE-57947
Change 4037418 by Alexis.Matte
Remove the checkSlow when adding polygon
Change 4037745 by Brandon.Schaefer
Use as much info as we can during ensure
Just as fast as the old way but with more information
#review-4037495 @Arciel.Rekman
#jira UE-47770
Change 4037816 by Rex.Hill
Import mesh optimization, BuildVertexBuffer
Change 4037957 by Arciel.Rekman
UBT: make it easier to try XGE on Linux.
Change 4038401 by Lauren.Ridge
Reordering is now correctly handled by undo. Reordering and then undoing will no longer cause a "ghost" widget to also be part of the tree.
#jira UE-58206
Change 4039612 by Anthony.Bills
Unix: Check for null StdOut and ReturnCode parameters, otherwise the code may dereference a null variable when the process fails to create.
Change 4039754 by Alexis.Matte
Remove the Render meshdescription, no need to carry this temporary data in the staticmesh
Change 4039806 by Anthony.Bills
Linux: UVS fixes
- Update to use new Unix base platform.
- Use bin/bash instead of usr/bin/bash (may need revisiting later).
- Recompile Shipping version with changes.
- Update Setup.sh to run from correct CWD (due to current limitations in the relative directory handling).
Change 4039883 by Lauren.Ridge
PR #4576: Save editor config to file first time a fav folder is added in the co. (Contributed by projectgheist)
#jira UE-56249
Change 4040117 by Lauren.Ridge
Replacing widgets should now also clear out references to the widget
#jira UE-57045
Change 4040790 by Lauren.Ridge
Tentative fix for Project Launcher crash when platform info not found
#jira UE-58371
Change 4042136 by Arciel.Rekman
UBT: refactor of LinuxToolChain to make it leaner and more configurable.
- Made it possible to override SDK passed to the toolchain.
- Simplified the code by using the same executable names on Windows and Linux (as .exe is optional), except where File.Exists() is needed (also remove a few)
- Some minor renames to make it clear that SystemSDK means system compiler (which otherwise may be unclear)
- Made changes to accomodate the new debug format.
Change 4042930 by Brandon.Schaefer
GCoreObjectArrayForDebugVisualizers was changed to FChunkedFixedUObjectArray reflect that in the Unix part
Change 4043539 by Brandon.Schaefer
Fix callsite address being used at times for the Program Counter
Fix only reporting the actual callstack and not the crash handling callstacks
#review-4041370 @Arciel.Rekman
#jira UE-58477
Change 4043674 by Arciel.Rekman
Added Linux ARM64 (AArch64) lib for MikkTSpace.
- Now required for standalone games due to EditableMesh runtime plugin.
Change 4043677 by Arciel.Rekman
Linux: updated ARM64 (AArch64) version of SDL2.
Change 4043690 by Arciel.Rekman
Linux: allow compiling VulkanRHI for AArch64 (ARM64).
Change 4045467 by Brandon.Schaefer
Add Anthony Bills SetupToolchain.sh script
Used to download the latest toolchain
Change 4045940 by Michael.Trepka
Return empty list instead of null from Mac GetDebugInfoExtensions() in UBT
#jira UE-58470
Change 4046542 by Alexis.Matte
Fix skeletal re-import material assignation
#jira UE-58551
Change 4048262 by Brandon.Schaefer
Rebuild SDL with pulse audio libs
#jira UE-58577
Change 3887093 by Anthony.Bills
Add bundled mono binary for Linux.
- Unify some of the script structure across Mac and Linux.
- This currently uses the same mono C# assemblies as Mac to keep the additional source size down.
- If the Mac mono version is updated, the Linux version will also need to be updated to match the same mono git revision.
- The system version of mono can still be used by setting the UE_USE_SYSTEM_MONO env var to 1.
Change 4003226 by Michael.Dupuis
Refactored StaticMeshInstancing to now use a command buffer to communicate with the GPU to prevent concurent access issues. It's mostly used in Editor or if runtime changes occur, otherwise the data is built and send to the GPU directly without keeping CPU copy.
Changed how the density scaling was applied to be more optimal
Removed UseDynamicInstanceBuffer as the concept is now irrelevant
Change 3833097 by Jamie.Dale
Localization Pipeline Optimization
Manifest/Archives:
Added FLocKey to keep an immutable string and its hash. This is used in several places within manifests and archives to minimize string hashing. FLocTextHelper also now take these in its API.
This also fixes some places where manifests were being iterated by key rather than source string (as this was causing redundant work).
Portable Object:
Cleaned up a lot of redundant code, changed things to use FLocKey, and simplified a lot of string manipulation to use algorithms instead (which proved to be faster).
Asset Gathering:
Optimized the way garbage collection runs while gathering from assets so that we avoid purging assets that we still need to gather from (or are still active dependencies). This also sorts the assets so that we can try and evict dependencies from memory as soon as possible (in much the same way that the cooker does).
Automation:
The gather commandlet can now take multiple configs to process. This is used by automation to avoid starting the editor several times (which can save a significant amount of start-up overhead).
[CL 4052378 by Lauren Ridge in Main branch]
2018-05-04 14:14:10 -04:00
TSharedPtr < SWidget > ButtonWidget = ButtonBoxChildren - > GetChildAt ( ButtonIndex ) ;
Copying //UE4/Dev-Editor to //UE4/Dev-Main (Source: //UE4/Dev-Editor @ 3133954)
#lockdown Nick.Penwarden
#rb none
==========================
MAJOR FEATURES + CHANGES
==========================
Change 3077573 on 2016/08/04 by Nick.Darnell
Removing some unused code, adding additional needed modules to editor tests.
#rb none
Change 3077580 on 2016/08/04 by Nick.Darnell
Removing the test plugins, going to be recreating them in EngineTest.
Change 3082659 on 2016/08/09 by Nick.Darnell
Automation - Presets are now stored in json files stored in Config so they can be shared, and human readable. Working on screenshot automation, getting it where it needs to be to permit us to have repeatable tests for comarison. Removing the option to not take full size screenshots, that defeats the purpose of being able to compare them.
#rb none
Change 3082766 on 2016/08/09 by Jamie.Dale
Fixed crashes when dealing with code-points outside the BMP on platforms with UTF-32 FStrings
ICU always deals with its offsets as UTF-16 (as it always uses UTF-16 internally with icu::UnicodeString), so there were a couple of places in code (break iteration, and bidi detection) where we needed to adjust those UTF-16 offsets to UTF-32 offsets in the case where FString is UTF-32.
#jira UE-33971
#rb James.Hopkin
Change 3083067 on 2016/08/09 by Nick.Darnell
Automation - Working on screenshot support, system now allows a lot more customization in terms of how large the shot is.
#rb none
Change 3084475 on 2016/08/10 by Richard.TalbotWatkin
Fixed issue with ModelComponent replication in client/server PIE if BSP is rebuilt. ModelComponent now implements IsNameStableForNetworking and always returns true, as a level's model components will never be rebuilt during a game session. Brush poly normals are now only fixed up in Editor builds.
#jira UE-34391 - No run animation on client that is not focused when running 2 player and dedicated server
#codereview Matt.Kuhlenschmidt
#rb none
Change 3084661 on 2016/08/10 by Matt.Kuhlenschmidt
Added grayscale texture importing support
#rb none
Change 3084774 on 2016/08/10 by Cody.Albert
Adding controller support for ComboBox widget
#jira UE-33826
#rb nick.darnell
Change 3085716 on 2016/08/11 by Nick.Darnell
UMG - Taking the Widget Component and Widget Interaction Components out of experimental. Removed old importing support for upgrading ancient versions of widget components. Removing parbola distortion, as users can now do whatever they want in their custom MID they can override the widget with.
#rb none
Change 3085733 on 2016/08/11 by Nick.Darnell
UMG - Documenting the meta parameters allowed on widgets, like we do for regular UObjects. For binding widgets from blueprints you can now do BindWidget (unchanged), and to simplify binding widgets optionally, you can now just do (BindWidgetOptional), rather than the combination of BindWidget + OptionalWidget=true. Made generating the Design time wrapper call a little more efficent, by optimizing it away by force inlining a noop. Also added some additional checking when we forcefully set focus in UMG, to help people catch cases where they set focus, but didn't make the widget focusable.
#rb none
Change 3085734 on 2016/08/11 by Nick.Darnell
Texture - Making GetDefaultMipMapBias a bit more efficent in the common case.
#rb none
Change 3085736 on 2016/08/11 by Nick.Darnell
Static Lighting - Warning the user when they build lighting, but have bForceNoPrecomputedLighting set to true on the world settings.
#rb none
Change 3085737 on 2016/08/11 by Nick.Darnell
Editor - code organization.
#rb none
Change 3085875 on 2016/08/11 by Nick.Darnell
UMG - You can now use 'G' to toggle game mode on the designer so that you can disable and enable the dashed lines around containers. The option in the settings is now used as the default when you startup a designer.
#rb none
Change 3086209 on 2016/08/11 by Ben.Salem
Make our automated test pass reporting more robust and pipe out to JSON in \saved\automation\logs\AutomationReport-{CL}-{Timestamp}.json format.
#rb adric.worley, william.ewen
Change 3086515 on 2016/08/11 by Nick.Darnell
Editor - Fixing a crash in the curve table customization. If the row doesn't exist, it would crash, we now protect against that case.
#rb Matt.Kuhlenschmidt
Change 3087216 on 2016/08/12 by Jamie.Dale
Fixed an issue where re-scanning a package file may leave old assets in the asset registry
We didn't used to clear out anything associated with the old package before scanning the file, which could result in old assets being left if they'd since been removed from the package.
This also exposes a PackageDeleted function to allow people to manually clear anything associated with a package (if doing some custom asset work).
#rb Andrew.Rodham
Change 3087219 on 2016/08/12 by Jamie.Dale
Updated TextRenderComponent to support multiple font pages
It used to use the correct UV data, but wouldn't set the correct texture page when rendering. It now creates MIDs for all of the texture pages used by the font, and will use these MIDs (which override the font page on the material) when rendering the text (batched on sequential index/vertex buffer data with the same texture page).
#rb Matt.Kuhlenschmidt
Change 3087308 on 2016/08/12 by Alex.Delesky
#jira UE-14727 - Support for editing TSet properties in the editor's Details panel has been added.
#rb Matt.Kuhlenschmidt
Change 3089140 on 2016/08/15 by Jamie.Dale
We now abort a directory watch if we lose access to the directory in question
This prevents an infinite loop in the call to MsgWaitForMultipleObjectsEx if a watched directory is deleted.
#jira UE-30172
#rb Andrew.Rodham
Change 3089148 on 2016/08/15 by Alexis.Matte
Allow fbx export of any actor type.
#rb none
#codereview dmitriy.dyomin
Change 3089211 on 2016/08/15 by Jamie.Dale
Unified access to the parent window for external dialogs
A lot of places used to ad-hoc use the MainFrame window, even when they had access to a widget that may be belong to a different window. This could cause issues where an external dialog could appear behind a modal UE4 window (as it would appear above the MainFrame), and be inaccessible.
You can now use IMainFrameModule::GetBestParentWindowHandleForDialogs to get the best window handle to use for an external dialog. This will either be the parent window for the given widget (if known), or failing that, the MainFrame window.
#rb Andrew.Rodham
Change 3089640 on 2016/08/15 by Jamie.Dale
Wrapped UMaterialExpression::MenuCategories in WITH_EDITORONLY_DATA to avoid gathering it for game-only loc
#rb none
Change 3089661 on 2016/08/15 by Nick.Darnell
Editor - There's a new view option "Show C++ Classes" in the content browser. Lets you hide all those C++ folders most folks probably don't care to see.
#rb none
Change 3089667 on 2016/08/15 by Cody.Albert
Updating RoutePointerUpEvent to call OnDrop for touch events when dragging
#jira UE-34709
#rb nick.darnell
Change 3089694 on 2016/08/15 by Jamie.Dale
Applied a fix to the ExcludeClasses setting in the loc gather
#rb none
Change 3089889 on 2016/08/15 by Nick.Darnell
Automation - Continued work on the screenshot portion of the automation system. Going to start using the adapter information in the screenshots taken, otherwise we can't accurately test a plethora of devices sharing the same OS, with different capabilities.
#rb none
Change 3090256 on 2016/08/16 by Nick.Darnell
Automation - working on screenshots.
#rb none
Change 3090322 on 2016/08/16 by Nick.Darnell
Automation - Adding modified screenshot function.
#rb none
Change 3090335 on 2016/08/16 by Nick.Darnell
Automation - The tests were determined to need to be shared afterall, but at least keeping them as plugins. Moved to Engine plugins.
#rb none
Change 3090881 on 2016/08/16 by Nick.Darnell
Automation - Moving the content over and fixing up some code so that the AutoRimport tests work as expected.
#rb none
Change 3090884 on 2016/08/16 by Nick.Darnell
Plugins - There's now support for generating a Content Only plugin from the new plugin wizard.
#rb none
Change 3090911 on 2016/08/16 by Nick.Darnell
Feature Packs - If there's an error loading a manifest, it's now an error, not a warning.
#rb none
Change 3090913 on 2016/08/16 by Jamie.Dale
Optimization and usability improvements of the MemoryProfiler2 tool
- Optimized the processing of the Callgraph, Histogram, and Short lived allocations views.
- The callgraph view is now using a virtualized tree view mapped to our own internal tree. This allows us to amortize the cost of adding nodes to the TreeView as the user views the nodes in the tree. In my own test, this took callgraph generation from ~45 seconds to ~5 seconds.
- The Histogram view was vastly optimized via the use of a HashSet on the callstack filter, and the batch addition of unsorted callstacks that are sorted once at the end. In my own test, this took histogram generation from ~15 minutes to ~2 seconds.
- The Short lived allocations view was optimized by avoiding redundant sorting, including maintaining a sorted order while inserting items, and instead doing a final sort at the end. The column selection was also optimized by avoiding copying the entire dataset just to resort it. In my own test, this took short lived allocation generation from ~1 minute to ~3 seconds.
- Added a user-configurable list of allocator functions to trim (which now includes FMemory and operator new by default, and produces much cleaner callstacks).
#jira UETOOL-948
#jira UETOOL-949
#rb James.Hopkin
Change 3090962 on 2016/08/16 by Jamie.Dale
Fixed double assignment of filter functions
#rb none
Change 3090989 on 2016/08/16 by Nick.Darnell
Editor - Attempting to fix the build, non-unity issue I suspect.
#rb none
Change 3091754 on 2016/08/17 by Nick.Darnell
FbxAutomationTestBuilder is now a plugin. Users won't see it unless they've enabled the plugin (so primarily internal QA). Reorganized the automation tools and testing menu to be a bit lower in the main menu, and gave them a more test sounding name. Additionally made some modifications to the workspace menu structure to allow generating just a subset of a workplace menu so that I could target where I wanted to insert all of the automation tool menu items, rather than just allowing the general placement of them under developer tools...etc.
#rb none
#codereview Alexis.Matte
Change 3091758 on 2016/08/17 by Nick.Darnell
Slate / Editor - Trying to make the editor less focus greedy. Now when there are notification popups and tabs attempt to grab your attention we now do a few activation ownership checks to ensure that it or a parent window actually owns activation. Not doing this has the nasty side effect of things like notifications and message log errors that popup while playing the game (if the game is in new window PIE), causing the game to be hidden, and focus returned to the editor. Ran into this a lot running the automation tests, the new PIE window that's launched to run tests is immediately hidden as soon as the tests log a warning or error or a notification about high res screenshots happens.
#rb none
#codereview Nick.Atamas,Matt.Kuhlenschmidt
Change 3091829 on 2016/08/17 by Nick.Darnell
Build - Attempting to repair the build.
#rb none
Change 3091920 on 2016/08/17 by Nick.Darnell
Build - Another attempt at fixing the mac build.
#rb none
Change 3093380 on 2016/08/18 by Matt.Kuhlenschmidt
Ignore group actors when checking for references to other actors when deleting. The check for references is designed for gameplay affecting references which groups are not. Having this show up for groups is annoying
#rb none
Change 3094474 on 2016/08/19 by Jamie.Dale
Fixed PS4 error when building with USE_MALLOC_PROFILER, and optimized symbol name resolution for a build with USE_MALLOC_PROFILER enabled
#jira UETOOL-951
#rb James.Hopkin
Change 3094581 on 2016/08/19 by Jamie.Dale
Added missing allocator filter needed by PS4 profiles
#rb none
Change 3094681 on 2016/08/19 by Richard.TalbotWatkin
Fixed issue where painting override vertex colors on a SpeedTree mesh would cause its wind animation to cease. The OverrideVertexColors vertex factory needed to be registered with the SpeedTree renderer.
#jira UE-32762 - Custom VertexPaint on SpeedTrees interferes with wind animation
#rb none
Change 3095163 on 2016/08/19 by Trung.Le
#jira UE-20849: Added tooltips to the inputs of the Material final result node
#rb matt.kuhlenschmidt
Change 3095285 on 2016/08/19 by Trung.Le
#jira UE-20849 In SGraphNodeMaterialResult, renamed ToolTip to ToolTipWidget so we're not hiding class member
#rb none
Change 3095344 on 2016/08/19 by Alexis.Matte
#jira UE-34690 When using the optionnal matrix to change the scene root node, we have to flush the fbx evaluation engine.
Add also a new option to allow the user to automatically convert the fbx scene to unreal unit (centimeter).
#rb none
#codereview matt.kuhlenschmidt
Change 3096162 on 2016/08/22 by Alexis.Matte
#jira UE-34763 Remove offending no-action combo box entry when the json file is readonly. Also clean up other combo box menu.
#rb none
#codereview matt.kuhlenschmidt
Change 3096261 on 2016/08/22 by Alexis.Matte
#jira UE-33121 Make sure re-import all and import all fix all the issue before starting the job. So it get not interrupt during the process.
#rb lina.halper
#codereview lina.halper
Change 3096344 on 2016/08/22 by Jamie.Dale
NSString conversion fix for UTF-32 strings containing characters outside of the BMP
#jira UE-33971
#rb Peter.Sauerbrei, James.Hopkin
Change 3096605 on 2016/08/22 by Alex.Delesky
#jira UE-34787 - Dropdown menus in standalone programs will now correctly display tooltips if they have any.
#rb Matt.Kuhlenschmidt
Change 3096615 on 2016/08/22 by Alex.Delesky
#jira UE-33334 - Scrolling up on the mouse wheel when using the orbit camera should no longer move away from the orbit point when the camera moves too close to the orbit origin.
#rb Matt.Kuhlenschmidt
Change 3096619 on 2016/08/22 by Alex.Delesky
#jira UE-34084 - Structs containing an enum with a value that contains a whitespace character will now serialize correctly when copied from the Details Panel.
#rb Matt.Kuhlenschmidt
Change 3097644 on 2016/08/23 by Matt.Kuhlenschmidt
PR #2729: Fix a typo in the comment (Contributed by adcentury)
#rb none
Change 3097648 on 2016/08/23 by Matt.Kuhlenschmidt
PR #2726: Undef unused macros (Contributed by shrimpy56)
#rb none
Change 3097697 on 2016/08/23 by Matt.Kuhlenschmidt
Guard against crash when details panels rebuild when their customizations have been torn down
https://jira.ol.epicgames.net/browse/UE-35048
#rb none
Change 3097757 on 2016/08/23 by Alex.Delesky
#jira UE-14727 - Support for editing TMap properties in the editor's Details panel has been added. This change also removes the Duplicate option from TSet elements, and disallows entry of duplicates elements into a TSet or duplicate keys into a TMap
#rb Matt.Kuhlenschmidt
Change 3098164 on 2016/08/23 by Alexis.Matte
#jira UE-34686 Fbx importer bImportMeshesInBoneHierarchy is used also by the animation.
#rb none
#codereview matt.kuhlenschmidt
Change 3098502 on 2016/08/23 by Alexis.Matte
#jira UE-30951 Fbx option dialog, we disable the option to bake pivot if transform vertex position is true
#rb none
#codereview matt.kuhlenschmidt
Change 3099986 on 2016/08/24 by Jamie.Dale
Fixing non-editor builds
#rb none
Change 3101138 on 2016/08/25 by Matt.Kuhlenschmidt
Fixed viewport redraw callback not being called when certian property modifications occur in the details panel (reset to default, array size changes, etc)
#rb none
Change 3101280 on 2016/08/25 by Jamie.Dale
Fixed crash when counting memory over internationalization meta-data
- The serialization code only used to handle loading or saving, now it handles loading or not loading.
- The Type of the meta-data wasn't set by all constructors. For safety it has been removed and replaced with a virtual function that the derived types override.
#rb James.Hopkin
Change 3101283 on 2016/08/25 by Jamie.Dale
MProf2 platform and symbol parsing improvements
- Updated ISymbolParser to work with lazy symbol resolution (handled via the UI when looking at full callstacks).
- Added a PS4 symbol parser which handles performing full file/line resolution for symbols.
- Removed all the V3 file format support and legacy platform handling.
- Optimized FStreamInfo.GetNameIndex so it can be used by the lazy symbol fixup.
#rb James.Hopkin
Change 3101586 on 2016/08/25 by Jamie.Dale
Small code cleanup and path normalization
#rb James.Hopkin
Change 3101837 on 2016/08/25 by Alexis.Matte
#jira UE-35101 we now store the sourceanimationname to retrieve the correct animtrack when re-importing animations
#rb none
#codereview matt.kuhlenschmidt
Change 3102537 on 2016/08/26 by Jamie.Dale
Fix for potential crash in FICUCamelCaseBreakIterator
In platforms with UTF-32 strings, the index returned by FICUTextCharacterIterator may not be in the same range as FString, so we need to call InternalIndexToSourceIndex to ensure that it is.
#rb James.Hopkin
Change 3102582 on 2016/08/26 by Matt.Kuhlenschmidt
Log the freetype version when it starts up (for debugging purposes)
#rb none
Change 3102657 on 2016/08/26 by Alexis.Matte
#jira UE-29177 When re-importing a texture we want to notify materials using this texture so they can recompile the shader.
#review-3101585 @uriel.doyon
#rb matt.kuhlenschmidt
Change 3102704 on 2016/08/26 by Jamie.Dale
Added symbol meta-data support to MProf2
You can now define platform specific meta-data using FPlatformStackWalk::GetSymbolMetaData, which is then stored within the generated .mprof file.
PS4 uses this meta-data to say where the original .self file can be found, so that MProf2 can usually automatically load the .self file without having to bother the user.
#rb James.Hopkin
Change 3102878 on 2016/08/26 by Matt.Kuhlenschmidt
Added support for outline fonts
- An outline size (in slate units), optional material and optional fill color can be specified with each font info.
- Outlines do not contribute to measurement directly so the text measuring and shaping methods have been modified to account for outlines
- Fixed a bug where font materials do not work properly if part of the font's rendered glyphs were in a different atlas
#rb jamie.dale
Change 3102879 on 2016/08/26 by Jamie.Dale
Bumped the MProf2 version so we can tell which build of the tool can load v6 mprof files
#rb none
Change 3102960 on 2016/08/26 by Alexis.Matte
build fix
#rb none
Change 3103032 on 2016/08/26 by Jamie.Dale
Fixed SEditableText and SMultiLineEditableText not setting the correct foreground color when painting
#jira UE-34936
#rb Matt.Kuhlenschmidt
Change 3103278 on 2016/08/26 by Jamie.Dale
Fixing Clang warnings
#rb none
Change 3104211 on 2016/08/29 by Ben.Marsh
Add build script for automated tests, and create settings file for Dev-Editor which adds an agent pool for running them.
#rb none
Change 3104290 on 2016/08/29 by Alex.Delesky
Adding additional documentation accessible from the editor for TSet and TMap properties, along with a quick clarification on container properties to let the user know what kind of container they're working with.
#rb Matt.Kuhlenschmidt
Change 3104292 on 2016/08/29 by Alex.Delesky
#jira UE-35039 - Command/Control user keybindings will no longer flip-flop when the editor is opened on Mac.
#rb Matt.Kuhlenschmidt
Change 3104294 on 2016/08/29 by Alex.Delesky
#jira UE-34952 - The user will no longer encounter an ensure when setting the value of Period equal to or less than 0 on the circular throbber widget
#rb Matt.Kuhlenschmidt
Change 3104295 on 2016/08/29 by Matt.Kuhlenschmidt
PR #2682: Remove unused bUseDesktopResolutionForFullscreen (Contributed by stfx)
#rb none
Change 3104296 on 2016/08/29 by Alex.Delesky
#jira UE-35160 - The Auto Distance Error for LOD meshes can now be set to any value larger than zero.
#rb Matt.Kuhlenschmidt
Change 3104348 on 2016/08/29 by Matt.Kuhlenschmidt
Added the ability to clear the preview mesh on a material instance. Previously there was no way to null it out.
#rb none
Change 3104355 on 2016/08/29 by Matt.Kuhlenschmidt
Guard against crash with invalid path to the default physical material. Just create a new one if it doesnt exist and warn about it.
#rb none
#jira UE-31865
Change 3104396 on 2016/08/29 by Ben.Marsh
Fix incrorrect agent names for running automated tests
Change 3104610 on 2016/08/29 by Alex.Delesky
Fix for AutomationTool compile editor from changes introduced today.
#rb None
Change 3104611 on 2016/08/29 by Michael.Dupuis
#jira UETOOL-253
#rb Alexis.Matte
Change 3105826 on 2016/08/30 by Gareth.Martin
Added console variables to discard grass and/or scalable foliage data on load
#jira UE-35086
#rb Benn
Change 3106126 on 2016/08/30 by Matt.Kuhlenschmidt
Eliminated bad code duplication between retainer widgets and element batcher
#rb none
#codereview nick.darnell
Change 3106449 on 2016/08/30 by Michael.Dupuis
#jira UETOOL-229 Added generic command icons used in Edit Menu (including contextual menu)
#rb Alexis.Matte
Change 3106966 on 2016/08/30 by Jamie.Dale
Fixed FApp::IsAuthorizedUser not considering the SessionOwner override
#rb Max.Preussner
Change 3107687 on 2016/08/31 by Michael.Dupuis
Checkout/Make Writable on proper config file
#rb Matt Kuhlenschmidt
Change 3107736 on 2016/08/31 by Matt.Kuhlenschmidt
Fixed mode typos in the lerp instruction
#rb none
Change 3107830 on 2016/08/31 by Matt.Kuhlenschmidt
Logging and guard against UEditorEngine::TeardownPlaySession crash.
#rb none
https://jira.ol.epicgames.net/browse/UE-35325
Change 3107912 on 2016/08/31 by Alex.Delesky
#jira UE-35181 - Normalizing paths when retrieving absolute filenames for source control operations.
#rb Matt.Kuhlenschmidt
Change 3107986 on 2016/08/31 by Matt.Kuhlenschmidt
Removed PropertyTestObject.h out of UnrealEd.h so you dont have to compile the entire editor when changing this one file.
#rb none
Change 3108027 on 2016/08/31 by Chris.Wood
Re-added lost doc comment for analytics event "Engine.AbnormalShutdown".
#rb none - just a comment in a cpp file
#codereview wes.hunt
Change 3108580 on 2016/08/31 by Mike.Fricker
Deleted the "Live Editor" plugins from UE4
- These were undocumented, buggy and never finished, and we have no plans to complete them
- Both the "LiveEditor" and "LiveEditorListenServer" plugins were deleted, along with related icon files
#codereview matt.kuhlenschmidt
#rb matt.kuhlenschmidt
Change 3108604 on 2016/08/31 by Mike.Fricker
Added new "MIDI Device" plugin (disabled by default)
- This is a simple MIDI interface that allows you to receive MIDI events from devices connected to your computer
- Currently only input is supported. In the future we might allow for output, as well.
- In Blueprints, here's how to use it:
- Look for "MIDI Device Manager" in the Blueprint RMB menu
- Call "Find MIDI Devices" to choose your favorite device. Break the "Found MIDI Device" struct to see what's available.
- Then call "Create MIDI Device Controller" for the device you want. Store that in a variable.
- On your MIDI Device Controller, bind your own Event to the "On MIDI Event" event. This will be called every game Tick when there is at least one new MIDI event to receive.
- Process the data passed into the Event to make your project do stuff!
- This plugin makes use of the "PortMidi" third party library (which already existed in UE4 -- it was used by the now-deprecated 'LiveEditor' plugin)
#codereview matt.kuhlenschmidt
#rb none
Change 3108760 on 2016/08/31 by Alexis.Matte
#jira UE-25840 Fbx export collision mesh, we now export collision: box, sphere, capsule and convex mesh. There is an option in the editor preference to enable the export of collisions, default value is false.
#rb none
#codereview matt.kuhlenschmidt
Change 3109006 on 2016/08/31 by Alex.Delesky
#ignore Source Control rename test - initial commit
Change 3109044 on 2016/08/31 by Alex.Delesky
#ignore Testing asset rename from P4 to observe correct behavior.
#rb none
Change 3109048 on 2016/08/31 by Alex.Delesky
#ignore Testing P4 rename to identify correct behavior
#rb none
Change 3110044 on 2016/09/01 by Gareth.Martin
Fixed painting foliage on blocking "query" actors not working
#jira UE-33852
#rb Allan.Bentham
Change 3110133 on 2016/09/01 by Alexis.Matte
Fix crash in function GetForceRecompileTextureIdsHash
#rb none
#codereview jamie.dale
Change 3111848 on 2016/09/02 by Mike.Fricker
MIDI Device plugin: Fixed compilation error on Clang compilers (Mac, Linux)
- Fixed bad enum cast
#rb none
Change 3111995 on 2016/09/02 by Michael.Dupuis
#jira UE-35263
Do not try selecting the actor if the actor is in the blueprint
Properly Refresh the ToopTip & Hyper Link to take into account blueprint recreation process
#rb Alexis Matte
Change 3112280 on 2016/09/02 by Michael.Dupuis
Call MakeWritable if source control fail
#rb Alexis Matte
Change 3112335 on 2016/09/02 by Cody.Albert
Updating cursor hiding logic to not improperly hide cursor when left clicking in ortho mode
#jira UE-35306
#rb none
Change 3112478 on 2016/09/02 by Alexis.Matte
#jira UE-20059 Use a base material to import fbx material.
#rb uriel.doyon
#codereview matt.kuhlenschmidt
#1468 Github pull request number
Change 3113912 on 2016/09/06 by Michael.Dupuis
#jira UE-32288 Fixed Console params display
#rb Alexis Matte
Change 3114026 on 2016/09/06 by Alex.Delesky
#jira UE-35123 - The Details panel in a Texture editor or Simple Asset editor window will no longer disappear when the inspected asset is imported again.
#rb Matt.Kuhlenschmidt
Change 3114032 on 2016/09/06 by Alex.Delesky
PR #2733: Improved the project launcher progress page (Contributed by projectgheist)
#jira UE-34027
#rb Matt.Kuhlenschmidt
Change 3114034 on 2016/09/06 by Alex.Delesky
#jira UE-35265 - Copying a comment node from a Material Function and pasting it inside a Material will no longer render the Material unsaveable
#rb Matt.Kuhlenschmidt
Change 3114071 on 2016/09/06 by Nick.Darnell
[AUTOMATED TEST] Automatic checkin, testing functionality.
Change 3114109 on 2016/09/06 by Nick.Darnell
[AUTOMATED TEST] Automatic checkin, testing functionality.
Change 3114562 on 2016/09/06 by Nick.Darnell
Adding LevelEditor to the FbxAutomationTestBuilder to fix a compiler issue.
#rb none
Change 3114701 on 2016/09/06 by Michael.Dupuis
#jira UE-31988 add const to all usage of TArray<ItemType>* as it was done in SListView
#rb Alexis Matte
Change 3114861 on 2016/09/06 by Matt.Kuhlenschmidt
Prevent non-thread safe slate code from running on the slate loading thread
#rb none
Change 3115698 on 2016/09/07 by Nick.Darnell
Make sure the commands are available - during functional testing that was found to not always be the case.
#rb none
Change 3115719 on 2016/09/07 by Nick.Darnell
Adding an IsRegistered command to commands.
#rb none
Change 3115721 on 2016/09/07 by Nick.Darnell
Adding a new built VirtualReality feature pack, this new one contains the update manifest that will parse correctly.
#rb none
Change 3115722 on 2016/09/07 by Nick.Darnell
IsBindWidgetProperty now returns false if the property passed in is null.
#rb none
Change 3115734 on 2016/09/07 by Alexis.Matte
#jira UE-30166 Support fbx sdk 2017
#rb none
Change 3115737 on 2016/09/07 by Nick.Darnell
Adding an image comparer for screenshots. Removing some content from EngineTest.
#rb none
Change 3115743 on 2016/09/07 by Nick.Darnell
Checkpointing a bunch of progress towards a screenshot comparison workflow that allows us to diff screenshots taken on various platforms and hardware. Disabling many tests that are not passing. Updating a few tests to log better errors, and fixed a few tests with easy bugs in them so they would start passing again. All editor tests currently passing!
#rb none
Change 3115748 on 2016/09/07 by Nick.Darnell
Making the RuntimeTests plugin a Developer module, so that it doesn't get included in shipping builds.
#rb none
Change 3115789 on 2016/09/07 by Jamie.Dale
We now favor Traditional Chinese for Hong Kong and Macau
#rb James.Hopkin
Change 3115799 on 2016/09/07 by Jamie.Dale
Removed validity check on source cultures when remapping, as platforms may use invalid cultures that need to be remapped
#rb James.Hopkin
Change 3115826 on 2016/09/07 by Nick.Darnell
Adding missing files.
#rb none
Change 3115838 on 2016/09/07 by Nick.Darnell
Back out revision 6 from //UE4/Dev-Editor/Engine/Source/Runtime/UMG/Public/Components/WidgetInteractionComponent.h
#rb none
Change 3116007 on 2016/09/07 by Alexis.Matte
build fix
#rb none
Change 3116057 on 2016/09/07 by Jamie.Dale
Fixed widget snapshot messages so they appear in the message debugger
#rb none
Change 3116112 on 2016/09/07 by Nick.Darnell
Removing the FbxAutomationBuilder file that go recreated on a merge from main.
#rb none
Change 3116365 on 2016/09/07 by Michael.Dupuis
#jira UE-20765 Added missing class flag to test (CLASS_CONFIG) and change a bit how the checkout/make writable work.
#codereview Matt.Kuhlenschmidt
#rb Alexis.Matte
Change 3116622 on 2016/09/07 by Alexis.Matte
#jira UE-35608 Use the same naming convention when trying to retrieve uv channel by name.
#rb matt.kuhlenschmidt
Change 3116638 on 2016/09/07 by Jamie.Dale
Ensured that manifests and archives don't try and load data that they can't parse
#rb none
Change 3117397 on 2016/09/08 by Gareth.Martin
Added rotate and blend support to the landscape mirror tool
#jira UE-34829
#rb Jack.Porter
Change 3117459 on 2016/09/08 by Gareth.Martin
Fixed crash saving a hidden landscape level with an offset (cloned from 4.13.1)
#jira UE-35301
#rb Jack.Porter
Change 3117462 on 2016/09/08 by Gareth.Martin
Fixed invisible landscape components and crashes when tessellation is enabled (cloned from 4.13.1)
#jira UE-35494
#rb Benn.Gallagher
Change 3117583 on 2016/09/08 by Nick.Darnell
Continued work on automation support for screenshot comparison, stubbing in a commandlet that can be run after automation tests that would perform the diffing. Need to finish rigging it up so that deltas and results can be dumped out somewhere and consumed by a tool to approve shots.
#rb none
Change 3117595 on 2016/09/08 by Nick.Darnell
Updating the build script for AutomatedTests, going to see if this works!
#rb none
Change 3117808 on 2016/09/08 by Nick.Darnell
Adding header includes for async.
#rb none
Change 3117812 on 2016/09/08 by Matt.Kuhlenschmidt
Partially taken from Pr 2381
Fixed Array Properties to handle duplicates properly and fixed Material Parameter Collection duplicate Guid problem.
#rb none
Change 3117851 on 2016/09/08 by Jamie.Dale
Silenced some redundant P4 errors that could be generated when running a stat update on a file
Some of the options produced errors when working with newly added files. These errors are now downgraded to infos like they are for the main stat command.
#rb Ben.Marsh
#codereview Thomas.Sarkanen
Change 3117853 on 2016/09/08 by Gareth.Martin
Clean up landscape includes and PCH
#rb steve.robb
Change 3117859 on 2016/09/08 by Alex.Delesky
#jira UE-35321 - Minimized windows will no longer act like they are visible when determining what widgets are currently underneath the mouse.
#rb Nick.Darnell
Change 3117997 on 2016/09/08 by Nick.Darnell
Updating the automation tests build script to use Editor-Cmd
#rb none
Change 3118005 on 2016/09/08 by Matt.Kuhlenschmidt
Properly reference graph node on material expressions so they are not GC'd while an expression still uses them
#jira UE-35362
#rb none
Change 3118043 on 2016/09/08 by Alex.Delesky
#jira UE-30649 - Removed unnecessary returns from UWidget API.
PR #2377: fix widget bug. (Contributed by dorgonman)
#rb none
Change 3118045 on 2016/09/08 by Matt.Kuhlenschmidt
Guard against crash saving config during level editor shutdown
#rb none
#jira UE-35605
Change 3118074 on 2016/09/08 by Matt.Kuhlenschmidt
PR #2783: Removed #pragme once from CPP files (Contributed by projectgheist)
#rb none
Change 3118078 on 2016/09/08 by Michael.Dupuis
#jira UE-32065 Removed the -windows that was added as a default option and add it simply if fullscreen is not specified
#rb Alexis.Matte
Change 3118080 on 2016/09/08 by Michael.Dupuis
#jira UE-31131 Do not show a contextual menu if the menu is empty
#rb Alexis.Matte
Change 3118087 on 2016/09/08 by Matt.Kuhlenschmidt
Constify this method
#rb none
Change 3118166 on 2016/09/08 by Nick.Darnell
Trying additional command options for the build machine for automation.
#rb none
Change 3118222 on 2016/09/08 by Matt.Kuhlenschmidt
Fix actor delete during mesh paint not working during undo
#rb none
#jira UE-35684
Change 3118298 on 2016/09/08 by Alexis.Matte
#jira UE-35302 Export all LODs for static mesh when there is no force LOD
#rb uriel.doyon
Change 3118325 on 2016/09/08 by Matt.Kuhlenschmidt
Fixed reset to default not appearing for slate brushes
#rb none
#jira UE-34958
Change 3119321 on 2016/09/09 by Matt.Kuhlenschmidt
Guard against crash with an invalid world trying to be opened from the content browser
#rb none
https://jira.ol.epicgames.net/browse/UE-35712
Change 3119433 on 2016/09/09 by Nick.Darnell
Removing a hack added by Paragon that prevents applications from resizing in real time as the user drags the size of the window around.
#rb Matt.Kuklenschmidt
#jira UE-35789
Change 3119448 on 2016/09/09 by Alex.Delesky
When simulating touch events using the mouse, clicking the mouse will no longer let a drag operation continue. This should also allow the finger that started a drag to continue dragging items until it is released from the surface.
#rb Nick.Darnell
Change 3119522 on 2016/09/09 by Jamie.Dale
Fixed FDetailCategoryImpl::ShouldBeExpanded not honoring bShouldBeInitiallyCollapsed when bRestoreExpansionState was true
#rb Matt.Kuhlenschmidt
Change 3119528 on 2016/09/09 by Jamie.Dale
Some UI re-work to the localization dashboard
This makes a better use of the available space, and will make it easier to make some other planned changes in the future.
#rb James.Hopkin
Change 3119861 on 2016/09/09 by Michael.Dupuis
#jira UE-9284 Added the Play/Stop button on the thumbnail
#rb Alexis.Matte
Change 3120027 on 2016/09/09 by Alexis.Matte
incorporate some fixes from licensee for LOD group re-import workflow
#jira UE-32268
#rb uriel.doyon
#codereview matt.kuhlenschmidt
Change 3120845 on 2016/09/12 by Gareth.Martin
Fixed crash in landscape editor when "Early Z" is enabled (cloned from 4.13.1)
#jira UE-35850
#rb Allan.Bentham
Change 3120980 on 2016/09/12 by Nick.Darnell
Adding a commandlet that is runnable for comparing screenshots. Adding comparing and exporting capability to the screenshot manager.
#rb none
Change 3120992 on 2016/09/12 by Alex.Delesky
#jira UE-35575 - TScriptInterface UProperties now have asset picker support.
#rb Matt.Kuhlenschmidt
Change 3121074 on 2016/09/12 by Michael.Dupuis
#jira UE-30092
Added path length in error message when typing
Added display of current filepath lenght for cooking
#rb Alexis.Matte
Change 3121113 on 2016/09/12 by Nick.Darnell
Adding some placeholder examples to show people how to author tests in EngineTest.
#rb none
Change 3121152 on 2016/09/12 by Gareth.Martin
Added TElementType, TIsContiguousContainer traits
Added GetData(), GetNum() generic functions
#rb Steve.Robb
Change 3121702 on 2016/09/12 by Jamie.Dale
Optimized a loop over a sorted list to instead use a binary search
This speeds up the short-lived allocation view generation.
We also now dump the exception information to the Trace log when in a non-debug build.
#rb James.Hopkin
Change 3121721 on 2016/09/12 by Jamie.Dale
We now set the window mode first when resizing the game viewport to ensure that the work area is correct
Fullscreen windows can affect the available work area size, which can break centering when moving between fullscreen and windowed mode.
#jira UE-32842
#rb Matt.Kuhlenschmidt
Change 3122578 on 2016/09/13 by Jamie.Dale
Small code clean up
Removed a use of the placement new style array addition.
#rb none
Change 3122634 on 2016/09/13 by Jamie.Dale
We now immediately update DefaultConfigCheckOutNeeded when checking out/making writable the config file, rather than wait for the text tick
#jira UE-34865
#rb James.Hopkin
Change 3122656 on 2016/09/13 by Jamie.Dale
Fixed array combo button not focusing its contents, which prevented the menu closing correctly
#jira UE-33667
#rb none
Change 3122661 on 2016/09/13 by Nick.Darnell
Checkpointing additional work on the screenshot compare dialog, moving some Directory path picker widget into a more common area. Moving some "Find the best top level window handle for this widget for dialogs' code out of the main frame module and into Slate Application where it probably belongs.
#rb none
Change 3122678 on 2016/09/13 by Jamie.Dale
Fixing CIS error on Clang
CoreUObject needs to be included before USTRUCT can be used.
#rb none
Change 3122686 on 2016/09/13 by Jamie.Dale
Fixing CIS error on Clang
CoreUObject needs to be included before UCLASS can be used.
#rb none
Change 3122728 on 2016/09/13 by Nick.Darnell
UMG - Exposing a trace channel for the WIC, defaults to Visibility. Improving how the WIC handles the cursor moving off the widget, it now maintains the last hit location rather than 0,0 which would cause things like dragged Sliders to reset to the left. Ideally - the WIC would know the underlying widget has capture and continue to fake collision against an imaginary plane to simulate a continuous surface.
#jira UE-35167
#rb none
Change 3122775 on 2016/09/13 by Nick.Darnell
Automation - Fixing an error with the ScreenshotTools plugin, needed to add an the include for Engine.h to the PCH.
#rb none
Change 3122779 on 2016/09/13 by Nick.Darnell
Widgetnimation - Exposing more of the class to C++.
#rb none
Change 3122793 on 2016/09/13 by Nick.Darnell
Fixing a crash in UWidgetComponent::UpdateRenderTarget updating a null material instance.
#jira UE-35796
#rb none
Change 3122834 on 2016/09/13 by Matt.Kuhlenschmidt
Fixed crash undoing moves after bsp creation
https://jira.ol.epicgames.net/browse/UE-35880
#rb none
Change 3122835 on 2016/09/13 by Nick.Darnell
Reverting changes to WIdgetAnimation
#rb none
Change 3122897 on 2016/09/13 by Matt.Kuhlenschmidt
Fixed non-editor compile error
#rb none
Change 3122988 on 2016/09/13 by Alexis.Matte
Material workflow refactor
#jira UETOOL-774
#rb matt.kuhlenschmidt
Change 3123006 on 2016/09/13 by Jamie.Dale
Fixed dynamic collections not returning anything
#jira UE-35869
#rb James.Hopkin
Change 3123145 on 2016/09/13 by Alexis.Matte
Fix fbx automation test. The test found a regression cause by CL: 3120027. In the case where we dont have a LODGroup we dont want to add LODs before the build.
#jira UE-32268
#rb none
#codereview matt.kuhlenschmidt
Change 3123148 on 2016/09/13 by Matt.Kuhlenschmidt
Fix fortnite compile error
#rb alexis.matte
Change 3123208 on 2016/09/13 by Jamie.Dale
The 'find culprit' dialog now honors the user choice
#rb RichTW
Change 3123545 on 2016/09/13 by Nick.Darnell
Slate - Adjusting the window dialog host finding code to do a better job of searching for slate windows and excluding popups and non-regular windows.
#rb none
Change 3124494 on 2016/09/14 by Jamie.Dale
Added ~ to the list of invalid characters for object/package names
#jira UE-12908
#rb Matt.Kuhlenschmidt
Change 3124513 on 2016/09/14 by Gareth.Martin
Implemented filter to allow painting foliage on other foliage
- Altered foliage filters so it will no longer paint on object types which don't have a filter, e.g. skeletal meshes
#rb Allan.Bentham
#2472
Change 3124523 on 2016/09/14 by Jamie.Dale
PR #2724: Fix ScrollBox right mouse/touch grab scrolling functionality (Contributed by aarmbruster)
#jira UE-34811
#jira UE-32082
#rb none
Change 3124607 on 2016/09/14 by Nick.Darnell
UMG - Adding BoundsScale support to the WidgetComponent's CalcBounds function.
#jira UE-35667
#rb none
Change 3124785 on 2016/09/14 by Gareth.Martin
Made some foliage functions editor-only to fix non-editor build
#rb none
Change 3124795 on 2016/09/14 by Gareth.Martin
Saved/loaded the new foliage filter
#rb Allan.Bentham
#2472
Change 3124915 on 2016/09/14 by Michael.Dupuis
#jira UE-19511
Add support for Add to source control on DefaultEditorPerProjectUserSettings file
Remove CheckoutNotice when not editing a DefaultXXXX.ini file
Edit proper config file either we're modifying settings from a Default file or Local user file
#codereview Matt.Kuhlenschmidt Max.Preussner
#rb Alexis.Matte
Change 3125266 on 2016/09/14 by Jamie.Dale
Fixed ULocalizationTarget::DeleteFiles not deleting cultures, and using SCC wrong
#rb none
Change 3125385 on 2016/09/14 by Matt.Kuhlenschmidt
Fix crash when using SaveAs to save over top of an existing level
#rb none
https://jira.ol.epicgames.net/browse/UE-35919
https://jira.ol.epicgames.net/browse/UE-35921
Change 3125487 on 2016/09/14 by Alexis.Matte
Fix cook content, regression induce by the material workflow refactor
#rb matt.kuhlenschmidt
Change 3126217 on 2016/09/15 by Gareth.Martin
Unset bHasPerInstanceHitProxies on landscape grass components, as they don't have individually editable instances
#rb Allan.Bentham
Change 3126311 on 2016/09/15 by Jamie.Dale
Placement mode fixes
- The display name is now cached correctly on construction, and the FPlaceableItem instance used with SPlacementAssetEntry is now const.
- Ensured that the ID used by FPlaceableItem could never overflow.
- Fixed some types being missing from the "All Classes" list.
- Fixed the escape key not cancelling the search.
#jira UE-35972
#rb James.Hopkin
Change 3126325 on 2016/09/15 by Jamie.Dale
Made sure that UWorld::GetAssetRegistryTags called its Super function so that properties tagged as AssetRegistrySearchable will be added.
#rb Andrew.Rodham
Change 3126403 on 2016/09/15 by Gareth.Martin
Added Find and Contains functions to TBitArray
#rb Steve.Robb
Change 3126405 on 2016/09/15 by Gareth.Martin
Allowed instances of Hierarchical Instanced Mesh Components to be moved around with the transform widget in the blueprint editor
- Just like regular instanced mesh components!
Also fixed not being able to move instances of an instanced mesh component when it is the root component
Also also fixed Hierarchical Instanced Mesh Components not flushing their async tree build on saving (this was causing log spam from PostLoad when dragging instances around as the blueprint would constantly reinstance the component before the async tree build had finished)
#jira UE-29357
#rb Allan.Bentham
Change 3126444 on 2016/09/15 by Jamie.Dale
Fixed the loc dashboard configs not working with SCC
This isn't a great solution, but the whole way the loc dashboard manages its config data is in need of an overhaul.
#rb none
Change 3126446 on 2016/09/15 by Jamie.Dale
Fixed loc dashboard game and engine targets sharing the same expansion settting
#rb none
Change 3126555 on 2016/09/15 by Chris.Wood
Removed WER from Windows crash handling. Crashes saved to log folder and passed to CRC with explicit path.
[UE-34470] - Investigate WER settings and if they can conflict with CRC on Windows
#rb Steve.Robb
Change 3126586 on 2016/09/15 by Gareth.Martin
Fixed missing landscape components when using a LODBias (cloned from 4.13.1)
#jira UE-35873
#rb Jack.Porter
Change 3126610 on 2016/09/15 by Jamie.Dale
Stopped PS4 from always staging all ICU data files
#rb Marcus.Wassmer
Change 3126779 on 2016/09/15 by Michael.Dupuis
#jira UE-32914 Improve the help text to provide usage examples and params
#rb Alexis.Matte
Change 3126849 on 2016/09/15 by Matt.Kuhlenschmidt
Fix font material and outline font material not being animatable in sequencer
#rb frank.fella
Change 3126858 on 2016/09/15 by Matt.Kuhlenschmidt
File not saved
#rb none
Change 3127001 on 2016/09/15 by Matt.Kuhlenschmidt
Fixed reset to default state still not appearing in all cases after changing a property.
#rb none
Change 3127038 on 2016/09/15 by Nick.Darnell
UMG - Improving focus setting for users on widgets. If we're unable to set the focus immediately, possibly because the user is setting focus in the Construct callback before the widget is in the tree, we now update the SlateOperations FReply on LocalPlayer to set focus next frame when it's more likely the widget will become focusable.
#rb none
Change 3127061 on 2016/09/15 by Nick.Darnell
Slate - We now have a reentrancy guard in TPanelChildren to avoid the broad cases where users might attempt to remove children while all children are being removed. Which is an easy case to engineer if you've got widgets spawning children managed by another widget, that all go away at the same time, thus causing the parent to attempt to cleanup children. The end result is a delete while deleting. So now TPanelChildren prevents adds/removes while emptying the list of children.
#jira UE-35726
#rb Matt.Kuchlenschmidt
Change 3127205 on 2016/09/15 by Alex.Delesky
#jira UE-18013 - Users can now add Textures, Materials, or Sprites to a Widget Blueprint directly from the content browser. This also fixes a few issues with adding Widget Blueprints to another Widget BP from the content browser, such as adding a widget to itself or creating a circular dependency.
#rb Nick.Darnell
Change 3127971 on 2016/09/16 by Matt.Kuhlenschmidt
Fix crash in scene outliner if actors become invalid
#rb none
https://jira.ol.epicgames.net/browse/UE-35932
Change 3128011 on 2016/09/16 by Matt.Kuhlenschmidt
Added guards for crashes accessing slate resources for deleted uobjects
#rb nick.darnell
Change 3128067 on 2016/09/16 by Michael.Dupuis
#jira UE-34158 Add an option to auto expand advanced details
#rb Alexis.Matte
Change 3128073 on 2016/09/16 by Michael.Dupuis
#jira UE-1145
Set Save As to Ctrl + Alt + S
Set Save All to Ctrl + Shift + S
Set Save Current to Ctrl + S
#rb Alexis.Matte
Change 3128117 on 2016/09/16 by Jamie.Dale
Updated the pin-type filter combo to filter on both the localized and source type descriptions
#jira UE-36081
#rb none
Change 3128177 on 2016/09/16 by Alexis.Matte
#jira UE-35946 Remove unnecessary GetReadValue call with bad parameter. The read value call is cache so subsequent call was returning the bad cache value.
#rb michael.dupuis
#codereview matt.kuhlenschmidt
Change 3128387 on 2016/09/16 by Gareth.Martin
Fixed location and rotation of arrow widget in the landscape mirror tool when using one of the new "Rotate" modes
#jira UE-36093
#rb none
Change 3128445 on 2016/09/16 by Matt.Kuhlenschmidt
Guard against scene outliner crash. Print out tree when items appear twice.
https://jira.ol.epicgames.net/browse/UE-35935
#rb none
Change 3128454 on 2016/09/16 by Matt.Kuhlenschmidt
Remove category for WindowTitleBarArea. It is very custom for internal use and should not be a top level widget
#rb none
Change 3128482 on 2016/09/16 by Michael.Dupuis
Added new key binding for generic Save, Save As
Added new key binding for Save All for the content browser
#rb Alexis.Matte (approved by MattK)
Change 3128560 on 2016/09/16 by Matt.Kuhlenschmidt
Fix build warning
#codereview nick.darnell
#rb none
Change 3128642 on 2016/09/16 by Alexis.Matte
#jira UE-36047 We now convert the light color correctly when importing and exporting fbx files. UE4 is sRGB and FBX is linear
#rb none
#codereview matt.kuhlenschmidt
Change 3128733 on 2016/09/16 by Nick.Darnell
UMG - Fixing a bad merge, some code was removed causing all BindWidget statements to fail to compile correctly.
#jira UE-36105
#rb none
Change 3128768 on 2016/09/16 by Matt.Kuhlenschmidt
Fix selection outline showing around edges of all internal mesh sections of a component instead of around the entire actor
#rb none
Change 3128779 on 2016/09/16 by Matt.Kuhlenschmidt
Fix offset characters on some small fonts
#rb none
Change 3130057 on 2016/09/19 by Jamie.Dale
Fixing volatility and invalidation issues for text widgets
#jira UE-33988
#rb Nick.Darnell
Change 3130064 on 2016/09/19 by Jamie.Dale
Changed mprof meta-data to allow unicode strings and updated ReadString to deal with them correctly
#rb James.Hopkin
Change 3130233 on 2016/09/19 by Michael.Dupuis
#jira UE-32914 Added missing args that the UI supported
#rb Alexis.Matte
Change 3130265 on 2016/09/19 by Nick.Darnell
Automation - Cleaning up some API items.
#rb none
Change 3130378 on 2016/09/19 by Matt.Kuhlenschmidt
Fix reentrancy saving assets while a prompt for checkout dialog is open
#rb none
Change 3130398 on 2016/09/19 by Jamie.Dale
Fixing UHT error when building
#rb none
Change 3132101 on 2016/09/20 by Nick.Darnell
UMG - Adding a toolbar option in the designer for the 'G' command, similar to 'Game View' in the level editor, it disables all the dashed lines / future editor visuals.
#rb none
Change 3132110 on 2016/09/20 by Nick.Darnell
PR #2792: ShowFlags for WidgetComponents (Contributed by projectgheist)
#jira UE-13770
#rb Nick.Darnell
Change 3132111 on 2016/09/20 by Nick.Darnell
UMG - The retainer now embeds a virtual window into the focus path so that paths are resolved correctly.
#rb none
Change 3132138 on 2016/09/20 by Michael.Dupuis
#jira UE-30945 Added missing PostEditComponentMove after drag is finished
#rb Alexis.Matte
Change 3132147 on 2016/09/20 by Michael.Dupuis
#jira UE-30866 Fixed the filter to work properly
#rb Alexis.Matte
Change 3132190 on 2016/09/20 by Matt.Kuhlenschmidt
Fix static analysis warnings in this file
#rb none
Change 3132231 on 2016/09/20 by Nick.Darnell
Slate - Updating the material blend states to match what is expected of Slate rendering, which differs a lot from the scene renderer with the way it treats alpha. This fixes translucent rendering with the retainer widget, users will need to set their materials to Alpha Composite though for it to behave as expected.
#jira UE-33285
#rb none
Change 3132255 on 2016/09/20 by Alex.Delesky
#jira UE-36048 - TMap and TSet properties are now disallowed from adding more children through the Details panel when they contain the dfault value for a key or element. Reset to Default is also no longer allowed on a Map or Set child when it will result in a second default value existing within the container.
#rb Matt.Kuhlenschmidt
Change 3132587 on 2016/09/20 by Mike.Fricker
MIDI Plugin: Fixed a CIS error in shipping configuration (introduced in CL 3108604)
#rb none
#lockdown matt.kuhlenschmidt
Change 3132623 on 2016/09/20 by Matt.Kuhlenschmidt
Fix crash opening the cooker settings
https://jira.it.epicgames.net/browse/UE-36197
#rb none
#lockdown nick.darnell
Change 3133144 on 2016/09/20 by Nick.Darnell
Build configuration for automation tests.
#rb none
#lockdown matt.kuhlenschmidt
Change 3133206 on 2016/09/20 by Matt.Kuhlenschmidt
Fix default material on odin text
#rb none
#lockdown nick.darnell
Change 3133913 on 2016/09/21 by Nick.Darnell
Back out revision 17 from //UE4/Dev-Editor/Engine/Source/Runtime/UMG/Private/Slate/SRetainerWidget.cpp
#rb none
#jira UE-36231
#lockdown matt.kuhlenschmidt
[CL 3133983 by Matt Kuhlenschmidt in Main branch]
2016-09-21 10:07:18 -04:00
if ( ButtonWidget . IsValid ( ) & & ButtonWidget - > GetVisibility ( ) = = EVisibility : : Visible )
{
return ButtonWidget ;
}
}
return TSharedPtr < SWidget > ( ) ;
2014-03-14 14:13:41 -04:00
}
/**
* Called when the checkbox items have changed state
*/
void SPackagesDialog : : RefreshButtons ( )
{
int32 CheckedItems = 0 ;
int32 UncheckedItems = 0 ;
int32 UndeterminedItems = 0 ;
/** Count the number of checkboxes that we have for each state */
for ( int32 ItemIndex = 0 ; ItemIndex < Items . Num ( ) ; + + ItemIndex )
{
FPackageItem & item = * Items [ ItemIndex ] ;
2014-12-10 14:24:09 -05:00
if ( item . GetState ( ) = = ECheckBoxState : : Checked )
2014-03-14 14:13:41 -04:00
{
CheckedItems + + ;
}
2014-12-10 14:24:09 -05:00
else if ( item . GetState ( ) = = ECheckBoxState : : Unchecked )
2014-03-14 14:13:41 -04:00
{
UncheckedItems + + ;
}
else
{
UndeterminedItems + + ;
}
}
/** Change the button state based on our selection */
for ( int32 ButtonIndex = 0 ; ButtonIndex < Buttons . Num ( ) ; + + ButtonIndex )
{
FPackageButton & Button = * Buttons [ ButtonIndex ] ;
if ( Button . GetType ( ) = = DRT_MakeWritable )
{
if ( UndeterminedItems > 0 | | CheckedItems > 0 )
Button . SetDisabled ( false ) ;
else
Button . SetDisabled ( true ) ;
}
else if ( Button . GetType ( ) = = DRT_CheckOut )
{
if ( CheckedItems > 0 )
Button . SetDisabled ( false ) ;
else
Button . SetDisabled ( true ) ;
}
}
}
/**
* Makes the widget for the checkbox items in the list view
*/
2014-04-02 18:09:23 -04:00
TSharedRef < ITableRow > SPackagesDialog : : MakePackageListItemWidget ( TSharedPtr < FPackageItem > Item , const TSharedRef < STableViewBase > & OwnerTable )
{
return SNew ( SPackageItemsListRow , OwnerTable )
. PackagesDialog ( SharedThis ( this ) )
. Item ( Item ) ;
}
TSharedRef < SWidget > SPackagesDialog : : GenerateWidgetForItemAndColumn ( TSharedPtr < FPackageItem > Item , const FName ColumnID ) const
2014-03-14 14:13:41 -04:00
{
check ( Item . IsValid ( ) ) ;
// Choose the icon based on the severity
2021-01-11 20:50:19 -04:00
const FSlateBrush * IconBrush = Item - > GetIconName ( ) . IsEmpty ( ) ? FStyleDefaults : : GetNoBrush ( ) : FEditorStyle : : GetBrush ( * ( Item - > GetIconName ( ) ) ) ;
2014-03-14 14:13:41 -04:00
2021-01-14 12:45:46 -04:00
const FMargin RowPadding ( 3 , 3 , 3 , 3 ) ;
2014-03-14 14:13:41 -04:00
// Extract the type and color for the package
FColor PackageColor ;
2021-02-11 19:52:08 -04:00
FText PackageType ;
2021-01-14 12:45:46 -04:00
Item - > GetTypeNameAndColor ( PackageType , PackageColor ) ;
2014-03-14 14:13:41 -04:00
2020-08-11 01:36:57 -04:00
const FString AssetName = Item - > GetAssetName ( ) ;
2020-09-03 08:20:02 -04:00
const FString OwnerName = Item - > GetOwnerName ( ) ;
2020-08-11 01:36:57 -04:00
const FString PackageName = Item - > GetPackageName ( ) ;
const FString FileName = Item - > GetFileName ( ) ;
2014-04-02 18:09:23 -04:00
2014-03-14 14:13:41 -04:00
TSharedPtr < SWidget > ItemContentWidget ;
2014-04-02 18:09:23 -04:00
if ( ColumnID = = SPackagesDialogDefs : : ColumnID_CheckBoxLabel )
2014-03-14 14:13:41 -04:00
{
ItemContentWidget = SNew ( SHorizontalBox )
2014-04-02 18:09:23 -04:00
+ SHorizontalBox : : Slot ( )
2021-01-14 12:45:46 -04:00
. Padding ( FMargin ( 10 , 3 , 6 , 3 ) )
2014-03-14 14:13:41 -04:00
[
SNew ( SCheckBox )
. IsChecked ( Item . Get ( ) , & FPackageItem : : OnGetDisplayCheckState )
. OnCheckStateChanged ( Item . Get ( ) , & FPackageItem : : OnDisplayCheckStateChanged )
2014-04-02 18:09:23 -04:00
] ;
}
else if ( ColumnID = = SPackagesDialogDefs : : ColumnID_IconLabel )
{
ItemContentWidget = SNew ( SHorizontalBox )
+ SHorizontalBox : : Slot ( )
2014-04-23 18:49:16 -04:00
. HAlign ( HAlign_Center )
. VAlign ( VAlign_Center )
2014-03-14 14:13:41 -04:00
[
2014-04-02 18:09:23 -04:00
SNew ( SImage )
. Image ( IconBrush )
2015-01-12 11:19:17 -05:00
. ToolTipText ( FText : : FromString ( Item - > GetToolTip ( ) ) )
2014-04-02 18:09:23 -04:00
. IsEnabled ( ! Item - > IsDisabled ( ) )
] ;
}
2020-08-11 01:36:57 -04:00
else if ( ColumnID = = SPackagesDialogDefs : : ColumnID_AssetLabel )
{
ItemContentWidget = SNew ( SHorizontalBox )
+ SHorizontalBox : : Slot ( )
. Padding ( RowPadding )
[
SNew ( STextBlock )
. Text ( FText : : FromString ( AssetName ) )
. IsEnabled ( ! Item - > IsDisabled ( ) )
] ;
}
2020-09-03 08:20:02 -04:00
else if ( ColumnID = = SPackagesDialogDefs : : ColumnID_OwnerLabel )
{
ItemContentWidget = SNew ( SHorizontalBox )
+ SHorizontalBox : : Slot ( )
. Padding ( RowPadding )
[
SNew ( STextBlock )
. Text ( FText : : FromString ( OwnerName ) )
. ToolTipText ( FText : : FromString ( OwnerName ) )
. IsEnabled ( ! Item - > IsDisabled ( ) )
] ;
}
2020-08-11 01:36:57 -04:00
else if ( ColumnID = = SPackagesDialogDefs : : ColumnID_PackageLabel )
2014-04-02 18:09:23 -04:00
{
ItemContentWidget = SNew ( SHorizontalBox )
+ SHorizontalBox : : Slot ( )
2014-04-23 18:49:16 -04:00
. Padding ( RowPadding )
2014-03-14 14:13:41 -04:00
[
2014-04-02 18:09:23 -04:00
SNew ( STextBlock )
2015-01-07 09:52:40 -05:00
. Text ( FText : : FromString ( PackageName ) )
2020-08-11 01:36:57 -04:00
. ToolTipText ( FText : : FromString ( FileName ) )
2014-04-02 18:09:23 -04:00
. IsEnabled ( ! Item - > IsDisabled ( ) )
] ;
}
else if ( ColumnID = = SPackagesDialogDefs : : ColumnID_TypeLabel )
{
ItemContentWidget = SNew ( SHorizontalBox )
+ SHorizontalBox : : Slot ( )
2014-04-23 18:49:16 -04:00
. Padding ( RowPadding )
2014-03-14 14:13:41 -04:00
[
2014-04-02 18:09:23 -04:00
SNew ( STextBlock )
2021-02-11 19:52:08 -04:00
. Text ( PackageType )
. ToolTipText ( PackageType )
2015-01-12 11:19:17 -05:00
. IsEnabled ( ! Item - > IsDisabled ( ) )
. ColorAndOpacity ( PackageColor )
] ;
}
else if ( ColumnID = = SPackagesDialogDefs : : ColumnID_CheckedOutByLabel )
{
check ( bAllowSourceControlConnection ) ;
FString CheckedOutByString = Item - > GetCheckedOutByString ( ) ;
ItemContentWidget = SNew ( SHorizontalBox )
+ SHorizontalBox : : Slot ( )
. Padding ( RowPadding )
[
SNew ( STextBlock )
. Text ( FText : : FromString ( CheckedOutByString ) )
. ToolTipText ( FText : : FromString ( CheckedOutByString ) )
2014-04-02 18:09:23 -04:00
. IsEnabled ( ! Item - > IsDisabled ( ) )
2014-03-14 14:13:41 -04:00
] ;
}
2014-04-02 18:09:23 -04:00
return ItemContentWidget . ToSharedRef ( ) ;
2014-03-14 14:13:41 -04:00
}
TSharedPtr < SWidget > SPackagesDialog : : MakePackageListContextMenu ( ) const
{
FMenuBuilder MenuBuilder ( true , NULL ) ;
const TArray < TSharedPtr < FPackageItem > > SelectedItems = GetSelectedItems ( false ) ;
if ( SelectedItems . Num ( ) > 0 )
{
MenuBuilder . BeginSection ( " FilePackage " , LOCTEXT ( " PackageHeading " , " Asset " ) ) ;
{
MenuBuilder . AddMenuEntry (
LOCTEXT ( " SCCDiffAgainstDepot " , " Diff Against Depot " ) ,
LOCTEXT ( " SCCDiffAgainstDepotTooltip " , " Look at differences between your version of the asset and that in source control. " ) ,
FSlateIcon ( ) ,
FUIAction (
FExecuteAction : : CreateSP ( this , & SPackagesDialog : : ExecuteSCCDiffAgainstDepot ) ,
FCanExecuteAction : : CreateSP ( this , & SPackagesDialog : : CanExecuteSCCDiffAgainstDepot )
)
) ;
}
MenuBuilder . EndSection ( ) ;
}
return MenuBuilder . MakeWidget ( ) ;
}
bool SPackagesDialog : : CanExecuteSCCDiffAgainstDepot ( ) const
{
return ISourceControlModule : : Get ( ) . IsEnabled ( ) & & ISourceControlModule : : Get ( ) . GetProvider ( ) . IsAvailable ( ) ;
}
void SPackagesDialog : : ExecuteSCCDiffAgainstDepot ( ) const
{
const FAssetToolsModule & AssetToolsModule = FModuleManager : : LoadModuleChecked < FAssetToolsModule > ( TEXT ( " AssetTools " ) ) ;
const TArray < TSharedPtr < FPackageItem > > SelectedItems = GetSelectedItems ( false ) ;
for ( int32 ItemIdx = 0 ; ItemIdx < SelectedItems . Num ( ) ; ItemIdx + + )
{
const TSharedPtr < FPackageItem > SelectedItem = SelectedItems [ ItemIdx ] ;
check ( SelectedItem . IsValid ( ) ) ;
2014-04-02 18:09:23 -04:00
UObject * Object = SelectedItem - > GetPackageObject ( ) ;
2014-03-14 14:13:41 -04:00
if ( Object )
{
2020-08-11 01:36:57 -04:00
const FString PackagePath = SelectedItem - > GetFileName ( ) ;
2014-03-14 14:13:41 -04:00
const FString PackageName = FPaths : : GetBaseFilename ( PackagePath ) ;
AssetToolsModule . Get ( ) . DiffAgainstDepot ( Object , PackagePath , PackageName ) ;
}
}
}
TArray < TSharedPtr < FPackageItem > > SPackagesDialog : : GetSelectedItems ( bool bAllIfNone ) const
{
//get the list of highlighted packages
TArray < TSharedPtr < FPackageItem > > SelectedItems = ItemListView - > GetSelectedItems ( ) ;
if ( SelectedItems . Num ( ) = = 0 & & bAllIfNone )
{
//If no packages are explicitly highlighted, return all packages in the list.
SelectedItems = Items ;
}
return SelectedItems ;
}
2014-12-10 14:24:09 -05:00
ECheckBoxState SPackagesDialog : : GetToggleSelectedState ( ) const
2014-03-14 14:13:41 -04:00
{
//default to a Checked state
2014-12-10 14:24:09 -05:00
ECheckBoxState PendingState = ECheckBoxState : : Checked ;
2014-03-14 14:13:41 -04:00
TArray < TSharedPtr < FPackageItem > > SelectedItems = GetSelectedItems ( true ) ;
//Iterate through the list of selected packages
for ( auto SelectedItem = SelectedItems . CreateConstIterator ( ) ; SelectedItem ; + + SelectedItem )
{
2014-12-10 14:24:09 -05:00
if ( SelectedItem - > Get ( ) - > GetState ( ) = = ECheckBoxState : : Unchecked )
2014-03-14 14:13:41 -04:00
{
//if any package in the selection is Unchecked, then represent the entire set of highlighted packages as Unchecked,
//so that the first (user) toggle of ToggleSelectedCheckBox consistently Checks all highlighted packages
2014-12-10 14:24:09 -05:00
PendingState = ECheckBoxState : : Unchecked ;
2014-03-14 14:13:41 -04:00
}
}
return PendingState ;
}
2014-12-10 14:24:09 -05:00
void SPackagesDialog : : OnToggleSelectedCheckBox ( ECheckBoxState InNewState )
2014-03-14 14:13:41 -04:00
{
TArray < TSharedPtr < FPackageItem > > SelectedItems = GetSelectedItems ( true ) ;
for ( auto SelectedItem = SelectedItems . CreateConstIterator ( ) ; SelectedItem ; + + SelectedItem )
{
FPackageItem * item = ( * SelectedItem ) . Get ( ) ;
2014-12-10 14:24:09 -05:00
if ( InNewState = = ECheckBoxState : : Checked )
2014-03-14 14:13:41 -04:00
{
if ( item - > IsDisabled ( ) )
{
2014-12-10 14:24:09 -05:00
item - > SetState ( ECheckBoxState : : Undetermined ) ;
2014-03-14 14:13:41 -04:00
}
else
{
2014-12-10 14:24:09 -05:00
item - > SetState ( ECheckBoxState : : Checked ) ;
2014-03-14 14:13:41 -04:00
}
}
else
{
2014-12-10 14:24:09 -05:00
item - > SetState ( ECheckBoxState : : Unchecked ) ;
2014-03-14 14:13:41 -04:00
}
}
ItemListView - > RequestListRefresh ( ) ;
}
2019-06-07 11:22:52 -04:00
void SPackagesDialog : : Tick ( const FGeometry & AllottedGeometry , const double InCurrentTime , const float InDeltaTime )
{
SCompoundWidget : : Tick ( AllottedGeometry , InCurrentTime , InDeltaTime ) ;
if ( bSortDirty )
{
bSortDirty = false ;
// Sort the list of root items
SortTree ( ) ;
ItemListView - > RequestListRefresh ( ) ;
}
}
2014-10-30 12:29:36 -04:00
FReply SPackagesDialog : : OnKeyDown ( const FGeometry & MyGeometry , const FKeyEvent & InKeyEvent )
2014-03-14 14:13:41 -04:00
{
2014-10-30 12:29:36 -04:00
if ( InKeyEvent . GetKey ( ) = = EKeys : : Escape )
2014-03-14 14:13:41 -04:00
{
for ( int32 ButtonIndex = 0 ; ButtonIndex < Buttons . Num ( ) ; + + ButtonIndex )
{
FPackageButton & Button = * Buttons [ ButtonIndex ] ;
if ( Button . GetType ( ) = = DRT_Cancel )
{
return Button . OnButtonClicked ( ) ;
}
}
}
2014-10-30 12:29:36 -04:00
return SCompoundWidget : : OnKeyDown ( MyGeometry , InKeyEvent ) ;
2014-03-14 14:13:41 -04:00
}
EVisibility SPackagesDialog : : GetConnectToSourceControlVisibility ( ) const
{
if ( bAllowSourceControlConnection )
{
if ( ! ISourceControlModule : : Get ( ) . IsEnabled ( ) | | ! ISourceControlModule : : Get ( ) . GetProvider ( ) . IsAvailable ( ) )
{
return EVisibility : : Visible ;
}
}
return EVisibility : : Collapsed ;
}
FReply SPackagesDialog : : OnConnectToSourceControlClicked ( ) const
{
ISourceControlModule : : Get ( ) . ShowLoginDialog ( FSourceControlLoginClosed ( ) , ELoginWindowMode : : Modal ) ;
2015-02-04 05:20:41 -05:00
OnSourceControlStateChanged . ExecuteIfBound ( ) ;
2014-03-14 14:13:41 -04:00
return FReply : : Handled ( ) ;
}
void SPackagesDialog : : PopulateIgnoreForSaveItems ( const TSet < FString > & InIgnorePackages )
{
for ( auto ItItem = Items . CreateIterator ( ) ; ItItem ; + + ItItem )
{
2020-08-11 01:36:57 -04:00
const FString & ItemName = ( * ItItem ) - > GetFileName ( ) ;
2014-03-14 14:13:41 -04:00
2014-12-10 14:24:09 -05:00
const ECheckBoxState CheckedStatus = ( InIgnorePackages . Find ( ItemName ) ! = NULL ) ? ECheckBoxState : : Unchecked : ECheckBoxState : : Checked ;
2014-03-14 14:13:41 -04:00
2014-10-14 10:33:22 -04:00
if ( ! ( * ItItem ) - > IsDisabled ( ) )
{
( * ItItem ) - > SetState ( CheckedStatus ) ;
}
2014-03-14 14:13:41 -04:00
}
}
void SPackagesDialog : : PopulateIgnoreForSaveArray ( OUT TSet < FString > & InOutIgnorePackages ) const
{
for ( auto ItItem = Items . CreateConstIterator ( ) ; ItItem ; + + ItItem )
{
2014-12-10 14:24:09 -05:00
if ( ( * ItItem ) - > GetState ( ) = = ECheckBoxState : : Unchecked )
2014-03-14 14:13:41 -04:00
{
2020-08-11 01:36:57 -04:00
InOutIgnorePackages . Add ( ( * ItItem ) - > GetFileName ( ) ) ;
2014-03-14 14:13:41 -04:00
}
else
{
2020-08-11 01:36:57 -04:00
InOutIgnorePackages . Remove ( ( * ItItem ) - > GetFileName ( ) ) ;
2014-03-14 14:13:41 -04:00
}
}
}
void SPackagesDialog : : Reset ( )
{
for ( int32 ButtonIndex = 0 ; ButtonIndex < Buttons . Num ( ) ; + + ButtonIndex )
{
Buttons [ ButtonIndex ] - > Reset ( ) ;
}
}
FText SPackagesDialog : : GetMessage ( ) const
{
return Message ;
}
2015-01-12 11:19:17 -05:00
FText SPackagesDialog : : GetWarning ( ) const
{
return Warning ;
}
EVisibility SPackagesDialog : : GetWarningVisibility ( ) const
{
2021-01-14 12:45:46 -04:00
return ( Warning . IsEmpty ( ) ) ? EVisibility : : Collapsed : EVisibility : : HitTestInvisible ;
2015-01-12 11:19:17 -05:00
}
2014-04-02 18:09:23 -04:00
EColumnSortMode : : Type SPackagesDialog : : GetColumnSortMode ( const FName ColumnId ) const
{
if ( SortByColumn ! = ColumnId )
{
return EColumnSortMode : : None ;
}
return SortMode ;
}
Asset View now supports secondary sorting
#UDN: Feature suggestion; Content browser can sort by a second column
#branch UE4
#change
Added two new images for secondary sort ascending and descending.
(Updated styles where needed).
Added new enum EColumnSortPriority: currently only lists Primary and Secondary, but can easily accommodate more*.
(FOnSortModeChanged was modified to also have the priority as a param, fixedup existing usage).
SHeaderRow now also has a SortPriority attribute to specify the SortMode order
(Defaults to Primary if unused).
Modified TUniquePtr so that assigning one from another worked correctly.
(Reviewed by Steve Robb).
SAssetView is the only table that has been modified, so far, to take advantage of the secondary sort. SetMajorityAssetType has been updated to correctly filter out all those sorts which are no longer relevant and bump the priority of the remaining sorts to fill in the ægapsÆ made by non-longer-relevant ones.
FAssetViewSortManager has been overhauled to take SortPriority into consideration when sortingÃ
Firstly, duplicate comparison structs were removed in favour of single structs which have æascendingÆ as a paramà any remaining duplicate code was removed in favour of an inherited usage. The base struct has an array of æfurther methodsÆ to employ in the result of a tie. Should a tie occur the ænextÆ comparison is done, and so on until itÆs not a tie or we run out of comparisons to perform.*
The manager defaults to having no secondary sort, so it relies on the interface thatÆs using it to provide it.
Whenever a column is assign the code makes sure that itÆs not already assigned to another column and corrects the order to take this into account.
Fixed a bug in FCompareFAssetItemByTagNumericalAscending comparing A with A (instead of B).
Various optimizations to the sort to descrease times
*The only places æSecondaryÆ is referred to in code is in GetSortingBrush (so it can display the correct icon for the sort), and OnTitleClicked (so it can set to correct sort based on input). The sorting code itself has no concept as to a secondary sort, it can support any number of sorting levels so if in future a tertiary (or more) is added, it is only these two function which should need updating as the sort will automatically accommodate it.
reviewed by Thomas.Sarkanen, Bob.Tellez
[CL 2119201 by Andrew Brown in Main branch]
2014-06-27 04:30:08 -04:00
void SPackagesDialog : : OnColumnSortModeChanged ( const EColumnSortPriority : : Type SortPriority , const FName & ColumnId , const EColumnSortMode : : Type InSortMode )
2014-04-02 18:09:23 -04:00
{
SortByColumn = ColumnId ;
SortMode = InSortMode ;
RequestSort ( ) ;
}
void SPackagesDialog : : RequestSort ( )
{
2019-06-07 11:22:52 -04:00
bSortDirty = true ;
2014-04-02 18:09:23 -04:00
}
void SPackagesDialog : : SortTree ( )
{
2020-08-11 01:36:57 -04:00
if ( SortByColumn = = SPackagesDialogDefs : : ColumnID_AssetLabel )
2014-04-02 18:09:23 -04:00
{
if ( SortMode = = EColumnSortMode : : Ascending )
{
Items . Sort ( [ ] ( const TSharedPtr < FPackageItem > & A , const TSharedPtr < FPackageItem > & B ) {
2020-08-11 01:36:57 -04:00
return A - > GetAssetName ( ) < B - > GetAssetName ( ) ; } ) ;
2014-04-02 18:09:23 -04:00
}
else if ( SortMode = = EColumnSortMode : : Descending )
{
Items . Sort ( [ ] ( const TSharedPtr < FPackageItem > & A , const TSharedPtr < FPackageItem > & B ) {
2020-08-11 01:36:57 -04:00
return A - > GetAssetName ( ) > = B - > GetAssetName ( ) ; } ) ;
}
}
2020-09-03 08:20:02 -04:00
else if ( SortByColumn = = SPackagesDialogDefs : : ColumnID_OwnerLabel )
{
if ( SortMode = = EColumnSortMode : : Ascending )
{
Items . Sort ( [ ] ( const TSharedPtr < FPackageItem > & A , const TSharedPtr < FPackageItem > & B ) {
return A - > GetOwnerName ( ) < B - > GetOwnerName ( ) ; } ) ;
}
else if ( SortMode = = EColumnSortMode : : Descending )
{
Items . Sort ( [ ] ( const TSharedPtr < FPackageItem > & A , const TSharedPtr < FPackageItem > & B ) {
return A - > GetOwnerName ( ) > = B - > GetOwnerName ( ) ; } ) ;
}
}
2020-08-11 01:36:57 -04:00
else if ( SortByColumn = = SPackagesDialogDefs : : ColumnID_PackageLabel )
{
if ( SortMode = = EColumnSortMode : : Ascending )
{
Items . Sort ( [ ] ( const TSharedPtr < FPackageItem > & A , const TSharedPtr < FPackageItem > & B ) {
return A - > GetPackageName ( ) < B - > GetPackageName ( ) ; } ) ;
}
else if ( SortMode = = EColumnSortMode : : Descending )
{
Items . Sort ( [ ] ( const TSharedPtr < FPackageItem > & A , const TSharedPtr < FPackageItem > & B ) {
return A - > GetPackageName ( ) > = B - > GetPackageName ( ) ; } ) ;
2014-04-02 18:09:23 -04:00
}
}
else if ( SortByColumn = = SPackagesDialogDefs : : ColumnID_TypeLabel )
{
if ( SortMode = = EColumnSortMode : : Ascending )
{
Items . Sort ( [ ] ( const TSharedPtr < FPackageItem > & A , const TSharedPtr < FPackageItem > & B ) {
2021-02-11 19:52:08 -04:00
return A - > GetTypeName ( ) . CompareTo ( B - > GetTypeName ( ) ) < 0 ; } ) ;
2014-04-02 18:09:23 -04:00
}
else if ( SortMode = = EColumnSortMode : : Descending )
{
Items . Sort ( [ ] ( const TSharedPtr < FPackageItem > & A , const TSharedPtr < FPackageItem > & B ) {
2021-02-11 19:52:08 -04:00
return A - > GetTypeName ( ) . CompareTo ( B - > GetTypeName ( ) ) > = 0 ; } ) ;
2014-04-02 18:09:23 -04:00
}
}
else if ( SortByColumn = = SPackagesDialogDefs : : ColumnID_IconLabel )
{
if ( SortMode = = EColumnSortMode : : Ascending )
{
Items . Sort ( [ ] ( const TSharedPtr < FPackageItem > & A , const TSharedPtr < FPackageItem > & B ) {
return A - > GetIconName ( ) < B - > GetIconName ( ) ; } ) ;
}
else if ( SortMode = = EColumnSortMode : : Descending )
{
Items . Sort ( [ ] ( const TSharedPtr < FPackageItem > & A , const TSharedPtr < FPackageItem > & B ) {
return A - > GetIconName ( ) > = B - > GetIconName ( ) ; } ) ;
}
}
2015-01-12 11:19:17 -05:00
else if ( SortByColumn = = SPackagesDialogDefs : : ColumnID_CheckedOutByLabel )
{
if ( SortMode = = EColumnSortMode : : Ascending )
{
Items . Sort ( [ ] ( const TSharedPtr < FPackageItem > & A , const TSharedPtr < FPackageItem > & B ) {
return A - > GetCheckedOutByString ( ) < B - > GetCheckedOutByString ( ) ; } ) ;
}
else if ( SortMode = = EColumnSortMode : : Descending )
{
Items . Sort ( [ ] ( const TSharedPtr < FPackageItem > & A , const TSharedPtr < FPackageItem > & B ) {
return A - > GetCheckedOutByString ( ) > = B - > GetCheckedOutByString ( ) ; } ) ;
}
}
2014-04-02 18:09:23 -04:00
}
void SPackageItemsListRow : : Construct ( const FArguments & InArgs , const TSharedRef < STableViewBase > & InOwnerTableView )
{
PackagesDialogWeak = InArgs . _PackagesDialog ;
Item = InArgs . _Item ;
SMultiColumnTableRow < TSharedPtr < FPackageItem > > : : Construct (
FSuperRowType : : FArguments ( )
, InOwnerTableView ) ;
}
TSharedRef < SWidget > SPackageItemsListRow : : GenerateWidgetForColumn ( const FName & ColumnName )
{
// Create the widget for this item
auto PackagesDialogShared = PackagesDialogWeak . Pin ( ) ;
if ( PackagesDialogShared . IsValid ( ) )
{
return PackagesDialogShared - > GenerateWidgetForItemAndColumn ( Item , ColumnName ) ;
}
// Packages dialog no longer valid; return a valid, null widget.
return SNullWidget : : NullWidget ;
}
2014-03-14 14:13:41 -04:00
# undef LOCTEXT_NAMESPACE
