z_syscfb.c, z_vimode.c, code_80140CE0 split and OK (#1159)

* z_vimode

* Fixups

* WIP

* matching

* sys_cfb OK

* some documentation

* vimode docs, name all syscfb vars

* quick fixes

* suggested changes, more things I missed

* merge suggestions

* code_80140CE0 -> z_viscvg

* format

* update symbols

* more suggestions

* fix include order

* sNotebookViMode comment, bss fix

---------

Co-authored-by: Kelebek1 <eeeedddccc@hotmail.co.uk>
Co-authored-by: louist103 <louist103@gmail.com>

tools/disasm/functions.txt

@@ -1707,7 +1707,7 @@
     0x800F4FC0:("Font_LoadMessageBoxEndIcon",),
     0x800F5004:("Font_LoadOrderedFont",),
     0x800F5090:("func_800F5090",),
-    0x800F50D4:("func_800F50D4",),
+    0x800F50D4:("Environment_ZBufValToFixedPoint",),
     0x800F510C:("Environment_Init",),
     0x800F5954:("func_800F5954",),
     0x800F5A8C:("Environment_LerpWeight",),
@@ -2748,17 +2748,17 @@
     0x8013FD74:("View_ApplyPerspectiveToOverlay",),
     0x80140024:("View_UpdateViewingMatrix",),
     0x801400CC:("View_ApplyTo",),
-    0x80140260:("func_80140260",),
-    0x8014026C:("func_8014026C",),
-    0x80140730:("func_80140730",),
-    0x80140810:("func_80140810",),
-    0x80140898:("func_80140898",),
-    0x80140900:("func_80140900",),
-    0x8014090C:("func_8014090C",),
-    0x80140970:("func_80140970",),
-    0x80140CE0:("func_80140CE0",),
-    0x80140D04:("func_80140D04",),
-    0x80140D10:("func_80140D10",),
+    0x80140260:("ViMode_LogPrint",),
+    0x8014026C:("ViMode_Configure",),
+    0x80140730:("ViMode_Save",),
+    0x80140810:("ViMode_Load",),
+    0x80140898:("ViMode_Init",),
+    0x80140900:("ViMode_Destroy",),
+    0x8014090C:("ViMode_ConfigureFeatures",),
+    0x80140970:("ViMode_Update",),
+    0x80140CE0:("VisCvg_Init",),
+    0x80140D04:("VisCvg_Destroy",),
+    0x80140D10:("VisCvg_Draw",),
     0x80140E80:("func_80140E80",),
     0x80140EA0:("func_80140EA0",),
     0x80140EAC:("func_80140EAC",),
@@ -3225,15 +3225,15 @@
     0x801780F0:("Mtx_SetTranslateScaleMtx",),
     0x801781EC:("Mtx_SetRotationMtx",),
     0x8017842C:("Mtx_SetTranslationRotationScaleMtx",),
-    0x80178750:("func_80178750",),
-    0x80178818:("func_80178818",),
-    0x80178978:("func_80178978",),
-    0x801789D4:("func_801789D4",),
-    0x801789EC:("SysCfb_GetFbPtr",),
+    0x80178750:("SysCfb_SetLoResMode",),
+    0x80178818:("SysCfb_SetHiResMode",),
+    0x80178978:("SysCfb_Init",),
+    0x801789D4:("SysCfb_Reset",),
+    0x801789EC:("SysCfb_GetFramebuffer",),
     0x80178A14:("SysCfb_GetZBuffer",),
-    0x80178A24:("func_80178A24",),
-    0x80178A34:("func_80178A34",),
-    0x80178A94:("func_80178A94",),
+    0x80178A24:("SysCfb_GetWorkBuffer",),
+    0x80178A34:("SysCfb_GetZBufferPixel",),
+    0x80178A94:("SysCfb_GetZBufferInt",),
     0x80178AC0:("func_80178AC0",),
     0x80178C80:("CmpDma_GetFileInfo",),
     0x80178D7C:("CmpDma_Decompress",),

tools/disasm/variables.txt

@@ -4051,7 +4051,7 @@
     0x801F8010:("D_801F8010","struct_801F8010","",0x10),
     0x801F8020:("sVisZbuf","VisZbuf","",0x10),
     0x801F8030:("sMonoColors","VisMono","",0x18),
-    0x801F8048:("D_801F8048","UNK_TYPE1","",0x1),
+    0x801F8048:("D_801F8048","ViMode","",0x88),
     0x801F80D0:("sGraphFaultAddrConvClient","FaultAddrConvClient","",0xc),
     0x801F80E0:("sGraphFaultClient","FaultClient","",0x10),
     0x801F80F0:("gGfxMasterDL","Gfx*","",0x4),
@@ -4094,30 +4094,30 @@
     0x801FBB14:("D_801FBB14","UNK_TYPE1","",0x1),
     0x801FBB20:("gRDPTotalTime","UNK_TYPE1","",0x1),
     0x801FBB28:("D_801FBB28","UNK_TYPE1","",0x1),
-    0x801FBB30:("D_801FBB30","OSViMode","",0x50),
+    0x801FBB30:("sNotebookViMode","OSViMode","",0x50),
     0x801FBB80:("gFramebuffers","u32*","[2]",0x8),
-    0x801FBB88:("D_801FBB88","OSViMode*","",0x4),
+    0x801FBB88:("gActiveViMode","OSViMode*","",0x4),
     0x801FBB8C:("gZBufferPtr","u16*","",0x4),
-    0x801FBB90:("D_801FBB90","UNK_TYPE4","",0x4),
+    0x801FBB90:("gWorkBuffer","UNK_TYPE4","",0x4),
     0x801FBB94:("gGfxSPTaskOutputBufferPtr","UNK_TYPE1","",0x1),
-    0x801FBB98:("gGfxSPTaskOutputBufferSize","UNK_TYPE1","",0x1),
-    0x801FBB9C:("D_801FBB9C","UNK_TYPE1","",0x1),
-    0x801FBBA0:("D_801FBBA0","UNK_TYPE1","",0x1),
-    0x801FBBA4:("gZBuffer","u16*","",0x4),
-    0x801FBBA8:("gWorkBuffer","u16**","",0x4),
-    0x801FBBAC:("gGfxSPTaskOutputBuffer","u16**","",0x4),
-    0x801FBBB0:("gGfxSPTaskOutputBufferEnd","UNK_TYPE1","",0x1),
-    0x801FBBB4:("D_801FBBB4","UNK_TYPE1","",0x1),
-    0x801FBBB8:("D_801FBBB8","UNK_TYPE1","",0x1),
-    0x801FBBBC:("D_801FBBBC","UNK_TYPE1","",0x1),
-    0x801FBBC0:("D_801FBBC0","UNK_TYPE1","",0x1),
-    0x801FBBC4:("gGfxSPTaskOutputBuffer2","UNK_TYPE1","",0x1),
-    0x801FBBC8:("gGfxSPTaskOutputBufferEnd2","UNK_TYPE1","",0x1),
-    0x801FBBCC:("D_801FBBCC","UNK_TYPE2","",0x2),
-    0x801FBBCE:("D_801FBBCE","UNK_TYPE2","",0x2),
-    0x801FBBD0:("D_801FBBD0","UNK_TYPE1","",0x1),
-    0x801FBBD2:("D_801FBBD2","UNK_TYPE1","",0x1),
-    0x801FBBD4:("D_801FBBD4","UNK_TYPE1","",0x1),
+    0x801FBB98:("gGfxSPTaskOutputBufferEnd","UNK_TYPE1","",0x1),
+    0x801FBB9C:("sCfbLoRes1","UNK_TYPE1","",0x1),
+    0x801FBBA0:("sCfbLoRes0","UNK_TYPE1","",0x1),
+    0x801FBBA4:("gZBufferLoRes","u16*","",0x4),
+    0x801FBBA8:("gWorkBufferLoRes","u16**","",0x4),
+    0x801FBBAC:("gGfxSPTaskOutputBufferLoRes","u16**","",0x4),
+    0x801FBBB0:("gGfxSPTaskOutputBufferEndLoRes","UNK_TYPE1","",0x1),
+    0x801FBBB4:("sCfbHiRes1","UNK_TYPE1","",0x1),
+    0x801FBBB8:("sCfbHiRes0","UNK_TYPE1","",0x1),
+    0x801FBBBC:("gZBufferHiRes","UNK_TYPE1","",0x1),
+    0x801FBBC0:("gWorkBufferHiRes","UNK_TYPE1","",0x1),
+    0x801FBBC4:("gGfxSPTaskOutputBufferHiRes","UNK_TYPE1","",0x1),
+    0x801FBBC8:("gGfxSPTaskOutputBufferEndHiRes","UNK_TYPE1","",0x1),
+    0x801FBBCC:("gCfbWidth","UNK_TYPE2","",0x2),
+    0x801FBBCE:("gCfbHeight","UNK_TYPE2","",0x2),
+    0x801FBBD0:("gCfbLeftAdjust","UNK_TYPE1","",0x1),
+    0x801FBBD2:("gCfbUpperAdjust","UNK_TYPE1","",0x1),
+    0x801FBBD4:("gSysCfbHiResEnabled","UNK_TYPE1","",0x1),
     0x801FBBE0:("sDmaBuffer","u32","[2]",0x8),
     0x801FBBF0:("D_801FBBF0","Vec3f","",0xc),
     0x801FBC00:("Math3D_ColSphereTri_line","LineSegment","",0x18),

tools/sizes/code_functions.csv

@@ -1221,7 +1221,7 @@ asm/non_matchings/code/z_kanfont/Font_LoadCharNES.s,Font_LoadCharNES,0x800F4F54,
 asm/non_matchings/code/z_kanfont/Font_LoadMessageBoxEndIcon.s,Font_LoadMessageBoxEndIcon,0x800F4FC0,0x11
 asm/non_matchings/code/z_kanfont/Font_LoadOrderedFont.s,Font_LoadOrderedFont,0x800F5004,0x23
 asm/non_matchings/code/z_kankyo/func_800F5090.s,func_800F5090,0x800F5090,0x11
-asm/non_matchings/code/z_kankyo/func_800F50D4.s,func_800F50D4,0x800F50D4,0xE
+asm/non_matchings/code/z_kankyo/Environment_ZBufValToFixedPoint.s,Environment_ZBufValToFixedPoint,0x800F50D4,0xE
 asm/non_matchings/code/z_kankyo/Environment_Init.s,Environment_Init,0x800F510C,0x212
 asm/non_matchings/code/z_kankyo/func_800F5954.s,func_800F5954,0x800F5954,0x4E
 asm/non_matchings/code/z_kankyo/Environment_LerpWeight.s,Environment_LerpWeight,0x800F5A8C,0x21
@@ -2270,9 +2270,9 @@ asm/non_matchings/code/z_vimode/func_80140898.s,func_80140898,0x80140898,0x1A
 asm/non_matchings/code/z_vimode/func_80140900.s,func_80140900,0x80140900,0x3
 asm/non_matchings/code/z_vimode/func_8014090C.s,func_8014090C,0x8014090C,0x19
 asm/non_matchings/code/z_vimode/func_80140970.s,func_80140970,0x80140970,0xDC
-asm/non_matchings/code/z_vimode/func_80140CE0.s,func_80140CE0,0x80140CE0,0x9
-asm/non_matchings/code/z_vimode/func_80140D04.s,func_80140D04,0x80140D04,0x3
-asm/non_matchings/code/z_vimode/func_80140D10.s,func_80140D10,0x80140D10,0x5C
+asm/non_matchings/code/z_vimode/VisCvg_Init.s,VisCvg_Init,0x80140CE0,0x9
+asm/non_matchings/code/z_vimode/VisCvg_Destroy.s,VisCvg_Destroy,0x80140D04,0x3
+asm/non_matchings/code/z_vimode/VisCvg_Draw.s,VisCvg_Draw,0x80140D10,0x5C
 asm/non_matchings/code/code_80140E80/func_80140E80.s,func_80140E80,0x80140E80,0x8
 asm/non_matchings/code/code_80140E80/func_80140EA0.s,func_80140EA0,0x80140EA0,0x3
 asm/non_matchings/code/code_80140E80/func_80140EAC.s,func_80140EAC,0x80140EAC,0x57
@@ -2739,15 +2739,15 @@ asm/non_matchings/code/speed_meter/SpeedMeter_DrawAllocEntries.s,SpeedMeter_Draw
 asm/non_matchings/code/speed_meter/func_801780F0.s,func_801780F0,0x801780F0,0x3F
 asm/non_matchings/code/speed_meter/func_801781EC.s,func_801781EC,0x801781EC,0x90
 asm/non_matchings/code/speed_meter/func_8017842C.s,func_8017842C,0x8017842C,0xC9
-asm/non_matchings/code/sys_cmpdma/func_80178750.s,func_80178750,0x80178750,0x32
-asm/non_matchings/code/sys_cmpdma/func_80178818.s,func_80178818,0x80178818,0x58
-asm/non_matchings/code/sys_cmpdma/func_80178978.s,func_80178978,0x80178978,0x17
-asm/non_matchings/code/sys_cmpdma/func_801789D4.s,func_801789D4,0x801789D4,0x6
-asm/non_matchings/code/sys_cmpdma/SysCfb_GetFbPtr.s,SysCfb_GetFbPtr,0x801789EC,0xA
+asm/non_matchings/code/sys_cmpdma/SysCfb_SetLoResMode.s,SysCfb_SetLoResMode,0x80178750,0x32
+asm/non_matchings/code/sys_cmpdma/SysCfb_SetHiResMode.s,SysCfb_SetHiResMode,0x80178818,0x58
+asm/non_matchings/code/sys_cmpdma/SysCfb_Init.s,SysCfb_Init,0x80178978,0x17
+asm/non_matchings/code/sys_cmpdma/SysCfb_Reset.s,SysCfb_Reset,0x801789D4,0x6
+asm/non_matchings/code/sys_cmpdma/SysCfb_GetFramebuffer.s,SysCfb_GetFramebuffer,0x801789EC,0xA
 asm/non_matchings/code/sys_cmpdma/SysCfb_GetZBuffer.s,SysCfb_GetZBuffer,0x80178A14,0x4
-asm/non_matchings/code/sys_cmpdma/func_80178A24.s,func_80178A24,0x80178A24,0x4
-asm/non_matchings/code/sys_cmpdma/func_80178A34.s,func_80178A34,0x80178A34,0x18
-asm/non_matchings/code/sys_cmpdma/func_80178A94.s,func_80178A94,0x80178A94,0xB
+asm/non_matchings/code/sys_cmpdma/SysCfb_GetWorkBuffer.s,SysCfb_GetWorkBuffer,0x80178A24,0x4
+asm/non_matchings/code/sys_cmpdma/SysCfb_GetZBufferPixel.s,SysCfb_GetZBufferPixel,0x80178A34,0x18
+asm/non_matchings/code/sys_cmpdma/SysCfb_GetZBufferInt.s,SysCfb_GetZBufferInt,0x80178A94,0xB
 asm/non_matchings/code/sys_cmpdma/func_80178AC0.s,func_80178AC0,0x80178AC0,0x70
 asm/non_matchings/code/sys_cmpdma/CmpDma_GetFileInfo.s,CmpDma_GetFileInfo,0x80178C80,0x3F
 asm/non_matchings/code/sys_cmpdma/CmpDma_Decompress.s,CmpDma_Decompress,0x80178D7C,0xC