Max Brunsfeld
689da9d0b1
Move git hunk controls to the left side ( #18460 )
...

Release Notes:
- N/A
2024-09-27 13:13:55 -07:00
Danilo Leal
1c5be9de4e
Capitalize tooltip labels on buffer search ( #18458 )
...
For consistency, as this seems to be the pattern we're using overall for
labels and buttons.
---
Release Notes:
- N/A
2024-09-27 17:02:32 -03:00
Kirill Bulatov
d5f67406b0
Install cargo-edito without extra features ( #18457 )
...
https://github.com/killercup/cargo-edit/pull/907 removed the feature
from the crate
Release Notes:
- N/A
2024-09-27 22:42:04 +03:00
Max Brunsfeld
c3075dfe9a
Fix bugs in diff hunk highlighting ( #18454 )
...
Fixes https://github.com/zed-industries/zed/issues/18405
In https://github.com/zed-industries/zed/pull/18313 , we introduced a
problem where git addition highlights might spuriously return when
undoing certain changes. It turned out, there were already some cases
where git hunk highlighting was incorrect when editing at the boundaries
of expanded diff hunks.
In this PR, I've introduced a test helper method for more rigorously
(and readably) testing the editor's git state. You can assert about the
entire state of an editor's diff decorations using a formatted diff:
```rust
cx.assert_diff_hunks(
r#"
- use some::mod1;
use some::mod2;
const A: u32 = 42;
- const B: u32 = 42;
const C: u32 = 42;
fn main() {
- println!("hello");
+ //println!("hello");
println!("world");
+ //
+ //
}
fn another() {
println!("another");
+ println!("another");
}
- fn another2() {
println!("another2");
}
"#
.unindent(),
);
```
This will assert about the editor's actual row highlights, not just the
editor's internal hunk-tracking state.
I rewrote all of our editor diff tests to use these more high-level
assertions, and it caught the new bug, as well as some pre-existing bugs
in the highlighting of added content.
The problem was how we *remove* highlighted rows. Previously, it relied
on supplying exactly the same range as one that we had previously
highlighted. I've added a `remove_highlighted_rows(ranges)` APIs which
is much simpler - it clears out any row ranges that intersect the given
ranges (which is all that we need for the Git diff use case).
Release Notes:
- N/A
2024-09-27 11:14:28 -07:00
Richard Feldman
caaa9a00a9
Remove Qwen2 model ( #18444 )
...
Removed deprecated Qwen2 7B Instruct model from zed.dev provider (staff
only).
Release Notes:
- N/A
2024-09-27 13:30:25 -04:00
Conrad Irwin
ffd1083cc1
vim: Command selection fixes ( #18424 )
...
Release Notes:
- vim: Fixed cursor position after `:{range}yank`.
- vim: Added `:fo[ld]`, `:foldo[pen]` and `:foldc[lose]`
2024-09-27 10:06:19 -06:00
Joseph T. Lyons
6d4ecac610
Add a get-release-notes-since script ( #18445 )
...
Release Notes:
- N/A
2024-09-27 10:59:19 -04:00
Ömer Sinan Ağacan
dc5ffe6994
Fix GoToDefinition changing the viewport unnecessarily ( #18441 )
...
Closes #10738 .
Release Notes:
- Fixed `GoToDefinition` changing the viewport (scrolling up/down) even when the definition is already within the viewport. ([#10738 ](https://github.com/zed-industries/zed/issues/10738 ))
2024-09-27 17:55:03 +03:00
Peter Tripp
03c7f08581
docs: Ollama api_url improvements ( #18440 )
2024-09-27 10:29:49 -04:00
Bennet Bo Fenner
73ff8c0f1f
Fix missing tooltips for selected buttons ( #18435 )
...
Reverts #13857 . Hiding tooltips for selected buttons prevents tooltips
like "Close x dock" from showing up, see #14938 for an example.
The intention of the original PR was to hide the "Show application menu"
tooltip, while the context menu is open.
In order to fix this without breaking other UI elements, we track the
state of the context menu using `PopoverMenuHandle` now, which allows us
to prevent the tooltip from showing up while the context menu is open.
Closes #14938
Release Notes:
- Fixed an issue where some tooltips would not show up
2024-09-27 14:16:14 +02:00
Bennet Bo Fenner
1c5d9c221a
Add missing shortcuts in tooltips ( #18282 )
...
Fixes some missing shortcuts from Tooltips like the project search,
buffer search, quick action bar, ....
https://github.com/user-attachments/assets/d3a0160a-8d6e-4ddc-bf82-1fabeca42d59
This should hopefully help new users learn and discover some nice
keyboard shortcuts
Release Notes:
- Display keyboard shortcuts inside tooltips in the project search,
buffer search etc.
2024-09-27 11:06:48 +02:00
Bennet Bo Fenner
a1d2e1106e
assistant: Fix copy/cut not working when selection is empty ( #18403 )
...
Release Notes:
- Fixed copy/cut/paste not working in the assistant panel when selection
was empty
2024-09-27 10:51:49 +02:00
Kirill Bulatov and Thorsten Ball
568a21a700
Fix the numeration in line wrap docs ( #18428 )
...
Follow-up of https://github.com/zed-industries/zed/pull/18412
Release Notes:
- N/A
Co-authored-by: Thorsten Ball <thorsten@zed.dev >
2024-09-27 10:48:34 +03:00
5199135b54
ssh remoting: Show error if opening connection timed out ( #18401 )
...
This shows an error if opening a connection to a remote host didn't work
in the timeout of 10s (maybe we'll need to make that configurable in the
future? for now it seems fine.)

Release Notes:
- N/A
---------
Co-authored-by: Bennet <bennet@zed.dev >
Co-authored-by: Conrad <conrad@zed.dev >
2024-09-27 09:31:45 +02:00
CharlesChen0823
8559731e0d
project: Fix worktree store event missing in remote projects ( #18376 )
...
Release Notes:
- N/A
2024-09-27 08:55:35 +02:00
Conrad Irwin
02d0561586
Fix read timeout for ollama ( #18417 )
...
Supercedes: #18310
Release Notes:
- Fixed `low_speed_timeout_in_seconds` for Ollama
2024-09-27 00:36:17 -06:00
Conrad Irwin
1be3c44550
vim: Support za ( #18421 )
...
Closes #6822
Updates #5142
Release Notes:
- Added new fold actions to toggle folds (`cmd-k cmd-l`), fold every
fold (`cmd-k cmd-0`) unfold every fold (`cmd-k cmd-j`) to fold
recursively (`cmd-k cmd-[`) and unfold recursively (`cmd-k cmd-]`).
- vim: Added `za` to toggle fold under cursor.
- vim: Added `zO`/`zC`/`zA` to open, close and toggle folds recursively
(and fixed `zc` to not recurse into selections).
- vim: Added `zR`/`zM` to open/close all folds in the buffer.
2024-09-26 23:52:07 -06:00
Conrad Irwin
32605e9ea4
Fix register selection in visual mode ( #18418 )
...
Related to #12895
Release Notes:
- vim: Fix register selection in visual yank
2024-09-26 20:27:49 -06:00
Kirill Bulatov
c83d007138
Remove non-wrapping settings from the language configuration ( #18412 )
...
Closes https://github.com/zed-industries/zed/issues/17736
Those are limited with 1024 symbols before wrapping still, and were
introduced for git diff deleted hunks display.
Instead of confusing people with actually wrapping, restores behavior
that was before https://github.com/zed-industries/zed/pull/11080
Release Notes:
- Removed confusing soft wrap option behavior
([#17736 ]https://github.com/zed-industries/zed/issues/17736 )
2024-09-26 23:43:58 +03:00
Peter Tripp and Joseph T. Lyons
48c6eb9ac7
Add script to generate license dependencies as csv ( #18411 )
...
Co-authored-by: Joseph T. Lyons <JosephTLyons@gmail.com >
2024-09-26 16:21:20 -04:00
Conrad Irwin
e28496d4e2
Stop leaking isahc assumption ( #18408 )
...
Users of our http_client crate knew they were interacting with isahc as
they set its extensions on the request. This change adds our own
equivalents for their APIs in preparation for changing the default http
client.
Release Notes:
- N/A
2024-09-26 14:01:05 -06:00
Max Brunsfeld
c1a039a5d7
Remove old project search code path, bump min-supported zed version for collaboration ( #18404 )
...
Release Notes:
- N/A
2024-09-26 12:10:39 -07:00
Mikayla Maki and conrad
71da81c743
SSH Remoting: Fix bugs in worktree syncing ( #18406 )
...
Release Notes:
- N/A
---------
Co-authored-by: conrad <conrad@zed.dev >
2024-09-26 12:03:57 -07:00
thataboy and Marshall Bowers
11058765be
Add ability to separately set background color for highlighted brackets ( #17566 )
...
Closes https://github.com/zed-industries/zed/issues/16380
Currently brackets are highlighted with
`editor.document_highlight.read_background`. This commit adds a separate
`editor.document_highlight.bracket_background` theme setting so bracket
highlights can be made more prominent without doing the same to other
highlights, making the display too busy.
(My own theme)
https://github.com/user-attachments/assets/29a8c05e-2f1a-4c16-9be8-a4b4cb143548
I set defaults for light and dark theme that I hope are sensible and not
too obnoxious, but noticeable so people can change it if they don't like
it.
Release Notes:
- Added `editor.document_highlight.bracket_background` field to the
theme to set background color of highlighted brackets.
- This will fall back to `editor.document_highlight.read_background`, if
not set.
<img width="355" alt="Screenshot 2024-09-08 at 8 46 57 AM"
src="https://github.com/user-attachments/assets/3270bb4d-19f5-4b34-8003-982377b2ceb6 ">
<img width="444" alt="Screenshot 2024-09-08 at 9 03 27 AM"
src="https://github.com/user-attachments/assets/3b12d84d-913c-4bde-9132-9b10f4a8d49b ">
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com >
2024-09-26 12:48:23 -04:00
renovate[bot]
c7a79cfc02
Update Rust crate libc to v0.2.159 ( #18370 )
...
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [libc](https://redirect.github.com/rust-lang/libc ) |
workspace.dependencies | patch | `0.2.158` -> `0.2.159` |
---
### Release Notes
<details>
<summary>rust-lang/libc (libc)</summary>
###
[`v0.2.159`](https://redirect.github.com/rust-lang/libc/releases/tag/0.2.159 )
[Compare
Source](https://redirect.github.com/rust-lang/libc/compare/0.2.158...0.2.159 )
##### Added
- Android: add more `AT_*` constants in
[#​3779](https://redirect.github.com/rust-lang/libc/pull/3779 )
- Apple: add missing `NOTE_*` constants in
[#​3883](https://redirect.github.com/rust-lang/libc/pull/3883 )
- Hermit: add missing error numbers in
[#​3858](https://redirect.github.com/rust-lang/libc/pull/3858 )
- Hurd: add `__timeval` for 64-bit support in
[#​3786](https://redirect.github.com/rust-lang/libc/pull/3786 )
- Linux: add `epoll_pwait2` in
[#​3868](https://redirect.github.com/rust-lang/libc/pull/3868 )
- Linux: add `mq_notify` in
[#​3849](https://redirect.github.com/rust-lang/libc/pull/3849 )
- Linux: add missing `NFT_CT_*` constants in
[#​3844](https://redirect.github.com/rust-lang/libc/pull/3844 )
- Linux: add the `fchmodat2` syscall in
[#​3588](https://redirect.github.com/rust-lang/libc/pull/3588 )
- Linux: add the `mseal` syscall in
[#​3798](https://redirect.github.com/rust-lang/libc/pull/3798 )
- OpenBSD: add `sendmmsg` and `recvmmsg` in
[#​3831](https://redirect.github.com/rust-lang/libc/pull/3831 )
- Unix: add `IN6ADDR_ANY_INIT` and `IN6ADDR_LOOPBACK_INIT` in
[#​3693](https://redirect.github.com/rust-lang/libc/pull/3693 )
- VxWorks: add `S_ISVTX` in
[#​3768](https://redirect.github.com/rust-lang/libc/pull/3768 )
- VxWorks: add `vxCpuLib` and `taskLib` functions
[#​3861](https://redirect.github.com/rust-lang/libc/pull/3861 )
- WASIp2: add definitions for `std::net` support in
[#​3892](https://redirect.github.com/rust-lang/libc/pull/3892 )
##### Fixed
- Correctly handle version checks when `clippy-driver` is used
[#​3893](https://redirect.github.com/rust-lang/libc/pull/3893 )
##### Changed
- EspIdf: change signal constants to c_int in
[#​3895](https://redirect.github.com/rust-lang/libc/pull/3895 )
- HorizonOS: update network definitions in
[#​3863](https://redirect.github.com/rust-lang/libc/pull/3863 )
- Linux: combine `ioctl` APIs in
[#​3722](https://redirect.github.com/rust-lang/libc/pull/3722 )
- WASI: enable CI testing in
[#​3869](https://redirect.github.com/rust-lang/libc/pull/3869 )
- WASIp2: enable CI testing in
[#​3870](https://redirect.github.com/rust-lang/libc/pull/3870 )
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
Release Notes:
- N/A
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-09-26 12:16:49 -04:00