Fix formatters not running in order (#24584)

Browse Source

Previously, if multiple formatters were specified for the same language,
they would be run in parallel on the state of the file, and then all
edits would be applied. This lead to incorrect output with many unwanted
artifacts.
This PR refactors the formatting code to clean it up, and ensure results
from previous formatters are passed in to subsequent formatters.

Closes #15544

Release Notes:

- Fixed an issue where when running multiple formatters they would be
ran in parallel rather than sequentially, leading to unwanted artifacts
and incorrect output.

---------

Co-authored-by: Conrad <conrad@zed.dev>

...

This commit is contained in:

Ben Kunkle

2025-02-10 16:18:14 -06:00

committed by GitHub

co-authored by Conrad

parent 1f288f7327

commit dab9c41799

1 changed files with 187 additions and 302 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

crates/project/src/lsp_store.rs

+187 -302

File diff suppressed because it is too large Load Diff