encounter/linuxdeploy
0
0
Fork 0
mirror of https://github.com/encounter/linuxdeploy.git synced 2026-07-10 12:18:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fix patchelf unexpectedly overwriting symlinked libraries

Browse Source
This commit is contained in:
TheAssassin
2022-05-18 23:33:02 +02:00
parent 23dcaa5cda
commit 56760df190
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/elf_file.cpp
+7 -1
View File
@@ -273,8 +273,14 @@ namespace linuxdeploy {
// don't try to fetch patchelf path in a catchall to make sure the process exists when the tool cannot be found
const auto patchelfPath = PrivateData::getPatchelfPath();
// calling (older versions of) patchelf on symlinks can lead to weird behavior, e.g., patchelf copying the
// original file and patching the copy instead of patching the symlink target
const auto canonicalPath = bf::canonical(d->path);
ldLog() << LD_DEBUG << "Calling patchelf on canonical path" << canonicalPath << "instead of original path" << d->path << std::endl;
try {
subprocess::subprocess patchelfProc({patchelfPath.c_str(), "--set-rpath", value.c_str(), d->path.c_str()});
subprocess::subprocess patchelfProc({patchelfPath.c_str(), "--set-rpath", value.c_str(), canonicalPath.c_str()});
const auto result = patchelfProc.run();