Move back test code

The code has never belonged into the BasicPluginsDeployer anyway. This
also makes calling the basic deployer's default code optional to
custom deployers.

This commit further puts a note in all existing deployers which call
the default deployment code for future developers.
This commit is contained in:
TheAssassin
2019-09-24 02:36:34 +02:00
parent d643148681
commit bb3ca84e09
13 changed files with 15 additions and 1 deletions
+2 -1
View File
@@ -27,6 +27,7 @@ BasicPluginsDeployer::BasicPluginsDeployer(std::string moduleName,
qtDataPath(std::move(qtDataPath)) {}
bool BasicPluginsDeployer::deploy() {
ldLog() << std::endl << "-- Deploying module:" << moduleName << "--" << std::endl;
// currently this is a no-op, but we might add more functionality later on, such as some kinds of default
// attempts to copy data based on the moduleName
return true;
}
+1
View File
@@ -11,6 +11,7 @@ using namespace linuxdeploy::core::log;
namespace bf = boost::filesystem;
bool BearerPluginsDeployer::deploy() {
// calling the default code is optional, but it won't hurt for now
if (!BasicPluginsDeployer::deploy())
return false;
+1
View File
@@ -11,6 +11,7 @@ using namespace linuxdeploy::core::log;
namespace bf = boost::filesystem;
bool GamepadPluginsDeployer::deploy() {
// calling the default code is optional, but it won't hurt for now
if (!BasicPluginsDeployer::deploy())
return false;
@@ -11,6 +11,7 @@ using namespace linuxdeploy::core::log;
namespace bf = boost::filesystem;
bool MultimediaPluginsDeployer::deploy() {
// calling the default code is optional, but it won't hurt for now
if (!BasicPluginsDeployer::deploy())
return false;
@@ -11,6 +11,7 @@ using namespace linuxdeploy::core::log;
namespace bf = boost::filesystem;
bool PlatformPluginsDeployer::deploy() {
// calling the default code is optional, but it won't hurt for now
if (!BasicPluginsDeployer::deploy())
return false;
@@ -11,6 +11,7 @@ using namespace linuxdeploy::core::log;
namespace bf = boost::filesystem;
bool PositioningPluginsDeployer::deploy() {
// calling the default code is optional, but it won't hurt for now
if (!BasicPluginsDeployer::deploy())
return false;
+1
View File
@@ -9,6 +9,7 @@ using namespace linuxdeploy::plugin::qt;
namespace bf = boost::filesystem;
bool QmlPluginsDeployer::deploy() {
// calling the default code is optional, but it won't hurt for now
if (!BasicPluginsDeployer::deploy())
return false;
+1
View File
@@ -11,6 +11,7 @@ using namespace linuxdeploy::core::log;
namespace bf = boost::filesystem;
bool Qt3DPluginsDeployer::deploy() {
// calling the default code is optional, but it won't hurt for now
if (!BasicPluginsDeployer::deploy())
return false;
+1
View File
@@ -11,6 +11,7 @@ using namespace linuxdeploy::core::log;
namespace bf = boost::filesystem;
bool SqlPluginsDeployer::deploy() {
// calling the default code is optional, but it won't hurt for now
if (!BasicPluginsDeployer::deploy())
return false;
+1
View File
@@ -11,6 +11,7 @@ using namespace linuxdeploy::core::log;
namespace bf = boost::filesystem;
bool SvgPluginsDeployer::deploy() {
// calling the default code is optional, but it won't hurt for now
if (!BasicPluginsDeployer::deploy())
return false;
@@ -12,6 +12,7 @@ using namespace linuxdeploy::core::log;
namespace bf = boost::filesystem;
bool WebEnginePluginsDeployer::deploy() {
// calling the default code is optional, but it won't hurt for now
if (!BasicPluginsDeployer::deploy())
return false;
@@ -12,6 +12,7 @@ using namespace linuxdeploy::core::log;
namespace bf = boost::filesystem;
bool XcbglIntegrationPluginsDeployer::deploy() {
// calling the default code is optional, but it won't hurt for now
if (!BasicPluginsDeployer::deploy())
return false;
+2
View File
@@ -227,6 +227,8 @@ int main(const int argc, const char *const *const argv) {
);
for (const auto& module : qtModulesToDeploy) {
ldLog() << std::endl << "-- Deploying module:" << module.name << "--" << std::endl;
auto deployer = deployerFactory.getInstance(module.name);
if (!deployer->deploy()) {