encounter/engine
0
0
Fork 0
mirror of https://github.com/encounter/engine.git synced 2026-03-30 11:09:55 -07:00
Code Issues Packages Projects Releases Wiki Activity

Fixes related to usage of std::weak_ptr to hold PlatformViews (#3949)

Browse Source 
* Call weak_ptr.lock(), which returns a null shared_ptr and does not throw
* IsViewInvalid was inverted
This commit is contained in:
Jason Simmons
2017-08-03 10:53:17 -07:00
committed by GitHub
parent c51b3ca86b
commit 42f5bc5fdf
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
shell/common/engine.cc
+2 -2
View File
@@ -485,7 +485,7 @@ void Engine::Render(std::unique_ptr<flow::LayerTree> layer_tree) {
void Engine::UpdateSemantics(std::vector<blink::SemanticsNode> update) {
blink::Threads::Platform()->PostTask(ftl::MakeCopyable(
[ platform_view = std::shared_ptr<PlatformView>{platform_view_}, update = std::move(update) ]() mutable {
[ platform_view = platform_view_.lock(), update = std::move(update) ]() mutable {
if (platform_view)
platform_view->UpdateSemantics(std::move(update));
}));
@@ -498,7 +498,7 @@ void Engine::HandlePlatformMessage(
return;
}
blink::Threads::Platform()->PostTask([
platform_view = std::shared_ptr<PlatformView>{platform_view_}, message = std::move(message)
platform_view = platform_view_.lock(), message = std::move(message)
]() mutable {
if (platform_view)
platform_view->HandlePlatformMessage(std::move(message));
shell/common/shell.cc
+3 -3
View File
@@ -34,7 +34,7 @@ bool IsInvalid(const ftl::WeakPtr<Rasterizer>& rasterizer) {
}
bool IsViewInvalid(const std::weak_ptr<PlatformView>& platform_view) {
return !(platform_view.expired());
return platform_view.expired();
}
template <typename T>
@@ -266,7 +266,7 @@ void Shell::GetPlatformViewIds(
std::vector<PlatformViewInfo>* platform_view_ids) {
std::lock_guard<std::mutex> lk(platform_views_mutex_);
for (auto it = platform_views_.begin(); it != platform_views_.end(); it++) {
std::shared_ptr <PlatformView> view{*it};
std::shared_ptr<PlatformView> view = it->lock();
if (!view) {
// Skip dead views.
continue;
@@ -317,7 +317,7 @@ void Shell::RunInPlatformViewUIThread(uintptr_t view_id,
*view_existed = false;
for (auto it = platform_views_.begin(); it != platform_views_.end(); it++) {
std::shared_ptr<PlatformView> view{*it};
std::shared_ptr<PlatformView> view = it->lock();
if (!view) continue;
if (reinterpret_cast<uintptr_t>(view.get()) == view_id) {
*view_existed = true;
shell/platform/android/platform_view_android.cc
+2 -2
View File
@@ -37,7 +37,7 @@ class PlatformMessageResponseAndroid : public blink::PlatformMessageResponse {
ftl::RefPtr<PlatformMessageResponseAndroid> self(this);
blink::Threads::Platform()->PostTask(
ftl::MakeCopyable([ self, data = std::move(data) ]() mutable {
std::shared_ptr<PlatformView> view{self->view_};
std::shared_ptr<PlatformView> view = self->view_.lock();
if (!view)
return;
static_cast<PlatformViewAndroid*>(view.get())
@@ -49,7 +49,7 @@ class PlatformMessageResponseAndroid : public blink::PlatformMessageResponse {
void CompleteEmpty() override {
ftl::RefPtr<PlatformMessageResponseAndroid> self(this);
blink::Threads::Platform()->PostTask(ftl::MakeCopyable([self]() mutable {
std::shared_ptr<PlatformView> view{self->view_};
std::shared_ptr<PlatformView> view = self->view_.lock();
if (!view)
return;
static_cast<PlatformViewAndroid*>(view.get())