dasharo/zephyr
0
0
Fork 0
mirror of https://github.com/Dasharo/zephyr.git synced 2026-03-06 14:57:20 -08:00
Code Issues Packages Projects Releases Wiki Activity

subsys/modbus: Fix potential memory overwrite (coverity)

Browse Source 
The size of ctx->rx_adu.data is not CONFIG_MODBUS_BUFFER_SIZE. Coverity
flagged the potential overwrite so just use sizeof().

Fixes #33789
Fixes #33792
Fixes #33818

Signed-off-by: David Leach <david.leach@nxp.com>
This commit is contained in:
David Leach
2021-03-30 17:59:26 -05:00
committed by Anas Nashif
parent f2d8b4cc94
commit 3f0da93902
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
subsys/modbus/modbus_raw.c
+1 -1
View File
@@ -70,7 +70,7 @@ int modbus_raw_submit_rx(const int iface, const struct modbus_adu *adu)
ctx->rx_adu.unit_id = adu->unit_id;
ctx->rx_adu.fc = adu->fc;
memcpy(ctx->rx_adu.data, adu->data,
MIN(adu->length, CONFIG_MODBUS_BUFFER_SIZE));
MIN(adu->length, sizeof(ctx->rx_adu.data)));
k_work_submit(&ctx->server_work);
return 0;