dasharo/systemd
0
0
Fork 0
mirror of https://github.com/Dasharo/systemd.git synced 2026-03-06 15:02:31 -08:00
Code Issues Packages Projects Releases Wiki Activity
64,754 Commits 1 Branch 0 Tags
e9dbe2abc3dbef9e26e7dd4cb194b1f20e104be7
Commit Graph

64754 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Lennart Poettering
e9dbe2abc3 update TODO 2023-05-23 11:03:49 +02:00
Frantisek Sumsal
5de8264b0d networkctl: fix a potential memory leak 
Resolves: CID#1512516
Follow-up to 96bab8fd63.
 2023-05-23 16:50:18 +09:00
Michal Sekletar
ff32060f2e core/service: when resetting PID also reset known flag 
Re-watching pids on cgroup v1 (needed because of unreliability of cgroup
empty notifications in containers) is handled bellow at the end of
service_sigchld_event() and depends on value main_pid_known flag.

In CentOS Stream 8 container on cgroup v1 the stop action would get stuck
indefinitely on unit like this,

$ cat /run/systemd/system/foo.service
[Service]
ExecStart=/bin/bash -c 'trap "nohup sleep 1 & exit 0" TERM;  sleep infinity'
ExecStop=/bin/bash -c 'kill -s TERM $MAINPID'
TimeoutSec=0

However, upstream works "fine" because in upstream version of systemd we
actually never wait on processes killed in containers and proceed
immediately to sending SIGKILL hence re-watching of pids in the cgroup
is not necessary. But for the sake of correctness we should merge the
patch also upstream.
 2023-05-23 09:27:56 +02:00
Luca Boccassi
b1f17f78e3 Merge pull request #27739 from dtardon/test-session-properties 
Add a test for org.freedesktop.logind1.Session SetIdleHint
 2023-05-22 23:55:25 +01:00
Daan De Meyer
139b6fb16f mkosi: Make sure persistent journal storage is enabled 
We ship with empty /var, so /var/log/journal does not exist, which
means journald does not do persistent logging. Let's fix that by
setting the config to explicitly enable persistent logging.
 2023-05-22 22:19:41 +02:00
Daan De Meyer
ab45e83fb6 repart: Default to vfat for ESP/XBOOTLDR partitions 
vfat makes a lot more sense than ext4 for these partitions.
 2023-05-22 22:16:32 +02:00
Yu Watanabe
4539bb3b4b Merge pull request #27733 from mrc0mmand/more-test-followups 
test: a couple of follow-ups
 2023-05-23 05:02:36 +09:00
David Tardon
7a501e40ec login: add test for SetIdleHint 2023-05-22 21:20:04 +02:00
David Tardon
b4ad59596d login: do not hardcode tty used in TEST-35-LOGIN 
The test can be run manually outside of CI.
 2023-05-22 21:13:15 +02:00
Luca Boccassi
fa63798a2e man: use setlogmask in LogControl1 example 
Useful to show programs using syslog() how to easily set a mask.
 2023-05-22 18:05:29 +01:00
Frantisek Sumsal
7234a2131b test: use run_testcases() in a few more places 2023-05-22 16:02:49 +02:00
Frantisek Sumsal
587ae50d55 test: add a missing session activation 
Otherwise test_list_user_sessions() would fail unless ordered after
test_session(), which activates the session.
 2023-05-22 16:02:49 +02:00
Frantisek Sumsal
030a516314 test: prefix "internal" stuff with an underscore 
Since bash has no namespaces, let's do the second best thing and prefix
all "internal" stuff with an underscore, to minimize the chance of a name
conflict in the future.
 2023-05-22 16:02:49 +02:00
Frantisek Sumsal
b60d910d12 test: abstract the test case logic into a shared function 2023-05-22 16:02:49 +02:00
Zbigniew Jędrzejewski-Szmek
cb1cc1acd4 Merge pull request #27703 from keszybz/systemd-vconsole-ordering 
Order systemd-vconsole-setup before getty units
 2023-05-22 13:27:33 +02:00
Ronan Pigott
110789987d zsh: amend completion for networkctl edit 2023-05-22 12:14:04 +01:00
Frantisek Sumsal
7942811255 test: fix a typo in the cleanup stuff 2023-05-22 12:39:47 +02:00
Frantisek Sumsal
9a1ebef378 test: avoid memleak when allocation fails 
==8==ERROR: LeakSanitizer: detected memory leaks

Indirect leak of 168 byte(s) in 3 object(s) allocated from:
    #0 0x4a0e6e in __interceptor_calloc /src/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:77:3
    #1 0x4dec61 in calloc (/build/fuzz-bus-match+0x4dec61)
    #2 0x7f7c25e2b92d in bus_match_add_leaf /work/build/../../src/systemd/src/libsystemd/sd-bus/bus-match.c:548:13
    #3 0x7f7c25e2b92d in bus_match_add /work/build/../../src/systemd/src/libsystemd/sd-bus/bus-match.c:886:16
    #4 0x4de864 in LLVMFuzzerTestOneInput /work/build/../../src/systemd/src/libsystemd/sd-bus/fuzz-bus-match.c:83:21
    #5 0x4defc8 in NaloFuzzerTestOneInput (/build/fuzz-bus-match+0x4defc8)
    #6 0x4fdf53 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:611:15
    #7 0x4fd73a in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:514:3
    #8 0x4fee09 in fuzzer::Fuzzer::MutateAndTestOne() /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:757:19
    #9 0x4ffad5 in fuzzer::Fuzzer::Loop(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:895:5
    #10 0x4eee3f in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:912:6
    #11 0x4ef708 in LLVMFuzzerRunDriver /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:925:10
    #12 0x4df225 in main (/build/fuzz-bus-match+0x4df225)
    #13 0x7f7c252e3082 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24082) (BuildId: 1878e6b475720c7c51969e69ab2d276fae6d1dee)

DEDUP_TOKEN: __interceptor_calloc--calloc--bus_match_add_leaf
SUMMARY: AddressSanitizer: 168 byte(s) leaked in 3 allocation(s).

Found by Nallocfuzz.
 2023-05-22 12:39:47 +02:00
Frantisek Sumsal
3575c37169 shared: correctly propagate possible allocation errors 
instead of just asserting in case the memstream couldn't be resized.

Found by Nallocufuzz.
 2023-05-22 12:39:47 +02:00
Yu Watanabe
6554f56361 wait-online: downgrade log level of failure that interface is removed or unmanaged during processing it 
Closing #27145.
 2023-05-22 19:06:06 +09:00
Jan Janssen
f70f992273 boot: Read files in small chunks on broken firmware 
Fixes: #25911
 2023-05-22 10:52:17 +01:00
Yu Watanabe
e7432ed7ca Merge pull request #27726 from yuwata/network-wireguard-doc 
network: update doc
 2023-05-22 16:46:38 +09:00
Daan De Meyer
137f5f9169 Merge pull request #26577 from ChenQi1989/revert-revert-journal 
Revert "Revert "journal: Make sd_journal_previous/next() return 0 at …
 2023-05-22 07:51:01 +02:00
Yu Watanabe
f8c5301e44 man: AllowedIPs= can be specified multiple times 
Closes #27507.
 2023-05-22 14:18:46 +09:00
Yu Watanabe
54189b2ec3 network/wireguard: make AllowedIPs= cleared by specifying an empty string 2023-05-22 14:15:49 +09:00