Daan De Meyer
1731008879
mkosi: Only keep failed test journals and other logs for 7 days
...
The default retention of 90 days seems a bit long, so drop it to 7
days.
2024-04-25 20:51:11 +02:00
Daan De Meyer
4becd5fb73
mkosi: Only archive outputs in systemd and systemd-stable repositories
...
Private forks would very quickly reach their quota or spend lots of
money trying to archive all these artifacts, so let's make sure it
only happens on our own repositories.
2024-04-25 20:51:08 +02:00
Łukasz Stelmach
e85be4983d
Fix _do_log conditions in log_exec_* macros
...
The expression for calculation of the _do_log values in the log_exec_*
macros need to be the same as the unit_log_level_test() function, used
to calculate _do_log in unit.h. The only difference between execute.h
and unit.h is the lack of the Unit structure.
Fixes: b646fc324a ("core: ensure execute/spawn functions can work without Unit object")
Fixes: 210ca71cb5 ("core/execute: clean up log_exec_full_errno and friends")
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com >
2024-04-25 18:24:36 +02:00
Daan De Meyer
2541f28e4b
Merge pull request #32477 from DaanDeMeyer/fixes
...
Various fixes
2024-04-25 18:24:09 +02:00
Luca Boccassi
8e0bd955fe
Merge pull request #32474 from poettering/varlink-no-pidfd
...
varlink: tweak fallback for SO_PEERPIDFD on old kernels
2024-04-25 17:27:18 +02:00
Luca Boccassi
c929c6a987
Merge pull request #32467 from yuwata/network-radv-cleanup
...
undefined
2024-04-25 17:10:27 +02:00
dependabot[bot]
34b795d4e9
build(deps): bump pkg/debian from 733ac7c to 4b1f868
...
Bumps pkg/debian from `733ac7c` to `4b1f868`.
---
updated-dependencies:
- dependency-name: pkg/debian
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com >
2024-04-25 17:07:26 +02:00
Antonio Alvarez Feijoo
5cef6b5393
cryptsetup-tokens: fix pin asserts
...
If a user only presses ENTER when the PIN is requested (without actually typing
the PIN), an assertion is reached and no other unlock method is requested.
```
sh-5.2# systemctl status systemd-cryptsetup@cr_root
× systemd-cryptsetup@cr_root.service - Cryptography Setup for cr_root
Loaded: loaded (/etc/crypttab; generated)
Drop-In: /etc/systemd/system/systemd-cryptsetup@.service.d
└─pcr-signature.conf
Active: failed (Result: core-dump) since Thu 2024-04-25 08:44:30 UTC; 10min ago
Docs: man:crypttab(5)
man:systemd-cryptsetup-generator(8)
man:systemd-cryptsetup@.service(8)
Process: 559 ExecStartPre=/usr/bin/pcr-signature.sh (code=exited, status=0/SUCCESS)
Process: 604 ExecStart=/usr/bin/systemd-cryptsetup attach cr_root /dev/disk/by-uuid/a8cbd937-6975-4e61-9120-ce5c03138700 none x-initrd.attach,tpm2-device=auto (code=dumped, signal=ABRT)
Main PID: 604 (code=dumped, signal=ABRT)
CPU: 19ms
Apr 25 08:44:29 localhost systemd[1]: Starting Cryptography Setup for cr_root...
Apr 25 08:44:30 localhost systemd-cryptsetup[604]: Assertion '!pin || pin_size > 0' failed at src/cryptsetup/cryptsetup-tokens/cryptsetup-token-systemd-tpm2.c:60, function cryptsetup_token_open_pin(). Aborting.
Apr 25 08:44:30 localhost systemd[1]: systemd-cryptsetup@cr_root.service: Main process exited, code=dumped, status=6/ABRT
Apr 25 08:44:30 localhost systemd[1]: systemd-cryptsetup@cr_root.service: Failed with result 'core-dump'.
Apr 25 08:44:30 localhost systemd[1]: Failed to start Cryptography Setup for cr_root.
```
In this case, `cryptsetup_token_open_pin()` receives an empty (non-NULL) `pin`
with `pin_size` equals to 0.
```
🔐 Please enter LUKS2 token PIN:
Breakpoint 3, cryptsetup_token_open_pin (cd=0x5555555744c0, token=0, pin=0x5555555b3cc0 "", pin_size=0, ret_password=0x7fffffffd380,
ret_password_len=0x7fffffffd378, usrptr=0x0) at ../src/cryptsetup/cryptsetup-tokens/cryptsetup-token-systemd-tpm2.c:42
42 void *usrptr /* plugin defined parameter passed to crypt_activate_by_token*() API */) {
(gdb) continue
Assertion '!pin || pin_size > 0' failed at src/cryptsetup/cryptsetup-tokens/cryptsetup-token-systemd-tpm2.c:60, function cryptsetup_token_open_pin(). Aborting.
```
2024-04-25 17:07:11 +02:00
Daan De Meyer
aa976d8788
tree-wide: Use log_setup() everywhere
...
Otherwise the default log target is the console and we won't use
the journal socket even if it is available.
2024-04-25 17:06:43 +02:00
Daan De Meyer
d74ebb175a
mkosi: Make sure systemd-resolved is started on boot
2024-04-25 17:06:42 +02:00
Daan De Meyer
f449a29bb9
portable: Don't fail if /etc/resolv.conf doesn't exist
...
The portable profiles assume /etc/resolv.conf exists, which isn't
always the case. Let's mark the mounts as optional so we don't fail
to start the unit if /etc/resolv.conf doesn't exist.
2024-04-25 17:06:42 +02:00
Daan De Meyer
cf5e1b5d39
test: Skip meson integration tests if SYSTEMD_INTEGRATION_TESTS != 1
...
We cannot mark a test suite as excluded by default in meson. Instead,
let's require that SYSTEMD_INTEGRATION_TESTS=1 and skip any integration
test if it's not set. This is effectively the same as excluding it by
default. If the integration-test option is enabled, we'll set the
environment variable by default, just like we do with SYSTEMD_SLOW_TESTS
and the slow-tests meson option.
2024-04-25 17:06:40 +02:00
Daan De Meyer
ff4fe9dee2
meson: Properly check dependencies of mkosi target
...
Let's insist on mkosi being found if the integration-tests option
is enabled and let's only add dependencies on systemd-journal-remote
and systemd-measure if they're being built. Drop ukify from the list
as its part of public_programs.
2024-04-25 17:06:00 +02:00
Daan De Meyer
a721b93aaa
mkosi: Add squashfs-tools
...
Required for various integration tests.
2024-04-25 17:06:00 +02:00
Lennart Poettering
5693208019
Merge pull request #32441 from poettering/rework-handoff-timestamp
...
pid1: rework handoff timestamp
2024-04-25 15:19:17 +02:00
Lennart Poettering
a3d04419fd
update NEWS
2024-04-25 15:18:07 +02:00
Daan De Meyer
a003244057
Merge pull request #32476 from CodethinkLabs/meson-logs-ci
...
ci: Add the meson logs to failure log artifacts
2024-04-25 15:09:34 +02:00
Richard Maw
292110aa1c
ci: Add the meson logs to failure log artifacts
...
It is not a lot of use to add --debug to tests without it
since only the last 100 lines are printed to console.
2024-04-25 13:05:37 +01:00
Richard Maw
aca6533951
ci: Update mkosi version
...
The change to add microcode support had a bug in ukify handling
that broke when it should have been picked up from ExtraSearchPaths.
2024-04-25 13:05:37 +01:00
Lennart Poettering
3c64aca544
update TODO
2024-04-25 13:40:41 +02:00
Lennart Poettering
be3444f119
execute: make ExecStatus dump more useful by showing passed time
...
Let's show the runtimes of our commands and preparations for them. It's
actually quite interesting, we sometimes are irritatingly slow with our
handoffs.
2024-04-25 13:40:41 +02:00
Lennart Poettering
2b5321817f
swap: hook up with handoff timestamps
2024-04-25 13:40:41 +02:00
Lennart Poettering
19ae89869e
mount: hook up with handoff timestamps
2024-04-25 13:40:41 +02:00
Lennart Poettering
1f41b10ee0
socket: hookup handoff timestamps with processes forked off by socket units
2024-04-25 13:40:41 +02:00
Lennart Poettering
3c1d1ca146
manager: switch service unit type over to using new handoff timestamping logic
...
Also: rename Handover → Handoff. I think it makes it clearer that this
is not really about handing over any resources, but that the executor is
out off the game from that point on.
2024-04-25 13:40:41 +02:00