mirror of
https://github.com/Dasharo/systemd.git
synced 2026-03-06 15:02:31 -08:00
lgtm: beef up list of dangerous/questionnable API calls not to make
This commit is contained in:
@@ -16,10 +16,28 @@ import cpp
|
||||
predicate potentiallyDangerousFunction(Function f, string message) {
|
||||
(
|
||||
f.getQualifiedName() = "fgets" and
|
||||
message = "Call to fgets is potentially dangerous. Use read_line() instead."
|
||||
message = "Call to fgets() is potentially dangerous. Use read_line() instead."
|
||||
) or (
|
||||
f.getQualifiedName() = "strtok" and
|
||||
message = "Call to strtok is potentially dangerous. Use extract_first_word() instead."
|
||||
message = "Call to strtok() is potentially dangerous. Use extract_first_word() instead."
|
||||
) or (
|
||||
f.getQualifiedName() = "strsep" and
|
||||
message = "Call to strsep() is potentially dangerous. Use extract_first_word() instead."
|
||||
) or (
|
||||
f.getQualifiedName() = "dup" and
|
||||
message = "Call to dup() is potentially dangerous. Use fcntl(fd, FD_DUPFD_CLOEXEC, 3) instead."
|
||||
) or (
|
||||
f.getQualifiedName() = "htonl" and
|
||||
message = "Call to htonl() is confusing. Use htobe32() instead."
|
||||
) or (
|
||||
f.getQualifiedName() = "htons" and
|
||||
message = "Call to htons() is confusing. Use htobe16() instead."
|
||||
) or (
|
||||
f.getQualifiedName() = "ntohl" and
|
||||
message = "Call to ntohl() is confusing. Use be32toh() instead."
|
||||
) or (
|
||||
f.getQualifiedName() = "ntohs" and
|
||||
message = "Call to ntohs() is confusing. Use be16toh() instead."
|
||||
)
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user