resolved: return regular varlink invalid parameter error if more is not specified on monitor call

No point in returning EINVAL if we can just return a proper varlink
invalid parameter error
This commit is contained in:
Lennart Poettering
2022-09-28 11:44:57 +02:00
parent 63fe457c1b
commit 43bd70d584

View File

@@ -539,9 +539,9 @@ static int vl_method_subscribe_dns_resolves(Varlink *link, JsonVariant *paramete
m = ASSERT_PTR(varlink_server_get_userdata(varlink_get_server(link)));
/* if the client didn't set the more flag, return an empty response and close the connection */
/* if the client didn't set the more flag, it is using us incorrectly */
if (!FLAGS_SET(flags, VARLINK_METHOD_MORE))
return varlink_error_errno(link, EINVAL);
return varlink_error_invalid_parameter(link, NULL);
if (json_variant_elements(parameters) > 0)
return varlink_error_invalid_parameter(link, parameters);