mirror of
https://github.com/Dasharo/systemd.git
synced 2026-03-06 15:02:31 -08:00
tree-wide: make ++/-- usage consistent WRT spacing
Throughout the tree there's spurious use of spaces separating ++ and -- operators from their respective operands. Make ++ and -- operator consistent with the majority of existing uses; discard the spaces.
This commit is contained in:
@@ -77,7 +77,7 @@ static int open_sockets(int *epoll_fd, bool accept) {
|
||||
if (r < 0)
|
||||
return r;
|
||||
|
||||
count ++;
|
||||
count++;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -105,7 +105,7 @@ static int open_sockets(int *epoll_fd, bool accept) {
|
||||
}
|
||||
|
||||
assert(fd == SD_LISTEN_FDS_START + count);
|
||||
count ++;
|
||||
count++;
|
||||
}
|
||||
|
||||
if (arg_listen)
|
||||
@@ -176,7 +176,7 @@ static int exec_process(const char* name, char **argv, char **env, int start_fd,
|
||||
if (!envp[n_env])
|
||||
return log_oom();
|
||||
|
||||
n_env ++;
|
||||
n_env++;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -191,7 +191,7 @@ static int exec_process(const char* name, char **argv, char **env, int start_fd,
|
||||
if (!envp[n_env])
|
||||
return log_oom();
|
||||
|
||||
n_env ++;
|
||||
n_env++;
|
||||
}
|
||||
|
||||
if (arg_inetd) {
|
||||
|
||||
@@ -290,7 +290,7 @@ int verify_units(char **filenames, ManagerRunningAs running_as, bool check_man)
|
||||
if (r == 0)
|
||||
r = k;
|
||||
} else
|
||||
count ++;
|
||||
count++;
|
||||
}
|
||||
|
||||
for (i = 0; i < count; i++) {
|
||||
|
||||
@@ -1004,7 +1004,7 @@ static int find_next(const CalendarSpec *spec, struct tm *tm, usec_t *usec) {
|
||||
c.tm_hour = c.tm_min = c.tm_sec = tm_usec = 0;
|
||||
}
|
||||
if (r < 0 || tm_out_of_bounds(&c, spec->utc)) {
|
||||
c.tm_year ++;
|
||||
c.tm_year++;
|
||||
c.tm_mon = 0;
|
||||
c.tm_mday = 1;
|
||||
c.tm_hour = c.tm_min = c.tm_sec = tm_usec = 0;
|
||||
@@ -1015,7 +1015,7 @@ static int find_next(const CalendarSpec *spec, struct tm *tm, usec_t *usec) {
|
||||
if (r > 0)
|
||||
c.tm_hour = c.tm_min = c.tm_sec = tm_usec = 0;
|
||||
if (r < 0 || tm_out_of_bounds(&c, spec->utc)) {
|
||||
c.tm_mon ++;
|
||||
c.tm_mon++;
|
||||
c.tm_mday = 1;
|
||||
c.tm_hour = c.tm_min = c.tm_sec = tm_usec = 0;
|
||||
continue;
|
||||
@@ -1031,7 +1031,7 @@ static int find_next(const CalendarSpec *spec, struct tm *tm, usec_t *usec) {
|
||||
if (r > 0)
|
||||
c.tm_min = c.tm_sec = tm_usec = 0;
|
||||
if (r < 0 || tm_out_of_bounds(&c, spec->utc)) {
|
||||
c.tm_mday ++;
|
||||
c.tm_mday++;
|
||||
c.tm_hour = c.tm_min = c.tm_sec = tm_usec = 0;
|
||||
continue;
|
||||
}
|
||||
@@ -1040,7 +1040,7 @@ static int find_next(const CalendarSpec *spec, struct tm *tm, usec_t *usec) {
|
||||
if (r > 0)
|
||||
c.tm_sec = tm_usec = 0;
|
||||
if (r < 0 || tm_out_of_bounds(&c, spec->utc)) {
|
||||
c.tm_hour ++;
|
||||
c.tm_hour++;
|
||||
c.tm_min = c.tm_sec = tm_usec = 0;
|
||||
continue;
|
||||
}
|
||||
@@ -1051,7 +1051,7 @@ static int find_next(const CalendarSpec *spec, struct tm *tm, usec_t *usec) {
|
||||
c.tm_sec /= USEC_PER_SEC;
|
||||
|
||||
if (r < 0 || tm_out_of_bounds(&c, spec->utc)) {
|
||||
c.tm_min ++;
|
||||
c.tm_min++;
|
||||
c.tm_sec = tm_usec = 0;
|
||||
continue;
|
||||
}
|
||||
|
||||
@@ -63,12 +63,12 @@ int extract_first_word(const char **p, char **ret, const char *separators, Extra
|
||||
if (!GREEDY_REALLOC(s, allocated, sz+1))
|
||||
return -ENOMEM;
|
||||
|
||||
for (;; (*p) ++, c = **p) {
|
||||
for (;; (*p)++, c = **p) {
|
||||
if (c == 0)
|
||||
goto finish_force_terminate;
|
||||
else if (strchr(separators, c)) {
|
||||
if (flags & EXTRACT_DONT_COALESCE_SEPARATORS) {
|
||||
(*p) ++;
|
||||
(*p)++;
|
||||
goto finish_force_next;
|
||||
}
|
||||
} else {
|
||||
@@ -81,7 +81,7 @@ int extract_first_word(const char **p, char **ret, const char *separators, Extra
|
||||
}
|
||||
}
|
||||
|
||||
for (;; (*p) ++, c = **p) {
|
||||
for (;; (*p)++, c = **p) {
|
||||
if (backslash) {
|
||||
if (!GREEDY_REALLOC(s, allocated, sz+7))
|
||||
return -ENOMEM;
|
||||
@@ -129,7 +129,7 @@ int extract_first_word(const char **p, char **ret, const char *separators, Extra
|
||||
backslash = false;
|
||||
|
||||
} else if (quote) { /* inside either single or double quotes */
|
||||
for (;; (*p) ++, c = **p) {
|
||||
for (;; (*p)++, c = **p) {
|
||||
if (c == 0) {
|
||||
if (flags & EXTRACT_RELAX)
|
||||
goto finish_force_terminate;
|
||||
@@ -149,7 +149,7 @@ int extract_first_word(const char **p, char **ret, const char *separators, Extra
|
||||
}
|
||||
|
||||
} else {
|
||||
for (;; (*p) ++, c = **p) {
|
||||
for (;; (*p)++, c = **p) {
|
||||
if (c == 0)
|
||||
goto finish_force_terminate;
|
||||
else if ((c == '\'' || c == '"') && (flags & EXTRACT_QUOTES)) {
|
||||
@@ -160,11 +160,11 @@ int extract_first_word(const char **p, char **ret, const char *separators, Extra
|
||||
break;
|
||||
} else if (strchr(separators, c)) {
|
||||
if (flags & EXTRACT_DONT_COALESCE_SEPARATORS) {
|
||||
(*p) ++;
|
||||
(*p)++;
|
||||
goto finish_force_next;
|
||||
}
|
||||
/* Skip additional coalesced separators. */
|
||||
for (;; (*p) ++, c = **p) {
|
||||
for (;; (*p)++, c = **p) {
|
||||
if (c == 0)
|
||||
goto finish_force_terminate;
|
||||
if (!strchr(separators, c))
|
||||
|
||||
@@ -352,7 +352,7 @@ static int parse_env_file_internal(
|
||||
case KEY:
|
||||
if (strchr(newline, c)) {
|
||||
state = PRE_KEY;
|
||||
line ++;
|
||||
line++;
|
||||
n_key = 0;
|
||||
} else if (c == '=') {
|
||||
state = PRE_VALUE;
|
||||
@@ -376,7 +376,7 @@ static int parse_env_file_internal(
|
||||
case PRE_VALUE:
|
||||
if (strchr(newline, c)) {
|
||||
state = PRE_KEY;
|
||||
line ++;
|
||||
line++;
|
||||
key[n_key] = 0;
|
||||
|
||||
if (value)
|
||||
@@ -416,7 +416,7 @@ static int parse_env_file_internal(
|
||||
case VALUE:
|
||||
if (strchr(newline, c)) {
|
||||
state = PRE_KEY;
|
||||
line ++;
|
||||
line++;
|
||||
|
||||
key[n_key] = 0;
|
||||
|
||||
@@ -535,7 +535,7 @@ static int parse_env_file_internal(
|
||||
state = COMMENT_ESCAPE;
|
||||
else if (strchr(newline, c)) {
|
||||
state = PRE_KEY;
|
||||
line ++;
|
||||
line++;
|
||||
}
|
||||
break;
|
||||
|
||||
@@ -908,7 +908,7 @@ int get_proc_field(const char *filename, const char *pattern, const char *termin
|
||||
/* Back off one char if there's nothing but whitespace
|
||||
and zeros */
|
||||
if (!*t || isspace(*t))
|
||||
t --;
|
||||
t--;
|
||||
}
|
||||
|
||||
len = strcspn(t, terminator);
|
||||
|
||||
@@ -276,8 +276,8 @@ int unbase32hexmem(const char *p, size_t l, bool padding, void **mem, size_t *_l
|
||||
if (padding) {
|
||||
/* strip the padding */
|
||||
while (l > 0 && p[l - 1] == '=' && pad < 7) {
|
||||
pad ++;
|
||||
l --;
|
||||
pad++;
|
||||
l--;
|
||||
}
|
||||
}
|
||||
|
||||
@@ -505,7 +505,7 @@ int unbase64char(char c) {
|
||||
if (c == '+')
|
||||
return offset;
|
||||
|
||||
offset ++;
|
||||
offset++;
|
||||
|
||||
if (c == '/')
|
||||
return offset;
|
||||
@@ -621,9 +621,9 @@ int unbase64mem(const char *p, size_t l, void **mem, size_t *_len) {
|
||||
|
||||
/* strip the padding */
|
||||
if (l > 0 && p[l - 1] == '=')
|
||||
l --;
|
||||
l--;
|
||||
if (l > 0 && p[l - 1] == '=')
|
||||
l --;
|
||||
l--;
|
||||
|
||||
/* a group of four input bytes needs three output bytes, in case of
|
||||
padding we need to add two or three extra bytes */
|
||||
|
||||
@@ -123,7 +123,7 @@ bool hostname_is_valid(const char *s, bool allow_trailing_dot) {
|
||||
return false;
|
||||
|
||||
dot = true;
|
||||
n_dots ++;
|
||||
n_dots++;
|
||||
} else {
|
||||
if (!hostname_valid_char(*p))
|
||||
return false;
|
||||
|
||||
@@ -249,7 +249,7 @@ ssize_t sparse_write(int fd, const void *p, size_t sz, size_t run_length) {
|
||||
} else if (n > 0)
|
||||
q += n;
|
||||
else
|
||||
q ++;
|
||||
q++;
|
||||
}
|
||||
|
||||
if (q > w) {
|
||||
|
||||
@@ -121,7 +121,7 @@ static void bubbleinsert(struct strbuf_node *node,
|
||||
sizeof(struct strbuf_child_entry) * (node->children_count - left));
|
||||
node->children[left] = new;
|
||||
|
||||
node->children_count ++;
|
||||
node->children_count++;
|
||||
}
|
||||
|
||||
/* add string, return the index/offset into the buffer */
|
||||
|
||||
@@ -477,7 +477,7 @@ char *ellipsize_mem(const char *s, size_t old_length, size_t new_length, unsigne
|
||||
}
|
||||
|
||||
if (k > x) /* last character was wide and went over quota */
|
||||
x ++;
|
||||
x++;
|
||||
|
||||
for (j = s + old_length; k < new_length && j > i; ) {
|
||||
char32_t c;
|
||||
|
||||
@@ -576,12 +576,12 @@ int parse_timestamp(const char *t, usec_t *usec) {
|
||||
goto from_tm;
|
||||
|
||||
} else if (streq(t, "yesterday")) {
|
||||
tm.tm_mday --;
|
||||
tm.tm_mday--;
|
||||
tm.tm_sec = tm.tm_min = tm.tm_hour = 0;
|
||||
goto from_tm;
|
||||
|
||||
} else if (streq(t, "tomorrow")) {
|
||||
tm.tm_mday ++;
|
||||
tm.tm_mday++;
|
||||
tm.tm_sec = tm.tm_min = tm.tm_hour = 0;
|
||||
goto from_tm;
|
||||
}
|
||||
|
||||
@@ -241,7 +241,7 @@ char *utf8_escape_non_printable(const char *str) {
|
||||
*(s++) = hexchar((int) *str);
|
||||
|
||||
str += 1;
|
||||
len --;
|
||||
len--;
|
||||
}
|
||||
}
|
||||
} else {
|
||||
|
||||
@@ -2237,7 +2237,7 @@ int exec_context_load_environment(Unit *unit, const ExecContext *c, char ***l) {
|
||||
|
||||
if (fn[0] == '-') {
|
||||
ignore = true;
|
||||
fn ++;
|
||||
fn++;
|
||||
}
|
||||
|
||||
if (!path_is_absolute(fn)) {
|
||||
|
||||
@@ -222,7 +222,7 @@ Job* job_install(Job *j) {
|
||||
*pj = j;
|
||||
j->installed = true;
|
||||
|
||||
j->manager->n_installed_jobs ++;
|
||||
j->manager->n_installed_jobs++;
|
||||
log_unit_debug(j->unit,
|
||||
"Installed new job %s/%s as %u",
|
||||
j->unit->id, job_type_to_string(j->type), (unsigned) j->id);
|
||||
@@ -856,7 +856,7 @@ int job_finish_and_invalidate(Job *j, JobResult result, bool recursive) {
|
||||
}
|
||||
|
||||
if (result == JOB_FAILED || result == JOB_INVALID)
|
||||
j->manager->n_failed_jobs ++;
|
||||
j->manager->n_failed_jobs++;
|
||||
|
||||
job_uninstall(j);
|
||||
job_free(j);
|
||||
|
||||
@@ -620,7 +620,7 @@ int config_parse_exec(
|
||||
separate_argv0 = true;
|
||||
else
|
||||
break;
|
||||
f ++;
|
||||
f++;
|
||||
}
|
||||
|
||||
if (isempty(f)) {
|
||||
@@ -668,7 +668,7 @@ int config_parse_exec(
|
||||
/* Check explicitly for an unquoted semicolon as
|
||||
* command separator token. */
|
||||
if (p[0] == ';' && (!p[1] || strchr(WHITESPACE, p[1]))) {
|
||||
p ++;
|
||||
p++;
|
||||
p += strspn(p, WHITESPACE);
|
||||
semicolon = true;
|
||||
break;
|
||||
|
||||
@@ -1073,7 +1073,7 @@ static int prepare_reexecute(Manager *m, FILE **_f, FDSet **_fds, bool switching
|
||||
return log_error_errno(r, "Failed to create serialization file: %m");
|
||||
|
||||
/* Make sure nothing is really destructed when we shut down */
|
||||
m->n_reloading ++;
|
||||
m->n_reloading++;
|
||||
bus_manager_send_reloading(m, true);
|
||||
|
||||
fds = fdset_new();
|
||||
|
||||
@@ -1137,7 +1137,7 @@ int manager_startup(Manager *m, FILE *serialization, FDSet *fds) {
|
||||
* this is already known, so we increase the counter here
|
||||
* already */
|
||||
if (serialization)
|
||||
m->n_reloading ++;
|
||||
m->n_reloading++;
|
||||
|
||||
/* First, enumerate what we can from all config files */
|
||||
dual_timestamp_get(&m->units_load_start_timestamp);
|
||||
@@ -1171,7 +1171,7 @@ int manager_startup(Manager *m, FILE *serialization, FDSet *fds) {
|
||||
|
||||
if (serialization) {
|
||||
assert(m->n_reloading > 0);
|
||||
m->n_reloading --;
|
||||
m->n_reloading--;
|
||||
|
||||
/* Let's wait for the UnitNew/JobNew messages being
|
||||
* sent, before we notify that the reload is
|
||||
@@ -2231,7 +2231,7 @@ int manager_serialize(Manager *m, FILE *f, FDSet *fds, bool switching_root) {
|
||||
assert(f);
|
||||
assert(fds);
|
||||
|
||||
m->n_reloading ++;
|
||||
m->n_reloading++;
|
||||
|
||||
fprintf(f, "current-job-id=%"PRIu32"\n", m->current_job_id);
|
||||
fprintf(f, "taint-usr=%s\n", yes_no(m->taint_usr));
|
||||
@@ -2301,13 +2301,13 @@ int manager_serialize(Manager *m, FILE *f, FDSet *fds, bool switching_root) {
|
||||
|
||||
r = unit_serialize(u, f, fds, !switching_root);
|
||||
if (r < 0) {
|
||||
m->n_reloading --;
|
||||
m->n_reloading--;
|
||||
return r;
|
||||
}
|
||||
}
|
||||
|
||||
assert(m->n_reloading > 0);
|
||||
m->n_reloading --;
|
||||
m->n_reloading--;
|
||||
|
||||
if (ferror(f))
|
||||
return -EIO;
|
||||
@@ -2327,7 +2327,7 @@ int manager_deserialize(Manager *m, FILE *f, FDSet *fds) {
|
||||
|
||||
log_debug("Deserializing state...");
|
||||
|
||||
m->n_reloading ++;
|
||||
m->n_reloading++;
|
||||
|
||||
for (;;) {
|
||||
char line[LINE_MAX], *l;
|
||||
@@ -2495,7 +2495,7 @@ finish:
|
||||
r = -EIO;
|
||||
|
||||
assert(m->n_reloading > 0);
|
||||
m->n_reloading --;
|
||||
m->n_reloading--;
|
||||
|
||||
return r;
|
||||
}
|
||||
@@ -2511,23 +2511,23 @@ int manager_reload(Manager *m) {
|
||||
if (r < 0)
|
||||
return r;
|
||||
|
||||
m->n_reloading ++;
|
||||
m->n_reloading++;
|
||||
bus_manager_send_reloading(m, true);
|
||||
|
||||
fds = fdset_new();
|
||||
if (!fds) {
|
||||
m->n_reloading --;
|
||||
m->n_reloading--;
|
||||
return -ENOMEM;
|
||||
}
|
||||
|
||||
r = manager_serialize(m, f, fds, false);
|
||||
if (r < 0) {
|
||||
m->n_reloading --;
|
||||
m->n_reloading--;
|
||||
return r;
|
||||
}
|
||||
|
||||
if (fseeko(f, 0, SEEK_SET) < 0) {
|
||||
m->n_reloading --;
|
||||
m->n_reloading--;
|
||||
return -errno;
|
||||
}
|
||||
|
||||
|
||||
@@ -942,7 +942,7 @@ static void service_set_state(Service *s, ServiceState state) {
|
||||
if (ec && exec_context_may_touch_console(ec)) {
|
||||
Manager *m = UNIT(s)->manager;
|
||||
|
||||
m->n_on_console --;
|
||||
m->n_on_console--;
|
||||
if (m->n_on_console == 0)
|
||||
/* unset no_console_output flag, since the console is free */
|
||||
m->no_console_output = false;
|
||||
|
||||
@@ -1979,7 +1979,7 @@ static void socket_enter_running(Socket *s, int cfd) {
|
||||
|
||||
service = SERVICE(UNIT_DEREF(s->service));
|
||||
unit_ref_unset(&s->service);
|
||||
s->n_accepted ++;
|
||||
s->n_accepted++;
|
||||
|
||||
UNIT(service)->no_gc = false;
|
||||
|
||||
@@ -1990,7 +1990,7 @@ static void socket_enter_running(Socket *s, int cfd) {
|
||||
goto fail;
|
||||
|
||||
cfd = -1;
|
||||
s->n_connections ++;
|
||||
s->n_connections++;
|
||||
|
||||
r = manager_add_job(UNIT(s)->manager, JOB_START, UNIT(service), JOB_REPLACE, &error, NULL);
|
||||
if (r < 0)
|
||||
|
||||
@@ -472,7 +472,7 @@ static int loopback_points_list_detach(MountPoint **head, bool *changed) {
|
||||
major(root_st.st_dev) != 0 &&
|
||||
lstat(m->path, &loopback_st) >= 0 &&
|
||||
root_st.st_dev == loopback_st.st_rdev) {
|
||||
n_failed ++;
|
||||
n_failed++;
|
||||
continue;
|
||||
}
|
||||
|
||||
@@ -507,7 +507,7 @@ static int dm_points_list_detach(MountPoint **head, bool *changed) {
|
||||
if (k >= 0 &&
|
||||
major(root_st.st_dev) != 0 &&
|
||||
root_st.st_dev == m->devnum) {
|
||||
n_failed ++;
|
||||
n_failed++;
|
||||
continue;
|
||||
}
|
||||
|
||||
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user