mirror of
https://github.com/Dasharo/linux.git
synced 2026-03-06 15:25:10 -08:00
w1: Constify 'struct bin_attribute'
The sysfs core now allows instances of 'struct bin_attribute' to be moved into read-only memory. Make use of that to protect them against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> Link: https://lore.kernel.org/r/20241211-sysfs-const-bin_attr-w1-v1-1-c4befd2aa7cc@weissschuh.net Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
This commit is contained in:
committed by
Krzysztof Kozlowski
parent
5f69c091a6
commit
699e5f2f28
@@ -111,7 +111,7 @@ ATTRIBUTE_GROUPS(w1_slave);
|
||||
/* Default family */
|
||||
|
||||
static ssize_t rw_write(struct file *filp, struct kobject *kobj,
|
||||
struct bin_attribute *bin_attr, char *buf, loff_t off,
|
||||
const struct bin_attribute *bin_attr, char *buf, loff_t off,
|
||||
size_t count)
|
||||
{
|
||||
struct w1_slave *sl = kobj_to_w1_slave(kobj);
|
||||
@@ -130,8 +130,8 @@ out_up:
|
||||
}
|
||||
|
||||
static ssize_t rw_read(struct file *filp, struct kobject *kobj,
|
||||
struct bin_attribute *bin_attr, char *buf, loff_t off,
|
||||
size_t count)
|
||||
const struct bin_attribute *bin_attr, char *buf,
|
||||
loff_t off, size_t count)
|
||||
{
|
||||
struct w1_slave *sl = kobj_to_w1_slave(kobj);
|
||||
|
||||
@@ -141,15 +141,15 @@ static ssize_t rw_read(struct file *filp, struct kobject *kobj,
|
||||
return count;
|
||||
}
|
||||
|
||||
static BIN_ATTR_RW(rw, PAGE_SIZE);
|
||||
static const BIN_ATTR_RW(rw, PAGE_SIZE);
|
||||
|
||||
static struct bin_attribute *w1_slave_bin_attrs[] = {
|
||||
static const struct bin_attribute *const w1_slave_bin_attrs[] = {
|
||||
&bin_attr_rw,
|
||||
NULL,
|
||||
};
|
||||
|
||||
static const struct attribute_group w1_slave_default_group = {
|
||||
.bin_attrs = w1_slave_bin_attrs,
|
||||
.bin_attrs_new = w1_slave_bin_attrs,
|
||||
};
|
||||
|
||||
static const struct attribute_group *w1_slave_default_groups[] = {
|
||||
|
||||
Reference in New Issue
Block a user