Some tools, such as Buildroot, will use packed tarballs of cloned git
repositories and trigger builds for the sources. This results in
flashrom grabbing incorrect git information. The best option is to
solely rely on the VERSION file.
Change-Id: Iac60ae253263eab42361b0f73a9c9c95cd547eb5
Signed-off-by: Jacob Rothbauer <rothbauerj@hotmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/88967
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Vincent Fazio <vfazio@gmail.com>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
To get a fast and easy feedback on how parameters affect runtime
(e.g. clock setting, polling delays, etc).
The runtime is measured starting from programmer_init and to
programmer_shutdown, inclusive. Message is displayed in debug
verbosity level.
Signed-off-by: Simon Buhrow <simon.buhrow@posteo.de>
Change-Id: I2238b3f3e6c2ab7745994662a88787fa2e86d480
Co-Developed-by: Anastasia Klimchuk <aklm@flashrom.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/47805
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
This commit adds check for the flag `verify_after_write` after
erase operation and does not perfom verification if the flag
disabled.
From command line, this is set by --noverify option.
libflashrom flag is FLASHROM_FLAG_VERIFY_AFTER_WRITE
Default stays the same, by default verification is performed.
This commit also adds test for the scenario.
Previously, erase operation ignored --noverify option and always
performed verification.
For more details, see
Ticket: https://ticket.coreboot.org/issues/520
Change-Id: I9f6cb7210f4dcdc32870f9096657a08b12e77c7f
Signed-off-by: Anastasia Klimchuk <aklm@flashrom.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/88734
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Carly Zlabek <carlyzlabek@gmail.com>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-by: Vincent Fazio <vfazio@gmail.com>
The last argument in `prepare_flash_access` function indicates
whether verify operation was requested. This information is
in the flag `verify_after_write` in flash context, so lets pass
it to the function.
Previously, the last argument which is called `verify_it`
was always `false`. This hasn't been detected because in the
current implementation of `prepare_flash_access`,
`verify_it` is always checked together with `erase_it`, the
latter was passed always true.
`verify_it` being false is wrong because we have a flag to decide
about verification. Also this false value contradicts reality,
because erase operation ignores the flag and always verifies
(this has always been the case even with earlier implementations
of erase logic).
Additional context is in the next commit and ticket
https://ticket.coreboot.org/issues/520
Change-Id: Idd7526084e4942b7adbbab57a62f7de84b4a4bb5
Signed-off-by: Anastasia Klimchuk <aklm@flashrom.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/88733
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
The main purpose is to run one operation after the other to
check that data is carried in flash context correctly.
As the most common chains, the first tests perform:
probe+read
probe+write
probe+erase
Change-Id: I9b09e04c7dbee7e7658118d66aacb640885f4d23
Signed-off-by: Anastasia Klimchuk <aklm@flashrom.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/88257
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
TEST=ich_descriptors_tool is able to detect "wildcat" chipset and show
below information:
> ./util/ich_descriptors_tool/ich_descriptors_tool
Need the file name of a descriptor image to read from.
usage: './util/ich_descriptors_tool/ich_descriptors_tool -f
<image file name> [-c <chipset name>] [-d]'
...
...
To also print the data stored in the descriptor straps you have to
indicate the chipset series with the '-c' parameter and one of the
possible arguments:
- "ich8",
- "ich9",
- "ich10",
- "apollo" for Intel's Apollo Lake SoC.
- "gemini" for Intel's Gemini Lake SoC.
- "jasper" for Intel's Jasper Lake SoC.
- "meteor" for Intel's Meteor Lake SoC.
- "panther" for Intel's Panther Lake SoC.
- "wildcat" for Intel's Wildcat Lake SoC.
...
...
- "300" or "cannon" for Intel's 300 series chipsets.
- "400" or "comet" for Intel's 400 series chipsets.
- "500" or "tiger" for Intel's 500 series chipsets.
- "600" or "alder" for Intel's 600 series chipsets.
Change-Id: I2957eab19d8b8fdd2479f7d1b50ecdb48f491954
Signed-off-by: Varun Upadhyay <varun.upadhyay@intel.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/88049
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
We identified somebody whose name was malformed in git history such that
they were credited wrong in the hall of fame, so add some code to handle
names that manage to be committed with incorrect formatting.
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Change-Id: I33b04932403b2d69da4648a3a7016aee57741d0d
Reviewed-on: https://review.coreboot.org/c/flashrom/+/88477
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Building authors/reviewers list (aka Hall of Fame) requires
more modern sphinx version than the rest of documentation. Also
we have separate meson options, `documentation` and
`generate_authors_list`, which both default to `auto`.
Auto mode is expected to check the environment and enable the
option if environment is suitable - or disable otherwise.
The patch check minimun required sphinx version specifically
for building hall of fame, the rest of documentation just checks
that sphinx is present.
So if developer has old version of sphinx, all the documentation
will be built, just without hall of fame.
Without this patch, developer with generate_authors_list=auto
(which is default) and old version of sphinx gets a build error
like this:
Exception occurred:
File "/usr/lib/python3/dist-packages/docutils/nodes.py",
line 652, in __getitem__
return self.attributes[key]
KeyError: 'colwidth'
and a stack trace from sphinx source code
Change-Id: I8f0ae62f33dca04c2c5233ea45c6263f10cbe4f9
Signed-off-by: Anastasia Klimchuk <aklm@flashrom.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/88373
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
