MdeModulePkg/Logo: fallback to builtin logo on error

Returning an error from this function can disable useful functionality
like capsule updates because progress bar treats such errors as fatal...

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
This commit is contained in:
Sergii Dmytruk
2024-09-16 01:08:33 +03:00
committed by Krystian Hebel
parent be7c21835d
commit dc2d484311
+9 -10
View File
@@ -95,20 +95,19 @@ GetImage (
(UINTN*) &(Image->Height),
(UINTN*) &(Image->Width));
if (EFI_ERROR (Status)) {
if (!EFI_ERROR (Status)) {
Image->Bitmap = Blt;
return Status;
}
Image->Bitmap = Blt;
return Status;
} else {
// No logo in CBMEM, fallback to builtin
*Attribute = mLogos[Current].Attribute;
*OffsetX = mLogos[Current].OffsetX;
*OffsetY = mLogos[Current].OffsetY;
return mHiiImageEx->GetImageEx (mHiiImageEx, mHiiHandle, mLogos[Current].ImageId, Image);
DEBUG ((DEBUG_ERROR, "Failed to translate logo image: %r\n", Status));
}
// No or bad logo in CBMEM, fallback to builtin
*Attribute = mLogos[Current].Attribute;
*OffsetX = mLogos[Current].OffsetX;
*OffsetY = mLogos[Current].OffsetY;
return mHiiImageEx->GetImageEx (mHiiImageEx, mHiiHandle, mLogos[Current].ImageId, Image);
}
EDKII_PLATFORM_LOGO_PROTOCOL mPlatformLogo = {