Touch: put the tap-to-reveal pause row back in the in-game menu

Its comment was still there, above the OSD selector, describing a control that no
longer existed -- the row was lost in the port and the setting left with no writer,
so nobody could hide the glyph or bring it back. Reported as the option missing from
the menu, which is what it was.

Goes where the comment says rather than in the touch editor toolbar, which is where
I first put it: this is a pause-button behaviour toggle and belongs with the overlay
controls it was written for.
This commit is contained in:
jpolo1224
2026-08-12 10:22:35 -04:00
parent 5b740f8921
commit 8a6deab362
3 changed files with 13 additions and 9 deletions
@@ -384,8 +384,8 @@ val EN: Map<String, String> = mapOf(
"action.back" to "Back",
"action.cancel" to "Cancel",
"action.remove" to "Remove",
"touch.editor.pauseRevealOn" to "Pause: tap to reveal",
"touch.editor.pauseRevealOff" to "Pause: always visible",
"overlay.pauseTapReveal.label" to "Tap to reveal pause button",
"overlay.pauseTapReveal.desc" to "Keeps the pause glyph hidden until you tap the top-right corner. That corner always opens this menu either way.",
"packages.licence.remove" to "Remove",
"packages.licence.remove.title" to "Remove this licence?",
"packages.licence.remove.body" to "%s will be deleted. Content it unlocks will stop working until the licence is installed again.",
@@ -655,6 +655,17 @@ private fun SessionPane(state: EmulationMenuUiState, viewModel: EmulationMenuVie
// "tap to reveal", NOT show/hide: on = the glyph stays hidden until you tap its top-right
// corner, which surfaces it. Either way that corner always opens this menu, so unlike the
// old on/off toggle there's no setting here that can lock you out of it.
//
// The comment above outlived its control: the row was lost somewhere in the port and the
// setting was left with no writer at all, so the glyph could not be hidden or brought back
// by anyone. Reported as the option missing from this menu, which is exactly what it was.
MenuSwitchRow(
str("overlay.pauseTapReveal.label"),
com.armsx2.ui.touch.TouchControls.pauseTapToReveal.value,
description = str("overlay.pauseTapReveal.desc"),
) { v ->
com.armsx2.ui.touch.TouchControls.setPauseTapToReveal(v)
}
// Removed: PS2 per-primitive filtering; use Anisotropic Filtering.
Spacer(Modifier.height(6.dp))
// OSD mode selector — one control (Full / Minimal / Custom / Off) in place of the old
@@ -1997,13 +1997,6 @@ private fun EditToolbar(modifier: Modifier = Modifier) {
ToolbarChip(if (TouchControls.faceMultiTouch.value) str("touch.editor.multiTouchOn") else str("touch.editor.multiTouchOff")) {
TouchControls.setFaceMultiTouch(!TouchControls.faceMultiTouch.value)
}
// Tap-to-reveal pause. The setting has existed since the pause button moved to the
// top-right, seeded from the old show/hide pref, but nothing ever wrote it: anyone
// whose button was visible had no way to hide it, and anyone migrated into hidden had
// no way back. Reported as the option being missing from the in-game menu.
ToolbarChip(if (TouchControls.pauseTapToReveal.value) str("touch.editor.pauseRevealOn") else str("touch.editor.pauseRevealOff")) {
TouchControls.setPauseTapToReveal(!TouchControls.pauseTapToReveal.value)
}
// Touch Gliding: drag a finger to hold every button it crosses (NetherSX2-style).
ToolbarChip(if (TouchControls.touchGliding.value) str("touch.editor.glidingOn") else str("touch.editor.glidingOff")) {
TouchControls.setTouchGliding(!TouchControls.touchGliding.value)