armsx/ARMSX3
0
0
Fork 0
mirror of https://github.com/ARMSX2/ARMSX3.git synced 2026-08-24 16:58:52 -07:00
Code Issues Packages Projects Releases Wiki Activity

PPU: stop on a compile out-of-memory rather than limping on

Browse Source 
Continuing with the modules that did compile is correct -- the dispatcher
entry for an uncompiled function interprets, nothing runs garbage -- but it is
per-instruction dispatch and it is slower than the interpreter outright. Saint
Seiya measured 6fps against 23 with most of its modules missing.

A game at that speed looks broken, and it gets reported as broken, when the
real answer is one restart away. An honest stop is better than a degraded run
that invites the wrong bug report.

So this ends the boot the way running out of memory always did. What is
different from before is the reason: the message names it and says what to do,
and it stays on screen because the overlay is drawn by the RSX thread rather
than the one this stops.

The fallback itself stays in place for the ordinary case of a single module
failing for some other reason, which is upstream's design and is worth keeping
-- one bad module costing its own functions is a fair trade. Running out of
memory is not that case: it takes most of the executable with it.
This commit is contained in:
jpolo1224
2026-08-20 00:33:33 -04:00
parent 187654eae6
commit 07a24cf71d
1 changed files with 22 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
rpcs3/Emu/Cell/PPUThread.cpp
+22 -3
View File
@@ -5729,10 +5729,29 @@ bool ppu_initialize(const ppu_module<lv2_obj>& info, bool check_only, u64 file_s
{
// std::string, not a literal: message_item is only instantiated for std::string
// and localized_string_id, so a const char* fails to link.
//
// Queued before the throw below, and it survives it: the overlay is drawn by the RSX
// thread, which is not the thread this kills.
rsx::overlays::queue_message(
std::string("Ran out of memory while compiling. Some functions will run slowly.\n"
"Close the game and start it again to compile the rest -- progress is kept."),
10'000'000);
std::string("Ran out of memory while compiling.\n"
"Close the game and start it again -- what already compiled is kept, so each "
"attempt gets further."),
30'000'000);
// Stop rather than limp.
//
// Everything that failed here would fall back to ppu_recompiler_fallback, which is
// correct -- the dispatcher entry interprets, nothing runs garbage -- but it is
// per-instruction dispatch, and it is slower than the interpreter outright. Saint
// Seiya measured 6fps against 23 with most of its modules missing. A game at that
// speed looks broken, and it gets reported as broken, when the real answer is one
// restart away.
//
// So this is a deliberate choice of an honest stop over a degraded run. It kills this
// thread the way running out of memory always did; what is different is that the
// reason is now on screen instead of being left to guess at.
fmt::throw_exception("Out of memory while compiling PPU modules -- restart the game to "
"continue compiling. Modules that already compiled are cached.");
}
}