armsx/ARMSX2
0
0
Fork 0
mirror of https://github.com/ARMSX2/ARMSX2.git synced 2026-08-24 16:50:16 -07:00
Code Issues Packages Projects Releases Wiki Activity

GS/Vulkan: atomic pipeline-cache write to prevent corruption on kill

Browse Source
This commit is contained in:
jpolo1224
2026-07-01 11:55:02 -04:00
parent 06aa3dc4ce
commit eccb320287
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ARMSX2/app/src/main/cpp/pcsx2/GS/Renderers/Vulkan/VKShaderCache.cpp
+9 -1
View File
@@ -616,9 +616,17 @@ bool VKShaderCache::FlushPipelineCache()
if (!FileSystem::StatFile(m_pipeline_cache_filename.c_str(), &sd) || sd.Size != static_cast<s64>(data_size))
{
Console.WriteLn("Writing %zu bytes to '%s'", data_size, m_pipeline_cache_filename.c_str());
if (!FileSystem::WriteBinaryFile(m_pipeline_cache_filename.c_str(), data.data(), data.size()))
// @@ARMSX2_VKCACHE_ATOMIC@@ Stage to a temp file then rename over the real one. A swipe-kill
// or crash mid-write otherwise leaves a half-written pipeline cache that some drivers (Adreno)
// still accept past the header check and then render garbage from — the "corrupt VK cache"
// bug that manifested as dark/purple textures until the cache was manually cleared. rename()
// is atomic on POSIX, so the previous valid cache survives a failed/interrupted write.
const std::string tmp_filename = m_pipeline_cache_filename + ".tmp";
if (!FileSystem::WriteBinaryFile(tmp_filename.c_str(), data.data(), data.size()) ||
!FileSystem::RenamePath(tmp_filename.c_str(), m_pipeline_cache_filename.c_str()))
{
Console.Error("Failed to write pipeline cache to '%s'", m_pipeline_cache_filename.c_str());
FileSystem::DeleteFilePath(tmp_filename.c_str());
return false;
}
}