armsx/ARMSX2
0
0
Fork 0
mirror of https://github.com/ARMSX2/ARMSX2.git synced 2026-08-24 16:50:16 -07:00
Code Issues Packages Projects Releases Wiki Activity

GS: correct the textureCompressionBC comment on the replacement decode path

Browse Source 
The comment asserted as fact that Vulkan textureCompressionBC is false on
"Adreno 650 / Snapdragon 865, and Mesa Turnip on any Adreno". Neither holds:
Turnip reports it true, and on Adreno 650 the Qualcomm blob gained BC at driver
512.614 (vulkan.gpuinfo.org splits cleanly across that revision). It is a driver
property, not a hardware one.

No behaviour change -- the CPU decode is already gated on the runtime feature
bits. The comment sent an investigation down the wrong path, which is the cost
being fixed here.
This commit is contained in:
Brian Degenhardt
2026-07-26 22:16:54 -07:00
parent a5bf32fa92
commit b2d57d93f6
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pcsx2/GS/Renderers/HW/GSTextureReplacementLoaders.cpp
+4 -2
View File
@@ -475,8 +475,10 @@ static bool ParseDDSHeader(std::FILE* fp, DDSLoadInfo* info)
const GSDevice::FeatureSupport features(g_gs_device->Features());
// Mobile GPUs frequently expose no BC/BPTC support at all (Vulkan
// textureCompressionBC false: Adreno 650 / Snapdragon 865, and Mesa Turnip on any
// Adreno). Rejecting the file there silently drops the ENTIRE pack — and for packs
// textureCompressionBC false). It is driver-dependent rather than a property of the
// hardware: on Adreno 650 the Qualcomm blob gained BC at driver 512.614 (vulkan.gpuinfo.org
// splits cleanly across that revision), and Mesa Turnip reports it true. Rejecting the file
// on a driver that lacks it silently drops the ENTIRE pack — and for packs
// that also ship game-side data the result is worse than "no upscale": the P3P Slim
// Font mod pairs new FONT0.FNT glyph metrics with BC7 replacement glyphs, so with
// the textures dropped the game indexes the new narrow metrics into the old wide