Files
linux/include/linux
Konstantin Khlebnikov b9ea25152e page_writeback: clean up mess around cancel_dirty_page()
This patch replaces cancel_dirty_page() with a helper function
account_page_cleaned() which only updates counters.  It's called from
truncate_complete_page() and from try_to_free_buffers() (hack for ext3).
Page is locked in both cases, page-lock protects against concurrent
dirtiers: see commit 2d6d7f9828 ("mm: protect set_page_dirty() from
ongoing truncation").

Delete_from_page_cache() shouldn't be called for dirty pages, they must
be handled by caller (either written or truncated).  This patch treats
final dirty accounting fixup at the end of __delete_from_page_cache() as
a debug check and adds WARN_ON_ONCE() around it.  If something removes
dirty pages without proper handling that might be a bug and unwritten
data might be lost.

Hugetlbfs has no dirty pages accounting, ClearPageDirty() is enough
here.

cancel_dirty_page() in nfs_wb_page_cancel() is redundant.  This is
helper for nfs_invalidate_page() and it's called only in case complete
invalidation.

The mess was started in v2.6.20 after commits 46d2277c79 ("Clean up
and make try_to_free_buffers() not race with dirty pages") and
3e67c0987d ("truncate: clear page dirtiness before running
try_to_free_buffers()") first was reverted right in v2.6.20 in commit
ecdfc9787f ("Resurrect 'try_to_free_buffers()' VM hackery"), second in
v2.6.25 commit a2b345642f ("Fix dirty page accounting leak with ext3
data=journal").

Custom fixes were introduced between these points.  NFS in v2.6.23, commit
1b3b4a1a2d ("NFS: Fix a write request leak in nfs_invalidate_page()").
Kludge in __delete_from_page_cache() in v2.6.24, commit 3a6927906f ("Do
dirty page accounting when removing a page from the page cache").  Since
v2.6.25 all of them are redundant.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Tejun Heo <tj@kernel.org>
Cc: Jan Kara <jack@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2015-04-14 16:49:01 -07:00
..
2015-02-19 13:31:40 +03:00
2015-03-29 16:17:10 +01:00
2014-12-15 18:19:03 -08:00
2015-01-29 10:49:28 +02:00
2015-04-07 11:17:34 +02:00
2015-03-11 15:56:59 -07:00
2014-12-18 19:08:10 -08:00
2015-02-12 18:54:15 -08:00
2014-12-19 22:55:06 +01:00
2015-03-25 14:53:58 +01:00
2015-01-21 19:21:30 +01:00
2014-12-31 13:06:50 -05:00
2015-01-25 23:17:28 -05:00
2015-04-06 17:50:59 -04:00
2015-02-18 15:08:33 +01:00
2015-01-27 11:09:13 +01:00
2015-01-15 10:34:54 +01:00
2015-01-15 10:34:54 +01:00
2015-02-13 21:21:36 -08:00
2015-02-17 14:34:51 -08:00
2014-12-18 09:39:51 +01:00
2015-01-04 23:11:43 -05:00
2015-04-10 08:27:18 -05:00
2015-01-25 23:17:28 -05:00
2015-02-17 14:34:52 -08:00
2015-01-06 11:01:13 -08:00
2015-02-16 17:56:03 -08:00
2015-02-24 08:44:16 +01:00
2015-02-13 21:21:41 -08:00
2015-01-22 15:10:56 +01:00
2015-01-03 14:32:57 -05:00
2015-02-13 21:21:35 -08:00
2015-03-25 13:28:58 +01:00
2015-02-17 22:21:11 -05:00
2014-12-15 23:49:28 +02:00