mirror of
https://github.com/armbian/linux.git
synced 2026-01-06 10:13:00 -08:00
ALSA: hda - Fix wrong gpio_dir & gpio_mask hint setups for IDT/STAC codecs
commit c507de88f6 upstream.
stac_store_hints() does utterly wrong for masking the values for
gpio_dir and gpio_data, likely due to copy&paste errors. Fortunately,
this feature is used very rarely, so the impact must be really small.
Reported-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
a26f3d7af4
commit
c5bcceb0e6
@@ -573,9 +573,9 @@ static void stac_store_hints(struct hda_codec *codec)
|
||||
spec->gpio_mask;
|
||||
}
|
||||
if (get_int_hint(codec, "gpio_dir", &spec->gpio_dir))
|
||||
spec->gpio_mask &= spec->gpio_mask;
|
||||
if (get_int_hint(codec, "gpio_data", &spec->gpio_data))
|
||||
spec->gpio_dir &= spec->gpio_mask;
|
||||
if (get_int_hint(codec, "gpio_data", &spec->gpio_data))
|
||||
spec->gpio_data &= spec->gpio_mask;
|
||||
if (get_int_hint(codec, "eapd_mask", &spec->eapd_mask))
|
||||
spec->eapd_mask &= spec->gpio_mask;
|
||||
if (get_int_hint(codec, "gpio_mute", &spec->gpio_mute))
|
||||
|
||||
Reference in New Issue
Block a user