armbian/linux-rockchip
0
0
Fork 0
mirror of https://github.com/armbian/linux-rockchip.git synced 2026-01-06 11:08:10 -08:00
Code Issues Packages Projects Releases Wiki Activity

rpmsg: rockchip: Don't send notification until last_tx_done() is ok

Browse Source 
RPMSG notify function sends a notification to the remote
side when the ring buffer updated, without needing an
immediate response. The remote side can then process
multiple data packets simultaneously.

Signed-off-by: Zain Wang <wzz@rock-chips.com>
Change-Id: Id1dd2d52e5587c319a8530272fe4fd818b7d1509
This commit is contained in:
Zain Wang
2024-06-25 14:35:08 +08:00
committed by Tao Huang
parent a9cae56903
commit c0b3b0aa04
1 changed files with 20 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
drivers/rpmsg/rockchip_rpmsg_mbox.c
View File

@@ -41,7 +41,7 @@ struct rk_rpmsg_dev {
struct platform_device *pdev;
int vdev_nums;
unsigned int link_id;
int first_notify;
bool need_notify;
u32 flags;
struct mbox_client mbox_rx_cl;
struct mbox_client mbox_tx_cl;
@@ -125,15 +125,28 @@ static bool rk_rpmsg_notify(struct virtqueue *vq)
link_id = rpdev->link_id;
if ((rpdev->first_notify == 0) && (rpvq->queue_id % 2 == 0)) {
/* first_notify is used in the master init handshake phase. */
dev_dbg(dev, "rpmsg first_notify\n");
rpdev->first_notify++;
if ((!rpdev->need_notify) && (rpvq->queue_id % 2 == 0)) {
/* first notify is used in the master init handshake phase. */
dev_dbg(dev, "rpmsg handshake notify\n");
} else if (rpvq->queue_id % 2 == 0) {
/* tx done is not supported, so ignored */
return true;
}
if (!rpdev->mbox_tx_chan->mbox->ops->last_tx_done(rpdev->mbox_tx_chan)) {
/*
* Mailbox BUSY means remote side has not processed previous
* notification. The remote side will process all availd
* messages after meeting the last notification.
*/
return true;
}
if (rpdev->need_notify)
mbox_client_txdone(rpdev->mbox_tx_chan, 0);
else
rpdev->need_notify = true;
tx_msg = kzalloc(sizeof(*tx_msg), GFP_KERNEL);
if (!tx_msg) {
dev_err(dev, "Can not get memory for tx_msg\n");
@@ -341,7 +354,7 @@ static int rockchip_rpmsg_probe(struct platform_device *pdev)
dev_info(dev, "rockchip rpmsg platform probe.\n");
rpdev->pdev = pdev;
rpdev->first_notify = 0;
rpdev->need_notify = false;
cl = &rpdev->mbox_rx_cl;
cl->dev = dev;
cl->rx_callback = rk_rpmsg_rx_callback;
@@ -358,6 +371,7 @@ static int rockchip_rpmsg_probe(struct platform_device *pdev)
cl->dev = dev;
cl->rx_callback = rk_rpmsg_tx_callback;
cl->tx_done = rk_rpmsg_xfer_done;
cl->knows_txdone = true;
rpdev->mbox_tx_chan = mbox_request_channel_byname(cl, "rpmsg-tx");
if (IS_ERR(rpdev->mbox_tx_chan)) {