When the X-Forwarded-Proto request header is set, the /status endpoint is expected to send the related X-Request-Scheme response header.
Additionally this commit removes unused imports and two trailing spaces.
Only the required methods from json and os modules are imported and the module prefix on method calls removed accordingly.
mirror_path and userdata_path variables are assigned only once if the related environment variable is present.
The userdata_path variable is only assigned in "dl_map" mode.
Signed-off-by: MichaIng <micha@dietpi.com>
and pass it via response header for testing and debugging purpose.
Signed-off-by: MichaIng <micha@dietpi.com>
Co-authored-by: MichaIng <micha@dietpi.com>
* [AR-604] Preserve protocol from client request if not given in mirror list
Currently redirects are done based on a mirror list with hardcoded URL scheme/protocol. This causes issues when either the client does not support the target protocol (e.g. no HTTPS support) or if the client does not allow its HTTPS request to be downgraded to plain HTTP, either in general or due to respected HSTS information. The usually expected behaviour for redirects is to preserve the protocol of the client request and in case leave HTTPS upgrades to be done by the target server.
This commit aims to implement that behaviour in an optional non-breaking way:
- If the protocol is given in the mirror list, it is used like before. This allows to force a protocol by the router, in case the mirror is not assured to support what the client requests. It is better to let the client decide whether to accept the protocol change or not, instead of letting it doing a request which is doomed to fail.
- If the protocol is not given in the mirror list, it is derived from the client's request scheme. This means that the mirror list needs to be changed for this commit to have any effect.
Signed-off-by: MichaIng <micha@dietpi.com>
* [AR-604] Remove scheme from mirrors with support HTTP + HTTPS
With PR https://github.com/armbian/dl-router/pull/14 mirrors are allowed to be given without URL scheme/protocol in the list file, in which case the client's request protocol is preserved. All currently active mirrors have been tested to support both HTTP and HTTPS and having no forced HTTP => HTTPS redirect. Some mirrors respond with a HSTS header, when connecting via HTTPS, but this cannot break any client request, as obviously the client supports HTTPS when it received the HSTS header once.
The "minio.k-space.ee" mirror is the only one with a forced HTTP => HTTPS redirect, but it is currently not in use. If this mirrors gets re-enabled, to avoid doubled redirects, it makes sense to leave the scheme in place.
Signed-off-by: MichaIng <micha@dietpi.com>
