b3db80f77a
alarmtimer: Implement timer_rearm() callback
...
Preparatory change to utilize the common posix timer mechanisms.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211657.434598989@linutronix.de
2017-06-04 15:40:30 +02:00
eae1c4ae27
posix-timers: Make use of cancel/arm callbacks
...
Replace the hrtimer calls by calls to the new try_to_cancel()/arm() kclock
callbacks and move the hrtimer specific implementation into the
corresponding callback functions.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211657.355396667@linutronix.de
2017-06-04 15:40:29 +02:00
525b8ed916
posix-timers: Add cancel/arm callbacks
...
Add timer_try_to_cancel() and timer_arm() callbacks to kclock which allow
to make common_timer_set() usable by both hrtimer and alarmtimer based
clocks.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211657.278022962@linutronix.de
2017-06-04 15:40:28 +02:00
eabdec0438
posix-timers: Zero settings value in common code
...
Zero out the settings struct in the common code so the callbacks do not
have to do it themself.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211657.200870713@linutronix.de
2017-06-04 15:40:28 +02:00
91d57bae08
posix-timers: Make use of forward/remaining callbacks
...
Replace the hrtimer calls by calls to the new forward/remaining kclock
callbacks and move the hrtimer specific implementation into the
corresponding callback functions.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211657.121437232@linutronix.de
2017-06-04 15:40:27 +02:00
63841b2a69
posix-timers: Add forward/remaining callbacks
...
Add two callbacks to kclock which allow using common_)timer_get() for both
hrtimer and alarm timer based clocks.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211657.044915536@linutronix.de
2017-06-04 15:40:27 +02:00
21e55c1f83
posix-timers: Add active flag to k_itimer
...
Keep track of the activation state of posix timers. This is a preparatory
change for making common_timer_get() usable by both hrtimer and alarm timer
implementations.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211656.967783982@linutronix.de
2017-06-04 15:40:26 +02:00
f37fb0aa4f
posix-timers: Use timer_rearm() callback in posixtimer_rearm()
...
Use the new timer_rearm() callback to replace the conditional hardcoded
calls into the hrtimer and cpu timer code.
This allows later to bring the same logic to alarmtimers.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211656.889661919@linutronix.de
2017-06-04 15:40:26 +02:00
96fe3b072f
posix-timers: Rename do_schedule_next_timer
...
That function is a misnomer. Rename it with a proper prefix to
posixtimer_rearm().
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211656.811362578@linutronix.de
2017-06-04 15:40:25 +02:00
3080294589
posix-timers: Add timer_rearm() callback
...
Add a timer_rearm() callback which is used to make the rescheduling of
posix interval timers independent of the underlying clock implementation.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211656.732632167@linutronix.de
2017-06-04 15:40:25 +02:00
d97bb75ddd
posix-timers: Store k_clock pointer in k_itimer
...
Having the k_clock pointer in the k_itimer struct avoids the lookup in
several code pathes and makes the next steps of unification of the hrtimer
and alarmtimer based posix timers simpler.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211656.641222072@linutronix.de
2017-06-04 15:40:25 +02:00
80105cd0e6
posix-timers: Move interval out of the union
...
Preparatory patch to unify the alarm timer and hrtimer based posix interval
timer handling.
The interval is used as a criteria for rearming decisions so moving it out
of the clock specific data structures allows later unification.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211656.563922908@linutronix.de
2017-06-04 15:40:24 +02:00
af888d677a
posix-timers: Unify overrun/requeue_pending handling
...
hrtimer based posix-timers and posix-cpu-timers handle the update of the
rearming and overflow related status fields differently.
Move that update to the common rearming code.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211656.484936964@linutronix.de
2017-06-04 15:40:24 +02:00
bab0aae9dc
posix-timers: Move posix-timer internals to core
...
None of these declarations is required outside of kernel/time. Move them to
an internal header.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Cc: Christoph Hellwig <hch@lst.de >
Link: http://lkml.kernel.org/r/20170530211656.394803853@linutronix.de
2017-06-04 15:40:23 +02:00
03676b41a8
posix-timers: Cleanup struct k_itimer
...
As a preparation for further changes, cleanup the formatting of the
k_itimer structure and add kernel doc comments.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211656.316574129@linutronix.de
2017-06-04 15:40:23 +02:00
6631fa12c1
posix-timers: Avoid gazillions of forward declarations
...
Move it below the actual implementations as there are new callbacks coming
which would require even more forward declarations.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211656.238209952@linutronix.de
2017-06-04 15:40:23 +02:00
3a06c7ac24
posix-clocks: Remove interval timer facility and mmap/fasync callbacks
...
The only user of this facility is ptp_clock, which does not implement any of
those functions.
Remove them to prevent accidental users. Especially the interval timer
interfaces are now more or less impossible to implement because the
necessary infrastructure has been confined to the core code. Aside of that
it's really complex to make these callbacks implemented according to spec
as the alarm timer implementation demonstrates. If at all then a nanosleep
callback might be a reasonable extension. For now keep just what ptp_clock
needs.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211656.145036286@linutronix.de
2017-06-04 15:40:22 +02:00
a81129e5a1
posix-timers: Remove unused export of posix_timer_event()
...
Since the removal of the mmtimer driver the export is not longer needed.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211656.052744418@linutronix.de
2017-06-04 15:40:22 +02:00
18c700c4e3
alarmtimer: Remove pointless config conditional
...
Having a IF_ENABLED(CONFIG_POSIX_TIMERS) inside of a
#ifdef CONFIG_POSIX_TIMERS section is pointless.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: John Stultz <john.stultz@linaro.org >
Link: http://lkml.kernel.org/r/20170530211655.975218056@linutronix.de
2017-06-04 15:40:22 +02:00
978267b643
Merge branch 'timers/urgent' into WIP.timers
...
Pick up urgent fixes to avoid conflicts.
2017-06-04 15:21:52 +02:00
ff86bf0c65
alarmtimer: Rate limit periodic intervals
...
The alarmtimer code has another source of potentially rearming itself too
fast. Interval timers with a very samll interval have a similar CPU hog
effect as the previously fixed overflow issue.
The reason is that alarmtimers do not implement the normal protection
against this kind of problem which the other posix timer use:
timer expires -> queue signal -> deliver signal -> rearm timer
This scheme brings the rearming under scheduler control and prevents
permanently firing timers which hog the CPU.
Bringing this scheme to the alarm timer code is a major overhaul because it
lacks all the necessary mechanisms completely.
So for a quick fix limit the interval to one jiffie. This is not
problematic in practice as alarmtimers are usually backed by an RTC for
suspend which have 1 second resolution. It could be therefor argued that
the resolution of this clock should be set to 1 second in general, but
that's outside the scope of this fix.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: Kostya Serebryany <kcc@google.com >
Cc: syzkaller <syzkaller@googlegroups.com >
Cc: John Stultz <john.stultz@linaro.org >
Cc: Dmitry Vyukov <dvyukov@google.com >
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20170530211655.896767100@linutronix.de
2017-06-04 15:21:18 +02:00
f4781e76f9
alarmtimer: Prevent overflow of relative timers
...
Andrey reported a alartimer related RCU stall while fuzzing the kernel with
syzkaller.
The reason for this is an overflow in ktime_add() which brings the
resulting time into negative space and causes immediate expiry of the
timer. The following rearm with a small interval does not bring the timer
back into positive space due to the same issue.
This results in a permanent firing alarmtimer which hogs the CPU.
Use ktime_add_safe() instead which detects the overflow and clamps the
result to KTIME_SEC_MAX.
Reported-by: Andrey Konovalov <andreyknvl@google.com >
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: Peter Zijlstra <peterz@infradead.org >
Cc: Kostya Serebryany <kcc@google.com >
Cc: syzkaller <syzkaller@googlegroups.com >
Cc: John Stultz <john.stultz@linaro.org >
Cc: Dmitry Vyukov <dvyukov@google.com >
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/20170530211655.802921648@linutronix.de
2017-06-04 15:21:18 +02:00
6bc51cbaa9
signal: Remove non-uapi <asm/siginfo.h>
...
By moving the kernel side __SI_* defintions right next to the userspace
ones we can kill the non-uapi versions of <asm/siginfo.h> include
include/asm-generic/siginfo.h and untangle the unholy mess of includes.
[ tglx: Removed uapi/asm/siginfo.h from m32r, microblaze, mn10300 and score ]
Signed-off-by: Christoph Hellwig <hch@lst.de >
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: linux-arch@vger.kernel.org
Cc: Fenghua Yu <fenghua.yu@intel.com >
Cc: Tony Luck <tony.luck@intel.com >
Cc: linux-ia64@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de >
Cc: sparclinux@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net >
Link: http://lkml.kernel.org/r/20170603190102.28866-6-hch@lst.de
2017-06-04 15:11:47 +02:00
b9253a4337
signal: Move copy_siginfo_to_user to <linux/signal.h>
...
Having it in asm-generic/siginfo.h doesn't make any sense as it is in no way
architecture specific. Move it to signal.h instead where several related
functions already reside.
Signed-off-by: Christoph Hellwig <hch@lst.de >
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: linux-arch@vger.kernel.org
Cc: Fenghua Yu <fenghua.yu@intel.com >
Cc: Tony Luck <tony.luck@intel.com >
Cc: linux-ia64@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de >
Cc: sparclinux@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net >
Link: http://lkml.kernel.org/r/20170603190102.28866-5-hch@lst.de
2017-06-04 15:11:46 +02:00
31ea70e030
posix-timers: Move the do_schedule_next_timer declaration
...
Having it in asm-generic/siginfo.h doesn't make any sense as it is in no way
architecture specific. Move it to posix-timers.h instead.
Signed-off-by: Christoph Hellwig <hch@lst.de >
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
Cc: linux-arch@vger.kernel.org
Cc: Fenghua Yu <fenghua.yu@intel.com >
Cc: Tony Luck <tony.luck@intel.com >
Cc: linux-ia64@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de >
Cc: sparclinux@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net >
Link: http://lkml.kernel.org/r/20170603190102.28866-4-hch@lst.de
2017-06-04 15:11:46 +02:00
Thomas Gleixner
Christoph Hellwig