Peter Hurley
998b4a4571
tty: Improve tty_debug() macro
...
Incorporate suggestions for tty core debug macro improvements
- printk(KERN_DEBUG) => pr_debug()
- ##args => ##__VA_ARGS__
- remove do {} while()
- output tty_name() first
cc: Joe Perches <joe@perches.com >
Signed-off-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Russell King
9f25bc510e
tty: amba-pl011: prepare REG_* register indexes
...
Prepare for REG_* register accessors. This change involves introducing
pl011_reg_to_offset() to convert REG_* to the hardware register offset,
and converting all call sites to use REG_* names. We need to fix up
locations where we check for equivalence of register offsets as well.
Much of this change was made via these sed expressions:
s/ST_UART01[1x]\(_[^_]*\|_LCRH_[TR]X\)\>/REG_ST\1/
s/UART01[1x]_\(DR\|RSR\|ECR\|FR\|ILPR\|[IF]BRD\|LCRH\|CR\|IFLS\|IMSC\|RIS\|MIS\|ICR\|DMACR\)\>/REG_\1/g
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk >
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Russell King
7fe9a5a9d9
tty: amba-pl011: add helper to detect split LCRH register
...
Add a helper to detect the split LCRH register found on ST variants.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk >
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Russell King
b2a4e24c2e
tty: amba-pl011: convert accessor functions to take uart_amba_port
...
Convert the new accessor functions to take the uart_amba_port instead
of the port base address.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk >
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Russell King
7583633921
tty: amba-pl011: add register accessor functions
...
Add register accessor functions to amba-pl011. Much of this
transformation was done using the sed expression below, with any
left-overs fixed up manually afterwards, and code formatted to remain
within coding style.
s/readw(\(uap->port.membase\|regs\|port->membase\) +/pl011_read(\1,/g
s/writew(\(.*\) +/pl011_write(\1,/g
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk >
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Masahiro Yamada
bd94c4077a
serial: support 16-bit register interface for console
...
Currently, 8-bit (MMIO) and 32-bit (MMIO32) register interfaces are
supported for the 8250 console, but the 16-bit (MMIO16) is not.
The 8250 UART device on my board is connected to a 16-bit bus and
my main motivation is to use earlycon with it.
(Refer to arch/arm/boot/dts/uniphier-support-card.dtsi)
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com >
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Masahiro Yamada
004e2ed5cc
serial: 8250_early: squash wait_for_xmitr() into serial_putc()
...
Now, wait_for_xmitr() is only called from serial_putc(), and both
are short enough. They can be merged into a single function.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com >
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Masahiro Yamada
f2bfdb0628
serial: 8250_early: confirm empty transmitter after sending characters
...
The current code waits until the transmitter becomes empty,
before sending each character, and after finishing the whole string.
This seems a bit redundant.
It can be more efficient by checking the transmitter only after sending
each character. This should be safe because the transmitter is already
empty at the first entry of serial_putc().
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com >
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Masahiro Yamada
2cda227bba
serial: 8250_early: do not save and restore IER in write callback
...
The IER has already been masked in early_serial8250_setup(), there is
no reason to save and restore it every time early_serial8250_write()
is called.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com >
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
c0f160a735
vt: Deinline save_screen, save 238 bytes
...
This function compiles to 79 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
5ef6504e9d
tty: Deinline __ldsem_down_write_nested, save 128 bytes
...
This function compiles to 491 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
fc0285f210
tty: Deinline __ldsem_down_read_nested, save 128 bytes
...
This function compiles to 479 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
eba3b47b26
serial/vt8500_serial: Deinline wait_for_xmitr, save 165 bytes
...
This function compiles to 141 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
0d5547ca1b
serial/sunsu: Deinline wait_for_xmitr, save 165 bytes
...
This function compiles to 141 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
63744a6902
serial/sprd_serial: Deinline wait_for_xmitr, save 165 bytes
...
This function compiles to 141 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
be9ae5d9f7
serial/pxa: Deinline wait_for_xmitr, save 165 bytes
...
This function compiles to 141 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
2172076d23
serial/omap-serial: Deinline wait_for_xmitr, save 165 bytes
...
This function compiles to 141 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
fed76af0c7
serial/men_z135_uart: Deinline men_z135_reg_clr, save 176 bytes
...
This function compiles to 98 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
CC: Peter Hurley <peter@hurleysoftware.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
9cdb933274
serial/m32r_sio: Deinline wait_for_xmitr, save 165 bytes
...
This function compiles to 141 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
9428d712d1
isicom: Deinline drop_dtr, save 112 bytes
...
This function compiles to 181 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
1c82363eef
cyclades: Deinline cyz_is_loaded, save 240 bytes
...
This function compiles to 58 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
cb128f69ca
tty/tty_ldisc: Deinline tty_ldisc_put, save 368 bytes
...
This function compiles to 72 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
f4581cab8d
serial_core: Deinline uart_update_mctrl, save 304 bytes
...
This function compiles to 92 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
6d70f46ba0
serial/jsm: Deinline neo_parse_isr, save 688 bytes
...
This function compiles to 811 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00
Denys Vlasenko
1a5b34ebeb
serial/bcm63xx_uart: Deinline wait_for_xmitr, save 374 bytes
...
This function compiles to 141 bytes of machine code.
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com >
CC: Jiri Slaby <jslaby@suse.com >
CC: linux-serial@vger.kernel.org
Reviewed-by: Peter Hurley <peter@hurleysoftware.com >
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org >
2015-12-13 19:59:48 -08:00