742ba02a51
udf: create common function for changing free space counter
...
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com >
Acked-by: Jan Kara <jack@suse.cz >
Cc: Christoph Hellwig <hch@infradead.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:35 -08:00
3f2587bb22
udf: create common function for tag checksumming
...
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com >
Acked-by: Jan Kara <jack@suse.cz >
Cc: Christoph Hellwig <hch@infradead.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:35 -08:00
4b11111aba
udf: fix coding style
...
fix coding style errors found by checkpatch:
- assignments in if conditions
- braces {} around single statement blocks
- no spaces after commas
- printks without KERN_*
- lines longer than 80 characters
- spaces between "type *" and variable name
before: 192 errors, 561 warnings, 8987 lines checked
after: 1 errors, 38 warnings, 9468 lines checked
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Jan Kara <jack@suse.cz >
Cc: Christoph Hellwig <hch@lst.de >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:35 -08:00
bd45a420f9
udf: fix sparse warnings (shadowing & mismatch between declaration and definition)
...
fix sparse warnings:
fs/udf/super.c:1431:24: warning: symbol 'bh' shadows an earlier one
fs/udf/super.c:1347:21: originally declared here
fs/udf/super.c:472:6: warning: symbol 'udf_write_super' was not declared. Should it be static?
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Ben Fennema <bfennema@falcon.csc.calpoly.edu >
Cc: Jan Kara <jack@suse.cz >
Acked-by: Christoph Hellwig <hch@infradead.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:35 -08:00
883cb9d184
udf: move calculating of nr_groups into helper function
...
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Ben Fennema <bfennema@falcon.csc.calpoly.edu >
Acked-by: Jan Kara <jack@suse.cz >
Cc: Christoph Hellwig <hch@infradead.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:35 -08:00
66e1da3f47
udf: convert macros related to bitmaps to functions
...
convert UDF_SB_ALLOC_BITMAP macro to udf_sb_alloc_bitmap function
convert UDF_SB_FREE_BITMAP macro to udf_sb_free_bitmap function
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Ben Fennema <bfennema@falcon.csc.calpoly.edu >
Acked-by: Jan Kara <jack@suse.cz >
Cc: Christoph Hellwig <hch@infradead.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:35 -08:00
deae6cfcdc
udf: check if udf_load_logicalvol failed
...
udf_load_logicalvol may fail eg in out of memory conditions - check it
and propagate error further
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Ben Fennema <bfennema@falcon.csc.calpoly.edu >
Acked-by: Jan Kara <jack@suse.cz >
Cc: Christoph Hellwig <hch@infradead.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:35 -08:00
dc5d39be6d
udf: convert UDF_SB_ALLOC_PARTMAPS macro to udf_sb_alloc_partition_maps function
...
- convert UDF_SB_ALLOC_PARTMAPS macro to udf_sb_alloc_partition_maps function
- convert kmalloc + memset to kcalloc
- check if kcalloc failed (partially)
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Ben Fennema <bfennema@falcon.csc.calpoly.edu >
Cc: Jan Kara <jack@suse.cz >
Acked-by: Christoph Hellwig <hch@infradead.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:35 -08:00
6c79e987d6
udf: remove some ugly macros
...
remove macros:
- UDF_SB_PARTMAPS
- UDF_SB_PARTTYPE
- UDF_SB_PARTROOT
- UDF_SB_PARTLEN
- UDF_SB_PARTVSN
- UDF_SB_PARTNUM
- UDF_SB_TYPESPAR
- UDF_SB_TYPEVIRT
- UDF_SB_PARTFUNC
- UDF_SB_PARTFLAGS
- UDF_SB_VOLIDENT
- UDF_SB_NUMPARTS
- UDF_SB_PARTITION
- UDF_SB_SESSION
- UDF_SB_ANCHOR
- UDF_SB_LASTBLOCK
- UDF_SB_LVIDBH
- UDF_SB_LVID
- UDF_SB_UMASK
- UDF_SB_GID
- UDF_SB_UID
- UDF_SB_RECORDTIME
- UDF_SB_SERIALNUM
- UDF_SB_UDFREV
- UDF_SB_FLAGS
- UDF_SB_VAT
- UDF_UPDATE_UDFREV
- UDF_SB_FREE
and open code them
convert UDF_SB_LVIDIU macro to udf_sb_lvidiu function
rename some struct udf_sb_info fields:
- s_volident to s_volume_ident
- s_lastblock to s_last_block
- s_lvidbh to s_lvid_bh
- s_recordtime to s_record_time
- s_serialnum to s_serial_number;
- s_vat to s_vat_inode;
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Ben Fennema <bfennema@falcon.csc.calpoly.edu >
Cc: Jan Kara <jack@suse.cz >
Acked-by: Christoph Hellwig <hch@infradead.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:34 -08:00
3a71fc5de5
udf: fix coding style of super.c
...
fix coding style errors found by checkpatch:
- assignments in if conditions
- braces {} around single statement blocks
- no spaces after commas
- printks without KERN_*
- lines longer than 80 characters
before: total: 50 errors, 207 warnings, 1835 lines checked
after: total: 0 errors, 164 warnings, 1872 lines checked
all 164 warnings left are lines longer than 80 characters;
this file has too much indentation with really long expressions
to break all those lines now; will fix later
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Ben Fennema <bfennema@falcon.csc.calpoly.edu >
Acked-by: Jan Kara <jack@suse.cz >
Cc: Christoph Hellwig <hch@lst.de >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:34 -08:00
74bedc4d56
libfs: rename simple_attr_close to simple_attr_release
...
simple_attr_close implementes ->release so it should be named accordingly.
Signed-off-by: Christoph Hellwig <hch@lst.de >
Cc: <stefano.brivio@polimi.it >
Cc: Arnd Bergmann <arnd@arndb.de >
Cc: Greg KH <greg@kroah.com >
Cc: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:34 -08:00
9261303ab7
libfs: make simple attributes interruptible
...
Use mutex_lock_interruptible in simple_attr_read/write.
Signed-off-by: Christoph Hellwig <hch@lst.de >
Cc: <stefano.brivio@polimi.it >
Cc: Arnd Bergmann <arnd@arndb.de >
Cc: Greg KH <greg@kroah.com >
Cc: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:34 -08:00
8b88b0998e
libfs: allow error return from simple attributes
...
Sometimes simple attributes might need to return an error, e.g. for
acquiring a mutex interruptibly. In fact we have that situation in
spufs already which is the original user of the simple attributes. This
patch merged the temporarily forked attributes in spufs back into the
main ones and allows to return errors.
[akpm@linux-foundation.org: build fix]
Signed-off-by: Christoph Hellwig <hch@lst.de>
Cc: <stefano.brivio@polimi.it>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg KH <greg@kroah.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 09:22:34 -08:00
efae09f3e9
Nuke duplicate header from sysctl.c
...
Don't include linux/security.h twice in kernel/sysctl.c
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:34 -08:00
f8db694e46
Nuke a duplicate include from profile.c
...
Remove duplicate inclusion of linux/profile.h from kernel/profile.c
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:34 -08:00
2dc9c91315
Nuke duplicate include from printk.c
...
Remove the duplicate inclusion of linux/jiffies.h from kernel/printk.c
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:34 -08:00
18914b1884
write_inode_now(): avoid unnecessary synchronous write
...
We shouldn't use WB_SYNC_ALL if the caller is asking for asynchronous
treatment.
Signed-off-by: Mike Galbraith <efault@gmx.de >
Acked-by: Jan Kara <jack@suse.cz >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:34 -08:00
abe8be3abe
Allow executables larger than 2GB
...
This allows us to use executables >2GB.
Based on a patch by Dave Anderson
Signed-off-by: Andi Kleen <ak@suse.de >
Cc: Dave Anderson <anderson@redhat.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:34 -08:00
531d7d4256
asm-*/posix_types.h: scrub __GLIBC__
...
Some arches (like alpha and ia64) already have a clean posix_types.h header.
This brings all the others in line by removing all references to __GLIBC__
(and some undocumented __USE_ALL).
Signed-off-by: Mike Frysinger <vapier@gentoo.org >
Acked-by: Ingo Molnar <mingo@elte.hu >
Cc: Ulrich Drepper <drepper@redhat.com >
Cc: Roland McGrath <roland@redhat.com >
Cc: <linux-arch@vger.kernel.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:34 -08:00
90b315af12
ufs: fix symlink creation on ufs2
...
If we create symlink on UFS2 filesystem under Linux, it looks wrong under
other OSes, because of max symlink length field was not initialized
properly, and data blocks were not used to save short symlink names.
[akpm@linux-foundation.org: add missing fs32_to_cpu()]
Signed-off-by: Evgeniy Dushistov <dushistov@mail.ru>
Cc: Steven <stevenaaus@yahoo.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-02-08 09:22:33 -08:00
91dbbe4896
ext2: remove unused ext2_put_inode prototype
...
Signed-off-by: Christoph Hellwig <hch@lst.de >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:33 -08:00
c2ec66828f
aio: negative offset should return -EINVAL
...
An AIO read or write should return -EINVAL if the offset is negative.
This check matches the one in pread and pwrite.
This was found by the libaio test suite.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
Acked-by: Zach Brown <zach.brown@oracle.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:33 -08:00
7adfa2ff3e
aio: partial write should not return error code
...
When an AIO write gets an error after writing some data (eg. ENOSPC), it
should return the amount written already, not the error. Just like write()
is supposed to.
This was found by the libaio test suite.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au >
Acked-By: Zach Brown <zach.brown@oracle.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:33 -08:00
25478445c4
Fix container_of() usage
...
Using "attr" twice is not OK, because it effectively prohibits such
container_of() on variables not named "attr".
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru >
Acked-by: Rusty Russell <rusty@rustcorp.com.au >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:32 -08:00
50e8a2890e
ext3: replace all adds to little endians variables with le*_add_cpu
...
replace all:
little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) +
expression_in_cpu_byteorder);
with:
leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder);
sparse didn't generate any new warning with this patch
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com >
Cc: Mark Fasheh <mark.fasheh@oracle.com >
Cc: David Chinner <dgc@sgi.com >
Cc: Timothy Shimmin <tes@sgi.com >
Cc: <linux-ext4@vger.kernel.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-02-08 09:22:32 -08:00
Marcin Slusarz
Christoph Hellwig
Jesper Juhl
Mike Galbraith
Andi Kleen
Mike Frysinger
Evgeniy Dushistov
Rusty Russell
Alexey Dobriyan