You've already forked linux-apfs
mirror of
https://github.com/linux-apfs/linux-apfs.git
synced 2026-05-01 15:00:59 -07:00
net: Move && and || to end of previous line
Not including net/atm/ Compiled tested x86 allyesconfig only Added a > 80 column line or two, which I ignored. Existing checkpatch plaints willfully, cheerfully ignored. Signed-off-by: Joe Perches <joe@perches.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
152b6a62ae
commit
f64f9e7192
+2
-2
@@ -633,8 +633,8 @@ static void p9_poll_mux(struct p9_conn *m)
|
||||
if (n & POLLOUT) {
|
||||
set_bit(Wpending, &m->wsched);
|
||||
P9_DPRINTK(P9_DEBUG_TRANS, "mux %p can write\n", m);
|
||||
if ((m->wsize || !list_empty(&m->unsent_req_list))
|
||||
&& !test_and_set_bit(Wworksched, &m->wsched)) {
|
||||
if ((m->wsize || !list_empty(&m->unsent_req_list)) &&
|
||||
!test_and_set_bit(Wworksched, &m->wsched)) {
|
||||
P9_DPRINTK(P9_DEBUG_TRANS, "sched write work %p\n", m);
|
||||
queue_work(p9_mux_wq, &m->wq);
|
||||
}
|
||||
|
||||
+10
-10
@@ -1362,8 +1362,8 @@ static int l2cap_ertm_send(struct sock *sk)
|
||||
if (pi->conn_state & L2CAP_CONN_WAIT_F)
|
||||
return 0;
|
||||
|
||||
while ((skb = sk->sk_send_head) && (!l2cap_tx_window_full(sk))
|
||||
&& !(pi->conn_state & L2CAP_CONN_REMOTE_BUSY)) {
|
||||
while ((skb = sk->sk_send_head) && (!l2cap_tx_window_full(sk)) &&
|
||||
!(pi->conn_state & L2CAP_CONN_REMOTE_BUSY)) {
|
||||
tx_skb = skb_clone(skb, GFP_ATOMIC);
|
||||
|
||||
if (pi->remote_max_tx &&
|
||||
@@ -1604,8 +1604,8 @@ static int l2cap_sock_sendmsg(struct kiocb *iocb, struct socket *sock, struct ms
|
||||
return -EOPNOTSUPP;
|
||||
|
||||
/* Check outgoing MTU */
|
||||
if (sk->sk_type == SOCK_SEQPACKET && pi->mode == L2CAP_MODE_BASIC
|
||||
&& len > pi->omtu)
|
||||
if (sk->sk_type == SOCK_SEQPACKET && pi->mode == L2CAP_MODE_BASIC &&
|
||||
len > pi->omtu)
|
||||
return -EINVAL;
|
||||
|
||||
lock_sock(sk);
|
||||
@@ -2756,8 +2756,8 @@ static inline int l2cap_config_req(struct l2cap_conn *conn, struct l2cap_cmd_hdr
|
||||
goto unlock;
|
||||
|
||||
if (l2cap_pi(sk)->conf_state & L2CAP_CONF_INPUT_DONE) {
|
||||
if (!(l2cap_pi(sk)->conf_state & L2CAP_CONF_NO_FCS_RECV)
|
||||
|| l2cap_pi(sk)->fcs != L2CAP_FCS_NONE)
|
||||
if (!(l2cap_pi(sk)->conf_state & L2CAP_CONF_NO_FCS_RECV) ||
|
||||
l2cap_pi(sk)->fcs != L2CAP_FCS_NONE)
|
||||
l2cap_pi(sk)->fcs = L2CAP_FCS_CRC16;
|
||||
|
||||
sk->sk_state = BT_CONNECTED;
|
||||
@@ -2845,8 +2845,8 @@ static inline int l2cap_config_rsp(struct l2cap_conn *conn, struct l2cap_cmd_hdr
|
||||
l2cap_pi(sk)->conf_state |= L2CAP_CONF_INPUT_DONE;
|
||||
|
||||
if (l2cap_pi(sk)->conf_state & L2CAP_CONF_OUTPUT_DONE) {
|
||||
if (!(l2cap_pi(sk)->conf_state & L2CAP_CONF_NO_FCS_RECV)
|
||||
|| l2cap_pi(sk)->fcs != L2CAP_FCS_NONE)
|
||||
if (!(l2cap_pi(sk)->conf_state & L2CAP_CONF_NO_FCS_RECV) ||
|
||||
l2cap_pi(sk)->fcs != L2CAP_FCS_NONE)
|
||||
l2cap_pi(sk)->fcs = L2CAP_FCS_CRC16;
|
||||
|
||||
sk->sk_state = BT_CONNECTED;
|
||||
@@ -3388,8 +3388,8 @@ static inline int l2cap_data_channel_sframe(struct sock *sk, u16 rx_control, str
|
||||
pi->expected_ack_seq = tx_seq;
|
||||
l2cap_drop_acked_frames(sk);
|
||||
|
||||
if ((pi->conn_state & L2CAP_CONN_REMOTE_BUSY)
|
||||
&& (pi->unacked_frames > 0))
|
||||
if ((pi->conn_state & L2CAP_CONN_REMOTE_BUSY) &&
|
||||
(pi->unacked_frames > 0))
|
||||
__mod_retrans_timer();
|
||||
|
||||
l2cap_ertm_send(sk);
|
||||
|
||||
+2
-2
@@ -60,8 +60,8 @@ static inline unsigned long hold_time(const struct net_bridge *br)
|
||||
static inline int has_expired(const struct net_bridge *br,
|
||||
const struct net_bridge_fdb_entry *fdb)
|
||||
{
|
||||
return !fdb->is_static
|
||||
&& time_before_eq(fdb->ageing_timer + hold_time(br), jiffies);
|
||||
return !fdb->is_static &&
|
||||
time_before_eq(fdb->ageing_timer + hold_time(br), jiffies);
|
||||
}
|
||||
|
||||
static inline int br_mac_hash(const unsigned char *mac)
|
||||
|
||||
@@ -316,9 +316,9 @@ static ssize_t store_group_addr(struct device *d,
|
||||
if (new_addr[5] & ~0xf)
|
||||
return -EINVAL;
|
||||
|
||||
if (new_addr[5] == 1 /* 802.3x Pause address */
|
||||
|| new_addr[5] == 2 /* 802.3ad Slow protocols */
|
||||
|| new_addr[5] == 3) /* 802.1X PAE address */
|
||||
if (new_addr[5] == 1 || /* 802.3x Pause address */
|
||||
new_addr[5] == 2 || /* 802.3ad Slow protocols */
|
||||
new_addr[5] == 3) /* 802.1X PAE address */
|
||||
return -EINVAL;
|
||||
|
||||
spin_lock_bh(&br->lock);
|
||||
|
||||
@@ -135,8 +135,8 @@ ebt_stp_mt(const struct sk_buff *skb, const struct xt_match_param *par)
|
||||
if (memcmp(sp, header, sizeof(header)))
|
||||
return false;
|
||||
|
||||
if (info->bitmask & EBT_STP_TYPE
|
||||
&& FWINV(info->type != sp->type, EBT_STP_TYPE))
|
||||
if (info->bitmask & EBT_STP_TYPE &&
|
||||
FWINV(info->type != sp->type, EBT_STP_TYPE))
|
||||
return false;
|
||||
|
||||
if (sp->type == BPDU_TYPE_CONFIG &&
|
||||
|
||||
+4
-4
@@ -375,8 +375,8 @@ static struct hlist_head *find_rcv_list(canid_t *can_id, canid_t *mask,
|
||||
return &d->rx[RX_ALL];
|
||||
|
||||
/* extra filterlists for the subscription of a single non-RTR can_id */
|
||||
if (((*mask & CAN_EFF_RTR_FLAGS) == CAN_EFF_RTR_FLAGS)
|
||||
&& !(*can_id & CAN_RTR_FLAG)) {
|
||||
if (((*mask & CAN_EFF_RTR_FLAGS) == CAN_EFF_RTR_FLAGS) &&
|
||||
!(*can_id & CAN_RTR_FLAG)) {
|
||||
|
||||
if (*can_id & CAN_EFF_FLAG) {
|
||||
if (*mask == (CAN_EFF_MASK | CAN_EFF_RTR_FLAGS)) {
|
||||
@@ -525,8 +525,8 @@ void can_rx_unregister(struct net_device *dev, canid_t can_id, canid_t mask,
|
||||
*/
|
||||
|
||||
hlist_for_each_entry_rcu(r, next, rl, list) {
|
||||
if (r->can_id == can_id && r->mask == mask
|
||||
&& r->func == func && r->data == data)
|
||||
if (r->can_id == can_id && r->mask == mask &&
|
||||
r->func == func && r->data == data)
|
||||
break;
|
||||
}
|
||||
|
||||
|
||||
+4
-3
@@ -2677,9 +2677,10 @@ __napi_gro_receive(struct napi_struct *napi, struct sk_buff *skb)
|
||||
return GRO_NORMAL;
|
||||
|
||||
for (p = napi->gro_list; p; p = p->next) {
|
||||
NAPI_GRO_CB(p)->same_flow = (p->dev == skb->dev)
|
||||
&& !compare_ether_header(skb_mac_header(p),
|
||||
skb_gro_mac_header(skb));
|
||||
NAPI_GRO_CB(p)->same_flow =
|
||||
(p->dev == skb->dev) &&
|
||||
!compare_ether_header(skb_mac_header(p),
|
||||
skb_gro_mac_header(skb));
|
||||
NAPI_GRO_CB(p)->flush = 0;
|
||||
}
|
||||
|
||||
|
||||
+2
-3
@@ -2052,9 +2052,8 @@ static void pktgen_setup_inject(struct pktgen_dev *pkt_dev)
|
||||
read_lock_bh(&idev->lock);
|
||||
for (ifp = idev->addr_list; ifp;
|
||||
ifp = ifp->if_next) {
|
||||
if (ifp->scope == IFA_LINK
|
||||
&& !(ifp->
|
||||
flags & IFA_F_TENTATIVE)) {
|
||||
if (ifp->scope == IFA_LINK &&
|
||||
!(ifp->flags & IFA_F_TENTATIVE)) {
|
||||
ipv6_addr_copy(&pkt_dev->
|
||||
cur_in6_saddr,
|
||||
&ifp->addr);
|
||||
|
||||
+2
-2
@@ -1085,8 +1085,8 @@ static int dcbnl_bcn_setcfg(struct net_device *netdev, struct nlattr **tb,
|
||||
u8 value_byte;
|
||||
u32 value_int;
|
||||
|
||||
if (!tb[DCB_ATTR_BCN] || !netdev->dcbnl_ops->setbcncfg
|
||||
|| !netdev->dcbnl_ops->setbcnrp)
|
||||
if (!tb[DCB_ATTR_BCN] || !netdev->dcbnl_ops->setbcncfg ||
|
||||
!netdev->dcbnl_ops->setbcnrp)
|
||||
return ret;
|
||||
|
||||
ret = nla_parse_nested(data, DCB_BCN_ATTR_MAX,
|
||||
|
||||
@@ -581,8 +581,9 @@ static int dn_fib_table_insert(struct dn_fib_table *tb, struct rtmsg *r, struct
|
||||
DN_FIB_SCAN_KEY(f, fp, key) {
|
||||
if (fi->fib_priority != DN_FIB_INFO(f)->fib_priority)
|
||||
break;
|
||||
if (f->fn_type == type && f->fn_scope == r->rtm_scope
|
||||
&& DN_FIB_INFO(f) == fi)
|
||||
if (f->fn_type == type &&
|
||||
f->fn_scope == r->rtm_scope &&
|
||||
DN_FIB_INFO(f) == fi)
|
||||
goto out;
|
||||
}
|
||||
|
||||
|
||||
+3
-2
@@ -1899,8 +1899,9 @@ int ip_mc_source(int add, int omode, struct sock *sk, struct
|
||||
err = -EADDRNOTAVAIL;
|
||||
|
||||
for (pmc=inet->mc_list; pmc; pmc=pmc->next) {
|
||||
if (pmc->multi.imr_multiaddr.s_addr == imr.imr_multiaddr.s_addr
|
||||
&& pmc->multi.imr_ifindex == imr.imr_ifindex)
|
||||
if ((pmc->multi.imr_multiaddr.s_addr ==
|
||||
imr.imr_multiaddr.s_addr) &&
|
||||
(pmc->multi.imr_ifindex == imr.imr_ifindex))
|
||||
break;
|
||||
}
|
||||
if (!pmc) { /* must have a prior join */
|
||||
|
||||
@@ -155,10 +155,10 @@ static int nf_ip_reroute(struct sk_buff *skb,
|
||||
if (entry->hook == NF_INET_LOCAL_OUT) {
|
||||
const struct iphdr *iph = ip_hdr(skb);
|
||||
|
||||
if (!(iph->tos == rt_info->tos
|
||||
&& skb->mark == rt_info->mark
|
||||
&& iph->daddr == rt_info->daddr
|
||||
&& iph->saddr == rt_info->saddr))
|
||||
if (!(iph->tos == rt_info->tos &&
|
||||
skb->mark == rt_info->mark &&
|
||||
iph->daddr == rt_info->daddr &&
|
||||
iph->saddr == rt_info->saddr))
|
||||
return ip_route_me_harder(skb, RTN_UNSPEC);
|
||||
}
|
||||
return 0;
|
||||
|
||||
@@ -1403,8 +1403,8 @@ irnet_connect_indication(void * instance,
|
||||
/* Socket already connecting ? On primary ? */
|
||||
if(0
|
||||
#ifdef ALLOW_SIMULT_CONNECT
|
||||
|| ((irttp_is_primary(server->tsap) == 1) /* primary */
|
||||
&& (test_and_clear_bit(0, &new->ttp_connect)))
|
||||
|| ((irttp_is_primary(server->tsap) == 1) && /* primary */
|
||||
(test_and_clear_bit(0, &new->ttp_connect)))
|
||||
#endif /* ALLOW_SIMULT_CONNECT */
|
||||
)
|
||||
{
|
||||
|
||||
@@ -211,9 +211,9 @@ void ieee80211_process_addba_request(struct ieee80211_local *local,
|
||||
* check if configuration can support the BA policy
|
||||
* and if buffer size does not exceeds max value */
|
||||
/* XXX: check own ht delayed BA capability?? */
|
||||
if (((ba_policy != 1)
|
||||
&& (!(sta->sta.ht_cap.cap & IEEE80211_HT_CAP_DELAY_BA)))
|
||||
|| (buf_size > IEEE80211_MAX_AMPDU_BUF)) {
|
||||
if (((ba_policy != 1) &&
|
||||
(!(sta->sta.ht_cap.cap & IEEE80211_HT_CAP_DELAY_BA))) ||
|
||||
(buf_size > IEEE80211_MAX_AMPDU_BUF)) {
|
||||
status = WLAN_STATUS_INVALID_QOS_PARAM;
|
||||
#ifdef CONFIG_MAC80211_HT_DEBUG
|
||||
if (net_ratelimit())
|
||||
|
||||
+2
-2
@@ -631,8 +631,8 @@ void ieee80211_unregister_hw(struct ieee80211_hw *hw)
|
||||
sta_info_stop(local);
|
||||
rate_control_deinitialize(local);
|
||||
|
||||
if (skb_queue_len(&local->skb_queue)
|
||||
|| skb_queue_len(&local->skb_queue_unreliable))
|
||||
if (skb_queue_len(&local->skb_queue) ||
|
||||
skb_queue_len(&local->skb_queue_unreliable))
|
||||
printk(KERN_WARNING "%s: skb_queue not empty\n",
|
||||
wiphy_name(local->hw.wiphy));
|
||||
skb_queue_purge(&local->skb_queue);
|
||||
|
||||
+2
-2
@@ -195,8 +195,8 @@ int mesh_rmc_check(u8 *sa, struct ieee80211s_hdr *mesh_hdr,
|
||||
list_del(&p->list);
|
||||
kmem_cache_free(rm_cache, p);
|
||||
--entries;
|
||||
} else if ((seqnum == p->seqnum)
|
||||
&& (memcmp(sa, p->sa, ETH_ALEN) == 0))
|
||||
} else if ((seqnum == p->seqnum) &&
|
||||
(memcmp(sa, p->sa, ETH_ALEN) == 0))
|
||||
return -1;
|
||||
}
|
||||
|
||||
|
||||
@@ -936,17 +936,16 @@ int mesh_nexthop_lookup(struct sk_buff *skb,
|
||||
}
|
||||
|
||||
if (mpath->flags & MESH_PATH_ACTIVE) {
|
||||
if (time_after(jiffies, mpath->exp_time +
|
||||
msecs_to_jiffies(sdata->u.mesh.mshcfg.path_refresh_time))
|
||||
&& !memcmp(sdata->dev->dev_addr, hdr->addr4,
|
||||
ETH_ALEN)
|
||||
&& !(mpath->flags & MESH_PATH_RESOLVING)
|
||||
&& !(mpath->flags & MESH_PATH_FIXED)) {
|
||||
if (time_after(jiffies,
|
||||
mpath->exp_time +
|
||||
msecs_to_jiffies(sdata->u.mesh.mshcfg.path_refresh_time)) &&
|
||||
!memcmp(sdata->dev->dev_addr, hdr->addr4, ETH_ALEN) &&
|
||||
!(mpath->flags & MESH_PATH_RESOLVING) &&
|
||||
!(mpath->flags & MESH_PATH_FIXED)) {
|
||||
mesh_queue_preq(mpath,
|
||||
PREQ_Q_F_START | PREQ_Q_F_REFRESH);
|
||||
}
|
||||
memcpy(hdr->addr1, mpath->next_hop->sta.addr,
|
||||
ETH_ALEN);
|
||||
memcpy(hdr->addr1, mpath->next_hop->sta.addr, ETH_ALEN);
|
||||
} else {
|
||||
struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
|
||||
if (!(mpath->flags & MESH_PATH_RESOLVING)) {
|
||||
|
||||
+2
-2
@@ -1168,8 +1168,8 @@ ieee80211_drop_unencrypted(struct ieee80211_rx_data *rx, __le16 fc)
|
||||
rx->key))
|
||||
return -EACCES;
|
||||
/* BIP does not use Protected field, so need to check MMIE */
|
||||
if (unlikely(ieee80211_is_multicast_robust_mgmt_frame(rx->skb)
|
||||
&& ieee80211_get_mmie_keyidx(rx->skb) < 0 &&
|
||||
if (unlikely(ieee80211_is_multicast_robust_mgmt_frame(rx->skb) &&
|
||||
ieee80211_get_mmie_keyidx(rx->skb) < 0 &&
|
||||
rx->key))
|
||||
return -EACCES;
|
||||
/*
|
||||
|
||||
+5
-4
@@ -366,10 +366,11 @@ ieee80211_tx_h_unicast_ps_buf(struct ieee80211_tx_data *tx)
|
||||
struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)tx->skb->data;
|
||||
u32 staflags;
|
||||
|
||||
if (unlikely(!sta || ieee80211_is_probe_resp(hdr->frame_control)
|
||||
|| ieee80211_is_auth(hdr->frame_control)
|
||||
|| ieee80211_is_assoc_resp(hdr->frame_control)
|
||||
|| ieee80211_is_reassoc_resp(hdr->frame_control)))
|
||||
if (unlikely(!sta ||
|
||||
ieee80211_is_probe_resp(hdr->frame_control) ||
|
||||
ieee80211_is_auth(hdr->frame_control) ||
|
||||
ieee80211_is_assoc_resp(hdr->frame_control) ||
|
||||
ieee80211_is_reassoc_resp(hdr->frame_control)))
|
||||
return TX_CONTINUE;
|
||||
|
||||
staflags = get_sta_flags(sta);
|
||||
|
||||
@@ -202,9 +202,9 @@ static inline int expect_clash(const struct nf_conntrack_expect *a,
|
||||
static inline int expect_matches(const struct nf_conntrack_expect *a,
|
||||
const struct nf_conntrack_expect *b)
|
||||
{
|
||||
return a->master == b->master && a->class == b->class
|
||||
&& nf_ct_tuple_equal(&a->tuple, &b->tuple)
|
||||
&& nf_ct_tuple_mask_equal(&a->mask, &b->mask);
|
||||
return a->master == b->master && a->class == b->class &&
|
||||
nf_ct_tuple_equal(&a->tuple, &b->tuple) &&
|
||||
nf_ct_tuple_mask_equal(&a->mask, &b->mask);
|
||||
}
|
||||
|
||||
/* Generally a bad idea to call this: could have matched already. */
|
||||
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user