perf tools: Remove unused 'prefix' from builtin functions

We got it from the git sources but never used it for anything, with the
place where this would be somehow used remaining:

  static int run_builtin(struct cmd_struct *p, int argc, const char **argv)
  {
	prefix = NULL;
	if (p->option & RUN_SETUP)
		prefix = NULL; /* setup_perf_directory(); */

Ditch it.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-uw5swz05vol0qpr32c5lpvus@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Arnaldo Carvalho de Melo
2017-03-27 11:47:20 -03:00
parent 6963d3c387
commit b0ad8ea664
41 changed files with 110 additions and 126 deletions
+10 -10
View File
@@ -25,17 +25,17 @@
# endif
#endif
int bench_numa(int argc, const char **argv, const char *prefix);
int bench_sched_messaging(int argc, const char **argv, const char *prefix);
int bench_sched_pipe(int argc, const char **argv, const char *prefix);
int bench_mem_memcpy(int argc, const char **argv, const char *prefix);
int bench_mem_memset(int argc, const char **argv, const char *prefix);
int bench_futex_hash(int argc, const char **argv, const char *prefix);
int bench_futex_wake(int argc, const char **argv, const char *prefix);
int bench_futex_wake_parallel(int argc, const char **argv, const char *prefix);
int bench_futex_requeue(int argc, const char **argv, const char *prefix);
int bench_numa(int argc, const char **argv);
int bench_sched_messaging(int argc, const char **argv);
int bench_sched_pipe(int argc, const char **argv);
int bench_mem_memcpy(int argc, const char **argv);
int bench_mem_memset(int argc, const char **argv);
int bench_futex_hash(int argc, const char **argv);
int bench_futex_wake(int argc, const char **argv);
int bench_futex_wake_parallel(int argc, const char **argv);
int bench_futex_requeue(int argc, const char **argv);
/* pi futexes */
int bench_futex_lock_pi(int argc, const char **argv, const char *prefix);
int bench_futex_lock_pi(int argc, const char **argv);
#define BENCH_FORMAT_DEFAULT_STR "default"
#define BENCH_FORMAT_DEFAULT 0
+1 -2
View File
@@ -114,8 +114,7 @@ static void print_summary(void)
(int) runtime.tv_sec);
}
int bench_futex_hash(int argc, const char **argv,
const char *prefix __maybe_unused)
int bench_futex_hash(int argc, const char **argv)
{
int ret = 0;
cpu_set_t cpu;
+1 -2
View File
@@ -140,8 +140,7 @@ static void create_threads(struct worker *w, pthread_attr_t thread_attr)
}
}
int bench_futex_lock_pi(int argc, const char **argv,
const char *prefix __maybe_unused)
int bench_futex_lock_pi(int argc, const char **argv)
{
int ret = 0;
unsigned int i;
+1 -2
View File
@@ -109,8 +109,7 @@ static void toggle_done(int sig __maybe_unused,
done = true;
}
int bench_futex_requeue(int argc, const char **argv,
const char *prefix __maybe_unused)
int bench_futex_requeue(int argc, const char **argv)
{
int ret = 0;
unsigned int i, j;
+1 -2
View File
@@ -197,8 +197,7 @@ static void toggle_done(int sig __maybe_unused,
done = true;
}
int bench_futex_wake_parallel(int argc, const char **argv,
const char *prefix __maybe_unused)
int bench_futex_wake_parallel(int argc, const char **argv)
{
int ret = 0;
unsigned int i, j;
+1 -2
View File
@@ -115,8 +115,7 @@ static void toggle_done(int sig __maybe_unused,
done = true;
}
int bench_futex_wake(int argc, const char **argv,
const char *prefix __maybe_unused)
int bench_futex_wake(int argc, const char **argv)
{
int ret = 0;
unsigned int i, j;
+2 -2
View File
@@ -284,7 +284,7 @@ static const char * const bench_mem_memcpy_usage[] = {
NULL
};
int bench_mem_memcpy(int argc, const char **argv, const char *prefix __maybe_unused)
int bench_mem_memcpy(int argc, const char **argv)
{
struct bench_mem_info info = {
.functions = memcpy_functions,
@@ -358,7 +358,7 @@ static const struct function memset_functions[] = {
{ .name = NULL, }
};
int bench_mem_memset(int argc, const char **argv, const char *prefix __maybe_unused)
int bench_mem_memset(int argc, const char **argv)
{
struct bench_mem_info info = {
.functions = memset_functions,
+1 -1
View File
@@ -1767,7 +1767,7 @@ static int bench_all(void)
return 0;
}
int bench_numa(int argc, const char **argv, const char *prefix __maybe_unused)
int bench_numa(int argc, const char **argv)
{
init_params(&p0, "main,", argc, argv);
argc = parse_options(argc, argv, options, bench_numa_usage, 0);
+1 -2
View File
@@ -260,8 +260,7 @@ static const char * const bench_sched_message_usage[] = {
NULL
};
int bench_sched_messaging(int argc, const char **argv,
const char *prefix __maybe_unused)
int bench_sched_messaging(int argc, const char **argv)
{
unsigned int i, total_children;
struct timeval start, stop, diff;
+1 -1
View File
@@ -76,7 +76,7 @@ static void *worker_thread(void *__tdata)
return NULL;
}
int bench_sched_pipe(int argc, const char **argv, const char *prefix __maybe_unused)
int bench_sched_pipe(int argc, const char **argv)
{
struct thread_data threads[2], *td;
int pipe_1[2], pipe_2[2];
+1 -1
View File
@@ -383,7 +383,7 @@ static const char * const annotate_usage[] = {
NULL
};
int cmd_annotate(int argc, const char **argv, const char *prefix __maybe_unused)
int cmd_annotate(int argc, const char **argv)
{
struct perf_annotate annotate = {
.tool = {
+6 -6
View File
@@ -25,7 +25,7 @@
#include <string.h>
#include <sys/prctl.h>
typedef int (*bench_fn_t)(int argc, const char **argv, const char *prefix);
typedef int (*bench_fn_t)(int argc, const char **argv);
struct bench {
const char *name;
@@ -155,7 +155,7 @@ static int bench_str2int(const char *str)
* to something meaningful:
*/
static int run_bench(const char *coll_name, const char *bench_name, bench_fn_t fn,
int argc, const char **argv, const char *prefix)
int argc, const char **argv)
{
int size;
char *name;
@@ -171,7 +171,7 @@ static int run_bench(const char *coll_name, const char *bench_name, bench_fn_t f
prctl(PR_SET_NAME, name);
argv[0] = name;
ret = fn(argc, argv, prefix);
ret = fn(argc, argv);
free(name);
@@ -198,7 +198,7 @@ static void run_collection(struct collection *coll)
fflush(stdout);
argv[1] = bench->name;
run_bench(coll->name, bench->name, bench->fn, 1, argv, NULL);
run_bench(coll->name, bench->name, bench->fn, 1, argv);
printf("\n");
}
}
@@ -211,7 +211,7 @@ static void run_all_collections(void)
run_collection(coll);
}
int cmd_bench(int argc, const char **argv, const char *prefix __maybe_unused)
int cmd_bench(int argc, const char **argv)
{
struct collection *coll;
int ret = 0;
@@ -270,7 +270,7 @@ int cmd_bench(int argc, const char **argv, const char *prefix __maybe_unused)
if (bench_format == BENCH_FORMAT_DEFAULT)
printf("# Running '%s/%s' benchmark:\n", coll->name, bench->name);
fflush(stdout);
ret = run_bench(coll->name, bench->name, bench->fn, argc-1, argv+1, prefix);
ret = run_bench(coll->name, bench->name, bench->fn, argc-1, argv+1);
goto end;
}
+1 -2
View File
@@ -276,8 +276,7 @@ static int build_id_cache__update_file(const char *filename)
return err;
}
int cmd_buildid_cache(int argc, const char **argv,
const char *prefix __maybe_unused)
int cmd_buildid_cache(int argc, const char **argv)
{
struct strlist *list;
struct str_node *pos;
+1 -2
View File
@@ -87,8 +87,7 @@ out:
return 0;
}
int cmd_buildid_list(int argc, const char **argv,
const char *prefix __maybe_unused)
int cmd_buildid_list(int argc, const char **argv)
{
bool show_kernel = false;
bool with_hits = false;
+2 -2
View File
@@ -2755,12 +2755,12 @@ static int perf_c2c__record(int argc, const char **argv)
pr_debug("\n");
}
ret = cmd_record(i, rec_argv, NULL);
ret = cmd_record(i, rec_argv);
free(rec_argv);
return ret;
}
int cmd_c2c(int argc, const char **argv, const char *prefix __maybe_unused)
int cmd_c2c(int argc, const char **argv)
{
argc = parse_options(argc, argv, c2c_options, c2c_usage,
PARSE_OPT_STOP_AT_NON_OPTION);
+1 -1
View File
@@ -154,7 +154,7 @@ static int parse_config_arg(char *arg, char **var, char **value)
return 0;
}
int cmd_config(int argc, const char **argv, const char *prefix __maybe_unused)
int cmd_config(int argc, const char **argv)
{
int i, ret = 0;
struct perf_config_set *set;
+4 -5
View File
@@ -6,7 +6,7 @@
#include "data-convert.h"
#include "data-convert-bt.h"
typedef int (*data_cmd_fn_t)(int argc, const char **argv, const char *prefix);
typedef int (*data_cmd_fn_t)(int argc, const char **argv);
struct data_cmd {
const char *name;
@@ -50,8 +50,7 @@ static const char * const data_convert_usage[] = {
NULL
};
static int cmd_data_convert(int argc, const char **argv,
const char *prefix __maybe_unused)
static int cmd_data_convert(int argc, const char **argv)
{
const char *to_ctf = NULL;
struct perf_data_convert_opts opts = {
@@ -98,7 +97,7 @@ static struct data_cmd data_cmds[] = {
{ .name = NULL, },
};
int cmd_data(int argc, const char **argv, const char *prefix)
int cmd_data(int argc, const char **argv)
{
struct data_cmd *cmd;
const char *cmdstr;
@@ -118,7 +117,7 @@ int cmd_data(int argc, const char **argv, const char *prefix)
if (strcmp(cmd->name, cmdstr))
continue;
return cmd->fn(argc, argv, prefix);
return cmd->fn(argc, argv);
}
pr_err("Unknown command: %s\n", cmdstr);
+1 -1
View File
@@ -1321,7 +1321,7 @@ static int diff__config(const char *var, const char *value,
return 0;
}
int cmd_diff(int argc, const char **argv, const char *prefix __maybe_unused)
int cmd_diff(int argc, const char **argv)
{
int ret = hists__init();
+1 -1
View File
@@ -46,7 +46,7 @@ static int __cmd_evlist(const char *file_name, struct perf_attr_details *details
return 0;
}
int cmd_evlist(int argc, const char **argv, const char *prefix __maybe_unused)
int cmd_evlist(int argc, const char **argv)
{
struct perf_attr_details details = { .verbose = false, };
const struct option options[] = {
+1 -1
View File
@@ -304,7 +304,7 @@ static int perf_ftrace_config(const char *var, const char *value, void *cb)
return -1;
}
int cmd_ftrace(int argc, const char **argv, const char *prefix __maybe_unused)
int cmd_ftrace(int argc, const char **argv)
{
int ret;
struct perf_ftrace ftrace = {

Some files were not shown because too many files have changed in this diff Show More