You've already forked linux-apfs
mirror of
https://github.com/linux-apfs/linux-apfs.git
synced 2026-05-01 15:00:59 -07:00
Input: omap-keypad - remove dead check
Commit da1f026b53 ("Keyboard: omap-keypad:
use matrix_keypad.h") switched the driver to use matrix keypad
infrastructure, which made array of keycodes to be unsigned short, and
caused the test for negativity never trigger. This leads to the following
static checker warning:
drivers/input/keyboard/omap-keypad.c:158 omap_kp_tasklet()
warn: 'keycodes[]' is never negative.
Given that we did not care about this check for a few years already let's
simply remove it.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Aaro Koskinen <aaro.koskinen@nokia.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
@@ -155,14 +155,6 @@ static void omap_kp_tasklet(unsigned long data)
|
||||
"pressed" : "released");
|
||||
#else
|
||||
key = keycodes[MATRIX_SCAN_CODE(row, col, row_shift)];
|
||||
if (key < 0) {
|
||||
printk(KERN_WARNING
|
||||
"omap-keypad: Spurious key event %d-%d\n",
|
||||
col, row);
|
||||
/* We scan again after a couple of seconds */
|
||||
spurious = 1;
|
||||
continue;
|
||||
}
|
||||
|
||||
if (!(kp_cur_group == (key & GROUP_MASK) ||
|
||||
kp_cur_group == -1))
|
||||
|
||||
Reference in New Issue
Block a user