You've already forked linux-apfs-rw
mirror of
https://github.com/linux-apfs/linux-apfs-rw.git
synced 2026-05-01 15:01:34 -07:00
Ernesto A. Fernández
d4797823ea
The driver is much closer to being usable, so I might start getting subtler bug reports soon. To make them easier to handle, put error messages all over the place. I should have done this from the beginning, but I guess I didn't fully understand the need back then. From now my general policy will be to use apfs_warn() for user errors or unsupported features; apfs_err() for things that are probably corruption or io errors; and apfs_alert() for things that are most likely bugs. These last two should be rare, so the same error/alert will be thrown by several layers in the callstack to provide as much information as possible. Be careful and don't flood the console on normal situations. Also, make messages with a log level lower than warning output their function name and line number, which I think will help debugging more than the actual messages. Signed-off-by: Ernesto A. Fernández <ernesto@corellium.com>
30 lines
641 B
C
30 lines
641 B
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2018 Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com>
|
|
*/
|
|
|
|
#include <linux/fs.h>
|
|
#include "apfs.h"
|
|
|
|
void apfs_msg(struct super_block *sb, const char *prefix, const char *func, int line, const char *fmt, ...)
|
|
{
|
|
char *sb_id = NULL;
|
|
struct va_format vaf;
|
|
va_list args;
|
|
|
|
va_start(args, fmt);
|
|
|
|
vaf.fmt = fmt;
|
|
vaf.va = &args;
|
|
|
|
/* The superblock is not available to all callers */
|
|
sb_id = sb ? sb->s_id : "?";
|
|
|
|
if (func)
|
|
printk("%sAPFS (%s): %pV (%s:%d)\n", prefix, sb_id, &vaf, func, line);
|
|
else
|
|
printk("%sAPFS (%s): %pV\n", prefix, sb_id, &vaf);
|
|
|
|
va_end(args);
|
|
}
|