with the "attribute packed" stuff for the efi/efd items etc..
It is confusing the parsing which works out the type names.
Merge of master-melb:xfs-cmds:31658a by kenmcd.
will execute a 'rm -f' on a directory which will fail. This should
be a rmdir....
Signed-off-by: Dave Chinner <dgc@sgi.com>
Merge of master-melb:xfs-cmds:31637a by kenmcd.
If test 078 fails and you try to run it again immediately, it
will execute a 'rm -f' on a directory which will fail. This should
be a rmdir.... Signed-off-by: Dave Chinner <dgc@sgi.com>
There are two errors I see all the time in 145:
- dm_probe_hole returns EINVAL for offsets close to the file size
- dm_probe_hole wants EAGAIN for a probe at offset 1, length 0
The first error is a consequence of how the hole puching / probing
works. It always rounds the requested offset up to the next block
size and then checks if that rounded offset still fits into the file
size. Just do the same rounding in the testcase to make sure we don't
probe invalid offsets.
The second error is very odd to me, as we never return AGAIN in the
whole dm_probe_hole path. I've just commented it out.
I've also re-enabled the E2BIG to past-EOF test that was uncommented
before because it works perfectly fine now.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Merge of master-melb:xfs-cmds:31330a by kenmcd.
fix XFSQA 145 / test_hole
Two really dumb bugs:
- "foo & 0x3FFFFFFFFFFFF" doesn't cap at 1TB, but rather at more than
two magnitudes larger than that. That gets us EFBIG with typical
32bit XFS setups.
- the command array can easily overflow and thus let the test fail
Signed-off-by: Christoph Hellwig <hch@lst.de>
Merge of master-melb:xfs-cmds:31327a by kenmcd.
Fix XFSQA test 144
level used on IRIX makes it complete in slightly under 10 minutes.
I'm not sure if checking for UP vs SMP is the right way to go into slow
mode, but I couldn't think of anything better.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Merge of master-melb:xfs-cmds:31272a by kenmcd.
partitions unless it's given -f in addition to the already required Y
input to confirm the fs creation, so give the argument to it.
While we're at it also write the full command line used to create the
filesystem into the log to ease future debugging.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Merge of master-melb:xfs-cmds:31250a by kenmcd.
Execute bits changed from xxx to ---
Fix up test with reiserfs
Test 167 will leave runaway fsstress processes around in case killall is
not installed and thus make all following tests fail. This patch checks
for killall beeing installed and error out otherwise.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Merge of master-melb:xfs-cmds:31171a by kenmcd.
don't run if killall is not installed.
If the path to the file being bmap'd has a [0-9] in it,
the output filter matches it and we get golden output
failure. Be more specific on the match.
Merge of master-melb:xfs-cmds:31170a by kenmcd.
Be more specific when trying to match extent output lines.
/tmp might be small, might not support files larger than 2GB,
etc, so trying to host loopback images of 100GB filesystems
will break in some situations. We should use $TEST_DIR for the
images.
Note: remounting of loopback images has a major bug (in mount)
that "leaks" loopback device references. Hence all the hackery
with losetup to work around this.
Merge of master-melb:xfs-cmds:31169a by kenmcd.
Don't use /tmp for hosting loopback images
made to test 008,the file sizes got much larger. It appears
that randholes actually reads the entire file, so this has
slowed the test down by a factor of ten (all file sizes
were increased by 10x). This means the test is now taking
about 18 minutes to run on a UML session, and all the time
is spent reading the files.
Instead, scale the file size based on the page size. We know
how many holes we are trying to produce and the I/O size
being used to produce them, so the size of the files can be
finely tuned. Assuming a decent random distribution, if the
number of blocks in the file is 4x the page size and the
I/O size is page sized, this means that every I/O should
generate a new hole and we'll only get a small amount of
adjacent extents. This has passed over 10 times on ia64
w/ 64k page and another 15 times on UML with 4k page.
UML runtime is down from ~1000s to 5s, ia64 runtime is down from
~30s to 7s.
Merge of master-melb:xfs-cmds:31168a by kenmcd.
Greatly reduce runtime by reducing filesizes down to sane minimum.
Barry Naujok
Tim Shimmin
Peter Leckie
Brad Scarlett
Donald Douwsma
Niv Sardi
Dave Chinner