mirror of
https://github.com/linux-apfs/apfstests.git
synced 2026-05-01 15:01:44 -07:00
fstests: remove generic/484
Generic/484 tests functionality that isn't really related to file systems, and has failed every since it was added. Remove it as it serves no puropse in xfstests. [Eryu: also remove src/t_locks_execve.c and its entries in src/Makefile and .gitignore] Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Eryu Guan <guaneryu@gmail.com>
This commit is contained in:
Christoph Hellwig
committed by
Eryu Guan
Eryu Guan
parent
1d6d14db11
commit
fd2366c6cd
@@ -129,7 +129,6 @@
|
||||
/src/t_getcwd
|
||||
/src/t_holes
|
||||
/src/t_immutable
|
||||
/src/t_locks_execve
|
||||
/src/t_mmap_collision
|
||||
/src/t_mmap_cow_race
|
||||
/src/t_mmap_dio
|
||||
|
||||
+2
-1
@@ -16,7 +16,8 @@ TARGETS = dirstress fill fill2 getpagesize holes lstat64 \
|
||||
holetest t_truncate_self t_mmap_dio af_unix t_mmap_stale_pmd \
|
||||
t_mmap_cow_race t_mmap_fallocate fsync-err t_mmap_write_ro \
|
||||
t_ext4_dax_journal_corruption t_ext4_dax_inline_corruption \
|
||||
t_ofd_locks t_locks_execve t_mmap_collision mmap-write-concurrent
|
||||
t_ofd_locks t_mmap_collision mmap-write-concurrent \
|
||||
t_get_file_time t_create_short_dirs t_create_long_dirs
|
||||
|
||||
LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize preallo_rw_pattern_reader \
|
||||
preallo_rw_pattern_writer ftrunc trunc fs_perms testx looptest \
|
||||
|
||||
@@ -1,89 +0,0 @@
|
||||
#ifndef _GNU_SOURCE
|
||||
#define _GNU_SOURCE
|
||||
#endif
|
||||
#include <stdio.h>
|
||||
#include <fcntl.h>
|
||||
#include <stdlib.h>
|
||||
#include <string.h>
|
||||
#include <errno.h>
|
||||
#include <pthread.h>
|
||||
#include <unistd.h>
|
||||
#include <sys/types.h>
|
||||
#include <sys/wait.h>
|
||||
|
||||
static void err_exit(char *op, int errn)
|
||||
{
|
||||
fprintf(stderr, "%s: %s\n", op, strerror(errn));
|
||||
exit(errn);
|
||||
}
|
||||
|
||||
void *thread_fn(void *arg)
|
||||
{
|
||||
/* execve will release threads */
|
||||
while(1) sleep(1);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
struct flock fl = {
|
||||
.l_type = F_WRLCK,
|
||||
.l_whence = SEEK_SET,
|
||||
.l_start = 0,
|
||||
.l_len = 1,
|
||||
};
|
||||
|
||||
static void checklock(int fd)
|
||||
{
|
||||
pid_t pid;
|
||||
|
||||
pid = fork();
|
||||
if (pid < 0)
|
||||
err_exit("fork", errno);
|
||||
|
||||
if (!pid) {
|
||||
if (fcntl(fd, F_GETLK, &fl) < 0)
|
||||
err_exit("getlk", errno);
|
||||
if (fl.l_type == F_UNLCK) {
|
||||
printf("record lock is not preserved across execve(2)\n");
|
||||
exit(1);
|
||||
}
|
||||
exit(0);
|
||||
}
|
||||
|
||||
waitpid(pid, NULL, 0);
|
||||
|
||||
exit(0);
|
||||
}
|
||||
|
||||
int main(int argc, char **argv)
|
||||
{
|
||||
int fd, flags;
|
||||
char fdstr[10];
|
||||
char *newargv[] = { argv[0], argv[1], fdstr, NULL };
|
||||
pthread_t th;
|
||||
|
||||
/* passing fd in argv[2] in execve */
|
||||
if (argc == 3) {
|
||||
fd = atoi(argv[2]);
|
||||
checklock(fd);
|
||||
}
|
||||
|
||||
fd = open(argv[1], O_WRONLY|O_CREAT, 0755);
|
||||
if (fd < 0)
|
||||
err_exit("open", errno);
|
||||
if (fcntl(fd, F_SETLK, &fl) < 0)
|
||||
err_exit("setlk", errno);
|
||||
|
||||
/* require multithread process to reproduce the issue */
|
||||
pthread_create(&th, NULL, thread_fn, &fd);
|
||||
|
||||
if ((flags = fcntl(fd, F_GETFD)) < 0)
|
||||
err_exit("getfd", errno);
|
||||
flags &= ~FD_CLOEXEC;
|
||||
if (fcntl(fd, F_SETFD, flags) < 0)
|
||||
err_exit("setfd", errno);
|
||||
|
||||
snprintf(fdstr, sizeof(fdstr), "%d", fd);
|
||||
execve(argv[0], newargv, NULL);
|
||||
|
||||
return 0;
|
||||
}
|
||||
@@ -1,51 +0,0 @@
|
||||
#! /bin/bash
|
||||
# SPDX-License-Identifier: GPL-2.0
|
||||
# Copyright (c) 2018 Red Hat Inc. All Rights Reserved.
|
||||
#
|
||||
# FS QA Test 484
|
||||
#
|
||||
# POSIX requires that record locks are preserved across an execve(2). But
|
||||
# there's bug that record locks are released if process is multithreaded at the
|
||||
# time that execve is called.
|
||||
#
|
||||
# Fixed by patch from Jeff Layton:
|
||||
# locks: change POSIX lock ownership on execve when files_struct is displaced
|
||||
#
|
||||
seq=`basename $0`
|
||||
seqres=$RESULT_DIR/$seq
|
||||
echo "QA output created by $seq"
|
||||
|
||||
here=`pwd`
|
||||
tmp=/tmp/$$
|
||||
status=1 # failure is the default!
|
||||
trap "_cleanup; exit \$status" 0 1 2 3 15
|
||||
|
||||
_cleanup()
|
||||
{
|
||||
cd /
|
||||
rm -f $tmp.*
|
||||
}
|
||||
|
||||
# get standard environment, filters and checks
|
||||
. ./common/rc
|
||||
. ./common/filter
|
||||
|
||||
# remove previous $seqres.full before test
|
||||
rm -f $seqres.full
|
||||
|
||||
# real QA test starts here
|
||||
_supported_fs generic
|
||||
_supported_os Linux
|
||||
_require_test
|
||||
_require_test_program "t_locks_execve"
|
||||
|
||||
# prepare a 4k testfile in TEST_DIR
|
||||
$XFS_IO_PROG -f -c "pwrite -S 0xFF 0 4096" \
|
||||
$TEST_DIR/t_lock_execve_file >> $seqres.full 2>&1
|
||||
|
||||
$here/src/t_locks_execve $TEST_DIR/t_lock_execve_file
|
||||
|
||||
# success, all done
|
||||
echo "Silence is golden"
|
||||
status=0
|
||||
exit
|
||||
@@ -1,2 +0,0 @@
|
||||
QA output created by 484
|
||||
Silence is golden
|
||||
@@ -486,7 +486,6 @@
|
||||
481 auto quick log metadata
|
||||
482 auto metadata replay
|
||||
483 auto quick log metadata
|
||||
484 auto quick
|
||||
485 auto quick insert
|
||||
486 auto quick attr
|
||||
487 auto quick eio
|
||||
|
||||
Reference in New Issue
Block a user