mirror of
https://github.com/linux-apfs/apfstests.git
synced 2026-05-01 15:01:44 -07:00
xfs: test X_QUOTARM functionality
The Q_XQUOTARM quotactl was not working properly, because we weren't passing in proper flags. The xfs_fs_set_xstate() ioctl handler used the same flags for Q_XQUOTAON/OFF as well as Q_XQUOTARM, but Q_XQUOTAON/OFF look for XFS_UQUOTA_ACCT, XFS_UQUOTA_ENFD, XFS_GQUOTA_ACCT etc, i.e. quota type + state, while Q_XQUOTARM looks only for the type of quota, i.e. XFS_DQ_USER, XFS_DQ_GROUP etc. Unfortunately these flag spaces overlap a bit, so we got semi-random results for Q_XQUOTARM; i.e. the value for XFS_DQ_USER == XFS_UQUOTA_ACCT, etc. yeargh. Anyway, here's a simple test that demonstrates it, kernel patch to fix it will follow. Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
committed by
Dave Chinner
parent
35ee39228b
commit
de876b996a
@@ -4,6 +4,7 @@
|
||||
004 db auto quick
|
||||
005 auto quick
|
||||
006 auto dir
|
||||
007 auto quota quick
|
||||
008 rw ioctl auto quick
|
||||
009 rw ioctl auto prealloc quick
|
||||
012 rw auto quick
|
||||
|
||||
Reference in New Issue
Block a user