apfs/apfstests
0
0
Fork 0
mirror of https://github.com/linux-apfs/apfstests.git synced 2026-05-01 15:01:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

generic/285: fix test for generic SEEK_HOLE/DATA implementations

Browse Source 
Generic implementation of SEEK_HOLE/DATA reports whole file as data chunk with
virtual hole at the end (generic_file_llseek, used by ext2/ext3/reiserfs/nfs).

Currently test prepares file smaller than expected for "huge file" testcases
(testcases 10-12). This patch fixes test file layout, now second data chunk
ends right at the expected end of file.

Plus it fixes type of 'filesz' argument, it should be off_t.

Signed-off-by: Konstantin Khlebnikov <k.khlebnikov@samsung.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
Konstantin Khlebnikov
2014-04-22 10:47:23 +10:00
committed by Dave Chinner
parent c365b11682
commit 35ee39228b
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/seek_sanity_test.c
+3 -2
View File
@@ -157,7 +157,7 @@ static int do_create(const char *filename)
return fd;
}
static int do_lseek(int testnum, int subtest, int fd, int filsz, int origin,
static int do_lseek(int testnum, int subtest, int fd, off_t filsz, int origin,
off_t set, off_t exp)
{
off_t pos, exp2;
@@ -203,7 +203,7 @@ static int huge_file_test(int fd, int testnum, off_t filsz)
{
char *buf = NULL;
int bufsz = alloc_size * 16; /* XFS seems to round allocated size */
off_t off = filsz - 2*bufsz;
off_t off = filsz - bufsz;
int ret = -1;
buf = do_malloc(bufsz);
@@ -211,6 +211,7 @@ static int huge_file_test(int fd, int testnum, off_t filsz)
goto out;
memset(buf, 'a', bufsz);
/* |- DATA -|- HUGE HOLE -|- DATA -| */
ret = do_pwrite(fd, buf, bufsz, 0);
if (ret)
goto out;