apfs/apfstests
0
0
Fork 0
mirror of https://github.com/linux-apfs/apfstests.git synced 2026-05-01 15:01:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

generic/108: Fix return value check from _get_scsi_debug_dev

Browse Source 
_get_scsi_debug_dev is supposed to return a "/dev/$device".
However, in case the scsi device is not mapped to a disk, hence
/dev/sd* doesn't exist, then get_scsi_debug_dev would return only
the "/dev/" string. In generic/108 we check whether return value is
"" and only then consider it a failure. This behavior allows the
test to erroneously consider _get_scsi_debug_dev succeeded even if
it returned a malformed string. Fix this by correctly checking
whether the return value is "/dev/"

Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
This commit is contained in:
Nikolay Borisov
2017-05-25 12:08:46 +03:00
committed by Eryu Guan
parent ce16ed94a8
commit c51ab0a850
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/generic/108
+1 -1
View File
@@ -64,7 +64,7 @@ rm -f $seqres.full
# _get_scsi_debug_dev returns a scsi debug device with 128M in size by default
SCSI_DEBUG_DEV=`_get_scsi_debug_dev`
if [ "$SCSI_DEBUG_DEV" == "" ]; then
if [ "$SCSI_DEBUG_DEV" == "/dev/" ]; then
_fail "Failed to initialize scsi debug device"
fi
echo "SCSI debug device $SCSI_DEBUG_DEV" >>$seqres.full