xfs: test that we don't leak inodes and dquots during failed cow recovery

Add a couple of tests to check that we don't leak inodes or dquots
if CoW recovery fails and therefore the mount fails.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
This commit is contained in:
Darrick J. Wong
2017-11-09 16:44:40 -08:00
committed by Eryu Guan
parent c0c26cecab
commit a9df2f23df
8 changed files with 332 additions and 0 deletions
+1
View File
@@ -3313,6 +3313,7 @@ _check_dmesg()
-e "(INFO|ERR): suspicious RCU usage" \
-e "INFO: possible circular locking dependency detected" \
-e "general protection fault:" \
-e "BUG .* remaining" \
$seqres.dmesg
if [ $? -eq 0 ]; then
_dump_err "_check_dmesg: something found in dmesg (see $seqres.dmesg)"
Executable
+111
View File
@@ -0,0 +1,111 @@
#! /bin/bash
# FS QA Test No. 434
#
# Ensure that we don't leak quota inodes when CoW recovery fails.
#
# Use xfs_fsr to inject bmap redo items in the log for a linked file and
# an unlinked file; enable quota so that we always mount with the quota
# inodes; and then corrupt the refcount btree to ensure that the CoW
# garbage collection (and therefore the mount) fail.
#
# On a subsequent mount attempt, we should be able to replay the bmap
# items for the linked and unlinked files without prematurely truncating
# the unlinked inode and without leaking the linked inode, and we should
# be able to release the quota inodes when we're aborting the mount. We
# also should not leak dquots.
#
#-----------------------------------------------------------------------
# Copyright (c) 2017, Oracle and/or its affiliates. All Rights Reserved.
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License as
# published by the Free Software Foundation.
#
# This program is distributed in the hope that it would be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write the Free Software Foundation,
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
#-----------------------------------------------------------------------
seq=`basename "$0"`
seqres="$RESULT_DIR/$seq"
echo "QA output created by $seq"
here=`pwd`
tmp=/tmp/$$
status=1 # failure is the default!
trap "_cleanup; exit \$status" 0 1 2 3 15
_cleanup()
{
cd /
rm -rf "$tmp".*
}
# get standard environment, filters and checks
. ./common/rc
. ./common/filter
. ./common/attr
. ./common/reflink
. ./common/inject
. ./common/quota
. ./common/module
# real QA test starts here
_supported_os Linux
_supported_fs xfs
_require_loadable_fs_module "xfs"
_require_quota
_require_scratch_reflink
_require_cp_reflink
_require_command "$XFS_FSR_PROG" "xfs_fsr"
_require_xfs_io_error_injection "bmap_finish_one"
_require_xfs_scratch_rmapbt
rm -f "$seqres.full"
echo "Format and mount"
_scratch_mkfs > "$seqres.full" 2>&1
_scratch_mount -o noquota >> "$seqres.full" 2>&1
testdir="$SCRATCH_MNT/test-$seq"
blksz=65536
blks=3
mkdir "$testdir"
echo "Create a many-block file"
_pwrite_byte 0x62 0 $((blksz * blks)) $testdir/file1 >> $seqres.full
_pwrite_byte 0x63 0 $blksz $testdir/file2 >> $seqres.full
_reflink_range $testdir/file2 0 $testdir/file1 $blksz $blksz >> $seqres.full
_scratch_cycle_mount noquota
echo "Inject error"
_scratch_inject_error "bmap_finish_one"
echo "Defrag the file"
$XFS_FSR_PROG -v -d $testdir/file1 >> $seqres.full 2>&1
echo "FS should be shut down, touch will fail"
touch $SCRATCH_MNT/badfs 2>&1 | _filter_scratch
echo "Remount to replay log" | tee /dev/ttyprintk
_scratch_unmount
_scratch_dump_log >> $seqres.full
_scratch_xfs_db -x -c 'agf 0' -c 'addr refcntroot' -c 'fuzz -d recs[1].startblock ones' >> $seqres.full
_scratch_xfs_db -x -c 'agf 0' -c 'addr refcntroot' -c p >> $seqres.full
# Suddenly enable quota to test if we can leak the quotacheck dquots!
_scratch_mount -o quota >> $seqres.full 2>&1
_scratch_unmount 2> /dev/null
rm -f ${RESULT_DIR}/require_scratch
echo "See if we leak"
_reload_fs_module "xfs"
# success, all done
status=0
exit
+9
View File
@@ -0,0 +1,9 @@
QA output created by 434
Format and mount
Create a many-block file
Inject error
Defrag the file
FS should be shut down, touch will fail
touch: cannot touch 'SCRATCH_MNT/badfs': Input/output error
Remount to replay log
See if we leak
Executable
+89
View File
@@ -0,0 +1,89 @@
#! /bin/bash
# FS QA Test No. 435
#
# Ensure that we don't leak dquots when CoW recovery fails.
#
# Corrupt the refcount btree to ensure that the CoW garbage collection
# (and therefore the mount) fail.
#
# On a subsequent mount attempt, we should be able to release the quota
# inodes when we're aborting the mount. We also should not leak dquots.
#
#-----------------------------------------------------------------------
# Copyright (c) 2017, Oracle and/or its affiliates. All Rights Reserved.
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License as
# published by the Free Software Foundation.
#
# This program is distributed in the hope that it would be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write the Free Software Foundation,
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
#-----------------------------------------------------------------------
seq=`basename "$0"`
seqres="$RESULT_DIR/$seq"
echo "QA output created by $seq"
here=`pwd`
tmp=/tmp/$$
status=1 # failure is the default!
trap "_cleanup; exit \$status" 0 1 2 3 15
_cleanup()
{
cd /
rm -rf "$tmp".*
}
# get standard environment, filters and checks
. ./common/rc
. ./common/filter
. ./common/attr
. ./common/reflink
. ./common/quota
. ./common/module
# real QA test starts here
_supported_os Linux
_supported_fs xfs
_require_loadable_fs_module "xfs"
_require_quota
_require_scratch_reflink
_require_cp_reflink
rm -f "$seqres.full"
echo "Format and mount"
_scratch_mkfs > "$seqres.full" 2>&1
_scratch_mount -o quota >> "$seqres.full" 2>&1
testdir="$SCRATCH_MNT/test-$seq"
blksz=65536
blks=3
mkdir "$testdir"
echo "Create a many-block file"
_pwrite_byte 0x62 0 $((blksz * blks)) $testdir/file1 >> $seqres.full
_pwrite_byte 0x63 0 $blksz $testdir/file2 >> $seqres.full
_reflink_range $testdir/file2 0 $testdir/file1 $blksz $blksz >> $seqres.full
echo "Remount to check recovery" | tee /dev/ttyprintk
_scratch_unmount
_scratch_xfs_db -x -c 'agf 0' -c 'addr refcntroot' -c 'fuzz -d recs[1].startblock ones' >> $seqres.full
_scratch_xfs_db -x -c 'agf 0' -c 'addr refcntroot' -c p >> $seqres.full
_scratch_mount -o quota >> $seqres.full 2>&1
_scratch_unmount 2> /dev/null
rm -f ${RESULT_DIR}/require_scratch
echo "See if we leak"
_reload_fs_module "xfs"
# success, all done
status=0
exit
+5
View File
@@ -0,0 +1,5 @@
QA output created by 435
Format and mount
Create a many-block file
Remount to check recovery
See if we leak
Executable
+105
View File
@@ -0,0 +1,105 @@
#! /bin/bash
# FS QA Test No. 436
#
# Ensure that we don't leak inodes when CoW recovery fails.
#
# Use xfs_fsr to inject bmap redo items in the log for a linked file and
# an unlinked file; and then corrupt the refcount btree to ensure that
# the CoW garbage collection (and therefore the mount) fail.
#
# On a subsequent mount attempt, we should be able to replay the bmap
# items for the linked and unlinked files without prematurely truncating
# the unlinked inode and without leaking the linked inode, and we should
# be able to release all the inodes when we're aborting the mount.
#
#-----------------------------------------------------------------------
# Copyright (c) 2017, Oracle and/or its affiliates. All Rights Reserved.
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License as
# published by the Free Software Foundation.
#
# This program is distributed in the hope that it would be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write the Free Software Foundation,
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
#-----------------------------------------------------------------------
seq=`basename "$0"`
seqres="$RESULT_DIR/$seq"
echo "QA output created by $seq"
here=`pwd`
tmp=/tmp/$$
status=1 # failure is the default!
trap "_cleanup; exit \$status" 0 1 2 3 15
_cleanup()
{
cd /
rm -rf "$tmp".*
}
# get standard environment, filters and checks
. ./common/rc
. ./common/filter
. ./common/attr
. ./common/reflink
. ./common/inject
. ./common/module
# real QA test starts here
_supported_os Linux
_supported_fs xfs
_require_loadable_fs_module "xfs"
_require_scratch_reflink
_require_cp_reflink
_require_command "$XFS_FSR_PROG" "xfs_fsr"
_require_xfs_io_error_injection "bmap_finish_one"
_require_xfs_scratch_rmapbt
rm -f "$seqres.full"
echo "Format and mount"
_scratch_mkfs > "$seqres.full" 2>&1
_scratch_mount -o noquota >> "$seqres.full" 2>&1
testdir="$SCRATCH_MNT/test-$seq"
blksz=65536
blks=3
mkdir "$testdir"
echo "Create a many-block file"
_pwrite_byte 0x62 0 $((blksz * blks)) $testdir/file1 >> $seqres.full
_pwrite_byte 0x63 0 $blksz $testdir/file2 >> $seqres.full
_reflink_range $testdir/file2 0 $testdir/file1 $blksz $blksz >> $seqres.full
_scratch_cycle_mount noquota
echo "Inject error"
_scratch_inject_error "bmap_finish_one"
echo "Defrag the file"
$XFS_FSR_PROG -v -d $testdir/file1 >> $seqres.full 2>&1
echo "FS should be shut down, touch will fail"
touch $SCRATCH_MNT/badfs 2>&1 | _filter_scratch
echo "Remount to replay log" | tee /dev/ttyprintk
_scratch_unmount
_scratch_dump_log >> $seqres.full
_scratch_xfs_db -x -c 'agf 0' -c 'addr refcntroot' -c 'fuzz -d recs[1].startblock ones' >> $seqres.full
_scratch_xfs_db -x -c 'agf 0' -c 'addr refcntroot' -c p >> $seqres.full
_scratch_mount -o noquota >> $seqres.full 2>&1
_scratch_unmount 2> /dev/null
rm -f ${RESULT_DIR}/require_scratch
echo "See if we leak"
_reload_fs_module "xfs"
# success, all done
status=0
exit
+9
View File
@@ -0,0 +1,9 @@
QA output created by 436
Format and mount
Create a many-block file
Inject error
Defrag the file
FS should be shut down, touch will fail
touch: cannot touch 'SCRATCH_MNT/badfs': Input/output error
Remount to replay log
See if we leak
+3
View File
@@ -431,3 +431,6 @@
431 auto quick dangerous
432 auto quick dir metadata
433 auto quick attr
434 auto quick clone fsr
435 auto quick clone
436 auto quick clone fsr