apfs/apfstests
0
0
Fork 0
mirror of https://github.com/linux-apfs/apfstests.git synced 2026-05-01 15:01:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

xfstests: aio-stress is calling pthread_join incorrectly

Browse Source 
The retval parameter to pthread_join() is a pointer to a pointer.
aio-stress is passing in a pointer to an int. This can result in a bus
error on sparc64 when the pointer is not aligned on a 64-bit boundary.
Since the return value is not used, it is simplest to pass a NULL
pointer instead.

This has been fixed in the LTP source:
https://github.com/linux-test-project/ltp/commit/981d33aad3b33c4625b88990fbf2fad5470d47e0

Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
This commit is contained in:
Dave Kleikamp
2013-06-18 17:57:00 -05:00
committed by Ben Myers
parent d897c0db68
commit a72607fada
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ltp/aio-stress.c
+1 -2
View File
@@ -1210,7 +1210,6 @@ typedef void * (*start_routine)(void *);
int run_workers(struct thread_info *t, int num_threads)
{
int ret;
int thread_ret;
int i;
for(i = 0 ; i < num_threads ; i++) {
@@ -1221,7 +1220,7 @@ int run_workers(struct thread_info *t, int num_threads)
}
}
for(i = 0 ; i < num_threads ; i++) {
ret = pthread_join(t[i].tid, (void *)&thread_ret);
ret = pthread_join(t[i].tid, NULL);
if (ret) {
perror("pthread_join");
exit(1);