generic: test for failure to unlock inode after chgrp fails with EDQUOT

This is a regression test that checks for xfs drivers that fail to
unlock the inode after changing the group id fails with EDQUOT.  It
pairs with "xfs: fix missing ILOCK unlock when xfs_setattr_nonsize fails
due to EDQUOT".

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
This commit is contained in:
Darrick J. Wong
2019-08-27 08:08:50 -07:00
committed by Eryu Guan
parent c9adaa192f
commit 3312c32e2c
3 changed files with 61 additions and 0 deletions
+58
View File
@@ -0,0 +1,58 @@
#! /bin/bash
# SPDX-License-Identifier: GPL-2.0+
# Copyright (c) 2019, Oracle and/or its affiliates. All Rights Reserved.
#
# FS QA Test No. 566
#
# Regression test for chgrp returning to userspace with ILOCK held after a hard
# quota error. This causes the filesystem to hang if kernel is not patched.
#
# This test goes with commit 1fb254aa983bf ("xfs: fix missing ILOCK unlock when
# xfs_setattr_nonsize fails due to EDQUOT")
seq=`basename $0`
seqres=$RESULT_DIR/$seq
echo "QA output created by $seq"
here=`pwd`
tmp=/tmp/$$
status=1 # failure is the default!
trap "_cleanup; exit \$status" 0 1 2 3 15
_cleanup()
{
cd /
}
# get standard environment, filters and checks
. ./common/rc
. ./common/quota
. ./common/filter
# real QA test starts here
_supported_os Linux
_supported_fs generic
_require_scratch
_require_quota
_require_user
rm -f $seqres.full
_qmount_option "grpquota"
_scratch_mkfs > $seqres.full
_qmount
dir="$SCRATCH_MNT/dummy"
mkdir -p $dir
chown $qa_user $dir
$XFS_QUOTA_PROG -x -f -c "limit -g bsoft=100k bhard=100k $qa_user" $SCRATCH_MNT
$XFS_IO_PROG -f -c 'pwrite -S 0x58 0 1m' $dir/foo >> $seqres.full
chown $qa_user "${dir}/foo"
_user_do "chgrp $qa_user ${dir}/foo" 2>&1 | _filter_scratch
ls -la ${dir} >> $seqres.full
$XFS_QUOTA_PROG -x -f -c 'report -hag' $SCRATCH_MNT >> $seqres.full
# success, all done
status=0
exit
+2
View File
@@ -0,0 +1,2 @@
QA output created by 566
chgrp: changing group of 'SCRATCH_MNT/dummy/foo': Disk quota exceeded
+1
View File
@@ -568,3 +568,4 @@
563 auto quick
564 auto quick copy_range
565 auto quick copy_range
566 auto quick quota metadata