apfs/apfstests
0
0
Fork 0
mirror of https://github.com/linux-apfs/apfstests.git synced 2026-05-01 15:01:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

resvtest.c: fix invalid use of sizeof()

Browse Source 
sizeof(pointer) will give you the size of a pointer, not the space
allocated to it.  I noticed this when gcc complained:

resvtest.c:76:33: warning: argument to 'sizeof' in 'memset' call is the same expression as the destination; did you mean to provide an explicit length? [-Wsizeof-pointer-memaccess]
  memset(writebuffer, 'A', sizeof(writebuffer));

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
Jeff Moyer
2014-06-18 09:29:57 +10:00
committed by Dave Chinner
parent c1ff85dfb6
commit 28f8c4c7fb
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/resvtest.c
+4 -4
View File
@@ -73,7 +73,7 @@ main(int argc, char **argv)
perror("open");
exit(1);
}
memset(writebuffer, 'A', sizeof(writebuffer));
memset(writebuffer, 'A', bsize);
unlink(filename);
writefd = open(filename, O_RDWR | O_CREAT | O_EXCL, S_IRUSR | S_IWUSR);
@@ -111,7 +111,7 @@ main(int argc, char **argv)
char *p;
int numerrors;
if (write(writefd, writebuffer, sizeof(writebuffer)) < 0) {
if (write(writefd, writebuffer, bsize) < 0) {
perror("write");
exit(1);
}
@@ -128,11 +128,11 @@ main(int argc, char **argv)
lseek(readfd, SEEK_SET, 0);
numerrors = 0;
for (j = 0; j < n; j++) {
if (read(readfd, readbuffer, sizeof(readbuffer)) < 0) {
if (read(readfd, readbuffer, bsize) < 0) {
perror("read");
exit(1);
}
for (i = 0; i < sizeof(readbuffer); i++) {
for (i = 0; i < bsize; i++) {
if (readbuffer[i] != 'A') {
fprintf(stderr,
"errors detected in file, pos: %d (%lld+%d), nwrites: %d [val=0x%x].\n",