_require_command: quote commands correctly

fixes 9435b92 common: _require_command needs to handle parameters

Also quoted $_command because _require_command may be called with an
empty $1 parameter, e.g.:
_require_command "$MY_UTIL_PROG" my_util  # but $MY_UTIL_PROG is empty

[ -x ] returns true.
[ -x "" ] returns false, as required here.

Signed-off-by: Omer Zilberberg <omzg@plexistor.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
This commit is contained in:
Omer Zilberberg
2015-05-26 12:51:57 +10:00
committed by Dave Chinner
parent 02f29ec573
commit 262442515c
+1 -1
View File
@@ -1307,7 +1307,7 @@ _require_command()
fi
_command=`echo "$1" | awk '{ print $1 }'`
if [ ! -x $command ]; then
if [ ! -x "$_command" ]; then
_notrun "$_name utility required, skipped this test"
fi
}