Makefile: fix bug when running make install under tests/* directory

The TESTS_DIR value is defined in TOPDIR makefile, it is empty here.
So running make install on ext4 directory will get the following info:

../../install-sh -o root -g root -m 755 -d /var/lib/xfstests//ext4

We can see they aren't installed under /var/lib/xfstests/tests/ext4 directory.
Fix this by moving TESTS_DIR definition to include/builddefs.in file.

Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
Reviewed-by: Eryu Guan <guaneryu@gmail.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
This commit is contained in:
Yang Xu
2021-06-30 09:52:05 +08:00
committed by Eryu Guan
parent c9419e671d
commit 23e3bf7e28
2 changed files with 3 additions and 2 deletions
+2 -1
View File
@@ -21,6 +21,8 @@ HAVE_BUILDDEFS = $(shell test -f $(TOPDIR)/include/builddefs && echo yes || echo
ifeq ($(HAVE_BUILDDEFS), yes)
include $(TOPDIR)/include/builddefs
else
export TESTS_DIR = tests
endif
SRCTAR = $(PKG_NAME)-$(PKG_VERSION).tar.gz
@@ -40,7 +42,6 @@ endif
LIB_SUBDIRS = include lib
TOOL_SUBDIRS = ltp src m4 common
export TESTS_DIR = tests
SUBDIRS = $(LIB_SUBDIRS) $(TOOL_SUBDIRS) $(TESTS_DIR)
default: include/builddefs
+1 -1
View File
@@ -35,7 +35,7 @@ PKG_VERSION = @pkg_version@
PKG_PLATFORM = @pkg_platform@
PKG_DISTRIBUTION= @pkg_distribution@
PKG_LIB_DIR = $(DESTDIR)@exec_prefix@/@pkg_name@
TESTS_DIR = tests
CC = @cc@
AWK = @awk@