generic/556: Fix rename test

Casefold rename test should check if renaming a file to an equivalent
name fails as expect (e.g. renaming from "file.txt" to "FILE.TXT") and
`mv` correctly identifies that those names refers to the same file.
Currently, the test doesn't do what is expected given that it doesn't
have the file to be renamed, and `mv` returns "No such file or
directory". Fix that by creating test files and checking the correct
output.

Fixes: 12b7dddbc2 ("generic: Add tests for filename casefolding feature")
Signed-off-by: André Almeida <andrealmeid@collabora.com>
Reviewed-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
This commit is contained in:
André Almeida
2021-03-24 19:48:17 -03:00
committed by Eryu Guan
parent 4243ee6a3d
commit 1fc1737959
2 changed files with 4 additions and 2 deletions
+3 -1
View File
@@ -341,8 +341,10 @@ test_file_rename()
mkdir -p ${basedir}
_casefold_set_attr ${basedir}
touch ${basedir}/rename
# Move to an equivalent name should not work
mv ${basedir}/rename ${basedir}/rename 2>&1 | \
mv ${basedir}/rename ${basedir}/RENAME 2>&1 | \
_filter_scratch
_casefold_check_exact_name ${basedir} "rename" || \
+1 -1
View File
@@ -5,7 +5,7 @@ SCRATCH_MNT/casefold_flag_removal Casefold
SCRATCH_MNT/casefold_flag_removal Casefold
SCRATCH_MNT/flag_inheritance/d1/d2/d3 Casefold
SCRATCH_MNT/symlink/ind1/TARGET
mv: cannot stat 'SCRATCH_MNT/rename/rename': No such file or directory
mv: 'SCRATCH_MNT/rename/rename' and 'SCRATCH_MNT/rename/RENAME' are the same file
# file: SCRATCH_MNT/xattrs/x
user.foo="bar"