ada/cpython
0
0
Fork 0
mirror of https://github.com/AdaCore/cpython.git synced 2026-02-12 12:57:15 -08:00
Code Issues Packages Projects Releases Wiki Activity

bpo-42014: shutil.rmtree: call onerror with correct function (GH-22585)

Browse Source 
The onerror is supposed to be called with failed function, but in this case lstat is wrongly used instead of open.

Not sure if this needs bug or not...

Automerge-Triggered-By: GH:hynek
This commit is contained in:
Michal Čihař
2020-11-10 17:06:02 +01:00
committed by GitHub
parent 3eb2846225
commit e59b2deffd
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/shutil.py
View File

@@ -711,7 +711,7 @@ def rmtree(path, ignore_errors=False, onerror=None):
try:
fd = os.open(path, os.O_RDONLY)
except Exception:
onerror(os.lstat, path, sys.exc_info())
onerror(os.open, path, sys.exc_info())
return
try:
if os.path.samestat(orig_st, os.fstat(fd)):

1
Misc/NEWS.d/next/Library/2020-11-10-15-40-56.bpo-42014.ShM37l.rst Normal file
View File

@@ -0,0 +1 @@
The ``onerror`` callback from ``shutil.rmtree`` now receives correct function when ``os.open`` fails.