From ed54f97909f25d09a53bae05834b5d73af9a8057 Mon Sep 17 00:00:00 2001 From: jpirnay Date: Thu, 16 Apr 2026 00:52:29 +0200 Subject: [PATCH] fix: Fix ghosting on exit of BMPViewer (#1432) ## Summary * **What is the goal of this PR?** After displaying an image via the filebrowser ghosting artifacts remained on the screen * **What changes are included?** ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< NO >**_ --- src/activities/util/BmpViewerActivity.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/activities/util/BmpViewerActivity.cpp b/src/activities/util/BmpViewerActivity.cpp index 62a02ce67..37fa8fe19 100644 --- a/src/activities/util/BmpViewerActivity.cpp +++ b/src/activities/util/BmpViewerActivity.cpp @@ -61,7 +61,7 @@ void BmpViewerActivity::onEnter() { GUI.drawButtonHints(renderer, labels.btn1, labels.btn2, labels.btn3, labels.btn4); // Single pass for non-grayscale images - renderer.displayBuffer(HalDisplay::FULL_REFRESH); + renderer.displayBuffer(HalDisplay::HALF_REFRESH); } else { // Handle file parsing error @@ -69,7 +69,7 @@ void BmpViewerActivity::onEnter() { renderer.drawCenteredText(UI_10_FONT_ID, pageHeight / 2, "Invalid BMP File"); const auto labels = mappedInput.mapLabels(tr(STR_BACK), "", "", ""); GUI.drawButtonHints(renderer, labels.btn1, labels.btn2, labels.btn3, labels.btn4); - renderer.displayBuffer(HalDisplay::FAST_REFRESH); + renderer.displayBuffer(HalDisplay::HALF_REFRESH); } file.close(); @@ -79,14 +79,14 @@ void BmpViewerActivity::onEnter() { renderer.drawCenteredText(UI_10_FONT_ID, pageHeight / 2, "Could not open file"); const auto labels = mappedInput.mapLabels(tr(STR_BACK), "", "", ""); GUI.drawButtonHints(renderer, labels.btn1, labels.btn2, labels.btn3, labels.btn4); - renderer.displayBuffer(HalDisplay::FULL_REFRESH); + renderer.displayBuffer(HalDisplay::HALF_REFRESH); } } void BmpViewerActivity::onExit() { Activity::onExit(); renderer.clearScreen(); - renderer.displayBuffer(HalDisplay::FAST_REFRESH); + renderer.displayBuffer(HalDisplay::HALF_REFRESH); } void BmpViewerActivity::loop() {