mirror of
https://gitlab.winehq.org/wine/wine-staging.git
synced 2024-11-21 16:46:54 -08:00
53 lines
1.7 KiB
Diff
53 lines
1.7 KiB
Diff
From 7f8f6898788adbb31318aaead591b129138288c2 Mon Sep 17 00:00:00 2001
|
|
From: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
|
|
Date: Wed, 18 Apr 2018 03:55:16 +0000
|
|
Subject: [PATCH] wintrust: Add parameter check in WTHelperGetProvCertFromChain
|
|
|
|
Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
|
|
---
|
|
dlls/wintrust/tests/softpub.c | 9 +++++++++
|
|
dlls/wintrust/wintrust_main.c | 2 +-
|
|
2 files changed, 10 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/dlls/wintrust/tests/softpub.c b/dlls/wintrust/tests/softpub.c
|
|
index 25d458faad7..998cce85380 100644
|
|
--- a/dlls/wintrust/tests/softpub.c
|
|
+++ b/dlls/wintrust/tests/softpub.c
|
|
@@ -1312,6 +1312,14 @@ static void test_get_known_usages(void)
|
|
"expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError());
|
|
}
|
|
|
|
+static void test_WTHelperGetProvCertFromChain(void)
|
|
+{
|
|
+ CRYPT_PROVIDER_CERT *cert;
|
|
+
|
|
+ cert = WTHelperGetProvCertFromChain(NULL, 0);
|
|
+ ok(!cert, "got certificate\n");
|
|
+}
|
|
+
|
|
START_TEST(softpub)
|
|
{
|
|
InitFunctionPtrs();
|
|
@@ -1320,4 +1328,5 @@ START_TEST(softpub)
|
|
test_wintrust();
|
|
test_wintrust_digest();
|
|
test_get_known_usages();
|
|
+ test_WTHelperGetProvCertFromChain();
|
|
}
|
|
diff --git a/dlls/wintrust/wintrust_main.c b/dlls/wintrust/wintrust_main.c
|
|
index 33695008b24..60c633e5abf 100644
|
|
--- a/dlls/wintrust/wintrust_main.c
|
|
+++ b/dlls/wintrust/wintrust_main.c
|
|
@@ -782,7 +782,7 @@ CRYPT_PROVIDER_CERT * WINAPI WTHelperGetProvCertFromChain(
|
|
|
|
TRACE("(%p %ld)\n", pSgnr, idxCert);
|
|
|
|
- if (idxCert >= pSgnr->csCertChain || !pSgnr->pasCertChain)
|
|
+ if (!pSgnr || idxCert >= pSgnr->csCertChain || !pSgnr->pasCertChain)
|
|
return NULL;
|
|
cert = &pSgnr->pasCertChain[idxCert];
|
|
TRACE("returning %p\n", cert);
|
|
--
|
|
2.34.1
|
|
|