From a05143287166a5b8730bedf577e1f6d10490da47 Mon Sep 17 00:00:00 2001 From: Zebediah Figura Date: Sun, 28 Apr 2024 18:56:27 -0500 Subject: [PATCH] Pipelight: Remove patch set. Even if one asserts that Silverlight is worth supporting in any capacity (which I am not for the moment taking any position on), Pipelight is unusable without downgrading Firefox. As Erich put it to me, "the point of Pipelight was to not have to run the entire browser in Wine," but now a user would have to go to at least such an extent anyway. And, of course, nothing here is useful outside of Pipelight, or if it is, we want to explicitly know about it so that we can document and properly support those knobs. --- ...X11DRV_FLUSH_GDI_DISPLAY-ExtEscape-c.patch | 41 ----------------- ...se-minimum-SetTimer-interval-to-5-ms.patch | 25 ---------- ...cate-direct-rendering-through-OpenGL.patch | 46 ------------------- patches/Pipelight/definition | 2 - 4 files changed, 114 deletions(-) delete mode 100644 patches/Pipelight/0001-winex11-Implement-X11DRV_FLUSH_GDI_DISPLAY-ExtEscape-c.patch delete mode 100644 patches/Pipelight/0002-user32-Decrease-minimum-SetTimer-interval-to-5-ms.patch delete mode 100644 patches/Pipelight/0004-winex11.drv-Indicate-direct-rendering-through-OpenGL.patch delete mode 100644 patches/Pipelight/definition diff --git a/patches/Pipelight/0001-winex11-Implement-X11DRV_FLUSH_GDI_DISPLAY-ExtEscape-c.patch b/patches/Pipelight/0001-winex11-Implement-X11DRV_FLUSH_GDI_DISPLAY-ExtEscape-c.patch deleted file mode 100644 index 95f24619..00000000 --- a/patches/Pipelight/0001-winex11-Implement-X11DRV_FLUSH_GDI_DISPLAY-ExtEscape-c.patch +++ /dev/null @@ -1,41 +0,0 @@ -From 32ae090ad4a99862a420cfe44847d8e2905cdde7 Mon Sep 17 00:00:00 2001 -From: Sebastian Lackner -Date: Sat, 21 Dec 2013 23:57:02 +0100 -Subject: winex11: Implement X11DRV_FLUSH_GDI_DISPLAY ExtEscape command - ---- - dlls/winex11.drv/init.c | 3 +++ - dlls/winex11.drv/x11drv.h | 3 ++- - 2 files changed, 5 insertions(+), 1 deletion(-) - -diff --git a/dlls/winex11.drv/init.c b/dlls/winex11.drv/init.c -index 5a7d316..68d3f96 100644 ---- a/dlls/winex11.drv/init.c -+++ b/dlls/winex11.drv/init.c -@@ -440,6 +440,9 @@ static INT X11DRV_ExtEscape( PHYSDEV dev, INT escape, INT in_count, LPCVOID in_d - return TRUE; - } - break; -+ case X11DRV_FLUSH_GDI_DISPLAY: -+ XFlush( gdi_display ); -+ return TRUE; - default: - break; - } -diff --git a/dlls/winex11.drv/x11drv.h b/dlls/winex11.drv/x11drv.h -index 9008db6..85dd2a5 100644 ---- a/dlls/winex11.drv/x11drv.h -+++ b/dlls/winex11.drv/x11drv.h -@@ -277,7 +277,8 @@ enum x11drv_escape_codes - X11DRV_GET_DRAWABLE, /* get current drawable for a DC */ - X11DRV_START_EXPOSURES, /* start graphics exposures */ - X11DRV_END_EXPOSURES, /* end graphics exposures */ -- X11DRV_FLUSH_GL_DRAWABLE /* flush changes made to the gl drawable */ -+ X11DRV_FLUSH_GL_DRAWABLE, /* flush changes made to the gl drawable */ -+ X11DRV_FLUSH_GDI_DISPLAY /* flush the gdi display */ - }; - - struct x11drv_escape_set_drawable --- -1.7.9.5 - diff --git a/patches/Pipelight/0002-user32-Decrease-minimum-SetTimer-interval-to-5-ms.patch b/patches/Pipelight/0002-user32-Decrease-minimum-SetTimer-interval-to-5-ms.patch deleted file mode 100644 index 073009aa..00000000 --- a/patches/Pipelight/0002-user32-Decrease-minimum-SetTimer-interval-to-5-ms.patch +++ /dev/null @@ -1,25 +0,0 @@ -From ebe00ceb4f2d24f2611dbec87486d6597a3466a9 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Michael=20M=C3=BCller?= -Date: Fri, 2 May 2014 20:46:19 +0200 -Subject: [PATCH] user32: Decrease minimum SetTimer interval to 5 ms. (try 2) - ---- - dlls/win32u/message.c | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/dlls/win32u/message.c b/dlls/win32u/message.c -index d2909339983..337d4a2cc1d 100644 ---- a/dlls/win32u/message.c -+++ b/dlls/win32u/message.c -@@ -3975,7 +3975,7 @@ UINT_PTR WINAPI NtUserSetTimer( HWND hwnd, UINT_PTR id, UINT timeout, TIMERPROC - - if (proc) winproc = alloc_winproc( (WNDPROC)proc, TRUE ); - -- timeout = min( max( USER_TIMER_MINIMUM, timeout ), USER_TIMER_MAXIMUM ); -+ timeout = min( max( 5, timeout ), USER_TIMER_MAXIMUM ); - - SERVER_START_REQ( set_win_timer ) - { --- -2.42.0 - diff --git a/patches/Pipelight/0004-winex11.drv-Indicate-direct-rendering-through-OpenGL.patch b/patches/Pipelight/0004-winex11.drv-Indicate-direct-rendering-through-OpenGL.patch deleted file mode 100644 index 321f4a09..00000000 --- a/patches/Pipelight/0004-winex11.drv-Indicate-direct-rendering-through-OpenGL.patch +++ /dev/null @@ -1,46 +0,0 @@ -From a9cf27a493697c97249ce526483d25c871c053c4 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Michael=20M=C3=BCller?= -Date: Sun, 1 Jun 2014 22:51:32 +0200 -Subject: [PATCH] winex11.drv: Indicate direct rendering through OpenGL - extension - ---- - dlls/winex11.drv/opengl.c | 7 +++++-- - 1 file changed, 5 insertions(+), 2 deletions(-) - -diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c -index 92555841f71..71e7ecbcf7c 100644 ---- a/dlls/winex11.drv/opengl.c -+++ b/dlls/winex11.drv/opengl.c -@@ -410,6 +410,7 @@ static int GLXErrorHandler(Display *dpy, XErrorEvent *event, void *arg) - static BOOL X11DRV_WineGL_InitOpenglInfo(void) - { - static const char legacy_extensions[] = " WGL_EXT_extensions_string WGL_EXT_swap_control"; -+ static const char direct_extension[] = " WINE_EXT_direct_rendering"; - - int screen = DefaultScreen(gdi_display); - Window win = 0, root = 0; -@@ -465,16 +466,18 @@ static BOOL X11DRV_WineGL_InitOpenglInfo(void) - } - gl_renderer = (const char *)opengl_funcs.gl.p_glGetString(GL_RENDERER); - gl_version = (const char *)opengl_funcs.gl.p_glGetString(GL_VERSION); -+ glx_direct = pglXIsDirect(gdi_display, ctx); - str = (const char *) opengl_funcs.gl.p_glGetString(GL_EXTENSIONS); -- glExtensions = malloc( strlen(str) + sizeof(legacy_extensions) ); -+ glExtensions = malloc( strlen(str)+sizeof(legacy_extensions)+sizeof(direct_extension) ); - strcpy(glExtensions, str); - strcat(glExtensions, legacy_extensions); -+ if (glx_direct) -+ strcat(glExtensions, direct_extension); - - /* Get the common GLX version supported by GLX client and server ( major/minor) */ - pglXQueryVersion(gdi_display, &glxVersion[0], &glxVersion[1]); - - glxExtensions = pglXQueryExtensionsString(gdi_display, screen); -- glx_direct = pglXIsDirect(gdi_display, ctx); - - TRACE("GL version : %s.\n", gl_version); - TRACE("GL renderer : %s.\n", gl_renderer); --- -2.35.1 - diff --git a/patches/Pipelight/definition b/patches/Pipelight/definition deleted file mode 100644 index f52de76d..00000000 --- a/patches/Pipelight/definition +++ /dev/null @@ -1,2 +0,0 @@ -Fixes: Reduced SetTimer minimum value from 10 ms to 5 ms (improves Silverlight framerates) -Fixes: Other Pipelight-specific enhancements